mterryGuh QML01:37
=== _salem is now known as salem_
=== jono is now known as Guest576
=== salem_ is now known as _salem
Mirvbregma: FYI Unity7 has a blocker, failing to build on armhf https://bugs.launchpad.net/unity/+bug/120951206:57
ubot5Launchpad bug 1209512 in Unity "FTBFS on armhf: ERROR: Library '/system/lib/libGLESv2.so' not found" [High,New]06:57
mhr3_Saviq, could i get you to have a rough look at https://code.launchpad.net/~mhr3/unity8/scopes-category-overriding/+merge/179015 ?08:05
mhr3_just to make sure it's going in the right direction08:05
tsdgeosdoes the vpn work for you?08:06
Saviqtsdgeos, +108:06
tsdgeosi can't connect :-/08:07
tsdgeosah connceted now08:07
tsdgeosjust took more than usual08:07
Saviqmhr3_, not liking the Repeaters in DashApps.qml - would probably go for a ProxyModel08:08
mhr3_you can transform the data with ProxyModel?08:08
Saviqmhr3_, sure you can08:08
tsdgeoswe killed the X server in an autopilot test08:08
mhr3_good to know :)08:08
Saviqmhr3_, and we should be able to get rid of "Available for download", no? the click scope should be providing it already?08:09
tsdgeosi like the "mieq is *NOT* the cause.  It is a victim." debug line08:09
mhr3_Saviq, i think they're perfectly capable of removing one line once it's in :)08:09
Saviqmhr3_, ;)08:10
Saviqtsdgeos, :D08:10
Saviqmhr3_, other than that - yeah, looking good08:11
mhr3_Saviq, i'm unsure whether the running apps will work, couldn't test it on the phone08:12
Saviqmhr3_, re: reparenting - might be tricky, we probably should "undo" the override when it's destroyed, instead08:13
Saviqmhr3_, should work, no reason why it wouldn't08:13
mhr3_Saviq, noting that, will remind you of it in a few days when you'll scream at me :P08:14
mhr3_Saviq, so i'll port also home to use the real thing08:15
Saviqmhr3_, yup08:17
mhr3_Saviq, any pointers how to do the transform with ProxyModel?08:18
Saviqmhr3_, just implement your own data()08:18
mhr3_you can do that in qml?08:19
Saviqmhr3_, no08:19
mhr3_another good to know thing :P08:19
mhr3_then i don't like that08:19
Saviqmhr3_, I don't like the Repeater more ;)08:19
mhr3_Saviq, come on, it's mocked data08:19
Saviqmhr3_, not for running apps i isn't08:20
Saviqmhr3_, when they get reordered08:20
Saviqmhr3_, or added / removed08:20
Saviqmhr3_, the Repeater approach will just bite you in the a$$08:20
mhr3_Saviq, it's not using the repeater for the running apps08:20
mhr3_just the mocked freq and downloadable08:20
Saviqmhr3_, ah, so we're targetting the "real scope will already be there" case?08:21
mhr3_well not exactly, that's why i said i'm unsure if the running apps will work :P08:21
Saviqmhr3_, they would, with a Proxy ;)08:22
mhr3_then i'll need to update also the renderer, right?08:23
mhr3_meaning "Apps/RunningApplicationsGrid.qml"08:23
Saviqmhr3_, yeah, to use the real scope roles08:24
Saviqmhr3_, but that would need to happen for the "real running apps" scope anyway08:24
Saviqmhr3_, so a good thing08:24
mhr3_right, see, i almost broke running apps :P08:24
Saviqmhr3_, I'd really go for a c++ ProxyModel or two, they would need to be maybe 50 lines each08:25
Saviqmhr3_, well, for the mock data08:25
Saviqmhr3_, just make the mocks have the "real scope roles" straight away08:26
Saviqmhr3_, no need for a Proxy or the Repeater - they're just ListModels with some ListElements inside them08:26
mhr3_also true, sounds easier08:26
Saviqmhr3_, so as long as they have the same roles, you just pass it straight in08:26
tsdgeosSaviq: in https://code.launchpad.net/~saviq/unity8/reenable-battery-drag-test/+merge/178911 when you say "make sure it works on devices", you mean running the autopilot test on the Nexus4?08:26
tsdgeosalso the Nexus10 or one should be enough?08:27
Saviqtsdgeos, would be good for N10 as well08:28
tsdgeosok, me tries in both places08:28
Saviqtsdgeos, should be just a case of "grab the output.zip; phablet-run-test -n unity8"08:28
Saviqinstalling the stuff from the .zip on the device first, of course08:28
tsdgeosi probably need to flash the Nexus10 first08:29
tsdgeosit's ooold08:29
Twenty-threehi, i think a recent kernel update was incompatible with my graphics card or something, someone Dr_willis suggested trying to create a new user and testing whether the problem persisted, i tried that and the problem persisted, i am not sure how to restore unity08:35
tsdgeosSaviq: obviously our autopilot packages miss some deps08:40
Saviqtsdgeos, apt-get -f install08:40
tsdgeosi'm getting: RuntimeError: Unable to instantiate any backends08:40
Saviqtsdgeos, but actually08:40
tsdgeosSaviq: did that already08:40
Saviqtsdgeos, phablet-test-run -i08:40
tsdgeosand after that i had to manually install python-autopilot08:41
Saviqtsdgeos, that will install all that's needed on the device for autopilot08:41
tsdgeosand now i'm getting that08:41
Saviqtsdgeos, yeah, phablet-test-run -i will do stuff08:41
Saviqtsdgeos, need ssh first, though08:41
tsdgeosgot that08:41
Saviqbug #120524408:41
ubot5bug 1205244 in Phablet Tools "phablet-test-run should install ssh if it requires it" [Undecided,Confirmed] https://launchpad.net/bugs/120524408:41
larsuI've MRed the themeiconprovider to the sdk, is there a way to make another module depend on that?09:02
larsuI don't want to duplicate the code between unitymenumodel and the sdk09:02
larsuand I'm sure it might be problematic when two modules add icon providers with the same name09:02
Saviqlarsu, why two with the same name?09:06
larsuSaviq: if I were gto leave the provider in unitymenumodel09:07
Saviqtsdgeos, it should've been 12 tests with the reenabled test09:07
larsuand somebody links against that and the sdk09:07
tsdgeosSaviq: :S09:08
Saviqtsdgeos, or waity09:09
Saviqtsdgeos, no, 1109:09
Saviqtsdgeos, it was skipped before, and now it passes, that's fine :)09:09
dednickSaviq: ping. we may have run into a bit of a snag with this glib event loop issue i was having with indicators.09:10
Saviqdednick, :/09:11
Saviqdednick, how bad?09:11
dednickSaviq: https://bugreports.qt-project.org/browse/QTBUG-3285909:11
dednickSaviq: "Do we even want to support calling glib directly?"09:11
dednickSaviq: "I'd say that running GMainLoop directly is out-of-scope."09:11
larsudednick: please don't approve ted's indicator-signals merge yet. I've had an unresolved discussion with him and we've decided to continue this discussion later and focus on other work right now.09:12
dednicklarsu: ok09:12
tsdgeoslarsu: can you comment that on the MR itself ? i was roaming on that MR and almost approve it :D09:12
dednicklarsu: think it needs some work anyway09:12
dednickSaviq: i do have a potential solution, but it involves work for every instance we have a glib callback calling back into qt.09:13
larsudednick: if you ask me, it needs to die :)09:13
dednickSaviq: essentially need to send a custom QEvent every time09:13
dednickSaviq: which is how qt handles window events and such.09:13
larsutsdgeos: it was quite a heated discussion, I wanted a low-profile way to stall this a bit until I have time to talk to him again09:14
Saviqdednick, re: the comments, I think we need to restate that the g_ thing is just the simplest way to reproduce, and not how we're trying to use it09:16
dednickSaviq: fyi, this problem is valid for anywhere else we use glib. which means probaly means everything from unitycore::scopes.09:17
Saviqdednick, yeah, I understand09:17
Saviqdednick, hmm but wait, the problem is that we actually *do* use glib directly in there?09:17
dednickSaviq: yes09:17
tsdgeosNexus 10 is not flipped?09:17
Saviqtsdgeos, yes it is09:18
dednickSaviq: we're connecting directly to gmenumodel09:18
tsdgeosah wait phablet-flash failed09:18
Saviqdednick, right09:18
tsdgeoswell it' a bit lame they claim glib event loop integration09:19
tsdgeosif the event loop integration doesnt' work :D09:19
dednickSaviq:  I think their point is that we should be sending events back through the qt event system.09:19
SaviqMacSlow, I reproduced the autopilot failure when running the tests on device09:19
MacSlowSaviq, I'll look into it later today.09:21
SaviqMacSlow, thanks09:21
MacSlowSaviq, I already switch the branch back to "wip" to avoid load on the jenkins-metal09:22
SaviqMacSlow, yeah, saw that09:22
tsdgeosha, i'm 0% of battery, that's why flashing fails :D09:23
MacSlowSaviq, currently back on the UI-side of things regarding the "extended snap-decisions"09:23
SaviqMacSlow, yup09:23
Saviqlarsu, btw, did you have time to write the menumodel vs. notifications email?09:24
larsuSaviq: typing right now :)09:24
Saviqlarsu, thanks09:24
MacSlowlarsu, looking forward to it09:25
Saviqdednick, the QEvent thing would be a workaround, then, while incrementing the loop level would be a solution, right?09:27
dednickSaviq: I think we would need to increment the loop level in our code (in the glib callbacks). I'm not sure there's a way around it. Problem is that the both routes (to glib handler, and to delete) pass through the same code.09:31
dednickBecause all the event handling goes through the glib event dispatcher.09:32
dednickSaviq: unfortunately the QEvent is the actual solution in this case it would seem. I think that's how it was intended to work. Unless i can find a better option.09:33
Saviqdednick, that sounds like a substantial amount of work, too?09:34
dednickSaviq: i'm looking into it now, but most likely quite a bit.09:34
dednickcustom event types for each different callback.09:34
MacSlownic-doffay, hey there...09:35
nic-doffayMacSlow, what's up?09:36
MacSlownic-doffay, I'm trying to get an expanded OptionSelector into a flickable (with a scrollbar) ... without any success sofar... it that possible at all?09:36
dednickSaviq: the only other solution i can potentially think of is to pull all the custom glib stuff onto a different loop. But I'm not sure how possible that would be, or how much work.09:36
seb128MacSlow, where did you find "OptionSelector"?09:37
* seb128 needs it but though that didn't land yet09:37
nic-doffayMacSlow, I haven't tried a scrollbar but I've put it in a flickable without issue.09:37
Saviqseb128, yeah, not landed yet09:37
MacSlowseb128, it's in a not-yet-merged branch... I'm trying to get a feel for this... as it'll be needed in the wifi-ap selection dialog/snap-decision09:38
MacSlownic-doffay, ok... I keep trying09:38
nic-doffayMacSlow, I'm going to pastebin you some of my filters code.09:39
MacSlownic-doffay, ok... thanks09:39
nic-doffayIt has scrolling too.09:39
nic-doffayMacSlow, ^09:40
Saviqdednick, so if I understand correctly, we're fooked regardless which route we'll go, and it's not just something that Qt guys say they don't care about09:40
Saviqdednick, so there's no "easy" fix for Qt itself09:40
nic-doffayMacSlow, you'll see there there are three OptionSelectors in a column which is in a flickable.09:40
MacSlowseb128, if you want to give it a try... lp:~nicolas-doffay/ubuntu-ui-toolkit/list-item-option-selector09:40
MacSlownic-doffay, great.. thanks!09:40
dednickSaviq: yes, from my understanding of the issue.09:40
nic-doffayMacSlow, np!09:41
seb128MacSlow, thanks09:41
seb128MacSlow, nic-doffay: when is that likely to land?09:42
Saviqdednick, :|09:42
* seb128 wants to start using it in system settings09:42
seb128our current hacked valueselector suck09:42
dednickSaviq: i may have a very dodgy workaround for the cpu problem that we can use for the moment while i work on the issue. Will only work while we have the proxy to qmenumodel though.09:42
MacSlowseb128, when you use it... (without installing it) be sure to use qmlscene -I path/to/modules ... and "import Ubuntu.Components.ListItems 0.1" so you can use OptionSelector in your QML-code.09:43
nic-doffayseb128, got feedback from design yesterday.09:44
MacSlowseb128, with "path/to/modules" being where ever you put nic-doffay's list-item-option-selector/modules09:44
nic-doffayBasically I need to ensure there's a pause between switching the chevron and tick then it's landable.09:44
seb128MacSlow, thanks09:44
nic-doffayseb128, I'm unsure when it will be reviewed though, obviously I'll push for asap.09:44
seb128nic-doffay, great, soon then09:44
Saviqdednick, yeah, would be good to have something temporary, even09:50
tsdgeosthe tablet has regressed09:55
tsdgeoscan't seem to be able to run the sidestage apps if there are no mainstage apps open09:55
tsdgeoswell, you can run it09:57
tsdgeosit just doesn't paint09:57
tsdgeosSaviq: want me to open a bug?09:57
Saviqtsdgeos, please do09:57
tsdgeoswhat was the file that has the build number?09:59
* tsdgeos always forgets09:59
MacSlownic-doffay, I can't get your example to work fully... I can expand option-selectors, but I can't scroll through them10:02
nic-doffayMacSlow, you mean with the flickable?10:02
MacSlownic-doffay, yes10:02
nic-doffayMacSlow, weird, I didn't have any issues.10:03
nic-doffayYou can check my whole branch if you want.10:03
nic-doffayMacSlow, it could be because it's disabled.10:03
nic-doffayMacSlow,  interactive: false10:03
MacSlownic-doffay, I changed those of course10:03
nic-doffayMacSlow, then I have no idea, sounds weird.10:04
MacSlowI tried to add it as an element in my dialog... but there it just didn't show up... I 'm currently using it stand-alone (also set a fixed width and no longer parent.width)10:05
MacSlownic-doffay, also disabled (commented out) the anchors to be able to use it stand-alone.10:06
nic-doffaySaviq, I've modified the CrossFadeImage a fair amount, think we'll have to get Kaleo in on this review now too.10:23
nic-doffayIt might be best just to put all that functionality in the OptionSelector and not use CrossFadeImage, or create a new SDK component.10:23
MacSlownic-doffay, so I went from this http://ubuntuone.com/3plX5yStNdhHqFS4yLqtO4 to this http://ubuntuone.com/1BZOL12QuErfCfwjq5gIBa which is already a bit closer to that mpt has in mind... but scrolling I could not get going yet... also the icons per entry are not supported in the option-selector as far as I can tell10:29
MacSlownic-doffay, that scribble is all the visual-spec I have atm10:29
* mpt applauds10:29
nic-doffayMacSlow, nope it doesn't support the icon.10:30
nic-doffayThis is what will need to be amended.10:30
MacSlowmpt, well there's much much left to be done (on the UI-side alone)10:30
mptsure :-)10:30
nic-doffayMacSlow, I think it's probably going to change a hell of a lot.10:30
MacSlownic-doffay, yeah... I remember you mentioned there are still discussions gonig on with Design about details (such as this I assume)10:30
nic-doffayI'm wondering if it's worth even using an OptionSelector.10:30
nic-doffayOr at least just copying and pasting the relevant code.10:31
nic-doffayMacSlow, like the selection stuff etc.10:31
MacSlownic-doffay, at least I can actually select elements in the list now... that didn't work with the first iteration http://ubuntuone.com/3plX5yStNdhHqFS4yLqtO410:32
nic-doffayMacSlow, it looks awesome!10:33
tsdgeosouch, my X suddenly restarted out of nowhere :-/10:49
mlankhorstvalgrind :-)10:51
dednickSaviq: https://code.launchpad.net/~nick-dedekind/unity8/indicators-cpuburn.QTBUG-32859/+merge/17916111:20
=== MacSlow is now known as MacSlow|lunch
Saviqdednick, +1 on greyback's comment, and FWIW I don't think that's a huge hack11:40
Saviqnic-doffay, you should make the CrossFadeImage mods a separate merge request, though11:40
Saviqnic-doffay, and it's the sdk guys that need to review anyway, I'm only looking at it from a visual / functional perspective11:41
dednickSaviq: yeah, but it's kind of a sidestep just because we're using a proxy. the problem will re-appear when we change to unitymenumodel if not fixed.11:41
Saviqdednick, right11:41
dednickSaviq: comment added.11:44
Saviqdednick, so that's bug #1206991 / bug #1183065 that should be helped with with that?11:52
ubot5bug 1206991 in Unity 8 "Frequent CPU hogging" [Critical,Incomplete] https://launchpad.net/bugs/120699111:53
ubot5bug 1183065 in touch-preview-images "Occassional severe battery drain" [High,Confirmed] https://launchpad.net/bugs/118306511:53
dednickSaviq: yeah11:53
=== alan_g is now known as alan_g|lunch
Saviqdednick, awesome11:54
Saviqdednick, less awesome that it's not a proper fix, but still awesome, and great investigation, thanks11:55
dednickSaviq: my pleasure. i have a much more detailed understanding of the qt event loop now. For the next few days until i forget it all at least.11:57
=== MacSlow|lunch is now known as MacSlow
Saviqdednick, we seem to be getting more and more of https://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/975/console12:42
Saviqdednick, which gets stuck in test_rightEdgeDrag()12:42
Saviqdednick, you were looking at Daniel's edge drags / velocity calculator12:42
Saviqdednick, could you look at the test and see if you can reproduce it locally, and ideally - fix?12:43
Saviqdednick, I've seen that in autopilot tests as well12:43
Saviqwhere the unlocking drag got stuck at ~ 1/3 of the screen from the left12:44
Saviqthere's a suspicion that due to the VM's speed the gesture isn't completed properly, 'cause velocity drops down or similar12:45
=== alan_g|lunch is now known as alan_g
=== _salem is now known as salem_
tsdgeosand we're back to 695$ :-)13:11
seb128tsdgeos, waouh, quite a change13:15
tsdgeosyep :)13:15
Saviqwow, and refunds13:19
Mirvbregma: so the previous Unity release blocker was resolved, but what remains is the amount of failing autopilot tests (varying on each run) that makes it hard to release. do you see anything at http://pastebin.ubuntu.com/5962552/ not addressed by other bugs you're already working on?13:20
bregmaMirc, the pinyin problems are in the new ibus, we're investigating those, a couple of the menu problems are because of a new indicators library upstream being broken (bug filed, no progress from them)13:22
bregmathe rest are vaguaries of the test system13:23
bregmafor example the previous Unity release blocker was fixed by fixing the build environment because libhybris broke x.org (nothing to do with Uniy or Compiz)13:24
tedgdednick, Checking in on the indicator work.  Are we at the point that we can have old/new indicators in Unity?13:24
dednicktedg: yes, but not in trunk13:26
dednicktedg: need unitymenumodel to land, then my branch.13:26
tedglarsu, When is unitymenumodel landing?13:27
tedgIs it up for review somewhere?13:27
dednicktedg: https://code.launchpad.net/~larsu/qmenumodel/add-unitymenumodel/+merge/17685713:27
dednicktedg: there's still a bit missing which larsu is looking at13:27
Mirvbregma: yes, I know many are long known flakiness in the tests, just pointing out the ones that keep popping up now and make it difficult to release. http://pastebin.ubuntu.com/5962573/ contains a couple more from two earlier runs from today. if there's anything you can do to reduce the flakiness of those tests (the ones in the latter pastebin link didn't show up now in the latest run), it'd help13:30
Saviqgreyback_, standup?13:31
Mirvnot sure if there'd be an option to mark some tests as false alarms, but then the tests don't do much good in the first place if they just randomly fail and they'd be even ignored13:31
greyback_Saviq: coming13:32
greyback_tsdgeos: are you doing notes then?13:34
tsdgeosgreyback_: i thought i was, but if you do, all yours :D13:34
tedgdednick, So talking with larsu he knows of one more bug for that branch.13:38
tedgdednick, After that's fixed, he thinks we could probably merge it.13:38
tedgdednick, Is that your assessment as well?13:38
tedgThere'll be additional bugs, but this starts unblocking things.13:39
dednicktedg: yep13:39
tedgdednick, Cool.13:39
tedglarsu, Is it fixed yet?  :-)13:39
larsutedg: no. I'm still have the occasional discussion ähere at guadec. I'll try to get it done today thouhg, as I'll be on a train tomorrow13:40
tedglarsu, Great, that'd be good.13:41
tedgdednick, ^13:41
dednicktedg: got it13:42
xnoxtedg: do you know how could review https://code.launchpad.net/~joe-yasi/libdbusmenu-qt/fix-x-timestamp/+merge/174573 a fix against libdbusmenu-qt from community and it looks sane (optional dependencies and fallbacks)13:43
xnoxsil2100 seems to be away.13:43
tedgxnox, Hmm, have you ping'd agateau ?13:43
tedgxnox, He'd be my first person to ask, but not sure if he'd do it.13:43
xnoxtedg: nope. agateau is not here either?13:44
tedgxnox, Hmm, he doesn't seem to be in any channels on freenode.13:44
mhr3oh ffs, how do i use Regex::escape in qml?13:45
Saviqdednick, ping13:46
dednickSaviq: pong13:46
=== greyback_ is now known as greyback|latelun
Saviqtsdgeos, looking at http://paste.ubuntu.com/5962716/ (and the console output)14:07
Saviqtsdgeos, then, reading http://qt-project.org/doc/qt-5.0/qtqml/qml-size.html14:08
Saviqtsdgeos, would you consider the error a bug?14:08
tsdgeosyou get a qsize vs qsizef thing?14:08
tsdgeosSaviq: problem is 0x0 creases a qsize and then you can't assign it to qsizef14:10
tsdgeosi can "see" why it happens14:10
tsdgeosbut yeah i don't think you should get a warning14:10
mhr3anyone seen SortFilterProxyModel provide one extra empty result?14:10
mhr3any ideas why it does that?14:10
Saviqtsdgeos, yeah, it should get converted automagically, right?14:10
tsdgeosSaviq: yeah14:11
tsdgeosmhr3: shouldn't, can you reproduce it?14:11
mhr3therefore i guess i'm doing something stupid14:12
tsdgeosmhr3: not necessarily14:13
tsdgeosmay be exposing a bug in the code14:13
mhr3tsdgeos, this does it14:13
tsdgeoslet me see if i can repro too14:14
mhr3tsdgeos, lp:~mhr3/unity8/scopes-category-overriding14:15
mhr3apply there14:15
tsdgeosmhr3: would it be the 7th item in "Recently used Apps"?14:20
mhr3tsdgeos, yea, also in "More suggestions"14:21
mhr3tsdgeos, also, works fine it you revert the pastebin14:21
tedgdednick, Did you notice?  https://code.launchpad.net/~ted/unity8/indicator-signals/+merge/17902814:24
tsdgeosthe DestkopFileModel.qml is weird :D14:24
dednicktedg: lars told me not to look at it. he said he wanted to discuss with you14:24
tsdgeosusing a repeater to fill a list feels weird14:24
mhr3tsdgeos, works :P14:25
tsdgeosmhr3: but you use more memory than you need14:26
mhr3patches welcome :)14:26
tsdgeosi mean that repeater is there forever14:26
tedgdednick, Could you look to make sure t is correct though.  I'm not as familiar with the code, not sure I put things in the right places.14:26
=== alan_g is now known as alan_g|tea
tsdgeosmhr3: there's something really fishy14:30
mhr3oh really? :)14:30
dednicktedg: i was thinking we should have a upstarter object in the utils/unity library rather than embedding the libupstart code in indicators. If we're going to be signalling things from in process, we will problably have do it more than once.14:30
tsdgeosmhr3: if you add "onCountChanged: console.log("SearchableResultModel count", count)" inside id: frequentlyUsedAppsModel14:30
tsdgeosit works :D14:30
tsdgeosyeah that14:31
tedgdednick, Perahps, but many of those are through libupstart-app-launcher.  And libdbus consolidates the connection.  So there's not too much benefit to abstracting away libupstart.14:31
tsdgeosmhr3: but it's totally reproducible :S14:31
tsdgeoscomment the line, 7 items14:31
tsdgeosuncomment it again 6 items14:31
dednicktedg: except class encapsulation14:33
dednicktedg: this is c++ after all :)14:34
tedgdednick, Yes, classes are definitely too cheap in C++.14:35
tedgToo bad tvoss is off today.  He needs to see how bad C++ is :-)14:35
dednicktedg: better to keep it readable (unlike C ;). anyway. the code looks to be in the right place.14:36
tedgdednick, readable_is_only_a_few_underscores_away  -- thanks for looking!14:38
=== alan_g|tea is now known as alan_g
Saviqtsdgeos, do you guys still have a list of tasks for unity8-mir integration somewhere?15:11
tsdgeosSaviq: http://studio.sketchpad.cc/UFFAX8fxc2 ?15:12
Saviqtsdgeos, greyback|latelun I added implementing QDesktopServices:openUrl so that we don't misplace that task15:14
tsdgeosmhr3: something seems to be wrong at the QSortFilterProxyModel level (or we are breaking it somehow)15:14
tsdgeosbecause i do stuff like15:14
tsdgeosgive me your number of rows and the number of the rows of your source model15:14
tsdgeosand get15:15
tsdgeos7, 615:15
tsdgeosand why would the proxy have more rows than the source?15:15
tsdgeosmhr3: i'm going back to finish my other dash task, but this defenitely needs someone investigating15:15
tsdgeosSaviq: ↑↑↑15:16
mhr3tsdgeos, i tried adding a qDebug to the sortfilterproxymodel::data, but it's not really called much15:16
mhr3tsdgeos, where were you debugging this?15:17
Saviqtsdgeos, mhr3, interesting, did you manage to build a minimal reproducible test case?15:17
tsdgeosSaviq: nope15:17
tsdgeosmhr3: http://paste.kde.org/~tsdgeos/pe86c3eff/15:17
tsdgeosincludes your changes15:18
tsdgeosand a few qdebus15:18
mhr3tsdgeos, yea, so why doesn't it call data() on that object, it's pretty weird15:19
tsdgeoson the model?15:19
tsdgeosit does15:19
tsdgeosthe data there is not the *right* one15:19
tsdgeosvirtual QVariant15:20
tsdgeosdata(const QModelIndex & index, int role = Qt::DisplayRole) const15:20
tsdgeosis the one you want to reimplement if you want to hijack them15:20
tsdgeosthe one there is for "direct use from qml"15:20
mhr3ah, maybe we could use clearer names next time15:22
MacSlownic-doffay, can the divider in an OptionSelector be disabled completely?15:26
MacSlownic-doffay, just curious... not that important15:27
nic-doffayMacSlow, yeah15:27
MacSlownic-doffay, didn't find the property yet for this15:27
nic-doffayMacSlow, sorry the components have support for this the OptionSelector doesn't.15:27
MacSlownic-doffay, only the internal "showDivider" flag15:27
nic-doffayMacSlow, worth adding?15:27
nic-doffayIf so I'll throw it in now.15:28
MacSlownic-doffay, *shrugg*15:28
nic-doffayMacSlow, might as well :)15:28
nic-doffayshowDividers bool it is then.15:28
=== greyback|latelun is now known as greyback
SaviqMacSlow, nic-doffay I think this should be theme-driven, no?15:31
MacSlowSaviq, yeah... maybe even that15:31
SaviqMacSlow, nic-doffay, I don't think we should be adding a property to disable them15:31
SaviqMacSlow, and in any case... I don't think there is real visual design for them...15:31
SaviqMacSlow, if you look at http://design.ubuntu.com/wp-content/uploads/option_selector_01.png for example15:32
SaviqMacSlow, there are dividers15:32
MacSlowSaviq, true... was just looking through the code of OptionSelector and was wondering as it is still work-in-progress15:32
SaviqMacSlow, when you're wondering such things, you need to have a red light light up in your brain - does that even make sense? ;)15:33
SaviqMacSlow, don't take visuals for granted - push back when you see something inconsistent15:33
nic-doffaySaviq, totally forgot about themes.15:35
SaviqMacSlow, even for https://lh4.googleusercontent.com/goPxF-p_6nxA8PM8vdawkie6HVW4ubTJ-hi_ajOHKUs2IQH34uvqIFLofNPP37GUj7enLg_f9kgaT8kegrKvWa3WyISjMmhGs4kRb8Uw_JWFt0v9Af0fC26f there are dividers, where did you see them not being there?15:38
MacSlowSaviq, one of mpt's scribbles... but again I was just curious and not really pushing for anything -> https://wiki.ubuntu.com/Networking?action=AttachFile&do=get&target=phone-wifi-prompted.png15:41
SaviqMacSlow, right, don't consider those anything close to visual design :D15:41
SaviqMacSlow, but in any case - changes like this should be theme-driven15:42
MacSlowSaviq, of course15:42
=== om26er is now known as om26er|away
=== Guest79504 is now known as amithkk
=== greyback is now known as greyback|dinner
=== alan_g is now known as alan_g|EOD
=== om26er|away is now known as om26er
Saviqmterry, if you have a minute: https://code.launchpad.net/~saviq/unity8/prepare-cross-build/+merge/17925018:14
mterrySaviq, looking18:15
Saviqmterry, yeah, I thought about the FATAL_ERROR18:28
Saviqmterry, can make it non-fatal18:28
=== greyback|dinner is now known as greyback
ESphynxHey guys... is any of you going to be at FOSSCON this weekend by any chance? :)20:39
ESphynxWe've got this bug that we'd really like to be fixed in Saucy Salamander and not quite sure whether it's our toolkit's fault or Unity's fault...20:39
ESphynxSaid bug being @ http://ecere.com/mantis/view.php?id=85020:39
=== jbicha is now known as Guest66961
=== salem_ is now known as _salem
=== jhodapp is now known as jhodapp|afk

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!