=== _salem is now known as salem_ | ||
phillw | balloons: poke... right in the left rib..... | 03:12 |
---|---|---|
=== salem_ is now known as _salem | ||
=== forestpiskie is now known as Guest28422 | ||
=== Guest28422 is now known as forestpiskie | ||
DanChapman | morning all | 07:04 |
Noskcaj | afternoon DanChapman | 07:07 |
elfy | morning DanChapman | 07:08 |
slickymaster | good morning | 08:51 |
DanChapman | slickymaster, morning :-) | 08:52 |
slickymaster | DanChapman: hello Dan | 08:52 |
slickymaster | elfy: ping. Are you there? | 08:55 |
=== lderan_ is now known as lderan | ||
elfy | hi slickymaster | 12:07 |
knome | balloons! | 12:15 |
knome | balloons, stgraber: re: the bug about testcases being archived while they shouldn't... i enabled one of them in the *other* testsuite (where we actually want them to be disabled), and it's unarchived again for the testsuite where we *want* them to be enabled | 12:17 |
=== _salem is now known as salem_ | ||
knome | stgraber, balloons: bug 1211746 | 12:22 |
ubot5 | bug 1211746 in Ubuntu QA Website "Disabling a testcase in one testsuite marks it as archived on other testsuites as well" [Undecided,New] https://launchpad.net/bugs/1211746 | 12:22 |
stgraber | knome: oops, sounds like buggy SQL, I'll fix that once I'm done travelling and attending conferences | 12:23 |
knome | stgraber, thanks :) the workaround is giving me all admin rights to the tracker, which would probably be a good idea anyway, if doable :) | 12:24 |
DanChapman | balloons, gedit is ready for a review again when you get a chance :-) | 13:24 |
balloons | DanChapman, got it :-) | 14:46 |
balloons | knome, ty for solving the mystery | 14:46 |
knome | balloons, no problem. seriously, would you approve me to get the admin access? | 14:47 |
DanChapman | balloons, I would go get a coffee if you run it lol lasts like 15 mins | 14:47 |
balloons | DanChapman, noted :-) | 14:47 |
balloons | knome, having an additional admin wouldn't be the worst idea | 14:48 |
knome | balloons, if you need me to take action regarding that, just tell me to; if not, thanks :) | 14:48 |
smartboyhw | Hey balloons how are you? | 14:54 |
balloons | knome, yes stgraber holds the keys to the acls, not I. | 14:55 |
knome | balloons, shall i ask him? | 14:55 |
balloons | knome, I think you did :-) | 14:56 |
balloons | smartboyhw, good, yourself? | 14:56 |
smartboyhw | balloons, great, just finished my piano exam today | 14:56 |
knome | balloons, sure, but not by your approval, if you see how that makes a difference :) | 14:56 |
smartboyhw | balloons is the "QA messiah" | 14:57 |
smartboyhw | And knome is the "flavour QA messiah" | 14:57 |
smartboyhw | How does that make it? | 14:57 |
balloons | smartboyhw, ohh piano, nice. Do you enjoy playing? | 14:57 |
smartboyhw | balloons, yep | 14:57 |
knome | heh, i played the piano for 6 years, but i'm pretty bad at it | 14:57 |
smartboyhw | knome, at what grade are you? | 14:58 |
knome | smartboyhw, none :) | 14:58 |
knome | i said i'm pretty bad at it! | 14:58 |
smartboyhw | knome, lolololololololololololololololololololololol | 14:58 |
knome | i mean i was like 6 when i started, and 12ish when i stopped the lessons | 14:58 |
smartboyhw | knome, oh:( | 14:58 |
* smartboyhw has learnt it for 9 years now。。。 | 14:59 | |
knome | and the studying atmosphere isn't quite as it is in asia here | 14:59 |
smartboyhw | knome, +1 | 14:59 |
smartboyhw | In Asia, either you study hard or you suck:P | 14:59 |
smartboyhw | i.e. no jobs, no university, etc. | 14:59 |
knome | fortunately, it's not quite the same here regarding that eitehr :P | 15:00 |
smartboyhw | Heh | 15:01 |
smartboyhw | knome, if you became an admin, expect me to ping you a lot:P | 15:01 |
knome | remind you, i'm good at ignoring | 15:01 |
smartboyhw | knome, boo | 15:01 |
balloons | smartboyhw, what grade are you in piano? I too played but only as a reference point for music instruction. I remember not having the hand dexterity to do very well. | 15:02 |
smartboyhw | balloons, eh, finished my Grade 8. | 15:02 |
elfy | thought I'd joined ##randomnessftw | 15:03 |
balloons | During one of my exams I had to play a piece, and the second half was in a different key. So I stopped, slid up the bench and kept playing.. my litle piano teacher was llike 5 ft tall if that with tiny hands. She told me if she could reach and play it, I shouldn't need to move either. I still could hardly reach an octave of keys | 15:04 |
knome | elfy, no, just #ubuntu-"quality"-discussions | 15:04 |
smartboyhw | elfy, LOL | 15:04 |
elfy | :) | 15:04 |
balloons | #randomness for the morning | 15:04 |
smartboyhw | elfy, it's good to be random some times;P | 15:05 |
elfy | I'm never random ... | 15:05 |
* smartboyhw hacks into elfy's brain and adds a random C++ code | 15:05 | |
* elfy hacked into his brain sometime in the early 80s - you are way too late | 15:06 | |
balloons | on that note, I'm going to start the gedit tests | 15:06 |
elfy | lol | 15:07 |
smartboyhw | balloons, what sort of new QA projects are you having in your brain? | 15:07 |
balloons | smartboyhw, stuff with manual testing. | 15:07 |
balloons | and testdrive :-) | 15:07 |
smartboyhw | balloons, that's not NEW... | 15:08 |
smartboyhw | balloons, hack, we failed:( | 15:08 |
balloons | hardly, lots of good setup came out of it.. but moving on, new stuff is click packages | 15:08 |
smartboyhw | balloons, \o/ | 15:08 |
balloons | you know about click packages a little right? | 15:08 |
smartboyhw | balloons, yep, sort of, you want to develop autopkgtest for it or? | 15:08 |
balloons | we need to migrate to using it, but it breaks our automated test running abilities | 15:09 |
smartboyhw | balloons, yeah:( | 15:09 |
smartboyhw | balloons, so what are you going to do? | 15:10 |
balloons | well, apparently be the guinea pig or lab rat if you will and test out the ideas they have to fix the issue | 15:10 |
* smartboyhw likes being in the lab, either being the guinea pig or the lab rat or the scientist:P | 15:11 | |
smartboyhw | balloons, ^ | 15:11 |
balloons | smartboyhw, yes it is the best part about qa isn't it? | 15:11 |
smartboyhw | balloons, \o/ | 15:11 |
balloons | ;-( my xephyr window doesn't seem to like me today | 15:15 |
smartboyhw | balloons, LOL | 15:15 |
slickymaster | tumbling up and down | 15:22 |
balloons | yea for working now.. apparently I just need to run the autopilot bit outside xephyr | 15:22 |
slickymaster | elfy, wasn't able to see if you can, or not, spare a few minutes | 15:23 |
elfy | I'm about slickymaster | 15:23 |
slickymaster | elfy, the reason I've pinged you this morning was about the assistive technologies testcase | 15:24 |
elfy | yep | 15:24 |
elfy | seen it | 15:24 |
slickymaster | elfy, mainly because I wasn't sure if you guys were aware that part of it already was in the settings manager testcase | 15:25 |
elfy | no I wasn't | 15:25 |
elfy | but it wasn't tagged xubuntu either - which is why I didn't know about it | 15:26 |
slickymaster | elfy, I thought so, | 15:26 |
smartboyhw | balloons, so, how to be the guinea pig? | 15:26 |
balloons | so DanChapman shall I place all my thoughts into the review, or do you want them inline here and now? | 15:26 |
slickymaster | elfy, well, I've done it anyway and at least now it has its own testcase | 15:27 |
elfy | yep - all merged and testcase sorted too :) | 15:27 |
slickymaster | elfy, that's about it, just wanted to check it with you | 15:27 |
elfy | okey doke | 15:28 |
elfy | how have you been anyway slickymaster ? | 15:28 |
slickymaster | elfy, dying while I wait for the 23rd | 15:28 |
elfy | holidays? | 15:28 |
slickymaster | elfy, vacations expecting me | 15:29 |
DanChapman | balloons, either im not fussy :-) | 15:29 |
elfy | slickymaster: not long now :) | 15:29 |
slickymaster | elfy, yes. time to pick up my board and surf all day long, for three entire weeks | 15:29 |
slickymaster | elfy: it seems light years away | 15:29 |
slickymaster | elfy, the best part is that my kid can,'t hardly wait to do it, also | 15:30 |
elfy | cool | 15:31 |
slickymaster | elfy, I just hope I can manage to get xubuntu documentation all translated into portuguese before that | 15:31 |
elfy | good lord - on your own? | 15:32 |
smartboyhw | slickymaster, NEVER translate a single documentation on your own:P | 15:32 |
slickymaster | elfy, well, no one else seems to be working on it | 15:32 |
smartboyhw | Collabarate is a better idea | 15:32 |
elfy | slickymaster: I would if it needs translating into english for the portuguese :) | 15:33 |
elfy | I should get my mate to do it for Gallego lol | 15:33 |
elfy | smartboyhw: collaboration's great if people join in | 15:33 |
smartboyhw | slickymaster, have you asked the team yet? | 15:34 |
smartboyhw | I mean, the pt translation team | 15:34 |
slickymaster | smartboyhw: bad timing smartboyhw, I've already translated Mugshot and TestDrive, alone | 15:34 |
smartboyhw | slickymaster, eh... | 15:34 |
smartboyhw | slickymaster, you'd better get a team member review your translations.. | 15:34 |
slickymaster | smartboyhw: they've been quite for a while | 15:34 |
smartboyhw | slickymaster, ? | 15:36 |
slickymaster | smartboyhw: yes | 15:36 |
elfy | quiet smartboyhw | 15:36 |
slickymaster | ? | 15:36 |
smartboyhw | elfy, ??????????? | 15:36 |
elfy | or rather smartboyhw - quiet not quite | 15:36 |
slickymaster | elfy: thanks | 15:36 |
slickymaster | smartboyhw: I meant quiet, but the fingers didn't type what the brain told them to | 15:37 |
smartboyhw | slickymaster, elfy ah ..... | 15:37 |
smartboyhw | Hmm, so you did contact them right? | 15:37 |
smartboyhw | In that case, high time to plan some activities in LoCo to get them translated:P | 15:37 |
slickymaster | smartboyhw: yes, that's a good idea | 15:38 |
slickymaster | smartboyhw: anyway I'm translating it in Rosetta, so it's kind of a work in progress, open to be worked and reviewed | 15:40 |
smartboyhw | slickymaster, but most people here don't know Portugese:P | 15:40 |
slickymaster | smartboyhw: I meant for the members of the pt translators :) | 15:41 |
smartboyhw | slickymaster, :) | 15:41 |
slickymaster | smartboyhw: and I suspect elfy can scratch a few words in northern spanish, which is very similar | 15:42 |
elfy | :) | 15:42 |
* smartboyhw didn't realize elfy knows Spanish | 15:43 | |
balloons | DanChapman, I had a few errors I was re-running to see if they would work | 15:43 |
balloons | and I had to reboot my box :-) | 15:43 |
DanChapman | balloons, oh which ones? :-) | 15:43 |
balloons | DanChapman, lol, silly me I rebooted and lost the full detail. But, I remember test_save_and_open_a_file | 15:45 |
balloons | which is confusing because it doesn't exist.. I suspected the merge didn't go as I thought | 15:47 |
DanChapman | balloons, do you mean test_save_file_type as save and open are seperate tests | 15:47 |
balloons | I also wanted to re-run for that reason :-) | 15:47 |
balloons | no DanChapman that exact test | 15:47 |
DanChapman | oh there aint a test called that lol | 15:47 |
balloons | I had a feeling some of my old hackery merged in when I merged the branch | 15:47 |
DanChapman | lol :-) | 15:48 |
balloons | ok, trying xephyr again | 15:49 |
* smartboyhw is trying out the terminal amuttp/temp-dir | 15:51 | |
smartboyhw | touch/tm/temp-dir/a | 15:51 |
smartboyhw | touch /tmp/temp-/c | 15:51 |
smartboyhw | mkdir/tmp/temp-dir2 | 15:51 |
smartboyhw | Sorry for that lol | 15:52 |
smartboyhw | I was trying the terminal autopilot test | 15:52 |
smartboyhw | And found out that I can't escape it:*( | 15:53 |
DanChapman | smartboyhw, lol done that many times forget i started it and end up with bugs in my test where ap has typed and i didnt notice :-D | 15:54 |
smartboyhw | lol | 15:54 |
balloons | that's the whole idea of running them in xephyr.. it's in own caged onscreen xserver and you can use your pc while it does it's business.. | 15:55 |
* DanChapman goes to look into xephyr | 15:55 | |
balloons | Try this: sudo apt-get install xserver-xephyr, Xephyr -ac -br -noreset -screen 800x600 :1, DISPLAY=:1.0, autopilot run terminal | 15:56 |
balloons | it seemingly doesn't need anything special to run.. so no window decorations required.. I went back and forth on running something like fluxbox or openbox in there | 15:57 |
DanChapman | balloons, E: Command line option ‘r’ [from -br] is not known | 15:57 |
balloons | ohh? it's not important | 16:02 |
DanChapman | got it going does it take ages for the test to start? | 16:03 |
balloons | DanChapman, yea, things seem a bit funny running it in there | 16:03 |
balloons | I've been playing with it to see if it can meet our needs.. I'm not sure what the long pauses are caused by | 16:05 |
balloons | ohh, 1024x768 might be a better size.. the file open dialog gets big ;-) | 16:08 |
DanChapman | far two slow for my liking :-) | 16:11 |
DanChapman | to | 16:11 |
balloons | *too | 16:11 |
balloons | I agree, a pure vm works better.. I want it to work somehow, but at least you know about it now ;-) | 16:12 |
DanChapman | its my fat fingers :-) | 16:12 |
balloons | I'm running the full gedit test in it now, we'll see how long it takes and if it works or not | 16:13 |
DanChapman | balloons, still running? | 16:32 |
balloons | DanChapman, yea, haha | 16:32 |
DanChapman | ouch! | 16:32 |
balloons | still running | 16:52 |
DanChapman | lol thats gotta be near on an hour now | 16:52 |
balloons | yea, I've been in a meetin', but I'm swapping it over to a vm | 16:53 |
balloons | and we're running in a vm now.. I'm guessing it will beat the xephyr run :-) | 16:57 |
DanChapman | should hope so :-D | 16:57 |
balloons | anyways on the code itself, I'm intrigued.. you've done a lot of nice work, and it makes me think of having an emulator for gtk apps | 16:59 |
balloons | I will say this is interesting: GeditTerminalTests | 17:03 |
DanChapman | balloons, an emulator would be pretty cool. But don't the class names have to match the object name? | 17:04 |
balloons | perhaps it would be better to just use typical command line to launch the application with arguments, rather than the terminal | 17:04 |
DanChapman | balloons, yeah i like that one | 17:04 |
DanChapman | Ok easy enough to change | 17:05 |
balloons | It's cool that you've done the work to test both.. and to be fair, it's closer to how a user would launch. But I'm concerned about that undirected typing | 17:05 |
balloons | we know what happens ;-) | 17:05 |
balloons | that said, when there are points you want to check interactions like this, where does it go? in the gedit test or the terminal test? | 17:05 |
DanChapman | both i would say. | 17:07 |
balloons | DanChapman, re:emulator, what do you mean the class names must match objectNames? | 17:09 |
DanChapman | the two tests in GeditTermTests will need breaking out to seperate test classes to be able to launch frm cmd line instead of using terminal | 17:09 |
balloons | DanChapman, testing command line options could prove interesting, heh, there's many options | 17:11 |
balloons | block processblock process | 17:12 |
balloons | I suppose only --new-document and --new-window would be interesting in addition to the files tests you have | 17:13 |
DanChapman | I havn't really looked into them so i maybe wrong but if i remember right the docs said emulater names should be that of the object i.e GtkWindow. But the names aren't the same across apps | 17:14 |
balloons | DanChapman, my only other comment on the code is are we able to assert focus before typing? does gtk give us such a property? | 17:14 |
DanChapman | yeah that would be cool | 17:14 |
DanChapman | focus of? | 17:14 |
balloons | the textbuffer for intstance | 17:14 |
balloons | DanChapman, ahh I gotcha.. yea, the diversity might limit how useful it could be.. but there are definitely things you've done in here that would help other tests, that's the hard bit | 17:15 |
balloons | re-using that code easily | 17:16 |
DanChapman | sometimes there is an is_focus property but sometimes it stays at 0. let me just check gedit | 17:17 |
balloons | aww, xephyr tests finished and vm is finished.. not sure which one "won" | 17:17 |
balloons | Ran 63 tests in 4388.826s | 17:17 |
balloons | Ran 63 tests in 813.501s | 17:17 |
balloons | I know part of the trouble with gtk stuff is that the properties didn't update.. I assumed gtk issues, but we could blame autopilot I suppose :-p | 17:18 |
balloons | well I say seemingly didn't update.. | 17:18 |
balloons | so that's it.. they all pass, the test layout looks great and very well thought out | 17:19 |
balloons | I think that's all my comments | 17:19 |
balloons | I agree, this can do a lot more than what's in there right now | 17:19 |
DanChapman | there is an is_focus property available for the buffer so i will get that in there | 17:21 |
dkessel | good evening | 17:22 |
DanChapman | dkessel, evening | 17:22 |
dkessel | can i have a look at what you guys are talking about? this sounds interesting | 17:22 |
balloons | dkessel, DanChapman I think can now be crowned the gtk autopilot test master.. he's producing some nice stuff :-) | 17:23 |
balloons | dkessel, we spoke a little of using xephyr.. that experiment failed as too slow and inconsistent. After that we spoke about DanChapman | 17:24 |
DanChapman | balloons, cheers for the list i'll get that implemented | 17:24 |
dkessel | where's that branch? :) | 17:24 |
balloons | 's gedit test. Here's the merge proposal: https://code.launchpad.net/~dpniel/ubuntu-autopilot-tests/gedit/+merge/178280 | 17:24 |
balloons | dkessel, lp:~dpniel/ubuntu-autopilot-tests/gedit | 17:24 |
dkessel | wow, so much stuff. and it even has some nice error messages with possible causes for the test failure... | 17:33 |
DanChapman | dkessel, yeah i noticed in the testtools docs that assertThat has an extra param to display friendly messages :-D | 17:34 |
dkessel | DanChapman, why? "assertion failed" is not nice enough for you to understand the failure? ;D | 17:35 |
DanChapman | dkessel, lol its nice enough for me but i wrote the test so i know the steps. It just looks nicer anyway saying 'Dialog didn't open' instead of assertion error 0 != 1. | 17:41 |
dkessel | DanChapman, yup :) | 17:41 |
* dkessel always hates when tests at his workplace break and just say "AssertionFailedError" ("Expected 10, but got 1" is not much better either) | 17:43 | |
DanChapman | :-) | 17:44 |
balloons | DanChapman, dkessel :-) Indeed, it's a nice little trick worth employing | 17:49 |
DanChapman | balloons, it would be cool to have a script like the ubiquity-runner to run autopilot tests but I don't know enough about bash to see if it can be modified to work for other tests | 18:06 |
balloons | DanChapman, what do you mean? | 18:08 |
DanChapman | balloons, lp:~jibel/+junk/ubiquity-autopilot-runner basically it creates a clean vm from an iso pulls the test branch and runs it although it does some extra bits to be able to run ubiquity. the xephyr thing got me thinking and that runner works pretty well | 18:13 |
balloons | DanChapman, OHHH.. I gotcha. Yes, you could indeed run that locally on say the whole test suite, just like in jenkins | 18:14 |
balloons | I don't see why not | 18:14 |
DanChapman | right calling it a day folks. balloons have pushed the changes for is_focus and changed the terminal tests will work on --new-doc and window in the morning | 18:56 |
balloons | DanChapman, woot.. tomorrow sounds like merge day for it then | 18:56 |
DanChapman | sounds good to me :-) | 18:57 |
m-b-o | balloons: what's up? | 19:04 |
balloons | m-b-o, guten tag | 19:05 |
m-b-o | :) | 19:05 |
m-b-o | no smoke tests for the weather app, somethings really broken? | 19:05 |
balloons | m-b-o, wie sagt man "the sky"? | 19:05 |
balloons | hehe.. the smoke tests are still running, there was some issues this morning with the builds | 19:06 |
m-b-o | der himmel? | 19:06 |
m-b-o | balloons: haha ;) | 19:06 |
balloons | m-b-o, danke. so, der himmel | 19:07 |
balloons | anyways, I'm curious as ever to see the weather app output | 19:08 |
balloons | yesterday it showed network issues, and also the tab switching was infinite looping. I disabled that test, you might have seen | 19:08 |
balloons | it's a bug in the emulator (the looping), but why it's not finding the tab to switch to is troubling, hence I opened a bug against weather app too | 19:09 |
m-b-o | is it still that "percentage-from-the-left" thing? | 19:09 |
balloons | no, not at all.. the tabs are selected much more sanely now :-) | 19:10 |
m-b-o | I had this bug alawys, when I've tried to get from the last tab back to the first | 19:10 |
m-b-o | as the first tab is attached at the end | 19:11 |
balloons | hmm, care to add some comments to the bugs? | 19:11 |
balloons | it very well could be an underlying emulator issue | 19:11 |
balloons | I mean completely | 19:11 |
m-b-o | balloons: I think so :) | 19:12 |
balloons | elopio, you about? | 19:12 |
m-b-o | ballons: I guess the index of the attached first tab (after the last) is not right. | 19:18 |
balloons | m-b-o, chatting about weather in #ubuntu-touch | 19:18 |
Letozaf_ | balloons, Hello | 19:23 |
phillw | is anyone else still having issues with usb-creator and unetbootin? | 19:48 |
elfy | phillw: not with unetbootin but I have nothing but trouble with usb-creator | 19:54 |
* elfy is glad we don't have it as a default | 19:55 | |
phillw | elfy: I have recently found :Usb creator For anyone having problems with the startup disk creator / unetbootin / casper (casper is the bit / system that adds persistency to your usb device), you could do worse than grab the deb version of live-usb-install. I tried it tonight with 13.10 and went without a hitch. It's available fromhttp://live.learnfree.eu/download that page also has further details on it. For lubuntu users, download the | 19:56 |
phillw | it seems to work well :D | 19:56 |
elfy | I never use it phillw | 19:57 |
phillw | I do, for my 'ubuntu on a stick' :D | 19:58 |
elfy | :) | 20:00 |
balloons | Letozaf_, hello | 20:01 |
phillw | ooh, sweet, they even ask for us to suggest adding new versions to the database! I've just asked that 13.10 be added :) | 20:02 |
Letozaf_ | balloons, for the calendar app test, if I add eventually to the two lines you suggested, I get this error: TypeError: Eventually is only usable with attributes that have a wait_for function or callable objects | 20:03 |
balloons | Letozaf_, ahh yes | 20:05 |
balloons | just add lambda: to the front | 20:05 |
Letozaf_ | balloons, ok thanks | 20:05 |
balloons | or depending on if you need the variable or not, you can remove the parathesis from the call and use the function directly | 20:06 |
balloons | confusing perhaps | 20:06 |
Letozaf_ | balloons, I will try both and see what happens :) | 20:09 |
balloons | Letozaf_, as in. | 20:09 |
balloons | blah = function() | 20:09 |
balloons | instead can be blah = function | 20:09 |
balloons | then it will allow use of eventually.. or even just | 20:09 |
balloons | assertThat(function, eventually()) | 20:10 |
Letozaf_ | balloons, ok understood :) | 20:10 |
balloons | :-) whew, good | 20:10 |
Letozaf_ | balloons, :p | 20:11 |
phillw | ooh, there's a new version... just grabbing :) | 20:12 |
Letozaf_ | balloons, done ! it worked putting lambda to the front :) | 20:22 |
balloons | :-) | 20:22 |
SergioMeneses | hi guys! does anyone have problems with testdrive-gtk? | 20:28 |
balloons | SergioMeneses, I used it just today | 20:29 |
balloons | SergioMeneses, so I would say no | 20:29 |
balloons | for me :-) | 20:29 |
SergioMeneses | balloons, I'm trying to open it but doesnt work | 20:30 |
SergioMeneses | let me try by console | 20:30 |
SergioMeneses | balloons, look: ERROR:gtkpreferences:Could not obtain the Ubuntu ISO list from rsync://cdimage.ubuntu.com/cdimage... | 20:33 |
balloons | SergioMeneses, Noskcaj might be able to tell you more, but try moving or deleting the .testdrive folder | 20:34 |
balloons | I would move it first in case it doesn't change anything and you want your cached images :-) | 20:34 |
balloons | SergioMeneses, that said, it sounds like a network error | 20:35 |
SergioMeneses | balloons, I have the same feeling | 20:35 |
balloons | is the app not handling missing the list very well? | 20:35 |
SergioMeneses | balloons, it's rare because I can open the link correctly http://cdimage.ubuntu.com/ | 20:36 |
=== hobgoblin is now known as elfy | ||
balloons | weird | 20:46 |
SergioMeneses | balloons, it was a network issue apparently | 21:35 |
SergioMeneses | as you said | 21:35 |
balloons | nice | 21:36 |
=== salem_ is now known as _salem | ||
elopio | balloons: I'm here. | 22:19 |
balloons | elopio, I opened a bug on tab switching, it will loop forever | 22:19 |
elopio | balloons: can I get the number please? | 22:22 |
balloons | https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1211619 | 22:22 |
ubot5 | Launchpad bug 1211619 in Ubuntu UI Toolkit "Autopilot emulator can loop infinitely while searching for tab" [Undecided,New] | 22:22 |
balloons | elopio, ^^ | 22:23 |
elopio | balloons: cool. I'll look into the weather app. | 22:24 |
elopio | thanks!@ | 22:24 |
elopio | balloons: do you have the test that causes the loop? | 22:37 |
balloons | elopio, yes, branch weather app. it's disabled and has a note on it | 22:37 |
balloons | in the test_mainview.py | 22:37 |
elopio | balloons: it didn't loop here. | 22:41 |
elopio | does it happen on your machine? | 22:42 |
=== infinity2 is now known as infinity | ||
balloons | elopio, no.. but it happens in the smoke testing | 22:50 |
balloons | see the runs from august 11th | 22:50 |
balloons | elopio, so there's 2 issues. One, we should add a control onto that while loop to stop after we've gone through every tab once | 22:51 |
balloons | 2, figure out why for some reason we don't get to a certain tab | 22:51 |
elopio | balloons: the thing is that the only way to know if we have gone through all the tabs is to get the number of tabs | 22:52 |
balloons | elopio, sure.. so get the number of tabs and don't loop more than the number? | 22:53 |
elopio | and if the number of tabs is correct, we should never loop. | 22:53 |
elopio | if the number of tabs is incorrect, nothing will work. | 22:53 |
balloons | well, I would say a hard limit on the tabs as well then | 22:53 |
elopio | balloons: I will limit the number of switches. But I'm more interested in understanding why it fails. | 22:54 |
elopio | also, I have no idea how to see the smoke testing runs of the 11th :) | 22:54 |
balloons | elopio, right :-) The limit just prevents the horrible loop :-) | 22:54 |
balloons | one sec, I'll link you | 22:55 |
balloons | elopio, this is weird actually. | 22:57 |
balloons | http://reports.qa.ubuntu.com/smokeng/saucy/image/3469/ubuntu-weather-app-autopilot/255413/ | 22:57 |
balloons | that was from the 11th.. and it worked? | 22:57 |
elopio | oh, so I was looking at the right place :D | 22:57 |
balloons | this is from today, it loops: https://jenkins.qa.ubuntu.com/job/saucy-touch_ro-mako-smoke-ubuntu-weather-app-autopilot/11/console | 22:57 |
elopio | balloons: do you keep the videos for that somewhere? | 22:58 |
balloons | i have a bug open against weather, as the actual problem I'm not sure lies in the sdk or autopilot | 22:58 |
balloons | elopio, no video possible on the devices ;-( | 22:58 |
elopio | that makes it hard. We need more loggging for autopilot. | 22:58 |
elopio | I'll work on that next week. | 22:59 |
balloons | I can try and recreate on the device | 22:59 |
balloons | I think they are run with -vv | 22:59 |
balloons | if not they should be :-) | 22:59 |
elopio | balloons: that would be awesome. I'll be implementing the loop prevention. | 23:00 |
elopio | it will be the same, but it won't take 30 minutes to fail. | 23:00 |
balloons | exactly, that was my hope | 23:00 |
elopio | I can see different coordinates on the desktop. That might be the problem. | 23:02 |
balloons | elopio, I have something I'd like your opinion on. What do you think of adding a polling wrapper for select calls, as opposed to using something like self.assertThat(thing, Eventually(Not(Is(None)))) | 23:23 |
balloons | i don't like the readability of tests as they are with all those silly asserts, when I already have a function in the emulator for the call. | 23:24 |
elopio | balloons: https://code.launchpad.net/~elopio/ubuntu-ui-toolkit/fix1211619-tab_loop/+merge/180018 | 23:29 |
elopio | I'm parsing your previous sentences... | 23:30 |
elopio | balloons: about that, I think that autopilot should raise and exception when select_single or select_many don't find any object. | 23:31 |
elopio | that's what selenium does. | 23:31 |
elopio | the most common case is that you will like that scenario to fail. | 23:31 |
balloons | elopio, I think I agree. .sorry my sentences were bad but you got it | 23:31 |
elopio | if you have a weird case where you just want to probe if the element is there, you can assert that the exception is raised. | 23:32 |
balloons | let me show you a branch diff | 23:32 |
thomi | elopio: we decided not to do that so it's easier to test whether an object exists or not | 23:32 |
elopio | balloons: no, they were fine. It's just that I'm slower in english. | 23:32 |
thomi | elopio: in hindsight, it may not have been the correct decision, but we can't change it now | 23:32 |
elopio | balloons: for that, on selenium-simple-test we added a element_exists method. | 23:32 |
balloons | thomi, hmm | 23:32 |
elopio | it returns true or false, doesn't fail. | 23:33 |
thomi | elopio: however, it should be trivial to check for None in the emulator | 23:33 |
thomi | so I don't think this is a big issue | 23:33 |
balloons | lp:~nskaggs/ubuntu-terminal-app/polling-test-idea | 23:34 |
elopio | we do it most of the times, I think. For example, on the Tabs: | 23:34 |
elopio | assert tabs is not None, _NO_TABS_ERROR | 23:34 |
balloons | elopio, thomi see http://bazaar.launchpad.net/~nskaggs/ubuntu-terminal-app/polling-test-idea/view/head:/tests/autopilot/ubuntu_terminal_app/emulators.py | 23:35 |
elopio | balloons: can't be that done with Eventually? | 23:36 |
balloons | I think I like the idea better than all the asserting for none in the test | 23:36 |
elopio | ah, that's what you don't like | 23:36 |
elopio | sorry. It's not my english that's slow today :) | 23:36 |
balloons | haha.. no my explanation was horrible, trust me | 23:37 |
elopio | there is a NotEquals matcher in test tools. | 23:38 |
elopio | I would prefer we add an IsNot | 23:39 |
elopio | self.assertThat([42], Eventually(IsNot([42]))) | 23:39 |
elopio | or we can ever do an EventuallyIsNot, if that's so common. | 23:39 |
elopio | *even | 23:39 |
balloons | eventuallyisnot is pretty common | 23:39 |
balloons | so which way do you think is best ? | 23:40 |
elopio | EventuallyIsNot = lambda x: Eventually(Not(Is(x))) | 23:40 |
elopio | I vote for that. Instead of adding an alternate polling method. | 23:40 |
balloons | elopio, this should be easier to see the difference; https://code.launchpad.net/~nskaggs/ubuntu-terminal-app/polling-test-idea/+merge/180020 | 23:41 |
balloons | well, we can change the polling method if you wish.. I just don't want to be writing the - self.assertThat(panel_popover, Eventually(NotEquals(None))) lines all the time | 23:41 |
elopio | with yours you remove the lambda though | 23:42 |
balloons | yea that was silly of me.. many of those did nothing | 23:42 |
elopio | balloons: another option would be to add a wait parameter to the select_single | 23:42 |
elopio | select_single(blah, wait=True) it will wait until the element is available. | 23:42 |
balloons | elopio, as you mentioned changing autopilot would be nice, but if there's no going back, well :-) The easy thing is for us to make a wrapper in the emulator (bring back get_object? shudder) | 23:43 |
balloons | elopio, but you see my basic idea of waiting for a function to notequal none | 23:43 |
thomi | elopio: you don't need to add the wait parameter - just use the Eventually matcher | 23:43 |
balloons | _poll_for_object | 23:43 |
elopio | thomi: the wait parameter would be a builtin eventuallyIsNotNone. | 23:44 |
elopio | if it's that common, it might be useful. | 23:44 |
thomi | elopio: what I'm saying is that we already have that | 23:44 |
elopio | balloons: I understand your _poll_for_object. | 23:44 |
thomi | autopilot.matchers.Eventually | 23:44 |
thomi | it takes any callable object | 23:45 |
balloons | so how can I wrap my calls.. hmm | 23:45 |
elopio | balloons: I still prefer not to add an alternate implementation to eventually. | 23:45 |
elopio | thomi: yes, what I'm saying is that we call autopilot.matchers.Eventually inside select single, if wait=True. | 23:45 |
balloons | so eventually(lambda: select_single ...,Equal(True)) | 23:46 |
elopio | if wait=False, we return whatever we find, None or the object. | 23:46 |
thomi | elopio: hmmmm. I'm not convinced that's a good idea.... | 23:46 |
thomi | elopio: I probably need to think about it some more | 23:46 |
elopio | balloons: I would not wrap the calls. I would make more specific matchers and do AssertThat(lambda: select_single(...), EventuallyEquals(True)) | 23:50 |
elopio | or assertThat(lambda: select_sing(...), EventuallyIsNot(None)) | 23:50 |
elopio | and, push thomi to add the wait param :) | 23:51 |
balloons | elopio, that's how I wrote for instance, the rssreader test | 23:51 |
balloons | assertThat(lambda: select_sing(...), EventuallyIsNot(None)), then do the actual call assgiment and do stuff ;-) | 23:51 |
elopio | and, also, if you find you are doing a common select_single, I would add it to the emulator with a get_method | 23:52 |
elopio | like on get_tabs, checking there are tabs. | 23:52 |
balloons | elopio, well yes, everything is a function call | 23:52 |
elopio | I got to run, sorry. I'll be back in the night. | 23:52 |
balloons | no lambda selects | 23:52 |
balloons | is there a slicker way to generically poll then.. I would rather do it in the function call in the emulator than in the test | 23:53 |
balloons | that's just my 2 cents | 23:53 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!