/srv/irclogs.ubuntu.com/2013/08/13/#ubuntu-quality.txt

=== _salem is now known as salem_
phillwballoons: poke... right in the left rib.....03:12
=== salem_ is now known as _salem
=== forestpiskie is now known as Guest28422
=== Guest28422 is now known as forestpiskie
DanChapmanmorning all07:04
Noskcajafternoon DanChapman07:07
elfymorning DanChapman07:08
slickymastergood morning08:51
DanChapmanslickymaster, morning :-)08:52
slickymasterDanChapman: hello Dan08:52
slickymasterelfy: ping. Are you there?08:55
=== lderan_ is now known as lderan
elfyhi slickymaster12:07
knomeballoons!12:15
knomeballoons, stgraber: re: the bug about testcases being archived while they shouldn't... i enabled one of them in the *other* testsuite (where we actually want them to be disabled), and it's unarchived again for the testsuite where we *want* them to be enabled12:17
=== _salem is now known as salem_
knomestgraber, balloons: bug 121174612:22
ubot5bug 1211746 in Ubuntu QA Website "Disabling a testcase in one testsuite marks it as archived on other testsuites as well" [Undecided,New] https://launchpad.net/bugs/121174612:22
stgraberknome: oops, sounds like buggy SQL, I'll fix that once I'm done travelling and attending conferences12:23
knomestgraber, thanks :) the workaround is giving me all admin rights to the tracker, which would probably be a good idea anyway, if doable :)12:24
DanChapmanballoons, gedit is ready for a review again when you get a chance :-)13:24
balloonsDanChapman, got it :-)14:46
balloonsknome, ty for solving the mystery14:46
knomeballoons, no problem. seriously, would you approve me to get the admin access?14:47
DanChapmanballoons, I would go get a coffee if you run it lol lasts like 15 mins14:47
balloonsDanChapman, noted :-)14:47
balloonsknome, having an additional admin wouldn't be the worst idea14:48
knomeballoons, if you need me to take action regarding that, just tell me to; if not, thanks :)14:48
smartboyhwHey balloons how are you?14:54
balloonsknome, yes stgraber holds the keys to the acls, not I.14:55
knomeballoons, shall i ask him?14:55
balloonsknome, I think you did :-)14:56
balloonssmartboyhw, good, yourself?14:56
smartboyhwballoons, great, just finished my piano exam today14:56
knomeballoons, sure, but not by your approval, if you see how that makes a difference :)14:56
smartboyhwballoons is the "QA messiah"14:57
smartboyhwAnd knome is the "flavour QA messiah"14:57
smartboyhwHow does that make it?14:57
balloonssmartboyhw, ohh piano, nice. Do you enjoy playing?14:57
smartboyhwballoons, yep14:57
knomeheh, i played the piano for 6 years, but i'm pretty bad at it14:57
smartboyhwknome, at what grade are you?14:58
knomesmartboyhw, none :)14:58
knomei said i'm pretty bad at it!14:58
smartboyhwknome, lolololololololololololololololololololololol14:58
knomei mean i was like 6 when i started, and 12ish when i stopped the lessons14:58
smartboyhwknome, oh:(14:58
* smartboyhw has learnt it for 9 years now。。。14:59
knomeand the studying atmosphere isn't quite as it is in asia here14:59
smartboyhwknome, +114:59
smartboyhwIn Asia, either you study hard or you suck:P14:59
smartboyhwi.e. no jobs, no university, etc.14:59
knomefortunately, it's not quite the same here regarding that eitehr :P15:00
smartboyhwHeh15:01
smartboyhwknome, if you became an admin, expect me to ping you a lot:P15:01
knomeremind you, i'm good at ignoring15:01
smartboyhwknome, boo15:01
balloonssmartboyhw, what grade are you in piano? I too played but only as a reference point for music instruction. I remember not having the hand dexterity to do very well.15:02
smartboyhwballoons, eh, finished my Grade 8.15:02
elfythought I'd joined ##randomnessftw15:03
balloonsDuring one of my exams I had to play a piece, and the second half was in a different key. So I stopped, slid up the bench and kept playing.. my litle piano teacher was llike 5 ft tall if that with tiny hands. She told me if she could reach and play it, I shouldn't need to move either. I still could hardly reach an octave of keys15:04
knomeelfy, no, just #ubuntu-"quality"-discussions15:04
smartboyhwelfy, LOL15:04
elfy:)15:04
balloons#randomness for the morning15:04
smartboyhwelfy, it's good to be random some times;P15:05
elfyI'm never random ...15:05
* smartboyhw hacks into elfy's brain and adds a random C++ code15:05
* elfy hacked into his brain sometime in the early 80s - you are way too late15:06
balloonson that note, I'm going to start the gedit tests15:06
elfylol15:07
smartboyhwballoons, what sort of new QA projects are you having in your brain?15:07
balloonssmartboyhw, stuff with manual testing.15:07
balloonsand testdrive :-)15:07
smartboyhwballoons, that's not NEW...15:08
smartboyhwballoons, hack, we failed:(15:08
balloonshardly, lots of good setup came out of it.. but moving on, new stuff is click packages15:08
smartboyhwballoons, \o/15:08
balloonsyou know about click packages a little right?15:08
smartboyhwballoons, yep, sort of, you want to develop autopkgtest for it or?15:08
balloonswe need to migrate to using it, but it breaks our automated test running abilities15:09
smartboyhwballoons, yeah:(15:09
smartboyhwballoons, so what are you going to do?15:10
balloonswell, apparently be the guinea pig or lab rat if you will and test out the ideas they have to fix the issue15:10
* smartboyhw likes being in the lab, either being the guinea pig or the lab rat or the scientist:P15:11
smartboyhwballoons, ^15:11
balloonssmartboyhw, yes it is the best part about qa isn't it?15:11
smartboyhwballoons, \o/15:11
balloons;-( my xephyr window doesn't seem to like me today15:15
smartboyhwballoons, LOL15:15
slickymastertumbling up and down15:22
balloonsyea for working now.. apparently I just need to run the autopilot bit outside xephyr15:22
slickymasterelfy, wasn't able to see if you can, or not, spare a few minutes15:23
elfyI'm about slickymaster15:23
slickymasterelfy, the reason I've pinged you this morning was about the assistive technologies testcase15:24
elfyyep15:24
elfyseen it15:24
slickymasterelfy, mainly because I wasn't sure if you guys were aware that part of it already was in the settings manager testcase15:25
elfyno I wasn't15:25
elfybut it wasn't tagged xubuntu either - which is why I didn't know about it15:26
slickymasterelfy, I thought so,15:26
smartboyhwballoons, so, how to be the guinea pig?15:26
balloonsso DanChapman shall I place all my thoughts into the review, or do you want them inline here and now?15:26
slickymasterelfy, well, I've done it anyway and at least now it has its own testcase15:27
elfyyep - all merged and testcase sorted too :)15:27
slickymasterelfy, that's about it, just wanted to check it with you15:27
elfyokey doke15:28
elfyhow have you been anyway slickymaster ?15:28
slickymasterelfy, dying while I wait for the 23rd15:28
elfyholidays?15:28
slickymasterelfy, vacations expecting me15:29
DanChapmanballoons, either im not fussy :-)15:29
elfyslickymaster: not long now :)15:29
slickymasterelfy, yes. time to pick up my board and surf all day long, for three entire weeks15:29
slickymasterelfy: it seems light years away15:29
slickymasterelfy, the best part is that my kid can,'t hardly wait to do it, also15:30
elfycool15:31
slickymasterelfy, I just hope I can manage to get xubuntu documentation all translated into portuguese before that15:31
elfygood lord - on your own?15:32
smartboyhwslickymaster, NEVER translate a single documentation on your own:P15:32
slickymasterelfy, well, no one else seems to be working on it15:32
smartboyhwCollabarate is a better idea15:32
elfyslickymaster: I would if it needs translating into english for the portuguese :)15:33
elfyI should get my mate to do it for Gallego lol15:33
elfysmartboyhw: collaboration's great if people join in15:33
smartboyhwslickymaster, have you asked the team yet?15:34
smartboyhwI mean, the pt translation team15:34
slickymastersmartboyhw: bad timing smartboyhw, I've already translated Mugshot and TestDrive, alone15:34
smartboyhwslickymaster, eh...15:34
smartboyhwslickymaster, you'd better get a team member review your translations..15:34
slickymastersmartboyhw: they've been quite for a while15:34
smartboyhwslickymaster, ?15:36
slickymastersmartboyhw: yes15:36
elfyquiet smartboyhw15:36
slickymaster?15:36
smartboyhwelfy, ???????????15:36
elfyor rather smartboyhw - quiet not quite15:36
slickymasterelfy: thanks15:36
slickymastersmartboyhw: I meant quiet, but the fingers didn't type what the brain told them to15:37
smartboyhwslickymaster, elfy ah .....15:37
smartboyhwHmm, so you did contact them right?15:37
smartboyhwIn that case, high time to plan some activities in LoCo to get them translated:P15:37
slickymastersmartboyhw: yes, that's a good idea15:38
slickymastersmartboyhw: anyway I'm translating it in Rosetta, so it's kind of a work in progress, open to be worked and reviewed15:40
smartboyhwslickymaster, but most people here don't know Portugese:P15:40
slickymastersmartboyhw: I meant for the members of the pt translators :)15:41
smartboyhwslickymaster, :)15:41
slickymastersmartboyhw: and I suspect elfy can scratch a few words in northern spanish, which is very similar15:42
elfy:)15:42
* smartboyhw didn't realize elfy knows Spanish15:43
balloonsDanChapman, I had a few errors I was re-running to see if they would work15:43
balloonsand I had to reboot my box :-)15:43
DanChapmanballoons, oh which ones? :-)15:43
balloonsDanChapman, lol, silly me I rebooted and lost the full detail. But, I remember test_save_and_open_a_file15:45
balloonswhich is confusing because it doesn't exist.. I suspected the merge didn't go as I thought15:47
DanChapmanballoons, do you mean test_save_file_type as save and open are seperate tests15:47
balloonsI also wanted to re-run for that reason :-)15:47
balloonsno DanChapman that exact test15:47
DanChapmanoh there aint a test called that lol15:47
balloonsI had a feeling some of my old hackery merged in when I merged the branch15:47
DanChapmanlol :-)15:48
balloonsok, trying xephyr again15:49
* smartboyhw is trying out the terminal amuttp/temp-dir15:51
smartboyhwtouch/tm/temp-dir/a15:51
smartboyhwtouch /tmp/temp-/c15:51
smartboyhwmkdir/tmp/temp-dir215:51
smartboyhwSorry for that lol15:52
smartboyhwI was trying the terminal autopilot test15:52
smartboyhwAnd found out that I can't escape it:*(15:53
DanChapmansmartboyhw, lol done that many times forget i started it and end up with bugs in my test where ap has typed and i didnt notice :-D15:54
smartboyhwlol15:54
balloonsthat's the whole idea of running them in xephyr.. it's in own caged onscreen xserver and you can use your pc while it does it's business..15:55
* DanChapman goes to look into xephyr15:55
balloonsTry this: sudo apt-get install xserver-xephyr, Xephyr -ac -br -noreset -screen 800x600 :1, DISPLAY=:1.0, autopilot run terminal15:56
balloonsit seemingly doesn't need anything special to run.. so no window decorations required.. I went back and forth on running something like fluxbox or openbox in there15:57
DanChapmanballoons, E: Command line option ‘r’ [from -br] is not known15:57
balloonsohh? it's not important16:02
DanChapmangot it going does it take ages for the test to start?16:03
balloonsDanChapman, yea, things seem a bit funny running it in there16:03
balloonsI've been playing with it to see if it can meet our needs.. I'm not sure what the long pauses are caused by16:05
balloonsohh, 1024x768 might be a better size.. the file open dialog gets big ;-)16:08
DanChapmanfar two slow for my liking :-)16:11
DanChapmanto16:11
balloons*too16:11
balloonsI agree, a pure vm works better.. I want it to work somehow, but at least you know about it now ;-)16:12
DanChapmanits my fat fingers :-)16:12
balloonsI'm running the full gedit test in it now, we'll see how long it takes and if it works or not16:13
DanChapmanballoons, still running?16:32
balloonsDanChapman, yea, haha16:32
DanChapmanouch!16:32
balloonsstill running16:52
DanChapmanlol thats gotta be near on an hour now16:52
balloonsyea, I've been in a meetin', but I'm swapping it over to a vm16:53
balloonsand we're running in a vm now.. I'm guessing it will beat the xephyr run :-)16:57
DanChapmanshould hope so :-D16:57
balloonsanyways on the code itself, I'm intrigued.. you've done a lot of nice work, and it makes me think of having an emulator for gtk apps16:59
balloonsI will say this is interesting: GeditTerminalTests17:03
DanChapmanballoons, an emulator would be pretty cool. But don't the class names have to match the object name?17:04
balloonsperhaps it would be better to just use typical command line to launch the application with arguments, rather than the terminal17:04
DanChapmanballoons, yeah i like that one17:04
DanChapmanOk easy enough to change17:05
balloonsIt's cool that you've done the work to test both.. and to be fair, it's closer to how a user would launch. But I'm concerned about that undirected typing17:05
balloonswe know what happens ;-)17:05
balloonsthat said, when there are points you want to check interactions like this, where does it go? in the gedit test or the terminal test?17:05
DanChapmanboth i would say.17:07
balloonsDanChapman, re:emulator, what do you mean the class names must match objectNames?17:09
DanChapmanthe two tests in GeditTermTests will need breaking out to seperate test classes to be able to launch frm cmd line instead of using terminal17:09
balloonsDanChapman, testing command line options could prove interesting, heh, there's many options17:11
balloonsblock processblock process17:12
balloonsI suppose only --new-document and --new-window would be interesting in addition to the files tests you have17:13
DanChapmanI havn't really looked into them so i maybe wrong but if i remember right the docs said emulater names should be that of the object i.e GtkWindow. But the names aren't the same across apps17:14
balloonsDanChapman, my only other comment on the code is are we able to assert focus before typing? does gtk give us such a property?17:14
DanChapmanyeah that would be cool17:14
DanChapmanfocus of?17:14
balloonsthe textbuffer for intstance17:14
balloonsDanChapman, ahh I gotcha.. yea, the diversity might limit how useful it could be.. but there are definitely things you've done in here that would help other tests, that's the hard bit17:15
balloonsre-using that code easily17:16
DanChapmansometimes there is an is_focus property but sometimes it stays at 0. let me just check gedit17:17
balloonsaww, xephyr tests finished and vm is finished.. not sure which one "won"17:17
balloonsRan 63 tests in 4388.826s17:17
balloonsRan 63 tests in 813.501s17:17
balloonsI know part of the trouble with gtk stuff is that the properties didn't update.. I assumed gtk issues, but we could blame autopilot I suppose :-p17:18
balloonswell I say seemingly didn't update..17:18
balloonsso that's it.. they all pass, the test layout looks great and very well thought out17:19
balloonsI think that's all my comments17:19
balloonsI agree, this can do a lot more than what's in there right now17:19
DanChapmanthere is an is_focus property available for the buffer so i will get that in there17:21
dkesselgood evening17:22
DanChapmandkessel, evening17:22
dkesselcan i have a look at what you guys are talking about? this sounds interesting17:22
balloonsdkessel, DanChapman I think can now be crowned the gtk autopilot test master.. he's producing some nice stuff :-)17:23
balloonsdkessel, we spoke a little of using xephyr.. that experiment failed as too slow and inconsistent. After that we spoke about DanChapman17:24
DanChapmanballoons, cheers for the list i'll get that implemented17:24
dkesselwhere's that branch? :)17:24
balloons's gedit test. Here's the merge proposal: https://code.launchpad.net/~dpniel/ubuntu-autopilot-tests/gedit/+merge/17828017:24
balloonsdkessel, lp:~dpniel/ubuntu-autopilot-tests/gedit17:24
dkesselwow, so much stuff. and it even has some nice error messages with possible causes for the test failure...17:33
DanChapmandkessel, yeah i noticed in the testtools docs that assertThat has an extra param to display friendly messages :-D17:34
dkesselDanChapman, why? "assertion failed" is not nice enough for you to understand the failure? ;D17:35
DanChapmandkessel, lol its nice enough for me but i wrote the test so i know the steps. It just looks nicer anyway saying 'Dialog didn't open' instead of assertion error 0 != 1.17:41
dkesselDanChapman, yup :)17:41
* dkessel always hates when tests at his workplace break and just say "AssertionFailedError" ("Expected 10, but got 1" is not much better either)17:43
DanChapman:-)17:44
balloonsDanChapman, dkessel :-) Indeed, it's a nice little trick worth employing17:49
DanChapmanballoons, it would be cool to have a script like the ubiquity-runner to run autopilot tests but I don't know enough about bash to see if it can be modified to work for other tests18:06
balloonsDanChapman, what do you mean?18:08
DanChapmanballoons, lp:~jibel/+junk/ubiquity-autopilot-runner basically it creates a clean vm from an iso pulls the test branch and runs it although it does some extra bits to be able to run ubiquity. the xephyr thing got me thinking and that runner works pretty well18:13
balloonsDanChapman, OHHH.. I gotcha. Yes, you could indeed run that locally on say the whole test suite, just like in jenkins18:14
balloonsI don't see why not18:14
DanChapmanright calling it a day folks. balloons have pushed the changes for is_focus and changed  the terminal tests will work on --new-doc and window in the morning18:56
balloonsDanChapman, woot.. tomorrow sounds like merge day for it then18:56
DanChapmansounds good to me :-)18:57
m-b-oballoons: what's up?19:04
balloonsm-b-o, guten tag19:05
m-b-o:)19:05
m-b-ono smoke tests for the weather app, somethings really broken?19:05
balloonsm-b-o, wie sagt man "the sky"?19:05
balloonshehe.. the smoke tests are still running, there was some issues this morning with the builds19:06
m-b-oder himmel?19:06
m-b-oballoons: haha ;)19:06
balloonsm-b-o, danke. so, der himmel19:07
balloonsanyways, I'm curious as ever to see the weather app output19:08
balloonsyesterday it showed network issues, and also the tab switching was infinite looping. I disabled that test, you might have seen19:08
balloonsit's a bug in the emulator (the looping), but why it's not finding the tab to switch to is troubling, hence I opened a bug against weather app too19:09
m-b-ois it still that "percentage-from-the-left" thing?19:09
balloonsno, not at all.. the tabs are selected much more sanely now :-)19:10
m-b-oI  had this bug alawys, when I've tried to get from the last tab back to the first19:10
m-b-oas the first tab is attached at the end19:11
balloonshmm, care to add some comments to the bugs?19:11
balloonsit very well could be an underlying emulator issue19:11
balloonsI mean completely19:11
m-b-oballoons: I think so :)19:12
balloonselopio, you about?19:12
m-b-oballons: I guess the index of the attached first tab (after the last) is not right.19:18
balloonsm-b-o, chatting about weather in #ubuntu-touch19:18
Letozaf_balloons, Hello19:23
phillwis anyone else still having issues with usb-creator and unetbootin?19:48
elfyphillw: not with unetbootin but I have nothing but trouble with usb-creator19:54
* elfy is glad we don't have it as a default19:55
phillwelfy: I have recently found :Usb creator For anyone having problems with the startup disk creator / unetbootin / casper (casper is the bit / system that adds persistency to your usb device), you could do worse than grab the deb version of live-usb-install. I tried it tonight with 13.10 and went without a hitch. It's available fromhttp://live.learnfree.eu/download  that page also has further details on it. For lubuntu users, download the19:56
phillwit seems to work well :D19:56
elfyI never use it phillw19:57
phillwI do, for my 'ubuntu on a stick' :D19:58
elfy:)20:00
balloonsLetozaf_, hello20:01
phillwooh, sweet, they even ask for us to suggest adding new versions to the database! I've just asked that 13.10 be added :)20:02
Letozaf_balloons, for the calendar app test, if I add eventually to the two lines you suggested, I get this error: TypeError: Eventually is only usable with attributes that have a wait_for function or callable objects20:03
balloonsLetozaf_, ahh yes20:05
balloonsjust add lambda: to the front20:05
Letozaf_balloons, ok thanks20:05
balloonsor depending on if you need the variable or not, you can remove the parathesis from the call and use the function directly20:06
balloonsconfusing perhaps20:06
Letozaf_balloons, I will try both and see what happens :)20:09
balloonsLetozaf_, as in.20:09
balloonsblah = function()20:09
balloonsinstead can be blah = function20:09
balloonsthen it will allow use of eventually.. or even just20:09
balloonsassertThat(function, eventually())20:10
Letozaf_balloons, ok understood :)20:10
balloons:-) whew, good20:10
Letozaf_balloons, :p20:11
phillwooh, there's a new version... just grabbing :)20:12
Letozaf_balloons, done ! it worked putting lambda to the front :)20:22
balloons:-)20:22
SergioMeneseshi guys! does anyone have problems with testdrive-gtk?20:28
balloonsSergioMeneses, I used it just today20:29
balloonsSergioMeneses, so I would say no20:29
balloonsfor me :-)20:29
SergioMenesesballoons, I'm trying to open it but doesnt work20:30
SergioMeneseslet me try by console20:30
SergioMenesesballoons, look: ERROR:gtkpreferences:Could not obtain the Ubuntu ISO list from rsync://cdimage.ubuntu.com/cdimage...20:33
balloonsSergioMeneses, Noskcaj might be able to tell you more, but try moving or deleting the .testdrive folder20:34
balloonsI would move it first in case it doesn't change anything and you want your cached images :-)20:34
balloonsSergioMeneses, that said, it sounds like a network error20:35
SergioMenesesballoons, I have the same feeling20:35
balloonsis the app not handling missing the list very well?20:35
SergioMenesesballoons, it's rare because I can open the link correctly http://cdimage.ubuntu.com/20:36
=== hobgoblin is now known as elfy
balloonsweird20:46
SergioMenesesballoons, it was a network issue apparently21:35
SergioMenesesas you said21:35
balloonsnice21:36
=== salem_ is now known as _salem
elopioballoons: I'm here.22:19
balloonselopio, I opened a bug on tab switching, it will loop forever22:19
elopioballoons: can I get the number please?22:22
balloonshttps://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/121161922:22
ubot5Launchpad bug 1211619 in Ubuntu UI Toolkit "Autopilot emulator can loop infinitely while searching for tab" [Undecided,New]22:22
balloonselopio, ^^22:23
elopioballoons: cool. I'll look into the weather app.22:24
elopiothanks!@22:24
elopioballoons: do you have the test that causes the loop?22:37
balloonselopio, yes, branch weather app. it's disabled and has a note on it22:37
balloonsin the test_mainview.py22:37
elopioballoons: it didn't loop here.22:41
elopiodoes it happen on your machine?22:42
=== infinity2 is now known as infinity
balloonselopio, no.. but it happens in the smoke testing22:50
balloonssee the runs from august 11th22:50
balloonselopio, so there's 2 issues. One, we should add a control onto that while loop to stop after we've gone through every tab once22:51
balloons2, figure out why for some reason we don't get to a certain tab22:51
elopioballoons: the thing is that the only way to know if we have gone through all the tabs is to get the number of tabs22:52
balloonselopio, sure.. so get the number of tabs and don't loop more than the number?22:53
elopioand if the number of tabs is correct, we should never loop.22:53
elopioif the number of tabs is incorrect, nothing will work.22:53
balloonswell, I would say a hard limit on the tabs as well then22:53
elopioballoons: I will limit the number of switches. But I'm more interested in understanding why it fails.22:54
elopioalso, I have no idea how to see the smoke testing runs of the 11th :)22:54
balloonselopio, right :-) The limit just prevents the horrible loop :-)22:54
balloonsone sec, I'll link you22:55
balloonselopio, this is weird actually.22:57
balloonshttp://reports.qa.ubuntu.com/smokeng/saucy/image/3469/ubuntu-weather-app-autopilot/255413/22:57
balloonsthat was from the 11th.. and it worked?22:57
elopiooh, so I was looking at the right place :D22:57
balloonsthis is from today, it loops: https://jenkins.qa.ubuntu.com/job/saucy-touch_ro-mako-smoke-ubuntu-weather-app-autopilot/11/console22:57
elopioballoons: do you keep the videos for that somewhere?22:58
balloonsi have a bug open against weather, as the actual problem I'm not sure lies in the sdk or autopilot22:58
balloonselopio, no video possible on the devices ;-(22:58
elopiothat makes it hard. We need more loggging for autopilot.22:58
elopioI'll work on that next week.22:59
balloonsI can try and recreate on the device22:59
balloonsI think they are run with -vv22:59
balloonsif not they should be :-)22:59
elopioballoons: that would be awesome. I'll be implementing the loop prevention.23:00
elopioit will be the same, but it won't take 30 minutes to fail.23:00
balloonsexactly, that was my hope23:00
elopioI can see different coordinates on the desktop. That might be the problem.23:02
balloonselopio, I have something I'd like your opinion on. What do you think of adding a polling wrapper for select calls, as opposed to using something like self.assertThat(thing, Eventually(Not(Is(None))))23:23
balloonsi don't like the readability of tests as they are with all those silly asserts, when I already have a function in the emulator for the call.23:24
elopioballoons: https://code.launchpad.net/~elopio/ubuntu-ui-toolkit/fix1211619-tab_loop/+merge/18001823:29
elopioI'm parsing your previous sentences...23:30
elopioballoons: about that, I think that autopilot should raise and exception when select_single or select_many don't find any object.23:31
elopiothat's what selenium does.23:31
elopiothe most common case is that you will like that scenario to fail.23:31
balloonselopio, I think I agree. .sorry my sentences were bad but you got it23:31
elopioif you have a weird case where you just want to probe if the element is there, you can assert that the exception is raised.23:32
balloonslet me show you a branch diff23:32
thomielopio: we decided not to do that so it's easier to test whether an object exists or not23:32
elopioballoons: no, they were fine. It's just that I'm slower in english.23:32
thomielopio: in hindsight, it may not have been the correct decision, but we can't change it now23:32
elopioballoons: for that, on selenium-simple-test we added a element_exists method.23:32
balloonsthomi, hmm23:32
elopioit returns true or false, doesn't fail.23:33
thomielopio: however, it should be trivial to check for None in the emulator23:33
thomiso I don't think this is a big issue23:33
balloonslp:~nskaggs/ubuntu-terminal-app/polling-test-idea23:34
elopiowe do it most of the times, I think. For example, on the Tabs:23:34
elopioassert tabs is not None, _NO_TABS_ERROR23:34
balloonselopio, thomi see http://bazaar.launchpad.net/~nskaggs/ubuntu-terminal-app/polling-test-idea/view/head:/tests/autopilot/ubuntu_terminal_app/emulators.py23:35
elopioballoons: can't be that done with Eventually?23:36
balloonsI think I like the idea better than all the asserting for none in the test23:36
elopioah, that's what you don't like23:36
elopiosorry. It's not my english that's slow today :)23:36
balloonshaha.. no my explanation was horrible, trust me23:37
elopiothere is a NotEquals matcher in test tools.23:38
elopioI would prefer we add an IsNot23:39
elopioself.assertThat([42], Eventually(IsNot([42])))23:39
elopioor we can ever do an EventuallyIsNot, if that's so common.23:39
elopio*even23:39
balloonseventuallyisnot is pretty common23:39
balloonsso which way do you think is best ?23:40
elopioEventuallyIsNot = lambda x: Eventually(Not(Is(x)))23:40
elopioI vote for that. Instead of adding an alternate polling method.23:40
balloonselopio, this should be easier to see the difference; https://code.launchpad.net/~nskaggs/ubuntu-terminal-app/polling-test-idea/+merge/18002023:41
balloonswell, we can change the polling method if you wish.. I just don't want to be writing the - self.assertThat(panel_popover, Eventually(NotEquals(None))) lines all the time23:41
elopiowith yours you remove the lambda though23:42
balloonsyea that was silly of me.. many of those did nothing23:42
elopioballoons: another option would be to add a wait parameter to the select_single23:42
elopioselect_single(blah, wait=True) it will wait until the element is available.23:42
balloonselopio, as you mentioned changing autopilot would be nice, but if there's no going back, well :-) The easy thing is for us to make a wrapper in the emulator (bring back get_object? shudder)23:43
balloonselopio, but you see my basic idea of waiting for a function to notequal none23:43
thomielopio: you don't need to add the wait parameter - just use the Eventually matcher23:43
balloons_poll_for_object23:43
elopiothomi: the wait parameter would be a builtin eventuallyIsNotNone.23:44
elopioif it's that common, it might be useful.23:44
thomielopio: what I'm saying is that we already have that23:44
elopioballoons: I understand your _poll_for_object.23:44
thomiautopilot.matchers.Eventually23:44
thomiit takes any callable object23:45
balloonsso how can I wrap my calls.. hmm23:45
elopioballoons: I still prefer not to add an alternate implementation to eventually.23:45
elopiothomi: yes, what I'm saying is that we call autopilot.matchers.Eventually inside select single, if wait=True.23:45
balloonsso eventually(lambda: select_single ...,Equal(True))23:46
elopioif wait=False, we return whatever we find, None or the object.23:46
thomielopio: hmmmm. I'm not convinced that's a good idea....23:46
thomielopio: I probably need to think about it some more23:46
elopioballoons: I would not wrap the calls. I would make more specific matchers and do AssertThat(lambda: select_single(...), EventuallyEquals(True))23:50
elopioor assertThat(lambda: select_sing(...), EventuallyIsNot(None))23:50
elopioand, push thomi to add the wait param :)23:51
balloonselopio, that's how I wrote for instance, the rssreader test23:51
balloonsassertThat(lambda: select_sing(...), EventuallyIsNot(None)), then do the actual call assgiment and do stuff ;-)23:51
elopioand, also, if you find you are doing a common select_single, I would add it to the emulator with a get_method23:52
elopiolike on get_tabs, checking there are tabs.23:52
balloonselopio, well yes, everything is a function call23:52
elopioI got to run, sorry. I'll be back in the night.23:52
balloonsno lambda selects23:52
balloonsis there a slicker way to generically poll then.. I would rather do it in the function call in the emulator than in the test23:53
balloonsthat's just my 2 cents23:53

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!