davechen1y | axw: ping | 04:08 |
---|---|---|
axw | davechen1y: pong | 04:08 |
davechen1y | axw: i'll find the bug | 04:08 |
davechen1y | but we have a prolem when we use deploy --to 0 | 04:08 |
davechen1y | which causes debug-log to go crazy | 04:09 |
axw | okey dokey | 04:09 |
davechen1y | i'd really like to be able to fix it | 04:09 |
davechen1y | because we're leaning heavily on the gui deployed to machine 0 | 04:10 |
davechen1y | the workaround is don't use --to | 04:10 |
davechen1y | axw: sorry, i don't know why I'm making this your problem | 04:10 |
davechen1y | you didn't write --to | 04:10 |
axw | heh that's okay, I can look into it | 04:10 |
axw | there's no consolidated log on local, so may take me a bit to get set up | 04:11 |
davechen1y | yeah | 04:11 |
davechen1y | that is why we didn't hit it til now | 04:11 |
davechen1y | bug 1211147 | 04:11 |
_mup_ | Bug #1211147: Deploying service to bootstrap node causes debug-log to spew messages <juju-core:Triaged> <https://launchpad.net/bugs/1211147> | 04:12 |
davechen1y | if it's too hard to fix easily I can stop useing --to | 04:13 |
davechen1y | but we're struggling to keep the number of machines deployed down to a reasonable level | 04:13 |
davecheney | hello | 04:37 |
davecheney | question from the field | 04:37 |
davecheney | does juju upgrade-charm --switch work | 04:37 |
davecheney | to switch from cs: to local: ? | 04:37 |
davecheney | hazmat: ping | 04:38 |
axw | davecheney: don't know that, but to fix your logging problem temporarily... | 04:40 |
axw | delete /etc/rsyslog.d/26-juju*, restart rsyslogd | 04:40 |
axw | (I think) | 04:40 |
davecheney | axw: thanks, i'll work up a one line juju ssh fix | 04:41 |
axw | on the state server that is | 04:41 |
axw | davecheney: I haven't tested it. | 04:41 |
axw | I don't have canonistack set up atm | 04:41 |
davecheney | axw: testing now | 04:44 |
davecheney | hmm, close, but there is still something else going on | 04:45 |
davecheney | axw: on positive news | 04:47 |
davecheney | debug hooks is working like a chapm | 04:47 |
davecheney | champ | 04:47 |
axw | davecheney: sorry went to get a sandwich | 04:53 |
axw | glad to know debug hooks is working. sorry about the logging... I'll keep looking | 04:53 |
davecheney | axw: it should work, maybe rsyslog is holding the config somewhere else ... | 05:05 |
davecheney | axw: ahh, it could be that debug-log is brokwn | 05:06 |
davecheney | totally | 05:06 |
axw | davecheney: how's that? | 05:07 |
davecheney | made a new environment without using --to | 05:07 |
davecheney | debug log still spews output | 05:07 |
axw | hmmkay | 05:07 |
davecheney | which is a bit of letdown | 05:07 |
davecheney | oh | 05:10 |
davecheney | i think the problem is all the \n's have been stripped from the debug log file | 05:10 |
davecheney | sorry | 05:10 |
davecheney | all-machines.log | 05:10 |
davecheney | so tail looks insane | 05:10 |
jam | morning axw and davecheney, how are things in AU? | 05:12 |
axw | jam: morning! not too shabby thank you | 05:12 |
jam | davecheney: is your debug-log problem bug #1211147? | 05:12 |
_mup_ | Bug #1211147: Deploying service to bootstrap node causes debug-log to spew messages <juju-core:Triaged> <https://launchpad.net/bugs/1211147> | 05:12 |
davecheney | jam: yes, and it is actually our log format | 05:13 |
axw | struggling to get back onto canonistack tho.. | 05:13 |
davecheney | axw: canonistack is fail | 05:13 |
davecheney | just get ec2 or hp cloud credentials | 05:13 |
davecheney | jam: the problem with debug-log is the log format | 05:13 |
davecheney | it's stripping the \n | 05:13 |
davecheney | so wc -l on all-machines says there are 0 lines | 05:13 |
davecheney | and tail prints everything fromthe beginnning of time | 05:13 |
jam | davecheney: so "juju debug-log" is just doing "juju ssh 0 tail -nX /var/log/juju/all-machines.log" but you're saying that something in how we are doing rsyslog is causing us to strip all \n chars? | 05:14 |
davecheney | jam: that is my diagnosise so far | 05:14 |
jam | davecheney: that certainly sounds like a new problem | 05:14 |
davecheney | jam: try it | 05:15 |
axw | davecheney: I guess there are company accounts for EC2/HPCloud? who do I need to ask? | 05:15 |
davecheney | axw: no | 05:15 |
davecheney | you shold obtain your own credentials and expense them | 05:15 |
axw | ah ok | 05:15 |
davecheney | i'm sorry nobody explained this too you | 05:15 |
davecheney | this really should be day one induction stuff | 05:15 |
davecheney | the company has resources, canonistack | 05:15 |
axw | actually I think rog mentioned we could expense EC2.. | 05:15 |
davecheney | but it's frequently not up to the task | 05:15 |
jam | davecheney: actually, we do have a company account with arosales for hp | 05:16 |
axw | that's a bit sad :( | 05:16 |
davecheney | axw: yeah, there is even a line item on the expense system for those type of expenses | 05:16 |
axw | ok | 05:16 |
axw | thanks | 05:16 |
marcoceppi | jam: I'm not sure it's a company account, more like an account that we have for certain testing | 05:18 |
marcoceppi | and now the occasional emergency charm school | 05:18 |
jam | marcoceppi: right. For "testing" which is what axw is doing. vs hosting your own project. | 05:19 |
* marcoceppi doesn't know what anyone does. Not even meself | 05:19 | |
jam | axw: which Canonical will pay for you to host your own project (equivalent of up to 3 m1.tiny (?)) as long as you manage it with Juju to give us feedback on the tool. | 05:19 |
axw | cool. | 05:20 |
axw | I better think up some interesting projects then | 05:20 |
davecheney | jam: it is quite strange, the output format of the rsyslog config hasn't changed since wallyworld_ landed the fix | 05:20 |
davecheney | sorry the original support | 05:20 |
davecheney | i wonder if it is a hp cloud thing | 05:20 |
* davecheney tries ec2 | 05:20 | |
=== tasdomas_afk is now known as tasdomas | ||
davecheney | indeed it is | 05:22 |
davecheney | it works perfectly in ec2 ... | 05:22 |
davecheney | i wonder if it is the hostname | 05:22 |
davecheney | jam: i think there are two problems | 05:26 |
davecheney | hulk smash causes rsyslog to feed back to itself | 05:26 |
davecheney | but also the output format + hp cloud does something strange | 05:26 |
jam | davecheney: right, hulk-smash is something I feel we have an understanding of the bug, we just need to fix it. hp cloud stripping '\n' is something new we haven't seen before. | 05:27 |
davecheney | jam: understood | 05:27 |
davecheney | will treat as a second issue | 05:27 |
davecheney | just trying axw's fix for hulk smash | 05:28 |
davecheney | jam: axw confirm that reminging /etc/rsyslog/26-juju* and restarting rsyslog works | 05:29 |
axw | goodo | 05:29 |
axw | thanks | 05:29 |
jam | davecheney: so that fixes the \n thing as well? or just the syslog feeding into itself? | 05:30 |
davecheney | jam: only 1211147 | 05:32 |
davecheney | i'll dig into the log format thing on hp cloud | 05:32 |
davecheney | and open a new issue | 05:32 |
davecheney | axw: is it possible to do | 05:45 |
davecheney | juju status 1 | 05:45 |
davecheney | and show only machine 1 | 05:45 |
axw | davecheney: nope | 05:45 |
axw | only unit or service | 05:45 |
davecheney | axw: roger | 05:45 |
davecheney | question, what is the presence ping delay ? | 05:46 |
davecheney | 60 seconds ? | 05:46 |
axw | there's a var in presence/presence.go that says 30s, tho I don't claim to understand the workings of that code | 05:48 |
axw | ^ davecheney | 05:48 |
marcoceppi | So, juju deploy mysql mysql-1 (using mysql-1 as an alias) throws an error, is this expected | 06:05 |
davecheney | axw: thanks | 06:22 |
davecheney | i was able to demo that | 06:22 |
davecheney | does anyone know whre the missing and unknown states show up | 06:22 |
davecheney | is that only for machine records ? | 06:22 |
axw | erk | 06:33 |
axw | jam: I reproduced that line-ending bug on lcy02 | 07:06 |
jam | I'm happy it was reproducible, less so that it exists :) | 07:06 |
axw | I'll look into it after fixing the original problem | 07:07 |
noodles775 | Is StoreSuite known to fail sometimes? http://paste.ubuntu.com/5984006/ | 07:10 |
axw | noodles775: yeah I think I've seen TestBlitzKey fail before, randomly | 07:14 |
jam | noodles775: we are supposed to be rigorous about not having casually failing tests in the test suite, though it seems being away for 3 weeks caused this rigor to diminish a bit. | 07:15 |
jam | (to land code, all tests must pass on the bot, for example) | 07:15 |
rogpeppe | axw, fwereade_, jam, davechen1y, mgz, wallyworld_: morning! | 07:19 |
noodles775 | jam: Yep, although it can be v. hard to fix them when they're hard to reproduce. | 07:20 |
noodles775 | axw: ack, txs. | 07:20 |
axw | rogpeppe: good morning | 07:20 |
rogpeppe | axw: fancy coming to the standup today? | 07:21 |
rogpeppe | axw: i don't know what time it is for you then, mind | 07:21 |
axw | rogpeppe: about 7:30 (dinner time ;)) - but I'll come today | 07:21 |
rogpeppe | axw: don't feel obliged - i just thought it might be nice if you could make it | 07:22 |
axw | rogpeppe: no I would like to come, and I haven't been to one yet | 07:23 |
rogpeppe | axw: cool | 07:23 |
rogpeppe | axw: how's it going anyway? | 07:23 |
axw | rogpeppe: not too shabby. working on manual deployment, and fixing a debug-log bug atm | 07:24 |
rogpeppe | axw: cool | 07:24 |
rogpeppe | axw: some time i hope we can have a way of changing the debug level in an environment dynamically | 07:26 |
axw | rogpeppe: I believe thumper has a branch in the works | 07:26 |
axw | it would be nice | 07:26 |
rogpeppe | axw: ah, that's good to know | 07:26 |
axw | jam1: if it interests you: https://bugs.launchpad.net/juju-core/+bug/1212148 | 08:27 |
_mup_ | Bug #1212148: rsyslog accumulator strips newlines on openstack <juju-core:New> <https://launchpad.net/bugs/1212148> | 08:27 |
dimitern | rogpeppe: hey | 09:10 |
rogpeppe | dimitern: yo! | 09:10 |
dimitern | rogpeppe: a relation is not an entity, right? we cannot reuse the LifeGetter for it | 09:10 |
rogpeppe | dimitern: hmm, yeah | 09:11 |
dimitern | rogpeppe: ok | 09:11 |
rogpeppe | dimitern: we could make it an entity, i guess | 09:14 |
dimitern | rogpeppe: I don't think this is a good idea | 09:17 |
dimitern | rogpeppe: it's not used as other entities are | 09:17 |
rogpeppe | dimitern: the AllWatcher reports on changes to it, not too differently from other entities | 09:17 |
rogpeppe | dimitern: entities are not all used the same | 09:18 |
dimitern | rogpeppe: yeah, but there's no agent or client that uses it as its main entity | 09:18 |
rogpeppe | dimitern: that's not true of Service either | 09:18 |
rogpeppe | dimitern: or Environment | 09:18 |
noodles775 | I'm trying to reproduce bug 1208504, but get "Cannot find requested image 81078" when trying to bootstrap on HP Cloud. If anyone has any experience with HP Clound and knows what I'm doing wrong, please let me know :) http://paste.ubuntu.com/5984281/ | 09:18 |
_mup_ | Bug #1208504: "error: no instances found" Post bootstrap on HP Cloud <papercut> <juju-core:In Progress by michael.nelson> <https://launchpad.net/bugs/1208504> | 09:18 |
dimitern | rogpeppe: hmm | 09:19 |
dimitern | rogpeppe: we can do that later, if we decide to do it anyway | 09:20 |
dimitern | rogpeppe: and what will be its key? there are 2 keys that are used - id int and a key string (created from the endpoints) | 09:22 |
dimitern | rogpeppe: the string key is _id in the doc, but is some places the id is also used | 09:22 |
rogpeppe | dimitern: i'd presume the latter, but there might well be reasons why that's a bad idea | 09:22 |
dimitern | fwereade_: you around? | 09:22 |
dimitern | and it's even less clear about endpoints | 09:29 |
dimitern | relationUnit seems it can be implemented at client-side with only a few methods on the server-side | 09:33 |
dimitern | fwereade_: when you have some time, we need to have a chat about how best to implement certain uniter objects in the api | 09:36 |
rogpeppe | does anyone else see this test failure on trunk? http://paste.ubuntu.com/5984415/ | 09:47 |
dimitern | rogpeppe: you need to update goamz | 09:48 |
rogpeppe | dimitern: ah | 09:48 |
rogpeppe | dimitern: wow, that's an unexpected way for it to fail (updating goamz did fix it) | 09:49 |
rogpeppe | dimitern: do you know what the issue was? | 09:49 |
dimitern | rogpeppe: yes, it stems from the changes to support instance-state in juju status | 09:50 |
axw | rogpeppe: sorry, I should have sent an email | 09:50 |
rogpeppe | axw: did you update the dependencies file? | 09:50 |
axw | rogpeppe: uhmm. I forget. I think so... | 09:50 |
rogpeppe | axw: cool | 09:50 |
axw | rogpeppe: the issue fixed in goamz was in the testing server, to pass through the instance state | 09:51 |
axw | previously it was always blank, hence the test failure | 09:52 |
axw | back later for the standup | 09:56 |
* rogpeppe has just discovered how to speed up ec2 local tests from 3 minutes to 6 seconds | 10:13 | |
dimitern | rogpeppe: how? | 10:13 |
rogpeppe | dimitern: change s3.attempts | 10:14 |
dimitern | rogpeppe: and still all pass? | 10:14 |
rogpeppe | dimitern: yeah | 10:14 |
dimitern | rogpeppe: cool! | 10:17 |
dimitern | rogpeppe: is that in juju or goamz? | 10:17 |
rogpeppe | dimitern: goamz | 10:17 |
dimitern | rogpeppe: ah | 10:17 |
mgz | yeah, the ec2test local bits are... fun in many ways | 10:23 |
rogpeppe | mgz: apologies for that :-) | 10:23 |
mgz | :) | 10:24 |
rogpeppe | mgz: i did the bare minimum required to get something working. | 10:24 |
rogpeppe | mgz: what issues are you having, BTW? | 10:24 |
mgz | general lack of flexibility mostly | 10:25 |
rogpeppe | mgz: right; it wasn't designed to be flexible | 10:26 |
mgz | tests in juju-core rely on hardcoded values that are in goamz, and aren't otherwise exposed or chnageable from inside a test, for instance | 10:26 |
rogpeppe | mgz: the instance address == instance id thing? | 10:27 |
mgz | like that, yes | 10:28 |
rogpeppe | mgz: i don't think it should be too hard to interject flexibility in some places | 10:28 |
rogpeppe | dimitern, mgz: https://codereview.appspot.com/12918044 | 10:36 |
mgz | looking | 10:36 |
dimitern | me too | 10:36 |
rogpeppe | i'd like to have a separate project containing AttemptStrategy, so that both juju-core and goamz can use it, but i'm not sure how gustavo would feel about that | 10:37 |
dimitern | rogpeppe: lgtm | 10:38 |
rogpeppe | dimitern: thanks | 10:38 |
mgz | also. I still wonder if this is really the right way of dealing with eventual consistency things. we poll-wait in a bunch of cases where actually it doesn't matter and operations could just continue | 10:39 |
mgz | I guess it's simpler like this at least | 10:39 |
rogpeppe | mgz: eventual consistency is very hard to deal with | 10:49 |
rogpeppe | mgz: can you think of a better plan for dealing with it? | 10:49 |
jam1 | rogpeppe: I don't know if you remember me mentioning the s3 thing about 2 months ago, and getting pushback from exposing it as a knob from goamz. I think there was some buy-in that we could have a flag for "disable retries entirely" | 10:50 |
rogpeppe | jam1: ah, ok | 10:50 |
rogpeppe | jam1: i wondered about that | 10:50 |
=== jam1 is now known as jam | ||
mgz | well, there are a bunch of places where pushing the handling up a few layers would mean we could make better choices | 10:50 |
rogpeppe | jam1: environs/ec2 is ridiculously slow to test | 10:50 |
jam | rogpeppe: yep | 10:50 |
mgz | but again, I think it's pretty set that it needs to be handled inside goamz, which limits things | 10:51 |
jam | It triggers because we check to see if you have any local tools/images/etc that we should be using, and the s3 eventual-consistency code kicks in saying "I don't have anything in your private bucket yet, but I might in 3 seconds" | 10:51 |
rogpeppe | mgz: what places are you thinking of that we are poll-waiting when we don't need to? | 10:51 |
rogpeppe | jam: yeah. that sounds reasonable - that may well happen for real when we're uploading tools | 10:52 |
jam | rogpeppe: so it is fine that it triggers in real life, adding 3-5s on every bootstrap isn't a big deal. In the case of the test suite, it is detrimental. | 10:55 |
rogpeppe | jam: absolutely | 10:55 |
jam | goamz's double *isn't* eventually consistent. :) | 10:55 |
rogpeppe | jam: indeed | 10:55 |
jam | I was also quite surprised that we were spending 3+min in time.Sleep() | 10:56 |
rogpeppe | jam: almost exactly three minutes in the case of environs/ec2 | 10:56 |
noodles775 | Could someone please set the following MP to Approved so it lands? https://code.launchpad.net/~michael.nelson/juju-core/1183159-ssh-options/+merge/179422 | 11:19 |
dimitern | noodles775: done | 11:20 |
noodles775 | ta | 11:20 |
rogpeppe | jam, mgz, dimitern: alternative formulation that might be more niemeyer-acceptable | 11:22 |
rogpeppe | https://codereview.appspot.com/12740044 | 11:22 |
dimitern | rogpeppe: reviewed | 11:24 |
rogpeppe | dimitern: the other one is just as unclean and should have the same warning really | 11:25 |
rogpeppe | dimitern: well, it's a bit less clean, i suppose as it's less direct | 11:25 |
rogpeppe | dimitern: (the new CL that is) | 11:26 |
jam | rogpeppe: what about putting the Retry boolean into the s3 constructor? | 11:26 |
jam | AutoRetry perhaps? | 11:26 |
rogpeppe | jam: that's ok if the tests have access to where the S3 instance is being constructed | 11:26 |
jam | rogpeppe: well, at least it would be exposed from codebase A into codebase B, and codebase B can expose it up the stack as necesasry. | 11:27 |
rogpeppe | jam: there are many possibilities here | 11:27 |
jam | I'm a *big* fan of having as little mutable global state as possible | 11:27 |
jam | dimitern: IIRC the specific objective Gustavo had for the attempts logic was that "real" code shouldn't ever have to tweak this setting because we should make sure it Just Works. | 11:28 |
jam | I'm not sure that I agree 100%, because site-specific tweaking is always a possilibity (what if your ping time means it takes longer to see a consistent state?) | 11:28 |
jam | For our particular use case, the boolean fits better what we actually need | 11:28 |
jam | and is nice an minimalist | 11:29 |
dimitern | well, we can have "just works" and better tests in the same time | 11:29 |
rogpeppe | jam: the sense of the boolean should be the other way if it's exposed in S3 | 11:29 |
rogpeppe | jam: although | 11:30 |
rogpeppe | jam: i hope nobody is initialising the S3 struct themselves | 11:30 |
jam | fwereade_, rogpeppe, dimitern, axw, mgz, wallyworld_, natefinch: standup time: | 11:31 |
jam | https://plus.google.com/hangouts/_/f497381ca4d154890227b3b35a85a985b894b471 | 11:31 |
hazmat | jamespage, re mulitple networks and juju (bug 1188126) , is there any order to how quantum attaches the nics, or is quantum api usage the only way to resolve the ambiguity? | 11:41 |
_mup_ | Bug #1188126: Juju unable to interact consistently with an openstack deployment where tenant has multiple networks configured <canonistack> <serverstack> <juju:New> <juju-core:Triaged> <https://launchpad.net/bugs/1188126> | 11:41 |
jamespage | hazmat, the order quantum attaches nics is unhelpful | 11:42 |
jamespage | hazmat, its attaches then in alpha numeric order for the uuid of the networks | 11:42 |
jamespage | hazmat, i'd prefer to see some sort of option to specific which network to use in juju - then the instances can be connected to the quantum networks in a deterministic order - i.e. a preferred admin network type arrangement | 11:43 |
jamespage | hazmat, that might also fit well with using LXC containers when adding extra network interfaces for each container | 11:45 |
jam | axw: I did say you could get back to work, not go back to your personal life :) | 12:02 |
jam | have a great evening | 12:02 |
mgz | natefinch: I'll catch up with you after lunch here to do some review/code things | 12:02 |
natefinch | mgz: cool. probably going to have to be in a few hours, due to my daughter's doctor's appointment. Not ideal for your schedule, I know. I'll ping you when I'm back. | 12:03 |
mgz | sure! | 12:04 |
hazmat | jamespage, ala vpc_id/quantum_net_id for an environment? | 12:05 |
hazmat | jamespage is this primarily a hosts issue when building a cloud, ie the baremetal gets networks for each of the guest tenants its hosting? | 12:06 |
jamespage | hazmat, no - I hit this purely with openvswitch overlay networking | 12:07 |
jamespage | where I can have any number of L2 networks attached to each instance | 12:07 |
hazmat | jamespage, does any of that mapping of nic to net id get exposed in instance metadata, or is quantum the only way to resolve? | 12:09 |
hazmat | jamespage, you'd want to spec a net id for private net usage via an env setting? or have juju resolve the entire net topology via quantum | 12:10 |
jamespage | hazmat, not sure about metadata (it might - I'll check) | 12:11 |
jamespage | its all exposed in quantum of course | 12:12 |
jamespage | hazmat, specing a net-id for the private network as an env setting works for me | 12:12 |
axw | jam: hah, thanks :) | 12:17 |
sidnei | can i get a pair of eyes on https://codereview.appspot.com/12859043/ ? | 12:44 |
sidnei | noodles775: did you get the tests to run to completion? | 13:09 |
rogpeppe | time for lunch | 13:12 |
noodles775 | sidnei: which tests? | 13:14 |
sidnei | noodles775: all of them *wink* | 13:15 |
noodles775 | sidnei: sorry - you've lost me. Are you talking about a juju-core test run for which branch? | 13:15 |
sidnei | noodles775: for any branch, iirc you were having trouble getting a clean test run of the whole suite, and i told you i was running only tests for specific packages. | 13:16 |
noodles775 | sidnei: yes, complete test run works fine. I don't remember the context last week where I was having issues. Perhaps before I had the correct mongedb version? | 13:17 |
sidnei | noodles775: could be. and you're in raring not saucy right? | 13:17 |
noodles775 | sidnei: saucy locally, but all my dev is on a precise canonistack instance. | 13:18 |
sidnei | noodles775: ok, so you run the tests on precise. | 13:18 |
noodles775 | yep. | 13:19 |
* sidnei tries on a precise lxc | 13:20 | |
dimitern | rogpeppe, jam, mgz: https://codereview.appspot.com/12906044 - endpoints refactoring as we discussed | 14:05 |
dimitern | rogpeppe, jam: thanks! | 14:37 |
dimitern | rogpeppe, jam, mgz: next one https://codereview.appspot.com/12748044 - relations as entities | 14:41 |
dimitern | rogpeppe: I might have missed something important there | 14:44 |
rogpeppe | dimitern: looking | 14:44 |
sidnei | rogpeppe: if you get a chance, https://codereview.appspot.com/12859043/ | 14:56 |
* sidnei lunches | 14:56 | |
cruejones | anyone ever see this on juju bootstrap ... 'juju open.go:89 state: connection failed, will retry: dial tcp 127.0.0.1:37017: connection refused' | 15:07 |
cruejones | full verbose details @ http://pastebin.ubuntu.com/5985297/ | 15:08 |
dimitern | cruejones: why sudo ? is that the local provider? | 15:09 |
cruejones | yup | 15:09 |
dimitern | cruejones: do you have mongo running on 127.0.0.1:37017 ? | 15:10 |
dimitern | mgz: ping | 15:11 |
cruejones | dimitern: does not look like anything is running at that port | 15:12 |
dimitern | cruejones: does it run on something like 10.0.3.x ? | 15:12 |
dimitern | cruejones: that's the lxc container address where it should run | 15:13 |
dimitern | rogpeppe: thanks for the review - updated with your suggestions | 15:14 |
cruejones | dimitern: nope | 15:14 |
dimitern | cruejones: are you using the tarball version of mongo, as described in the README? | 15:15 |
dimitern | cruejones: ah, sorry you probably followed the procedure there and did make install-dependencies ? | 15:16 |
mgz | dimitern: hey | 15:16 |
cruejones | dimitern: ha, no | 15:16 |
dimitern | mgz: https://codereview.appspot.com/12748044/ please? | 15:16 |
dimitern | cruejones: did you get juju-core from source? | 15:17 |
cruejones | dimitern: just updated to latest juju-core, setup my environment.yaml and ran 'sudo juju bootstrap' | 15:17 |
=== tasdomas is now known as tasdomas_afk | ||
mgz | dimitern: okay | 15:17 |
dimitern | cruejones: if you can run the tests successfully, that's the first step: "go build ./... && go test ./..." in juju-core/ | 15:17 |
cruejones | dimitern: ok, having to go there is not so user friendly though | 15:18 |
cruejones | mramm: ^ | 15:19 |
dimitern | cruejones: well, I haven't seen this error, sorry, but then again I haven't used the local provider yet | 15:19 |
dimitern | cruejones: most likely it's an issue with the correct version of mongo and/or lxc prerequisities - that's why we've updated the README to streamline the process | 15:20 |
mramm | cruejones: we are doing two things to make this better 1) adding error messages when the packages aren't installed correctly | 15:21 |
mramm | and 2) adding a juju-local-provider package that installs both juju and the local provider dependencies | 15:21 |
cruejones | dimitern: sorry, don't get me wrong I really appreciate the help - trying to point out where things could and do go wrong with first impressions | 15:22 |
cruejones | or I am just clueless and/or bad luck ... probably a both ;) | 15:22 |
dimitern | cruejones: you're right, it's not user friendly, but we're trying to make it better and appreciate sharing the problems you encounter | 15:23 |
mramm | cruejones: definitely, we have to fix this so the process feels seamless and we very much value anybody pointing out where it is not | 15:23 |
dimitern | cruejones: can you try getting juju-core from source and retry the same, possibly following the steps in the README to see if it helps? 1.12 was some time ago and some changes were already made for the better | 15:24 |
cruejones | dimitern: will do after some mid-morning meetings, let you know how it goes .. thx | 15:26 |
henninge | fwereade_: ping | 15:36 |
dimitern | henninge: he's out today | 15:36 |
henninge | Ah, that's why. ;-) | 15:36 |
henninge | dimitern: Will he be back tomorrow? | 15:36 |
dimitern | henninge: I think so | 15:37 |
henninge | cheers | 15:37 |
dimitern | mgz: does it look ok? | 15:44 |
rogpeppe | sidnei: you've got a review | 15:47 |
sidnei | cool, not as bad as i expected ;) | 15:48 |
sidnei | rogpeppe: do the changes to instanceData doc need some sort of schema migration between versions? | 15:48 |
mgz | dimitern: fine I think, though I'm not sure I get all the implications | 15:49 |
rogpeppe | sidnei: i don't *think* so | 15:49 |
dimitern | mgz: since nothing is using relation as entities yet, there are no implications I can see | 15:49 |
mgz | fair enough | 15:50 |
dimitern | mgz: the only issue might be that now you can attach annotations to relations as well | 15:50 |
dimitern | rogpeppe, mgz: which might be a good thing | 15:50 |
dimitern | but there's no api for that anyway | 15:51 |
sidnei | rogpeppe: on a related topic, i think this is wrong: http://paste.ubuntu.com/5985486/ | 15:51 |
sidnei | rogpeppe: i think the append should be inside the if s != ""? | 15:51 |
rogpeppe | sidnei: i don't *think* so | 15:52 |
rogpeppe | sidnei: i think you're allowed to say "mem= disk=10M" | 15:52 |
rogpeppe | sidnei: to say "no constraint on memory, but i want to specify that" | 15:53 |
rogpeppe | sidnei: i think that's true for any constraint attribute | 15:53 |
sidnei | rogpeppe: but that's on HardwareCharacteristics.String() | 15:55 |
rogpeppe | dimitern: i don't think you can now attach annotations to relations | 15:55 |
sidnei | rogpeppe: so it ends up as 'mem= ' in juju status | 15:55 |
rogpeppe | sidnei: ha, yes | 15:55 |
dimitern | rogpeppe: while looking at the code it seemed so, but I might be wrong | 15:55 |
rogpeppe | sidnei: only if you've got zero memory of course | 15:55 |
rogpeppe | dimitern: i think you can only set annotations on entities that embed annotator | 15:56 |
sidnei | rogpeppe: right, which is never the case. the one i hit was one case with OsDisk being nil, but it should never be nil anyway. | 15:56 |
rogpeppe | sidnei: i think the hardward characteristics stuff was probably just copied naively from constraints | 15:56 |
sidnei | it definitely looks so | 15:57 |
rogpeppe | sidnei: they're so similar (and they share some identical code) that i think they could both sit usefully in the same package | 15:57 |
dimitern | rogpeppe: ah, right! | 15:57 |
rogpeppe | sidnei: i don't think the h/w characteristics stuff should use uintStr at all, which is just there for that constraint logic | 15:58 |
rogpeppe | if hc.Mem != nil {strs = append(strs, fmt.Sprintf("mem=%M", hc.Mem))} | 15:59 |
sidnei | rogpeppe: %M? is there an extra char missing there? | 15:59 |
rogpeppe | sidnei: ha ha, %d i meant | 16:00 |
sidnei | k, will make that change. | 16:00 |
rogpeppe | %dM | 16:00 |
rogpeppe | in fact | 16:00 |
sidnei | rogpeppe: in the comment 'Just "return" should be do ok here.' that's meant for the 'return nil' line? | 16:04 |
rogpeppe | sidnei: it's meant for the if and the return | 16:05 |
natefinch | mgz: back finally | 16:06 |
mgz | natefinch: ace | 16:06 |
sidnei | rogpeppe: oh, i guess i could just 'return err' without the if you mean? since err will be nil anyway? | 16:06 |
sidnei | ah, not even that since it assigns to err | 16:07 |
sidnei | got it now | 16:07 |
rogpeppe | sidnei: yeah, and since you've already declared the err return variable, you can use a bare return | 16:07 |
natefinch | rogpeppe: what's our stance on bare returns? In general I try to avoid them, since they sometimes can return things you didn't mean to return | 16:10 |
rogpeppe | natefinch: i think in very short functions where it's easy to see everything at a glance, they're ok | 16:11 |
rogpeppe | natefinch: that said, i try to avoid them on most occasions too | 16:11 |
rogpeppe | natefinch: in this case, the function's only 3 lines long - it seems reasonable there | 16:12 |
natefinch | rogpeppe: yeah, for short functions it doesn't matter much... I just usually get to the return and think "really? I'm trying to save 3 (or whatever) characters?" so in practice I never actually use bare returns even though I'm not fundamentally against them | 16:14 |
rogpeppe | natefinch: yeah, i see that pov | 16:15 |
natefinch | rogpeppe: I sorta wish I didn't even have the option, then I wouldn't have to argue with myself about it ;) | 16:16 |
rogpeppe | natefinch: yeah. adg shares your view there, i think. | 16:16 |
sidnei | allenap: around? | 16:21 |
sidnei | or jtv | 16:24 |
allenap | sidnei: Hi there. | 16:24 |
sidnei | allenap: i assume you are somewhat knowledgeable about azure things. im looking at this table http://msdn.microsoft.com/en-us/library/windowsazure/dn197896.aspx and wondering which of the two columns for 'os disk-space' i should use to fill in some values | 16:25 |
sidnei | allenap: or maybe that already comes from roleSize? | 16:27 |
sidnei | oh, it seems to be defined there already, just need to pick one of the two | 16:27 |
allenap | sidnei: Yeah, that's right, but let me check in GWACL. | 16:29 |
sidnei | allenap: yeah, im looking in gwacl/rolesizes.go, i just don't know which of the two values to use | 16:29 |
allenap | sidnei: NewRole's first argument can be "ExtraSmall", for example. | 16:32 |
allenap | sidnei: That seems to be what Azure expects. | 16:33 |
sidnei | allenap: sorry, let me be more explicit. when i do 'juju deploy' in azure, do i get a 'cloud service' or a 'virtual machine', more explicitly even, the instance that comes up has OSDiskSpaceCloud MBs or OSDiskSpaceVirt MBs in it's root disk? | 16:34 |
sidnei | allenap: this is for exposing the os disk size in HardwareCharacteristics and constraints as part of bug #1201503 | 16:35 |
_mup_ | Bug #1201503: Add os disk constraint <constraints> <juju-core:Triaged by sidnei> <https://launchpad.net/bugs/1201503> | 16:35 |
allenap | sidnei: You get the VM sizes. | 16:36 |
sidnei | allenap: awesome, thanks! | 16:36 |
rogpeppe | does anyone know anything about Config.SSLHostnameVerification ? | 16:44 |
rogpeppe | it's only mentioned in one place, and that's just to say it can't be used | 16:44 |
sidnei | rogpeppe: addressed comments + added azure info per discussion with allenap above. | 16:46 |
sidnei | is fwereade_ not around today? | 16:47 |
dimitern | sidnei: nope, he's off today | 16:52 |
sidnei | dimitern: feel like doing a review? https://codereview.appspot.com/12859043/ | 16:53 |
dimitern | sidnei: sure | 16:53 |
mgz | sidnei: I have a few quibbles on that branch | 16:53 |
mgz | will post comments ina sec | 16:54 |
rogpeppe | sidnei: do you think we ever want to accept blank values for h/w specification attributes? | 16:54 |
sidnei | thanks mgz | 16:54 |
sidnei | rogpeppe: afaict those are mainly filled from instance type, so no? | 16:54 |
rogpeppe | sidnei: i suspect that we don't want the 'if str != ""' parse logic in instance.go | 16:54 |
rogpeppe | sidnei: (which makes the code simpler, and usefully different from that in constraints, i think) | 16:55 |
sidnei | indeed | 16:56 |
dimitern | sidnei: you've got a review | 17:09 |
dimitern | g'night all | 17:14 |
sidnei | mgz: waiting for your comments | 17:16 |
sidnei | jam: iiuc you're the one looking into migrations between versions? | 17:17 |
sidnei | ah, beat me to it | 17:19 |
sidnei | mgz: i like the root disk suggestion, i was afraid someone would take 'os-' as openstack as well. | 17:20 |
rogpeppe | sidnei, mgz: i nearly suggested root-disk too | 17:23 |
rogpeppe | i like that as a name | 17:23 |
rogpeppe | although to be accurate it should probably be root-disk-size, though that's probably more verbose than we want | 17:23 |
* rogpeppe smells dal cooking downstairs. time to stop for the day. | 17:24 | |
rogpeppe | g'night all | 17:24 |
sidnei | natefinch: i renamed to root-disk per rog/mgz suggestion. | 17:50 |
natefinch | sidnei: cool :) | 17:51 |
sidnei | natefinch: applied one fix, replied to the rest. seems like it's mostly stylistic issues which i have no opinion about, but neither rog or dimitern catched, so my assumption is that they are fine with them. i'll wait until tomorrow to get a second pass. | 17:57 |
natefinch | sidnei: yeah, nothing terribly important. | 17:57 |
natefinch | arosales: you around? | 19:09 |
=== tasdomas_afk is now known as tasdomas | ||
=== tasdomas is now known as tasdomas_afk | ||
arosales | natefinch, hello | 20:22 |
natefinch | arosales: hey, was talking to John Meinel, looking for something to work on in juju, and he suggested the HP no instances bug you'd looked at | 20:24 |
natefinch | arosales: https://bugs.launchpad.net/juju-core/+bug/1208504 | 20:24 |
_mup_ | Bug #1208504: "error: no instances found" Post bootstrap on HP Cloud <papercut> <juju-core:In Progress by michael.nelson> <https://launchpad.net/bugs/1208504> | 20:25 |
arosales | natefinch, I think michael, noodles775, was working on it | 20:26 |
arosales | natefinch, you may want to touch base with him | 20:26 |
sidnei | natefinch: yeah, noodles775 has a branch started but seems like it was not on the right track | 20:28 |
natefinch | arosales: has there been anything done on it since the comments on the bug? | 20:28 |
natefinch | arosales: ok, thanks | 20:28 |
natefinch | Yeah, I saw the comment from John about fixing the providers. Luckily, I'm not averse to diving in and changing a bunch of stuff if it makes the code better. But I'll touch base with Noodles first. | 20:29 |
arosales | natefinch, I am not 100% sure. Best bet would be to confirm with noodles775 | 20:30 |
natefinch | arosales: cool, ok, thanks. | 20:30 |
arosales | natefinch, I am guessing the notes are up to date, but I can't say for certain. | 20:31 |
sidnei | natefinch: what about https://bugs.launchpad.net/juju-core/+bug/1130372 ? seems like an interesting one | 20:33 |
arosales | natefinch, have you searched papercut bugs? | 20:34 |
* arosales gets the link | 20:34 | |
natefinch | arosales: yeah, I have. I fixed a couple, the HP bug was just what John suggested looking at | 20:35 |
arosales | https://bugs.launchpad.net/juju-core/+bugs?field.tag=papercut | 20:35 |
arosales | ah ok | 20:35 |
natefinch | sidnei: that definitely looks like something we need to address | 20:35 |
sidnei | https://bugs.launchpad.net/juju-core/+bug/1187959 is kinda papercut-ery but might be a bit more involved | 20:35 |
_mup_ | Bug #1187959: juju does not detect instance launch error, waits forever? <juju-core:Triaged> <https://launchpad.net/bugs/1187959> | 20:35 |
natefinch | sidnei: it says it's assigned to Danilo, though that was as of 6/15 and nothing's been posted since then | 20:35 |
sidnei | i don't think danilo is working on it | 20:36 |
arosales | natefinch, some low hanging, wishlist bugs: | 20:39 |
arosales | https://bugs.launchpad.net/juju-core/+bug/1201628 | 20:39 |
_mup_ | Bug #1201628: HP Cloud Boiler-plate (juju init) template has AWS info <bitesize> <juju-core:Triaged> <https://launchpad.net/bugs/1201628> | 20:39 |
natefinch | sidnei, arosales: We have a team meeting in about 12 hours and a standup a few hours after that, I'll talk to people then. Either of those look appropriate, but the pyjuju seems more important, since we don't want to dissuade people from upgrading from pyjuju | 20:39 |
arosales | https://bugs.launchpad.net/juju-core/+bug/1201628 | 20:39 |
_mup_ | Bug #1201628: HP Cloud Boiler-plate (juju init) template has AWS info <bitesize> <juju-core:Triaged> <https://launchpad.net/bugs/1201628> | 20:39 |
arosales | https://bugs.launchpad.net/juju-core/+bug/1210593 | 20:39 |
_mup_ | Bug #1210593: Show the user all current running environments <juju-core:Triaged> <https://launchpad.net/bugs/1210593> | 20:39 |
sidnei | https://bugs.launchpad.net/juju-core/+bug/1190985 is another favorite of mine | 20:39 |
arosales | given I am partial as I submitted those bugs ;-) | 20:39 |
natefinch | haha | 20:39 |
arosales | natefinch, sorry pyjuju? | 20:40 |
natefinch | arosales: https://bugs.launchpad.net/juju-core/+bug/1130372 | 20:43 |
arosales | natefinch, ah ok | 20:44 |
natefinch | arosales, sidnei: I'll keep those on my shortlist if John doesn't have something specific he wants me to work on. | 20:45 |
arosales | natefinch, https://bugs.launchpad.net/juju-core/+bug/1201628 is my vote | 20:45 |
_mup_ | Bug #1201628: HP Cloud Boiler-plate (juju init) template has AWS info <bitesize> <juju-core:Triaged> <https://launchpad.net/bugs/1201628> | 20:46 |
arosales | but like I said I am partial | 20:46 |
arosales | ;-) | 20:46 |
natefinch | arosales: that one *is* pretty embarassing... and I presume pretty trivial to fix | 20:46 |
arosales | sorry I meant to paste, https://bugs.launchpad.net/juju-core/+bug/1201628 | 20:47 |
_mup_ | Bug #1201628: HP Cloud Boiler-plate (juju init) template has AWS info <bitesize> <juju-core:Triaged> <https://launchpad.net/bugs/1201628> | 20:47 |
arosales | ugh | 20:47 |
arosales | this one | 20:47 |
arosales | https://bugs.launchpad.net/juju-core/+bug/1210576 | 20:47 |
_mup_ | Bug #1210576: Show exposed URL after exposing and on command 'show' <papercut> <juju-core:Triaged> <https://launchpad.net/bugs/1210576> | 20:47 |
natefinch | haha | 20:47 |
natefinch | arosales: ahh, neat idea, definitely | 20:48 |
natefinch | arosales: definitely makes for a really good first impression (not that the rest of juju isn't pretty impressive as-is). | 20:50 |
arosales | yup, but john may have some other priorities too, so I think your thought process on checking with his is the correct approach. | 20:51 |
natefinch | arosales: yep | 20:51 |
natefinch | well, it's EOD for me here. | 20:52 |
* thumper looks around for others working | 21:35 | |
* thumper remembers that he is on the other side of the planet | 21:35 | |
* davecheney waves | 21:36 | |
thumper | gym time | 23:54 |
davecheney | thumper: ping | 23:57 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!