| gary_poster | bcsaller, you around? | 01:32 |
|---|---|---|
| bcsaller | gary_poster I am | 01:33 |
| gary_poster | hey bcsaller. How is your import support intended to be used within the context of our current goals? | 01:33 |
| bcsaller | gary_poster: For the store, you create a new db and a topo configured for a bundle, import the YAML into the db and render the topo into some container in the store | 01:35 |
| bcsaller | gary_poster: its not about trying to replicate what the server side deployer does, though that option could exist down the road | 01:35 |
| gary_poster | bcsaller, ah! I see. looking around | 01:36 |
| gary_poster | bcsaller, this branch does not actually hook up the YAML parsing, right? If it does, I'm missing it | 01:38 |
| bcsaller | gary_poster: no, there is no UI on it yet and the YAML isn't required to trigger the function, but the tests show what the parsed YAML looks like, its just imported deployer styled data | 01:39 |
| gary_poster | bcsaller, cool. thanks, was trying to see where it fit in. | 01:39 |
| gary_poster | won't get a chance to review it myself: finishing up closing email with goals etc, | 01:40 |
| bcsaller | I could connect the import code to it though (which makes sense) but we can't really transform many ghosts into real deploys yet | 01:40 |
| bcsaller | for example I don't think we have any special support around pending relations yet (though this can tag those) | 01:40 |
| bcsaller | gary_poster: this is a needed step to rendering bundles in the store | 01:41 |
| gary_poster | and we'll want the import spelling to match what frankban is building in the charm server | 01:41 |
| gary_poster | right bcsaller, got it now. It will also help with letting the fakebackend dupe the deployer | 01:41 |
| gary_poster | but we are not there yet | 01:41 |
| bcsaller | should be easy to change, but its in sync what what is exported now | 01:41 |
| bcsaller | right | 01:41 |
| gary_poster | cool, thank you! by "import spelling" I just mean the APIs that we will use to pass the YAML to the server | 01:42 |
| bcsaller | ahh, ok | 01:42 |
| bcsaller | thanks for taking a peek :) | 01:42 |
| gary_poster | np :-) | 01:43 |
| gary_poster | hey huwshimi, I assigned you to #1207045, #1207041, and #1207039. Do you want to be unassigned from any of them? We need to have them resolved by end of next week. | 01:58 |
| _mup_ | Bug #1207045: Lots of whitespace below the charms on the landing page of the charm browser in fullscreen <charmbrowser> <ie10> <juju-gui:Triaged by huwshimi> <https://launchpad.net/bugs/1207045> | 01:58 |
| _mup_ | Bug #1207041: Opening up charm browser details view shifts environment left in IE10 <charmbrowser> <ie10> <juju-gui:Triaged by huwshimi> <https://launchpad.net/bugs/1207041> | 01:58 |
| _mup_ | Bug #1207039: Inspector settings viewlet has nested scroll bars in IE10 <ie10> <juju-gui:In Progress by huwshimi> <https://launchpad.net/bugs/1207039> | 01:58 |
| huwshimi | gary_poster: I started work on them but put it aside to work on other things. I can pick that up again. I wasn't able to figure out Bug #1207041 | 02:02 |
| _mup_ | Bug #1207041: Opening up charm browser details view shifts environment left in IE10 <charmbrowser> <ie10> <juju-gui:Triaged by huwshimi> <https://launchpad.net/bugs/1207041> | 02:02 |
| gary_poster | huwshimi, I don't want to shift you around randomly, but we do need it done when I said, and the sooner the better. What is a reasonable schedule, given your other goals? | 02:03 |
| gary_poster | huwshimi, I will take your name off that one now | 02:03 |
| huwshimi | gary_poster: I can pick it up again this afternoon | 02:04 |
| gary_poster | cool thanks huwshimi | 02:04 |
| huwshimi | np | 02:04 |
| gary_poster | hatch you around? | 02:11 |
| === schwuk is now known as schwuk_away | ||
| === schwuk_away is now known as schwuk | ||
| bac | benji: is aaron out today? | 13:02 |
| benji | bac: nope, I expect he'll be in momentarily | 13:03 |
| rick_h | yea, next week he's out | 13:03 |
| bac | rt | 13:06 |
| bac | hi abentley, to avoid having staging get the multiple ingesting of baskets bug (due to id vs _id) i'd like to merge the branch you reviewed last night but with the bundle display disabled in search.pt to avoid having a 404 link. seems safer than waiting for my next branch to land, which will be no earlier than tomorrow. | 13:38 |
| abentley | bac: That sounds fine to me. It's not just staging, though. Production also has this bug. | 13:39 |
| bac | abentley: sorry, i got disconnected. did you reply to my question? | 14:01 |
| abentley | bac: Yes. "That sounds fine to me. It's not just staging, though. Production also has this bug." | 14:02 |
| bac | abentley: ok. i'll merge it now. | 14:02 |
| hatch | morning | 14:14 |
| rick_h | morning | 14:15 |
| antdillon | hatch, Morning | 14:43 |
| frankban | bac, benji, or anyone else who wants to look at some python code: could you please review https://codereview.appspot.com/12903044 ? | 14:58 |
| bac | frankban: sure | 14:58 |
| benji | darn, I was too slow | 14:58 |
| frankban | benji: i need two reviews ;-) | 14:58 |
| benji | yay! | 14:59 |
| frankban | heh, thank you both | 14:59 |
| hatch | sooo hows everyones day so far? | 15:15 |
| rick_h | I get to go fishing after work today so the later the day goes the better it gets :P | 15:17 |
| hatch | oh awesome - I almost made it out kiting yesterday but the wind started to die after work so I wasn't going to make the drive | 15:17 |
| hatch | I need to start work about 2h ealier in the off chance that there will be wind | 15:17 |
| hatch | haha | 15:17 |
| hatch | rick_h: what kind of fish are by you? | 15:18 |
| rick_h | the lake I go to is pike, bass, crappie. There's a lot more around the area though | 15:18 |
| hatch | ahh cool | 15:18 |
| rick_h | honestly, I just like going out by the lake as it's really low traffic and chilling for a while | 15:19 |
| hatch | yeah for sure - I hear there are private lakes in the US in the south | 15:19 |
| abentley | sinzui: 1x1? | 15:31 |
| sinzui | abentley, yep | 15:36 |
| * hatch really misses his second monitor | 15:43 | |
| rick_h | jcsackett: bac has access to the analytics I think. I was hoping he'd reply to the email but he's afk it looks like | 15:46 |
| rick_h | noooooooooo, lbox hanging....oh the hate | 15:48 |
| hatch | jujugui guichat in 10, kanban now | 15:49 |
| Makyo | Pff. | 15:49 |
| rick_h | jujugui reviews please https://codereview.appspot.com/12797046 will swap reviews for reviews | 15:49 |
| Makyo | rick_h, you're on. | 15:49 |
| hatch | rick_h: got one | 15:49 |
| Makyo | https://codereview.appspot.com/12900043/ | 15:49 |
| hatch | Makyo: mohohahaha I beat you | 15:49 |
| Makyo | hatch, My clock STILL says 9:49! | 15:50 |
| Makyo | Just flipped over. | 15:50 |
| rick_h | oh noes! my first go review | 15:50 |
| rick_h | Makyo: just either lucked out or is doomed | 15:50 |
| Makyo | Thankfully still in JS :o) | 15:50 |
| rick_h | ah, tricky filenames with go...just not at the end | 15:50 |
| rick_h | there's bac! get him | 15:53 |
| hatch | AHHHHH | 15:54 |
| hatch | that was me charging | 15:54 |
| bac | er? | 15:54 |
| bac | bad internet day | 15:55 |
| hatch | rick_h: review done | 15:56 |
| rick_h | hatch: thanks | 15:56 |
| hatch | next time qa before you propose :P | 15:57 |
| * hatch internet slaps rick_h | 15:57 | |
| rick_h | whoa, hatch advocating more tests? | 15:57 |
| hatch | I know right? lol | 15:57 |
| rick_h | hatch: :P yea, that z is embarrassing | 15:57 |
| hatch | lol | 15:57 |
| bac | rick_h: did you need something? | 15:57 |
| rick_h | hatch: oh well, at least my code has tests | 15:57 |
| hatch | haha | 15:57 |
| rick_h | bac: was going to hit you up on the call, mramm is asking about analytics on jujucharms.com and I thought you had access | 15:57 |
| rick_h | bac: wanted to see if you could reply to the email if you do? | 15:58 |
| rick_h | bac: was to the -peeps mailing list | 15:58 |
| Makyo | jujugui call in2 | 15:58 |
| hatch | rick_h: do you have a yaml file for qa? then I can qa once you update | 15:58 |
| rick_h | hatch: no, I was looking around and didn't find one. | 15:58 |
| bac | rick_h: oh, ok | 15:59 |
| Makyo | frankban, starting without you | 16:01 |
| bcsaller | bac: just ping me when you want to talk then | 16:16 |
| hatch | rick_h: are you planning on expanding those tests? (I just saw that you updated the propose) | 16:16 |
| bac | bcsaller: ok. we don't need to talk if you're just going to say "be aware but you don't really need to do anything now." | 16:16 |
| rick_h | hatch: I'll look at it. | 16:17 |
| rick_h | hatch: I don'pt want to get too 'test all the things' in one test | 16:17 |
| hatch | the extra asserts should be pretty trivial to add | 16:17 |
| bcsaller | bac: thats about the size of it, there will be a method you call with a container node and some bundle data and this will draw it | 16:17 |
| bcsaller | at some point in the future | 16:17 |
| rick_h | hatch: but if they're not touching too many parts at once I'll add them | 16:17 |
| bac | bcsaller: ok, then lets defer | 16:17 |
| bcsaller | fair enough | 16:17 |
| hatch | rick_h: yeah - my idea was that we just want to make sure the plumbing is hooked up :) | 16:18 |
| hatch | rick_h: I lgtm;d so you can submit whenever | 16:18 |
| hatch | afternoon luca | 16:27 |
| rick_h | grabbing food, will have review day afterwards. | 16:32 |
| luca | hatch: Hi Jeff | 16:35 |
| luca | hatch: How's it going? | 16:36 |
| hatch | it's going good, and you? | 16:36 |
| hatch | bcsaller: in my hacking on this databinding stuff I've found some very odd bugs....like where we will have 80+ bindings in `this._bindings` | 16:49 |
| hatch | but I can't find out how to repro them :/ | 16:49 |
| hatch | so I just wanted to make you aware | 16:49 |
| luca | hatch: I'm good :) | 16:49 |
| bcsaller | hatch: remember that we bind each node with a valueChange, not just the container, so its possible for something with many config values to see a lot, but 80 does sound high | 16:50 |
| hatch | yeah the one that was 88 had 32 bindings the next time | 16:50 |
| hatch | so that system needs a refactor....or something | 16:51 |
| hatch | but we already knew that | 16:51 |
| hatch | I'm just surprised it has no negative effects haha | 16:55 |
| === schwuk is now known as schwuk_away | ||
| bcsaller | hatch: I was thinking about it but haven't verified this yet. I think the fillSlot stuff might bind again because the DOM for the slot can be re-rendered. It might be rebinding the whole set at that point w/o clearing the list first. If thats the case it would take some thought to fix because clearing the list would break the contract (bindings can store state as this.whatever). | 17:46 |
| bcsaller | But I think that might be the issue and we could manually clear the old bindings for the inspector in the slot being filled | 17:47 |
| hatch | yeah there is a UI repercussion of this in which the unit_count does not get updated when opening the inspector | 17:48 |
| hatch | so we will have to fix this before we release off flag | 17:48 |
| rick_h | jcsackett: qusetion in bound with my LGTM though | 17:48 |
| hatch | bcsaller: sorry just trying to do something else atm so I haven't put any thought into it | 17:49 |
| bcsaller | I was just trying to think how it could happen | 17:50 |
| hatch | yeah it happens probably 50% of the time | 17:50 |
| hatch | so the inconsistency is my biggest worry | 17:50 |
| hatch | I was so totally just burnt by loose typing js | 18:00 |
| hatch | ouch it hurts | 18:01 |
| rick_h | don't do that | 18:01 |
| bac | this is my favorite docstring ever: | 18:10 |
| bac | """Ensure the future is done and it contains the expected results.""" | 18:10 |
| hatch | bcsaller: should this not trigger the update function? app.env.add_unit('mediawiki', 10) - it adds the units into the db and the status bar ... | 18:12 |
| benji | that's pretty good | 18:12 |
| bcsaller | hatch: which update method, the bindings.unit_count.update one? it should happen after the delta comes back | 18:13 |
| hatch | yeah | 18:14 |
| hatch | it's definitely not | 18:14 |
| hatch | :/ | 18:14 |
| hatch | at least I'm not goin nuts | 18:14 |
| bcsaller | in the console try a change listener on the value and do it manually | 18:14 |
| hatch | sory I don't follow | 18:15 |
| hatch | guichat? | 18:15 |
| bcsaller | taken | 18:15 |
| hatch | ring ring | 18:16 |
| rick_h | bcsaller: review inbound, let me know if I'm missing stuff and we can chat. | 18:21 |
| bcsaller | rick_h: thanks, on a call now | 18:21 |
| benji | bac, abentley, sinzui: ready to finish our discussion? | 18:22 |
| abentley | benji: Sure. | 18:22 |
| * sinzui finds drink | 18:22 | |
| * bac does same | 18:23 | |
| bac | benji, abentley, sinzui: the doc is at https://docs.google.com/a/canonical.com/document/d/17bgbReU6JJMoUHSJeo8egG5zoSM0fpPIs7U8F1-Piyk -- in case i cannot reopen it inside the hangout | 18:27 |
| sinzui | benji, you might recall my nagios branch. I have a separate merge into the unstable charm where I resolved conflicts. Do you have time to review it? https://codereview.appspot.com/12942043 | 19:18 |
| benji | sinzui: my pleasure | 19:18 |
| benji | sinzui: oh, I forgot to mention that since the shell script uses [[ you don't have to quote the variable to avoid expansion | 19:31 |
| sinzui | oh yes. Thanks benji. | 19:33 |
| abentley | sinzui: Could you please review https://code.launchpad.net/~abentley/charmworld/versioned-ids-for-charms/+merge/180225 ? | 19:44 |
| abentley | sinzui: Sorry about the size. It's gotten hard to break out bits. | 19:49 |
| * sinzui looks | 19:53 | |
| hatch | nice post Makyo | 20:00 |
| Makyo | Just figured i'd brag :) | 20:00 |
| hatch | isn't that what blogs are for? | 20:05 |
| Makyo | Yep! | 20:13 |
| hatch | jujugui has anyone started on any of the IE cards yet? | 20:15 |
| Makyo | hatch, doing investigation of the viewBox attribute now. | 20:15 |
| hatch | kewl | 20:16 |
| sinzui | abentley, sorry the the delay. I replied with a question. | 20:56 |
| abentley | sinzui: No worries. This branch took weeks to finish, so an hour reviewing it is nothing :-) | 20:58 |
| hatch | a | 21:07 |
| hatch | bcsaller: if user is looking at the inspector and someone else ups the units...should it up the input as well? | 21:07 |
| hatch | I'm thinking yes | 21:08 |
| hatch | that inputs story is a little confusing | 21:08 |
| hatch | bcsaller: another bug - when I deploy a service then open the inspector fast - the line that we changed in model.js var sum = service.get('units').size(); throws an error that service.get('units') is undefined | 21:15 |
| hatch | I lied, it also happens when deploying a ghost from dragging | 21:16 |
| hatch | I can repro it 100% of the time now so I"ll make a ticket | 21:16 |
| hatch | uh oh someone broke ci!!!!! | 21:28 |
| bcsaller | hatch: yes to the first one. for the second that list is added on the first delta of a unit of that service I think. We can see the other case when the binding is setup so it would be units = service.get('units'); sum = units && units.size() || 0; | 21:34 |
| hatch | https://bugs.launchpad.net/juju-gui/+bug/1212443 | 21:34 |
| _mup_ | Bug #1212443: Drag to deploy to soon after pageload and throws console error <juju-gui:New> <https://launchpad.net/bugs/1212443> | 21:34 |
| hatch | ahh that makes sense | 21:34 |
| bcsaller | The CI looks like it might be a saucelabs issue, might just queue another and see what happens | 21:40 |
| hatch | bcsaller: looks like you were right :) | 22:22 |
| hatch | jujugui has anyone started on adding constraints to the ghost? | 22:40 |
| hatch | jcsackett: kickin around? | 22:45 |
| huwshimi | Morning | 22:58 |
| hatch | morning huwshimi | 23:11 |
| hatch | what are you workin on today? | 23:11 |
| huwshimi | hatch: Finishing off some IE10 stuff | 23:12 |
| hatch | great - so you were saying that the browser shifting things left you wanted to pass off? | 23:13 |
| * hazmat starts playing the story of the ghost in the background | 23:13 | |
| huwshimi | hatch: Well, at this point I haven't figured it out. I left a note on the bug from what I discovered but I haven't managed to figure out the real cause. If someone else wants to take a look that'd be great :) | 23:14 |
| hatch | hazmat: diggin a little Phish at EOD? :) | 23:14 |
| hazmat | hatch, indeed | 23:14 |
| hazmat | hatch, no constraints though ;-) | 23:14 |
| hatch | huwshimi: ok cool - I've been stuck in service constraint and databinding land - it seems like everything I've had to touch is broken lol | 23:15 |
| hatch | so I want to make sure we can get this stuff delievered on time | 23:15 |
| hatch | hazmat: :) | 23:15 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!