| rick_h | hatch: no, it was what I was going to start but IE bugs come first | 00:06 |
|---|---|---|
| hatch | fishing done? | 00:07 |
| rick_h | hatch: yes...why yes it does | 00:10 |
| hatch | catch anything? | 00:10 |
| rick_h | hatch: no, it was not a good trip | 00:10 |
| hatch | oh...? | 00:10 |
| rick_h | lost my pole/reel into the lake... /me isn't proud | 00:11 |
| hatch | haha darn I hate it when that happens | 00:17 |
| rick_h | new rod/reel, just over a week old. Not feeling the love of today | 00:18 |
| hatch | rick_h: last year 2 of my buddies went out fishing in a canoe with all brand new gear - an hour later they returned soaked....they tipped the canoe and lost everything | 00:54 |
| rick_h | doh | 00:55 |
| hatch | counting cell phones and glasses it was probably a $3000 tip | 00:55 |
| hatch | haha | 00:55 |
| rick_h | ouch | 00:55 |
| hatch | yup that was an expensive weekend! | 00:57 |
| Makyo | Good news, everyone. | 01:22 |
| rick_h | Makyo: I like good news | 01:22 |
| Makyo | The viewBox attr on SVGs fixes both FF and IE10 | 01:23 |
| rick_h | Makyo: sweet! | 01:23 |
| Makyo | rick_h, Going to correct the default icons first, then we can figure out a story for charm/icon.svg | 01:23 |
| bcsaller | Makyo: I think the api server can patch them on ingest | 01:36 |
| rick_h | bcsaller: yea, it completely can. Just needs to be added | 01:37 |
| rick_h | bcsaller: and should get it added to the demo/template provided in the docs perhaps | 01:37 |
| Makyo | bcsaller, yeah, that's what I was thinking. Gary was concerned about that as a solution over requesting charm authors to do it themselves. | 01:38 |
| bcsaller | charm authors no more known what they SVG editors save as does than... well... I bet they don't know | 01:39 |
| Makyo | Hah, fair. | 01:39 |
| rick_h | right | 01:39 |
| Makyo | Where's the template, rick_h ? The attribute would change based on the final width/height values, curious how those are specified. | 01:39 |
| rick_h | we'll never have it 'fixed' if we rely 100% on charm authors | 01:39 |
| rick_h | Makyo: sec, in the juju docs. Looking. | 01:40 |
| rick_h | Makyo: https://juju.ubuntu.com/docs/authors-charm-icon.html | 01:40 |
| Makyo | I like that the title is "None" :P | 01:40 |
| rick_h | heh | 01:40 |
| rick_h | but the template is at https://juju.ubuntu.com/docs/media/icon.svg I bet jcastro or marcoceppi can update that if we need. | 01:41 |
| Makyo | rick_h, Alright. From the looks of it, authors may be editing the width/height in Inkscape, as well. I may prowl around through there and see if there's an option in Inkscape itself for viewBox. | 01:42 |
| rick_h | hatch: I submitted without the extra tests but poked at the env and db. Would like to chat about how those 'work' tomorrow if you've got time | 01:42 |
| rick_h | Makyo: cool | 01:42 |
| rick_h | thanks for looking into it. | 01:42 |
| rick_h | hatch: e.g. getting a charm from the db doesn't have the config values in it that I could tell. And there wasn't an idea of fetching the charm from the env I could see either | 01:43 |
| Makyo | rick_h, Okay, found it. Hopefully it's this easy! | 01:46 |
| hatch | rick_h: yeah remind me when I get in and I'll fill ya in | 03:20 |
| hatch | unless you're around now | 03:20 |
| hatch | Makyo: thanks :D | 03:20 |
| rick_h | hatch: around now but past my bed time. I'll hit you up tomorrow | 03:27 |
| marcoceppi | rick_h: what did I do? | 07:11 |
| === schwuk_away is now known as schwuk | ||
| rick_h | heh, well it's closer I guess. Friend was trying to convince me FF was faster than chrome now. Except test suite 37s in chrome and 56s in FF | 12:15 |
| rick_h | it used to be twice as much though, so getting better | 12:15 |
| bac | abentley, benji, sinzui: in a fit of OCD i reorganized the task list on our google doc from yesterday. i also made cards for my tasks in kanban. might be nice to add the ones you've been assigned too. i'll make cards for the unassigned ones. | 13:19 |
| benji | thanks; oh, yeah, I need to add a card for mine too | 13:19 |
| sinzui | thank you bac | 13:19 |
| rick_h | lol, love fits of OCD | 13:20 |
| bac | or CDO as jeff bailey calls it. everything should be alphabetized. | 13:20 |
| rick_h | yay! I have defeated IE! Where is my victory parade? | 13:23 |
| bac | sinzui: if you understand #10 on the list could you re-write it to make sense? it is currently gibberish to me. | 13:24 |
| jcsackett | jujugui: can someone else with ie10 ready confirm that bug 1112783 appears to be fixed? i have tried to reproduce and it works for me. if it works for someone else i'll mark it resolved. | 13:26 |
| _mup_ | Bug #1112783: 'destroy service' never returns from confirmation dialog <ie10> <juju-gui:Triaged> <https://launchpad.net/bugs/1112783> | 13:26 |
| rick_h | jcsackett: sec, will in just a min | 13:27 |
| jcsackett | rick_h: thanks. | 13:27 |
| abentley | bac: ack | 13:30 |
| rick_h | jujugui IE QA/review please https://codereview.appspot.com/12871046 | 13:30 |
| benji | rick_h: looking | 13:30 |
| sinzui | bac, I cannot edit it | 13:31 |
| rick_h | jcsackett: cannot reproduce | 13:31 |
| rick_h | jcsackett: it's from Feb so not surprised we've fixed something between now and then | 13:31 |
| jcsackett | rick_h: huzzah! | 13:31 |
| jcsackett | rick_h: move the card to releasable, or just delete it? | 13:32 |
| bac | sinzui: your gmail id had edit permission. now your canonical does too | 13:33 |
| rick_h | jcsackett: I'd just delete. | 13:33 |
| rick_h | jcsackett: and mark the bug as invalid. If it's releaseable then we'd do fix-released I'd think | 13:33 |
| jcsackett | rick_h: i would say it's fix-released; it wasn't invalid, we just fixed it at some point. but i'll delete the card. | 13:34 |
| rick_h | jcsackett: k | 13:34 |
| rick_h | jcsackett: then keep the card and get bi-weekly bug credit :) | 13:34 |
| jcsackett | :-P | 13:35 |
| jcsackett | Makyo: i see you assigned to the card for bug 1207035, but assigned in LP to 1207036; are you working on both? | 13:36 |
| _mup_ | Bug #1207035: Some charm icons are improperly sized in IE10 <charmbrowser> <ie10> <charmworld:Triaged> <juju-gui:Triaged by makyo> <https://launchpad.net/bugs/1207035> | 13:36 |
| jcsackett | oops, mup didn't pick up the second one. bug 1207036. | 13:36 |
| _mup_ | Bug #1207036: Service SVG icon in inspector is stretched vertically <ie10> <juju-gui:Triaged by makyo> <https://launchpad.net/bugs/1207036> | 13:36 |
| rick_h | jcsackett: he thinks he's got a fix for both with one change | 13:38 |
| rick_h | jcsackett: so those should be good coming soon | 13:38 |
| rick_h | though might need a charmworld branch as well. | 13:38 |
| abentley | bac: Could you please give me edit rights on Charmworld URLs and Pages notes? | 13:39 |
| bac | abentley: your gmail identity has them. i think it automatically granted to all identities in the original chat. | 13:40 |
| bac | abentley: you want me to add your canonical? | 13:40 |
| abentley | bac: Yes, please. | 13:41 |
| bac | abentley: try now | 13:42 |
| abentley | bac: Looks good. | 13:43 |
| bac | abentley: cool. just got smart and opened to all canonical | 13:43 |
| rick_h | jcsackett: can you qa https://codereview.appspot.com/12871046 for me in your fresh IE setup please? | 13:44 |
| jcsackett | rick_h: sure. | 13:48 |
| jcsackett | rick_h: have you seen this happen on IE10 before? happened after i hit the search bar in fullscreen. http://d.pr/i/PpyH | 13:53 |
| rick_h | jcsackett: looking | 13:54 |
| rick_h | jcsackett: oh...interesting...not seen that one | 13:54 |
| jcsackett | rick_h: i'm checking if that happens in trunk. can't imagine it's related to your branch. | 13:54 |
| rick_h | jcsackett: so it does it every time? | 13:54 |
| rick_h | ah, I can dupe it. In fullscreen, missed tghat part | 13:55 |
| jcsackett | rick_h: it does it in trunk, so it's not your branch. | 13:55 |
| rick_h | jcsackett: yea, I bet it's the autocomplete widget which is on comingsoon, but not jujucharms. Will need to file that as a new one | 13:56 |
| rick_h | ugh | 13:56 |
| jcsackett | also, in IE10 if i just load jujugui and click the "browse" button i'm not going to fullscreen. | 13:56 |
| hatch | morning | 13:56 |
| jcsackett | rick_h: can you reproduce that? | 13:56 |
| * jcsackett hopes its something weird locally. | 13:56 | |
| rick_h | jcsackett: no, it changes modes for me | 13:56 |
| jcsackett | huzzah! | 13:56 |
| jcsackett | morning, hatch. | 13:57 |
| rick_h | jcsackett: ok, will file the AC bug and add a card for that | 13:57 |
| jcsackett | rick_h: ok. | 13:57 |
| jcsackett | i'll update your MP with my QA ok. | 13:58 |
| hatch | brb | 13:58 |
| jcsackett | rick_h: got any notions of why AC pushes down the rest of the screen? i'm free to pursue the bug, but would like pointers if you've got 'em. | 14:00 |
| rick_h | jcsackett: thanks for the search link then | 14:01 |
| rick_h | jcsackett: errr, the notion that it's used in search as well | 14:01 |
| rick_h | jcsackett: so basically going to be something in the css of the autocomplete that's not being position absolute I guess. | 14:01 |
| rick_h | jcsackett: I'd just start going through the .aclist* classes and nodes and seeing if they can be tweaked | 14:02 |
| jcsackett | rick_h: ok. | 14:02 |
| jcsackett | rick_h: i'm actually less free than i thought--hatch emailed me a bug last night i need to look into as it appears to be browsercharm fallout. | 14:03 |
| jcsackett | probably simple though, so i should be able to get to AC soon. | 14:03 |
| rick_h | jcsackett: rgr | 14:03 |
| jcsackett | hatch: i saw your email and the bug, but i can't reproduce. | 14:06 |
| hazmat | sinzui, incidentally that rack charm store issue is caused by a bug in the charm itself | 14:07 |
| sinzui | hazmat, great. | 14:07 |
| sinzui | hazmat, details | 14:07 |
| sinzui | or update the bug | 14:07 |
| hazmat | sinzui, i replyd via email, its going to take a few for lp to publish | 14:08 |
| sinzui | thanks | 14:08 |
| hatch | jcsackett: hmm I just did http://comingsoon.jujucharms.com/:flags:/serviceInspector/ dd mediawiki, click 'destroy service' click 'confirm', see error in console | 14:08 |
| jcsackett | hatch: i missed destroy was available before deploying. | 14:13 |
| hatch | :) | 14:15 |
| jcsackett | hatch: btw, it's "Jon" not "John". :-P | 14:18 |
| hatch | yeah....well..... | 14:18 |
| hatch | yeah I got nothin | 14:19 |
| hatch | oops :) | 14:19 |
| abentley | jcsackett: I always thought jc was short for Jesus Christ :-P | 14:21 |
| jcsackett | only in my most meglomaniacal moments. | 14:22 |
| rick_h | I have slain the mighty IE! All bow before my...oh wait...my bad | 14:22 |
| * jcsackett laughs | 14:22 | |
| hatch | or that his last name was Penney | 14:22 |
| jcsackett | yes, because none of these are jokes i have heard a thousand times. :-P | 14:23 |
| hatch | or Chasez | 14:23 |
| hatch | have you heard THAT one? | 14:23 |
| jcsackett | i have not. well played. | 14:23 |
| jcsackett | only half credit though, as it's just a variation on a theme. :-P | 14:23 |
| hatch | lol true true | 14:24 |
| jcsackett | hatch: fix up for that bug https://codereview.appspot.com/12795046 | 14:26 |
| jcsackett | can you review? | 14:26 |
| hatch | on it | 14:26 |
| jcsackett | jujugui: i suppose even though it's one line, i need one other reviewer.:-P ^ | 14:27 |
| hatch | there are two now | 14:27 |
| rick_h | jcsackett: already done, but figured you'd trivial it | 14:27 |
| jcsackett | rick_h: i usually eschew trivial when the fix is for actual breakage. | 14:28 |
| jcsackett | and thanks for the review. | 14:28 |
| rick_h | np | 14:28 |
| hatch | rick_h: when did you want to go over the db stuff | 14:30 |
| rick_h | hatch: after the standup call ok? | 14:30 |
| hatch | yep no problem | 14:30 |
| sinzui | abentley, jc is short for our lord and savour John Cleese. | 14:32 |
| jcsackett | ok, *that* one is new. | 14:33 |
| hatch | jcsackett: oh crud it's a little late now but we should have added a test for that bug | 14:39 |
| * hatch hasn't had his coffee yet | 14:40 | |
| abentley | sinzui: chat? | 14:43 |
| hatch | jcsackett: I can add that test | 14:43 |
| jcsackett | hatch: ok, i'm pursuing a css issue with AC in IE10. if you've not gotten around to the test before i'm done with that, i can pick it up then. | 14:44 |
| hatch | I'll start on it now, I need a break from this constraints stuff | 14:44 |
| sinzui | abentley, in 15? I am in meetings | 14:45 |
| abentley | sinzui: sure. | 14:45 |
| abentley | sinzui: How's it going? | 15:10 |
| sinzui | abentley, all clear. we can talk | 15:11 |
| abentley | sinzui: hangout at https://plus.google.com/hangouts/_/666d51fb65e7f2ce7442c104ad381044fefac89a?hl=en-GB | 15:12 |
| marcoceppi | Hi juju-gui people. Question about the canvas in gui. (well, two) | 15:15 |
| Makyo | Shoot, marcoceppi | 15:16 |
| marcoceppi | One, is it worth filing a bug to disable right-click context menu from the browser on the gui? We had 21 users who were operating under the assumption that in order to bring up the menus they needed to right click (they also though that the long click was right click only) and were getting frustrated by having the browser menu pop up when using right click | 15:16 |
| marcoceppi | after showing them it was all Mouse 1 they got it, so I'm just doing due diligence as I said I'd bring it up with you guys | 15:17 |
| Makyo | marcoceppi, jujugui, I say file it, and then we can triage it during calls. From my point of view, it makes enough sense, at least on the canvas. | 15:17 |
| marcoceppi | thanks | 15:17 |
| hatch | yeah that's a tough one from past experience | 15:18 |
| hatch | if you're going to disable it, it needs to have a custom one | 15:18 |
| hatch | else I've found people get equally frustrated hah | 15:18 |
| * hatch included | 15:18 | |
| rick_h | why would people right-click on the web? /me never would have even thought of thatr | 15:18 |
| hatch | lol | 15:18 |
| benji | if that's what the users expect, we could also actually make right click bring up the menu | 15:18 |
| hatch | benji: right | 15:18 |
| marcoceppi | the second question is more of a bug, but I wanted a sanity check on it. Currently I can't highlight text when drilling down in to the unit view (ie, click on service, click on unit, try to select IP address to copy), is this a known issue? Expected behavior? If not I'll also file a bug | 15:18 |
| rick_h | Makyo: hmm, maybe we can deploy flag something like that? /me doesn't want to lose 'right-click - inspect element' even in the canvas | 15:19 |
| marcoceppi | rick_h: maybe enable a "developer" mode which doesn't override right click? | 15:19 |
| marcoceppi | Any event I'll create a bug for you guys to track it | 15:19 |
| hatch | marcoceppi: I think the selection was disabled, checking | 15:20 |
| hazmat | the inspector mode will change that | 15:20 |
| Makyo | rick_h, agreed. | 15:20 |
| hatch | marcoceppi: just to confirm this is in the new inspector? | 15:20 |
| marcoceppi | hatch: I've just been deploying cs:precise/juju-gui | 15:20 |
| marcoceppi | So whatever that constitues | 15:20 |
| hazmat | the old unit/service view it sounds like | 15:20 |
| hatch | but do you add /:flags:/serviceInspector to the url? | 15:21 |
| Makyo | hatch, marcoceppi - no, drilling down is old behavior. | 15:21 |
| marcoceppi | If there's a new inspector coming I'll just let them know that new cool shit is coming and to just dealwithit.gif | 15:21 |
| Makyo | hatch, yeah, stuff under feature flags wouldn't be used in these contexts, I don't think | 15:22 |
| hatch | marcoceppi: fyi on comingsoon.jujucharms.com I can't repro your select issue | 15:22 |
| hatch | but yes big changes coming down the pipe soon :) | 15:22 |
| * marcoceppi peeks | 15:22 | |
| marcoceppi | I like the slider | 15:22 |
| marcoceppi | hatch: ah, yeah selecting text works. Thanks! | 15:23 |
| marcoceppi | We had about 25 people using the GUI for the first time, all really overwhelmingly good feedback outside of the above questions! | 15:23 |
| hatch | oh that's so awesome to hear :) | 15:24 |
| rick_h | marcoceppi: good to hear | 15:24 |
| marcoceppi | I saw them using it more than they were the cli ;) | 15:24 |
| Makyo | Excellent :) | 15:24 |
| hatch | haha perfect ;) | 15:24 |
| jcsackett | rick_h: i think i have a fix up for the AC thing. care to review? https://codereview.appspot.com/12760045/ | 15:44 |
| rick_h | jcsackett: sure thing, doing the lbox dance with mine right now. Will pull/check it out when it's done | 15:44 |
| rick_h | and swap you reviews :) | 15:44 |
| rick_h | jcsackett: oh, can you see if that fixes the home bug I filed as well then? Seems it might be related. #1212695 | 15:45 |
| _mup_ | Bug #1212695: home link moves during search in ie10 <ie10> <juju-gui:Triaged> <https://launchpad.net/bugs/1212695> | 15:45 |
| rick_h | jcsackett: maybe not, nvn | 15:46 |
| jcsackett | rick_h: i'll look. | 15:46 |
| jcsackett | but yeah. | 15:46 |
| jcsackett | rick_h: nvm on my MP. | 15:49 |
| jcsackett | in looking at yours i've realized mine introduces a new horror. | 15:49 |
| jcsackett | (your bug, not your MP) | 15:50 |
| jcsackett | goddamn IE requiring absolute positioning... | 15:50 |
| hatch | jujugui guichat in 10 kanban now | 15:50 |
| rick_h | jcsackett: ugh, yea I was afraid of that. | 15:51 |
| rick_h | jujugui couple of reviews please, not IE specific. Happens in all browsers. https://codereview.appspot.com/12997043 but the bug was noted in IE | 15:51 |
| jcsackett | rick_h: looking. | 15:51 |
| Makyo | rick_h, on it. | 15:51 |
| rick_h | thanks guys | 15:54 |
| hatch | jujugui looking for 2 very quick reviews on https://codereview.appspot.com/12998043/ as well | 15:55 |
| Makyo | hatch, on it | 15:58 |
| hatch | thanks | 15:58 |
| bcsaller | think its already got two :) | 15:58 |
| hatch | jujugui guichat in 2 | 15:58 |
| Makyo | bcsaller, hatch Well...bonus! | 15:59 |
| bcsaller | everyone likes more tests | 15:59 |
| Makyo | \o/ | 16:00 |
| hatch | jujugui guichat on now | 16:00 |
| jcsackett | ok. i'm going to get lunch. IE10 has temporarily dispirited me. | 16:28 |
| rick_h | jcsackett: hah, don't let it beat you down! | 16:29 |
| hatch | are constraints supposed to be 'dumb' right now? Or are we supposed to be pulling the options from juju? | 16:42 |
| rick_h | no idea | 16:46 |
| hatch | I love lines that are 80 characters long | 16:59 |
| hatch | such - a -rebel | 16:59 |
| rick_h | down with him! | 16:59 |
| hatch | ugh I can't wait until we switch to sass and have sourcemaps for our css | 17:01 |
| lovea | Quick question about charm deployments - Juju client run on node that has internet access and on isolated internal LAN, Juju boostrap node on isolated LAN/no internet access, Juju-GUI node on isolated LAN/no internet access. Q1: Does Juju client pull charms from the charm store and push to Juju bootstrap node? Q2: Is Juju-GUI node useless without an internet connection to pull pickable charms from? | 17:07 |
| rick_h | lovea: the final point is true. The Gui needs access to https://manage.jujucharms.com to show the list of available charms to pick from. | 17:08 |
| rick_h | icons and data are pulled from that data endpoint | 17:08 |
| lovea | rick_h: ok, thought so | 17:09 |
| rick_h | hatch: Makyo do you guys know how a 'deploy' goes down? Does the gui send the charm over to the bootstrap node? Or do we just tell it to fetch it? | 17:12 |
| Makyo | rick_h, we just tell it to fetch it. | 17:12 |
| hatch | just fetch it | 17:12 |
| rick_h | Makyo: cool, thanks. What I assumed. | 17:12 |
| rick_h | lovea: so does that answer the other part then? | 17:12 |
| lovea | Forgive my ignorance but would the theory be that, given an internet enabled Juju-GUI node, I could wire up my charms to meet my specific deployment needs as a "model", export the "model", use the Juju client to actually implement the "model" in my isolated environment. | 17:13 |
| Makyo | rick_h, lovea GUI will work as a monitoring tool behind the firewall, would still show the environment, but charm-store would be empty. | 17:13 |
| Makyo | lovea, yes. You can use the GUI and then export (or even just write down) your environment to be deployed elsewhere. | 17:14 |
| Makyo | lovea, There is a section on "Deploying behind a firewall" at https://jujucharms.com/fullscreen/search/precise/juju-gui-74/?series=precise&text=juju-gui&type=approved#bws-readme | 17:15 |
| lovea | or are we saying that Juju bootstrap node also needs to be internet enabled because it gets fetch instructions from Juju client? | 17:15 |
| lovea | Makyo: ok I'll read up on this. Many thanks | 17:15 |
| Makyo | lovea, the bootstrap node would only need internet if deploying charms from the charmstore (eg: "cs:precise/mysql"). Using the CLI, one can deploy local charms, however. | 17:15 |
| lovea | rick_h, Makyo: Thans for te clarifications | 17:16 |
| Makyo | Cheers. | 17:17 |
| lovea | quit | 17:21 |
| benji | abentley: the bundle API tweak branch is up for review if you have a moment (after lunch): https://code.launchpad.net/~benji/charmworld/update-bundle-api/+merge/180384 | 17:24 |
| abentley | benji: Okay. | 17:24 |
| hatch | rick_h: what was the trick you used to get templates auto generating again? | 17:31 |
| rick_h | hatch: there was a typo in the dir name in the config of places to look? | 17:31 |
| hatch | ahh right | 17:31 |
| rick_h | manually I'd do rm build-shared/juju-ui/templates.js && make build-shared/juju-ui/templates.js | 17:32 |
| hatch | yeah that's it, I'll try that | 17:32 |
| abentley | benji: I have an important call in 15 and I need to do some prep. Is it cool if I delay your review by an hour or so? | 17:43 |
| abentley | benji: I have some thoughts, but haven't gotten everything done. | 17:43 |
| benji | abentley: sure | 17:44 |
| hatch | bcsaller: this collective event stuff has gota be fixed lol | 17:46 |
| jcsackett | does IE have any sort of dev tools? | 17:48 |
| hatch | F12 | 17:48 |
| rick_h | jcsackett: yea, in the options is "developer tools" | 17:48 |
| hatch | they are 'sort of dev tools' | 17:48 |
| rick_h | (right side gear) | 17:48 |
| hatch | F12 opens it | 17:48 |
| rick_h | yea, I noticed 'debugger;' didn't do me any good :( | 17:48 |
| rick_h | and the element selector only half works | 17:49 |
| hatch | nope you have to click 'start debugging' | 17:49 |
| hatch | the element selector works only if you hit 'refresh' in the devtools first | 17:49 |
| jcsackett | rick_h: i do not have a developer tools option in my gear menu. f12 worked though. | 17:49 |
| hatch | jcsackett: they actually market it as "The F12 Developer Tools" :D | 17:50 |
| rick_h | jcsackett: oh, ok then | 17:50 |
| * jcsackett continues to loathe IE. | 17:50 | |
| rick_h | carry on | 17:51 |
| hatch | they say the IE11 ones are actually real devtools | 17:51 |
| * hatch is hoping | 17:51 | |
| hatch | I used to have to support IE7+ | 17:51 |
| * jcsackett is hoping to never need IE11 tools, b/c he's hoping to never to IE work again. | 17:51 | |
| hatch | AND the 'simulator' in IE10 doesn't even come close to simulating IE8,9 properly | 17:51 |
| hatch | sorry :) | 17:51 |
| jcsackett | rick_h: got a bit to chat? my current approach is so error prone i think i need to step back and maybe hear other ideas. | 17:52 |
| rick_h | the 9 one did a good job with 8 | 17:52 |
| rick_h | jcsackett: sure thing | 17:52 |
| jcsackett | rick_h: guichat is open. | 17:52 |
| hatch | rick_h: also lemme know when you want to chat about the db stuff | 17:53 |
| Makyo | Hm. Good news, bad news. | 17:57 |
| Makyo | Good news: ingest now adds viewBox to icons. It works in FF and IE. | 17:57 |
| Makyo | Bad news: it only MOSTLY works in IE. | 17:58 |
| Makyo | This wouldn't be easy >:/ | 17:58 |
| hatch | what's mostly? :) | 17:58 |
| Makyo | It fixes the icons in the service blocks, but not in the browser (which might be because they're not styled with a size - investigating), and not in the inspector (for potentially the same reason) | 17:59 |
| hatch | ARG!!!! I can't propose my branch until I upgrade jshint so I can tell it about globals...... | 18:00 |
| hatch | Makyo: ahh ok, well good luck :) | 18:00 |
| Makyo | What globals? | 18:00 |
| hatch | this._unitSpinner = new Spinner({ | 18:00 |
| Makyo | Oh, and Spinner isn't provided by YUI or anything? I mean, that's how we get d3. | 18:01 |
| hatch | I should be able to do /* global Spinner */ | 18:01 |
| hatch | I think d3 is defined by the namespace methods | 18:02 |
| hatch | so it's not actually a global | 18:02 |
| hatch | we dont jslint the html so that's why this hasn't come up before | 18:02 |
| hatch | :/ | 18:02 |
| Makyo | Nah, not that I can see. It's just used immediately in app/topology/topology.js | 18:03 |
| Makyo | Oh well, though. | 18:03 |
| Makyo | We've used the spinner before in JS, though. It hasn't come up yet? | 18:04 |
| hatch | hmm you're right | 18:04 |
| hatch | nope the spinner is only ever used in index.html | 18:04 |
| hatch | and in my new code | 18:04 |
| hatch | ohh wait | 18:05 |
| hatch | I was grepping crappy | 18:05 |
| Makyo | and app/widgets/overlay-indicator.js | 18:05 |
| hatch | guess I'll have to make this spinner in the index.html as well | 18:05 |
| hatch | :/ | 18:05 |
| hatch | I am curious as to how d3 is being defined there | 18:06 |
| hatch | in topology.js | 18:06 |
| hatch | as in why the linter isn't going wako | 18:06 |
| Makyo | What is Y.spinner.getSpinner()? | 18:07 |
| hatch | I guess I could refactor that to be a generator | 18:08 |
| Makyo | It's already there, that's what I'm saying. | 18:08 |
| hatch | but even there it's not blowing up... | 18:08 |
| Makyo | I'm sure you'll figure it out. We're all counting on you., | 18:08 |
| hatch | lol | 18:09 |
| hatch | /rage | 18:09 |
| Makyo | So why won't Y.spinner.getSpinner() work in your case? | 18:09 |
| hatch | it's mergingness of it's options will not work for some of the options i need | 18:10 |
| Makyo | Can't you provide an options object? | 18:10 |
| hatch | so I can fix that....but I'm not sure if that's the right place | 18:10 |
| Makyo | I'm not sure what you mean by mergingness, so... | 18:10 |
| hatch | it merges it's defaults with the config that I need | 18:11 |
| hatch | so I'll either need to specify more options resetting them to other defautls | 18:11 |
| hatch | or patch the file | 18:11 |
| hatch | script* | 18:11 |
| rick_h | jcsackett: http://paste.mitechie.com/show/1002/ | 18:12 |
| Makyo | Patching sounds notsogood. Is there an issue with specifying all the options you need? | 18:12 |
| hatch | well nothing beyond I have to go find out what the defaults are | 18:13 |
| hatch | when the issue at hand is really the tools | 18:14 |
| Makyo | That's fair, and perhaps working with upstream is required, but working with tools is kinda what we do. | 18:15 |
| rick_h | hatch: reuse the existing spinner. What's wrong with it? | 18:15 |
| hatch | it doesn't fit in an input box and isn't blue :) | 18:15 |
| bcsaller | hatch: can't you just use an animated gif for the little in <input> field spinner you need? | 18:15 |
| rick_h | well, wtf is 'blue' a thing? Spinner is standardized. | 18:15 |
| rick_h | and we can adjust the size in the widget if we need I believe | 18:16 |
| rick_h | ah, nvm. We use the same animated gif, not js spinner. We had a bug for that at some point | 18:16 |
| hatch | bcsaller: only if you have one :) | 18:16 |
| bcsaller | hatch: http://www.ajaxload.info/ ;) | 18:17 |
| hatch | lol | 18:17 |
| rick_h | hatch: why are we spinning a single input box? | 18:17 |
| hatch | indicator to let the user know units are being spun up | 18:17 |
| rick_h | link to the UX mockup? | 18:17 |
| hatch | v11 | 18:18 |
| hatch | oh it's on the dropbox one | 18:18 |
| hatch | I don't have the link on this machine | 18:18 |
| bcsaller | in google drive if you search inspector and pull the v11 hit though its there | 18:18 |
| rick_h | yea, loading/looking | 18:18 |
| hatch | it's ok I have updated the linter already | 18:19 |
| hatch | there is only 2145 errors! | 18:19 |
| rick_h | the little blue refresh-looking thing? | 18:19 |
| hatch | oh that was only 33% of the files heh | 18:20 |
| hatch | I think it needs some config options | 18:20 |
| hatch | rick_h: yes | 18:20 |
| rick_h | hatch: well where's the assets for it then :P | 18:20 |
| rick_h | why are you complaining about Spinner when you can't use that anyway | 18:20 |
| * rick_h is confused | 18:20 | |
| Makyo | This sounds like a less than ideal path, and also counter to what we've done in the past of two-step implement-and-then-style branches. | 18:21 |
| hatch | so drop the spinner? | 18:22 |
| rick_h | yea, until you have the assets to implement it imo | 18:22 |
| Makyo | Or implement A Spinner, and style it later. | 18:22 |
| rick_h | yea, I guess I'd do it textual with a "replace with gif when available" | 18:23 |
| hatch | it is implemented heh | 18:23 |
| Makyo | Eh, nevermind, I'm out. Gotta eat, then propose the charmworld stuff. | 18:24 |
| hatch | bcsaller: I'm going to grab the asset from there I guess :) | 18:27 |
| hatch | interesting the old jshint accepted our json files, the new one does not | 18:30 |
| hatch | looks like it doesn't accept the old config file | 18:31 |
| hatch | yeah it'll take a bit to reconstruct this config | 18:34 |
| hatch | bcsaller: it appears that the databinding system doesn't like to have multiple fields bound to the same value | 19:10 |
| hatch | ohh wait nm | 19:12 |
| hatch | wait nope it's definitely broken | 19:13 |
| hatch | it only ever calls the update method once regardless of how many fields are bound | 19:14 |
| hatch | the 'target' gets overridden by the last element with the binding set to it | 19:16 |
| Makyo | jujugui charmworld branch for viewbox on icons (default and ingested) https://codereview.appspot.com/13001044 | 19:16 |
| benji | Makyo: I assume you're looking for a review. I'll take a look. | 19:17 |
| hatch | looks good to me but I'm not really qualified :) | 19:17 |
| bac | Makyo: i'll look | 19:17 |
| Makyo | benji, bac Yes, thanks. | 19:17 |
| bac | Makyo: have you run 'make lint'? | 19:20 |
| Makyo | bac, not yet, had assumed .lbox.check did that, will do it now. | 19:21 |
| bac | Makyo: hey you could add that to .lbox.check if you wanted. but, the charmworlders are not generally using lbox. | 19:22 |
| Makyo | bac, Oh, okay, maybe I'll do that. | 19:23 |
| bac | Makyo: actuallly, charmworld is using tarmac to land, triggered by the merge proposal on LP. so using lbox is actually problematic. | 19:27 |
| Makyo | bac, Only once the MP is marked approved, though, right? | 19:28 |
| bac | Makyo: i'll go vote approved on LP. you'll then need to set a commit message and mark the whole thing Approved when you're ready to land. | 19:28 |
| Makyo | bac, so propose shouldn't affect it, just don't submit? | 19:28 |
| Makyo | bac, okay. Only done this once before :/ | 19:29 |
| bac | Makyo: votes need to be recorded over there too. btw, charmworld is only requiring one review | 19:29 |
| Makyo | Oh, okay. | 19:29 |
| bac | Makyo: for now, it may make sense to change .lbox.check to be only run /bin/false | 19:30 |
| Makyo | benji, single/double quotes: the processing instruction is generated by ElementTree with single quotes, but attributes are generated with double quotes. I could switch to single quotes and escape the internal ones, but I figured this was cleaner. | 19:32 |
| benji | Makyo: that makes sense; maybe it's worth commenting | 19:33 |
| Makyo | benji, Alright. As for the logs issue, I was under the impression that we should be adding the attribute on ingest, since we can as long as we have width/height (it's just 0 0 <width> <height> every time). Should I log it anyway, or die, or..? | 19:34 |
| benji | Makyo: ah, so we just need the attributes, even if they are 0? If so, a warning (or info, or nothing) seems fine. I would add a comment about why we're doing what we're doing though. | 19:36 |
| Makyo | benji, I can check for 0 as well, since that would be a malformed SVG. Logging and commenting sound fine too. | 19:37 |
| benji | well, you can use lbox for inline code reviews if you want, but landing has to be done through LP | 19:39 |
| Makyo | Alright. | 19:40 |
| abentley | sinzui: I just landed versioned charm-ids. | 19:57 |
| abentley | sinzui: Or rather, deployed them to staging. | 19:58 |
| sinzui | \o/ | 19:58 |
| hatch | awesome! | 20:14 |
| hatch | bcsaller: I'm going to work around this now but I'd like your input whenever you have some spare time https://bugs.launchpad.net/juju-gui/+bug/1212813 | 20:17 |
| _mup_ | Bug #1212813: databinding only allows a single field to be bound to an attribute <juju-gui:New> <https://launchpad.net/bugs/1212813> | 20:17 |
| sinzui | abentley, benji: do either of you have time to review my unsexy branch that adds the concept of API3 https://code.launchpad.net/~sinzui/charmworld/add-api-3/+merge/180426 | 20:43 |
| abentley | sinzui: Sure. | 20:44 |
| abentley | sinzui: For the test_health changes, it looks like thge test cases are almost identical. Have you considered using two TestCases and just overriding the check_api call? | 20:54 |
| sinzui | abentley, I can do that. | 20:54 |
| abentley | sinzui: The indentation at 173-174 looks odd to me. I'd expect it to line up with the opening paren, or else for it to be indented once. | 20:55 |
| abentley | sinzui: check_api3 isn't used yet, right? | 20:56 |
| sinzui | abentley, nasty pep8 check wanted the if continuation separated from the lines executed | 20:56 |
| sinzui | abentley, check_api3 is used by the /heartbeat view | 20:57 |
| sinzui | Its check though uses the same rules as API2 | 20:57 |
| sinzui | almost the same rules | 20:57 |
| sinzui | all the checks have a common control structure | 20:58 |
| abentley | sinzui: How does check_api3 get referenced by /heartbeat? | 20:58 |
| abentley | sinzui: nm, found it. | 20:58 |
| sinzui | line 244 | 20:59 |
| abentley | sinzui: r=me. | 21:00 |
| sinzui | abentley, thanks. I'll refactor the tests before landing | 21:00 |
| Makyo | Good news everybody. | 21:16 |
| bcsaller | hatch: having looked at it I don't see why that would be true (it used to be when we used a map for _bindings, but now its an array) | 21:16 |
| Makyo | I was actually insane when I said things didn't work on Chrome. Thinks work fine :) | 21:17 |
| Makyo | s/chrome/IE10 | 21:17 |
| hatch | Makyo: yay for insanity! | 21:17 |
| Makyo | "things are actually alright" is the best kind of insanity. | 21:17 |
| hatch | I think that's insanity after the medication | 21:17 |
| Makyo | Hah! I reverted my config change before I checked the icons last time. | 21:17 |
| Makyo | It looks like the branch approved earlier fixes most icon issues. | 21:18 |
| Makyo | Minus the one in the inspector, but that appears to be styled wrong. | 21:18 |
| Makyo | jujugui need one quick review for trivial: https://codereview.appspot.com/12828045/ | 21:36 |
| hatch | Makyo: lgtm | 21:37 |
| Makyo | hatch, thanks. | 21:37 |
| * hatch is furious - sent my wifes HTC One in for repairs because the screen is separating and they just called saying that the repair depo says it's physical damage and that it'll be $250 | 21:40 | |
| hatch | but of course I can't talk to anyone about this bs until tomorrow | 21:42 |
| hatch | good thing I took pictures of the device before it was shipped | 21:43 |
| * Makyo finally dogwalks | 21:59 | |
| hatch | bcsaller: hmm not sure - I've been fighting getting the tests to pass again so I haven't looked into it much but I know that the 'update' method was only called with a single value (the last one) so we'll just have to look at that sometime in the future | 22:10 |
| bcsaller | hatch: I'll try adding a test for it to what I'm doing now. Does your branch already include the change to sum up the changeKeys between updateDOM intervals, because this would look like that as well I think | 22:12 |
| hatch | bcsaller: here is my branch https://code.launchpad.net/~hatch/juju-gui/scale-up-ui | 22:14 |
| hatch | a....plethora of tests fail now hah | 22:14 |
| hatch | if plethora was 7 | 22:14 |
| hatch | well...7 is when it stops | 22:14 |
| hatch | there is probably a lot more | 22:14 |
| hatch | arg I broke the databinding | 22:34 |
| hatch | bcsaller: have a minute to take a look at my databinding code? | 22:44 |
| hatch | I'm sure I'm missing something obvious | 22:44 |
| bcsaller | hatch: what part do you want me to look at? | 22:44 |
| hatch | http://bazaar.launchpad.net/~hatch/juju-gui/scale-up-ui/view/head:/app/views/databinding.js#L194 | 22:44 |
| hatch | for some reason this causes the conflict code to apply the conflict style to the wrong element | 22:44 |
| hatch | which element....I'm not sure....possibly the mirror one? | 22:45 |
| hatch | bcsaller: if I comment out 194-204 it works as expected | 22:45 |
| bcsaller | hatch: I think you put the key collapse code in the wrong place though, I saw this living in modelChangeHandler (dealing only with keys) and cleared in updateDOM. By dealing only with keys at that layer we can select all bindings that match those keys in deltaFromChange | 22:46 |
| bcsaller | does that make sense? | 22:46 |
| bcsaller | you try and remove dup bindings, but this is the binding, not the change, we just want all the bindings matching a key at this point | 22:48 |
| bcsaller | (or a set of keys) | 22:48 |
| bcsaller | if you'd like I can take a stab at it | 22:48 |
| hatch | hmm maybe I've been staring at this too long because I was under the impression that I was aggregating the deltas using this technique | 22:49 |
| bcsaller | deltasFromChange is only the delta in the keyspace of the model, not the change events | 22:50 |
| bcsaller | you are close though | 22:50 |
| hatch | ok I am totally missunderstanding what's happening here then - maybe if you wouldn't mind fixing it so I can see what I'm missing | 22:51 |
| * hatch slides a pint of beer across the table | 22:52 | |
| hatch | how about now? | 22:52 |
| hatch | :) | 22:52 |
| bcsaller | hatch: happy to, I'll write it now and you can merge when I have it ready | 22:52 |
| bcsaller | virtual beer... | 22:52 |
| hatch | awwwwsuuuummmm | 22:52 |
| hatch | next sprint - real beer | 22:52 |
| huwshimi | Morning | 23:04 |
| hatch | hey huwshimi how are you doing? | 23:04 |
| huwshimi | hatch: Good thanks, yourself? | 23:04 |
| hatch | could be better :) | 23:06 |
| huwshimi | hatch: Are you sick? | 23:08 |
| hatch | nah, just stupid things happening today | 23:08 |
| huwshimi | oh | 23:08 |
| hatch | HTC repair depo not wanting to fix my wifes One set me off | 23:08 |
| hatch | huwshimi: so hows that IE stuff coming? | 23:11 |
| bcsaller | hatch: so I *think* this should fix it, but I didn't generate a full test for the multiple key case as getting the timing right on that would delay you actually testing it. lp:~bcsaller/juju-gui/databinding-safeupdate | 23:12 |
| hatch | bcsaller: ok looking thanks | 23:13 |
| bcsaller | hatch: if that doesn't help I'll keep at it with you | 23:13 |
| hatch | bcsaller: ok I gota merge this in manually so it'll take a second | 23:15 |
| bcsaller | hatch: if you didn't change databindings.js for anything else take that version | 23:15 |
| hatch | yeah I added the prev value stuff | 23:16 |
| huwshimi | hatch: Our animating input fields are being a pain. We need to set the inputs in the inspector to a flexible width as the size of the scrollbars varies between browsers. | 23:16 |
| bcsaller | router issue, might lose wifi here | 23:18 |
| hatch | ok merged...trying | 23:19 |
| hatch | bcsaller: awesome, fixed | 23:21 |
| bcsaller | sweet | 23:21 |
| hatch | thanks a ton | 23:21 |
| hatch | now to figure out the difference | 23:22 |
| hatch | I think I saw it though | 23:22 |
| bcsaller | yeah, I was going to ask | 23:22 |
| hatch | ahhhh now I see now I see | 23:22 |
| bcsaller | this just accumulates keys until updateDOM is called | 23:22 |
| hatch | you only deal with the keys not the datasets | 23:22 |
| bcsaller | yeah | 23:22 |
| bcsaller | keeps it simple | 23:23 |
| hatch | I'm not entirely clear why my technique broke it though | 23:23 |
| hatch | clearly it was wrong...but I don't know why.... | 23:23 |
| bcsaller | you thought delta in deltaFromChange means ws delta changes or something | 23:23 |
| bcsaller | we are selecting the binding objects for model change keys here | 23:23 |
| bcsaller | so a set of keys becomes a set of bindings | 23:23 |
| bcsaller | not change events | 23:24 |
| hatch | ohh that's why it was pointing to the incorrect element | 23:24 |
| hatch | ok got it now | 23:24 |
| bcsaller | the delta is vs the keyspace of the model in this case. I'm open to renaming it so this doesn't happen to another dev | 23:24 |
| bcsaller | bindingsFromModelChange or somesuch | 23:25 |
| hatch | yeah it's not bad idea....now I"m going to tackle the remaining failures :) | 23:26 |
| hatch | thanks again! | 23:26 |
| hatch | ohh my prevValue code doesn't support pojo's | 23:27 |
| hatch | huwshimi: did you need a hand or need to bounce any ideas off anyone for that? | 23:30 |
| huwshimi | hatch: It's ok I just need to modify the scrolling code which is all fairly hardcoded to be more flexible | 23:31 |
| huwshimi | scrolling/animating | 23:31 |
| hatch | ahh ok, I think there was a scrolling change landed today | 23:34 |
| hatch | so you might want to merge trunk | 23:34 |
| huwshimi | hatch: Ah right, thanks | 23:36 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
