StevenKwgrant: https://code.launchpad.net/~stevenk/launchpad/distroseries-spec-preload/+merge/18004600:32
wgrantStevenK: What about searches that don't need workitems?02:03
wgrantAnd also I think your preloading omits a sort.02:03
StevenKwgrant: I should order by workitem.sequence ?02:04
StevenKwgrant: I was thinking about that -- which calls don't you think require workitems?02:05
wgrantStevenK: The web UI's search, for example.02:06
wgrantStevenK: You should probably aggregate the workitems by spec, then sort each spec's items, then add them to the spec.02:07
StevenKwgrant: Which means no load_referencing() :-(02:08
wgrantStevenK: Sort afterwards.02:08
wgrantSorting it Python is fine when you need the whole set anyway.02:08
StevenKwgrant: I see what you mean WRT the web UI, but I don't think I can tell the difference in a preload hook02:11
wgrantStevenK: You can't, no. You need to use an argument.02:18
wgrantMost of the methods that preload stuff like that have a kwarg to enable it.02:19
StevenKwgrant: Right. We already have that02:20
StevenKI'll check that the webui stuff turns off preload02:21
StevenKwgrant: http://pastebin.ubuntu.com/5987337/02:28
wgrantStevenK: Sounds reasonable.02:36
StevenKwgrant: The diff is updated03:16
StevenKBut I suspect I need to rework the preload hook03:17
StevenKWe want to preload people always, but not workitems03:17
wgrantgetPrecachedPersonsById or whatever it is has an option for each03:17
StevenKvisible_specifications and _valid_specifications are properties, and exported as such05:08
wgrantStevenK: What's the issue with that?05:27
StevenKwgrant: The browser code calls the same properties that the API does.05:31
StevenKwgrant: http://pastebin.ubuntu.com/5987804/ is what I have, with the plan that the webui doesn't add prejoin_objects and the API does.05:47
wgrantStevenK: Isn't linked_branches needed by the web UI?05:50
StevenKwgrant: Hm, maybe05:51
StevenKThen we have objects and extra_objects?05:51
StevenKThis is a horrible mess05:51
wgrantStevenK: The others have a flag for each. need_branches, need_people, for example.05:53
StevenKwgrant: Right, but I still don't see how I can seperate it out if it's called via properties05:54
wgrantStevenK: You can't use the property.05:54
StevenKLet me think05:58
* StevenK tries to work out how to combine functions06:11
wgrantStevenK: Combine?06:13
StevenKwgrant: If I have need_people, need_branches, need_workitems then I have three pre_iter_hooks to call06:14
wgrantStevenK: Why not have one pre_iter_hook?06:20
StevenKwgrant: Oh, with partial() ?06:21
wgrantStevenK: with if06:21
StevenKwgrant: I need to throw arguments at it, don't I?06:22
wgrantStevenK: Closures06:24
StevenKBleh, nested functions06:26
StevenKI think I've seen partial as an existing pattern06:27
wgrantThe existing stuff doesn't use partial06:27
wgrantSee prepopulate_person in _getPrecachedPersons06:28
wgrantPretty simple06:28
wgrantThat's a decorator rather than a pre_iter_hook, but you get the idea.06:28
=== tasdomas_afk is now known as tasdomas
=== olli_ is now known as olli
=== tasdomas is now known as tasdomas_afk
wgrantjelmer: Can you land the bzr-git thing?21:05
wgrantThanks for the reviews.21:05
jelmerwgrant: you should be able to, I think21:07
wgrantjelmer: I'm not in bzrish teams21:08
jelmerwgrant: I'm sure that's fixable :-)21:10
jelmerI guess I can land this one change; I'd like to avoid the impression that I'm actually maintaining it though.21:11
wgrantjelmer: Who should I talk to about ~bzr membership?21:13
wgrantThough it would be appreciated if you could land this one.21:13
jelmerwgrant: sure, I can do that21:13
jelmerwgrant: I think jam is probably the best person to ask about it21:14
wgrantjelmer: Thanks, will do.21:14
wgrantjelmer: Thanks!23:36
jelmerthank you :)23:36

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!