[00:32] <StevenK> wgrant: https://code.launchpad.net/~stevenk/launchpad/distroseries-spec-preload/+merge/180046
[02:03] <wgrant> StevenK: What about searches that don't need workitems?
[02:03] <wgrant> And also I think your preloading omits a sort.
[02:04] <StevenK> wgrant: I should order by workitem.sequence ?
[02:05] <StevenK> wgrant: I was thinking about that -- which calls don't you think require workitems?
[02:06] <wgrant> StevenK: The web UI's search, for example.
[02:07] <wgrant> StevenK: You should probably aggregate the workitems by spec, then sort each spec's items, then add them to the spec.
[02:08] <StevenK> wgrant: Which means no load_referencing() :-(
[02:08] <wgrant> StevenK: Sort afterwards.
[02:08] <wgrant> Sorting it Python is fine when you need the whole set anyway.
[02:11] <StevenK> wgrant: I see what you mean WRT the web UI, but I don't think I can tell the difference in a preload hook
[02:18] <wgrant> StevenK: You can't, no. You need to use an argument.
[02:19] <wgrant> Most of the methods that preload stuff like that have a kwarg to enable it.
[02:20] <StevenK> wgrant: Right. We already have that
[02:21] <StevenK> I'll check that the webui stuff turns off preload
[02:28] <StevenK> wgrant: http://pastebin.ubuntu.com/5987337/
[02:36] <wgrant> StevenK: Sounds reasonable.
[03:16] <StevenK> wgrant: The diff is updated
[03:17] <StevenK> But I suspect I need to rework the preload hook
[03:17] <StevenK> We want to preload people always, but not workitems
[03:17] <wgrant> Right
[03:17] <wgrant> getPrecachedPersonsById or whatever it is has an option for each
[05:08] <StevenK> Blah
[05:08] <StevenK> visible_specifications and _valid_specifications are properties, and exported as such
[05:27] <wgrant> StevenK: What's the issue with that?
[05:31] <StevenK> wgrant: The browser code calls the same properties that the API does.
[05:47] <StevenK> wgrant: http://pastebin.ubuntu.com/5987804/ is what I have, with the plan that the webui doesn't add prejoin_objects and the API does.
[05:50] <wgrant> StevenK: Isn't linked_branches needed by the web UI?
[05:51] <StevenK> wgrant: Hm, maybe
[05:51] <StevenK> Then we have objects and extra_objects?
[05:51] <StevenK> This is a horrible mess
[05:53] <wgrant> StevenK: The others have a flag for each. need_branches, need_people, for example.
[05:54] <StevenK> wgrant: Right, but I still don't see how I can seperate it out if it's called via properties
[05:54] <wgrant> StevenK: You can't use the property.
[05:58] <StevenK> Grump
[05:58] <StevenK> Let me think
[06:11]  * StevenK tries to work out how to combine functions
[06:13] <wgrant> StevenK: Combine?
[06:14] <StevenK> wgrant: If I have need_people, need_branches, need_workitems then I have three pre_iter_hooks to call
[06:20] <wgrant> StevenK: Why not have one pre_iter_hook?
[06:21] <StevenK> wgrant: Oh, with partial() ?
[06:21] <wgrant> StevenK: with if
[06:22] <StevenK> wgrant: I need to throw arguments at it, don't I?
[06:24] <wgrant> StevenK: Closures
[06:26] <StevenK> Bleh, nested functions
[06:27] <StevenK> I think I've seen partial as an existing pattern
[06:27] <wgrant> The existing stuff doesn't use partial
[06:28] <StevenK> Aw
[06:28] <wgrant> See prepopulate_person in _getPrecachedPersons
[06:28] <wgrant> Pretty simple
[06:28] <wgrant> That's a decorator rather than a pre_iter_hook, but you get the idea.
[06:29] <StevenK> Yes
[21:05] <wgrant> jelmer: Can you land the bzr-git thing?
[21:05] <wgrant> Thanks for the reviews.
[21:07] <jelmer> wgrant: you should be able to, I think
[21:08] <wgrant> jelmer: I'm not in bzrish teams
[21:10] <jelmer> wgrant: I'm sure that's fixable :-)
[21:11] <jelmer> I guess I can land this one change; I'd like to avoid the impression that I'm actually maintaining it though.
[21:13] <wgrant> jelmer: Who should I talk to about ~bzr membership?
[21:13] <wgrant> Though it would be appreciated if you could land this one.
[21:13] <jelmer> wgrant: sure, I can do that
[21:14] <jelmer> wgrant: I think jam is probably the best person to ask about it
[21:14] <wgrant> jelmer: Thanks, will do.
[23:36] <wgrant> jelmer: Thanks!
[23:36] <jelmer> thank you :)