| rick_h | morning huwshimi | 01:33 |
|---|---|---|
| hatch | morning huwshimi | 03:29 |
| hatch | guess it's afternoon now :) | 03:31 |
| huwshimi | hatch: Well and truly :) | 03:59 |
| hatch | huwshimi: :) did you see the new IE10 bugs? | 04:00 |
| hatch | there are a few which fall into your ballpark I think | 04:00 |
| hatch | https://bugs.launchpad.net/juju-gui/+bugs?field.tag=ie10 | 04:00 |
| huwshimi | hatch: I did. It's strange that I didn't notice some of them. I just need to finish getting my IE vm working again and I'll take a look | 04:01 |
| hatch | huwshimi: well a number of branches landed so it's entirely possible they were introduced there | 04:01 |
| huwshimi | hatch: That's true | 04:02 |
| hatch | in our retrospective we made up a rule that any branch that gets landed now needs to be qa'd in IE as well | 04:02 |
| hatch | so get that VM up ;) | 04:02 |
| huwshimi | That's fine, I've been QAing in IE for a while now | 04:13 |
| hatch | oh awesome - well you are ahead of the curve | 04:13 |
| hatch | :) | 04:13 |
| hatch | morning | 13:33 |
| hatch | I'm still looking for one more review/qa on https://codereview.appspot.com/13072043/ plz and thanks | 13:42 |
| frankban | guihelp: anyone available for a python review? https://codereview.appspot.com/13106043 (I need another one) | 13:47 |
| jcsackett | hatch: i'm looking at the card about closing the ghost inspector and opening the service inspector on deploy, and wondering if it's really as simple as it sounds. and you sem like the person to poke about that. | 13:52 |
| hatch | yeah lets have a chat | 14:00 |
| hatch | one sec just grabbing my coffee | 14:00 |
| hatch | ^ jcsackett | 14:00 |
| jcsackett | hatch: ok, be in guichat in a second. | 14:01 |
| hatch | ok there | 14:01 |
| * hatch wonders if there are only the three of us in today :) | 14:41 | |
| bac | hatch: i've been here all day. just haven't had anything to say. so, hello. | 15:00 |
| hatch | well hello bac want to do a review/qa? https://codereview.appspot.com/13072043/ just need to check the branch out and run `make && make lint` and if there is no errors it qa's ok | 15:02 |
| bac | hatch: writing a MP atm. will do it in a second. | 15:03 |
| hatch | thanks! would love to get this landed....the new jshint is so fast | 15:03 |
| hatch | it takes longer to query the files than to lint them | 15:03 |
| hatch | haha | 15:03 |
| bac | hatch: there is a conflict in databinding.js | 15:12 |
| bac | hatch: when merging your branch into trunk | 15:12 |
| hatch | not surprising considering the time between branching and today :) | 15:12 |
| hatch | I'll merge | 15:12 |
| hatch | one minute | 15:13 |
| hatch | bac: re-proposing - it was actually only a trivial conflict | 15:14 |
| bac | hatch: yeah | 15:15 |
| hatch | I'll ping when it's done proposing | 15:15 |
| hatch | Makyo: you can probably just land your IE fix, it's pretty trivial | 15:16 |
| hatch | bac: done proposing | 15:18 |
| Makyo | hatch, Alright. | 15:23 |
| * Makyo will take that as an LGTM | 15:23 | |
| * hatch did lgtm :) | 15:23 | |
| Makyo | Well, bonus. | 15:24 |
| hatch | Makyo: do you know if we have any way of pulling the real constraints into the gui for the ghost inspector? | 15:27 |
| hatch | I'm trying to figure out if this is broken or if we simply don't have the functionality | 15:28 |
| Makyo | hatch, don't know what you mean by real constraints. | 15:28 |
| hatch | well like say we are on EC2, how do we pull in what machines they can deploy to? | 15:28 |
| hatch | those are the constraints no? | 15:28 |
| bac | hatch: done | 15:33 |
| bac | hi benji, could you review https://code.launchpad.net/~bac/charmworld/bundle-page/+merge/180891 at your leisure? | 15:34 |
| benji | bac: sure | 15:34 |
| hatch | bac: you are correct in that you need to specify which jshint flag to turn off | 15:36 |
| hatch | it's no longer a 'ignore all' type of flag | 15:36 |
| hatch | I actually prefer this approach | 15:37 |
| bac | hatch: no, i mean we went from /* jshint: foo=true */ to /* jshint -W99 */ | 15:37 |
| hatch | then it still checks for other errors | 15:37 |
| bac | hatch: that's what i meant. | 15:37 |
| hatch | validthis:true is just a 'everything is ok' flag | 15:37 |
| hatch | whereas W99 (which I'll add docs for) | 15:37 |
| hatch | only disables that one error | 15:37 |
| bac | hatch: oh. so you can just tell it to stfu for now. | 15:37 |
| hatch | right | 15:38 |
| bac | hatch: ok, i like the granularity but don't like the obscurity. | 15:38 |
| hatch | yeah I agree I'll be adding the comments as to what error it gets around | 15:38 |
| hatch | although js pro's should know by looking at the code ;) | 15:38 |
| bac | perfecto | 15:38 |
| hatch | maybe that's a good interview question lol | 15:38 |
| hatch | "why do we need to tell jshint to ignore this" | 15:39 |
| Makyo | jujugui call in 10 | 15:50 |
| Makyo | hatch, sorry, got distracted. Constraints are fuzzy, not absolute. If you say mem=2G, any machine with at least 2G matches. | 15:51 |
| Makyo | hatch, and this isn't pulled in from EC2, we'd have to go through the machines we have. | 15:51 |
| Makyo | hatch, Also, I was inexact. Some constraints are fuzzy, some, like arch, are not. | 15:51 |
| hatch | Makyo: I guess I'm confused how it works with input boxes because the user can really input whatever they want and I don't really know what happens afterwards | 15:52 |
| hatch | maybe we chat after the call and you can get me up to speed? | 15:52 |
| Makyo | hatch, sure. | 15:54 |
| hatch | thanks | 15:54 |
| Makyo | jujugui call in 2 | 15:59 |
| hatch | the websocket tests now save logs to the browser when running in make test-server :) | 17:16 |
| hatch | jcsackett: wow huge diff ;) | 17:26 |
| jcsackett | hatch: :-P | 17:32 |
| hatch | I'm QA'ing in IE | 17:32 |
| jcsackett | hatch: cool, thanks. | 17:32 |
| jcsackett | Makyo: could i trouble you for the second review on https://codereview.appspot.com/12852045/ ? | 17:33 |
| Makyo | jcsackett, sure, on it | 17:33 |
| jcsackett | thanks. :-) | 17:33 |
| hatch | blarg Win 8 is going black again | 17:33 |
| jcsackett | win8 is terrible. | 17:37 |
| jcsackett | and i say this as a person who is not anti-windows per se. win8 is terrible. | 17:37 |
| hatch | good news is that your branch appears to be fixed | 17:38 |
| hatch | bad news is I found another bug :/ | 17:39 |
| hatch | jcsackett: next ticket? https://bugs.launchpad.net/juju-gui/+bug/1214058 :) | 17:42 |
| _mup_ | Bug #1214058: Cannot open Browse if sidebar is minimized <charmbrowser> <juju-gui:New> <https://launchpad.net/bugs/1214058> | 17:42 |
| jcsackett | hatch: sounds good to me. | 17:47 |
| hatch | thank you very much :) | 17:47 |
| * hatch is trying to get these bugs squashed early to make for an easy release | 17:47 | |
| bac | benji: i'm getting those json decode messages too. i'll try it in trunk. my branch should not have affected that area. | 17:51 |
| bac | benji: jsondecode errors on trunk too. | 17:57 |
| benji | bac: ok, "good" | 17:58 |
| benji | :) | 17:58 |
| benji | we should really convert those to INFO or something similar | 17:58 |
| benji | they look scary when they shouldn't | 17:58 |
| bac | yeah, "good" in near-team | 17:58 |
| bac | benji: those failures are getting 503 fetching the charm | 18:06 |
| bac | benji: actually it is fetching the jenkins results. jenkins is dead. | 18:08 |
| bac | https://jenkins.qa.ubuntu.com/job/precise-ec2-charm-apache2-passenger/lastBuild/api/json | 18:08 |
| benji | interesting; in that case a more descriptive error would seem to be in order | 18:08 |
| bac | benji: we print an error message and proceed if the code == 404. i'm going to change that to != 200 | 18:12 |
| benji | +1 | 18:12 |
| bac | benji: IS says they had a jenkins upgrade that went awry. they are poking at it. | 18:24 |
| benji | cool | 18:25 |
| hatch | jujugui lf two reviews and a qa for https://codereview.appspot.com/12956045/ plz | 18:29 |
| hatch | bueller.....bueller | 18:55 |
| jcastro | hey rick_h | 19:02 |
| hatch | jcastro: he is off today | 19:05 |
| jcastro | ack | 19:05 |
| hatch | anything i can help with? | 19:05 |
| jcastro | https://bugs.launchpad.net/juju-gui/+bug/1214087 | 19:05 |
| _mup_ | Bug #1214087: GUI fails to deploy keystone <juju-gui:New> <https://launchpad.net/bugs/1214087> | 19:05 |
| jcastro | ran into this today | 19:06 |
| jcastro | I _think_ this is the same issue we ran into during OSCON | 19:06 |
| jcastro | where some config options break deployment | 19:06 |
| hatch | ok so it deploys fine on the sandbox | 19:07 |
| hatch | so will have to take a peek a little later deploying to ec2 | 19:07 |
| hatch | do you know what the error was? | 19:07 |
| jcastro | but not in his MAAS | 19:07 |
| jcastro | let me ask | 19:07 |
| hatch | thanks - just want to get as much info as possible for when someone goes in to take a look | 19:08 |
| bac | benji: would you do a quick review of my jenkins fixing one line branch? | 19:11 |
| bac | benji: https://code.launchpad.net/~bac/charmworld/schmenkins/+merge/180930 | 19:12 |
| benji | bac: sure | 19:12 |
| benji | bac: looks good | 19:14 |
| bac | thx | 19:14 |
| jcastro | hatch: added the log info to the bug report | 19:16 |
| hatch | thanks! | 19:17 |
| hatch | looking | 19:17 |
| hatch | hehe | 19:17 |
| hatch | paramter | 19:17 |
| hatch | jcastro: thanks for doing the legwork on that | 19:38 |
| Makyo | My elegant idea causes a memory leak in tests \o/ | 19:38 |
| hatch | best....fix....ever | 19:39 |
| hatch | :P | 19:39 |
| hatch | jujugui still looking for some reviews on https://codereview.appspot.com/12956045/ | 19:40 |
| bac | hatch: looking | 19:40 |
| hatch | thanks bac | 19:40 |
| benji | hatch: I'll take one. | 19:42 |
| hatch | thanks to you too :) | 19:42 |
| bac | hatch: done. | 19:51 |
| hatch | thanks! | 19:51 |
| hatch | looking | 19:51 |
| bac | fearless canadians: http://www.piratejoes.ca | 19:58 |
| hatch | lol! | 19:59 |
| * hatch looks up trader joes | 19:59 | |
| hatch | it's a grocery store? | 20:00 |
| hatch | Makyo: I'm also running into an IE10 bug where it ignores the Cascading part of CSS | 20:10 |
| hatch | :/ | 20:10 |
| Makyo | Siiiigh. | 20:15 |
| hatch | benji: would you be agaist hanging those constraints configs off of utils ? | 20:18 |
| hatch | then they won't need to be mocked | 20:18 |
| benji | hatch: sounds good to me | 20:18 |
| * benji thinks (almost) to himself: "mock" doesn't sound like the right word for that... | 20:19 | |
| hatch | stub? | 20:19 |
| hatch | "fragile code structure" ? | 20:19 |
| hatch | ;) | 20:19 |
| benji | :) | 20:21 |
| hatch | I have two computers lboxing right now | 20:24 |
| hatch | I think we need to speed that process up somehow :D | 20:24 |
| hatch | jujugui looking for a quick review/qa in IE for this one (4line diff) https://codereview.appspot.com/13094044/ | 20:25 |
| === marcoceppi__ is now known as marcoceppi | ||
| huwshimi | Morning | 23:05 |
| * bcsaller takes off for a bit but back tonight. | 23:21 | |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!