/srv/irclogs.ubuntu.com/2013/08/20/#juju-gui.txt

hatchhey huwshimi how are you doing?00:55
hatchhuwshimi: are you working on any of the gui stuff yesterday/today?00:57
huwshimihatch: Yep, getting some of this IE stuff done.00:58
hatchoh ok cool, can you put your head on the cards so that we aren't duplicating work00:58
huwshimihatch: I had a question for you, let me see if I can remember00:58
hatchsure, I'll be here all night00:58
huwshimihatch: Oh yeah, I haven't been able to reproduce bug #121326000:59
_mup_Bug #1213260: DDing a charm renders service icon under sidebar <ie10> <juju-gui:New> <https://launchpad.net/bugs/1213260>00:59
hatchhuwshimi: ok, umm does it render exactly where you drop it?01:00
hatchor is it rendered slightly off?01:01
hatchmy laptop (which has IE10) has a low res screen01:01
huwshimihatch: It's been rendering fine for me this morning, but I just went to double check and my VM died again.01:02
hatchcrap, so what happens when it dies?01:05
hatchjust crashes?01:05
huwshimihatch: Yeah, this time it's complaining about having run out of disk space, but it has plenty01:06
huwshimihatch: Now can't boot into it01:06
hatch:/ is there a 'free disk space' command?01:07
hatchI know parallels has that and has to be run from time to time01:07
hatchhttp://askubuntu.com/questions/219286/virtualbox-dynamic-disk-not-expanding-to-virtual-size01:09
hatchpossibly related?01:09
huwshimiOh it has actually run out of space, somehow it has taken up 12gb...01:12
huwshimiNot sure how to free that up...01:13
hatchhuwshimi: maybe just increase the size of your vm01:16
huwshimihatch: I run it off a disk and the vm has used up all the space on that disk. I'm just temporarily deleting some vm files so that I can boot the vm, clean up and then restore...01:17
hatchohh01:18
huwshimihatch: It's a new thing every other day that goes wrong :)01:19
hatchwelcome to windows lol01:19
hatchhuwshimi: any luck?01:38
huwshimihatch: Not yet, it's repairing01:39
huwshimiwell, it was, no feedback at the moment01:39
hatchoh boy - sounds like you might need to give it more space01:39
hatchI think mine has 32gigs01:39
huwshimihatch: It has a few gb free at the moment01:39
hatchmaybe it's paging things because it doesnt' have enough ram01:40
huwshimihatch: It has heaps of ram01:42
huwshimihatch: It's works!01:46
huwshimiNow to figure out what I can delete01:46
huwshimihatch: The service block always appears with the top left point under the mouse01:48
hatchreally...01:50
hatchhmm on a fresh trunk checkout?01:51
huwshimihatch: Yes01:51
huwshimihatch: I haven't seen it do anything else01:51
hatchpulling new trunk01:51
hatchgota 'make' then I'll test01:52
hatchohh01:54
hatchyou gota drop it on the big square in the middle01:54
hatchthe thing below 'start adding charms'01:55
hatchactually it doesn't matter where I drop it, it's always off01:55
huwshimihatch: Where does it up it?01:56
hatchwha?01:56
huwshimihatch: put it?01:57
hatch~40px from the left of the canvas under the sidebar about mid screen01:58
hatchI can demo it01:58
hatchif you want to hop into a hangout01:58
hatchI'm in guichat01:58
hatchhttp://bazaar.launchpad.net/~juju-gui/juju-gui/trunk/view/head:/app/views/topology/service.js#L426 is the method which handles the drop and the positioning01:59
huwshimihatch: I'm not seeing that at all, on a fresh branch. Windows 8 IE1001:59
hatchodd02:00
hatchchecking the code02:00
huwshimihatch: What's your screen res?02:01
hatch1366x76802:01
huwshimihatch: Even changing my browser size doesn't change it02:03
hatchon this line http://bazaar.launchpad.net/~juju-gui/juju-gui/trunk/view/head:/app/views/topology/service.js#L443 put console.log(ghostAttributes.coordinates[index]);02:04
hatchand let me know what the two numbers are02:04
huwshimihatch: Trying, but I think doing a disk cleanup and running IE were too much for the vm02:12
hatchjeesh and I thought I had hardware issues :)02:12
huwshimihatch: 8 cores, 16gb ram is not the problem... 4gb ram and 4 cores are dedicated to the vm. Not sure why it runs so poorly.02:14
huwshimihatch: I'm going to finish getting this VM back to normal and then I'll get back to you about the drag and drop02:15
hatchsure thing02:17
hatchhuwshimi: just FYI I'm running it in a vm with 3GB of ram and 1 core02:18
huwshimihatch: Virtualbox?02:21
hatchyup02:21
hatchV4.2.1602:21
huwshimiI have .1002:22
huwshimi(4.2.1002:22
huwshimi)02:22
hatchmight be worth an upgrade02:22
huwshimihatch: Did you change settings for the VM?02:22
hatchwhat do you mean?02:23
hatchthe hard drive is 25GB02:23
hatchwell what it thinks it's hard drive is02:23
huwshimihatch: There are lots of little checkboxes that do things, but I don't know if I need to change any of them...02:25
hatchheh yeah there are02:26
hatchI fiddled with it long enough when I first started with it I remember02:26
hatchbut I can't tell you what I changed and what was there02:26
hatchI know I had to do some command line trickery to think it had a resolution higher than like 400x60002:26
hatchor something crazy02:26
huwshimihatch: 137, 101. And it placed where I expected it to.04:02
hatchhuwshimi: interesting - I get only negative numbers04:10
hatchin the am I'll have to try and get someone else to see if they can repro04:10
hatchhuwshimi: are you in the 'Desktop' version of IE? or the Metro version?04:11
huwshimihatch: Desktop04:14
hatchwell what the heck hah04:14
hatchI suppose it's entirely possible mine is caching something wrong04:15
hatch:/04:17
hatchI think you're lie'n to me so you don't have to fix it lol04:17
huwshimiheh04:21
huwshimihatch: It's possible it's broken, I just can't reproduce it here04:28
hatchyeah but how's that possible haha04:28
hatchboth on trunk same version of ie04:29
huwshimihatch: Do you get the same thing in rev 940?04:45
hatchhuwshimi: let me check05:10
hatchhuwshimi: not exactly - that revno was before the fix for dropping the service on the center message05:13
hatchthey are positioned incorrectly still however05:13
hatchI'm guessing it works correctly there?05:14
huwshimihatch: You changed some positioning stuff the revision after that so I was hoping it might have worked back then...05:16
hatchyeah doesn't look like it - I'll get someone else to test it out, it could jsut be that mine is broken for whatever reason05:16
hatchI'm going to take off but if you could push up/email me with whatever you get done so we can merge it in that would be awesome05:16
huwshimihatch: Sure. Night.05:17
=== rogpeppe1 is now known as rogpeppe
frankbanbac, benji: when you have time, could you please review https://codereview.appspot.com/12927049 ?13:09
benjisure13:09
rick_hjcsackett: ping13:09
bacfrankban: sure.  hey sorry i didn't get to your review yesterday before your EOD13:09
frankbanbac: no problem and thanks13:10
frankbanbenji: thank you13:10
rick_hjcsackett: fyi, not sure where you are on the bug, but updated it with notes since I thought it might be my fault (though kind of an accidently worked thing) #121405813:15
_mup_Bug #1214058: Cannot open Browse if sidebar is minimized  <charmbrowser> <juju-gui:Triaged by jcsackett> <https://launchpad.net/bugs/1214058>13:15
rick_hhatch: ping when you get in. Want to chat about where we left off last week if you've got the time. 13:16
=== robbiew1 is now known as robbiew
frankbanbac, benji: thanks for your reviews!13:43
hatchhey I gota run and take the car into the shop so I'll probably be back in 30-45 mins13:54
hatchrick_h: I normalized the constraints stuff so you're free to go on the ghost constraints13:54
rick_hhatch: k, will unblock the card then13:54
rick_hhatch: thanks and have fun at the dealer13:54
hatchlol dealer13:55
hatchppl take their cars to the dealer?13:55
hatch:P13:55
rick_hhatch: yea, under warranty and all :P13:55
jcsackettrick_h: saw your notes, had come to the same conclusion yesterday, but thanks for the validation. :-)13:55
hatchriiiiight, my cars are too old haha13:55
jcsackett(not so much about what had happened, but about what was going on)13:55
hatchok gota run be back in a few13:55
rick_hjcsackett: cool, wasn't sure where you were with it but I was curious as it seemed really strange any changes recently broke that :/13:56
jcsackettrick_h: yeah, and the truth is it never really should have worked. :-P13:56
rick_hjcsackett: right, that made more sense :)13:56
rick_hin a ...strange...kind of way13:57
jcsackettrick_h: i'm glad you updated me though. i could see what was wrong but my update at standup was def going to be "i have no idea why this ever worked".13:57
rick_hjcsackett: sorry my z-index stuff borked a couple of other things on you13:58
rick_hjcsackett: it's the one line 'fixes' that kill13:58
* jcsackett laughs13:58
jcsackettyou mean that floating sidebar icon thing?13:58
jcsackettat least it was an easy fix too.13:59
rick_hyea, as a drive IE fix I had to bump the z-index and then saw the bugs come out of it13:59
jcsackett...of course another one-line, so we'll see what that borks. :-P13:59
rick_hbut since it was a one-liner and I TRIVIAL'd it...WCPGR13:59
jcsackett...i have no idea what that last acronym means. :-P14:00
rick_hjcsackett: that's SteveK's famous "What Could Possibly Go Wrong" /me misses that14:01
jcsackettaaaah.14:01
jcsackettyeah, we need to bring that back.14:01
hatchback14:23
hatchrick_h: on the weekend I installed cruise and a stereo into the mrs car and now it's off to get a new windshield - I typically do all of my own repairs but it's cheaper to have someone else install the windshield :)14:24
rick_hhatch: defintely. special tool to pull the gasket around there and such14:25
rick_hhatch: was blown away by how fast a pro could do it14:25
hatchyep!14:26
hatchso who has IE running?14:26
hatchhuw said he couldn't repro this bug https://bugs.launchpad.net/juju-gui/+bug/1213260 and was looking to see if it's fixed for anyone else too14:26
_mup_Bug #1213260: DDing a charm renders service icon under sidebar <ie10> <juju-gui:New> <https://launchpad.net/bugs/1213260>14:26
rick_hhatch: looking14:26
rick_hhatch: yea, not doing it here14:28
rick_hhatch: even if I just drop it 'right' past the edge of the sidebar, the left side of the service block is a few px east of the sidebar edge14:28
hatchwell I'm glad....but slightly irritated because that means there is something wrong with my IE :/14:30
rick_hhatch: updating the bug with my screenshot of a tiny IE window working right. Re-open if you can dupe or find something. 14:31
hatchrick_h: mind closing the ticket as cannot reproduce? Just so we have a record of it14:31
hatchoh I can dupe the issue for sure14:31
hatchbut noone else can lol14:31
rick_hhatch: well, marked it invalid with the notes about 'cannot reproduce' 14:31
hatchoh right...that's how it works14:32
hatchdid anyone get an email from huw about what he was working on?14:32
* rick_h didn't see anything14:33
hatchallllright then14:33
sinzuijcsackett, 1x1?14:33
hatchrick_h: so the constraints util method should all be gtg now, and all you need to do is create another wrapper around the constraints partial to loop through the fields14:34
rick_hhatch: looking14:34
jcsackettsinzui: yes.14:34
jcsackettsinzui: i'm in the hangout attached to the appt14:35
hatchrick_h: remember the performance discussion we had about etags and mobile? You should watch these talks it outlines the issues in detail in the first video https://plus.google.com/118445028821328031751/posts/hz2XpU76xzN14:39
rick_hhatch: will put it on for lunch time viewing. thanks14:40
hatchit has some really great information in it - there is like 3.5h of talks in the playlist hah14:40
=== BradCrittenden is now known as bac
hatchMakyo: as far as core is concerned what happens if the constraints aren't specified?15:09
Makyohatch, Aren't specified?  As in, you send a set-constraints with no constraints, or as in you deploy without specifying?15:09
hatchboth I suppose - assuming the constraints object is empty15:10
hatchright now there are no errors it appears?15:10
hatchdoe stha tmeans it picks the lowest possible?15:10
hatchwow I can't type15:10
Makyohatch, Don't know off the top of my head, I'd assume it just allocates whatever size is specified in your ~/.juju/environments.yaml, which is a machine class, like tiny, small, etc.15:11
hatchalright so with none specified in the gui a good name would be 'Default' ?15:11
MakyoI'd make sure with luca.  That makes sense to me, but others might not know where that default is specified - I've been using Juju for a year, so I've got that advantage.15:12
hatchgood point15:13
hatchluca: are you there?15:13
hatch*poke poke*15:13
lucaMakyo: hatch heya15:13
hatchwhen 'scaling up' the dialogue shows you the current constraints15:13
hatchif none are specified....what shoudl be shown?15:13
lucahatch: the defaults15:13
hatchwe can't get the defaults15:14
hatchall the info we have is that there isn't anything specified15:14
Makyoluca, if you deploy without constraints, it uses what's specified in your environments.yaml file, which we don't have access to.15:14
hatchright now I have Default Ghz Default GB ..... etc15:14
lucaMakyo: hatch right. What do you think we should show?15:15
hatchI like 'Default'15:15
hatchalthough then people won't know what those are15:15
hatchbut it's kind of a chicken/egg issue there15:15
MakyoI suppose I'd expect a 'use defaults from environment.yaml' checkbox that disables fields, maybe?  But yeah, I have experience with juju15:16
hatchI'd say that could be in the 'set constraints' section15:17
hatchbut in the 'these are your current settings' section15:17
hatchmaybe we just have Default for now, and then when we add 'help bubbles' they can say where the defaults are set15:17
MakyoYeah, prowling through the machine and unit objects in the db from improv, we don't have any specs.15:19
MakyoDon't know how meaningful improv is, not checking against core yet.15:19
hatchjujugui lf two quick reviews and an IE QA on https://codereview.appspot.com/12987045/ plz15:39
Makyohatch, on it15:39
MakyoGot the IE bit.15:39
rick_hhatch: looking15:39
hatchright arm!15:39
hatchI needed to get these landed so that I can finish the upgrade ux heh15:40
hatchdarn IE15:40
rick_hhatch: what do I need to do to see the original bug?15:40
hatchscale up the units without editing the constraints so it'll say 'Default CPU Default GB ...15:41
hatchif it doesn't wrap then you're good15:41
hatchand as far as the X's  just focus an input, if there is no X in the post deployment inspector then you are good15:41
rick_hhatch: ok, the bug states on 'inputs' and so I was checking on the config inputs15:42
hatchyeah I left the X on ones which aren't databound15:42
rick_hI didn't realize IE did the X clear on non type="search" inputs15:42
hatchjust incase IE ppl like that X for some reason...15:42
rick_hand yea, the config ones are actually textareas so bad check15:43
hatchshift + cmd + left is so much faster than trying to find the damn X with the mouse :)15:43
hatchrick_h: did you want me to comment in the css why the part I removed is no longer required?15:48
hatchI'm a little confused by the comment15:48
Makyojujugui call in 9, kanban now15:51
Makyohatch, want to run it today, then I'll get W/Th, you get F?15:51
hatchsounds like a plan15:52
* hatch gets out the whip15:52
* hatch just pulling alittle stewie there15:52
bacbenji: after the call a review of https://code.launchpad.net/~bac/charmworld/json-for-deployer/+merge/181087 ?15:55
benjibac: sure15:56
lucaMakyo: hatch got called away, did you get a solution hehe?15:58
Makyoluca, Don't have anything atm, was hatch's task.15:59
Makyojujugui call in 115:59
Makyoluca, will poke around more after the call.15:59
lucaMakyo: cool16:00
hatchluca: I just ended up going with 'Default' instead of undefined when it's not specified16:00
lucahatch: nice, ok16:00
hatchluca: if you decide you want it changed in the future it's pretty easy to change16:15
benjibac: your branch looks good.  I had a question though: do we need URLs without user names for promulgated bundles?16:19
rick_hbenji: yes, the jujugui charm is an example16:19
bacbenji: last week we discussed that and decided that the deployer will always want a versioned basket16:20
rick_herr, ignore me16:20
bacbenji: that decision is open to be revisited but that's what i went o16:20
bacn16:20
bacbenji: btw, this branch was very easy to do based on the nice stuff you added recently16:21
benjibac: right, I think we always want a version, but don't we want to be able to say "I want the official big mysql cluster bundle, regargless of who is its current manager"?16:22
benjiI'm glad to hear I made the code a bit better.16:22
hatchjujugui does anyone know the status/details of the card in Inspector 'Inspector does not work with core: cannot iterate over undefined WRT units' ?16:25
bcsallerno, sorry, sounds like that one needs testing with a real core deployment16:26
hatchyeah there is no ticket attached :/16:27
MakyoI created it in a rush, sorry.16:27
MakyoWill try again.16:27
MakyoJust wasn't listing units.16:27
bacbenji:  yeah, perhaps.  sinzui do you have an argument against what benji says?16:27
hatchMakyo: ohh, so that really needs to be fixed then before we unflag?16:27
MakyoIf it's still an issue.16:27
bacbenji: it'll be trivial to add...16:27
benjiyeah; if we aren't sure one way or the other we can land it as-is and add this later16:28
hatchMakyo: if you have time today/tomorrow it would be awesome if you could test it out again :)16:28
Makyohatch, doing it now; need a juju environment up anyway.16:29
hatchoh awesome thanks!16:29
hatchI got my first SMS spam this morning at 5am - I have finally made it!16:29
Makyohatch, looks good, trashing the card.16:43
hatch*phew* thanks for looking into that Makyo16:44
sinzuibac: We do want to support  short url. the GUI will always use the full url. But from the command line, I might want to type just:fast-wordpress16:47
sinzuibac, remember search will only return tip and reviewed bundles have a higher score,. The GUI will always suggest the user use the latest official charm.16:48
hatchrick_h: I'm just going through the tickets and came across this one https://bugs.launchpad.net/juju-gui/+bug/1209016 I know you fixed it but it appears that the + sign doesnt turn orange on hover...is this a css or image issue?16:51
_mup_Bug #1209016: Right hand zoom slider handles sprited improperly <juju-gui:Triaged by rharding> <https://launchpad.net/bugs/1209016>16:51
sinzuibac: benji: do either of you have time to review https://code.launchpad.net/~sinzui/charmworld/api3-search/+merge/181092 ? I have an implementation question and am open to discuss net steps.16:51
adeuringsinzui: could you have a look a this MP: https://code.launchpad.net/~adeuring/charmworld/1206659-simpler-es-mapping/+merge/181100 ?16:52
* sinzui looks16:53
rick_hhatch: looking16:53
rick_hhatch: looks like a JS issue. The hover class is added, but the sprite css doesn't change the icon. If you hard edit the css the image will show16:55
rick_hhatch: so rather than adding a css class it needs to add and remove 16:55
hatchright looks like the old class is still taking precident16:56
hatchI'll make a card for this ticket16:56
rick_hhatch: comment added with the details https://bugs.launchpad.net/juju-gui/+bug/1209016/comments/116:56
_mup_Bug #1209016: Right hand zoom slider handles sprited improperly <juju-gui:Triaged by rharding> <https://launchpad.net/bugs/1209016>16:56
hatchcool thanks16:57
rick_hjcsackett: did you need a second pair of eyes on the event stuff?16:57
rick_hjujugui I'm having a hard time concentrating through the meds. Going afk. 16:59
MakyoAlright, good luck16:59
sinzuiadeuring, r=me with comments17:06
adeuringsinzui: thanks!17:06
adeuringsinzui: Making the two lists "constants" is fine, but I don't understand your suggestion to add an XXX: Do you mean line 230 of the diff? I don't think that an XXX is needed there17:11
sinzuiadeuring, okay. I wont press you to make the change.17:12
sinzuijujugui. Note that https://jenkins.qa.ubuntu.com/ is not responding. So charmworld is not collecting charm test results at the moment.17:18
hazmathmm17:18
hazmatsinzui, raising to webops17:19
bachazmat, sinzui: i got booted off-line.  m_3 and i raised the jenkins issue on #is yesterday17:59
m_3bac: they're still working it too it looks like17:59
sinzuithank you bac18:00
bacm_3, even more dead than yesterday18:00
bacbenji: thanks for the review.  i'm going to land it now and do the promulgated as another branch18:02
benjicool18:02
bacsinzui, benji: do we think this is the URL to get JSON for the deployer use for promulgated branches:  http://manage.jujucharms.com/bundles/mysql/tiny/json18:33
benjibac: I /think/ so.  I don't remember exactly.18:34
bacbenji: i've added it to the doc and will proceed.  having an optional version right in the middle is not pretty18:36
benjimmm18:36
bacor maybe the version is only there if there is an owner18:36
sinzuibac, I think so. There is no version and no owner in it18:39
sinzuibac: I shared "Deploying Charmworld and Juju-GUI to Prodstack" with jujugui and orangesquad so that everyone knows the fastest way to get things deployed18:40
bacsinzui: yay18:40
bacsinzui: i have given it a gold star so i'll always have it with me.18:42
hatchrick_h: back yet?18:52
rick_hhatch: what's up?19:45
hatchrick_h: oops sorry didn't see you replied19:59
hatchI'm going to be changing the template that the constraints use a little19:59
rick_hhatch: rgr19:59
hatchfeelin better?19:59
rick_hhatch: little bit, took a half day sick and a nap20:00
rick_hnow nap-groggy, but wheeeee20:00
jcsacketthey hatch, since updating your jshint i'm getting complaints about the 2 line indents on all files. any idea what i need to change?20:21
hatchjcsackett: you merged trunk?20:22
jcsackettthat's how i got your jshint update.20:22
jcsackettshould there no longer be 2 space indents?20:22
* jcsackett goes to see if there's more trunk to merge20:22
hatchhmm well no there should be20:23
hatchguichat real quick?20:23
jcsacketthatch: sure, one sec.20:24
sinzuibac, do you have time to give me some feedback on https://code.launchpad.net/~sinzui/charmworld/api3-search/+merge/18109220:25
bacsinzui: sure20:25
Makyojujugui (hatch, bcsaller?) - the saveAs noop is what's causing the memory leak for me in the websocket_logging tests.  Am I behind on a version or something?  Have clean-all'20:28
MakyoHave run clean-all etc.20:28
bcsallerafaik that code hasn't been touched in quite some time, this is the export saveAs you're referencing?20:29
MakyoIt's just the line "saveAs = function() {};", I think.  In the browser, as hatch  says, I get a save as dialog, but Phantom just dies, then I get a message that it's used all available system memory.20:31
hatchoh THAT's why phantom always dies for me now20:31
jcsacketthatch: threw node_modules/jshint/bin into my path and now all is well.20:31
hatchjcsackett: awesome :)20:31
hatchMakyo: looking at the test20:32
Makyohatch, it20:32
MakyoIt's test/test_websocket_logging.js:5920:32
MakyoThat test.20:32
hatchoh em gee who wrote FileSaver.js20:35
hatchlol20:35
bcsallerFileSaver.js is a polyfill we pulled in20:35
bacsinzui: are you asking for a full review?  or a mid-imp discussion?20:35
hatchbcsaller: yeah I know, :)20:36
hatchMakyo: what if you change those to websocketLogging.prototype.saveLog = ... ?20:36
sinzuibac. I hope the former, but the later is not unreasonable since I think the metadata issue should be solved in this branch20:37
jcsackettjujugui: can i get two reviews for https://codereview.appspot.com/1309204420:38
hatchon it20:38
jcsackettthanks, hatch.20:40
MakyoNo luck, hatch 20:42
hatchdarn - ok I'll have to look into the memory profile in a few20:43
MakyoWill poke around too20:43
rick_hjcsackett: reviewing20:43
rick_hjcsackett: sanity check on the test method there please. 20:44
rick_hjcsackett: but other than that ok. Heading out. 20:44
rick_hgrrr, reviewboard is timing out 20:45
hatchMakyo: hmm I can't reproduce the memory leak in the browser20:46
hatchdoes it happen in the browser for you too or just in phantom?20:47
Makyohatch, just phantom, the browser shows the save dialog.20:47
hatchok I don't get any save dialogue20:47
hatchand I shouldn't because the saveLog method was monkeypatched20:47
bacsinzui: is the metadata currently used?  i think your suggestion is a good one.20:48
hatchit.only('responds to the saveWebsocketLog event', function(done) {20:48
Makyohatch, the memory bug seems to be a phantom thing, closing uncleanly because of a crash with the file saving.20:48
hatchthat's the proper test right?20:48
MakyoThat appears to be it.20:48
hatchok trying phantom20:48
jcsackettrick_h: ack. 20:48
hatchno issues20:48
hatchMakyo: maybe I need your branch20:48
MakyoThat's why I was wondering about versions. 20:49
hatchok well trunk as far as this morning was A O K20:49
hatchif you push up your branch I can take a look20:49
sinzuibac: it is not used for bundles. Aaron and rick introduced it to charms to describe things we add to the charm, like related_charms. I think adding to metadata is keeping with the grand plan, but you or benji might know of changes to the plan while I was in IoM20:50
Makyohatch, I haven't touched that test, nor anything that test touches.  I'm currently checking trunk, so give me a sec.  if it is my branch, I'll push it and send it your way.20:50
hatchalrighty20:51
bacsinzui: i don't know anything about it.  it looks good to me.20:51
hatchmaybe it's just in your head ;)20:51
* hatch waves his hand "this is not the test you are looking for"20:51
MakyoNnnnnnno.20:51
Makyohatch, dies in trunk, too.20:52
hatchhmm20:52
hatchthat's very odd20:52
hatchphantomjs --version ?20:53
hatchI'm showing 1.9.120:53
sinzuiOkay. then I will add doctype to meta data to charm and bundle in API3. bac I intended to look at the index_client.api_search() I discovered. Do you agree? Or should I work on the interesting endpoint?20:53
hatchMakyo: the thing that's intersting is that you said you get a save dialog - I do not...20:54
Makyo1.8.0 - let me try updating.20:54
hatchyeah that version is pretty old20:55
hatchDec 201220:55
* hatch crosses fingers20:55
bacsinzui: api_search20:55
MakyoThat's what I was thinking, s'why I asked.  Hope it works!20:55
sinzuibac, thank you for the direction.20:55
* sinzui cleans up metadata rules20:56
Makyohatch, It crashes faster this time :)20:57
hatchlol20:57
hatchand it works perfectly fine here...20:58
hatch11MB of ram usage20:58
MakyoFffff.20:58
MakyoIt's no longer memory-leaking, thankfully.20:58
MakyoJust crashing.20:59
hatchohh ok20:59
hatchphantomjs always crashes on me for no reason20:59
hatchI just restart the test20:59
hatchbut with the .only on that test it's fast20:59
hatchand no crashy20:59
hatchrunning the .only on the describe21:00
hatchahah!21:00
* hatch made it crash21:00
hatchit's actually crashing in it('can save a log', function() {21:00
hatchbecause saveAs isn't actually a global21:01
hatch ReferenceError: Can't find variable: saveAs21:02
hatchsee it's defined on line 24 of test_websotkcet21:03
hatchor whatever my fingers meant to type21:03
hatchholy crap this FileSaver.js file is hard to read21:04
hatchMakyo: https://gist.github.com/hatched/919583b63f7d9c336c0d21:08
hatchfixed21:08
Makyohatch, oh!21:09
MakyoLinter runs on tests, are we okay with removing 'use strict'?21:09
hatchprobably not21:09
hatch:)21:09
hatchMakyo: var saveAs = saveAs; outside of the closure with a flag to tell jshint it's OK21:11
hatch /* jshint: -W079*/ for example21:12
hatchI'm actually wondering how the heck that EVER ran21:12
hatchlol21:12
hatchMakyo: did that work for you as well?21:15
Makyohatch, started raining and I was hang-drying stuff outside.  Let me try.21:15
hatchshoot I gota run pick the car up from the glass place before they close21:20
hatchwill bbiab21:20
Makyo\o/21:21
MakyoThanks hatch 21:21
hatchw00t w00t!21:21
hatchno problem :)21:21
hatchback21:37
* bac dogwalk21:38
Makyobac, http://imgur.com/gallery/DLXSjcS22:26
huwshimiMorning23:01
bachi huwshimi23:25
huwshimibac: Hey23:26
bachuwshimi: i'm working on charmworld.  and we've got some pages that needs some styling love.  any chance you'd be able to look at them?23:27
huwshimibac: Sure, what needs to be done?23:27
bachuwshimi: i just created a page to display the info for bundles and just laid it out as tables.  so, it could be re-arranged to be more pleasant.  and the charm display page is ugly with overlapping text: http://manage.jujucharms.com/charms/precise/etherpad-lite23:28
bachuwshimi: if you can look i'll send you an email tomorrow with details.23:29
huwshimibac: Sure, that's fine. Let me know!23:30
bachuwshimi: the bundle page is at http://staging.jujucharms.com/~abentley/bundles/wiki-bundle/wiki23:30
bachuwshimi: have you ever worked on charmworld before?  if not i'll embellish my email with how to get up and running.  it is a pretty simple process.23:31
huwshimibac: I have done, but it was last year I think, so might be worth putting in some instructions just in case :)23:32
bacwill do.  thanks for the help!23:32
huwshimibac: No problems.23:34
bachuwshimi: email sent.  it is pretty minimal but i think its enough.  let me know if you need more detail.23:45
huwshimibac: Thanks, that looks fine for me to get started/23:47

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!