| hatch | hey huwshimi how are you doing? | 00:55 |
|---|---|---|
| hatch | huwshimi: are you working on any of the gui stuff yesterday/today? | 00:57 |
| huwshimi | hatch: Yep, getting some of this IE stuff done. | 00:58 |
| hatch | oh ok cool, can you put your head on the cards so that we aren't duplicating work | 00:58 |
| huwshimi | hatch: I had a question for you, let me see if I can remember | 00:58 |
| hatch | sure, I'll be here all night | 00:58 |
| huwshimi | hatch: Oh yeah, I haven't been able to reproduce bug #1213260 | 00:59 |
| _mup_ | Bug #1213260: DDing a charm renders service icon under sidebar <ie10> <juju-gui:New> <https://launchpad.net/bugs/1213260> | 00:59 |
| hatch | huwshimi: ok, umm does it render exactly where you drop it? | 01:00 |
| hatch | or is it rendered slightly off? | 01:01 |
| hatch | my laptop (which has IE10) has a low res screen | 01:01 |
| huwshimi | hatch: It's been rendering fine for me this morning, but I just went to double check and my VM died again. | 01:02 |
| hatch | crap, so what happens when it dies? | 01:05 |
| hatch | just crashes? | 01:05 |
| huwshimi | hatch: Yeah, this time it's complaining about having run out of disk space, but it has plenty | 01:06 |
| huwshimi | hatch: Now can't boot into it | 01:06 |
| hatch | :/ is there a 'free disk space' command? | 01:07 |
| hatch | I know parallels has that and has to be run from time to time | 01:07 |
| hatch | http://askubuntu.com/questions/219286/virtualbox-dynamic-disk-not-expanding-to-virtual-size | 01:09 |
| hatch | possibly related? | 01:09 |
| huwshimi | Oh it has actually run out of space, somehow it has taken up 12gb... | 01:12 |
| huwshimi | Not sure how to free that up... | 01:13 |
| hatch | huwshimi: maybe just increase the size of your vm | 01:16 |
| huwshimi | hatch: I run it off a disk and the vm has used up all the space on that disk. I'm just temporarily deleting some vm files so that I can boot the vm, clean up and then restore... | 01:17 |
| hatch | ohh | 01:18 |
| huwshimi | hatch: It's a new thing every other day that goes wrong :) | 01:19 |
| hatch | welcome to windows lol | 01:19 |
| hatch | huwshimi: any luck? | 01:38 |
| huwshimi | hatch: Not yet, it's repairing | 01:39 |
| huwshimi | well, it was, no feedback at the moment | 01:39 |
| hatch | oh boy - sounds like you might need to give it more space | 01:39 |
| hatch | I think mine has 32gigs | 01:39 |
| huwshimi | hatch: It has a few gb free at the moment | 01:39 |
| hatch | maybe it's paging things because it doesnt' have enough ram | 01:40 |
| huwshimi | hatch: It has heaps of ram | 01:42 |
| huwshimi | hatch: It's works! | 01:46 |
| huwshimi | Now to figure out what I can delete | 01:46 |
| huwshimi | hatch: The service block always appears with the top left point under the mouse | 01:48 |
| hatch | really... | 01:50 |
| hatch | hmm on a fresh trunk checkout? | 01:51 |
| huwshimi | hatch: Yes | 01:51 |
| huwshimi | hatch: I haven't seen it do anything else | 01:51 |
| hatch | pulling new trunk | 01:51 |
| hatch | gota 'make' then I'll test | 01:52 |
| hatch | ohh | 01:54 |
| hatch | you gota drop it on the big square in the middle | 01:54 |
| hatch | the thing below 'start adding charms' | 01:55 |
| hatch | actually it doesn't matter where I drop it, it's always off | 01:55 |
| huwshimi | hatch: Where does it up it? | 01:56 |
| hatch | wha? | 01:56 |
| huwshimi | hatch: put it? | 01:57 |
| hatch | ~40px from the left of the canvas under the sidebar about mid screen | 01:58 |
| hatch | I can demo it | 01:58 |
| hatch | if you want to hop into a hangout | 01:58 |
| hatch | I'm in guichat | 01:58 |
| hatch | http://bazaar.launchpad.net/~juju-gui/juju-gui/trunk/view/head:/app/views/topology/service.js#L426 is the method which handles the drop and the positioning | 01:59 |
| huwshimi | hatch: I'm not seeing that at all, on a fresh branch. Windows 8 IE10 | 01:59 |
| hatch | odd | 02:00 |
| hatch | checking the code | 02:00 |
| huwshimi | hatch: What's your screen res? | 02:01 |
| hatch | 1366x768 | 02:01 |
| huwshimi | hatch: Even changing my browser size doesn't change it | 02:03 |
| hatch | on this line http://bazaar.launchpad.net/~juju-gui/juju-gui/trunk/view/head:/app/views/topology/service.js#L443 put console.log(ghostAttributes.coordinates[index]); | 02:04 |
| hatch | and let me know what the two numbers are | 02:04 |
| huwshimi | hatch: Trying, but I think doing a disk cleanup and running IE were too much for the vm | 02:12 |
| hatch | jeesh and I thought I had hardware issues :) | 02:12 |
| huwshimi | hatch: 8 cores, 16gb ram is not the problem... 4gb ram and 4 cores are dedicated to the vm. Not sure why it runs so poorly. | 02:14 |
| huwshimi | hatch: I'm going to finish getting this VM back to normal and then I'll get back to you about the drag and drop | 02:15 |
| hatch | sure thing | 02:17 |
| hatch | huwshimi: just FYI I'm running it in a vm with 3GB of ram and 1 core | 02:18 |
| huwshimi | hatch: Virtualbox? | 02:21 |
| hatch | yup | 02:21 |
| hatch | V4.2.16 | 02:21 |
| huwshimi | I have .10 | 02:22 |
| huwshimi | (4.2.10 | 02:22 |
| huwshimi | ) | 02:22 |
| hatch | might be worth an upgrade | 02:22 |
| huwshimi | hatch: Did you change settings for the VM? | 02:22 |
| hatch | what do you mean? | 02:23 |
| hatch | the hard drive is 25GB | 02:23 |
| hatch | well what it thinks it's hard drive is | 02:23 |
| huwshimi | hatch: There are lots of little checkboxes that do things, but I don't know if I need to change any of them... | 02:25 |
| hatch | heh yeah there are | 02:26 |
| hatch | I fiddled with it long enough when I first started with it I remember | 02:26 |
| hatch | but I can't tell you what I changed and what was there | 02:26 |
| hatch | I know I had to do some command line trickery to think it had a resolution higher than like 400x600 | 02:26 |
| hatch | or something crazy | 02:26 |
| huwshimi | hatch: 137, 101. And it placed where I expected it to. | 04:02 |
| hatch | huwshimi: interesting - I get only negative numbers | 04:10 |
| hatch | in the am I'll have to try and get someone else to see if they can repro | 04:10 |
| hatch | huwshimi: are you in the 'Desktop' version of IE? or the Metro version? | 04:11 |
| huwshimi | hatch: Desktop | 04:14 |
| hatch | well what the heck hah | 04:14 |
| hatch | I suppose it's entirely possible mine is caching something wrong | 04:15 |
| hatch | :/ | 04:17 |
| hatch | I think you're lie'n to me so you don't have to fix it lol | 04:17 |
| huwshimi | heh | 04:21 |
| huwshimi | hatch: It's possible it's broken, I just can't reproduce it here | 04:28 |
| hatch | yeah but how's that possible haha | 04:28 |
| hatch | both on trunk same version of ie | 04:29 |
| huwshimi | hatch: Do you get the same thing in rev 940? | 04:45 |
| hatch | huwshimi: let me check | 05:10 |
| hatch | huwshimi: not exactly - that revno was before the fix for dropping the service on the center message | 05:13 |
| hatch | they are positioned incorrectly still however | 05:13 |
| hatch | I'm guessing it works correctly there? | 05:14 |
| huwshimi | hatch: You changed some positioning stuff the revision after that so I was hoping it might have worked back then... | 05:16 |
| hatch | yeah doesn't look like it - I'll get someone else to test it out, it could jsut be that mine is broken for whatever reason | 05:16 |
| hatch | I'm going to take off but if you could push up/email me with whatever you get done so we can merge it in that would be awesome | 05:16 |
| huwshimi | hatch: Sure. Night. | 05:17 |
| === rogpeppe1 is now known as rogpeppe | ||
| frankban | bac, benji: when you have time, could you please review https://codereview.appspot.com/12927049 ? | 13:09 |
| benji | sure | 13:09 |
| rick_h | jcsackett: ping | 13:09 |
| bac | frankban: sure. hey sorry i didn't get to your review yesterday before your EOD | 13:09 |
| frankban | bac: no problem and thanks | 13:10 |
| frankban | benji: thank you | 13:10 |
| rick_h | jcsackett: fyi, not sure where you are on the bug, but updated it with notes since I thought it might be my fault (though kind of an accidently worked thing) #1214058 | 13:15 |
| _mup_ | Bug #1214058: Cannot open Browse if sidebar is minimized <charmbrowser> <juju-gui:Triaged by jcsackett> <https://launchpad.net/bugs/1214058> | 13:15 |
| rick_h | hatch: ping when you get in. Want to chat about where we left off last week if you've got the time. | 13:16 |
| === robbiew1 is now known as robbiew | ||
| frankban | bac, benji: thanks for your reviews! | 13:43 |
| hatch | hey I gota run and take the car into the shop so I'll probably be back in 30-45 mins | 13:54 |
| hatch | rick_h: I normalized the constraints stuff so you're free to go on the ghost constraints | 13:54 |
| rick_h | hatch: k, will unblock the card then | 13:54 |
| rick_h | hatch: thanks and have fun at the dealer | 13:54 |
| hatch | lol dealer | 13:55 |
| hatch | ppl take their cars to the dealer? | 13:55 |
| hatch | :P | 13:55 |
| rick_h | hatch: yea, under warranty and all :P | 13:55 |
| jcsackett | rick_h: saw your notes, had come to the same conclusion yesterday, but thanks for the validation. :-) | 13:55 |
| hatch | riiiiight, my cars are too old haha | 13:55 |
| jcsackett | (not so much about what had happened, but about what was going on) | 13:55 |
| hatch | ok gota run be back in a few | 13:55 |
| rick_h | jcsackett: cool, wasn't sure where you were with it but I was curious as it seemed really strange any changes recently broke that :/ | 13:56 |
| jcsackett | rick_h: yeah, and the truth is it never really should have worked. :-P | 13:56 |
| rick_h | jcsackett: right, that made more sense :) | 13:56 |
| rick_h | in a ...strange...kind of way | 13:57 |
| jcsackett | rick_h: i'm glad you updated me though. i could see what was wrong but my update at standup was def going to be "i have no idea why this ever worked". | 13:57 |
| rick_h | jcsackett: sorry my z-index stuff borked a couple of other things on you | 13:58 |
| rick_h | jcsackett: it's the one line 'fixes' that kill | 13:58 |
| * jcsackett laughs | 13:58 | |
| jcsackett | you mean that floating sidebar icon thing? | 13:58 |
| jcsackett | at least it was an easy fix too. | 13:59 |
| rick_h | yea, as a drive IE fix I had to bump the z-index and then saw the bugs come out of it | 13:59 |
| jcsackett | ...of course another one-line, so we'll see what that borks. :-P | 13:59 |
| rick_h | but since it was a one-liner and I TRIVIAL'd it...WCPGR | 13:59 |
| jcsackett | ...i have no idea what that last acronym means. :-P | 14:00 |
| rick_h | jcsackett: that's SteveK's famous "What Could Possibly Go Wrong" /me misses that | 14:01 |
| jcsackett | aaaah. | 14:01 |
| jcsackett | yeah, we need to bring that back. | 14:01 |
| hatch | back | 14:23 |
| hatch | rick_h: on the weekend I installed cruise and a stereo into the mrs car and now it's off to get a new windshield - I typically do all of my own repairs but it's cheaper to have someone else install the windshield :) | 14:24 |
| rick_h | hatch: defintely. special tool to pull the gasket around there and such | 14:25 |
| rick_h | hatch: was blown away by how fast a pro could do it | 14:25 |
| hatch | yep! | 14:26 |
| hatch | so who has IE running? | 14:26 |
| hatch | huw said he couldn't repro this bug https://bugs.launchpad.net/juju-gui/+bug/1213260 and was looking to see if it's fixed for anyone else too | 14:26 |
| _mup_ | Bug #1213260: DDing a charm renders service icon under sidebar <ie10> <juju-gui:New> <https://launchpad.net/bugs/1213260> | 14:26 |
| rick_h | hatch: looking | 14:26 |
| rick_h | hatch: yea, not doing it here | 14:28 |
| rick_h | hatch: even if I just drop it 'right' past the edge of the sidebar, the left side of the service block is a few px east of the sidebar edge | 14:28 |
| hatch | well I'm glad....but slightly irritated because that means there is something wrong with my IE :/ | 14:30 |
| rick_h | hatch: updating the bug with my screenshot of a tiny IE window working right. Re-open if you can dupe or find something. | 14:31 |
| hatch | rick_h: mind closing the ticket as cannot reproduce? Just so we have a record of it | 14:31 |
| hatch | oh I can dupe the issue for sure | 14:31 |
| hatch | but noone else can lol | 14:31 |
| rick_h | hatch: well, marked it invalid with the notes about 'cannot reproduce' | 14:31 |
| hatch | oh right...that's how it works | 14:32 |
| hatch | did anyone get an email from huw about what he was working on? | 14:32 |
| * rick_h didn't see anything | 14:33 | |
| hatch | allllright then | 14:33 |
| sinzui | jcsackett, 1x1? | 14:33 |
| hatch | rick_h: so the constraints util method should all be gtg now, and all you need to do is create another wrapper around the constraints partial to loop through the fields | 14:34 |
| rick_h | hatch: looking | 14:34 |
| jcsackett | sinzui: yes. | 14:34 |
| jcsackett | sinzui: i'm in the hangout attached to the appt | 14:35 |
| hatch | rick_h: remember the performance discussion we had about etags and mobile? You should watch these talks it outlines the issues in detail in the first video https://plus.google.com/118445028821328031751/posts/hz2XpU76xzN | 14:39 |
| rick_h | hatch: will put it on for lunch time viewing. thanks | 14:40 |
| hatch | it has some really great information in it - there is like 3.5h of talks in the playlist hah | 14:40 |
| === BradCrittenden is now known as bac | ||
| hatch | Makyo: as far as core is concerned what happens if the constraints aren't specified? | 15:09 |
| Makyo | hatch, Aren't specified? As in, you send a set-constraints with no constraints, or as in you deploy without specifying? | 15:09 |
| hatch | both I suppose - assuming the constraints object is empty | 15:10 |
| hatch | right now there are no errors it appears? | 15:10 |
| hatch | doe stha tmeans it picks the lowest possible? | 15:10 |
| hatch | wow I can't type | 15:10 |
| Makyo | hatch, Don't know off the top of my head, I'd assume it just allocates whatever size is specified in your ~/.juju/environments.yaml, which is a machine class, like tiny, small, etc. | 15:11 |
| hatch | alright so with none specified in the gui a good name would be 'Default' ? | 15:11 |
| Makyo | I'd make sure with luca. That makes sense to me, but others might not know where that default is specified - I've been using Juju for a year, so I've got that advantage. | 15:12 |
| hatch | good point | 15:13 |
| hatch | luca: are you there? | 15:13 |
| hatch | *poke poke* | 15:13 |
| luca | Makyo: hatch heya | 15:13 |
| hatch | when 'scaling up' the dialogue shows you the current constraints | 15:13 |
| hatch | if none are specified....what shoudl be shown? | 15:13 |
| luca | hatch: the defaults | 15:13 |
| hatch | we can't get the defaults | 15:14 |
| hatch | all the info we have is that there isn't anything specified | 15:14 |
| Makyo | luca, if you deploy without constraints, it uses what's specified in your environments.yaml file, which we don't have access to. | 15:14 |
| hatch | right now I have Default Ghz Default GB ..... etc | 15:14 |
| luca | Makyo: hatch right. What do you think we should show? | 15:15 |
| hatch | I like 'Default' | 15:15 |
| hatch | although then people won't know what those are | 15:15 |
| hatch | but it's kind of a chicken/egg issue there | 15:15 |
| Makyo | I suppose I'd expect a 'use defaults from environment.yaml' checkbox that disables fields, maybe? But yeah, I have experience with juju | 15:16 |
| hatch | I'd say that could be in the 'set constraints' section | 15:17 |
| hatch | but in the 'these are your current settings' section | 15:17 |
| hatch | maybe we just have Default for now, and then when we add 'help bubbles' they can say where the defaults are set | 15:17 |
| Makyo | Yeah, prowling through the machine and unit objects in the db from improv, we don't have any specs. | 15:19 |
| Makyo | Don't know how meaningful improv is, not checking against core yet. | 15:19 |
| hatch | jujugui lf two quick reviews and an IE QA on https://codereview.appspot.com/12987045/ plz | 15:39 |
| Makyo | hatch, on it | 15:39 |
| Makyo | Got the IE bit. | 15:39 |
| rick_h | hatch: looking | 15:39 |
| hatch | right arm! | 15:39 |
| hatch | I needed to get these landed so that I can finish the upgrade ux heh | 15:40 |
| hatch | darn IE | 15:40 |
| rick_h | hatch: what do I need to do to see the original bug? | 15:40 |
| hatch | scale up the units without editing the constraints so it'll say 'Default CPU Default GB ... | 15:41 |
| hatch | if it doesn't wrap then you're good | 15:41 |
| hatch | and as far as the X's just focus an input, if there is no X in the post deployment inspector then you are good | 15:41 |
| rick_h | hatch: ok, the bug states on 'inputs' and so I was checking on the config inputs | 15:42 |
| hatch | yeah I left the X on ones which aren't databound | 15:42 |
| rick_h | I didn't realize IE did the X clear on non type="search" inputs | 15:42 |
| hatch | just incase IE ppl like that X for some reason... | 15:42 |
| rick_h | and yea, the config ones are actually textareas so bad check | 15:43 |
| hatch | shift + cmd + left is so much faster than trying to find the damn X with the mouse :) | 15:43 |
| hatch | rick_h: did you want me to comment in the css why the part I removed is no longer required? | 15:48 |
| hatch | I'm a little confused by the comment | 15:48 |
| Makyo | jujugui call in 9, kanban now | 15:51 |
| Makyo | hatch, want to run it today, then I'll get W/Th, you get F? | 15:51 |
| hatch | sounds like a plan | 15:52 |
| * hatch gets out the whip | 15:52 | |
| * hatch just pulling alittle stewie there | 15:52 | |
| bac | benji: after the call a review of https://code.launchpad.net/~bac/charmworld/json-for-deployer/+merge/181087 ? | 15:55 |
| benji | bac: sure | 15:56 |
| luca | Makyo: hatch got called away, did you get a solution hehe? | 15:58 |
| Makyo | luca, Don't have anything atm, was hatch's task. | 15:59 |
| Makyo | jujugui call in 1 | 15:59 |
| Makyo | luca, will poke around more after the call. | 15:59 |
| luca | Makyo: cool | 16:00 |
| hatch | luca: I just ended up going with 'Default' instead of undefined when it's not specified | 16:00 |
| luca | hatch: nice, ok | 16:00 |
| hatch | luca: if you decide you want it changed in the future it's pretty easy to change | 16:15 |
| benji | bac: your branch looks good. I had a question though: do we need URLs without user names for promulgated bundles? | 16:19 |
| rick_h | benji: yes, the jujugui charm is an example | 16:19 |
| bac | benji: last week we discussed that and decided that the deployer will always want a versioned basket | 16:20 |
| rick_h | err, ignore me | 16:20 |
| bac | benji: that decision is open to be revisited but that's what i went o | 16:20 |
| bac | n | 16:20 |
| bac | benji: btw, this branch was very easy to do based on the nice stuff you added recently | 16:21 |
| benji | bac: right, I think we always want a version, but don't we want to be able to say "I want the official big mysql cluster bundle, regargless of who is its current manager"? | 16:22 |
| benji | I'm glad to hear I made the code a bit better. | 16:22 |
| hatch | jujugui does anyone know the status/details of the card in Inspector 'Inspector does not work with core: cannot iterate over undefined WRT units' ? | 16:25 |
| bcsaller | no, sorry, sounds like that one needs testing with a real core deployment | 16:26 |
| hatch | yeah there is no ticket attached :/ | 16:27 |
| Makyo | I created it in a rush, sorry. | 16:27 |
| Makyo | Will try again. | 16:27 |
| Makyo | Just wasn't listing units. | 16:27 |
| bac | benji: yeah, perhaps. sinzui do you have an argument against what benji says? | 16:27 |
| hatch | Makyo: ohh, so that really needs to be fixed then before we unflag? | 16:27 |
| Makyo | If it's still an issue. | 16:27 |
| bac | benji: it'll be trivial to add... | 16:27 |
| benji | yeah; if we aren't sure one way or the other we can land it as-is and add this later | 16:28 |
| hatch | Makyo: if you have time today/tomorrow it would be awesome if you could test it out again :) | 16:28 |
| Makyo | hatch, doing it now; need a juju environment up anyway. | 16:29 |
| hatch | oh awesome thanks! | 16:29 |
| hatch | I got my first SMS spam this morning at 5am - I have finally made it! | 16:29 |
| Makyo | hatch, looks good, trashing the card. | 16:43 |
| hatch | *phew* thanks for looking into that Makyo | 16:44 |
| sinzui | bac: We do want to support short url. the GUI will always use the full url. But from the command line, I might want to type just:fast-wordpress | 16:47 |
| sinzui | bac, remember search will only return tip and reviewed bundles have a higher score,. The GUI will always suggest the user use the latest official charm. | 16:48 |
| hatch | rick_h: I'm just going through the tickets and came across this one https://bugs.launchpad.net/juju-gui/+bug/1209016 I know you fixed it but it appears that the + sign doesnt turn orange on hover...is this a css or image issue? | 16:51 |
| _mup_ | Bug #1209016: Right hand zoom slider handles sprited improperly <juju-gui:Triaged by rharding> <https://launchpad.net/bugs/1209016> | 16:51 |
| sinzui | bac: benji: do either of you have time to review https://code.launchpad.net/~sinzui/charmworld/api3-search/+merge/181092 ? I have an implementation question and am open to discuss net steps. | 16:51 |
| adeuring | sinzui: could you have a look a this MP: https://code.launchpad.net/~adeuring/charmworld/1206659-simpler-es-mapping/+merge/181100 ? | 16:52 |
| * sinzui looks | 16:53 | |
| rick_h | hatch: looking | 16:53 |
| rick_h | hatch: looks like a JS issue. The hover class is added, but the sprite css doesn't change the icon. If you hard edit the css the image will show | 16:55 |
| rick_h | hatch: so rather than adding a css class it needs to add and remove | 16:55 |
| hatch | right looks like the old class is still taking precident | 16:56 |
| hatch | I'll make a card for this ticket | 16:56 |
| rick_h | hatch: comment added with the details https://bugs.launchpad.net/juju-gui/+bug/1209016/comments/1 | 16:56 |
| _mup_ | Bug #1209016: Right hand zoom slider handles sprited improperly <juju-gui:Triaged by rharding> <https://launchpad.net/bugs/1209016> | 16:56 |
| hatch | cool thanks | 16:57 |
| rick_h | jcsackett: did you need a second pair of eyes on the event stuff? | 16:57 |
| rick_h | jujugui I'm having a hard time concentrating through the meds. Going afk. | 16:59 |
| Makyo | Alright, good luck | 16:59 |
| sinzui | adeuring, r=me with comments | 17:06 |
| adeuring | sinzui: thanks! | 17:06 |
| adeuring | sinzui: Making the two lists "constants" is fine, but I don't understand your suggestion to add an XXX: Do you mean line 230 of the diff? I don't think that an XXX is needed there | 17:11 |
| sinzui | adeuring, okay. I wont press you to make the change. | 17:12 |
| sinzui | jujugui. Note that https://jenkins.qa.ubuntu.com/ is not responding. So charmworld is not collecting charm test results at the moment. | 17:18 |
| hazmat | hmm | 17:18 |
| hazmat | sinzui, raising to webops | 17:19 |
| bac | hazmat, sinzui: i got booted off-line. m_3 and i raised the jenkins issue on #is yesterday | 17:59 |
| m_3 | bac: they're still working it too it looks like | 17:59 |
| sinzui | thank you bac | 18:00 |
| bac | m_3, even more dead than yesterday | 18:00 |
| bac | benji: thanks for the review. i'm going to land it now and do the promulgated as another branch | 18:02 |
| benji | cool | 18:02 |
| bac | sinzui, benji: do we think this is the URL to get JSON for the deployer use for promulgated branches: http://manage.jujucharms.com/bundles/mysql/tiny/json | 18:33 |
| benji | bac: I /think/ so. I don't remember exactly. | 18:34 |
| bac | benji: i've added it to the doc and will proceed. having an optional version right in the middle is not pretty | 18:36 |
| benji | mmm | 18:36 |
| bac | or maybe the version is only there if there is an owner | 18:36 |
| sinzui | bac, I think so. There is no version and no owner in it | 18:39 |
| sinzui | bac: I shared "Deploying Charmworld and Juju-GUI to Prodstack" with jujugui and orangesquad so that everyone knows the fastest way to get things deployed | 18:40 |
| bac | sinzui: yay | 18:40 |
| bac | sinzui: i have given it a gold star so i'll always have it with me. | 18:42 |
| hatch | rick_h: back yet? | 18:52 |
| rick_h | hatch: what's up? | 19:45 |
| hatch | rick_h: oops sorry didn't see you replied | 19:59 |
| hatch | I'm going to be changing the template that the constraints use a little | 19:59 |
| rick_h | hatch: rgr | 19:59 |
| hatch | feelin better? | 19:59 |
| rick_h | hatch: little bit, took a half day sick and a nap | 20:00 |
| rick_h | now nap-groggy, but wheeeee | 20:00 |
| jcsackett | hey hatch, since updating your jshint i'm getting complaints about the 2 line indents on all files. any idea what i need to change? | 20:21 |
| hatch | jcsackett: you merged trunk? | 20:22 |
| jcsackett | that's how i got your jshint update. | 20:22 |
| jcsackett | should there no longer be 2 space indents? | 20:22 |
| * jcsackett goes to see if there's more trunk to merge | 20:22 | |
| hatch | hmm well no there should be | 20:23 |
| hatch | guichat real quick? | 20:23 |
| jcsackett | hatch: sure, one sec. | 20:24 |
| sinzui | bac, do you have time to give me some feedback on https://code.launchpad.net/~sinzui/charmworld/api3-search/+merge/181092 | 20:25 |
| bac | sinzui: sure | 20:25 |
| Makyo | jujugui (hatch, bcsaller?) - the saveAs noop is what's causing the memory leak for me in the websocket_logging tests. Am I behind on a version or something? Have clean-all' | 20:28 |
| Makyo | Have run clean-all etc. | 20:28 |
| bcsaller | afaik that code hasn't been touched in quite some time, this is the export saveAs you're referencing? | 20:29 |
| Makyo | It's just the line "saveAs = function() {};", I think. In the browser, as hatch says, I get a save as dialog, but Phantom just dies, then I get a message that it's used all available system memory. | 20:31 |
| hatch | oh THAT's why phantom always dies for me now | 20:31 |
| jcsackett | hatch: threw node_modules/jshint/bin into my path and now all is well. | 20:31 |
| hatch | jcsackett: awesome :) | 20:31 |
| hatch | Makyo: looking at the test | 20:32 |
| Makyo | hatch, it | 20:32 |
| Makyo | It's test/test_websocket_logging.js:59 | 20:32 |
| Makyo | That test. | 20:32 |
| hatch | oh em gee who wrote FileSaver.js | 20:35 |
| hatch | lol | 20:35 |
| bcsaller | FileSaver.js is a polyfill we pulled in | 20:35 |
| bac | sinzui: are you asking for a full review? or a mid-imp discussion? | 20:35 |
| hatch | bcsaller: yeah I know, :) | 20:36 |
| hatch | Makyo: what if you change those to websocketLogging.prototype.saveLog = ... ? | 20:36 |
| sinzui | bac. I hope the former, but the later is not unreasonable since I think the metadata issue should be solved in this branch | 20:37 |
| jcsackett | jujugui: can i get two reviews for https://codereview.appspot.com/13092044 | 20:38 |
| hatch | on it | 20:38 |
| jcsackett | thanks, hatch. | 20:40 |
| Makyo | No luck, hatch | 20:42 |
| hatch | darn - ok I'll have to look into the memory profile in a few | 20:43 |
| Makyo | Will poke around too | 20:43 |
| rick_h | jcsackett: reviewing | 20:43 |
| rick_h | jcsackett: sanity check on the test method there please. | 20:44 |
| rick_h | jcsackett: but other than that ok. Heading out. | 20:44 |
| rick_h | grrr, reviewboard is timing out | 20:45 |
| hatch | Makyo: hmm I can't reproduce the memory leak in the browser | 20:46 |
| hatch | does it happen in the browser for you too or just in phantom? | 20:47 |
| Makyo | hatch, just phantom, the browser shows the save dialog. | 20:47 |
| hatch | ok I don't get any save dialogue | 20:47 |
| hatch | and I shouldn't because the saveLog method was monkeypatched | 20:47 |
| bac | sinzui: is the metadata currently used? i think your suggestion is a good one. | 20:48 |
| hatch | it.only('responds to the saveWebsocketLog event', function(done) { | 20:48 |
| Makyo | hatch, the memory bug seems to be a phantom thing, closing uncleanly because of a crash with the file saving. | 20:48 |
| hatch | that's the proper test right? | 20:48 |
| Makyo | That appears to be it. | 20:48 |
| hatch | ok trying phantom | 20:48 |
| jcsackett | rick_h: ack. | 20:48 |
| hatch | no issues | 20:48 |
| hatch | Makyo: maybe I need your branch | 20:48 |
| Makyo | That's why I was wondering about versions. | 20:49 |
| hatch | ok well trunk as far as this morning was A O K | 20:49 |
| hatch | if you push up your branch I can take a look | 20:49 |
| sinzui | bac: it is not used for bundles. Aaron and rick introduced it to charms to describe things we add to the charm, like related_charms. I think adding to metadata is keeping with the grand plan, but you or benji might know of changes to the plan while I was in IoM | 20:50 |
| Makyo | hatch, I haven't touched that test, nor anything that test touches. I'm currently checking trunk, so give me a sec. if it is my branch, I'll push it and send it your way. | 20:50 |
| hatch | alrighty | 20:51 |
| bac | sinzui: i don't know anything about it. it looks good to me. | 20:51 |
| hatch | maybe it's just in your head ;) | 20:51 |
| * hatch waves his hand "this is not the test you are looking for" | 20:51 | |
| Makyo | Nnnnnnno. | 20:51 |
| Makyo | hatch, dies in trunk, too. | 20:52 |
| hatch | hmm | 20:52 |
| hatch | that's very odd | 20:52 |
| hatch | phantomjs --version ? | 20:53 |
| hatch | I'm showing 1.9.1 | 20:53 |
| sinzui | Okay. then I will add doctype to meta data to charm and bundle in API3. bac I intended to look at the index_client.api_search() I discovered. Do you agree? Or should I work on the interesting endpoint? | 20:53 |
| hatch | Makyo: the thing that's intersting is that you said you get a save dialog - I do not... | 20:54 |
| Makyo | 1.8.0 - let me try updating. | 20:54 |
| hatch | yeah that version is pretty old | 20:55 |
| hatch | Dec 2012 | 20:55 |
| * hatch crosses fingers | 20:55 | |
| bac | sinzui: api_search | 20:55 |
| Makyo | That's what I was thinking, s'why I asked. Hope it works! | 20:55 |
| sinzui | bac, thank you for the direction. | 20:55 |
| * sinzui cleans up metadata rules | 20:56 | |
| Makyo | hatch, It crashes faster this time :) | 20:57 |
| hatch | lol | 20:57 |
| hatch | and it works perfectly fine here... | 20:58 |
| hatch | 11MB of ram usage | 20:58 |
| Makyo | Fffff. | 20:58 |
| Makyo | It's no longer memory-leaking, thankfully. | 20:58 |
| Makyo | Just crashing. | 20:59 |
| hatch | ohh ok | 20:59 |
| hatch | phantomjs always crashes on me for no reason | 20:59 |
| hatch | I just restart the test | 20:59 |
| hatch | but with the .only on that test it's fast | 20:59 |
| hatch | and no crashy | 20:59 |
| hatch | running the .only on the describe | 21:00 |
| hatch | ahah! | 21:00 |
| * hatch made it crash | 21:00 | |
| hatch | it's actually crashing in it('can save a log', function() { | 21:00 |
| hatch | because saveAs isn't actually a global | 21:01 |
| hatch | ReferenceError: Can't find variable: saveAs | 21:02 |
| hatch | see it's defined on line 24 of test_websotkcet | 21:03 |
| hatch | or whatever my fingers meant to type | 21:03 |
| hatch | holy crap this FileSaver.js file is hard to read | 21:04 |
| hatch | Makyo: https://gist.github.com/hatched/919583b63f7d9c336c0d | 21:08 |
| hatch | fixed | 21:08 |
| Makyo | hatch, oh! | 21:09 |
| Makyo | Linter runs on tests, are we okay with removing 'use strict'? | 21:09 |
| hatch | probably not | 21:09 |
| hatch | :) | 21:09 |
| hatch | Makyo: var saveAs = saveAs; outside of the closure with a flag to tell jshint it's OK | 21:11 |
| hatch | /* jshint: -W079*/ for example | 21:12 |
| hatch | I'm actually wondering how the heck that EVER ran | 21:12 |
| hatch | lol | 21:12 |
| hatch | Makyo: did that work for you as well? | 21:15 |
| Makyo | hatch, started raining and I was hang-drying stuff outside. Let me try. | 21:15 |
| hatch | shoot I gota run pick the car up from the glass place before they close | 21:20 |
| hatch | will bbiab | 21:20 |
| Makyo | \o/ | 21:21 |
| Makyo | Thanks hatch | 21:21 |
| hatch | w00t w00t! | 21:21 |
| hatch | no problem :) | 21:21 |
| hatch | back | 21:37 |
| * bac dogwalk | 21:38 | |
| Makyo | bac, http://imgur.com/gallery/DLXSjcS | 22:26 |
| huwshimi | Morning | 23:01 |
| bac | hi huwshimi | 23:25 |
| huwshimi | bac: Hey | 23:26 |
| bac | huwshimi: i'm working on charmworld. and we've got some pages that needs some styling love. any chance you'd be able to look at them? | 23:27 |
| huwshimi | bac: Sure, what needs to be done? | 23:27 |
| bac | huwshimi: i just created a page to display the info for bundles and just laid it out as tables. so, it could be re-arranged to be more pleasant. and the charm display page is ugly with overlapping text: http://manage.jujucharms.com/charms/precise/etherpad-lite | 23:28 |
| bac | huwshimi: if you can look i'll send you an email tomorrow with details. | 23:29 |
| huwshimi | bac: Sure, that's fine. Let me know! | 23:30 |
| bac | huwshimi: the bundle page is at http://staging.jujucharms.com/~abentley/bundles/wiki-bundle/wiki | 23:30 |
| bac | huwshimi: have you ever worked on charmworld before? if not i'll embellish my email with how to get up and running. it is a pretty simple process. | 23:31 |
| huwshimi | bac: I have done, but it was last year I think, so might be worth putting in some instructions just in case :) | 23:32 |
| bac | will do. thanks for the help! | 23:32 |
| huwshimi | bac: No problems. | 23:34 |
| bac | huwshimi: email sent. it is pretty minimal but i think its enough. let me know if you need more detail. | 23:45 |
| huwshimi | bac: Thanks, that looks fine for me to get started/ | 23:47 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!