/srv/irclogs.ubuntu.com/2013/08/20/#launchpad-dev.txt

=== hloeung is now known as Guest71555
=== Guest71555 is now known as hloeung
=== Ursinha is now known as Ursinha-afk
=== Ursinha-afk is now known as Ursinha
=== Ursinha is now known as Ursinha-afk
StevenKwgrant: https://code.launchpad.net/~stevenk/launchpad/distroseries-spec-preload/+merge/180046 is updated, and it failed ec2 last night, but the only failures were related to builders and Fault 8002.02:10
wgrantStevenK: When last night did you start it?02:12
wgrantI thought I fixed the 8002s in the early afternoon.02:12
wgrantHum02:12
wgrantNo, 21:0602:12
StevenKwgrant: It finished at 9pm, so 5ish02:12
wgrantRight, so you had the bad lpbuildd02:12
wgrantSo that's fine02:12
wgrantI'll review after lunch02:12
wgrant:)02:12
StevenKwgrant: Than microservices!!02:13
wgrantI'm melting strawberry atm.02:13
StevenKPoor strawberry02:16
StevenKwgrant: It's after lunch; good news, bad news, no news?04:08
* StevenK takes that as 'no news'04:54
wgrantSoon soon05:09
stubStevenK: You can review my branches if you are bored ;)05:09
=== tasdomas_afk is now known as tasdomas
wgrantStevenK: I've done a bit of testing of buildd-manager on DF.05:36
wgrantHave you looked at all?05:36
StevenKI have not.05:36
wgrantI think it's probably OK to deploy, particularly now that the ARM buildds don't suck; slightly overzealous error handling isn't going to be a huge problem any more.05:36
StevenKThe pandas are still around, just manualed, right?05:37
wgrantI believe they're inactived.05:37
wgrantBut probably not actually switched off yet.05:37
wgrantYeah, still not there on /builders.05:37
StevenKThey seem to be gone, indeed05:37
StevenKWe probably need a fitz, though05:37
StevenKwgrant: If the new stuff works fine with un-upgraded buildds, then I agree about the error handling, and we should deploy.05:39
wgrantIf something goes terribly wrong we can always undeploy :)05:45
StevenKwgrant: WRT lines 125-127, the method involved is one that deletes workitems that aren't referenced any more and is only called by updateWorkItems. I wanted to be certain it grabbed whatever was latest. But I can change it to use the cached version if you wish.07:09
wgrantStevenK: I thought the one I pointed out was in workitems_text07:13
wgrantThe one after was updateWorkItems07:13
wgrantBut I may be wrong07:13
StevenKThe one after is lines 134-13707:14
StevenKThat one doesn't used the cached version since we just deleted non-matching workitems, and the old code duplicated the method anyway.07:15
StevenKAnd we blow the cache away at the end of the method anyway07:15
StevenKwgrant: workitems_text is lines 88-89 and 97-10207:16
StevenKAnd does make use of the cached property, for obvious reasons.07:16
wgrantAh, you're right07:16
wgrantI was looking at the wrong part of the file.07:16
StevenKwgrant: Your objection is withdrawn?07:17
wgrantIndeed07:17
StevenKwgrant: I'm looking into your suggestion about rewriting the horrible double loop07:18
StevenKwgrant: Blah, I forgot about a comment I rewrote to be less like a novel, but: http://pastebin.ubuntu.com/6005501/07:20
wgrantStevenK: That makes a lot less nonsense.07:21
StevenKI didn't want to stuff around with going back from specid in work_items_by_spec.keys() to spec so I could get a cache -- if the spec id isn't in work_items_by_spec it returns [] anyway since it's a defaultdict.07:22
wgrantStevenK: Oh, since you're going through rows this time you can remove the code that presets the work_items cache to []07:23
StevenKGood point, killed.07:24
StevenKI shall push and land07:24
=== Ursinha-afk is now known as Ursinha
=== Ursinha is now known as Ursinha-afk
=== Ursinha-afk is now known as Ursinha
=== tasdomas is now known as tasdomas_afk
=== BradCrittenden is now known as bac

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!