=== hloeung is now known as Guest71555 === Guest71555 is now known as hloeung === Ursinha is now known as Ursinha-afk === Ursinha-afk is now known as Ursinha === Ursinha is now known as Ursinha-afk [02:10] wgrant: https://code.launchpad.net/~stevenk/launchpad/distroseries-spec-preload/+merge/180046 is updated, and it failed ec2 last night, but the only failures were related to builders and Fault 8002. [02:12] StevenK: When last night did you start it? [02:12] I thought I fixed the 8002s in the early afternoon. [02:12] Hum [02:12] No, 21:06 [02:12] wgrant: It finished at 9pm, so 5ish [02:12] Right, so you had the bad lpbuildd [02:12] So that's fine [02:12] I'll review after lunch [02:12] :) [02:13] wgrant: Than microservices!! [02:13] I'm melting strawberry atm. [02:16] Poor strawberry [04:08] wgrant: It's after lunch; good news, bad news, no news? [04:54] * StevenK takes that as 'no news' [05:09] Soon soon [05:09] StevenK: You can review my branches if you are bored ;) === tasdomas_afk is now known as tasdomas [05:36] StevenK: I've done a bit of testing of buildd-manager on DF. [05:36] Have you looked at all? [05:36] I have not. [05:36] I think it's probably OK to deploy, particularly now that the ARM buildds don't suck; slightly overzealous error handling isn't going to be a huge problem any more. [05:37] The pandas are still around, just manualed, right? [05:37] I believe they're inactived. [05:37] But probably not actually switched off yet. [05:37] Yeah, still not there on /builders. [05:37] They seem to be gone, indeed [05:37] We probably need a fitz, though [05:39] wgrant: If the new stuff works fine with un-upgraded buildds, then I agree about the error handling, and we should deploy. [05:45] If something goes terribly wrong we can always undeploy :) [07:09] wgrant: WRT lines 125-127, the method involved is one that deletes workitems that aren't referenced any more and is only called by updateWorkItems. I wanted to be certain it grabbed whatever was latest. But I can change it to use the cached version if you wish. [07:13] StevenK: I thought the one I pointed out was in workitems_text [07:13] The one after was updateWorkItems [07:13] But I may be wrong [07:14] The one after is lines 134-137 [07:15] That one doesn't used the cached version since we just deleted non-matching workitems, and the old code duplicated the method anyway. [07:15] And we blow the cache away at the end of the method anyway [07:16] wgrant: workitems_text is lines 88-89 and 97-102 [07:16] And does make use of the cached property, for obvious reasons. [07:16] Ah, you're right [07:16] I was looking at the wrong part of the file. [07:17] wgrant: Your objection is withdrawn? [07:17] Indeed [07:18] wgrant: I'm looking into your suggestion about rewriting the horrible double loop [07:20] wgrant: Blah, I forgot about a comment I rewrote to be less like a novel, but: http://pastebin.ubuntu.com/6005501/ [07:21] StevenK: That makes a lot less nonsense. [07:22] I didn't want to stuff around with going back from specid in work_items_by_spec.keys() to spec so I could get a cache -- if the spec id isn't in work_items_by_spec it returns [] anyway since it's a defaultdict. [07:23] StevenK: Oh, since you're going through rows this time you can remove the code that presets the work_items cache to [] [07:24] Good point, killed. [07:24] I shall push and land === Ursinha-afk is now known as Ursinha === Ursinha is now known as Ursinha-afk === Ursinha-afk is now known as Ursinha === tasdomas is now known as tasdomas_afk === BradCrittenden is now known as bac