| wgrant | StevenK: mm | 00:19 |
|---|---|---|
| StevenK | wgrant: http://pastebin.ubuntu.com/6012298/ its pretty ugly | 00:31 |
| wgrant | StevenK: I think that's still more consistent, and not that ugly. | 00:32 |
| StevenK | wgrant: Except that the initial value no longer works, and the ordering of the form changed to have distroseries at the top | 00:33 |
| wgrant | Hmm | 00:34 |
| wgrant | OK, maybe the other way is better. | 00:34 |
| StevenK | Now for some tests | 00:39 |
| StevenK | wgrant: https://code.launchpad.net/~stevenk/launchpad/set-initial-archive-daily-build/+merge/181440 | 02:12 |
| === Ursinha is now known as Ursinha-afk | ||
| wgrant | StevenK: Sounds good | 03:26 |
| wgrant | About to land a 2kline buildd-manager branch, btw. | 03:26 |
| wgrant | Extracting all the twisted stuff out of the Builder DB class. | 03:26 |
| === Ursinha-afk is now known as Ursinha | ||
| StevenK | wgrant: OMG | 03:43 |
| lifeless | don't forget to ask for special dispensation :P | 03:44 |
| wgrant | The Twisted stuff isn't completely layered on top of the DB stuff yet, but it's close. | 03:45 |
| StevenK | wgrant: It stops the commit madness? | 03:46 |
| wgrant | No. | 03:47 |
| wgrant | But letting the Twisted stuff run without touching the DB objects is a prerequisite. | 03:48 |
| wgrant | So they need to be split. | 03:48 |
| StevenK | Right. | 03:48 |
| StevenK | wgrant: So this is the first step, cool. It won't conflict with Colin's abort work? | 03:49 |
| wgrant | StevenK: His remaining b-m branch is small and merges pretty easily, but I've prepared a merge branch. | 03:51 |
| StevenK | wgrant: So I get to spend an hour reviewing twisted and having my brain leak out of my ears? | 03:54 |
| wgrant | No, it's sufficiently mechanical, Twisted and brain-melting that it's not worth reviewing. It's well-tested, pretty simple, and so repetitive that you'd be unlikely to notice any issues. | 03:55 |
| wgrant | The next branch will probably want review :) | 03:55 |
| lifeless | it being 2K LOC is also why you wouldn't notice issues | 03:55 |
| wgrant | It's not very splittable, because the bits all interact. | 03:56 |
| lifeless | I get that | 03:56 |
| lifeless | just saying, part of the problem is size. | 03:57 |
| wgrant | Sure | 03:57 |
| * StevenK waits for lifeless to start banging buildd-manager-as-a-microservice drum | 03:57 | |
| wgrant | 800 lines of anything is reviewable :) | 03:57 |
| StevenK | Speaking of, microservices! | 03:57 |
| wgrant | And this is a big part of splitting buildd-manager out into a | 03:57 |
| wgrant | more separate thing. | 03:57 |
| StevenK | wgrant: Talking to the DB how? | 03:57 |
| wgrant | Probably XML-RPC initially. But that's way down the line. | 03:58 |
| wgrant | The main thing now is to get sane structure. | 03:58 |
| lifeless | StevenK: I don't need to bang the drum, you guys are on it | 03:58 |
| StevenK | Mostly as a humour device | 04:00 |
| lifeless | boom tish | 04:14 |
| wgrant | StevenK: You broke the build. | 04:19 |
| StevenK | I could have sworn I ran tests before proposing | 04:21 |
| StevenK | wgrant: I'll fix when my tea that isn't dishwater is done | 04:21 |
| === stub` is now known as stub | ||
| === wallyworld__ is now known as wallyworld | ||
| === jam1 is now known as jam | ||
| === tasdomas_afk is now known as tasdomas | ||
| === mpt_ is now known as mpt | ||
| === Ursinha is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
| === tasdomas is now known as tasdomas_afk | ||
| === Ursinha is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
| === tasdomas_afk is now known as tasdomas | ||
| === tasdomas is now known as tasdomas_afk | ||
| === Ursinha is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
| === Ursinha is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!