[12:30] BradCrittenden: you can't seem to settle on a name here lately [12:30] I have a small review up that could use your attention: https://code.launchpad.net/~benji/charmworld/migration-018-delete-bundles/+merge/181807 [12:30] benji: yeah, i got the dropouts. [12:31] ooh, I hear that can be fatal [12:31] the nick retention period is much longer than the time it takes me to reconnect so it won't let me have 'bac' === BradCrittenden is now known as bac === bac is now known as InigoMontoya [12:32] * InigoMontoya prepare to die [12:38] InigoMontoya: you can /release the nick by talking to NickServ and he'll let you have it back [12:40] benji: no, it isn't a problem, i can usually get it back quickly. but i have to notice the problem after my client reconnects [12:41] why does your client choose the wrong nick? [12:41] benji: b/c when it reconnects freenode has not yet released 'bac' and i guess i have the longer one as my alternate. [12:42] ah; I have some purge-all-past-incarnations commands that my client runs when I connect. That helps a bit with that. [12:42] benji: moving on to other topics: i'm about ready to break out 'rev' as a separate field in the mongo doc. it seems crazy to go to all of the trouble i'm having just for this issue. [12:43] benji: it can still be part of the _id as needed [12:43] benji: reality-based objections? [12:43] makes sense; will you also have the search_id as part of the document, so you can search on it? [12:44] no, but Falcor isn't a fan of the idea [12:44] ah, who am I kidding, Falcor loves everyone [12:44] unsure about search_id [12:46] I figured that since you want to search on everything but the revision, the search ID would be the way to go (since that's what it is) [13:02] * sinzui sets charmworld to benji's 264 [13:02] 364 I mean [13:02] rick_h: if you can look at https://codereview.appspot.com/12935046/ again i updated it yesterday. [13:04] jcsackett: cool looking [13:04] jcsackett: ah, I saw jeff gave you a lgtm so I didn't go back to it [13:04] rick_h: it's LGTM with your proposed changes; figured i would make sure you were happy with those changes. [13:05] if you want to hand wave it i'm happy to go ahead and land it. :-P [13:05] ok, looking now [13:07] benji, I see from the log the migration was run. I still see the wiki bundle. This might be a timing issue because ingest starts *before* the website is brought back up [13:08] jcsackett: replied. [13:08] rick_h: dig, thanks. [13:10] jujugui: i need two reviews on https://codereview.appspot.com/12741050 and someone with IE to QA. it's an easy one--just a bunch of deletions. [13:11] sinzui: I would suspect timing. The migration is simple and its tests seem to be representative. If the bad bundle doesn't cause any errors, I would suspect re-ingestion. [13:12] benji, The ES data is different. The search that worked yesterday doesn't work. I think all is well. [13:12] cool! [13:12] benji, are bundles ingested first? [13:12] thanks for working on it [13:12] I don't know the order off the top of my head. [13:12] * benji looks [13:13] I think they are, meaning the first bundles will always be place before the website restarts [13:13] sinzui: it depends on the hash order of a dictionary, so it should be consistent, but is unspecified [13:27] benji, bac: do either of you have time to review https://code.launchpad.net/~sinzui/charmworld/provide-type-from-api-search [13:27] bac, benji: when you have time, could you please review https://codereview.appspot.com/12802045 ? [13:27] sinzui: sure [13:27] frankban: sure [13:27] frankban: sure === InigoMontoya is now known as bac [13:28] thank you both [14:03] kind of short notice http://www.yuiblog.com/blog/2013/08/23/save-the-date-yuiconf-nov-6-7 [14:03] hatch: ^ [14:04] hatch: Makyo updated the branch from yesterday with the bi-directional go constraint conversersion, refactoring, added the sandbox tests/adjustments. https://codereview.appspot.com/13084045 [14:05] hatch: Makyo appreciate a second look though I know I got LGTM yesterday. Feel like a lot's changed, but part of that is in my head [14:13] rick_h, on it [14:15] jujugui: can i get two reviews on https://codereview.appspot.com/12741050, please? [14:15] jcsackett: will look in a sec [14:15] rick_h: thanks. [14:16] jcsackett, on it. [14:16] Makyo: thanks! [14:20] jcsackett, admin thinks you are on holiday today. Did you forget? [14:23] sinzui: it's a half day, PM. [14:23] leaving at noon. [14:23] jcsackett, sorry, I thought you had extended it to the whole day. [14:24] I think I am the only member of Orange working on Monday. [14:28] benji, about the access to _representation. I too was hoping that we would have solved this by now for bundles and charms. maybe both classes should have a property that returns dict(self._representation) [14:31] sinzui: that would be fine with me; I do worry a little about non-canonical key/values sneaking in, plus it would be nice to have the properies get a chance to return things. How about returning dict((key, getattr(self, key)) for key in self._COMMON_REPRESENTATION) [14:34] Makyo: did you do the IE QA on jcsackett's branch? [14:35] benji, yes, that is better. Maybe we want a guard in the class that ensures unwanted keys are always rejected. __init__ looks flawed. if it was ensured a sane dict, calling @representation or dict(Bundle(data)) could be trusted [14:36] sinzui: yep, I like putting the gate earlier too (dict(Bundle(data)) can actually be trusted now because it does its own filtering, but I get your point) [14:37] benji, okay. I will report a bug for this because I think we want to fix this bad pattern for charms and bundles. [14:37] sounds good [14:40] rick_h, ah, will do that now. [14:40] Makyo: that's ok, was wondering. My lbox submit finished so I can pull it into my colo now [14:40] I'll poke at it [14:41] rick_h, oh, alright. [14:42] bac, sinzui: could you trying the branch: lp:~adeuring/charmworld/1206659-spurious-errors ? it should fix a number of spurious failures, even some in tests that were not disabled in r362, but I'd like some independent test runs before I claim that everything is fixed... [14:42] adeuring: sure! [14:42] thank you adeuring [14:45] adeuring: how long does 'make test' take to run on your slow and fast machines? [14:45] luca, ping [14:45] Makyo: heya [14:47] luca, the upgrade service ux appears in two different places in the mockup. I like the second one better - after all of the unit management stuff - because this is by service, not by units, and having it mixed in confused even me for a bit. Can I go with that one? [14:47] luca, on https://www.dropbox.com/s/d6sc200adk2dszs/juju-gui-2-inspector-09.jpg [14:48] Makyo: they are the same but different :D [14:48] Makyo: There is 2 use cases going on here [14:48] Makyo: #1 I need to upgrade my servicer [14:48] Makyo: #2 I need to revert my service [14:49] luca, Why is it mixed in with units? [14:49] Makyo: When there is a new upgrade that the user hasn't seen yet, the "A new upgrade is available" populates near the top [14:49] Makyo: there isn't really a "mixed in with units" thing, they are just notifications, it's all about hierarchy [14:50] luca, I keep getting wireframes with no explanation and being told to implement. I'd appreciate a call. [14:50] jujugui call in 10 kanban now. [14:50] Makyo: Ah, thats fine. We actually worked with gary on this and most of this way his idea, I would of thought he would of briefed you guys on it before delegating it out. [14:51] luca, nope. [14:51] Makyo: right, when are you available? [14:51] luca, now for 9 minutes, and in an hour and nine minutes for several hours. [14:51] bac: the slow one needs ca 100 seconds (...and I just noticed another test failure...) [14:51] adeuring: i'm running the tests but they are taking forever to run [14:51] ..and the fast machine now show a ton of errors even for trunk... [14:52] adeuring: in past 'make test' took about 74 seconds for me. this one is taking minutes [14:53] bac: interesting. I changed a status check when a temporary index is created for a test. Could be related. [14:55] adeuring: still on the first line of dots of test output [14:55] bac: Then just abort it... [14:55] adeuring: even if all tests pass, this is too painful [14:55] right [14:59] jujugui call in 1 [15:06] adeuring: try scripts/reset-db? [15:06] adeuring: in a bind, i've rm /var/lib/elasticsearch too [15:07] bac: yes [15:07] i tried both, but i did not restart mongodb, as suggested by sinzui [15:19] rick_h, constraints are passed from pyjuju in the get_service call, and are hooked up, at least in the inspector. [15:19] rick_h, will check go too. [15:19] Makyo: k, cool. Yea I figure pyjuju worked and maybe we never got around to checking/working on -core? [15:20] rick_h, yeah, will do that now. [15:25] sinzui: you said "it is not in saucy". were you referring to pyjuju or core? that is, what is in saucy? [15:26] pyjuju is not in saucy [15:27] sinzui: ah, that makes sense [15:27] sinzui: I heard it the other way as well [15:27] sorry for speaking in curtisese [15:32] rick_h: I'm going to revert the inspector and then I can help you out [15:33] hatch: k, all good. [15:34] Bleh, debug-log no longer uses newlines, nearly impossible o read. [15:34] joy [15:35] matt I crested a card in urgent and put our heads on it for the IE10 QA [15:36] hatch, Cool, thanks/ [15:37] crested a card [15:37] hmm [15:37] lol [15:39] rick_h, I am getting constraints from core, too, but they're showing up strangely. It looks like core responds only in MB, but GUI expects GB for memory, so it says I created a machine with 2048GB of memory. I hope that's not the case :) [15:39] Makyo: hah, ok. Good to know. Maybe that follow up card isn't much work then. [15:39] Makyo: curious to trace how it was getting the data format and fitting it to the UX [15:40] 2048GB of ram....that must be rick_h's new desktop [15:40] hah, I'm about 2012 short [15:40] lol [15:41] err, 2016 that is. /me can't do match on fridays [15:41] rick_h, It looks like it's just populated in the service model's attrs and bound in the inspector from there. [15:41] Makyo: cool [15:41] Makyo: yea, I saw some stuff in the utils that generates titles and such for the UX so maybe it's doing it there. [15:42] luca, ping; I'm free if you've got some time before your end of day. [15:43] Makyo: ok, I'm in a meeting with Mark S at the moment but I'll join guichat when I'm out. [15:43] luca, alright, thanks. [15:48] frankban: I finally finished looking at your branch, it looks good [15:50] benji: great, thanks [16:06] Makyo: I'm on GUI chat [16:06] bcsaller, in guichat if you want to join [16:18] Makyo: after your call, was that -core constraint working done via the gui? e.g. you deployed and set a constraint from the gui and then when you opened it back up it was loaded ok, just off as far as units? [16:19] rick_h, deployed from command line in a real env. `juju deploy --constraints mem=2G cs:precise/mysql` [16:19] Makyo: ok, I'd be curious then if settnig via the gui does work since that's where I was looking for us to translate the names of the constraints to the Go format. [16:24] hatch: running out to grab some food. Looks like my last branch had the wrong 'structure' for constraints and so needing to clean that back up. Latest work is in lp:~rharding/juju-gui/ghost-constraints-1125352 if you want to poke and if you wanted to pair on it in a bit. [16:24] rick_h: ok sure - I have a few emails to write then I'll be on it [16:25] hatch: np, biab [16:45] hmm [16:45] fresh trunk test failures.... [16:52] I'm always confused how this happens [16:56] oh it did fail in CI too [16:56] it was just masked by the selenium failures [16:56] hatch: details on what I broke? [16:56] frankban: review done [16:57] rick_h: I think it was a bad merge [16:57] hatch: hmm, yea that sucks. I mean it has to merge/pass tests to land so confused [16:57] rick_h: https://gist.github.com/hatched/13dd112c33c1263476f4 [16:57] bac: thanks! [16:57] oh woops [16:57] heh [16:57] the 'expected' is the Constraints object [16:58] ^ rick_h [16:58] hatch: yea, looking [16:58] hmm, those are tests I changed and such but not seeing the /actual/expected [16:59] hatch: but I can pull down trunk again and see if I can replicate it locally. Sec [17:01] thanks [17:01] hatch: ok, I have the same error here. Will hack a branch to see what's up/fix it. [17:02] * rick_h wonders how the $@#$@# it landed then. [17:02] yeah right!?!? [17:02] maybe you had an old test server running :D [17:02] that caught bcsaller once hehe [17:02] oh, and the lbox hit that vs its own? [17:02] yup [17:03] hmm, guess that's possible. I was running tests. [17:07] hatch: cool, easy fixes. Must have done that I guess. Sorry about that :/ [17:07] yeah....you'll pay for this.... [17:08] with your cpu.....mohohahahahahaha [17:08] I figure that would be from Futurama [17:08] haven't I already suffered enough on this card? plus more lboxing...the punishment! [17:08] pssht lboxing for you is what....20s? :P [17:08] no, stupid bzr/launchpad/branching :/ [17:09] ahhh right right [17:12] rick_h: gave you an lgtm [17:12] hatch: cool thanks. [17:17] hatch: ok, fix heading down for that. [17:17] great - once it lands I can then revert the flag branch [17:17] it's in trunk at least. bzr pull will have it and you can start [17:18] cool proposing [17:21] jujugui fyi I'm putting bugs which will block the release in maintenance/urgent [17:21] hatch: k [17:23] jujugui review for reverting the inspector as the default https://codereview.appspot.com/12739049/ [17:25] Makyo: I can't find any IE10 specific bugs \o/ lemme know what your result is whenever you get a chance [17:26] hatch: looking [17:27] landing thanks for the reviews Makyo rick_h [17:38] My IE is so small :S I should see if I can get VB to pretend like I have a bigger monitor. The unit details view goes off the edge of the screen. [17:42] Happens in all browsers, ditto with fullscreen. I think I just have it smaller than our minimum size is all [17:44] hatch, maybe worth a card, but I don't think I'd consider it a blocker. Looks fine once I get above something like 1024x768 :P [17:46] haha that's pretty small === rogpeppe3 is now known as rogpeppe [17:49] hatch, yeah. vbox just picked up a small default. [17:50] hatch, also, relation labels are too high. Also small. Probably defaulting to a baseline at the bottom rather than the middle. [17:50] hatch, no blockers, though. Everything looks/works fine otherwise. [17:59] awesome! :D [17:59] thanks for that [18:00] man, almost have my own charmworld/juju-gui running in lxc containers but can't configure the juju-gui to set the charmworld url away from manage.jujucharms.com [18:01] rick_h: sounds like a bug to me :) [18:03] hatch: trying to set via cli and see if it works [18:04] hatch: yea, worked via cli. hmmm, need a release to check if it works via the inspecgtor [18:08] http://uploads.mitechie.com/lp/lxc-jujugui.png so that's all in lxc containers. Charmworld hadn't finished ingesting and such. However cool to run it all locally. [18:08] pretty quick overall [18:08] so thanks for the charm-school jcastro ^ [18:10] that is awesome :) I need to do that at some point [18:11] 20GB of ram left, time to try to run 100 juju-guis [18:11] very odd issue with the CI failures this time [18:11] I guess I'll retrigger it and see what happens [18:11] rick_h: so where are we with the ghost constraints stuff? Anything i can help with? [18:12] hatch: sorry, took a break to watch the charm school on lxc stuff to test things coming up. [18:12] hatch: so we're doing ok. Fixing the constraints object conversion to work [18:12] python works, go api fails. [18:13] who needs Go anyways [18:14] heh, my branch is going to leave the api set to go in the config-debug per our discussion today [18:15] I think I missed that discussion [18:15] guichat to bring me up to speed? [18:15] sure [18:32] awesome HTC is going to fix the mrs phone - now I can go get a new phone haha [18:42] canceled CI trying again... [18:43] hatch: ok, might need a chat after all. Data seems to go in, won't come back out [18:45] rick_h: ok in a few minutes just eating a sandwitch :) [18:45] hatch: rgr [18:51] arg I don't know what's up with this CI [18:56] rick_h: ok sandwitch done ....guichat? [18:57] hatch: rg [18:57] rg [18:57] damn rgr [19:41] benji, sinzui: in our google doc, we agreed the api endpoint should be plural "bundles" but it is still "bundle". any objections to me fixing it? [19:41] bac: are we going to change "charm" to "charms"? [19:42] wait, there already is a "charms" [19:42] bac: we changed it the other way, API2 had "charms" but API3 has "charm" [19:42] bac, charms/ is a searchable collection, charm/ is an individual charm [19:43] bac /search is a collection of all bundles and charms and it replaces charms/ [19:43] sinzui, benji: looky here: https://docs.google.com/a/canonical.com/document/d/17bgbReU6JJMoUHSJeo8egG5zoSM0fpPIs7U8F1-Piyk/edit#heading=h.u3246vho9aig [19:43] bundle/ would provide a single bundle I think [19:43] fourth bullet point [19:43] http://staging.jujucharms.com/api/3/bundles/~abentley/wiki-bundle/1/wiki [19:44] bac, I know.bundles/ is fine because we moved charms/ to search/ [19:44] bac: I don't really care much one way or the other, just making the current state known [19:45] bac, benji. I don't have an opinion about the plural of bundle(s)/, but I want it to be consistent with charm/ which is what we have now [19:46] +1 [19:46] we can rename charm to charms/ in api3 [19:46] sinzui: well it is easier to fix the google doc than the code [19:46] * sinzui is dizzy from seeing all his work not come to fruition today [19:47] actually, no because we have: [19:47] http://manage.jujucharms.com/~sinzui/bundles/mysql/5/tiny/json [19:47] http://manage.jujucharms.com/bundles/mysql/tiny/json [19:48] so, in the branch i'm about to propose they are all going to be 'bundles' [19:48] if we want to change them to 'bundle' we can do that, after updating the doc [19:48] i gotta land this thing! [19:49] bac, sure. We will revisit all the URLs in SEO soon anyway [20:00] bac, I can review your branch if you want https://code.launchpad.net/~bac/charmworld/official-bundle-json/+merge/181909 [20:00] * sinzui needs a break from failing to show interesting bundles [20:00] sinzui: it has conflicts. i'll let you know when it is fixed -- thanks! [20:26] sinzui: conflicts fixed [20:26] sinzui: sorry the diff is so long [20:28] bac: np [20:28] bac, can you review https://code.launchpad.net/~sinzui/charmworld/api3-interesting/+merge/181910 ? It is very short because I got lost [20:28] sure [21:17] bac, I replied with 2 questions [21:20] sinzui: ok [21:28] sinzui: thanks for the mongo sort reminder. i'd tried that yesterday, before i made basket_revision a field. i'll make that change now. [21:29] sinzui: as to the other, yes basket_with_revision is a better name [21:29] bac okay. I was only asking questions. Make changes as you like; r=me [21:56] sinzui: would you update https://docs.google.com/a/canonical.com/document/d/17bgbReU6JJMoUHSJeo8egG5zoSM0fpPIs7U8F1-Piyk/edit# with check marks? [21:56] bac, The 3 interesting parts aren't done-done [21:57] I did verify routing with versions is good [21:57] sinzui: 4b and 4c aren't done? [21:58] bac, api supports them, but until we change ingest and views to collect the data, no one will see which is new or popular [21:59] well...considering how new bundles are, we might not ever see popular bundles [22:01] good point sinzui. [22:01] * bac dog walk [22:17] bac, I deployed your changes to staging. They work for the most part, but I think there is something amiss with the basket-name: http://staging.jujucharms.com/~abentley/bundles/wiki-bundle/1/wiki/json is not found and a search for abentley finds a bundle without a basket. [22:21] bac, I need to make dinner so will sign off. I think we need to update ingest or the model to handle the / in the basket. I see this in the DB: { "_id" : "~abentley/wiki-bundle/1/wiki", "owner" : "abentley", "basket" : "wiki-bundle/1"} [22:22] well, before I go I will delete the bundle from staging so that we can check with a fresh ingest. [22:23] man there has to be something wrong with canonistack [22:25] hatch, how do you mean [22:25] the ci just hangs after loading in the selenium deps [22:25] and I can't find anything wrong with it [22:26] it's like it can't create a new instance or something [22:27] hatch, are the deps enormous? [22:27] I don't think so it always gets to "FInished processing dependencies for selenium==2.33.0" [22:27] then sits there for 45mins until it times out [22:33] hatch, I wonder if there is a network issue. I thought this might be an issue with the charm payload. which is bug 1156649 [22:33] <_mup_> Bug #1156649: pyJu fails to deploy/upgrade charm with 32MB payload [22:34] hmm nope it's not even getting that far [22:34] I think I'll bench this and make a card [22:34] start on it again on monday [22:34] hatch, I think you are getting much farther since you have an instance doing an install [22:34] have a nice weekend [22:35] you too! [22:38] bac: I have good news and bad news. Since I did not go away as I claimed I was, I was here fir the reingest of the bundle. It works! this means we need a migration to purge all bundles before your changes are activated. Oh, but since I happen to know benji landed just such a migration 9 hours ago, we can just pretend you have. I am confident that no bundles will be in the db when we restart production. [22:39] bac have a nice weekend. [22:41] * benji is glad to be part of the good news for once. [22:51] * bac missed the bad news [22:52] it sounded like good news & good news