| wgrant | Yeah, I knew it would be bad, and we've been down some IS staff here for the last couple of weeks, otherwise I would have done it myself. | 00:05 |
|---|---|---|
| wgrant | Thanks :) | 00:05 |
| wgrant | StevenK: https://code.launchpad.net/~wgrant/launchpad/builderinteractor-updateBuild/+merge/182600 | 00:12 |
| StevenK | wgrant: So there's no code changes, just moving it? | 00:44 |
| wgrant | StevenK: Apart from porting TTBB to override handleStatus instead, yeah. | 00:46 |
| wgrant | Otherwise it's basically just s/self._interactor/self/ | 00:47 |
| StevenK | wgrant: r=me with a small niggle | 00:49 |
| wgrant | Commenting circular imports is pointless. | 00:50 |
| wgrant | I've never understood why we do it | 00:50 |
| wgrant | Need to know whether an import is circular? If it's inside a function, it's circular. | 00:50 |
| wgrant | Need to find all circular imports? bzr grep '^\s+import' | 00:51 |
| StevenK | True. But currently, we tend to comment on them. | 00:54 |
| wgrant | It might become more reasonable if we have a sane code structure such that they don't appear in almost every file. | 00:54 |
| StevenK | That would be nice. | 00:55 |
| wgrant | But now you can barely read a notable function without seeing at least one, so commenting them is silly. | 00:55 |
| StevenK | Right. | 00:56 |
| cjwatson | wgrant: How about http://paste.ubuntu.com/6038589/ as a refactoring of the Sources/Packages path handling in series-alias (untested, but general idea)? It's more LOC than before, but perhaps that's worth it. I'm on the fence. | 00:57 |
| cjwatson | I thought about making it a method on the publisher config. Not sure about that. | 00:57 |
| wgrant | cjwatson: I think that's clearer. I think having them as functions is fine. | 00:58 |
| wgrant | I like keeping the path joining and string formatting rules in one place | 00:59 |
| * cjwatson sets the archivepublisher tests going and really goes to bed, then | 00:59 | |
| cjwatson | Thanks | 00:59 |
| wgrant | Thanks, and night | 00:59 |
| jtv | wgrant: excellent downtime announcement email BTW. I saw one from Microsoft the other day and the difference is palpable. | 02:47 |
| wgrant | I think our announcements win simply by not quoting the times in some random timezone | 03:00 |
| wgrant | Particularly when someone quotes an outage time in PST when they actually mean PDT... | 03:00 |
| jtv | Seriously? | 03:00 |
| jtv | It's a bit like that ad a friend spotted in late 1999... | 03:00 |
| wgrant | Yeah, Americans don't do timezones, even their own. | 03:00 |
| jtv | "Even in the year 2000 we will be there for you 365 days." | 03:01 |
| wgrant | Heh | 03:01 |
| jtv | He was itching to call them and ask: given that 2000 is a leap year, and surely you have dealt with Y2K bugs such as mistaking it for a non-leap year, which day will you be unavailable?" | 03:02 |
| * jtv was sad to discover at a quiz that only one other contestant knew how to calculate leap years | 03:02 | |
| jtv | Doubly sad: one, a room full of teachers was largely unaware; and two, there was the bare minimum of awareness to rob our team of that 1-point advantage. | 03:05 |
| wgrant | Well, everyone'll hopefully learn by 2100 :) | 03:07 |
| jtv | They'd better! | 03:07 |
| jtv | Loved that Sun joke at the time... "Y5K bug (or whatever the number was) discovered in Java. A team at Sun is reportedly rushing to fix the problem." | 03:08 |
| wgrant | StevenK: https://code.launchpad.net/~wgrant/launchpad/builderinteractor-cookies/+merge/182813 https://code.launchpad.net/~wgrant/launchpad/axe-the-ibb/+merge/182814 | 04:21 |
| StevenK | wgrant: r=me for both | 04:54 |
| wgrant | StevenK: Thanks. | 04:55 |
| wgrant | Nearly disentangled. | 04:57 |
| === jam1 is now known as jam | ||
| StevenK | wgrant: One more branch | 05:01 |
| StevenK | ? | 05:01 |
| wgrant | I've got one more branch of cleanups, and then I think I can start pulling the DB dependencies up. | 05:02 |
| wgrant | That mostly involves heavily caching a few builder attributes and the slave build cookie. | 05:03 |
| wgrant | and then a SlaveScanner should be able to handle most operations other than the start and end of a build without touching the DB. | 05:03 |
| StevenK | So its another 3 or 4 branches, right | 05:03 |
| wgrant | And I will have succeeded in stopping the commits. | 05:03 |
| wgrant | Something like that. | 05:03 |
| StevenK | wgrant: So why was there an IBB, that's what I can't understand | 05:07 |
| wgrant | StevenK: BuildFarmJobBehavior used to have updateBuild etc. on it | 05:08 |
| wgrant | Including updateBuild_IDLE | 05:08 |
| wgrant | Every scan would go through to a BFJB. | 05:08 |
| wgrant | And the BFJB could do with the result whatever it wanted. | 05:09 |
| wgrant | But nothing ever overrode anything except updateBuild_WAITING, and I don't want to have to create a BFJB from the DB for every scan. | 05:09 |
| wgrant | So I moved those general methods up into the new BuilderInteractor. | 05:09 |
| wgrant | In related news, https://code.launchpad.net/~wgrant/launchpad/direct-action/+merge/182818 | 05:09 |
| wgrant | It sorta made sense back in 2009 when it was designed, as not everything was going to have a BuildFarmJob. | 05:10 |
| wgrant | So the original TTBJ implementation overrode a couple of the others. | 05:11 |
| wgrant | But that's long fixed. | 05:11 |
| wgrant | StevenK: Do you vaguely see what I'm working towards here? | 05:13 |
| wgrant | BuilderInteractor will cache enough information to do normal scans without hitting the DB. A single new worker in buildd-manager will scan the DB every n seconds and update all the cached information on each SlaveScanner's BuilderInteractor, and another new worker will grab the logtail from each SlaveScanner and flush them all to the DB at once. | 05:15 |
| StevenK | wgrant: r=me | 05:31 |
| wgrant | Thanks. | 05:31 |
| cjwatson | wgrant: I don't suppose you fancy canonicalising the spelling of "behaviour" in your buildmaster rearrangements? :-) | 11:30 |
| * cjwatson was just bitten by that again | 11:30 | |
| wgrant | cjwatson: I think I've been consistent, but I will happily switch to the real spelling now that we've exterminated the Americans :) | 11:31 |
| wgrant | Though knowing my luck that will cause lots of extra lines to wrap, giving me a good excuse to rename current_build_behavior to something less silly too. | 11:32 |
| wgrant | cjwatson: That branch will fail with devel merged | 12:04 |
| wgrant | The middle argument to handleStatus is gone. | 12:04 |
| wgrant | (it was an ILibrarianClient that hadn't been used in 3 years) | 12:04 |
| cjwatson | I'd better merge devel into buildmaster-cancel-properly then | 12:08 |
| wgrant | It won't conflict with that | 12:10 |
| wgrant | As the new handleStatus was added in the branch you landed a couple of weeks ago. | 12:10 |
| cjwatson | Yeah. Fixed now. | 12:12 |
| === Ursinha is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
| === Ursinha is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!