wgrant | Reproduced the exception on DF | 00:10 |
---|---|---|
wgrant | There's no way it could have worked yesterday | 01:09 |
wgrant | Yet I quoted the log showing that it did | 01:09 |
wgrant | I wonder if the code was out of date. | 01:10 |
cjwatson | wgrant: https://code.launchpad.net/~cjwatson/launchpad/failure-count-reset/+merge/183320 | 11:16 |
* cjwatson goes off for a while | 11:17 | |
wgrant | Looking | 11:17 |
wgrant | Thanks | 11:17 |
cjwatson | wgrant: One of these days I will get the hang of Twisted. | 13:30 |
wgrant | cjwatson: Heh | 13:31 |
wgrant | The key thing here is that a Deferred isn't executed until the reactor gets to it, and the reactor won't get it unless you return it all the way up. | 13:31 |
cjwatson | wgrant: Yeah. It's not that I don't know it, but I still find it excessively easy to forget. | 14:19 |
wgrant | Indeed. | 14:19 |
cjwatson | wgrant: I must admit I'm fairly confused about how/where the reactor is started in test code, though. | 14:59 |
cjwatson | Oh, "run_tests_with = AsynchronousDeferredRunTest.make_factory(timeout=20)" maybe ... | 15:01 |
Guest46080 | cjwatson: Right, AsynchronousDeferredRunTest lets tests return a deferred | 23:31 |
=== Guest46080 is now known as wgrant | ||
=== wgrant is now known as Guest34878 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!