/srv/irclogs.ubuntu.com/2013/08/31/#launchpad-dev.txt

wgrantReproduced the exception on DF00:10
wgrantThere's no way it could have worked yesterday01:09
wgrantYet I quoted the log showing that it did01:09
wgrantI wonder if the code was out of date.01:10
cjwatsonwgrant: https://code.launchpad.net/~cjwatson/launchpad/failure-count-reset/+merge/18332011:16
* cjwatson goes off for a while11:17
wgrantLooking11:17
wgrantThanks11:17
cjwatsonwgrant: One of these days I will get the hang of Twisted.13:30
wgrantcjwatson: Heh13:31
wgrantThe key thing here is that a Deferred isn't executed until the reactor gets to it, and the reactor won't get it unless you return it all the way up.13:31
cjwatsonwgrant: Yeah.  It's not that I don't know it, but I still find it excessively easy to forget.14:19
wgrantIndeed.14:19
cjwatsonwgrant: I must admit I'm fairly confused about how/where the reactor is started in test code, though.14:59
cjwatsonOh, "run_tests_with = AsynchronousDeferredRunTest.make_factory(timeout=20)" maybe ...15:01
Guest46080cjwatson: Right, AsynchronousDeferredRunTest lets tests return a deferred23:31
=== Guest46080 is now known as wgrant
=== wgrant is now known as Guest34878

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!