[00:10] Reproduced the exception on DF [01:09] There's no way it could have worked yesterday [01:09] Yet I quoted the log showing that it did [01:10] I wonder if the code was out of date. [11:16] wgrant: https://code.launchpad.net/~cjwatson/launchpad/failure-count-reset/+merge/183320 [11:17] * cjwatson goes off for a while [11:17] Looking [11:17] Thanks [13:30] wgrant: One of these days I will get the hang of Twisted. [13:31] cjwatson: Heh [13:31] The key thing here is that a Deferred isn't executed until the reactor gets to it, and the reactor won't get it unless you return it all the way up. [14:19] wgrant: Yeah. It's not that I don't know it, but I still find it excessively easy to forget. [14:19] Indeed. [14:59] wgrant: I must admit I'm fairly confused about how/where the reactor is started in test code, though. [15:01] Oh, "run_tests_with = AsynchronousDeferredRunTest.make_factory(timeout=20)" maybe ... [23:31] cjwatson: Right, AsynchronousDeferredRunTest lets tests return a deferred === Guest46080 is now known as wgrant === wgrant is now known as Guest34878