/srv/irclogs.ubuntu.com/2013/09/03/#ubuntu-unity.txt

=== racarr|desert is now known as racarr
Mirvif any Unity8 devs around, filed a stack publishing preventing bug https://bugs.launchpad.net/unity8/+bug/122005705:51
ubot5Launchpad bug 1220057 in Unity 8 "Failing autopilot test EphemeralNotificationsTests.test_urgency_order" [Critical,New]05:51
dednickmzanetti: ping07:18
mzanettidednick: good morning07:18
dednickmzanetti: howdy.07:18
dednickmzanetti: do you know much about object ownership changes passing between c++ & qt?07:19
mzanettidednick: you mean QML?07:19
dednicksorry, yes07:19
dednickmzanetti: as in passing a (new QObject) back into qml.07:20
mzanettidednick: there are some QML components which take ownership of the objects if they don't have another parent yet07:20
dednickmzanetti: is that only with QMLComponent, or QQuickItem as well?07:20
mzanettiQQuickItems as well.07:21
mzanettidednick: so if you just do a new QObject() and put it somewhere into a view, the view will set itself as parent07:21
dednickmzanetti: QObject as well?07:22
dednickdoesnt seem to be happening for me :(07:23
dednicknot even with a QQuickItem07:23
dednickmzanetti: do you know it it works with qml properties ?07:26
dednickmzanetti: like "property Item action: menu.getAction(...)"07:27
dednickwhere getAction returns new object07:27
mzanettidednick: no. in that case I don't think its reparented07:28
dednickmzanetti: hm. ok07:28
dednickmzanetti: thanks. guess that would be my problem then :)07:28
larsudednick: morning :)07:28
dednicklarsu: hey :)07:28
dednicklarsu: just talking about your code.07:29
larsudednick: yep, just read that07:29
mzanettidednick: you need it to be reparented?07:29
larsudednick: so the problem is basically that I'm parenting the actions to the model?07:29
dednicklarsu: yep. but also the way we work it in qml using a property doesnt change the owner of the object07:30
dednickmzanetti: yep07:30
larsudednick: but surely it does js-style ref counting?07:30
dednicklarsu: apparently not.07:31
dednicklarsu: i removed the parent in the function, but they're not being deleted.07:31
mzanettidednick: you really sure about that? I mean... if c++ code does a "new"... you really want it to "get lost" in javascript?07:31
dednicklarsu: the js counting only works within js functions i think07:31
larsudednick: ah, this is what I'm trying right now as well. Sigh.07:32
dednickmzanetti: yeah, i would prefer that we left delete responsibility to what creates them, but it sticks around forever.07:32
mzanettidednick: well. if its about the cleanup you could do something like this: MyQMLItem { Componet.onDestruction: myCppObj.destroy() }07:33
mzanettiwhich will call deleteLater() on QObject iirc07:33
dednickmzanetti: the property can change as well. so those will be lost.07:34
larsudednick: I guess we need something like this: https://qt-project.org/doc/qt-5.0/qtqml/qqmlengine.html#setObjectOwnership07:36
mzanettiinteresting...07:37
dednicklarsu: http://qt-project.org/wiki/SharedPointersAndQmlOwnership . but i dont think it applies in this case07:37
dednicklarsu: as far as i've read Q_INVOKABLE funcions have the ownership set to JavaScriptOwnership, but maybe that isnt the case...07:39
larsudednick: right, so we shouldn't have to call setOwnership explicitely07:40
dednicklarsu: from my understanding07:41
dednicklarsu: guess we could give it a go and see if it changes things07:41
dednicklarsu: maybe using them on a property setter is behaving differently under this circumstance.07:41
larsudednick: I'm trying right now07:41
larsudednick: nope, same problem07:43
dednicklarsu: ok, i think having the index property may be the best option. Then we dont have to worry about ownership.07:44
dednicksince we can just create the object in qml07:44
dednicklarsu: the index will be bound to the modelIndex, so changes to that will need to sync down to the registration.07:45
dednickstupid custom actions.07:49
larsudednick: stupid non-existent ref-counting :P07:50
greybackmzanetti: hey, using the app api in unity-api, found something that's problematic with it. Question: do you ever call the get(index) method to get a raw ApplicationInfo object?08:24
mzanettigreyback: I don't think I need it, no08:25
greybackmzanetti: because I'm wondering why we have that ApplicationInfo class at all. I'm thinking it should be an implementation detail, not something that needs to be given to QML in any way (which get() does)08:25
mzanettigreyback: why that?08:25
greybackmzanetti: well get() returns the ApplicationInfo object. The only place that's needed is for focusApp() and stopApp(). Why not instead just always use appId as the unique identifier, not at times using a appId, other times using ApplicationInfo*08:26
mzanettigreyback: so if you want to pass stuff on to somewhere else you need to pass all the 5 strings separately08:27
greybackmzanetti: do you need to do that? As I don't08:28
mzanettigreyback: actually I intended to pass the ApplicationInfo object to the launcher plugin and have all the data in there. without the need of starting to parse .dekstop files again08:28
mzanettigreyback: not really the get() method, but as parameter in applicationFocused08:28
greybackmzanetti: ok I see what you're doing08:28
nic-doffaymzanetti, I'm not really sure what you mean by this: * it breaks the narrowMode decision. Try opening the search field and drag it smaller/bigger and compare that to trunk08:28
greybackmzanetti: yes then you find it useful. Okay, will think a bit more08:29
mzanettigreyback: not that I would _really_ need it. but it feels like a good idea to minimize parsing the file system08:30
mzanettinic-doffay: just try it :)08:30
greybackmzanetti: no true. Having 1 object that has all the data from the desktop file ready internally, that can be shared around, makes sense08:31
mzanettigreyback: which still leaves one question open08:32
mzanettigreyback: I'd need to link the applicationinfo implementation in the launcher plugin08:32
mzanettinot really sure yet how to do that08:32
greybackmzanetti: yep. Is do-able, will see once implementation done & working.08:37
sil2100bregma: hi!08:37
sil2100bregma: we have a serious unity AP problem that's blocking the unity from releasing: https://bugs.launchpad.net/unity/+bug/121963608:38
ubot5Launchpad bug 1219636 in Unity "unity autopilot tests fails to move mouse, leading to infinite test run" [Critical,New]08:38
sil2100bregma: it most probably doesn't happen all the time, but frequently08:38
larsudednick: ah there you are. I'm almost done rewriting that patch.08:54
dednicklarsu: cool08:54
nic-doffaymzanetti, any idea who would know more about those icon themes?09:47
nic-doffayI'd like to get to the bottom of why certain icons aren't available for me.09:47
larsudednick: something's totally off now, UnityMenuAction instances aren't even created for me anymore :(09:50
larsunic-doffay: it looks like the gicon image provider has been removed?!09:50
* larsu only judges by all the warnings he's seeing09:51
dednicklarsu: can you push your branch to junk or something?09:51
nic-doffaylarsu, there are so many image related warnings I lose track >_<09:51
larsunic-doffay: right :( Let's fix them!09:51
nic-doffaylarsu, some icons are still available though...09:51
nic-doffayeg "search" is available.09:52
larsudednick: I'm doing a clean rebuild now, maybe I messed something up. Will push after that09:52
nic-doffaylarsu, any idea who to talk to about this?09:54
larsunic-doffay: I'm afraid that would be me09:54
larsuI'll be looking into this after I fixed that issue for dednick09:54
nic-doffaylarsu, cool :P09:56
mzanettinic-doffay: was in a meeting...10:00
nic-doffaymzanetti, no worries10:00
mzanettinic-doffay: well... what does dpkg -L ubuntu-mobile-icons give you?10:00
nic-doffaymzanetti, that's the thing a lot of icons.10:00
nic-doffaymzanetti, majority of those work.10:02
nic-doffayfilters didn't though.10:02
nic-doffay(ive tried skype and other random picks before)10:02
mzanettinic-doffay: and is the "filter" icon listed in there?10:02
nic-doffaymzanetti, it's not.10:03
mzanettidednick: way better :)10:03
nic-doffayBut I was wondering how you got it?10:03
larsudednick: I pushed it to lp:~/qmenumodel/use-full-action-name.10:03
mzanettinic-doffay: apt-cache policy ubuntu-mobile-icon10:03
mzanettinic-doffay: apt-cache policy ubuntu-mobile-icons10:03
dednicklarsu: ta10:03
nic-doffaymzanetti, mine's 13.04+13.10.20130812-0ubuntu110:04
larsudednick: there might be some bugs in there still, I can 't test it because I'm getting that qml error:10:04
dednickmzanetti: you mean the checkbox?10:04
larsufile:///home/lars/src/unity8/unitymenumodel.messages/builddir/plugins/Unity/Indicators/Messaging/MessageMenuItemFactory.qml:136: TypeError: Cannot read property 'valid' of null10:04
dednicklarsu: ok10:04
mzanettidednick: yes :)10:04
mzanettinic-doffay: please paste both, the complete output of "apt-cache policy ubuntu-mobile-icons" and "dpkg -L ubuntu-mobile-icons"10:06
mzanettinic-doffay: and your code where you try to use the Icon with the filter icon10:06
nic-doffaymzanetti, the code is simple10:06
nic-doffayI just reference use the icon name.10:06
nic-doffayWithout the type suffix.10:06
nic-doffayThat works for the other icons in that package.10:07
mzanettinic-doffay: I know its simple. yet you must have a mistake somewhere.... otherwise it would work10:07
larsunic-doffay: what are the exact icons uris you are using?10:07
mzanettilarsu: the Icon {} component has some magic... it has a property "name" which refers to an icon name, withouth e.g. image:// and file type extension10:08
nic-doffaymzanetti, here's everything. https://pastebin.canonical.com/96734/10:09
larsumzanetti: I know, but it seems to be doing the right thing afaics10:09
nic-doffaymzanetti, filter is there.10:09
mzanettinic-doffay: what happens if you remove the color property?10:10
nic-doffaymzanetti, nothing.10:10
mzanettibut I've changed the code here to be exactly this. and it works10:11
nic-doffaymzanetti, changed it to exactly what?10:13
larsunic-doffay: QIcon::fromTheme() returns an empty icon for "filter"10:14
mzanettinic-doffay: http://paste.kde.org/p8a71429e10:14
larsunic-doffay: so it's not a problem with your code at all10:14
nic-doffaylarsu, yeah as I suspected.10:15
nic-doffayBut what differs between myself and mzanetti's setup?10:15
nic-doffayThis is what I'd like to find out.10:15
nic-doffaylarsu, I mean the filters icon is clearly visible after dpkg -L ubuntu-mobile-icons10:16
nic-doffayAnd I've used other icons there as a test.10:16
larsunic-doffay: are you on the desktop or on the phone? Most likely, the theme name is wrong.10:16
larsuya, it works if I set the theme name manually10:17
larsuunity8 should set this if the platform abstraction thingy doesn't10:18
larsudednick: are you seeing the same error?10:18
dednicklarsu: nope10:18
dednickjust testing on phone now10:19
larsudednick: hm. Any idea why I could be running into that? It makes it really hard to test :) (and there's no other error about not being able to load the UnityMenuAction type)10:19
dednicklarsu: you maybe left the UnityMenuActions as getAction in the messaging menu factor10:19
nic-doffaylarsu, currently off the desktop.10:19
larsudednick: no, I triple-checked and rebuilt the whole thing from scratch10:20
larsunic-doffay: there's your problem, then :)10:20
dednicklarsu: revert changes to unity8 and apply http://pastebin.ubuntu.com/6058425/10:21
larsunic-doffay: changing your icon theme won't work though, because unity8 doesn't pick it up10:21
dednicklarsu: then ./build && ./run from source10:21
dednicks/source/source dir10:21
larsunic-doffay: basically, someone needs to call QIcon::setThemeName("ubuntu-mobile") at some point10:22
larsudednick: ya, this is what I have as well10:22
dednicklarsu: hm.10:22
larsudednick: does sending replies work for you now?10:24
dednicklarsu: not sure how to test that without phone. which i'm still updating at the moment.10:25
dednicklarsu: it's getting through to the muxer at least.10:25
larsudednick: and you're not getting those error messages? /me is thoroughly confused10:26
dednicklarsu: but the UnityAction.isValid doesnt seem to be working.10:26
greybackmzanetti: hey, I need your opinion. In shell, I want to use QSortFilterProxyModel to filter the running applications list to get list of running sidestage apps. If I want to focus one of those side-stage apps, right now I need its Application pointer.10:26
greybackmzanetti: To get that I need to use get(i) where i is the index in the original model, not the filtered model. But I don't think we've implemented anything like the mapToSource() method on AbstractProxyModel10:27
greybackmzanetti: Or I could change the api in unity-apis, so that focus uses the appId, not the Application pointer10:28
greybackmzanetti: or I could add a role to the model which returns the Application pointer10:28
larsudednick: oh, so the UnityMenuAction _is_ being created, but the replyAction property is still null10:28
nic-doffaymzanetti, can you clarify one of you review comments for me?10:29
mzanettigreyback: roles that return pointers might be problematic10:30
greybackmzanetti: yeah, it's my least favourite option10:30
dednicklarsu: i think your fullActionName may be acting up. the toUtf8() is returning a QByteArray, which i think is being destroyed after the call to constData(), so the mem is no longer valid.10:30
mzanettigreyback: changing all api's to use appId except having a get(appId) to get the appInfo pointer sounds ok...10:30
larsudednick: ugh, very good point10:31
mzanettigreyback: while I once did expose something like mapToSource() in another project and it still works fine, I think it's not very nice10:31
nic-doffaymzanetti, with this comment: * the animation feels weird. It covers everything except the searchfield. Please check with design.10:31
mzanettinic-doffay: yeah...10:31
larsudednick: but that shouldn't lead to that error, should it?10:31
greybackmzanetti: I wasn't looking forward to trying it, I'll admit that :)10:31
nic-doffayDo you mean it's strange that the animation affects everything but the search bar?10:31
dednickno10:31
mzanettinic-doffay: there is this thing coming down fro the top.. it goes below the textfield but above everything else10:31
mzanettinic-doffay: feels/looks really weird imho10:32
dednickcan you pastebin your unity8 source diff?10:32
greybackmzanetti: appId it is. Thanks10:32
nic-doffaymzanetti, right gotcha.10:32
nic-doffayHaving a chat about it now.10:32
dednicklarsu: ^10:32
larsudednick: it's exactly what you pastebinned earlier10:32
larsudednick: the UnityMenuAction constructor is called, but none of the setters. Something must delete the object during construction...10:40
dednicklarsu: any other errors?10:40
larsudednick: a bazillion warnings about icons and the hud, but nothing about this10:41
dednicklarsu: my line 136 is "appIcon: menu && menu.ext.xCanonic..."10:41
larsudednick: because of your patch. It's line 139 now10:42
larsudednick: I get these errors for every occurence of replyAction10:43
dednicklarsu: try putting a Component.onCompleted with log message in the replyAction10:45
larsudednick: already did, doesn't get called10:45
dednicklarsu: bleh. hmm. ok, try just creating a QMenuMode.UnityMenuAction in the Factory root item. maybe it will log out an error if you create like that10:46
dednicklarsu: not using a property i mean10:46
larsudednick: ah, good idea10:46
dednicklarsu: but i really dont get why it's working on mine :/10:46
greybackmzanetti: http://pastebin.ubuntu.com/6058490/ is what will suit me. What do you think of line 30-31 of the diff, would that make sense? It would remove idea of model index entirely, so appId is the only unique identifier10:49
dednicklarsu: reply works on device now10:50
larsudednick: MessageMenuItemFactory.qml:35:5: Cannot assign object to list10:50
larsudednick: when try to just add a UnityMenuAction directly10:51
larsuthis is beyond weird10:51
dednicklarsu: yeah, sorry, put it in the loader10:51
greybackas aside, this is interesting article on working around carriers not pushing OS updates: http://arstechnica.com/gadgets/2013/09/balky-carriers-and-slow-oems-step-aside-google-is-defragging-android/10:51
larsudednick: ah, default property magic?10:51
dednicklarsu: there's some dodgeyness going on in the sdk listview items where you cant child qobjects10:51
dednicklarsu: yep10:52
larsudednick: no additional error :(10:53
dednickno onCompleted log?10:54
dednicklarsu: is the destructor being called?10:54
dednickreally strange10:55
mzanettigreyback: +1 on lines 30-3110:55
greybackmzanetti: ta. MR on it's way10:56
mzanettigreyback: you sure its a good idea to remove the return value from startApplication?10:56
larsudednick: onCompleted is called, the destructor is not called10:56
mzanettigreyback: might make sense to retain a bool?10:56
dednicklarsu: try reinstalling archive qmenumodel and see if it complains about the index property10:56
greybackmzanetti: oops, that should keep a bool yes10:57
mzanettigreyback: rest looks quite good I'd say10:57
larsudednick: it does10:58
dednicklarsu: does it call onCompleted? or say it cant create the UnityMenuAction?10:59
dednicklarsu: nevermind. just tried myself. doesnt create11:00
larsudednick: right, it doesn't even have the messagemenuitemfactory type now11:00
larsuI guess it treats the non-existent property like a syntax error11:01
dednicklarsu: yeah11:01
dednicklarsu: when you added to the factory, did you create an empty one UnityMenuAction {}, or with properties?11:02
larsudednick: with properties, I copied the one from the replyAction11:03
dednicklarsu: sigh. i dunno wtf is going on...11:03
dednicklarsu: is it not complaining about the replyAction in TextMessage? line 100?11:05
larsudednick: yes it is. It complains about all occurrences of UnityMenuAction11:06
dednickah11:06
larsuI'm building without the patch now, lets see if that still works11:06
larsudednick: anyway, I'm hungry. You said it does work for you now, right?11:16
dednicklarsu: yeah11:17
larsudednick: okay, going to lunch then :)11:18
larsudednick: I just pushed a fix for the fullActionName thing11:18
dednicklarsu: ta.11:22
=== hikiko is now known as hikiko|lunch
dednicklarsu: right, so i approved in terms of a review, but i'm hesitent to do global until we get it working for you :(12:01
=== alan_g is now known as alan_g|lunch
dednicklarsu: you on qt5.0 or 5.1?12:03
=== dednick is now known as dednick|lunch
larsudednick|lunch: 5.0.212:14
mzanettiseb128: hey, did the settings override for the launcher already land in the image?12:19
seb128mzanetti, http://people.canonical.com/~ogra/touch-image-stats/20130903.changes12:19
seb128mzanetti, it did!12:19
seb128mzanetti, thanks to ogra ;-)12:19
mzanetti\o/12:19
mzanettithanks you two12:19
greybackmzanetti: https://code.launchpad.net/~gerboland/unity-api/adjust-application-api/+merge/18364112:21
greybacklemme know what you think12:21
mzanettigreyback: I'd need a review when you have some time. albert already did a first round and I've fixed his comments: https://code.launchpad.net/~mzanetti/unity8/launcher-defaults-from-dconf/+merge/18342012:21
greybackmzanetti: ok, looking now12:21
mzanettiyep, will check out yours12:21
=== hikiko|lunch is now known as hikiko
larsumzanetti: seb128 advises to call QIcon::setThemeName("ubuntu-mobile") in unity8 until bug #1098578 is fixed12:25
ubot5bug 1098578 in Ubuntu UI Toolkit "On Ubuntu Desktop, the icon theme used by Qt is always 'gnome' (instead of the user set one)" [High,Confirmed] https://launchpad.net/bugs/109857812:25
larsumzanetti: who'd be the right guy to ask where to put that?12:25
seb128larsu, mzanetti: system-settings does "QIcon::setThemeName("ubuntu-mobile");"12:25
seb128that works fine on touch and desktop (when the theme is installed, we depends on it)12:25
mzanettilarsu: I am until saviq is back... yeah.12:26
mzanettilarsu: probably just dump it in the main.cpp where we set up all the other import paths12:26
larsumzanetti: sounds reasonable. I'll put up a MR right away12:27
mzanettilarsu: just found this code in unity8:12:27
mzanettivoid resolveIconTheme() {12:27
mzanetti    const char *ubuntuIconTheme = getenv("UBUNTU_ICON_THEME");12:27
mzanetti    if (ubuntuIconTheme != NULL) {12:27
mzanetti        QIcon::setThemeName(ubuntuIconTheme);12:27
mzanetti    }12:27
mzanetti}12:27
larsuugh, that's ... ugly12:27
mzanettilarsu: I guess I know why this is12:28
mzanettilarsu: there was a time when we were transitioning between ubuntu-mobile-icons and ubuntu-icons-touch (or something like that)12:28
seb128that makes testing with a different theme easy though12:28
mzanettiprobably it was added to suite that12:29
seb128you might want to do that and have an else case setting the default theme12:29
mzanetti+1 ^^12:29
larsuokay, fair enough12:29
greybackmzanetti: you don't like the C++11 for iterator? "for" -> "Q_FOREACH" :)12:30
davmor2guys in saucy if I click on the power button the system shutsdown even if the system is in sleep mode I'm guessing at that being a bad thing,  to reproduce let your machine lock hit the power button watch it shutdown with no prompt12:31
mzanettigreyback: Q_FOREACH knows better how to deal with QHash and QMap12:31
mzanettigreyback: other than that it's probably the same.12:31
greybackmzanetti: really? huh12:31
mzanettigreyback: yeah.. for example Q_FOREACH(const QVariant &value, m_myHash) directly iterates over the values12:32
mzanettigreyback: whereas c++11 would need for(const QVariant &value, m_myHash.values()) which needs to create a copy of the values list first12:32
greybackmzanetti: ah of course yes12:32
mzanettigreyback: not really sure if that applies to all my usages... but then its only because I'm used to Q_FOREACH12:33
mzanettigreyback: I do hate the overuse of "auto" tho12:33
mzanettiwhich that merge gets rid of too12:34
greybackmzanetti: I'm fond of it, if the object type is obvious12:34
larsuI just found out why unity8 takes 10 seconds to load on my desktop and I started crying: `cat /usr/lib/x86_64-linux-gnu/hud/dbus-activation-hack.sh?12:34
mzanettigreyback: auto variant = m_accounts->getUserProperty(m_user, "launcher-items");12:35
mzanettigreyback: what is it?12:35
greybackmzanetti: yeah, not obvious there at all. But there are times, like in an iterator, where it doesn't cause any harm12:36
mzanettiyeah... but once you have a file which _only_ uses auto you get upset and remove them all :D12:36
greybackhttp://blog.qt.digia.com/blog/2013/09/02/new-scene-graph-renderer/ new renderer looks very interesting, I sense the fact there's much GPU retention will help shell and some app performance greatly12:41
larsumzanetti, seb128: https://code.launchpad.net/~larsu/unity8/fallback-icon-theme/+merge/18364912:43
seb128larsu, why do you Build-Depends on it? is that used in tests?12:44
seb128larsu, or did you mean to Depends: rather?12:44
larsuseb128: this is why I pinged you. I don't think before I push!12:45
seb128lol12:45
seb128larsu, you can also make it a Recommends: since that's not strictly required12:45
larsuseb128: okay :)12:45
seb128larsu, danke12:46
larsuseb128: done12:46
seb128larsu, done, set as approved (but comment only, I'm not an unity8 maintainer and I don't feel like approving their MRs)12:47
larsuya that makes sense12:48
larsumerci!12:48
dandraderdednick|lunch, FYI: taking over the review of https://code.launchpad.net/~nick-dedekind/unity8/indicator.multi-icon/+merge/181862 from Albert as he's on holidays13:00
=== alan_g|lunch is now known as alan_g
greybackapt-get update: "Fetched 17.8 MB in 4993d 10h 9min 6s (0 B/s)" lol13:23
mhall119hey guys, any chance of https://bugs.launchpad.net/unity8/+bug/1214428 getting fixed soonish?  It's causing problems with click app installation13:30
ubot5Launchpad bug 1214428 in Unity 8 "Apps with capital letters in their .desktop file name won't launch" [Undecided,New]13:30
mzanettidednick|lunch: standup13:30
mzanettikgunn: fyi: standup time in case you wanna join13:32
greybacksorry about the background noise13:36
=== dednick|lunch is now known as dednick
dednickdandrader: cool. thanks13:39
larsumzanetti: getenv is deprecated?! That's news to me...13:49
mzanettilarsu: oh... my mistake13:50
mzanettilarsu: it was only deprecated in VCS200513:50
mzanettiwhich we probably don't really care about13:50
larsumzanetti: ah, right, just read that in the docs as well :)13:50
larsumzanetti: I don't care, if you prefer qgetenv I can fix it13:50
larsuI had already moved unity-mobile-icons to Recommends13:51
mhall119mzanetti: any feedback from katie on the wording for the tour's final step/13:52
mhall119?13:52
mzanettimhall119: yes:13:53
mzanettimhall119: go for 3 lines, but no link13:53
mzanettimhall119: unity_tour_threelines.png but removing the "Skip intro" link completely13:54
mhall119ok, can I modify EdgeDemoOverlay.qml to add an alias to the link's visibility?13:54
kgunndednick: curious...did saviq talk to you about possibly picking up snap decisions while macslow is out ?13:58
dednickkgunn: nope13:58
kgunndednick: mzanetti & i were just chattting about first time boot/sim card pin entry which would need snap decisions13:58
kgunndednick:  awesome... :)13:59
dednickkgunn: is that a "awesome, thanks for picking it up"? :)13:59
dednickas in "now you know"14:00
kgunndednick: awesome as in i dropped the ball14:00
kgunndednick: so...now that you do know...mind taking a look this afternoon just to get a feel for it, if you think you might be able to effect it ?14:01
kgunnguess you'd have to branch off macslows...14:01
dednickkgunn: sure14:01
mzanettidednick: ping me when you want to get started. I can explain what the plan is14:02
dednickthis is in relation to the ext snap dialogs right?14:02
kgunndednick: i trust your judgement...if you think its best to just wait till monday for macslow to return, lemme know14:02
kgunndednick: thank you14:04
kgunndednick: and to be totally clear....yeah, ext snap dialogs14:05
kgunndednick_: also if you can make progress on ext snap dialog...just as a but of freedom/guidance for you it's better to have something landed than perfection14:23
kgunnfwiw14:23
=== dandrader is now known as dandrader|afk
nic-doffayCimi, got time for a quick review?14:43
nic-doffaydednick_, fancy a one line review?14:51
=== dandrader|afk is now known as dandrader
dednick_nic-doffay: can do14:52
sil2100pete-woods: hi!14:53
pete-woodssil2100: hi14:53
nic-doffaydednick_, https://code.launchpad.net/~nicolas-doffay/unity8/infographic-background-change/+merge/18367514:53
nic-doffayShould be easy to test too.14:53
sil2100pete-woods: did you get an e-mail from Robert about lp:ubuntu-voice?14:53
sil2100pete-woods: I mean, unity-voice14:53
sil2100pete-woods: since he outlined some problems with the symbols file and autopilot tests14:54
pete-woodssil2100: I did a could of days ago, yes - I thought I had fixed everything he asked about14:54
dednick_that's 19 lines...14:55
dednick_larsu: you ever get that action working?14:56
larsudednick_: no, was distracted (and will be for the next hour as well, meeting)14:57
dednick_larsu: ok14:57
larsudednick_: maybe I can try to do it on the side if the meeting is boring :P14:57
dednick_:)14:58
sil2100pete-woods: oh, let me re-check then - thanks!14:58
pete-woods:)14:59
dednick_nic-doffay: did design give you that asset?15:01
nic-doffaydednick_, yeah15:07
dednick_nic-doffay: approved15:08
nic-doffaydednick_, ta15:12
larsumzanetti: hm the merge failed because of some tests that seem unrelated. Can you please have a look what the problem there might be?15:20
mzanettilarsu: yeah... I need to walk through the whole list of merges today anyways15:32
larsumzanetti: cool, thanks15:33
greybackmzanetti: if you have minute: https://code.launchpad.net/~gerboland/unity-api/adjust-application-api/+merge/18364115:40
=== om26er is now known as om26e
=== om26e is now known as om26er
greybackmzanetti: thank you15:49
dednickpete-woods: ping15:51
pete-woodsdednick: hi15:54
mhall119mzanetti: updated branch and screenshot on https://code.launchpad.net/~mhall119/unity8/finish-tour/+merge/18303715:55
dednickpete-woods: hey. were you working on pinlock with MacSlow?15:56
pete-woodsdednick: not pinlock - it's the wifi auto dialogue API I'm waiting on from MacSlow15:56
pete-woods*auto -> auth15:57
dednickpete-woods: i c15:57
dednickpete-woods: thanks, maybe tedg knows15:57
dednicktedg: ^15:57
mzanettimhall119: it's approved already15:58
tedgdednick, I think that'll be me when it gets done, but I don't know that MacSlow knows that yet.15:58
mzanettimhall119: err... I think I forgot to actually send the approval :D15:58
mhall119mzanetti: not according ot LP15:58
mzanettiwill do now15:58
mhall119:P15:58
pete-woodsdednick: np15:59
dednicktedg: ok. cool15:59
tedggreyback, Do I just need the Mir PPA to get your version of Unity on my phone, or is there something else I should do?16:01
greybacktedg: just that ppa, update, dist-upgrade and reboot16:02
* tedg jumps16:02
mhall119mzanetti: any idea why Jenkins is failing now, but wasn't previously, and on something that seems unrelated?16:05
mhall119https://code.launchpad.net/~mhall119/unity8/finish-tour/+merge/18303716:05
mhall119sorry: https://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/1461/?16:05
mzanettimhall119: yeah. the SDK released an update of the ToolBar and we weren't prepared for it16:06
mhall119ok, so it's not my branch that broke it16:08
larsudednick: this issue is like magic. Run unity8 it works (none of the weird errors). Apply your patch and run it, weird errors happen. Revert it, errors *still* happen. I want to cry.16:10
dednicklarsu: you havent got some weird import path variables set up have you?16:11
larsuno....16:11
dednickand you're building every time you make a source change to unity? you're not editing build files again are you?!16:12
dednick:) i have no idea16:12
larsunope, rebuilding every time16:12
larsuI think its just my setup16:12
larsualso: I need to go now16:12
dednicklarsu: i'll get someone else to test tomorrow. if it works, we will approve16:13
larsudednick: okay cool thanks. Have a good evening16:13
dednickyou too16:13
mzanettigreyback: unity-api merged btw.16:15
greybackmzanetti: yay!16:15
mzanettigreyback: is there already some branch I could start working on top of?16:16
kgunngreyback: you were saying you needed review on unity-mir before landing...? do you have a victim ?16:16
mzanetti29 branches to be reviewed... Saviq will kill us when he's back :D16:17
greybackkgunn: Almost: I need reviewer for unity8 stuff. I got a preliminary review from Saviq, who had no major problems16:17
greybackkgunn: and the bits I'm doing, and bits dandrader is doing. We'll review each-other's stuff there probably16:17
greybackkgunn: so I think I'll steal dandrader for a while longer16:18
nic-doffaymzanetti, you got a moment?16:22
mzanettinic-doffay: yeah16:22
nic-doffaymzanetti, I need to pass the size of the whole qmlscene of unity to the PageHeader, any idea what the easiest way to do that is?16:23
nic-doffayI can't just use narrowMode for this...16:23
nic-doffayThe size of the filters tab needs to be worked out based on the total height.16:23
mzanettinic-doffay: what for?16:24
mzanettinic-doffay: wait. need to check your code16:24
mzanettinic-doffay: you mean the height of the filterSelector Rectangle?16:25
nic-doffayYeah.16:25
nic-doffayI think that needs to be based off the total height.16:26
nic-doffayOr at least the amount of space for the MouseArea below to get rid of it.16:26
mzanettinic-doffay: for that use the InverseMouseArea16:27
nic-doffaymzanetti, ^5 for that.16:32
mzanettinic-doffay: 5?16:32
nic-doffaymzanetti, high five ;P16:32
mzanettiah :)16:32
=== dandrader is now known as dandrader|lunch
nic-doffaymzanetti, thanks for that screen16:36
nic-doffayI noticed the filter button is already there?16:36
nic-doffayin the search bar in addition to the one I added?16:36
mzanettinic-doffay: I was just playing around while doing the review16:36
mzanettiso it's only hacked in in a local branch here16:37
nic-doffaymzanetti, ah ok.16:37
nic-doffayI was worried because I didn't see anything in the code anywhere.16:37
mzanettinic-doffay: so... have asked martin16:37
nic-doffaymzanetti, are you setting your theme manually?16:37
nic-doffayStill need to get to the bottom of why mine isn't displaying.16:37
mzanettithe overlay should be relative to the screen height, keeping 8 grid units distance from the bottom16:37
nic-doffaymzanetti, right so we'll need to pass the total height.16:37
mzanettinic-doffay: hmm... I have set up KDE to use the ubuntu-mobile-icons theme16:38
mzanettinic-doffay: so I probably get it as default. but larsu fixed it for you. once his branch has landed, you can merge with trunk and you'll se the icons16:38
nic-doffaymzanetti, ah brilliant.16:39
nic-doffaylarsu, cheers16:39
nic-doffaymzanetti, where would be the best place to pass the height into the PageHeader from?16:39
mzanettinic-doffay: for now you can do this  to get it:16:39
mzanettiexport UBUNTU_ICON_THEME="ubuntu-mobile"16:39
mzanettibefore doing the ./run and the icons should show up16:40
mzanettinic-doffay: let me check the code for the height thingie16:40
nic-doffaymzanetti, I'm assuming the individual selectors will be a fraction of the filter rectangle's height, but I'm double checking.16:40
mzanettinic-doffay: ok. have found the height thing16:54
mzanettinic-doffay: you have a moment so I can give you some instructions how to fix stuff?16:54
nic-doffaymzanetti, yeah16:58
mzanettinic-doffay: ok. so... from what I can see the narrowMode change is on16:59
mzanettinic-doffay: ok. so... from what I can see the narrowMode change is only because you added the Icon, right?16:59
mzanettinic-doffay: so I'd suggest you revert line 37 + 38 of the diff to where it was before.17:00
mzanettinic-doffay: then remove your added icon17:00
nic-doffaymzanetti, I've added my icon into the search bar instead.17:00
mzanettinic-doffay: and add the icon back inside the TextField as secondaryItem.17:01
mzanettiyeah exactly17:01
nic-doffaymzanetti, yeah done that bit.17:01
mzanettiits still not 100% matching the design, but at least it looks good enough for now.17:01
nic-doffaymzanetti, yeah agreed.17:01
mzanettiand especially, it looks like the other search/filter labels17:01
nic-doffayThere still needs a black bar and some other additions.17:01
mzanettiexactly. but we won't do that in here. for that we'll create a ModifiedTextField.qml and use that one here... in another merge request tho17:02
mzanettiso. next thing is the height of that overlay. I asked martin. it should be screenHeight - units.gu(8)17:02
mzanettifor that, add a property filtersHeight (or similar) to the PageHeader.17:03
mzanettiand in the Dash*.qml, where the pageHeader is used, set it to the appropriate height17:03
mzanettinic-doffay: anything else you need more information?17:05
nic-doffaymzanetti, where's that height stored originally thought?17:06
nic-doffayI'd like to pass it into DashContent preferably and then on to the pageHeader.17:06
mzanettinic-doffay: for example: the PageHeader is used in Dash/DashContent.qml17:08
mzanettinic-doffay: I think that ScopeView is fullscreen. so just pass scopeView.height - units.gu(8) to the PageHeader in that file17:08
nic-doffaymzanetti, perfect cheers17:18
dednickdandrader|lunch: fixed those issues in indicator.multi_icon17:19
mhall119mzanetti: will I need to merge from trunk and push a new revision of my branch, or should jenkins just start being happy with mine once trunk is fixed?17:23
mzanettimhall119: I don't think you will need to merge.17:24
mhall119ok, thanks17:24
* mhall119 is unreasonably happy about contributing a fix to Unity :)17:24
=== racarr is now known as racarr|lunch
mterryIs anyone else working on upgrading unity8 from icon://gicon/name to icon://theme/name?  I can do that if not18:18
tvoss_mzanetti, ping19:06
mzanettitvoss_: hi19:06
=== racarr|lunch is now known as racarr
=== dandrader|lunch is now known as dandrader
=== dandrader is now known as dandrader|afk
=== dandrader|afk is now known as dandrader
=== dandrader is now known as dandrader|afk
=== dandrader|afk is now known as dandrader
=== sergiuse1s is now known as sergiusens

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!