[04:56] <pitti> Good morning
[06:22] <DanChapman> morning all
[06:22] <elfy> morning DanChapman
[06:48] <jibel> Good morning
[07:08] <pitti> jibel: let's move here, all public stuff
[07:09] <pitti> jibel: so the task is to run dbus + gnome-session + firefox under xvfb in run-adt-test -sl?
[07:09] <jibel> pitti, yes
[07:09] <pitti> jibel: my g-s-d tests are the absolutely bare minimum, we can probably do that in a bit simpler way
[07:09] <jibel> pitti, the current code is in firefox source package
[07:11] <jibel> in debian/testing/testrunhelper.py
[07:12] <jibel> it creates a dummy session, in /tmp/tmp.XXXX/home, then launches gnome-session via xvfb-run and dbus-launch with this session
[07:13] <jibel> this helper is called from dep8 test script with: /usr/bin/python /usr/lib/firefox/testing/run_xpcshell_tests --own-session --xunit-file /var/tmp/testresults/xpcshell-tests.xml --xunit-suite-name xpcshell --manifest xp --verbose
[07:14] <pitti> jibel: oh, we got gnome-session 3.9.90 now; I wonder if that's it, last time I actively tried it was with 3.6
[07:14] <jibel> yes, it could be
[07:14] <jibel> pitti, the current test fails with http://paste.ubuntu.com/6061661/
[07:15] <jibel> pitti, it could be because this very test works fine on raring
[07:15] <pitti> meh, in my days firefox used to be 10 MB packed; it got ridiculously bloated
[07:15] <jibel> agreed
[07:15] <pitti> jibel: ack, I get the same in VM
[07:15] <jibel> pitti, there is a VM running in the lab if you wish
[07:16] <pitti> jibel: run-adt-test should be fine
[07:17] <jibel> pitti, outside of qemu, this test also works
[07:21] <pitti> hm, I have a gut feeling that the accel stuff is a red herring
[07:21] <pitti> jibel: give me some time with this, I'll investigate more deeply
[07:31] <pitti> jibel: oh, je crois que je sais pourquoi -- il a besoin d'un session de logind
[07:42] <pitti> jibel: ok, it is the accelerated stuff after all
[07:42] <pitti> sudo mv /usr/lib/gnome-session/gnome-session-check-accelerated{,.orig}
[07:42] <pitti> sudo ln -s /bin/true /usr/lib/gnome-session/gnome-session-check-accelerated
[07:42] <pitti> -> with that it works
[07:45] <pitti> jibel: so if we want gnome-session to work on 2D, we need to patch this away:
[07:46] <jibel> pitti, it should make no difference if xvfb-run is run locally or in qemu, in both cases it is unaccelerated?
[07:46] <pitti>         if (gl_failed) {
[07:46] <pitti>                 gsm_fail_whale_dialog_we_failed (FALSE, TRUE, NULL);
[07:46] <pitti> or make software accell work in xvfb somehow
[07:46] <pitti> right
[07:47] <jibel> pitti, so, why gnome-session-check-accelerated detects llvmpipe when executed locally and nothing in qemu
[07:47] <jibel> ?
[07:47] <jibel> is there something special to enable llvmpipe
[07:47] <pitti> jibel: oh, you mean xvfb-run gnome-session works for you locally?
[07:47] <jibel> pitti, yes
[07:48] <pitti> $ xvfb-run /usr//lib/gnome-session/gnome-session-check-accelerated
[07:48] <pitti> gnome-session-is-accelerated: No composite extension.
[07:48] <pitti> gnome-session-check-accelerated: Helper exited with code 256
[07:48] <pitti> not here
[07:48] <jibel> hm, let me try again
[07:50] <jibel> pitti, xvfb-run -a -s "-screen 0 1280x1024x24 -extension MIT-SCREEN-SAVER" dbus-launch --exit-with-session gnome-session --debug
[07:50] <jibel> $ xvfb-run -a -s "-screen 0 1280x1024x24 -extension MIT-SCREEN-SAVER" dbus-launch --exit-with-session /usr//lib/gnome-session/gnome-session-check-accelerated
[07:50] <jibel> gnome-session-is-accelerated: llvmpipe detected.
[07:51] <pitti> smells like some missing dependencies then
[07:52] <jibel> ah, it fails if I don't specify a screen
[07:52] <pitti> ah, nice!
[07:52] <pitti> that works in VM, too
[07:53] <pitti> LIBGL_ALWAYS_SOFTWARE=1 xvfb-run  -a -s "-screen 0 1280x1024x24 -extension MIT-SCREEN-SAVER" /usr//lib/gnome-session/gnome-session-check-accelerated
[07:53] <pitti> ** (process:21453): DEBUG: Command-line parsed to -1
[07:53] <pitti> gnome-session-is-accelerated: llvmpipe detected.
[07:54] <pitti> jibel: so that's it apparently
[07:59] <jibel> it makes no difference to me in a VM
[07:59] <jibel> $ LIBGL_ALWAYS_SOFTWARE=1 xvfb-run  -a -s "-screen 0 1280x1024x24 -extension MIT-SCREEN-SAVER" /usr//lib/gnome-session/gnome-session-check-accelerated
[07:59] <jibel> gnome-session-is-accelerated: No hardware 3D support.
[07:59] <jibel> gnome-session-check-accelerated: Helper exited with code 256
[08:02] <jibel> i'm trying with qemu on saucy, if it makes a differnece
[08:03] <pitti> yeah, I tried the same
[08:06] <jibel> pitti, sudo apt-get install libgl1-mesa-dri
[08:07] <pitti> not heresudo apt-get install xvfb dbus-x11 gnome-session-bin"
[08:07] <pitti> ouch, weechat, WTF?
[08:08] <pitti> jibel: I meant to say, that already gets pulled in by sudo apt-get install xvfb dbus-x11 gnome-session-bin
[08:08] <jibel> interesting, it was not in the VM created in the lab
[08:24] <jibel> pitti, libgl1-mesa-dri is a recommends of xvfb but pbuilder-satisfydepends-classic installs packages with  APTFLAG="-o APT::Install-Recommends=false"
[08:29] <jibel> pitti, chrisccoulson \o/ finally I got firefox tests running on saucy
[08:29] <chrisccoulson> jibel, excellent, thanks. what did you need to do?
[08:29] <jibel> (at least xpcshell testsuite is running)
[08:31] <jibel> chrisccoulson, gnome-session refuses to start if there is no 3D acceleration on Saucy, and it doesn't detect llvmpipe because libgl1-mesa-dri is not installed. It is a recommends of xvfb but recommends are not installed by default.
[08:31] <chrisccoulson> jibel, ah, excellent :)
[08:32] <chrisccoulson> jibel, should i add that dependency to firefox-testsuite?
[08:32] <chrisccoulson> or do you want to add it elsewhere?
[08:32] <jibel> chrisccoulson, I'll let it finish on my machine, and will reproduce in the lab to confirm
[08:32] <chrisccoulson> thanks
[08:33] <jibel> chrisccoulson, in the dependency list of dep8 control file like xvfb would be the ight place
[08:33] <jibel> right
[11:24] <knome> balloons, ping
[12:23] <balloons> knome, pong
[12:24] <elfy> game, set, match
[12:24] <DanChapman> :-D
[12:24] <knome> balloons, do you know anything about the oem installer and if it is supposed to work on flavors?
[12:25] <smartboyhw> balloons, where is your email:P (And up so early?)
[12:25] <smartboyhw> elfy, um, this is NOT Rafael Nadal vs. Novak Djokovic -.-
[12:25] <balloons> knome, good question, I can't say I ever did an oem install of a flavor
[12:25] <knome> no, this is andy roddick vs jarkko nieminen
[12:26] <elfy> who? never heard of them - what's their nicks on irc?
[12:26] <knome> balloons, i can tell you it isn't working ;)
[12:27] <smartboyhw> elfy, tennis players-.-
[12:27] <smartboyhw> knome, Andy Roddick retired, isn
[12:27] <smartboyhw> 't he?
[12:28]  * smartboyhw thinks elfy should catch up on Sports News
[12:29] <balloons> knome, I wouldn't persay expect it to work..
[12:29] <smartboyhw> balloons, but it is included in some testsuites for flavours
[12:30] <elfy> while balloons and knome are both here - what's the current state of play in getting rid of the archive state of some of our package testcases - are we still waiting for stgraber ?
[12:32] <smartboyhw> Jeez, that's why I hate doing upgrade testcases, have to zsync and install the 13.04 image, then wait for the long package upgrade to 13.10 process in VBox-.-
[12:32] <knome> got to go
[12:32] <knome> see you later
[12:33] <balloons> smartboyhw, knome well we can certainly drop oem, but we should talk about it a bit more first
[12:33] <balloons> elfy, what do you mean?
[12:33] <smartboyhw> balloons, maybe you can answer my first question "where is your email";P
[12:33] <smartboyhw> (about promo, that is)
[12:34] <DanChapman> balloons: could i get some time with you some point today. could do with your opinion/help/review on the gtk emulators.
[12:34]  * smartboyhw thinks balloons is in highly-wanted status today-.-
[12:34] <elfy> balloons: still getting this -> http://packages.qa.ubuntu.com/qatracker/milestones/300/builds/50384/testcases/1586/results
[12:34] <elfy> because there are dupes I believe - which we can't get rid of
[12:35] <elfy> back to work now - back in a few hours
[12:35] <DanChapman> have fun elfy :-)
[12:35] <balloons> ohh nice elfy
[12:35] <smartboyhw> DanChapman, if you can, do test some Beta 1 images;P
[12:36] <balloons> well, stgraber would have to help you out there, but we'll need to frame the specific request
[12:37] <smartboyhw> balloons, are you ignoring me? :(
[12:39] <balloons> DanChapman, this. https://code.launchpad.net/~dpniel/ubuntu-autopilot-tests/using_gtk_emulators?
[12:40] <DanChapman> balloons: lp:autopilot-gtk-emulators is the source but yeah https://code.launchpad.net/~dpniel/ubuntu-autopilot-tests/using_gtk_emulators aswell as I converted them to using it so you can see how it works
[12:41] <DanChapman> balloons: https://code.launchpad.net/~dpniel/autopilot-gtk-emulator/trunk
[12:41] <balloons> I see
[12:41] <balloons> smartboyhw, no, I see you asking for an email.. it's a work item for the next several months, remember
[12:42] <smartboyhw> balloons, next several months?:P
[12:42] <balloons> yes, work items are commitments to accomplish tasks during the cycle
[12:42] <smartboyhw> balloons, OK
[12:42] <balloons> once the cycle winds down you can/should ping people to ensure it gets done, but not 3 days after :-)
[12:43] <smartboyhw> balloons, OK
[12:43] <balloons> don't worry it will happen, and I don't plan to wait months to do it
[12:43] <smartboyhw> balloons, sure.
[12:46] <TheDrums> balloons: Tried OEM install, got http://paste.openstack.org/show/45735/ - http://paste.openstack.org/show/45733/ in my dmesg and /var/log/oem-whatever-it-is.log
[12:53] <balloons> DanChapman, well I'll branch now.. I looked at the tests you created
[12:54] <balloons> TheDrums, what happens on screen?
[12:54] <TheDrums> Same issue as knome, http://temp.knome.fi/xubuntu/saucy_testing/xubuntu-oem-fail.png 5 times.
[12:56] <balloons> well tbh, xnox is the guy to ask about it. xnox should oem installation work on flavors? If so, we've got a bug :-)
[12:57] <xnox> balloons: it should in the sense that it's available. In practice I only for sure know that it is actively used and verified to work on ubuntu and e.g. lubuntu pre-installed.
[12:57] <balloons> so DanChapman I'm curious to see what all is in the emulators..
[12:57] <xnox> balloons: which bug?
[12:58] <xnox> hmm... looks like network manager really hates unknown uid =(
[12:58] <balloons> xnox, well the xubuntu folks are finding it's not working, so we should get a bug filed.. That was my thought as well.. the only flavor I can think of that perhaps used it was kubuntu or lubunutu
[12:58] <DanChapman> balloons: cool there is some tests in the branch aswell just run autopilotgtkemulators
[13:01] <balloons> I see.. :-) ImportError: No module named autopilotgtkemulators
[13:01] <TheDrums> xnox: I saw "gksudo" being called from one of the python files, but that is no longer seeded in Ubuntu or several flavors.
[13:02] <xnox> TheDrums: ouch, that's bad. Where?
[13:02] <DanChapman> balloons: it works for me running from inside /autopilot-gtk-emulator/
[13:03] <TheDrums> xnox: At least in http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/saucy/ubiquity/saucy/view/head:/bin/oem-config-prepare but in theory it's run as root anyway?
[13:03] <balloons> DanChapman, yea, I wonder if you've commited everything
[13:04] <xnox> TheDrums: that branch was last updated in 2012..... why not look at the actual sources? http://bazaar.launchpad.net/~ubuntu-installer/ubiquity/trunk/view/head:/bin/oem-config-prepare no gksudo called anymore.
[13:04] <TheDrums> >_<
[13:05] <xnox> TheDrums: aka lp:ubiquity ;-)
[13:05] <TheDrums> Well that's sure not going to help...
[13:05] <TheDrums> Thanks.
[13:05] <DanChapman> balloons: i believe i did. Just gonna pull a fresh branch
[13:06] <balloons> I didn't see any missing init's, so it should see it
[13:06] <DanChapman> balloons works fine for me. How strange
[13:07] <TheDrums> And that would be why I couldn't find nmwidgets in the right location.  I want my tasty, warm beverage now...
[13:23] <DanChapman> balloons: just double checked everything on lp and its all there mate
[13:47] <smartboyhw> Oy, phillw is resigning!?
[14:31] <smartboyhw> balloons, I think we need a private chat. PM?
[14:33] <balloons> DanChapman, I gave up for the moment. That said, looking at the code  I like the much simplified test writing.. so it definitely meets that need. The only concern I would have would be long-term maintaince, but to be honest, having it in one place makes it easier.. It does allow us to encounter a bug in the module that breaks everything though :-)
[14:39] <DanChapman> balloons: I tried to make it as simple as possible. I would be more than happy to keep up the maintenance of it :-) once it's more complete would it be an idea for it to live in libautopilot-gtk rather than in my ppa?
[14:41] <balloons> basically our current testsuite is a nice testbed of what you need in an emulator
[14:41] <balloons> so it works well :-)
[14:42] <balloons> on living in the library, I think the team has come around to that idea.. I'd guess you could incorporate it easily enough
[14:47] <balloons> fginther, ping
[14:47] <fginther> balloons, hello
[14:48] <balloons> fginther, if I may, can you look at a couple AP failures? They are a bit funny: http://91.189.93.70:8080/job/generic-mediumtests/206/testReport/calendar_app.tests.test_monthview/TestMonthView/test_monthview_go_to_today_next_year_with_mouse_/
[14:48] <balloons> this calendar test keeps dying at the introspection fork for autopilot
[14:49] <fginther> balloons, that's one I haven't seen before
[14:50] <balloons> meanwhile, filemanager seems to have a backend issue, which is confusing to me; http://91.189.93.70:8080/job/generic-mediumtests/205/testReport/junit/ubuntu_filemanager_app.tests.test_filemanager/TestFolderListPage/test_show_file_properties_with_mouse_/
[14:50] <balloons> I'm going to try building the upstream version on both before digging too much further, to see if the issue appears there also
[14:51] <JoshStrobl> Would this be the right place to go if I wanted to propose a particular application be removed from USC?
[14:51] <balloons> JoshStrobl, try #ubuntu-devel
[14:52] <JoshStrobl> copy that
[14:52] <fginther> balloons, something looks borked
[14:52] <fginther> balloons, I'm looking into the machine itself
[14:53] <balloons> fginther, that was my thought also, but I wanted to double check before pointing too many fingers :-)
[14:54] <balloons> fginther, so I can confirm the filemanager issue with not able to find a backend exists on trunk also.
[15:07] <smartboyhw> chilicuil, BTW why don't you join your LoCo Team or make up one!?
[15:07] <balloons> fginther, interestingly calendar tests passed running from trunk; http://91.189.93.70:8080/job/generic-mediumtests/208/testReport/
[15:10] <chilicuil> smartboyhw: I joined my local team and tried to push forward to organize events (we could organize 3 previous ugj), however it was a pain working with them, therefore I resigned of team, and I don't want to create another local team since I think it could create conflicts, however I will participate on the UGJ, I'll look at one who is organized online, it will be useful to work on my pending tasks in the QA team =)
[15:10] <smartboyhw> chihchun_afk, hmm, that's a problem. What is the pain?
[15:11] <smartboyhw> *chilicuil ^
[15:11] <smartboyhw> Everyone should be able to work with each other
[15:11] <fginther> balloons, I rebooted the VM and am preparing to get it back up. The jenkins process looked to have gone off into the weeds
[15:12] <fginther> balloons, I'll do a few test builds when it's back
[15:12] <balloons> fginther, alrighty
[15:14] <balloons> smartboyhw, there's nothing wrong with not being a part of a local team
[15:14] <smartboyhw> balloons, but there's something wrong when the reason is that you can't cooperate
[15:14] <chilicuil> smartboyhw: people in control of the local resources, web page, lp team and so on, seems not really interested on the team, they delay too much to answer my queries (or don't answer at all) , it's some kind frustating.., also right now I'm somekind busy to try to go through to all the process to make it official in my team
[15:15] <smartboyhw> chilicuil, :(
[15:54] <balloons> fginther, still trying to get jenkins going again or ?
[15:55] <fginther> balloons, yes, I had one good test, but the second had issues with X
[15:55] <balloons> yea, I still see failures
[16:02] <fginther> balloons, the calendar MP passed, I'm now rerunning the file manager
[16:02] <fginther> balloons, I'll be out for a bit, but will check again when I get back
[16:42] <phillw> balloons: do you know if arm still want the lubuntu ac100? It's not been checked all cycle on tracker as far as I can tell.
[17:12] <balloons> phillw, I believe arm is focused on the newer arm revisions now
[17:13] <phillw> balloons: okies, I'll pass the message on to my replacement. There's no point having the image built if it is not required.
[17:14] <balloons> phillw, I won't speak for them, heh
[17:14] <balloons> that's only my opinion, and doesn't mean the image needs or doesn't need to be built ;-)
[17:14] <fginther> balloons, mediumtests are running now except for file manager which is still hitting the backend issue. I'm going to take a closer look
[17:15] <balloons> fginther, good, keep me in touch on filemanager I guess. it's kind of bizarre
[17:15] <phillw> balloons: (s)he can ask. I'm just ensuring an orderly transfer
[17:16] <balloons> right.. I just didn't want you thinking I spoke with authority on that
[17:17] <phillw> as it was Julien who gave permission for ac100, it's most likely best that he ask if it is still required for 13.10 so that the wiki TL knows what the state of play is :)
[17:19] <phillw> balloons: I've got one outstanding task for ubuntu-quality, that of the page https://wiki.ubuntu.com/Testing/Activities/AutopilotTesting do you expect to have completed the spread sheet soon?
[17:22] <balloons> phillw, ohh, the status for ubuntu stuff is in the bugs opened already.. I would suspect longer term for this info to be managed via bugs, but I guess it' up to everyone
[17:26] <phillw> okies, I'll hand the page over to you. elfy has the spreadhseet with lubuntu and xubuntu added for what ever is decided :)
[17:28] <balloons> either way, we just needed the data, so :-)
[17:30] <elfy> balloons: as far as 'framing the request' we need to remove the instances were we've disabled a test - knome is that what we/you found?
[17:30] <knome> yes. stgraber needs to do that, or fix his sql magic.
[17:30] <balloons> elfy, yes I believe knome has the specifics.. If I remember right he spoke with stephane about it as well.
[17:30] <elfy> I think so
[17:30] <balloons> knome, did we file a bug against the site?
[17:31] <stgraber> knome: what was the specific bug again?
[17:31] <balloons> that might help to ensure it's not lost again.. I assumed it was done
[17:32] <elfy> stgraber: if you look here - http://packages.qa.ubuntu.com/qatracker/milestones/300/builds/50384/testcases/1586/results
[17:32] <elfy> the test is archived
[17:32] <elfy> if you look here - http://packages.qa.ubuntu.com/admin/config/services/qatracker/testsuites/348/edit
[17:32] <elfy> you can see we have disabled tests - they got movbed to a different testsuite
[17:32] <elfy> if we enable them - then the real test stops being archived
[17:33] <knome> stgraber, i'll grab it, i vaguely remember filing one...
[17:34] <knome> stgraber, bug 1211746
[17:34] <knome> stgraber, and a real-life example is above ^
[17:36] <balloons> knome, ahh perfect
[17:36] <stgraber> knome: ah right, it's not a bug in the admin UI but the user UI
[17:37] <knome> stgraber, yep
[17:39] <stgraber> ok, I see what check is wrong, just need to figure out what to do to fix it
[17:40] <knome> sure, thanks :)
[17:46] <fginther> balloons, I think I figured out the filemanager issue. The tests are patching a new HOME in the environment with a temp directory. As a result, the file ~/.Xauthority can't be found and autopilot can't find an input backend
[17:46] <fginther> balloons, I'm testing a fix
[17:46] <balloons> fginther, ohh, right
[17:46] <balloons> I was trying to think what was special about them, as they were the only ones
[17:47] <fginther> balloons, I was actually doing a diff with another project to figure out what they were doing different :-)
[17:47] <balloons> hehe, smart
[17:49] <stgraber> knome: can you easily reproduce the issues on packages.qa.dev.stgraber.org?
[17:49] <stgraber> knome: if so, I can then land the fix there to confirm it's right and if it's, ask for IS to push it to production ASAP
[17:49] <knome> stgraber, let me try to
[17:49] <stgraber> if you can't, I'll have to pull a new DB export and re-deploy my local dev environment which takes quite a bit longer (and isn't as likely to get done today then)
[17:56] <knome> i need a mouse
[17:56] <knome> just a sec
[18:01] <knome> stgraber, don't seem to be able to duplicate
[18:02] <knome> http://packages.qa.dev.stgraber.org/qatracker/milestones/254/builds/27973/testcases
[18:02] <knome> stgraber, display settings is disabled in b
[18:03] <knome> oh wait!
[18:03] <knome> ta dah
[18:03] <knome> stgraber, i can reproduce..
[18:04] <knome> stgraber, need chaging the testcase status in testsuite A too to be marked archived
[18:04] <knome> after that, there's no way to revert
[18:07] <stgraber> ok, I'll push the fix there in a few minutes
[18:07] <knome> great
[18:33] <stgraber> knome: can you try now?
[18:34] <knome> stgraber, sure. just a sec
[18:34] <knome> stgraber, seems to be fixed now.
[18:35] <stgraber> good. I'll get IS to deploy this then.
[18:36] <knome> goodie
[18:37] <elfy> thanks stgraber :)
[18:37] <knome> stgraber, marked as committed and assigned to you.
[18:45] <knome> thanks, gtg
[18:46] <stgraber> knome: done, fixed
[20:50] <balloons> fginther, did the fix work, everything good for file manager? the mp is still sitting out there
[20:50] <balloons> fginther, if possible I'd like to push it through as-is, as the tests are failing in the lab and this fixes them
[20:51] <fginther> balloons, the MP resolves the issue of not being able to run the tests, but the tests have other issues :-(
[21:10] <fginther> balloons, the tests are much better now, but I don't know how mdspencer wants to proceed.
[21:11] <balloons> fginther, ok, well we can try him on IRC
[21:11] <balloons> as of this morning he wanted to get it in
[21:15] <balloons> fginther, he's online now, iBelieve
[21:16] <balloons> iBelieve, fginther solved the issue with the tests not pass in the virtual enviroment
[21:16] <iBelieve> balloons, fginther wonderful!
[21:16] <balloons> iBelieve, the changes you made with ~/Home were causing the issue. I believe fginther needs some input now on how to proceed
[21:17] <fginther> iBelieve, here's the MP: https://code.launchpad.net/~fginther/ubuntu-filemanager-app/copy-Xauthority/+merge/183937
[21:17] <fginther> there are still some failing tests, but the start-up issue is resolved
[21:18] <iBelieve> fginther, so that's why they were failing. There was an old bug about that but I didn't realize it was a big problem
[21:19] <iBelieve> fginther, the other failing tests are probably the ones fixed in my branch that I've been working on
[21:19] <iBelieve> fginther, what's the input you need on how to proceed?
[21:20] <fginther> iBelieve, my MP contains the dependency change to include  qtdeclarative5-localstorage-plugin. I didn't know if you wanted to include this, just to have it replaced by u1db in the next MP.
[21:21] <balloons> iBelieve, it might be best to create an MP which includes fginther's fixes, and both of your branch changes.. it might be a lot of code churn, but if it solves everything, that might be the way to go
[21:21] <balloons> if you can otherwise fix the tests and break up the code changes, we can do it seperately
[21:22] <fginther> iBelieve, it may also be easier to just include the change to _patch_home() in your branch
[21:22] <iBelieve> fginther, balloons should I just merge in fginther's branch into mine and do the merge request off that?
[21:24] <balloons> iBelieve, yes, assuming the tests would pass as-is in your branch then. you made it sound like there were more fixes needed in another branch you had
[21:24] <fginther> iBelieve, that will work. you might need to merge to trunk due to the changes to debian/control
[21:24] <fginther> once my branch is merged in
[21:24] <iBelieve> balloons, I was refering the branch that we've been trying to land. I don't have another one
[21:25] <balloons> iBelieve, ahh, then yea, :-)
[21:33] <iBelieve> balloons, fginther okay added in the fix to my merge request: https://code.launchpad.net/~mdspencer/ubuntu-filemanager-app/fix-popover-caller/+merge/183225
[21:33] <iBelieve> hopefully jenkins passes now :)
[22:20] <balloons> iBelieve, one last failure: http://91.189.93.70:8080/job/generic-mediumtests/232/testReport/ubuntu_filemanager_app.tests.test_filemanager/TestFolderListPage/test_copy_file_with_mouse_/?