| mhall119 | yay, my MP landed! | 00:32 |
|---|---|---|
| === shiznix_ is now known as shiznix | ||
| mzanetti | veebers: still around? | 07:54 |
| nic-doffay | larsu, ping | 08:28 |
| larsu | nic-doffay: good morning | 08:29 |
| nic-doffay | larsu, how things? | 08:30 |
| larsu | nic-doffay: good thanks, how are you? | 08:30 |
| nic-doffay | larsu, good! | 08:31 |
| nic-doffay | larsu, you know that branch you prepped which fixed the icons? | 08:31 |
| veebers | mzanetti: I'm just making/having tea but will be around | 08:31 |
| nic-doffay | Can I take a look at the diff? | 08:31 |
| mzanetti | veebers: wanted to ask how many ottos do we have? | 08:32 |
| larsu | nic-doffay: you mean the one that sets the default icon theme to ubuntu-mobile? https://code.launchpad.net/~larsu/unity8/fallback-icon-theme/+merge/183649 | 08:32 |
| dednick | mzanetti: if you're available, can i get you to test a couple of branches for me today? | 08:45 |
| mzanetti | dednick: yes | 08:45 |
| dednick | mzanetti: it's to do with unitymenumodel and the messaging menu. something larsu and i where working on yesterday. It was working on my machine and device, but for some extremely strange reason, it wasn't working for larsu, but we dont know why | 08:46 |
| dednick | mzanetti: lp:~larsu/qmenumodel/use-full-action-name | 08:47 |
| dednick | mzanetti: lp:~nick-dedekind/unity8/unitymenumodel.messages | 08:47 |
| dednick | need to work together | 08:47 |
| dednick | need to check that messages can be replied to and can do a missed call callback. | 08:48 |
| mzanetti | dednick: ok | 08:49 |
| nic-doffay | mzanetti, I think the filters branch is ready for a code review. All the points you brought up have been addressed. | 08:50 |
| mzanetti | nic-doffay: ok | 08:50 |
| nic-doffay | mzanetti, cheers | 08:50 |
| nic-doffay | If there's anything else just comment and I'll see to it. | 08:50 |
| nic-doffay | I think it looks good for an alpha now though. | 08:50 |
| mzanetti | I will :) | 08:50 |
| nic-doffay | As you mentioned the icon isn't right. | 08:50 |
| dednick | mzanetti: larsu was getting this error: | 08:51 |
| dednick | file:///home/lars/src/unity8/unitymenumodel.messages/builddir/plugins/Unity/Indicators/Messaging/MessageMenuItemFactory.qml:136: TypeError: Cannot read property 'valid' of null | 08:51 |
| nic-doffay | I'll bring that up now... | 08:51 |
| mzanetti | nic-doffay: which icon? | 08:51 |
| larsu | dednick: might it be that "index" is one of those special property names you're not allowed to use? | 08:51 |
| nic-doffay | mzanetti, the filters one. | 08:51 |
| dednick | larsu: ah. errr it might be | 08:51 |
| nic-doffay | In that design preview it has an orange background. | 08:51 |
| dednick | larsu: dont know why it would be working on mine then | 08:52 |
| mzanetti | larsu: well, inside a Delegate, the word "index" is indeed reserved for the index in the List/Repeater/Whatever | 08:52 |
| larsu | right, we had this befoe | 08:52 |
| mzanetti | aka. an attached property | 08:52 |
| larsu | but wouldn't it give me an error? | 08:52 |
| dednick | mzanetti: you can override properties though. it's just a QObject that has the index proporty | 08:53 |
| dednick | *property | 08:53 |
| dednick | but i guess maybe the listview passing down of the property is buggering things up | 08:54 |
| dednick | larsu: worth a try changing it i guess | 08:54 |
| larsu | dednick: trying right now | 08:54 |
| mzanetti | larsu: hmm... actually no... its like defining a local variable in a context where that name already exists. the local one will just hide the "global" one | 08:55 |
| larsu | mzanetti: this is a property name though, not a variable name | 08:56 |
| veebers | mzanetti: ah err, good question. I've only set up one machine so far, but there are I think 4 more from memory that are to be part of that pool of otto machines | 08:56 |
| mzanetti | veebers: we need them all :D | 08:57 |
| mzanetti | veebers: if apps and unity run tests on the same machine, one is definitely not enough. | 08:57 |
| veebers | mzanetti: agreed, I'll get them setup first thing my morning :-) I need to change one thing with the config too. So will let you know when they are setup and running | 08:58 |
| mzanetti | veebers: awesome. thanks | 08:58 |
| veebers | nw | 09:01 |
| === hikiko is now known as hikiko|lunch | ||
| mzanetti | greyback: you available for a review? | 10:41 |
| greyback | mzanetti: if it's not too big, sure | 10:41 |
| mzanetti | greyback: https://code.launchpad.net/~mzanetti/unity-api/launcher-add-focused/+merge/183843 and https://code.launchpad.net/~mzanetti/unity8/launcher-appmanager/+merge/183837 | 10:41 |
| greyback | mzanetti: you mean to have the big debug prints in the latter one? | 10:42 |
| * mzanetti checks | 10:43 | |
| mzanetti | greyback: d'oh. forgot to push my last commit. should be gone now | 10:44 |
| greyback | ok | 10:44 |
| greyback | mzanetti: probably due to my not understanding the launcher design, but I had expected the launcher to be connected to the AppManager's list of running apps, and be able to read off the focused one from there | 10:47 |
| mzanetti | greyback: yeah. the applicationFocused will change again I guess. With the current state of the app manager this is the closest I could get | 10:48 |
| greyback | mzanetti: understood. Wanna put in a todo/remove-me comment in the api? | 10:48 |
| mzanetti | greyback: if you think I should... but it's clearly on my todo list to switch to the final App Manager api :) | 10:49 |
| greyback | mzanetti: fair enough :) I'll trust you | 10:49 |
| mzanetti | nic-doffay: dude... your branch doesn't even start up :D | 10:59 |
| nic-doffay | mzanetti, ? | 10:59 |
| nic-doffay | works ok for me | 10:59 |
| mzanetti | nic-doffay: http://paste.kde.org/pc6423eb3 | 10:59 |
| nic-doffay | mzanetti, try using trunk of ubuntu-ui-toolkit | 11:00 |
| mzanetti | nic-doffay: better indeed :) | 11:03 |
| nic-doffay | mzanetti, :) | 11:03 |
| mzanetti | nic-doffay: but the narrowMode is still broken | 11:03 |
| nic-doffay | mzanetti, just taking a look at your screenshot again. | 11:04 |
| nic-doffay | mzanetti, jenkins needs to rebuild too there was a whitespace issue. | 11:04 |
| nic-doffay | mzanetti, I see about narrowMode. | 11:05 |
| nic-doffay | What's it supposed to look like? | 11:06 |
| === hikiko|lunch is now known as hikiko | ||
| sil2100 | pete-woods: hi! | 11:22 |
| sil2100 | pete-woods: https://code.launchpad.net/~sil2100/unity-voice/add_autopilot_package/+merge/183852 <- could you take a look? ;) | 11:22 |
| pete-woods | sil2100: having a look now :) | 11:24 |
| greyback | mzanetti: I got this when compiling lp:~mzanetti/unity8/launcher-appmanager http://pastebin.ubuntu.com/6062275/ | 11:24 |
| mzanetti | greyback: oh noes! fixing | 11:26 |
| sil2100 | pete-woods: the merger is down so there's no hurry ;) | 11:26 |
| mzanetti | greyback: added | 11:28 |
| greyback | mzanetti: ta | 11:28 |
| mzanetti | dednick: do you still need me to test those branches or did the "index" thing fix your problem? | 11:32 |
| dednick | larsu: ^ did you test that? | 11:32 |
| dednick | mzanetti: i'm guessing it didnt fix if he hasn't whooped with joy | 11:37 |
| mzanetti | :D | 11:37 |
| nic-doffay | mzanetti, reading your comment regarding the flicking up. | 11:42 |
| nic-doffay | mzanetti, I don't notice any flicker? | 11:43 |
| nic-doffay | when dragging after it's been nudged to display that it can be scrolled | 11:43 |
| mzanetti | nic-doffay: do *exactly* what I tell you to reproduce: | 11:44 |
| mzanetti | ./run | 11:44 |
| nic-doffay | mzanetti, also, I def cannot swipe left or right when the overlay is open? | 11:44 |
| mzanetti | click on the search text | 11:44 |
| mzanetti | click on the filter icon | 11:44 |
| mzanetti | click on applications | 11:45 |
| mzanetti | click on books | 11:45 |
| mzanetti | click on books again | 11:45 |
| mzanetti | click on books again | 11:45 |
| mzanetti | now the optionselector is broken | 11:45 |
| mzanetti | now, to reproduce the jumping: | 11:46 |
| mzanetti | click on books once again (to expand the optionsleector again) | 11:46 |
| mzanetti | scroll down to the end | 11:46 |
| nic-doffay | mzanetti, ah got it. | 11:46 |
| mzanetti | click on videos | 11:46 |
| mzanetti | click on videos again. | 11:46 |
| mzanetti | start dragging the list up/down => it'll jump | 11:46 |
| nic-doffay | mzanetti, good spotting, thanks for that. | 11:49 |
| mzanetti | nic-doffay: and for the swiping of the dash: | 11:50 |
| mzanetti | ./run | 11:50 |
| mzanetti | click on the search textt | 11:50 |
| mzanetti | click on the filter icon | 11:50 |
| mzanetti | swipe it to the right/left | 11:50 |
| nic-doffay | mzanetti, ah I see. | 11:50 |
| nic-doffay | It's only disabled for Applications. | 11:50 |
| mzanetti | nic-doffay: also broken for applications here | 11:51 |
| mzanetti | anyways... need some food | 11:51 |
| nic-doffay | mzanetti, strange, I def cannot swipe applications. | 11:52 |
| nic-doffay | After the rest of the fixes I'll revisit that though. | 11:52 |
| === dandrader is now known as dandrader|afk | ||
| === alan_g is now known as alan_g|lunch | ||
| sil2100 | pete-woods: thanks for the review! The merger is still down, so it'll be around in the form of a merge for a while still ;p | 12:09 |
| pete-woods | sil1200: np! | 12:09 |
| === dandrader|afk is now known as dandrader | ||
| sil2100 | pete-woods: btw! Do you know if unity-voice is part of the touch FFe? | 12:17 |
| larsu | dednick: I tested it this morning and it didn't solve the problem | 12:17 |
| pete-woods | sil2100: I don't know, but I doubt it to be honest | 12:19 |
| sil2100 | pete-woods: so it's not necessary for the touch images? | 12:23 |
| pete-woods | sil2100: I have created the package because HUD has frequently developed memory leaks, and when it leaks it takes the fairly heavyweight voice code with it - e.g. 50MB each time | 12:25 |
| pete-woods | sil2100: so the package is there in-case we have any emergency leaks in HUD | 12:25 |
| pete-woods | we can switch over to using it | 12:25 |
| pete-woods | but it isn't necessary in the mathematical sense for 13.10 | 12:26 |
| === dednick is now known as dednick|lunch | ||
| sil2100 | pete-woods: ah! Ok, all is clear now | 12:26 |
| larsu | pete-woods: talking about the hud, it doesn't respond to any dbus calls on my machine. Starting unity8 takes > 10 seconds until it times out. Do you have any idea what the issue could be? | 12:27 |
| larsu | pete-woods: I'm on saucy, no ppas. | 12:27 |
| pete-woods | larsu: that doesn't surprise me, it seems to break all the time | 12:30 |
| pete-woods | often when I / Wellark go in to fix things, it seems strange how those parts ever worked in the first place | 12:30 |
| pete-woods | larsu: I'll try running it up now on my machine to see how I fare, though | 12:31 |
| larsu | pete-woods: thanks. It's not super-urgent as I hardly use it. Just a bit annoying because I have to wait for unity to start up… | 12:32 |
| larsu | but I don't hack on that refularily | 12:32 |
| larsu | *regularily | 12:32 |
| * larsu learns it's actually *regularly | 12:33 | |
| pete-woods | I prefer your second spelling | 12:33 |
| pete-woods | larsu: well I can confirm the timeout issue - I also have to wait on HUD | 12:37 |
| larsu | pete-woods: I think it's a combination of it not responding and the sleep(10) in dbus-activation-hack.sh | 12:38 |
| nic-doffay | mzanetti, ^5 for the review comments. Most have been sorted out aside from the tests which are next on my list. Just need a second opinion on the scrolling between scopes being disabled correctly. | 12:38 |
| pete-woods | larsu: I have no idea why we even have that hack, I'm guessing it has something to do with upstart? | 12:45 |
| larsu | pete-woods: hm, changing that '10' to something lower doesn't make unity start faster. I guess that's no it, then | 12:47 |
| larsu | pete-woods: something about the interaction between dbus and upstart. I've been saying for a long time that we need proper dbus activation support in upstart. | 12:48 |
| pete-woods | larsu: I totally agree with you there | 12:50 |
| pete-woods | systemd has it, so upstart should too | 12:50 |
| === alan_g|lunch is now known as alan_g | ||
| mzanetti | om26er: greyback: can you please review this? Apparently Pat would need this fixed for a demo later today: https://code.launchpad.net/~mzanetti/unity8/fix-1219035/+merge/183866 | 12:59 |
| mzanetti | greyback: I think my code is ok. however, bad thing is, is that I don't really understand why this has been working before :/ | 13:00 |
| greyback | mzanetti: ack, will do now | 13:00 |
| mzanetti | the size of the panel is probably because the Panel was reworked and most likely doesn't live outside the view any mire | 13:01 |
| om26er | mzanetti, looks good to me. I can probably test the fix once the debs are published | 13:01 |
| mzanetti | but why the "hide button on release" did work before is beyond me | 13:01 |
| larsu | pete-woods: hm, org.freedesktop.dbus.StartServiceByName('com.canonical.hud', 0) times out, but the name seems to get registered correctly (it appears in ListNames). Maybe the hud manages to register the name and then immediately hangs when dbus-daemon tries to ping it? | 13:05 |
| * larsu wonders why the daemon would ping it at all | 13:05 | |
| sergiusens | is there a plan to update the apps lens on changes to ~/.local/share/applications ? | 13:07 |
| larsu | pete-woods: I bet the problem is the script itself - dbus probably wants that the PID it just started registers the name | 13:08 |
| pete-woods | larsu: I think the real concern I have is that this problem must exist in all services that try to use both upstart and dbus activation | 13:11 |
| greyback | mzanetti: approved | 13:11 |
| pete-woods | unless there's a better way to do it that is being done in HUD | 13:13 |
| pete-woods | *than | 13:13 |
| larsu | pete-woods: I think tedg's idea is to get away from dbus activation, which would circumvent this problem entirely | 13:14 |
| pete-woods | well all I really care about is there's a proper way for me to copy for any services I write | 13:15 |
| tedg | Yeah, the way the HUD does it is kinda a hack, but I thought it'd be temporary until we got DBus activation in Upstart. But I'm not sure that's happening. | 13:16 |
| tedg | I'm curious if we can't use the dbus monitor in Upstart today to fake it. | 13:16 |
| tedg | Though I haven't tried. | 13:16 |
| larsu | tedg: the way the hud does it doesn't work right now... | 13:17 |
| tedg | I don't know if StartServiceByName actually gets broadcast. | 13:17 |
| tedg | ? | 13:17 |
| pete-woods | tedg: dbus service activation doesn't seem to work for HUD atm | 13:17 |
| larsu | to be fair, it might be a bug in the hud as well | 13:17 |
| pete-woods | good point | 13:17 |
| tedg | Hmm, it just worked for me... | 13:17 |
| larsu | maybe it just hangs right after registering its name | 13:18 |
| pete-woods | tedg: our test case is killall hud then start unity8 | 13:18 |
| pete-woods | if you have to wait 10s then you also have the problem | 13:18 |
| tedg | pete-woods, Is upstart confused? Try "stop hud" ? | 13:18 |
| tedg | Also I think that the shell script needs to have died as well. | 13:19 |
| pete-woods | tedg: I get the same if I stop hud nicely with stop hud | 13:19 |
| tedg | pete-woods, Is dbus-activation-hack.sh still running? | 13:20 |
| pete-woods | tedg: it doesn't seem to be - I made sure I waited >10s | 13:23 |
| pete-woods | tedg: we're not ruling out that this could be a problem in HUD, maybe something has broken in it again | 13:23 |
| tedg | The only thing that's changed there is the dbus paths... it's pretty innocuous. | 13:24 |
| tedg | Anything in the hud log? | 13:24 |
| pete-woods | tedg: I haven't had time to investigate it beyond confirming that it happens | 13:27 |
| * tedg has upgraded and is rebooting his phone | 13:33 | |
| kgunn | anyone else's mumble freaking out? | 13:34 |
| tedg | So I stopped the HUD. Opened the webbrowser and then opened the HUD. There were entries in the browser. | 13:36 |
| tedg | pete-woods, larsu, is there something else I need to do? | 13:36 |
| mterry | mzanetti, sound came in right at the end :-/ | 13:36 |
| mterry | mzanetti, I don't get mumble sometimes | 13:37 |
| pete-woods | tedg: this is on the desktop | 13:37 |
| mzanetti | mterry: no worries. | 13:37 |
| tedg | pete-woods, Unity8 on the desktop? | 13:37 |
| pete-woods | it means it takes 10s to start unity8 each time you make a change to it | 13:37 |
| pete-woods | tedg: ues | 13:37 |
| pete-woods | yes, even | 13:37 |
| nic-doffay | pstolowski, ping | 13:37 |
| tedg | pete-woods, How are you running Unity8 on the desktop? | 13:38 |
| pstolowski | nic-doffay: pong | 13:38 |
| larsu | tedg: I also don't see any results in unity7 | 13:38 |
| larsu | tedg: it doesn't react to any dbus message | 13:38 |
| * tedg is confused | 13:39 | |
| tedg | 13.10.1+13.10.20130822.4-0ubuntu1 right? | 13:39 |
| larsu | yep | 13:39 |
| larsu | is there a log I could send you? | 13:40 |
| tedg | You guys should come use my computer, it is seemingly much better than yours. | 13:40 |
| tedg | :-) | 13:40 |
| tedg | larsu, Check ~/.cache/upstart/hud.log | 13:40 |
| larsu | there's one problem with that though: your computer is in Texas | 13:40 |
| tedg | larsu, So you'd upgrade your location AND your computer! | 13:40 |
| larsu | I've got a couple of those: (process:17380): hud-service-WARNING **: SIGTERM recieved | 13:41 |
| larsu | nothing else | 13:41 |
| tedg | That'd be just when it shutsdown. Probably shouldn't be a warning. | 13:41 |
| larsu | right | 13:41 |
| tedg | initctl list | grep hud | 13:41 |
| larsu | hud start/running, process 31274 | 13:41 |
| kgunn | mzanetti: ping | 13:41 |
| mzanetti | kgunn: pong | 13:41 |
| tedg | larsu, $ hud-cli test | 13:42 |
| * larsu installs indicator-appmenu-tools | 13:43 | |
| larsu | interesting, that doesn't contain hud-cli | 13:43 |
| tedg | larsu, hud-tools | 13:43 |
| larsu | tedg: thanks. Bash told me it is in indicator-appmenu-tools | 13:44 |
| tedg | Huh, I thought that was autogenerated... perhaps it needs to be updated. | 13:44 |
| larsu | tedg: "search token: test", then nothing for a while, then "** (process:32182): WARNING **: Unable to get a HUD proxy: Error calling StartServiceByName for com.canonical.hud: Timeout was reached" | 13:45 |
| tedg | larsu, try stopping it "stop hud" and then do it again. | 13:45 |
| kgunn | mterry: ping | 13:46 |
| larsu | tedg: same result | 13:46 |
| tedg | Wonder if I'm running the old dbus in my session. | 13:46 |
| larsu | tedg: actually, the error is different: ** (process:32208): WARNING **: Unable to get a HUD proxy: Error calling StartServiceByName for com.canonical.hud: GDBus.Error:org.freedesktop.DBus.Error.TimedOut: Activation of com.canonical.hud timed out | 13:47 |
| larsu | well, for some values of "different" | 13:47 |
| tedg | larsu, I'm going to reboot a second to see if that's the case. | 13:47 |
| nic-doffay | mzanetti, apparently a lot of the backend scope unit tests already test the functionality. What else would you recommend testing in the filters QML side? | 13:50 |
| tedg | larsu, Huh, no, still works: http://pastebin.ubuntu.com/6062728/ | 13:50 |
| larsu | tedg: weird. I assume this is plain saucy as well? | 13:52 |
| tedg | larsu, Yeah, nothing special besides being in Texas. | 13:52 |
| tedg | larsu, Try covering your laptop in BBQ sauce. | 13:53 |
| larsu | hm, maybe that's it :P | 13:53 |
| larsu | HAHA | 13:53 |
| kgunn | mterry: ping | 13:54 |
| mterry | kgunn, hi | 13:56 |
| mzanetti | nic-doffay: I want a test that checks if that overlay indeed shows up when I click the filter icon, if clicking the bottom area dismisses it, and if interacting with the optionselector inside that overlay actually works | 13:56 |
| nic-doffay | mzanetti, gotcha | 13:56 |
| mzanetti | kgunn: here's the branch with the code: https://code.launchpad.net/~unity-team/unity8/ofono/+merge/177814 | 13:57 |
| mzanetti | kgunn: and here's the video of it: http://ubuntuone.com/4mdKuE6k2KvdQE9ie2nYF8 | 13:57 |
| mzanetti | dednick|lunch: let me know when you're back. have some results for your branches | 14:10 |
| tedg | dednick|lunch, It looks like the multi-icon branch landed \o/ But I'm still not getting multiple icons... anything I need to do? | 14:12 |
| === dandrader is now known as dandrader|afk | ||
| === dednick|lunch is now known as dednick | ||
| dednick | mzanetti: i'm back. just forgot to change status | 14:16 |
| dednick | tedg: not that i know of. if you give icons they should be displayed | 14:17 |
| tedg | dednick, Are you getting a cell signal level on your panel? | 14:17 |
| dednick | tedg: nope | 14:17 |
| tedg | larsu, Just tried the guest session and that worked for me as well, can you try that? | 14:18 |
| dednick | tedg: sometimes i do | 14:18 |
| tedg | dednick, Hmm, that's weird. | 14:19 |
| tedg | I'm definitely exporting it. | 14:19 |
| mzanetti | dednick: so, I've installed a package of lars's branch and ./run_on_device yours | 14:19 |
| tedg | dednick, http://pastebin.ubuntu.com/6062829/ | 14:19 |
| dednick | tedg: hm. let me take a look | 14:20 |
| mzanetti | dednick: the messages icon in the panel is missing, but I do get missed calls in the messages tab. calling back works fine. need to test with SMS still | 14:20 |
| dednick | mzanetti: cool. | 14:20 |
| larsu | tedg: no output at all and the process exits immediately. Also, no indicators in the guest session... | 14:21 |
| tedg | larsu, You need to start it from lightdm, not the session menu :-( | 14:21 |
| larsu | tedg: because upstart? | 14:21 |
| larsu | will try again | 14:21 |
| tedg | larsu, Yeah, for some reason they're starting the session differently. | 14:21 |
| tedg | Which seems really bad, but I don't understand why yet. | 14:22 |
| larsu | tedg: works as it should when I log in from lightdm | 14:23 |
| larsu | let me try restarting my own session | 14:23 |
| tedg | larsu, Delete everything in your home directory and try again. | 14:24 |
| tedg | ;-) | 14:24 |
| dednick | tedg: gsm-3g-medium doesnt exist in the theme | 14:25 |
| dednick | tedg: https://bugs.launchpad.net/ubuntu-themes/+bug/1212184 | 14:26 |
| ubot5 | Launchpad bug 1212184 in Ubuntu theme "Missing ubuntu-mobile indicator icons" [High,Confirmed] | 14:26 |
| larsu | tedg: doesn't time out anymore, but no output either | 14:26 |
| larsu | tedg: the hud itself also doesn't work, but doesn't show the never ending spinner anymore | 14:26 |
| tedg | dednick, I've got one as well: https://bugs.launchpad.net/indicator-network/+bug/1220418 | 14:27 |
| ubot5 | Launchpad bug 1220418 in Network Menu "Remove temporary icons" [High,Confirmed] | 14:27 |
| tedg | dednick, Those exist in the mono set, do we not fall back to that? | 14:27 |
| dednick | tedg: dont think it is installed on phone | 14:27 |
| tedg | dednick, They're in Humanity as well. | 14:28 |
| dednick | tedg: apparently not then | 14:28 |
| tedg | Okay, so I'll put them in as temp icons in indicator-network. | 14:28 |
| tedg | larsu, Interesting, but at least it's running :-) | 14:28 |
| tedg | larsu, This is on Unity8 in the emulator thing or Unity 7? | 14:29 |
| === alan_g is now known as alan_g|tea | ||
| === dandrader|afk is now known as dandrader | ||
| larsu | tedg: unity7 | 14:31 |
| tedg | dednick, Cool, I copied the icons manually into the mobile theme and they work! \o/ | 14:32 |
| * tedg has two bars! | 14:32 | |
| dednick | tedg: deisgn is working on it, but dont know when they're actually going to put them in. | 14:33 |
| tedg | larsu, Stupid question, but making sure, do you have unity-gtk-module installed? | 14:33 |
| tedg | dednick, Eh, I can put temp ones in. We can't block on them. We already have a bunch. | 14:33 |
| larsu | tedg: yes :) | 14:35 |
| larsu | tedg: I already said this to pete, this is not the most pressing issue. Just wanted to let you guys know. | 14:36 |
| mzanetti | dandrader: added tests. can you review/approve? | 14:42 |
| mzanetti | dandrader: https://code.launchpad.net/~mzanetti/unity8/fix-1219035/+merge/183866 | 14:42 |
| dandrader | mzanetti, sure | 14:45 |
| tedg | larsu, Okay. It is odd. | 14:46 |
| tedg | larsu, Were you able to figure out the unity menu model thing for custom actions? | 14:46 |
| === alan_g|tea is now known as alan_g | ||
| mzanetti | dednick: replying to an sms works too. only thing is that the notification icon doesn't show up in the panel | 14:51 |
| larsu | tedg: nope, I still have the same problem | 14:51 |
| larsu | tedg: apparently mzanetti doesn't, though^^ | 14:51 |
| dednick | larsu: i'm going to approve | 14:52 |
| mzanetti | I built a package from larsu's branch and installed that to the phone. rebooted and used run_on_device to run dednick's branch | 14:52 |
| larsu | I'm throughly confused about what is going on :) | 14:53 |
| larsu | but anyway, glad it works for all of you | 14:53 |
| * tedg took a walk and tested one bar, two bars and three bars of signal level... now I need a cell tower to test four. | 14:53 | |
| dandrader | mzanetti, how do I run autopilot tests. I'm getting a "RuntimeError: Unable to locate unity8 binary: CalledProcessError()" | 14:53 |
| dandrader | mzanetti, but unity8 is build | 14:53 |
| dandrader | built | 14:54 |
| mzanetti | larsu: you can close the bug with status WORKSFORYOU :P | 14:54 |
| dednick | dandrader: you need to install | 14:54 |
| larsu | mzanetti: haha! | 14:54 |
| mzanetti | dandrader: need to do a make install in the builddir | 14:54 |
| dandrader | oh no | 14:54 |
| dednick | dandrader: just to local. make install in build folder. | 14:54 |
| dednick | dandrader: i think it goes to ./builddir/install | 14:55 |
| dednick | by default anyway | 14:55 |
| * mzanetti whishes the make install wasn't needed | 14:55 | |
| dandrader | dednick, right. thanks! | 14:55 |
| dednick | maybe mzanetti should fix it such that it isnt ;) | 14:56 |
| mzanetti | or... if the make autopilot target would be able to filter tests. then it would solve the problem too | 14:56 |
| dandrader | mzanetti, then I run autopilot from where? I'm a bit lost now | 14:56 |
| mzanetti | dandrader: to run all tests, simply do a make autopilot in builddir | 14:56 |
| mzanetti | dandrader: to run single tests, you need to do the make install in the builddir every time you change some code and then go to tests/autopilot | 14:57 |
| mzanetti | dandrader: and run with "autopilot run unity8...." | 14:57 |
| mzanetti | dandrader: ah, fyi: the notifications autopilot tests will fail unless you either kill your notifyosd or launch a new dbus session bus before starting the test suite | 15:02 |
| nic-doffay | mzanetti, any idea how to run individual tests with the Unity.Test module? | 15:08 |
| mzanetti | nic-doffay: do you mean a single test, or a single test suite? | 15:09 |
| nic-doffay | mzanetti, a single test with qmltestrunner | 15:09 |
| mzanetti | nic-doffay: the problem is, qmltestrunner doesn't restart the app during the run of a whole suite. so running a single test would give you different results | 15:10 |
| mzanetti | nic-doffay: but the test suites aren't that big. which one are you working on? | 15:10 |
| nic-doffay | mzanetti, qmluitests | 15:10 |
| mzanetti | nic-doffay: how do you run them? | 15:10 |
| nic-doffay | mzanetti, from the builddir make qmluitests | 15:11 |
| mzanetti | nic-doffay: ah ok... you're running all test suites | 15:11 |
| mzanetti | nic-doffay: use "make testXXX" where XXX is the test suite you want | 15:11 |
| nic-doffay | mzanetti, right I figured that was one suite, my mistake. | 15:11 |
| mzanetti | nic-doffay: for example "make testPageHeader" runs the PageHeader tests. | 15:12 |
| dandrader | mzanetti, reviewed | 15:12 |
| mzanetti | nic-doffay: to see your test while working on it, you can use "make tryPageHeader" | 15:12 |
| mzanetti | dandrader: thanks | 15:12 |
| mzanetti | dandrader: done | 15:14 |
| dandrader | mzanetti, likewise | 15:17 |
| mzanetti | dandrader: lol. yes you are :) I was actually thinking about adding "except on the button itself" :) | 15:17 |
| dandrader | hehehe | 15:18 |
| === dandrader is now known as dandrader|afk | ||
| === dandrader|afk is now known as dandrader | ||
| dandrader | mzanetti, actually, on a second thought, won't the hud button always disappear anyway (HUD being activated or not)? | 15:22 |
| mzanetti | dandrader: yes. indeed | 15:23 |
| dandrader | mzanetti, therefore shouldn't we be checking whether the hud is being activated or not instead? | 15:23 |
| mzanetti | dandrader: but this test deals only with releasing it outside. the next test is the one that releases it on the button | 15:23 |
| mzanetti | dandrader: right... fair point. I'll add that check too | 15:23 |
| === dandrader is now known as dandrader|afk | ||
| mzanetti | dandrader|afk: pushed | 15:27 |
| dednick | mzanetti: ping | 15:39 |
| mzanetti | dednick: pong | 15:39 |
| dednick | mzanetti: how goes the sim pin ui? | 15:39 |
| mzanetti | dednick: what you mean with how goes? | 15:39 |
| dednick | how is it going? :) | 15:39 |
| mzanetti | dednick: havent managed to integrate it as a notification yet | 15:40 |
| dednick | ok | 15:40 |
| dednick | i've got the network indicator sending of a notification, but for now i'm just using wifi-auth ui. now just got to get the pin back... | 15:42 |
| dednick | mzanetti: ^ | 15:42 |
| mzanetti | dednick: oh wow, cool | 15:42 |
| kgunn | greyback: ricmm ... the switch we've been dicussing will be boot-time right ? | 15:47 |
| kgunn | based on qt plugin | 15:47 |
| dednick | mzanetti: problem is that i have no idea how MacSlow intended to get data back to the backend. He's got some feedback interface, but actually using it might be a different story. | 15:47 |
| mzanetti | dednick: at which branch are you looking? | 15:48 |
| dednick | mzanetti: lp:~macslow/unity-notifications/extended-snap-decisions | 15:48 |
| dednick | lp:~macslow/unity8/extended-snap-decisions | 15:48 |
| mzanetti | dednick: ok, will look at it now | 15:49 |
| nic-doffay | larsu, ping | 15:52 |
| kgunn | dednick: do you know jussi who does the backend for notifications?...not sure, would it help to chat with him ? | 15:53 |
| kgunn | he's finnish so might be eod | 15:53 |
| dednick | kgunn: thanks | 15:55 |
| larsu | nic-doffay: yep | 15:55 |
| nic-doffay | larsu, any idea how I can enable the icon themes for Unity qmluitests? | 15:55 |
| larsu | nic-doffay: no... what's the problem? | 15:56 |
| nic-doffay | larsu, not seeing the icon again. | 15:56 |
| nic-doffay | running the pageHeader test. | 15:56 |
| larsu | nic-doffay: how do I run that manually? | 15:57 |
| nic-doffay | larsu, go to the builddir | 15:57 |
| nic-doffay | run make tryPageHeader | 15:57 |
| nic-doffay | or make testPageHeader | 15:57 |
| nic-doffay | larsu, from my branch though. | 15:58 |
| nic-doffay | larsu, lp:~nicolas-doffay/unity8/filter-selector | 15:58 |
| * larsu branches away | 15:58 | |
| larsu | nic-doffay: I'm guessing your test is not running the unity8 binary? | 16:00 |
| nic-doffay | larsu, no. | 16:03 |
| larsu | nic-doffay: so most likely the theme isn't set to "ubuntu-mobile", and the "filter" icon is only in there | 16:03 |
| larsu | nic-doffay: call QIcon::setThemeName("ubuntu-mobile"); in your test startup | 16:04 |
| larsu | the test does pass though...... | 16:04 |
| larsu | :) | 16:04 |
| nic-doffay | larsu, at the moment | 16:04 |
| nic-doffay | I haven't pushed anything else. | 16:04 |
| nic-doffay | You'll see the filter's icon isn't visible too | 16:04 |
| nic-doffay | and you can't click on it for whatever reason | 16:04 |
| nic-doffay | Need to get to the bottom of this. | 16:04 |
| nic-doffay | larsu, since this is a qml test how can I call that function from qmlside? | 16:05 |
| larsu | nic-doffay: not sure if you can call it from qml at all. Is it one of those QUICK_TEST_MAIN deals? | 16:06 |
| nic-doffay | larsu, as I suspected | 16:06 |
| nic-doffay | larsu, not sure tbh | 16:06 |
| larsu | nic-doffay: ah, qmltestrunner. So I don't think this will be possible, unless we can add it to some module that your test imports | 16:10 |
| larsu | but it doesn't look like there's any testing-specific c++ plugin | 16:10 |
| nic-doffay | larsu, hmm it might be detrimental to some of the visual tests | 16:11 |
| nic-doffay | But I guess if they pass they pass. | 16:11 |
| larsu | nic-doffay: adding it to the Unity.Test module might be okay | 16:17 |
| larsu | nic-doffay: http://paste.debian.net/35020/ | 16:18 |
| larsu | not sure _how_ ugly people would find that, but at least it solves this problem :) | 16:18 |
| nic-doffay | larsu, I'll take a look at the test case code. | 16:19 |
| nic-doffay | Maybe there's another place to put it. | 16:20 |
| nic-doffay | larsu, cheers though | 16:20 |
| nic-doffay | mzanetti, you there? | 16:26 |
| mzanetti | nic-doffay: yes | 16:26 |
| nic-doffay | mzanetti, simple mouse test isn't being executed, is there anything I need to be aware of? | 16:27 |
| nic-doffay | https://pastebin.canonical.com/96871/ | 16:27 |
| nic-doffay | I can click it in a qmlscene | 16:27 |
| mzanetti | nic-doffay: is it inside a UnityTest {} ? | 16:27 |
| nic-doffay | The test fails though, I'm not sure what more I need to do than trigger a mouseClick on a MouseArea at 0, 0 | 16:27 |
| nic-doffay | mzanetti, yeah | 16:28 |
| mzanetti | nic-doffay: don't know whats going on. you'd need to push the code | 16:29 |
| mhr3 | pete-woods, ping? | 16:32 |
| pete-woods | mhr3: hi | 16:32 |
| mhr3 | pete-woods, hey did you already with the zeitgeist tracing? | 16:33 |
| mhr3 | already start* | 16:33 |
| pete-woods | mhr3: not yet, the other stuff I was working on has taken longer than I anticipated | 16:33 |
| mhr3 | oh, so it's not just me :) | 16:34 |
| pete-woods | ;) | 16:34 |
| mhr3 | pete-woods, ok, so i'll try it | 16:34 |
| pete-woods | mhr3: as in you're going to do the profiling? | 16:34 |
| mhr3 | yeah | 16:34 |
| pete-woods | okay, well I'm never going to complain about less work for me | 16:35 |
| pete-woods | just wish I'd been able to take it off hands sooner | 16:35 |
| pete-woods | *your | 16:35 |
| nic-doffay | mzanetti, the inverseMouseArea works fine. | 16:54 |
| nic-doffay | The test | 16:54 |
| nic-doffay | https://pastebin.canonical.com/96879/ | 16:54 |
| nic-doffay | That fails. | 16:54 |
| nic-doffay | Because it's collapsed after selected the inverseMouseArea | 16:54 |
| nic-doffay | however the normal mouse area still doesn't click in the test. | 16:54 |
| mzanetti | nic-doffay: you're clicking the inverseMouseArea, that's the one that make it collapse, right? | 16:56 |
| nic-doffay | mzanetti, yes that works. | 16:56 |
| nic-doffay | mzanetti, the other doesn't. | 16:56 |
| === alan_g is now known as alan_g|EOD | ||
| mzanetti | but after clicking, you check if its expanded | 16:57 |
| nic-doffay | mzanetti, yeah that fails which is expected from the inverseMouseArea. | 16:57 |
| nic-doffay | Since it's not 'expanded' | 16:57 |
| nic-doffay | mzanetti, here's the whole test currently: https://pastebin.canonical.com/96880/ | 16:57 |
| nic-doffay | mzanetti, if I replace line 6 with "filterSelector.state = 'expanded'" it works | 16:58 |
| mzanetti | nic-doffay: try to use tryCompare() | 16:58 |
| mzanetti | and maybe click in the center of the mousearea, instead of 0,0, or try with 1,1 at least | 16:59 |
| nic-doffay | mzanetti, I've tried offsetting the values. | 17:01 |
| nic-doffay | no luck with tryCompare either. | 17:01 |
| mzanetti | nic-doffay: can you push the code so I can try to find out? | 17:03 |
| nic-doffay | mzanetti, yeah just trying some last ditch efforts | 17:04 |
| nic-doffay | mzanetti, pushed | 17:06 |
| mzanetti | nic-doffay: found it | 17:14 |
| mzanetti | nic-doffay: so, you need to call pageHeader.triggerSearch() in the beginning to make the search label appear | 17:14 |
| mzanetti | nic-doffay: and then use some tryCompare() to wait for the textField to become visible | 17:14 |
| nic-doffay | mzanetti, ah I tried triggerSearch without an asynchronous call. Guess that's where I went wrong. cheers | 17:17 |
| mzanetti | nic-doffay: also 2 other hints: | 17:17 |
| mzanetti | nic-doffay: it's better to click on the icon instead of the mousearea. because the user will click on the icon too. so you will catch the case if the mousearea doesn't work for some reason | 17:17 |
| mzanetti | nic-doffay: and also make sure to restore the pageheader at the end of your test to not cause other tests to fail (collapse the overlay and hide the searchfield | 17:18 |
| nic-doffay | mzanetti, gotcha | 17:18 |
| === dandrader|afk is now known as dandrader | ||
| mterry | jenkins seems mad about some launcher api change? | 19:15 |
| greyback | mterry: there was an api change in unity-api, could be causing it. This needs to land to fix it: https://code.launchpad.net/~mzanetti/unity8/launcher-appmanager/+merge/183837 | 19:21 |
| mterry | boiko, heyo! I was just thinking about the phone again. Is there a bug I can watch for progress on qml-ification? | 19:24 |
| mterry | (for the benefit of the greeter integrating the dialer) | 19:25 |
| === dandrader is now known as dandrader|afk | ||
| * greyback eod | 19:45 | |
| === dandrader|afk is now known as dandrader | ||
| fajung1 | how do style a toolbar GTK_STYLE_CLASS_PRIMARY_TOOLBAR in Qt 5.1 ? | 20:07 |
| mhall119 | it would be nice if, in addition to Unity getting the "average" color of a wallpaper, it could also identify a "highlight" color to replace the orange we use | 21:01 |
| mhall119 | or at the very least, a way of setting it manually | 21:01 |
| Daekdroom | mhall119, would that fit the icon theme? | 21:03 |
| Daekdroom | The orange window close button is an image as well. | 21:03 |
| mhall119 | Daekdroom: looks red to me | 21:05 |
| Daekdroom | I think how it has a color that is not monochrome-ish is the point. | 21:06 |
| Daekdroom | (also, that depends on your monitor calibration and perception) | 21:06 |
| boiko | mterry: hmm, there is no bug to track that one, let me create one | 21:13 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!