| === wedgwood is now known as Guest58173 | ||
| wallyworld_ | davecheney: do you know how to get the magic gobbledegook to put into the dependencies.csv file for a new goose revision? | 02:40 |
|---|---|---|
| wallyworld_ | nevermind, found it | 02:45 |
| === wedgwood is now known as Guest92845 | ||
| davecheney | wallyworld_: that deps file doesn't do anyting | 03:03 |
| davecheney | you know that right ? | 03:03 |
| davecheney | nothing consumes it | 03:03 |
| davecheney | so we can't tell if it is wrong | 03:04 |
| wallyworld_ | i think the bot uses it? | 03:04 |
| davecheney | nope | 03:04 |
| davecheney | i recommend deleting the file until there is something that can consume it | 03:04 |
| wallyworld_ | hmmm. i'll ask at the standup later today | 03:04 |
| davecheney | kk | 03:05 |
| === ChanServ changed the topic of #juju-dev to: https://juju.ubuntu.com | On-call reviewer: - | Bugs: 7 Critical, 94 High - https://bugs.launchpad.net/juju-core/ | ||
| wallyworld_ | fwereade: i've been having a lot of issues with the bot today. io timeouts on RelationUnitSuite.TestProReqWatchScope and RelationUnitSuite.TestContainerWatchScope. 2 of my branches landed ok. the tests pass locally. one one bot run, a test setup also timed out. have you seen this at all before? | 08:02 |
| fwereade | wallyworld_, hmm, no, I have not... *but* I reinstated those tests only a few days ago, after they got dropped accidentally, and dimitern then modified them just yesterday | 08:03 |
| fwereade | dimitern, can I ask you to take a quick look please? | 08:03 |
| wallyworld_ | strange that my first 2 branches landed, and the tird failed | 08:03 |
| wallyworld_ | third | 08:03 |
| fwereade | I will be out for houses for, hopefully, the last time today | 08:03 |
| wallyworld_ | np. i'm about to have dinner soon | 08:04 |
| dimitern | fwereade: will look | 08:07 |
| TheMue | fwereade: one short question regarding the result of ServiceGet in case of defaults. if an option is set to default but this default is nil we currently return "value: nil". | 08:09 |
| TheMue | fwereade: if i remember it right we said that in this case we can omit the output of value. | 08:10 |
| TheMue | fwereade: am i right? (not sure anymore) | 08:10 |
| dimitern | wallyworld_: is it always the same test failing? | 08:11 |
| dimitern | ah, there are 2 of them | 08:12 |
| TheMue | fwereade: allready out? | 08:13 |
| wallyworld_ | dimitern: yeah, the same 2 | 08:13 |
| wallyworld_ | dimitern: https://pastebin.canonical.com/97052/ if it helps | 08:14 |
| dimitern | wallyworld_: it's strange that they didn't fail when I submitted my change | 08:17 |
| wallyworld_ | yeah, and they seem to pass locally for me too | 08:17 |
| dimitern | wallyworld_: and the bot wasn't under load presumably | 08:17 |
| wallyworld_ | don't think so | 08:17 |
| wallyworld_ | i guess we can wait till the next bot run and see what happens | 08:17 |
| dimitern | yeah | 08:17 |
| dimitern | it's something to do with the dummy provider I think | 08:18 |
| dimitern | yay i just got my Clean Code book | 08:20 |
| dimitern | wallyworld_: I have no clue what could have gotten wrong :/ | 08:23 |
| wallyworld_ | thanks for looking, i was hoping maybe something would jump out | 08:23 |
| dimitern | there's no specific timeout that could've been triggered there | 08:24 |
| dimitern | it's just a state call | 08:24 |
| dimitern | mgz: are you the OCR today? | 09:05 |
| dimitern | https://codereview.appspot.com/13249050/ | 09:06 |
| dimitern | i'd like a review on that if anyone's available | 09:06 |
| TheMue | looking | 09:14 |
| TheMue | dimitern: you've got a review | 09:19 |
| dimitern | TheMue: cheers! | 09:22 |
| raywang | hi, anyone knows how to change juju gui's admin password? | 09:27 |
| TheMue | raywang: did you already asked in #juju-gui? i can't help, sorry. | 09:27 |
| raywang | i see, thanks TheMue | 09:28 |
| frankban | raywang: the password is the admin-secret in your environments.yaml. AFAIK there is no way to change that after the environment is bootstrapped. | 09:29 |
| raywang | frankban, well, user sometimes need to change the password then. it's necessary to have this functionality :) | 09:30 |
| frankban | raywang: improvements on the auth machinery are in progress, and eventually it will be possible to do that, but for now you can change the admin secret only before you create the environment | 09:34 |
| raywang | frankban, understood, thanks for the information :) | 09:36 |
| frankban | raywang: welcome | 09:36 |
| dimitern | TheMue: https://codereview.appspot.com/13269051 - this should fix the tests failing only on the bot and preventing stuff from landing | 10:23 |
| TheMue | dimitern: taking a look | 10:25 |
| TheMue | dimitern: those two calls lead to the failing? | 10:26 |
| dimitern | TheMue: yeah - see https://pastebin.canonical.com/97052/ | 10:26 |
| dimitern | TheMue: I hope this should fix the issue, if not we'll look for other things | 10:27 |
| TheMue | dimitern: interesting, it dislikes the connection to mongo in that moment | 10:28 |
| dimitern | TheMue: it's really weird | 10:28 |
| dimitern | TheMue: but since I added these asserts recently, removing them shouldn't harm anything | 10:28 |
| TheMue | dimitern: yep, just lgtm'ed, give it a try | 10:29 |
| dimitern | TheMue: cheers | 10:29 |
| dimitern | it didn't work :( | 10:42 |
| TheMue | dimitern: still fails, yes | 10:42 |
| TheMue | dimitern: just took a look at the result | 10:42 |
| dimitern | TheMue: I still have no idea why that happens | 10:42 |
| dimitern | TheMue, natefinch, fwereade,mgz, wallyworld_: standup | 10:45 |
| natefinch | fyi the standup link is different from before (I had the old one bookmarked) | 10:47 |
| natefinch | fwereade, mgz ^^ | 10:52 |
| mgz | ah, doh, forgot about the time move | 11:08 |
| natefinch | heh, figured | 11:12 |
| dimitern | hmm some things were missing and had to be reconfigured after the bot machine reboot | 11:13 |
| dimitern | like the crontab job | 11:14 |
| dimitern | and it appears the golang version got updated from 1.1.1 to 1.1.2 so I had to wipe out the linux_amd64 object files | 11:14 |
| dimitern | seems to be working .. for now | 11:14 |
| mgz | hm... wonder how we'd cope with the updagrade in a less manual fashion | 11:15 |
| dimitern | easy - put a rc.d script that does these steps on boot | 11:16 |
| mgz | that seems sane | 11:16 |
| dimitern | but in fact the charm should do that in a hook when it starts | 11:16 |
| * dimitern fingers crossed.. tests almost done | 11:20 | |
| dimitern | :( nope, still the same failure | 11:22 |
| TheMue | weird | 11:36 |
| dimitern | so, an update - tried downgrading go to 1.1.1 on the bot - the two tests stil fail, so I reverted back the go version to 1.1.2 from the archive and I'm proposing this change, which skips these two tests; tried manually on the bot - tests pass | 12:17 |
| dimitern | proposing now and will sent the link shortly | 12:17 |
| dimitern | https://codereview.appspot.com/13487044 | 12:21 |
| dimitern | can someone lgtm that so I can land it | 12:21 |
| dimitern | mgz, TheMue: ^^ | 12:22 |
| mgz | looking | 12:23 |
| mgz | dimitern, have you files a bug? | 12:24 |
| dimitern | mgz: no | 12:24 |
| dimitern | mgz: will do | 12:24 |
| dimitern | added bug 1221705 | 12:29 |
| _mup_ | Bug #1221705: relationunit_test.go: 2 tests fail only on the bot <juju-core:Confirmed> <https://launchpad.net/bugs/1221705> | 12:29 |
| dimitern | \o/ !! it landed | 12:39 |
| dimitern | the bot should be good again | 12:40 |
| mgz | well played dimitern :) | 12:40 |
| TheMue | +1, super | 12:40 |
| dimitern | well, I haven't really fixed the problem, but we have carte blanche for now | 12:40 |
| * TheMue just made something to eat and now has lunch beside the computer | 12:41 | |
| dimitern | wallyworld_: your last branch should be good to land | 12:41 |
| === _mup__ is now known as _mup_ | ||
| === Guest92845 is now known as mew | ||
| === mew is now known as wedgwood | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!