/srv/irclogs.ubuntu.com/2013/09/10/#juju-gui.txt

rick_h_morning huwshimi 00:46
huwshimirick_h_: Hey!00:46
rick_h_huwshimi: glad you made it back safe and sound00:47
huwshimirick_h_: Thanks. Me too!00:47
huwshimirick_h_: Your trip went ok?00:47
rick_h_huwshimi: yea, was actually really nice. Had an empty seat next to me that I split with the guy 2 seats over00:48
rick_h_huwshimi: so was nice to have more leg room and such00:48
huwshimirick_h_: Nice, I had the same thing :)00:48
rick_h_woot!00:48
huwshimiYeah00:48
=== TheRealMue is now known as TheMue
hatchmorning12:01
rick_h_morning12:01
hatchI'm going to try and keep this new starting hour12:03
rick_h_lol, good luck!12:03
hatchhaha thanks I might need it12:04
hatchhmm huw is saying that trunk is broken12:05
hatchoh and rick my fitbit stopped working again lol12:06
rick_h_yea, I can't dupe the trunk test failures. Tried normal and make clean-all12:09
rick_h_hatch: and :P on the fitbit12:09
=== gary_poster|away is now known as gary_poster
hatchrick_h_: so any luck on the toggles?12:22
rick_h_hatch: yea, a little bit. I've got to get through dealing with the conflict ux with the multiple fields and then some tests and such12:23
rick_h_and get a formatter in there for the true/false to True/False12:23
hatchuse css12:24
rick_h_ah, good call on that. 12:24
hatchtext-transform: capitalize12:24
hatchI think that's it12:24
rick_h_yea12:24
hatchI find it irritating that my cell phone internet is like 3x the speed of my home internet :)12:51
hatchI can't wait to get fiber12:51
hatchsame price, 2x the speed12:52
bacyeah, me neither.  oh, wait, that'll never, ever happen12:52
hatchlol12:52
bachey benji, you have a moment to guichat?12:52
benjibac: sure, one sec, let me get my camera hooked up12:53
gary_posterheads up to jujugui world: I'm looking pretty carefully at the databinding code, particularly in conflict resolution.  if anyone is tempted to work around there, please lemme know.13:00
rick_h_gary_poster: ok, I'm in there currently, but doing little things atm. 13:01
gary_postercool rick_h_ 13:01
rick_h_hatch: want to chat when you get a sec please13:01
hatchgary_poster: glad you are - we have been looking into refactoring that for a while13:01
hatchits scope has.....changed :)13:01
gary_postercool hatch.  I'm not trying to do a heavy refactor, just trying to get a number of edge-ish cases working.13:01
rick_h_hatch: got a sec?13:02
=== marcoceppi_ is now known as marcoceppi
bachi gary_poster, can you join benji and me in guichat?13:04
gary_posterok bac13:04
hatchrick_h_: yup guichat?13:05
rick_h_hatch: it's busy, will send invite13:05
hatchcool13:05
hatchwe should almost make a guichat2 :)13:05
sinzuiHoly fsck! I have a crippled computer13:09
sinzuiThe update this morning borked my keyboard. I just spent an hour trying to get capital letters working.13:10
sinzuiEverytime I pressed shift, the menus opened. I hacked dconf and restarted. Then every time I pressed super the menus started13:11
sinzuiopening13:11
sinzuiI suspect I am on xmir and it doesn't respect Xmodmap13:12
rick_h_hatch: so....I could bind the event in the viewlet render call ... maybe ... just sayin13:15
hatchlol no! becuase then there is no way to clean it up :)13:16
hatchfight the pain13:16
rick_h_ah $#@$@#$@#13:16
hatchfight the pain!13:16
* rick_h_ goes back to swearing at things13:16
rick_h_hatch: but viewlets have a destroy stub and it gets called on filling slot?13:19
rick_h_hatch: and on the viewlet manager destructor13:20
rick_h_hatch: so I can bind in render and add cleanup to a custom destory function in the viewlet def?13:20
hatchoh I suppose you 'could' find a way13:20
hatchdont' really see what that gets you though13:20
hatchit really adds more complexity because now there would be two places events are being attached13:20
rick_h_hatch: yea, a 'right' place and a 'wrong' place and it's easier to test the viewlet stand alone13:21
rick_h_hatch: ignore me...carry on. Thanks for the tip13:21
hatchI dont' think so because the viewlet is only supposed to be a configuration13:21
hatch:)13:21
rick_h_it's not, too bad, move along. :)13:22
hatchrm -rf rick_h13:22
hatchmoved along13:22
hatch:P13:22
hatchoh hey it's the apple conference today13:24
hatchhmm test fails....looks at tests....test shouldn't have passed before....oops13:26
hatch:)13:26
hatchI wish when I walked into my room it would turn off email and G+ notifications on my phonhe13:30
hatchroom being office13:30
rick_h_hatch: getting there. With the bluetooth unlock/safe zones the ground work is there to start building bt based profiles. 13:30
rick_h_hatch: basically need a BT target on your desk that if it's attached it silences events down a notch13:31
hatchhmm13:31
* hatch quickly files patents13:31
* hatch quickly learns Java and writes android app13:32
* hatch retires into obscurity after selling millions13:32
MakyoThat was fast.13:44
hatchyeah I'm a pro like that13:46
hatchoh crap I was supposed to be in obscurity13:46
* hatch goes obscure again13:46
hatchbtw- it feels like fall here.....*sqweee* winter is coming!13:47
rick_h_ugh, high is supposed to hit 35.5C today (96F)13:48
* rick_h_ is not happy13:48
rick_h_today/tomorrow, then I get fall back.13:48
hatchyikes!!13:49
MakyoYeah, it's delightfully rainy and cool here.  Brought back a bit of the weather.13:49
hatchOO today is looking like a good kiteboarding day13:49
hatch*caugh caugh*13:49
* hatch isn't feeling good13:49
hatch*caugh caugh*13:49
jcsackettrick_h_: it always shocks me when you northerners have a hotter day than us.13:55
rick_h_jcsackett: and makes me sad :(13:56
hatchrick_h_: see #3 http://www.healthycomputing.com/office/setup/monitor/ (I think it was you and I discussing this)13:56
rick_h_hatch: yea, with huw13:56
rick_h_hatch: cool, yea I'm checking mine and that's about right13:56
hatchyeah mine is a little high...maybe 1" but thats because it's too damn big for the desk and I can't get it any lower13:57
hatchlol13:57
hatchrick_h_: oh there is an exception ""Exception: If you use a large monitor (20" or larger), position your monitor so that the top of the viewing area is about 3" above eye level.""13:58
hatchhehe 20" or larger is a 'large monitor'13:58
rick_h_hatch: https://www.dropbox.com/s/sj5ayprdxsj6b68/2013-09-10%2009.57.39.jpg is with my phone camera right about eye level13:59
rick_h_oh hmm, maybe I need to move them up a bit, though these are only 21"ers13:59
* hatch hates you and your setup13:59
hatchI mostly hate it because I can't do it14:02
hatchlol14:02
rick_h_it's ok, I'm never happy with it. Always something else. Trying to stop here and be happy14:02
hatchisn't that the western way?14:03
hatchwe are never happy with what we have?14:03
hatchlol14:03
rick_h_guess so, but I realize it and get annoyed with myself over it.14:03
hatchtruth!14:03
hatchmaybe that's why I keep cell phones for 3 years14:04
hatchto try and prove to myself I'm not like that lol14:04
jcsackettorangesquad: i resolved my lp-propose goofiness. can i get a review of https://code.launchpad.net/~jcsackett/charmworld/review-queue-metrics/+merge/184785 ?14:07
jcsackettfeels good to be using lp-propose again, honestly.14:07
sinzuifreak14:08
abentleyjcsackett: aww, you're so sweet.14:08
jcsackettabentley: :-P14:08
abentleyjcsackett: looking.14:08
jcsackettabentley: thanks.14:08
jcsackettsinzui: lp-propose: a few seconds. lbox propose -cr: go make coffee.14:09
sinzuijcsackett, IRC does not properly convey my sarcasm 14:10
hatchjcsackett: you just hate lbox because your tests always fail :P14:10
sinzuibugger. I still have a broken keyboard and now I cannot see out of me left eye.14:11
jcsacketthatch: aaah, is that why you so frequently forgo new tests in your branch? :-P14:11
hatchrofl14:11
rick_h_oooh, burnnnnn14:11
hatchyeah it stings a little14:12
jcsackettlemme get you some lidocaine for that.14:12
benjibac: Huw's follow-up branch has landed.14:19
bacbenji: thanks14:19
abentleysinzui: My computer is trying to protect me from Saucy.  Upgrade-manager keeps dying with "Real-time signal 0".14:38
sinzuiouch14:39
abentleyjcsackett: Juju gui bot is me.  Doh.14:39
sinzuiMaybe it knows keyboards are screwed.14:39
jcsackettabentley: dig, thanks, and good points all.14:40
sinzuiThe keyboard options to configure keys is missing in saucy. The documentation still described the old way to get to the settings. I found some setting in dconf, but I am clueless about writing the gnome codes by hand14:40
bacbenji: it looks like you or huw fixed the readme width for charms but not bundles.14:42
benjibac: arg!  I should have remembered that.  Yeah, he only did the one.14:42
benjibac: I'll self-review a branch that fixes that right now.14:42
bacbenji: cool14:43
arosalesMakyo, gary_poster: hello, did you have any getting started with the GUI docs that evilnickveitch could include in the juju documentation?14:43
bacbenji: and he went back to 9 not 8.  i guess that was intentional14:43
Makyoarosales, I have a branch started, but not completed.14:43
benjibac: it was; because 8 causes unwanted line wrapping; 9 does too, when font size is increased14:44
gary_posterarosales, was encouraging Makyo to get that out to you, though we are behind on inspector so I'm prioritizing that now.  hopefully he can get some time for it later this week, yeah, Makyo?14:44
arosalesgary_poster, Makyo: thanks or the update. No rush, just wanted to follow up.14:45
gary_postercool, thanks arosales 14:45
Makyogary_poster, arosales I'm on swap Wed-Fri, but will see what I can do tonight.14:47
gary_posterMakyo, oh right!  sorry.  Next week then. :-)14:47
arosalesgary_poster, no worries if it lands next week14:48
arosalessorry14:48
arosalesMakyo, no worries if it lands next week14:48
gary_poster:-)14:49
hatchso close to getting all of these tests fixed14:50
hatchfixing tests after refactoring is making me dislike agile14:50
hatchagile this! *hulk smash*14:50
* sinzui restarts to verify he has beatdown mir+gnome+unity14:52
hatchman I friggen love databinding14:58
luca__gary_poster: do you need the inspector lists that you created last week?15:05
gary_posterluca__, no thank you, took a photo15:06
luca__gary_poster: ok15:06
adeuringbac, benji, abentley: could one of you have a look at this MP: https://code.launchpad.net/~adeuring/charmworld/fixed-interfaces-mapping/+merge/184805 ?15:13
benjiadeuring: I'll take a look15:13
rick_h_hatch: guichat please?15:19
hatchsure15:20
bacbenji: staging has been updated to r39215:25
benjicool15:25
bacbenji: go here: http://staging.jujucharms.com/search?search_text=precise  , a search for 'precise'.  marvel at the first hit.15:36
benjihuh15:36
benjibac: it is because the description of one of the config strings includes the word "precise"15:38
bacok, i thought i looked there15:38
benjisuch are the vagaries of full text search15:38
bacbenji: staging looks good to me.  i'm going to request production update to r39215:46
benjik15:47
benjiadeuring: your branch looks good to me15:49
adeuringbenthanks15:49
adeuringbenji: thanks15:49
gary_posterjujugui call in 915:52
gary_posterjujugui call in 115:59
bacsinzui: when i create an RT i get an error message (Couldn't load or create user: Must specify 'Name' attribute)  the RT gets created, though.  do you know what might be wrong?16:15
baci put 'bac' as requestor and it shows that as the owner16:15
* bac hates rt.16:16
sinzuibac, I think you need to provide your email address16:16
bacwill try next time16:16
sinzuibac, I sometimes forget requester. It has never stopped webops.16:17
abentleysinzui: I've updated the environments.yaml so that juju doesn't need novarc to be sourced.  I've also added a command, "jnova", that uses the settings from environments.yaml to run "nova".16:41
sinzuifab16:42
abentleysinzui: That means that "juju switch" is all you need, whether you're switching from one region to another or one set of user credentials to another.16:43
* sinzui pulls16:44
hatchjujugui: requesting two reviews and a large QA on https://codereview.appspot.com/13373050/ QA will need to be someone with a go env setup.... rick_h_ ;)17:04
rick_h_hatch: k, will be a few 17:09
hatchrick_h_: yeah no rush it's a big one17:09
hatchjujugui anyone else sitting on reviews they need?17:10
gary_posternot i, but thank you17:11
=== schwuk is now known as schwuk_away
hatchoh and if anyone doing my reviews wants a walk though I'll be more than happy to help :)17:17
hatchbcsaller: if you have time I'd love it if you could review my branch17:24
hatchgary_poster: I need to wait for that branch to be reviewed/landed before I work on the follow-ups is there another card you would like me to work on in the mean time?17:28
gary_posterlooking17:29
gary_posterhatch, what was "ghost save functionality," do you remember?17:30
hatchyeah, it doesn't do anything17:30
hatchit just closes the inspector17:30
bcsallerhatch: I'll start on it in a minute, I've seen parts of this before so that helps :)17:30
hatchat least that's what it 'was' not sure if that's still valid17:30
hatchbcsaller: awesome thanks :)17:30
gary_posterhatch, yeah, good enough for now.  it is "saved" in that you can open it up and see it again.  I am not keen on needing to use env annotations to make these shared, at least for now.  maybe later.  However...17:31
gary_posterhatch, luca says that MS wants us to move "expose" from the config page to the front "destroy" section17:31
gary_posterI think it is on newer visuals, maybe?17:32
gary_posterI wasn't quite sure how to do that on the face of it17:32
gary_posterbut maybe you can whip it out quickly?  17:32
hatchthat can't be done until after rick_h_ is done with his branch because he modifies that code17:32
hatchso there will be huge conflicts17:32
rick_h_hatch: well do me a favor, I'm setting up a MP so I can go through the stuff changed and get tests updated. If you can pull/QA that'd be helpful17:33
hatchsure, what's the branch?17:33
rick_h_hatch: lp:~rharding/juju-gui/update-conflict-ux17:34
hatchmoving expose to the destroy section sounds very odd to me, I think I'll need to see these new designs17:34
hatchrick_h_: cool, on it17:34
hatchdoes this have trunk merged in?17:34
rick_h_hatch: hmm, not today I guess. /me goes to do that 17:34
rick_h_hatch: merged and pushed17:35
hatchwoah 64bit chip in the new iphone17:36
hatchrick_h_: thanks17:37
hatchrick_h_: so is the expose section supposed to have True/False ?17:59
hatchit looks odd to me17:59
rick_h_hatch: yea, I went back and forth. When you leave that out, it looks strange in two lines18:00
rick_h_hatch: and I figured I'd make it consistent and we can update with UX input once it hits coming soon18:00
hatchand in the ghost - 'Use the default configuration?' has that as well18:00
hatchand when it's checked(true) I can still toggle the debug checkbox18:01
hatchthat checkbox needs to be disabled18:01
rick_h_hatch: yea, consistent design to start, make it inconsistent once told to :/18:01
rick_h_hatch: yea, finding that in tests right now, adjusting18:01
rick_h_the disabled part18:01
* gary_poster CHEERS that prototype now actually fixes all the things he wanted it to fix. YAAS!18:02
hatchthe 'import config file' button looks disabled and doesn't turn the cursor into a pointer (not sure if your branch or something else in trunk)18:02
gary_posterNow for a few branches...18:02
hatchw00t w00t18:02
gary_posterprototype is 493 line diff, so hopefully won't be too bad to actually get out there...18:02
hatchI still donlt like these true/false things - I know they aren't your fault rick_h_ but you're the only one around I can complain to right now :P18:03
rick_h_hatch: :P well I want to get it up in front of UX folks and get feedback. Wouldn't be the first time design needed tweaking18:03
rick_h_yay! existing tests now pass. Time to write the new ones18:04
hatchI mentioned it in the mockups that there is no 'division' because there is no large white block...they ignored me :'(18:04
hatchWAHHHHHH18:04
rick_h_hah, no one loves hatch...he's going to eat some worms18:04
hatchlol is that a thing down there?18:04
rick_h_kids thing "No body loves me, everybody hates me, I'm going to eat some worms..." Wasn't it a book or something? /me doesn't recall18:05
hatchmaybe some crazy american book18:05
rick_h_hatch: ok, updated with disabled on the field18:05
rick_h_overall though QA is pretty clean?18:06
hatchyup, just checking conflict ux now18:06
hatchalso didn't qa in IE yet18:06
hatchbut i'll do that once the full thing langs18:06
hatchlands18:06
rick_h_k, all good. Sure it'll need it with review18:06
rick_h_but good to have another set of eyes on it18:06
rick_h_hatch: but if you need my stuff you can grab this branch to start with18:06
rick_h_I'll have tests today and probably have to get review/qa tomorrow.18:07
hatchI have no idea what i'm supposed to do with this conflict18:07
hatchI see a ! then I click on it and....?18:07
hatchit just goes away18:07
rick_h_yea, there's nothing to do. It's just a 'notice'18:07
rick_h_for a checkbox there's no choice to make, do you want to change it or not?18:07
rick_h_if someone changes behind you, we just say 'hey, this was changed while you're working on it'18:08
hatchyeah I guess...but that ! doesn't really mean anything18:08
hatchmaybe we need a tooltip ?18:08
rick_h_well once gary_poster's lands it won't show it when the values are equal18:08
hatch"this means there is a conflict"18:08
rick_h_so the *only* time you should see it is: "1 - you change from false to true, 2 - someone else sets it to true, 3- someone else sets it to false and saves, 4 - you get a conflict notice"18:09
hatchright so it's very rare so it's even more important to have some help text18:09
rick_h_bah, and we're offially over 90F...I hate mother nature18:09
* hatch thinks you should probably hate humans who probably contributed to making it so hot ;)18:10
benjigary_poster/bac: I've been trying to fight through a headache, but I'm going to have to go lie down now18:10
gary_posterhatch, agree, and my branch makes even more things automatic, but I think that needs to be post-release.  Could be wrong.18:10
gary_posterbenji, ok, feel better18:10
hatchgary_poster: yeah we can work towards it for sure - just as long as design also see's the issue :D18:11
gary_posterhatch, I think they will when we show it to them18:11
hatchrick_h_: there are some styling issues with the input conflict ux....probably not your branch though18:12
hatchthe checkmark spills out of the dropdown18:12
rick_h_hatch: ok, good to know. I didn't think I touched that but will double check on comingsoon18:12
rick_h_hatch: if you can check/file a bug would be appreciated18:12
hatchcan do!18:13
hatchrick_h_: yah it's ugly there too18:14
hatch:D18:14
rick_h_thank goodness18:14
* rick_h_ wants to get this branch wrapped up, he'll never be able to look at checkboxes again after the last two weeks18:14
bachi gary_poster, regarding upgrading jujucharms.com, for juju-gui the latest tarball is 0.9.0.  we want to upgrade to it.  do we need a new version of the charm as well, i.e. r76?18:15
gary_posterhi bac.  no, we do not (though +1 on verifying that the old charm is unnecessary).18:15
bacgary_poster: did you see the call for mentors for the sparkcon "learn to code" event this weekend?18:15
gary_posterbac, no18:15
hatchgary_poster: you never did get back to me about a ticket to tackle :)18:15
bacgary_poster: trizpug mailing list.  looks like fun, maybe.18:16
gary_posterhatch, I did too!  you just didn't like any of my suggestions :-P18:16
hatchlol!18:16
hatchit's not that I didn't LIKE them....18:16
gary_posterheh18:16
hatchdo we have a design for moving the expose button?18:17
gary_posterI think so.  looking18:17
hatchI really can't do anything about it until rick's branch lands but I'd like to take a peek18:17
gary_posterhatch, you could work from his branch.  that's what I sometimes do.  Anyway, here, look at the second inspector from the top left here: https://docs.google.com/a/canonical.com/file/d/0B7XG_QBXNwY1YWJqdXg1QzdLYkU/edit?usp=sharing18:20
hatchmaybe his branch will fail review :P18:20
hatchlooking18:20
gary_poster"expose" is right above "destroy"18:20
hatchohhh I see18:21
hatchit's kind of hidden and out of the way18:21
hatchmaybe that's good?18:21
bachatch: you think we can build a MAAS cluster of 64bit iphones as a compute farm?18:21
hatchwould people want to toggle it?18:22
rick_h_yea, you don't normally expose that many services18:22
hatchbac: a very power efficient compute farm? :D18:22
bacgary_poster: rts 64505 and 64512 logged for upgrading manage.jujucharms.com  and jujucharms.com.  waiting on webops.18:23
gary_posterbac awesome thank you18:23
bachatch: my current phone is slowly losing functionality so i'm in the market for a replacement18:23
hatchbac: I'd highly recommend the HTC One18:24
hatchpicked one up 2 weeks ago and loving it18:24
rick_h_I'm waiting for the nexus 5 next month, one is good, the new motox is cool, but limited availability right now18:24
hatchrick_h_: I'd remove 'True' from the ghost config template (it should be set by the databinding)18:24
hatchrick_h_: 5" is just too big - I do like how the iphone is a 4" but I haven't really found the One to feel that large for some reason18:25
rick_h_hatch: hmm, that wasn't there. 18:25
rick_h_hatch: well the dimentiions of the N5 are smaller than the N4 with a larger screen18:25
hatchIm just doing a psudo code review to see if I want to work from your branch :P18:25
hatchoh really? I thought it was mirrored off of that new Sony phone18:25
rick_h_hatch: LG thing, but if the fcc filings are correct, then yea. less bezel ftw18:26
hatchI'm confused by the requirement for skipconflictux on elements that don't have conflict ux markup18:27
hatchthe expose template18:27
rick_h_hatch: because they've been set/unset/etc 5 times in getting this branch worked out18:28
rick_h_hatch: but things like marking 'changed' also apply18:28
rick_h_and the ! indicator isn't part of the conflict resovle html18:28
rick_h_so all elements have the potential for conflict-ux18:28
rick_h_hatch: the True on the ghost is for the default config box, that's not data bound18:29
rick_h_how would data binding make me not need that18:29
rick_h_?18:29
hatchoh woops18:29
bachey benji, do you have all of the fiddly bits necessary to access staging.jujucharms.com?18:31
bacbenji: i mean to manage via juju18:31
hatchrick_h_: do change events not bubble?18:34
rick_h_don't know for sure, I'd imagine no since it's tied to a specific input18:35
hatchall events are :)18:35
rick_h_http://stackoverflow.com/questions/265074/does-the-onchange-event-propagate18:35
hatchhttps://developer.mozilla.org/en-US/docs/Web/Reference/Events/change18:35
hatchaccording to this 'yes'18:35
hatchso if it truely does then you can put that event listener in the environment.js file and remove all of that event stuff in the viewlet manager18:37
rick_h_so http://jsfiddle.net/nfakc/18/ seems to work and bubble in IE1018:40
hatchawesome so you can remove all of that event attach stuff18:41
hatchmy guess - at one point it didn't bubble and noone has gone back and updated those old docs18:42
hatchs/docs/questions18:42
rick_h_so seems to buble in all three. Will look at it though the point was to stop putting event stuff in environment.js as it's beyond evil. I can use a delegate or something though to update it as one event vs each chcekbox18:42
hatchno no no no, when we move the event stuff it'll be done properly in the viewlet manager, not just one event tacked on separate from the rest18:43
rick_h_why would the viewlet manager do it? Each viewlet needs to control wtf it does. I'm failing to see how moving the evil from one file to another file that's not the locatino of the code using it makes any sense at all18:44
hatchbecause the viewlet manager will parse an event config in each viewlet and attach it to the viewlets container18:44
rick_h_you create a ghost-inspector, it wants to watch for boolean inputs...so the event is there. 18:44
hatchwhen the viewlet is destroyed the manager will then go and clean those up18:44
rick_h_how many files do I have to have open to see wtf is going on. No wonder everyone hates events. They're not located next to the owner18:45
hatchthe event configuration will be moved from the environments.js file and split up into each viewlet18:46
rick_h_anyway, argument for another day. I need to get these tests going. I want to test the veiwlet and it's event handling properly without a viewlet manager, or environment, or anything else that needs a bunch of stuff. I should be able to hand a viewlet a container and model and test it. 18:46
hatchno because a viewlet is a configuration object18:46
hatchthat's it18:46
hatchso you can unit test the utility methods which are mixed in18:47
hatchand you can integration test the whole stack18:47
hatchit was designed that way to be very easy to test18:48
rick_h_except that it's not currently. The tests don't test the render method or any helpers because they need to go through a viewlet manager to figure out what's up. Then there's the pain of the viewlet manager needs to pull in all viewlets and there's interactions hidden in there. 18:49
hatchthat's because you're trying to write a unit test without a proper mockup18:50
hatchor you're writing an integration test and don't want to pull in everything18:51
hatchreally, it makes sense I promise :)18:51
rick_h_I understand what you're saying. And when you say "it's just a configuration object" I know it sounds light/easy. However, in practice, it's a mess. I know it'll get better with refactoring, but I don't understand why we're against events and callbacks responding to those events living in the viewlet itself. It's a mini-view without the YUI overhead. Syncing code between inspector.js, evironment.js, the template, the viewlet, an18:54
rick_h_the idea is great, in practice there's some love needed18:54
hatchbecause then you have to create an instance of the viewlet. if you want to unit test a method in a mixin....just pass the data into the method and test what comes out. That's what a unit test is18:55
hatchanything more is an integration test18:55
hatchthe real issue we have is that we don't have a proper mock structure which we can count on cross our test suite18:56
rick_h_the viewlet is doing sync with data binding, the template, change events. There's no such thing as unit testing this viewlet at this point. 18:56
hatchthat's an integration test18:57
hatchso write an integration test18:57
rick_h_hatch: and I don't disagree, but small localized integration tests I can count on to break are good things :)18:57
rick_h_right, but I don't want to integrate with every viewlet in the system18:57
hatchso you want an integration test that only integrates the things you want? :D18:58
rick_h_it's like a widget. You can unit test some bits, but for the most part, you've got to stick it on the page and fake the interactions to amke sure it behaves as you expect18:58
rick_h_it's an interactive structure. 18:58
rick_h_by its very nature18:58
hatchthat's right18:59
hatchI don't really see what the issue is here18:59
hatchif you want to write a unit test - put the method in a mixin18:59
hatchif you want to write an integration test....well that already works18:59
rick_h_so you want me to do some mixin for updating boolean input fields?19:00
rick_h_and move the event that's bound there to there?19:00
hatchthat's an integration test19:00
hatchthe input field needs the template, the databinding engine, viewlet manager, viewlet19:00
rick_h_hatch: no, it's in integration test that needs a render call and a single simulate call. 19:01
rick_h_it doesn't need data binding, it doesn't need the viewlet-manager19:01
hatchwell the events aren't in the viewlet config so you can't do that19:02
hatchyou need the manager to bind the events19:02
hatchthat's just how it works19:02
rick_h_I bind the event in the render() call. I don't need the manager for it at all19:02
rick_h_that's not how the current code works :)19:03
hatchyeah but that's wrong19:03
rick_h_lol19:03
rick_h_but it works and I don't have to bring in another monolilthic module of code to make sense of it all :)19:03
bacgary_poster: jujucharms.com is upgraded.  i'm not sure what the key differences are to verify.  it is up and running.19:03
gary_posterbac, thank you.  the two highlights are search autocomplete and IE support.19:04
hatchjust because you don't like the architecture of the system doesn't mean that you can just go and hulk smash things to make it work the way you expect19:04
hatchwe already know we need to put the event config objects in the viewlets19:04
rick_h_hatch: except you've agreed they need to change and the current system is flawed. If there's a better place I'm all for it. 19:04
hatchbut that will still need the manager to instantiate it19:04
bacgary_poster: autocomplete works.19:04
gary_postercool bac thanks.19:04
bacdon't have easy access to IE to test.  perhaps hatch can19:05
hatchyup I can19:05
rick_h_bac: I can pull it up, have IE open now19:05
bacthanks y'all19:05
hatchcool rick_h_ can do it because i'll have to boot up the laptop19:05
bacso have we made the site HiDPI friendly?  it looks amazingly sharp now19:06
hatchbac: well the svg's should be sharp but the rest is the same19:06
hatchactually19:06
rick_h_bac: looks good, just went through search/auto complete, deployed a couple, build/destroy a relationship19:06
hatchI think the only raster graphics we use are some icons19:06
rick_h_bac: let me know if there's anything else I need to check. 19:07
bacrick_h_: that should do it.  thanks19:07
hatchicons meaning UI stuff, not charm stuff19:07
rick_h_yea, the +, ^ v and such19:07
gary_posterrick_h_, hatch, I agree that we want to change the viewlet event approach for later, and I agree with hatch that we should not introduce a new approach now but stick with what we have, unless we have a specific branch that is about proposing a new approach.  Please don't intro a third approach we all have to find and keep track of as part of another unrelated task.  Does that seem reasonable rick_h_ or do you have s19:08
gary_posterome concerns, or maybe I misunderstand what you all are talking about?19:08
rick_h_gary_poster: working on it. I'm trying to get tests going and then will look back at it. 19:09
gary_postercool thanks rick_h_ 19:09
rick_h_gary_poster: I think you understand, I'm just being a bull headed fool about never adding an event to environment.js because it's horrible imo and hatch wants me to follow design  so we ended up going at it a bit :)19:10
hatchI like our.....discussions19:10
rick_h_and the tests sit and wait while we fill up irc19:10
gary_posterrick_h_, heh, ok cool.19:10
hatch:)19:10
hatchif I wanted to propose that the juju docs use local configuration as the default install who would I propose that to?19:11
hatch^ gary_poster ?19:11
rick_h_hatch: marco and evilnick19:11
gary_posterhatch, you could try evilnick.19:11
gary_posterat the least he'd be able to tell you who else you need to convince :-)19:12
hatchok cool will do - my idea is that local provider doesn't require you to set up an ec2 account just to try it out19:12
hatchI think I screwed up my juju install19:22
gary_posterhatch, btw, great task: review Huw's gui branch and land it. :-)19:22
hatchI get `error: flag provided but not defined --show` when I try and run `juju generate-config --show`19:23
hatch-v --version19:23
hatchno flags work :/19:23
rick_h_hatch: yea, what are you running? what's the --version?19:23
rick_h_oh, you can't run version?19:23
hatchrick_h_: I get that error19:23
hatchyeah19:23
rick_h_dpkg -l | grep juju19:23
hatchjuju, juju-0.7, juju-core19:24
rick_h_ok, so that's old19:24
hatchweird I JUST installed19:24
rick_h_hatch: from the ppa?19:25
rick_h_so I'm using sudo add-apt-repository  ppa:juju/devel19:25
hatchoh I used /stable19:25
rick_h_but there's also ppa:juju/stable19:25
hatchso I'll remove juju and juju-0.719:25
hatchand just leave core?19:25
rick_h_oh hmm, I thought 1.0 was in stable?19:25
hatchI thought I could have both installed19:25
rick_h_I've not messed with both. It seems messy and more trouble and I just abuse Makyo for my pyjuju qa19:26
hatchok so I'll remove the first two then19:26
MakyoMy setup is pyjuju installed from apt in /user/bin/juju and core installed in $GO_HOME via go install ./...19:26
MakyoFWIW19:26
hatchlooks like I'll have to remove and reinstall core as well19:27
hatchhmph nope still broken19:28
hatchwhat version of ubuntu is this...19:29
hatch12.0419:29
hatchcore supports 12.04 right?19:29
hatchoh well I'll get back to that later19:31
gary_posterhatch, I'd get a newer one.  raring or saucy.  we support precise as host19:31
* hatch really doesnt' want to upgrade his vm19:31
hatch:)19:31
gary_postermake another one :-)19:31
hatchguess I could make a new one19:31
hatchhaha19:31
gary_posteror clone19:31
hatchgary_poster: I can't seem to find huw's branch in my email19:32
hatchdo you know what its called?19:32
hatchI only have ones of his which are submitted19:33
gary_posterhatch https://code.launchpad.net/~huwshimi/juju-gui/inspector-style-merge19:33
hatchoh no lbox19:33
hatchthat would be why19:34
gary_posterhatch mentioned in his email with subject "Trunk broken - branch for review"19:34
hatchohhhhh right right woops19:34
hatchbcsaller: re your comment on object order - according to the spec the order of an object is not guaranteed19:35
hatchalthough I've never found that to be true19:35
hatch:)19:35
hatchbut that did require me to sort that list even though the values were there19:36
bcsallerhatch: I know that, but I actually thought deepEquals did a key oriented compare 19:36
hatchthat's what I thought too....but it made me change the order19:36
hatchbcsaller: did you want me to move that unit stuff into the init in this branch or a follow-up?19:40
bcsallerhatch: I think it will be a small delta, do you feel alright doing it now? It trims a few checks out of your branch19:40
hatchyeah I think you're right - it's the proper way to might as well do it now19:41
hatchbcsaller: also re your comment on the error split uglyness - you didn't have a better approach right? That was just a comment?19:42
bcsallerhatch: yeah, just indicating we need to follow up on that talk because this won't last in the real world19:43
hatchwell it'll last until they change it lol19:43
hatchso....probably next week :P19:43
hatch"oh we didn't like colons, so we switched to to pipes"19:43
hatch:P19:43
hatchgreat comments, I'll reply in the reviews but I'm pretty sure I'll be implementing all of the changes19:45
hatchoh poo a CI failure19:52
bacbenji, gary_poster: the charmworld api_search and the interesting, et al, lists all have bundles and charms intermingled, with the 'doctype' field specifying one from the other.  the search method called from site search box is the only one that separates the two.19:52
gary_posterbac I feel that's good enough for a start, thank you.  Do search results include match scores in case we want to join them?19:53
* hatch looks slyly at gary_poster....."was your branch QA'd in IE10?"19:54
gary_posterhatch, no I have no IE 10 here, sorry :-( problem?19:54
hatchyeah CI failed19:55
hatchlooks like we really need to require that IE QA19:55
bacgary_poster: it does not look like they do19:55
gary_posterhatch, we do, I just didn't follow it.  Though, I suspect that this is intermittent on the face of it: TestNotifications is not something I should have touched19:55
hatchahhh gotcha gotcha19:57
gary_posterI didn't follow it because I don't have it on this machine; I don't have it on this machine because I don't usually code that much any more; I don't code that much any more because it is not my main job; so the solution is that I should never code at all any more. :-)19:57
hatchrofl!!!19:57
hatchlove the justification19:57
gary_posterhatch, could you or rick_h_ give it a whirl on IE 10 for me and let me know how it goes?19:57
hatchyeah I can do it19:58
gary_posterty20:00
Makyojujugui A little branch in need of reviewing: https://codereview.appspot.com/13413045 Thanks in advance20:01
hatchgary_poster: I can't see what this things issue is, I'll refire it off again20:11
gary_posterhatch, oh, you duped?20:11
gary_posteroh, you mean, you didn't dupe20:11
hatchyeah it all works as expected20:11
gary_posterso you are going to see if it magically fixes itself20:11
gary_posterok cool thank you20:11
hatchyeah the sauce labs videos don't work anymore for whatever reason so I can't see exactly what's going on20:13
hatchbut it looks like the details pane didn't open20:13
hatchgary_poster: that functionality that you added was really cool though :)20:19
gary_posterglad you like it hatch :-) .  luca apparently had in mind all along20:20
hatchI wonder if they can do mockups in something that allows them to be functional20:20
hatchdidn't fireworks used to do that?20:21
hatchprobably needless though :)20:21
hatchthe new iphone sure has some specs...20:22
hatchugh phantomjs crashing all the time is really irritating20:35
hatchhmm huw's branch definitely has something wrong with it20:51
hatchit's not 'trunk' it's a merge or something20:51
hatchgary_poster: a re-fire of your branch's CI passed20:51
gary_posterhatch, 80% good. ;-)  thanks again20:52
hatchmust have been a lag in the host machine or something20:52
hatchmaybe we should be polling on every DOM query in selenium20:52
gary_posterhatch that sounds interesting...worth a friday card so you don't forget the idea?20:53
hatchoh looks like we already do that20:55
hatchwait_for_css_selector20:55
hatchtimeout is 1020:57
hatchso I'm assuming that's 10s which should be plenty20:57
huwshimiMorning23:00
hatchhey huwshimi23:02
hatchso I took a quick peek at your branch23:02
hatchand it's not trunk that has the issue23:02
hatchit appears to be a bad merge between it and your branch23:03
huwshimihatch: Oh really? I could reproduce the same thing on a clean trunk23:03
hatchhmm I couldn't but I could try again23:05
hatchok make and test-debug is running, i'll check back in a few and let you know23:05
huwshimihatch: It could be an environment issue (strange that that test might just stop working)...23:08
hatchso it's running the tests now23:08
hatchwell I could reproduce your failure with your branch23:09
hatchbut trunk passed just fine23:09
hatchyup and trunk passes with flying colours23:09
hatchso maybe delete your trunk branch and re-branch it23:09
hatchthen try on that23:09
huwshimihatch: Hmm... a fresh trunk from today passes just fine...23:11
huwshimiI'll try a merge into my branch and see what happens23:12
hatchyeah, and i Merged trunk into your branch - and after resolving the conflicts it still had the same failure23:12
hatchso there is definitely something off about your branch23:12
hatchwhich is why I was thinking it was a bad past merge23:12
hatchmaybe a conflict done wrong or something?23:12
huwshimiAh, I'll deal with these conflicts and see what's going on...23:12
hatchif you need some help ping me, I'll likely be around23:15
huwshimihatch: Yeah, seeing the same thing...23:21
huwshimihatch: Was there a reason you thought a bad merge might have broken it? I did touch the status bar, but not sure what I could have done to break that specific test...23:33
hatchhuwshimi: sorry no, just a twag23:34
hatchhuwshimi: so what that test failure is saying is that the width was never set23:45
hatchhuwshimi: ok I found your bug23:51
huwshimihatch: Well, I think I've fixed it, but only if the test was only passing due to the default resize flag being set to true23:52
hatchno it was working because of the node.attr being set that you removed23:52
hatchso the width and height were never being set23:53
hatchwhich if I remember was required for IE support23:53
huwshimihatch: Right, but if you set resize: false the test would have failed...23:53
hatchyeah23:53
hatchas it should I think23:53
hatchI am pretty sure that width is required....23:53
huwshimihatch: Oh well, either way it's fixed :)23:54
hatchtested in IE?23:55
hatchI think that's what the width was for23:55
huwshimihatch: I'll double check (It was working fine in IE when I QAd it without the width being set).23:56
hatchoh ok23:56
hatchI guess if it's not required then you can just delete that from the test :D23:57
huwshimihatch: Well, the difference being that when it's used we never call it without calling update() unlike this test...23:57
hatchahh23:58
huwshimi(and hence this test only passing previously because of the default resize value)23:59
hatchohh right right23:59

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!