=== chriadam|away is now known as chriadam | ||
cwayne | mhall119: ping | 00:13 |
---|---|---|
mhall119 | cwayne: pong | 00:17 |
cwayne | mhall119: does an app need to explictly set its background as Theme.Palette.normal.background to have it's background change when the default theme is changed? | 00:18 |
mhall119 | um.....I don't know | 00:18 |
mhall119 | Kaleo might | 00:18 |
imnichol | mhall119, since you're already here, and you know what you're talking about: is there documentation on using the camera in qml? | 00:19 |
mhall119 | imnichol: well, one out of two anyway :) | 00:19 |
mhall119 | imnichol: I haven't tried it, but the camera should be accessible using the Qt APIs | 00:20 |
mhall119 | http://qt-project.org/doc/qt-5.0/qtmultimedia/cameraoverview.html | 00:20 |
imnichol | And a follow-up, what's the keyword that I should search for if I'm trying to find the code for picking a picture that's already been taken on the device | 00:20 |
imnichol | Hah, thanks man | 00:20 |
imnichol | I feel like it was "image picker" or "gallery chooser" or something like that | 00:21 |
mhall119 | imnichol: for pictures already taken, you want to talk to kenvandine about his content-hub | 00:21 |
imnichol | "content-hub", gotcha | 00:21 |
mhall119 | pretty sure that was the name of it | 00:21 |
imnichol | Yeah it is | 00:21 |
imnichol | I remember now | 00:21 |
mhall119 | yeah, that'll let you get pictures even if they're outside of your app's security sandbox | 00:21 |
imnichol | Thank you very much dude | 00:21 |
mhall119 | np, happy hacking :) | 00:22 |
=== ondra is now known as ondra-afk | ||
mihir_ | Goodmorning :) | 05:37 |
vadi | I compiled my Qt app on Qt5 (installed from Qt's online installer) and there is no appmenu integration anymore. How can I get that back? | 07:29 |
dholbach | good morning | 07:45 |
nerochiaro | gusch: do you have time for a quick look at this ? https://code.launchpad.net/~amanzi-team/webapps-demo/webapps-demo-no-hud/+merge/184535 | 08:14 |
gusch | nerochiaro: ok | 08:14 |
nerochiaro | gusch: thanks | 08:14 |
gusch | nerochiaro: ah - that's the one, where I proposed to keep the "," for the webbrowser-app | 08:15 |
nerochiaro | gusch: oh :) right, doing it now. sorry | 08:15 |
nerochiaro | gusch: done | 08:17 |
gusch | nerochiaro: approved - jenkins will do the rest | 08:18 |
JamesTait | Good morning all, happy Swap Ideas Day! :-D | 08:21 |
nerochiaro | gusch: excellent | 08:22 |
nerochiaro | JamesTait: every morning i wonder, where do you find out what Weird Stuff Day is today ? | 08:23 |
JamesTait | nerochiaro: wikipedia and daysoftheyear.com, mostly. Various history sites as well, but only if the first two turn up nothing that piques my interest. | 08:25 |
nerochiaro | JamesTait: nice. thanks | 08:25 |
mardy | timp: hi! Not sure you are the right person to review this, but at least you should know who is: https://code.launchpad.net/~mardy/ubuntu-ui-toolkit/lp1221707/+merge/184513 | 08:34 |
mardy | bzoltan1: or you (hi!) :-) ^ | 08:35 |
timp | mardy: yes I could review it. | 08:57 |
timp | mardy: or zsombi | 08:57 |
mardy | timp: thanks either way :-) | 08:57 |
timp | mardy: ok. I'll check it later today | 08:58 |
mehow | shigar and a waffle ? | 09:38 |
mehow | http://www.youtube.com/watch?v=HXJefJOU5OE&noredirect=1 | 09:38 |
bzoltan1 | hello mardy! | 09:45 |
mardy | bzoltan1: hi! | 09:45 |
bzoltan1 | Pat told me that you might be good to join us :) and give some love to our QtCreator plugins | 09:46 |
mardy | bzoltan1: that is news to me, but if I can, I'll happily help | 09:50 |
bzoltan1 | mardy: Well :) maybe I should have talked to David first :) | 09:51 |
bzoltan1 | mardy: my dear fellow jppiiroinen quits us this month and so the QtC plugins will fall on my shoulder ... | 09:52 |
mardy | jppiiroinen: shame on you! ;-) | 09:54 |
mardy | bzoltan1: don't tell me you are unhappy to be back to coding :-) | 09:55 |
bzoltan1 | mardy: To be frank :) I did enjoy when i had to code C++ the plugin when jp was out for a month | 09:55 |
jppiiroinen | mardy :D | 10:09 |
nik90|Office | zsombi: do you happen to know Charles Kerr's email? I can email and check if he is still working on the notifications. I forgot to mention this in our email | 10:11 |
zsombi | nik90|Office I gave his email to you once already :) | 10:13 |
=== gusch is now known as gusch|lunch | ||
nik90|Office | zsombi: sorry, it is in my other laptop :P | 10:14 |
zsombi | nik90|Office emailed 2 U :) | 10:16 |
nik90|Office | zsombi: hehe thnx a lot :). I have added him as a contact now | 10:16 |
=== chriadam is now known as chriadam|away | ||
nerochiaro | gusch|lunch: i'm trying to build the gallery, but i get this error: http://pastebin.ubuntu.com/6087415/ (this is frrom trunk, on saucy) | 10:49 |
nerochiaro | any ideas ? | 10:49 |
=== gusch|lunch is now known as gusch | ||
gusch | nerochiaro: you need to install the content-hub | 10:53 |
nerochiaro | gusch: shouldn't it be a dependency ? | 10:54 |
nerochiaro | gusch: cmake doesn't complain about it being missin | 10:54 |
gusch | nerochiaro: libcontent-hub-dev is set as dependency | 10:54 |
nerochiaro | gusch: but cmake doesn't check for it. it should | 10:54 |
gusch | nerochiaro: yes, it should, but there is no proper file for it yet in content-hub | 10:55 |
nerochiaro | gusch: understood | 10:57 |
nerochiaro | gusch: and when trying to run ap tests on the desktop, do you know why ap is complaining that "ImportError: No module named ubuntuuitoolkit" | 11:00 |
nerochiaro | ? | 11:00 |
gusch | nerochiaro: what? the gallery c++ unit test you mean? | 11:01 |
nerochiaro | gusch: the galllery autopilot tests | 11:02 |
gusch | nerochiaro: let me check - but they worked a few days ago | 11:04 |
gusch | nerochiaro: works for me - strange message what's "ubuntuuitoolkit" supposed to be? | 11:08 |
nerochiaro | gusch: i think the sdk installs some python modules to help with writing tests that do stuff like revealing the toolbar | 11:09 |
nerochiaro | gusch: guess that for some reason i don't have that stuff installed here | 11:09 |
gusch | nerochiaro: ah - it's a python error ... | 11:10 |
nerochiaro | gusch: ok, found out what it was: ubuntu-ui-toolkit-autopilot package was missing | 11:10 |
gusch | nerochiaro: you need ubuntu-ui-toolkit-autopilot | 11:10 |
nerochiaro | gusch: :) | 11:10 |
=== MacSlow is now known as MacSlow|lunch | ||
=== nik90|Office is now known as nik90|Office|Lun | ||
nerochiaro | gusch: ok, this is quite weird. i have submitted this MR and the tests pass on desktop: https://code.launchpad.net/~amanzi-team/gallery-app/gallery-app-actions-api/+merge/184533 but obviously jenkins doesn't like this stuff and lots of tests fail there. any ideas ? the tests that fail don't seem very related to the changes i made | 11:21 |
gusch | nerochiaro: let me see - bzoltan had quite a lot of issues with gallery tests as well :( | 11:22 |
bzoltan | gusch: yes, we have an MR pending for similar reason, timp can tell | 11:23 |
gusch | nerochiaro: ^ | 11:24 |
nerochiaro | bzoltan: is anyone looking into these failures then ? | 11:28 |
nerochiaro | timp: ^ | 11:35 |
mefrio | hi guys is there anybody who can help me with a click package of my app? | 11:38 |
bzoltan | nerochiaro: check with the devs of those tests... that is what I try to do | 11:40 |
timp | nerochiaro: no, and I have the reverse problem. Gallery tests fail for me when I run it on device | 11:40 |
timp | nerochiaro gusch so I we have to fix these test issues together. I don't think someone else is looking into them. | 11:41 |
cwayne | Kaleo: hey, does an app have to explictly set its background as Theme.palette.normal.background in order to have it changed when the default theme is changed? | 11:42 |
nerochiaro | timp: gusch: i'm going to lunch. by the time i am back omer should be back too. hopefully he's not too busy and we can talk to him as well. i have a feeling we need a qa person to solve this mess. | 11:43 |
timp | nerochiaro, gusch test reports like this https://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/646/testReport/junit/gallery_app.tests.test_album_editor/TestAlbumEditor/test_add_photo_with_touch_/ are like chinese for me. I don't see what's wrong | 11:43 |
timp | nerochiaro: enjoy your meal, and about the mess I really wish to get it fixed today | 11:44 |
nerochiaro | timp: yeah, it fails to do something that it is expected by the test (open an album in this case). but there's no change i made that should prevent that from happening | 11:44 |
nerochiaro | timp: did you try to run the tests on trunk as well ? | 11:44 |
nerochiaro | timp: if not please have a go at that to see if they fail for you there too | 11:44 |
timp | nerochiaro: trunk of what? | 11:44 |
nerochiaro | timp: of gallery app ? | 11:44 |
nerochiaro | that's what we're talking about no ? | 11:45 |
timp | nerochiaro: I tried on the latest image with updated packages (apt-get update&&upgrade), and it fails, without installing custom packages | 11:45 |
gusch | timp: this seems to be the issue: file:///usr/lib/arm-linux-gnueabihf/qt5/qml/Ubuntu/Components/Page.qml:155: TypeError: Cannot read property 'actionManager' of null | 11:45 |
timp | nerochiaro: yes, we are. I also like to test my own UITK packages but I didn't get to it because the tests fail even with the released version. | 11:45 |
nerochiaro | timp: good. let's talk with QA when i'm back then | 11:46 |
gusch | dpm: can you help mefrio regarding click package issues? | 11:46 |
timp | gusch: what's the url of the log where you get that? | 11:47 |
gusch | timp: the one you posted | 11:47 |
mefrio | dpm, if you have time please give a look at my app: https://github.com/Mefrio/Memories I want to build a click package, but I don't know how since I am using CMake | 11:47 |
timp | gusch: ok, so var manager = page.__propagated.actionManager; | 11:48 |
timp | __progagated comes from the MainView. Can the Page be instantiated before the MainView? | 11:48 |
gusch | timp: and even before there is file:///usr/lib/arm-linux-gnueabihf/qt5/qml/Ubuntu/Components/MainView.qml:250:39: Unable to assign Tab_QMLTYPE_33 to Page_QMLTYPE_25 | 11:48 |
gusch | mefrio: here a blog entry from mzanetti that might help you http://notyetthere.org/?p=316 | 11:50 |
timp | gusch: hmm, weird stuff happening to bindings there | 11:50 |
mefrio | gusch, thank you! | 11:50 |
timp | gusch: do you get those warnings also when running gallery? | 11:51 |
timp | gusch: what are the dependencies on the device before I can execute ./runOnDevice.sh? | 11:53 |
gusch | timp: ./runOnDevice.sh -s | 11:54 |
timp | thanks | 11:54 |
gusch | timp: works locally - eitehr a device issue, or a jenkins issue? (or setup on these) | 11:54 |
timp | gusch: locally means on your pc? or on your phone? | 11:55 |
timp | gusch: I am not aware of changes to the UITK in the code that gives the warnings here, so there is something strange | 11:56 |
gusch | timp: on the desktop - didin't test on the device | 11:56 |
timp | gusch: did we switch to qt5.1 yet on the device? | 11:56 |
gusch | timp: ask a SDK-guy ;) - no idea | 11:56 |
timp | Mirv: did we switch to qt5.1 yet on the device? | 11:57 |
gusch | timp: oh - I just saw I do get those warnings on my desktop as well | 12:00 |
gusch | timp: but gallery seems to work fine | 12:00 |
timp | gusch: I am able to run the gallery fine on device, but autopilot tests fail | 12:00 |
timp | gusch: https://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/646/testReport/junit/gallery_app.tests.test_album_editor/TestAlbumEditor/test_add_photo_with_touch_/ finishes with MismatchError: After 10.0 seconds test on AlbumViewerAnimated.isOpen failed: False != dbus.Boolean(True, variant_level=1) | 12:02 |
timp | gusch: ok, building gallery trunk on device now | 12:03 |
timp | gusch: do you have a device to run the autopilot tests on? | 12:06 |
gusch | timp: starting to test it | 12:07 |
timp | gusch: something like phablet-test-run -s 014E281217013001 -n -p 'gallery-app-autopilot' gallery_app should work if you have the device environment set up | 12:07 |
timp | gusch: ok great :) I had a bit of a struggle to get it working, but now it works for me. | 12:07 |
timp | gusch: just updating to the latest environment always takes a long time | 12:07 |
=== snwh_ is now known as snwh | ||
timp | gusch: does runOnDevice install gallery app? so after running the script, if I open gallery-app by tapping its icon in Applications, it gives me the version that I just compiled | 12:13 |
timp | ? | 12:13 |
gusch | timp: no - it only local in /home/phablet/gallery afaik | 12:14 |
Mirv | timp: no, need to get eg. that ui-toolkit tests problem fixed https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1217331 | 12:16 |
ubot2` | Launchpad bug 1217331 in Ubuntu UI Toolkit "ui-toolkit fails some tests against Qt 5.1.1" [Critical,In progress] | 12:16 |
timp | gusch: so for the autopilot tests with that version I need to run phablet-test-run -s 014E281217013001 -n -p 'gallery-app-autopilot' /home/phablet/gallery/src/gallery-app ? | 12:16 |
=== _salem is now known as salem_ | ||
timp | Mirv: ok, just trying to figure out what has changed recently that is causing a lot of tests to fail | 12:16 |
timp | so its not a new qt version | 12:17 |
gusch | timp: I have to admit I don't know - haven't really worked on gallery for a while - and stuff changed quite a lot | 12:17 |
timp | gusch: it doesn't run on device for me https://pastebin.canonical.com/97260/ | 12:20 |
timp | gusch: ok | 12:20 |
gusch | timp: simply running "phablet-test-run -p gallery-app-autopilot gallery_app" on maguro with latest image works for me | 12:20 |
timp | gusch: how do you install the latest image? We have several latest images | 12:21 |
gusch | timp: phablet-flash cdimage-touch --pending | 12:22 |
timp | gusch: that's all? no package updates? | 12:22 |
=== MacSlow|lunch is now known as MacSlow | ||
* timp doing the same now | 12:23 | |
gusch | timp: then installing openssh-server (I don't know if that is still needed) | 12:24 |
gusch | timp: and then simply "phablet-test-run -p gallery-app-autopilot gallery_app" | 12:24 |
timp | gusch: could you check if webbrowser-app and notes-app autopilot tests are also succesfull for you? | 12:31 |
=== nik90|Office|Lun is now known as nik90|Office | ||
timp | gusch, bzoltan I created two bug reports: https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1223326 and https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1223329 | 12:37 |
ubot2` | Launchpad bug 1223326 in Ubuntu UI Toolkit "Assigning Tab to activePage when running gallery-app on device" [Critical,New] | 12:37 |
ubot2` | Launchpad bug 1223329 in Ubuntu UI Toolkit "When running gallery-app on device, page doesn't have __propagated" [Critical,New] | 12:37 |
timp | gusch, bzoltan they are warning that show up in the failing tests.. but I don't know if they are the cause for the fail | 12:37 |
gusch | timp: notes-app works (but gallery-app did as well) | 12:37 |
timp | I should be able to fix them relatively fast by adding extra guards in the uitk code | 12:38 |
timp | gusch: thanks for checking. | 12:38 |
timp | gusch: last time I tested, I installed the image without --pending, but I did apt-get update && apt-get upgrade before running the test | 12:39 |
timp | gusch: so apparently that leaves me with a different environment than simply installing the pending image | 12:39 |
timp | gusch: so when you run gallery-app on your pc, you get the warnings from my bugs also? | 12:40 |
timp | gusch: I want to fix the bugs, and I can test quicker on my laptop than on device | 12:40 |
gusch | timp: yes (as soon as I open the albums tab), but gallery seems to work nicely | 12:41 |
timp | well it won't hurt to fix the warnings anyway | 12:42 |
timp | welcome back nerochiaro | 12:45 |
nerochiaro | timp: hi | 12:45 |
nerochiaro | timp: i posted this fake MR to see what jenkins would do with running tests on trunk: https://code.launchpad.net/~uriboni/gallery-app/gallery-app-test-tests/+merge/184764 | 12:46 |
nerochiaro | timp: it has just a text file added, so if tests fail on that branch it means that jenkins is busted | 12:46 |
timp | nerochiaro, gusch when I compile gallery-app on my laptop some header is missing: https://pastebin.canonical.com/97262/ | 12:46 |
timp | nerochiaro: ok, good to check. | 12:46 |
timp | nerochiaro, gusch how so I get the build dependencies of gallery-app? | 12:47 |
nerochiaro | timp: install libcontent-hub-dev, | 12:47 |
gusch | timp: sudo apt-get build-dep gallery-app | 12:48 |
timp | thanks | 12:48 |
gusch | timp: and "sudo apt-get build-dep gallery-app-autopilot" if you want to run the autopilot tests | 12:48 |
gusch | timp: no - I guess the last one does not work | 12:49 |
timp | gusch: awesome. gallery-app runs now without having to comment out all the HUD code (which I needed to do long time ago) | 12:51 |
timp | ah I still get the warnings | 12:53 |
timp | gusch: EditingHUD is still used? | 12:53 |
gusch | timp: at least a bit of progress in 3 month ;) | 12:53 |
gusch | timp: yes - well nerochiaro is working on it | 12:54 |
timp | I cannot open a photo - https://pastebin.canonical.com/97263/ | 12:54 |
timp | no animateOpen function | 12:54 |
nerochiaro | timp: gusch: you can find here the version that uses actions instad of hud: https://code.launchpad.net/~amanzi-team/gallery-app/gallery-app-actions-api | 12:56 |
gusch | timp: well - you don't have the HUD stuff installed (anymore?) | 12:59 |
gusch | timp: the Ubuntu.HUD module | 12:59 |
nerochiaro | gust, timp the hud-less version of gallery is here: https://code.launchpad.net/~amanzi-team/gallery-app/gallery-app-actions-api | 13:00 |
nerochiaro | timp: i suggest you use that one instead | 13:00 |
timp | nerochiaro: is that going into trunk soon? | 13:01 |
timp | gusch: no I don't have that on my laptop | 13:01 |
nerochiaro | timp: when jenkins stops being a pain in the arse, and the someone will have to review it. you and gusch are the best candidates | 13:01 |
timp | ok | 13:01 |
timp | I'll get that branch then | 13:01 |
=== marcoceppi_ is now known as marcoceppi | ||
timp | nerochiaro: are there any other changes in that branch besides HUD removal? | 13:05 |
timp | nerochiaro: it would be pointless for me to try the tests with that branch if they still fail on trunk | 13:05 |
nik90|Office | nerochiaro: the branch https://code.launchpad.net/~amanzi-team/gallery-app/gallery-app-actions-api requires some more fixes which I have commented on. | 13:06 |
nerochiaro | timp: no, it's just hud removal | 13:07 |
gusch | bzoltan timp nerochiaro this "fixes" all the issues https://code.launchpad.net/~schwann/gallery-app/gallery-disable-autopilot-tests/+merge/184773 | 13:09 |
bzoltan | gusch: _ALL_ ? Cool.... will it fix the water tap in my kitchen too? | 13:09 |
nerochiaro | gusch: lol, that's a magic bullet indeed :) | 13:09 |
gusch | bzoltan: you could fix the water tap issue in a similar way - turn off the water for the whole building ;) | 13:11 |
timp | haha :) | 13:11 |
bzoltan | gusch: LOL | 13:11 |
timp | gusch: are you planning to get that MR approved, and then add tests back one by one? | 13:11 |
nerochiaro | nik90: that's a nice tip, but it's mostly cosmetic. in all other apps i converted i have imported actions that way, i think i'll leave it that way for now, for consistency, then change it in all places later on in one go | 13:12 |
gusch | timp: that MR is just a joke - my sense of humor | 13:13 |
timp | nerochiaro: the change is not only cosmetic. the UITK actions allow you to set an iconSource in case you put the action in the toolbar | 13:14 |
timp | gusch: I approved it already | 13:14 |
timp | >;) | 13:14 |
gusch | timp: it will fail without setting the commit message ... | 13:15 |
timp | gusch: I don't know if it the same for all projects, but for UITK it doesn't anymore since a week or so (it takes the description when there is no commit message) | 13:15 |
nerochiaro | timp: so one can import the same actions in two ways, but one is better than the other ? doesn't sound like a great design. why not just allow one kind of action ? | 13:16 |
timp | nerochiaro: the way you do it was the way to do it before HUD was supported by UITK | 13:17 |
nerochiaro | timp: gusch: ok, this is interesting. jenkins likes my no-change MR, it does not fail test: https://code.launchpad.net/~uriboni/gallery-app/gallery-app-test-tests/+merge/184764 | 13:17 |
timp | nerochiaro: now UITK imports the Unity actions for you | 13:17 |
timp | nerochiaro: trigger it again, to see if it reproducible | 13:17 |
nerochiaro | timp: ah, ok. well, it's not an error to do it this way anyway, and i'd rather change all of these apps later in one go | 13:17 |
nerochiaro | timp: ok | 13:17 |
nerochiaro | om26er: are you a bit less busy today ? | 13:18 |
nerochiaro | om26er: we're trying to figure out why https://code.launchpad.net/~amanzi-team/gallery-app/gallery-app-actions-api/+merge/184533 fails on stuff that's unrelated to the changes in the MR | 13:19 |
timp | nerochiaro: ok | 13:19 |
om26er | nerochiaro, that branch does not open | 13:19 |
timp | nerochiaro: unfortunately the passed tests don't show any log, so I cannot see if the warnings of the failed tests are there anyway | 13:19 |
timp | nerochiaro: the warnings of these bugs https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1223326 and https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1223329 | 13:20 |
ubot2` | Launchpad bug 1223326 in Ubuntu UI Toolkit "Assigning Tab to activePage when running gallery-app on device" [Critical,New] | 13:20 |
ubot2` | Launchpad bug 1223329 in Ubuntu UI Toolkit "When running gallery-app on device, page doesn't have __propagated" [Critical,New] | 13:20 |
om26er | oh ah, I am not logged in to launchpad :p | 13:20 |
nerochiaro | om26er: what, this one ? https://code.launchpad.net/~amanzi-team/gallery-app/gallery-app-actions-api/+merge/184533 | 13:21 |
timp | nerochiaro: ok your branch runs beautifully on my laptop :) | 13:22 |
timp | nerochiaro: it is just a bit annoying that I have to open the toolbar all the time to go back ;) | 13:22 |
nerochiaro | timp: isn't that by design ? | 13:22 |
timp | nerochiaro: I have MRs ready to improve that, but cannot get anything in until we have the autopilot tests for gallery-app passing | 13:22 |
nerochiaro | timp: and what about the tests ? | 13:22 |
timp | nerochiaro: tests are next to run | 13:22 |
timp | nerochiaro: what's the command to run them? | 13:23 |
nerochiaro | timp: cd tests/autopilot then autopilot run gallery_app | 13:23 |
nerochiaro | timp: then go get a coffee | 13:23 |
timp | nerochiaro: damn I don't have coffee here | 13:25 |
timp | nerochiaro: can you recommend me a place? (in barcelona) :) | 13:25 |
beuno | "policy_groups": [ | 13:25 |
beuno | "" | 13:25 |
beuno | ], | 13:25 |
beuno | ah, no jdstrand | 13:25 |
nerochiaro | timp: i don't do coffee ;) | 13:25 |
rschroll | I'm trying to build a click package for a compiled app, following mzanetti's instructions. The build seems to work, but installation (on a desktop VM) doesn't. Is anyone available to help troubleshoot? | 13:33 |
timp | nerochiaro, gusch nero's branch fails for me | 13:37 |
timp | the autopilot tests | 13:37 |
timp | ah no shit i ran the test for trunk | 13:37 |
timp | re-running them... | 13:39 |
mzanetti | rschroll: shoot | 13:40 |
rschroll | My source is here: https://github.com/rschroll/beru, with the manifest and apparmor profiles | 13:41 |
rschroll | there's a makeclick.sh script that copies them into a subdirectory and then calls click build | 13:41 |
rschroll | That works, but if I try to install with pkcon, I get a Python traceback: dbus.exceptions.UnknownMethodException: org.freedesktop.DBus.Error.UnknownMethod: Unknown method: CreateTransaction is not a valid method of interface org.freedesktop.PackageKit | 13:42 |
rschroll | This is on a VM running an up-to-date 13.10 | 13:42 |
rschroll | Trying to install with sudo click install gives a variety of errors; right now it's complaining that it can't generate an apparmor profile. | 13:43 |
tiagoscd | hey, morning | 13:44 |
tiagoscd | I would like to know if I need any specific permission to access hardware (like camera) directly via an app | 13:44 |
rschroll | If I remove the read_path and write_path, that error goes away, but it says "Could not parse click manifest". (This is on install, not build!) | 13:44 |
timp | nerochiaro: ok, the tests passed on your branch for me | 13:51 |
timp | nerochiaro: on laptop. | 13:51 |
timp | nerochiaro: next on device | 13:51 |
nerochiaro | om26er: any news ? | 13:52 |
timp | 14:24 < gusch> timp: then installing openssh-server (I don't know if that is still needed) | 13:53 |
timp | gusch: ^ runOnDevice.sh -s installs openssh-server :) | 13:53 |
rschroll | mzanetti: I should add that first attempt to install with click install worked. But installing newer versions on top of it didn't update the apparmor profile. I couldn't find an uninstall option, so I nuked everything in /opt/click.ubuntu.com and /var/lib/apparmor, but now I'm getting these errors. Is there something else hanging around that could be causing problems? | 13:55 |
=== mzanetti is now known as mzanetti|meeting | ||
attente | is there a way to apply the addDisplaced and removeDisplaced transitions to a ListView section.delegate? | 14:10 |
attente | setting the transitions only seems to make them apply to the non-section delegates | 14:10 |
om26er | nerochiaro, working on it. probably the device didn't had the latest image. Flashing now | 14:15 |
timp | Wellark: is it okay to call actionManager.addLocalContext(actionContext) twice with the same actionContext? | 14:18 |
=== mzanetti|meeting is now known as mzanetti | ||
seb128 | timp, ^ do you know about the delegate question asked a bit earlier? | 14:37 |
timp | nerochiaro: your branch seems to run fine on device. how would I run the autopilot tests for that branch on device? | 14:38 |
timp | seb128: can you paste it again? I don't see it | 14:38 |
seb128 | timp, the one from attente 30 minutes ago | 14:38 |
seb128 | timp, sorry just trying to figure who could help/answer that, that's for settings work | 14:38 |
nerochiaro | timp: install the package, install the gallery-app-autopilot package, shell in as phablet then when your phone is unlocked do: autopilot run gallery_app | 14:39 |
nerochiaro | timp: that's exactly what i'm doing right now btw | 14:39 |
attente | timp: "is there a way to apply the addDisplaced and removeDisplaced transitions to a ListView section.delegate? | 14:40 |
attente | setting the transitions only seems to make them apply to the non-section delegates" | 14:40 |
timp | attente, seb128 sorry, no idea | 14:40 |
seb128 | timp, do you know who would have one? | 14:41 |
timp | attente: perhaps you can put an addition Item around your delegate that is positioned, and add sth like x:-10 to your delegate? I'm just guessing | 14:41 |
timp | seb128: you can try zsombi | 14:41 |
timp | seb128: he seems to be away at the moment | 14:41 |
seb128 | k | 14:41 |
timp | nerochiaro: I executed runOnDevice.sh but that doesn't build the package | 14:42 |
attente | i'm not sure ListView section.delegates have any concept of the non-section delegates they precede | 14:43 |
timp | nerochiaro: I'm using cdimage-touch, no need to unlock the device. I hope that's not terribly deprecated | 14:43 |
timp | ..yet | 14:43 |
timp | nerochiaro: do you have a recipe for building and installing the package? or do you do it via qtcreator? | 14:43 |
nerochiaro | timp: unlock as in having the lock/welcome screen up | 14:44 |
timp | ah :) | 14:44 |
nerochiaro | timp: i downloaded the package from jenkins | 14:44 |
nerochiaro | timp: you can also build in pbuild | 14:45 |
nerochiaro | timp: om26er: all tests passed on my device using the package downloaded from the latest run of jenkins on this: https://code.launchpad.net/~amanzi-team/gallery-app/gallery-app-actions-api/+merge/184533 | 14:45 |
nerochiaro | timp: om26er: but jenkins fails on the same packages | 14:45 |
nerochiaro | om26er: latest image, just flashed | 14:46 |
mefrio | mzanetti, ping | 14:50 |
mzanetti | mefrio: pong | 14:51 |
mefrio | mzanetti, I was reading your blog entry to learn how to build a click package for my app (http://notyetthere.org/?p=316) but I have a question....in the first point you said that the developer should build an arm package using pbuilder environment | 14:52 |
mefrio | mzanetti, could you explain me how to do that? I did not find anything useful | 14:52 |
mzanetti | mefrio: do you have debian packaging files (for creating a .deb) package? | 14:54 |
mefrio | mzanetti, yes | 14:54 |
mzanetti | mefrio: check the comments, there is a command to setup pbuilder | 14:54 |
mzanetti | mefrio: but isntead of manually unpacking the created chroot | 14:54 |
mzanetti | mefrio: do a "pbuilder -p saucy-armhf" | 14:55 |
mefrio | mzanetti, let me see | 14:56 |
timp | nerochiaro: which package has unzip? | 14:56 |
nerochiaro | timp: unzip ? | 14:57 |
mzanetti | timp: apt-cache search has it :D | 14:57 |
timp | yes, it is there. for some reason I didn't see it repeatedly | 14:59 |
timp | :s | 14:59 |
timp | nerochiaro: the tests fail instantly https://pastebin.canonical.com/97273/ | 15:02 |
timp | nerochiaro: are you sure you run it as phablet? the permissions seem wrong | 15:02 |
timp | hmm | 15:02 |
timp | ah I ran it as root first | 15:03 |
nerochiaro | timp: :) | 15:03 |
timp | nerochiaro: ok, something seems to be happening now, but I don't see gallery opening on the device | 15:04 |
nerochiaro | timp: and you're sure the welcome screen was gone when you laucnhed that command ? | 15:04 |
timp | DBusException: org.freedesktop.DBus.Error.NotSupported: Unable to autolaunch a dbus-daemon without a $DISPLAY for X11 | 15:04 |
timp | nerochiaro: yes it was gone | 15:05 |
nerochiaro | timp: i am now afraid you messed something up by runing things as root | 15:05 |
timp | hmm | 15:07 |
timp | nerochiaro: su - phablet instead of su phablet works :) | 15:08 |
* timp running tests now | 15:08 | |
timp | I log in using adb which gives me a root shell | 15:08 |
timp | nerochiaro: I have an MR to fix some warnings in the gallery-app tests: https://code.launchpad.net/~tpeeters/ubuntu-ui-toolkit/gallery-app-warnings/+merge/184788 | 15:11 |
timp | nerochiaro: could you test them on device with your gallery-app branch? uitk packages are in the MR | 15:11 |
timp | I can test them also, but I'm still testing your branch with stock UITK on device | 15:12 |
nerochiaro | timp: ok, doing it | 15:12 |
timp | thanks | 15:12 |
timp | I am not sure if the warnings are related to the fails | 15:12 |
timp | nerochiaro: please post the results as comments on the MR | 15:12 |
nerochiaro | timp: btw my branch with stock uitk pass all tests | 15:14 |
nerochiaro | timp: on device | 15:14 |
timp | nerochiaro: I just got the same results. good. | 15:17 |
timp | so what's up with jenkins? | 15:17 |
timp | nerochiaro: I am now re-running the test with my UITK version | 15:21 |
timp | nerochiaro: we should test jenkins for your MR with my UITK version, dunno if that's possible. | 15:21 |
nerochiaro | timp: i don't think it's possible | 15:21 |
nerochiaro | timp: but in any case just my MR failing alone in jenkins and working on the device is something that om26er needs to help us fix. as far as i'm concerned all the tests are good, i can't find out what's broken | 15:22 |
nerochiaro | timp: and for the record, tests just finished here, with my branch + your uitk branch > everything pass | 15:23 |
nerochiaro | timp: so there's something busted in jenkins | 15:23 |
nerochiaro | om26er: let me know if you want me to file a bug for this | 15:23 |
om26er | nerochiaro, I have flashed the device | 15:23 |
om26er | nerochiaro, but somehow I lost the MR you gave me | 15:23 |
timp | om26er: https://code.launchpad.net/~amanzi-team/gallery-app/gallery-app-actions-api/+merge/184533 | 15:24 |
timp | om26er: I verified that the autopilot tests pass with the latest pending image | 15:24 |
nerochiaro | om26er: also your fix on the mediaplayer MR isn't working: https://code.launchpad.net/~amanzi-team/mediaplayer-app/mediaplayer-app-new-actions-api/+merge/182148 | 15:24 |
timp | omg26er: so cdimage-touch --pending. Is that what jenkins uses? | 15:24 |
timp | nerochiaro, om26er the results say UNSTABLE, not FAILED. What's the difference? | 15:25 |
om26er | timp, yes we do --pending | 15:25 |
om26er | timp, unstable means few tests failed. FAILED means all | 15:25 |
om26er | timp, nerochiaro its rerunning here | 15:26 |
om26er | s-jenkins:8080/job/generic-mediumtests-runner-maguro/657/console | 15:26 |
om26er | only on one device, I just wanted to make sure | 15:27 |
timp | a bunch of tests failed, but I don't see a relation between the failed tests | 15:27 |
* timp food now. bbl. | 15:29 | |
mefrio | mzanetti, I tried to follow the instructions in a comment but it seems pbuilder cannot create a valid arm environment | 15:29 |
mefrio | mzanetti, it seems the .tgz created is empty | 15:30 |
om26er | timp, nerochiaro that passed. So we should re-run the CI and it will pass this time | 15:31 |
nerochiaro | om26er: why would it pass ? | 15:32 |
nerochiaro | om26er: it didn't pass before and there are no changes in the branch | 15:32 |
mzanetti | mefrio: paste the whole output | 15:32 |
om26er | nerochiaro, the device flashing was kind of stuck a 2 days behind | 15:32 |
om26er | so I flashed to the latest iamge | 15:32 |
om26er | nerochiaro, about the mediaplayer failure you just pointed at that's a different thing. a problem with jenkins. We need to retrigger again | 15:33 |
om26er | https://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/2738/console | 15:33 |
om26er | see the logs | 15:33 |
nerochiaro | om26er: ok, will retryigger both | 15:33 |
mefrio | mzanetti, http://pastebin.com/uw5gdYXX | 15:33 |
om26er | nerochiaro, I did that already | 15:33 |
nerochiaro | om26er: on both ? ok | 15:33 |
mzanetti | mefrio: download error... | 15:34 |
mzanetti | mefrio: make sure your network is working | 15:35 |
mzanetti | mefrio: and make sure your system is up to date | 15:35 |
mefrio | oh I did not noticed that error...mzanetti thanks | 15:35 |
mefrio | let me retry | 15:35 |
om26er | yep | 15:35 |
Wellark | timp: yes. each of the add* functions are safe to call multiple times with same data | 15:38 |
labsin | which path do I need to give to the icon in my desktop file for a click package. Is it "./some-name.png" or just "some-name.png" cause the first one was working on my desktop before but not anymore. | 15:53 |
iBelieve | labsin, "some-name.png" is correct | 15:56 |
mefrio | mzanetti, it worked! Thanks! :) | 16:07 |
mzanetti | :) | 16:07 |
mefrio | mzanetti, the chroot environment cannot found my home dir :( | 16:13 |
mzanetti | mefrio: you can do "ptest --save -p saucy-armhf" | 16:14 |
mzanetti | mefrio: inside you can create the required dirs and then type "logout" to exit the chroot again | 16:15 |
mzanetti | mefrio: any changes in there will only be saved when you give the --save option | 16:15 |
mefrio | mzanetti, ok thanks now it works | 16:15 |
AskUbuntu | Where do I submit applications written for Ubuntu Touch? | http://askubuntu.com/q/343877 | 16:43 |
balloons | iBelieve, another day of test results :-) Did you happen to take a look? | 16:48 |
iBelieve | balloons, no, I haven't seen test results. Where? Are the tests still failing? | 16:50 |
balloons | iBelieve, yea, I'm not sure why.. I'll be back a bit later, but have a look if you'd like | 16:52 |
balloons | iBelieve, the results appear everyday here: http://reports.qa.ubuntu.com/smokeng/ | 16:52 |
balloons | iBelieve, I didn't see evidence of a systematic failure occuring; meaning, different tests simply failed there asserts at different points, indicative of actual test failures | 16:53 |
balloons | the good news is the Xauthority problem is solved :-) | 16:54 |
nerochiaro | om26er: gallery still failing https://code.launchpad.net/~amanzi-team/gallery-app/gallery-app-actions-api/+merge/184533 | 16:54 |
om26er | nerochiaro, we just updated java on the slave | 16:55 |
iBelieve | balloons, that's weird, it looks like it doesn't think None == None | 16:55 |
om26er | nerochiaro, sorry about keeping your builds failed. I triggered a rebuild (now that we have a latest Java) | 16:56 |
nerochiaro | om26er: ok. can you retrigger the other one too ? https://code.launchpad.net/~amanzi-team/mediaplayer-app/mediaplayer-app-new-actions-api/+merge/182148 | 16:56 |
om26er | nerochiaro, ok | 16:56 |
clepto | mhall119, any news on compiled binaries in click packages? | 17:03 |
mhall119 | clepto: I'm still finding out myself, dpm and dholbach should know more | 17:04 |
dholbach | we're going to have a tutorial up soon which will sort of be a workaround | 17:04 |
clepto | mhall119, dholbach thank you both! | 17:04 |
dholbach | but everybody's hard at work getting things ready, so we can have stuff build automatically in the future | 17:04 |
dholbach | rock on! | 17:04 |
iBelieve | I'm filling out the Submission Form for the App Showdown. What do I put in the Submission URL field? | 17:07 |
clepto | iBelieve, submission form? | 17:08 |
iBelieve | clepto, https://docs.google.com/forms/d/1a1Owwl6EVQ8165Wy_TsSaDGGWmYJaT6INm2P4DgZWAA/viewform | 17:08 |
iBelieve | clepto, Item #4 of http://developer.ubuntu.com/showdown/ | 17:09 |
iBelieve | mhall119, do you know what I should put for the Submission URL of the submission form for the showdown? ^^^ | 17:12 |
dpm | iBelieve, that will be the url of your app in myapps.developer.ubuntu.com, let me give you an example... | 17:12 |
iBelieve | dpm, so https://myapps.developer.ubuntu.com/dev/click-apps/13/? | 17:12 |
dpm | iBelieve, exactly :) | 17:12 |
iBelieve | dpm, great, thanks. Should I fill in the form now or is there any reason to wait? | 17:13 |
dpm | iBelieve, go for it, no reason to wait :) | 17:13 |
iBelieve | dpm, cool, thanks | 17:13 |
iBelieve | dpm, for the website, should I put my GitHub project, my blog, or my static webpage http://sonrisesoftware.wordpress.com/ubuntu-tasks/? | 17:16 |
dpm | iBelieve, any website you think offers info about the project should do. I guess you have links to github on your static webpage, so that might be a nice URL to use | 17:17 |
iBelieve | dpm, okay, I'll use the static webpage | 17:18 |
dpm | great | 17:18 |
dpm | clepto, as dholbach is saying, we're working to get some more detailed documentation online soon. In the meantime, you can use http://developer.ubuntu.com/resources/tutorials/getting-started/creating-click-packages-with-cpp-extensions/ - although the part about doing the actual cross-compiling will need to be fleshed out | 17:19 |
clepto | dpm, today I'll try to fix as many bugs as I can and focus tomorrow on packaging (8:20 pm here), do you think it will be updated by tomorrow? | 17:21 |
dpm | clepto, we will do our best, but if you are on IRC tomorrow, you can ping us if we can help with any questions. | 17:22 |
dpm | clepto, you'll essentially need to do two things: | 17:22 |
dpm | 1) Cross-compile your extension | 17:22 |
dpm | 2) Put the compiled binary in a click package that you will create manually outside of Qt Creator | 17:23 |
dpm | There are ways to do 1), but we want to describe the easiest way for app developers for the contest, as a temporary solution until we've got all of the infrastructure bits sorted | 17:24 |
clepto | dpm, that will be great! ok! | 17:25 |
nerochiaro | renato_: can you please finally approve https://code.launchpad.net/~amanzi-team/mediaplayer-app/mediaplayer-app-new-actions-api/+merge/182148 ? now jenkins finally likes it ! | 17:29 |
om26er | nerochiaro, renato_ I top approved | 17:40 |
nerochiaro | om26er: thanks | 17:40 |
nerochiaro | om26er: the gallery app is not failing on my maguro device when using the same packages built by jenkins | 17:44 |
om26er | nerochiaro, the logs suggest the app crashed | 17:45 |
om26er | like real crash | 17:45 |
nerochiaro | om26er: that sounds strange. and also many other tests in gallery open a photo, so i don't see why only that one should crash | 17:46 |
om26er | nerochiaro, race or something probably, definitely nothing wrong with that code, rather something bad in the app that needs fixinfg | 17:47 |
e8hffff | Question: What the status of the File-Manager opening files? | 17:50 |
balloons | iBelieve, yes it can read a bit funny.. it's showing you the line output, none=none, but the assert is eventually(notequals(none))), hence the failure | 17:55 |
mefrio | mzanetti, I am still getting errors after an afternoon spent on that click package generation...can you help me please? http://pastebin.com/T1DABeet | 17:58 |
mefrio | I installed all the dependencies...it's so frustrating | 17:59 |
iBelieve | balloons, oh, now i see the actual assertion. That makes a bit more sense now :) | 17:59 |
balloons | iBelieve, :-) I'm going to run the whole test suite again here locally on my device.. I know I ran it yesterday and worked, so I'm confused that it is failing. | 18:01 |
attente | when emitting dataChanged() in QAbstractItemModel, are there conditions where data() is not called as a result? i would've expected it to get called every time, but it seems to be not the case | 18:03 |
mzanetti | mefrio: oh :/ you're running into the qemu bug | 18:03 |
mzanetti | mefrio: you would need to disable the tests to build it in pbuilder | 18:03 |
mefrio | mzanetti, do you need the autopilot package? | 18:03 |
mzanetti | no... qmltests are causing this issue with pbuilder | 18:04 |
mefrio | mzanetti, how do I disable it? | 18:04 |
mzanetti | mefrio: you said you are using cmake, right? | 18:04 |
mefrio | mzanetti, yes | 18:05 |
mzanetti | mefrio: comment the add_subdirectory(tests) | 18:05 |
mzanetti | or similar | 18:05 |
mefrio | mzanetti, I have not yet implemented real tests so there is nothing releated to tests in my CMake | 18:05 |
mefrio | mzanetti, do I have to disable the autopilot package so? | 18:05 |
mzanetti | no... autopilot should be fine | 18:06 |
mzanetti | mefrio: but according to the logs it uns this: qmltestrunner -input tests/unit | 18:06 |
mzanetti | mefrio: there must be a add_test() somewhere | 18:06 |
mefrio | mzanetti, can you take a look if you have time please? https://github.com/Mefrio/Memories | 18:09 |
mefrio | there is nothing related to qmltestrunner in my CMake | 18:09 |
mefrio | mzanetti, oh it was in the Makefile generated by QtCreator -.- | 18:12 |
mzanetti | ok :) | 18:12 |
mefrio | mzanetti, it's hardest to build an arm package then write an app :P can't we let launchpad do it for us? | 18:13 |
mzanetti | mefrio: yes, you could. you'd need to contact the launchpad admins and ask for an arm builder for your ppa | 18:13 |
mzanetti | mefrio: however, those launchpad builders have the same problem and would crash in the same way | 18:14 |
mefrio | mzanetti, the arm builder should available by default, no? | 18:14 |
mzanetti | mefrio: probably they will be enabled by default at some point, yes | 18:15 |
mefrio | mzanetti, anyway the package it was build has the _all extension...how do I make sure it is for ARM? | 18:16 |
mzanetti | the .deb package or the .click package? | 18:16 |
mefrio | mzanetti, the deb | 18:16 |
mzanetti | debian/control -> Architecture | 18:16 |
mefrio | mzanetti, "Architecture: all" | 18:17 |
mzanetti | mefrio: you should also add your build depends in there instead of modifying your pbuilder tarball | 18:17 |
mefrio | mzanetti, they are there, I thought I had to install them in the pbuilder too....anyway, is the architecture good? | 18:19 |
mzanetti | mefrio: no, it should be "any" | 18:19 |
mefrio | mzanetti, ok thanks for your big patience :) it seems I am finally done with that thing! :D | 18:21 |
mzanetti | :) | 18:23 |
mefrio | mzanetti, and of course, changing the architecture to any I get the following error http://pastebin.com/Yv5BYYgp | 18:24 |
mzanetti | seems a bit like you have a dirty source directory | 18:25 |
mzanetti | could it be that you tried building with debuild first and still have some x86 binaries in debian/memories-app... ? | 18:26 |
mefrio | mzanetti, I deleted them | 18:26 |
mefrio | let me do it again, deleting also the source build dir | 18:27 |
mefrio | it's the same | 18:28 |
mzanetti | lol... the app supports "basic memory management (add, remove and edit)" | 18:28 |
mzanetti | oh boy... I whish I could remove memories just like that | 18:28 |
mefrio | mzanetti, ahaha my app has super-natural powers xD | 18:29 |
mzanetti | mefrio: does it already support all that stuff or is that the roadmap? | 18:29 |
mefrio | mzanetti, it supports everything written on GitHub | 18:29 |
mzanetti | not bad... time to get that stuff packaged up them | 18:29 |
mefrio | mzanetti, and some more functions such PDF export for which I need a C++ module...this feature is causing me all this problems with packaging | 18:30 |
mzanetti | hmm... maybe you'd be better off with just doing it manually in the chroot | 18:30 |
mzanetti | as you said you have the package already I assumed it to be completely working already | 18:31 |
mzanetti | so basically what you can do is to ptest into the chroot, copy the source in there, do a manual cmake and make and just copy that one .so file back to your other system and package it up | 18:31 |
mzanetti | mefrio: ^ | 18:31 |
mefrio | mzanetti, yeah that sounds as a great solution | 18:32 |
mefrio | mzanetti, with CMake and make to build it says "Error: SEGV" :'( | 18:35 |
mefrio | running make again solves the segmentaion error -.- | 18:36 |
mefrio | now I finally have the .so!!!!!!!!! :D yesss! :D | 18:36 |
mefrio | thank you very much mzanetti!! I couldn't have done that without your help | 18:36 |
mefrio | now it's time to make some rest from all that things :D see you guys and thank you again mzanetti! | 18:38 |
balloons | iBelieve, the same tests failed on my device, as failed in the lab, heh | 18:45 |
balloons | I wonder what has changed? | 18:45 |
iBelieve | balloons, that's odd. Did you run the tests on the desktop as well? I'll run them myself in a few minutes | 18:55 |
balloons | iBelieve, I had thought I had done both.. but it fails on the device now | 19:04 |
balloons | it of course passed in the vm | 19:04 |
boiko | bfiller: at last renato_ managed to fix the address-book-service code that was blocking the UI, no more UI freezes when the smart dialer is looking up for contacts | 19:18 |
bfiller | boiko: cool, can you point me at the MR's so I can test? | 19:19 |
boiko | bfiller: https://code.launchpad.net/~renatofilho/address-book-service/eventloop-wait/+merge/184842 | 19:19 |
boiko | bfiller: now I'll check the designs for the dialer-app | 19:19 |
vadi | I compiled my Qt app on Qt5 (installed from Qt's online installer) and there is no appmenu integration anymore. How can I get that back? | 19:34 |
mzanetti | vadi: afaik Qt 5 doesn't officially support that yet. Try installing the ubuntu qt5 packages | 19:37 |
bfiller | boiko, renato_ : that MR looks kind of scary regarding event loops and waits and such. Did you guys thoroughly test and make sure no regressions? | 19:38 |
vadi | Are those officially available in 12.04? I used the Ubuntu Touch SDK ppa before - and it was building me a fairly broken Qt5 app (couldn't click anywhere and such). I'll try once again, though | 19:38 |
mzanetti | bfiller: heh... isn't the task of the reviewer? :D | 19:39 |
bfiller | mzanetti: indeed, that's why I'm asking to double check | 19:40 |
boiko | bfiller: I tried the dialer-app, and the contacts app | 19:40 |
renato_ | bfiller, I tested both too | 19:41 |
bfiller | renato_: does that code only get invoked when using the smart dialer or all the time when fetching contacts? | 19:41 |
mzanetti | bfiller: just reading the code it looks ok... the one bad would assert | 19:42 |
mzanetti | actually... do we test with debug builds on the phone? | 19:42 |
mzanetti | otherwise I wouldn't trust that this assert gets actually discovered when it happens | 19:42 |
boiko | bfiller: all the time | 19:42 |
=== salem_ is now known as _salem | ||
=== seb128_ is now known as seb128 | ||
=== ryukafalz_ is now known as ryukafalz | ||
timp | Wellark: ok, great. then this MR is good :) https://code.launchpad.net/~tpeeters/ubuntu-ui-toolkit/gallery-app-warnings/+merge/184788 | 22:50 |
=== _salem is now known as salem_ | ||
=== karni is now known as Guest72454 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!