/srv/irclogs.ubuntu.com/2013/09/13/#juju-gui.txt

hatchgary_poster: saw your email, and freshly pulling trunk has 5 broken tests for me .....01:13
gary_posterhatch did you try a make clean?01:13
hatchI'll try again01:14
gary_posterlint was definitely broken, but trivial to fix01:14
hatchyeah the odd thing was how did it get landed...01:14
gary_posteryeah, that's a good q01:15
hatchI wonder if it's the issue bcsaller ran into where it picks up a running test suite on another branch01:15
hatchso it 'passes' by thinking the other branch is its own01:15
gary_postermaybe, but the one failing test for me is the one I broke01:16
gary_posterI'll try switching to trunk in just a sec01:16
hatchvery odd, fresh trunk pull and 6 errors01:16
hatchthe failures are in app-cookies-extension.js01:16
gary_posterok01:17
gary_posterI'll try to verify in a sec01:17
rick_h_cleaning here to look01:17
gary_posterthanks01:17
bcsallerhatch: we can change the test target to use random ports so we always fire servers in the proper mode01:17
gary_postersimpler solution might be to fall over harder if the port is already running01:18
gary_posterwe simply complain now01:18
gary_posterwhich is actually kind of convenient :-P01:18
rick_h_+101:18
rick_h_I know I landed a branch on accident due to that fact before01:19
rick_h_I get the cookie error, "cannot call setStyle of null" in the check() function01:20
hatch*phew* glad I wasn't the only one01:20
gary_posterrick_h_, my branch plus your check conflict branch were not friends.  They duked it out and your branch won. ;-) I'm redoing the core of my branch01:20
rick_h_gary_poster: :( sorry01:21
gary_posterrick_h_, heh, np01:21
rick_h_gary_poster: let me know if I can do anything to help01:21
gary_posterrick_h_, naah, Jeff and I just decided that your assumptions were better than the ones I had made01:21
* hatch would like to note on the record that he does sometimes agree with rick_h_ :P01:21
rick_h_hatch: sssh, don't spread the word01:22
hatchlol01:22
rick_h_otherwise people will look twice when we do agree :P01:22
gary_posterlol01:22
hatchhaha01:22
hatchok now to figure out how to revert my branch to pre-trunk-merge01:22
rick_h_I can look at the test thing first thing in the morning. I reviewed bac's branch that hatch thinks is the issue and should be a simple thing. 01:23
hatchoh it forsure is - it's the one that made CI fail01:23
hatchbut it's probably a trivial fix01:23
rick_h_hatch: right01:23
hatchI just am really busy tonight01:24
rick_h_hatch: he did touch index.html which probably threw off something01:24
gary_posterhatch you can just back out bac's branch.  bzr merge -r bad_revno..bad_revno-101:24
rick_h_hatch: yea, I'm about to head to bed myself after doing the birthday cake bake off with the 3yr old01:24
gary_poster:-)01:24
rick_h_but can completely pick it up in the am. I did qa the branch, but didn't run tests locally with it. 01:24
gary_posterhatch uh I think I got that wrong01:24
gary_posteroff by one :-)01:24
hatchI `bzr revert -r 1038`01:25
gary_poster bzr merge -r bad_revno+1..bad_revno01:25
rick_h_hatch: so that reverts the whole tree to that state01:25
gary_posterif it works, go for it. :-)01:25
gary_posteryeah that's what I thought01:25
gary_posterwhile what I did01:25
gary_posteris a cherrypick01:25
hatchohh ok ok01:25
rick_h_huh? I only see 103701:25
hatchmy local branch has more commits01:25
rick_h_gotcha, ok so you want -r 103601:26
rick_h_since 1037 is the last one on trunk you want to back out01:26
hatchhmm it's giving me errors01:28
hatchso in order to revert the trunk commit which is 1039 in my branch01:29
hatchso I need to undo a commit and a merge01:31
hatchso revert -r103801:31
gary_posterhatch if it is the most recent commit01:32
gary_posterthen you can bzr uncommit01:32
gary_posterwhich just uncommits, then you can bzr revert (and maybe bzr revert --forget-merges)01:32
gary_postermaybe that's all the same thing--sorry01:33
hatchperfecto01:33
hatchthanks I was doing things in the wrong oder01:33
hatchorder even01:33
gary_postercool01:33
hatchthere are a lot more blog posts about how to do these things in git01:33
hatchhaha01:33
hatchok gota run again have a good night all01:34
gary_poster:-) night01:35
frankbanhazmat: ping, when you have a minute, could you please take a look at https://code.launchpad.net/~frankban/juju-deployer/guiserver-changes/+merge/182369 ? 08:59
gary_posterhey rick_h_ you around?12:07
rick_h_gary_poster: yep12:12
rick_h_gary_poster: finishing up going through the diff. Have time to walk me through a couple of bits?12:12
gary_posterthank you rick_h_! yeah sure12:13
gary_posterrick_h_, https://plus.google.com/hangouts/_/f3cad7e0300cc572c223e13157a2d685a8adcb2c?12:13
rick_h_gary_poster: you know, if we didn't think of it as conflict but more change indication the behavior makes more sense. I think I got hung up on 'there's no conflict technically' but there's definitely change to indicate to the usre12:31
gary_posterrick_h_, good point.  Can you think of a name for the viewlet function that would introduce less cognitive dissonance in that regard?12:32
gary_poster"doubleChange" ..."modelChangeAfterEdit"12:33
gary_poster"possibleConflict"12:33
rick_h_I was thinking of some way to indicate backgroud 12:33
rick_h_backgroundChange12:33
benjiverbs are nice12:33
gary_posterbut the databinding handles background changes if the field has not been edited rick_h_ 12:34
gary_posterbenji, ack.  "handleBackgroundChangeAfterEdit"..."handleConflict"..."handlePossibleConflict"12:35
rick_h_gary_poster: definitely. I only mean in the single case12:35
gary_posterah, a separate "handleConflict" and "handleBackgroundChange"?12:35
gary_posterboth?12:35
rick_h_well, what are we naming? I was originall just speaking that in general I was thinking that the goal was to modify conflictux to handle conflicts correctly. 12:36
gary_posterf we were to introduce "handle" we'd have to go through the whole API...handleChange at the very least12:36
gary_posterrick_h_, I was thinking of naming the viewlet method that databinding calls in this case12:36
gary_poster(it is currently called "conflict")12:37
rick_h_yea, looking12:38
rick_h_binding.viewlet.indicateChange ?12:41
rick_h_if the value is changed and you've not changed it we don't idicate it at all12:41
gary_posterrick_h_, but we do: see the viewlet.changed method :-)12:41
gary_posterthis case is all about the interaction from both sides12:42
rick_h_but I'm fine with it as is. I was just pondering why this seemed like we can't get a behavior that 'felt' nice and I think it was around sticking to the idea that it's for conflicts specifically12:42
frankbanguihelp: I need two reviews and one QA for https://codereview.appspot.com/13549046/ . Anyone available? Thanks!12:42
gary_posterrick_h_, I think you are exactly right and just wanted to make our names match our thoughts12:42
bacfrankban: i'll do a review right now12:43
rick_h_frankban: will peek at it in a sec. 12:43
frankbanbac, rick_h_: thank you both!12:43
rick_h_gary_poster: doh, you're right of course. We do indicate modified lol. 12:44
gary_poster:-)12:44
rick_h_gary_poster: what about checkForConflict or something that seems more fuzzy "we're not sure wtf is here...but you should know about it"12:44
gary_posterheh12:44
gary_posterrick_h_, would be fine with that, yeah.  similar to my "handlePossibleConflict".  Both convey the idea better than what we have.  Maybe I'll sneak it into my next branch (last in the series!)12:45
rick_h_gary_poster: wooo! 12:46
gary_poster:-)12:46
rick_h_frankban: hah, nice for providing not just qa instructions but a qa script12:52
frankbanrick_h_: yeah, that's the easiest thing to do with this kind of branches. I have a card for converting these QA scripts in actual functional tests12:53
* gary_poster is going for hour walk soon, to slightly compensate for many hours spent over this week. :-)12:55
rick_h_frankban: you've made my day. I didn't realize there was a backport of futures13:00
rick_h_frankban: caught me off gaurd, thought it was only avail for 3.2+13:01
frankbanrick_h_: :-) that's really cool indeed.13:02
bachi frankban i'm getting this failure http://paste.ubuntu.com/6101649/13:30
frankbanbac: interesting, is it intermittent? 13:31
bacfrankban: no13:31
bacfrankban: wait, yes it is intermittent.  5 runs, 4 errors13:32
bacfrankban: 10 runs, 9 errors.  so it is mildly intermittent tending towards mostly failing.  :)13:33
bacfrankban: i'm running on a saucy vm fwiw13:34
frankbanbac: taking a look13:34
frankbanbac: could you please try bzr pull and then run the tests again?13:39
bacfrankban: no difference13:41
rick_h_timing issue? 5 runs here no problem13:41
bacrick_h_: perhaps.  my vm may be a little sluggish13:42
rick_h_198 tests in 3.1s here13:43
rick_h_is juju-test still not in a ppa?13:45
frankbanbac: could you try pull and tests again?13:49
bacfrankban: different failure, about 20% of the time: http://paste.ubuntu.com/6101721/13:52
benjijuju-gui: anyone know anything about this error I got while doing a make in a clean checkout? Error: No compatible version found: cryptojs@'cryptojs@>= 2.5.3'13:53
bacrick_h_: and my tests run in 2.95s, so my vm isn't slow at all13:53
rick_h_bac: cool yea. strange I can't dupe :/13:53
rick_h_I'm not on saucy though13:55
frankbanbac: do you have that error if you disable test_cancel_started_deployment?13:55
* bac tries13:55
bacyes, frankban13:56
frankbanbac: ok, so, some of the tests in that module are racy in your configuration. and not well isolated. good to know. just to check if this problem is generated by this branch, could you please try to run the same tests in trunk?13:58
bacfrankban: ok13:59
frankbanbac: thanks13:59
hatchhey has anyone started fixing trunk yet?14:01
rick_h_hatch: gary submitted something last night14:01
hatchoh woops missed that14:01
rick_h_hatch: there was a follow up email 14:01
gary_posterbenji, have not seen.  try make clean?14:02
rick_h_benji: hmm, do you have an offline cache it's not hitting? 2.5.3 is the latest in npm 14:02
rick_h_heh, updated 2 yrs ago...nvm14:03
benjigary_poster: tried; I'm trying a couple of other things, I think it is that checkout in particular (which is strange because it is just a branch from an updated trunk, with some changes from a WIP branch merged in)14:03
bacfrankban: i do see that same failure on trunk about 10% of test runs14:05
hatchbenji: the syntax is wrong in that error you posted - is that what it looks like in the shrinkwrap file?14:05
benjihatch/gary_poster: I figured it out!  I was re-using a shell session that happened to be running in an LXC container that isn't set up to do GUI dev.14:07
hatchhaha nice14:08
frankbanbac: hum... ok, so perhaps, if you agree, I can tackle this in another card. just one last request of pull from my branch and test again if you can? I changed one last thing in an old test14:10
gary_postercool14:10
bacfrankban: will re-test.  certainly cool with you making a new card and moving along14:11
frankbanbac: cool, thanks14:11
bacfrankban: on the 4th run the failure occurred14:12
frankbanbac: and perhaps we can pair on that card once I am back ;-) I am not sure where to start to reproduce your configuration14:12
bacsure14:12
frankbanbac: cool, creating the card.14:12
frankbancard created in bundles14:15
frankbanhazmat: thanks for reviewing and merging my branch!14:24
hazmatfrankban, sorry about the delay14:26
frankbanhazmat: np14:27
benjithe bane of my existence: "Illegal comma at end of object literal"14:45
rick_h_benji: I was doing python wed night and realized "I can leave a trailing comma! It's so beautiful!"14:45
benjipfft14:45
hatchoh noes you have to write clean code "oh the horror" :P14:45
rick_h_comma first came all from the issue of not leaving a trailing comma14:46
rick_h_plus it's an IE issue...who cares about IE :P14:46
rick_h_err, except us that is14:46
hatchno it came from a bunch of geeks who didn't get enough drama in highschool so they need to stir some up now14:46
hatchlol14:47
benjiits the non-trailing-comma crazies that lead people to do this: 14:47
benjix = foo(bar14:47
benji  , baz14:47
benji  , biz);14:47
hatchlol that's so ugly14:47
rick_h_yep, what I did in php 14:47
hatchhaha sad14:48
benjiI have seen this in production Python code too, insanity on top of insanity.14:48
hatchI can honestly say that a trailing comma hasn't ever caused me to lose sleep14:48
benjiI'm special like that.14:48
hatchyeah in python it makes no sense14:48
* rick_h_ mumbles about special :P14:48
hatchlol14:48
hatchFriday!14:49
hatchlast night I educated 4 other devs on Juju14:52
hatchthey thought it was really cool14:52
hatchthey already knew about alternatives like docker.io so maybe we need to find some geek cred somewhere to make it viral14:52
gary_posterjujugui call in 714:53
hatchjcastro: when discussing it with these guys the hardest thing they had to understand was how relations work - it was hard to wrap their head around what happens when a relation happens - as in how does the app know about it's mongo connection for example14:55
hatchgary_poster: we are now using the link in the event on the calendar?14:57
gary_posterhatch yes.  jujugui call in 2.14:57
gary_posteralmost there15:00
gary_posterbenji bac frankban https://plus.google.com/hangouts/_/0ae499f5c2e2e483949d5f96802c30fdf603af8415:01
gary_poster(from calendar)15:01
gary_postersorry frankban :-P15:01
frankban:-)15:01
hatchbcsaller: on the review15:53
hatchbcsaller: should this not require a QA?15:53
* gary_poster to optician biab16:16
hatchbcsaller: review done - qa failed :(16:30
hatchrick_h_: so looking at these unit buttons - you are working on the 'remove' button?16:33
rick_h_hatch: yes, I've got the buttom working and looking at how to test it16:33
rick_h_I don't see a simliar test in the python env either. 16:33
rick_h_hatch: if you want I can push up what I've got and I can go test the go backend stuff for retry/resolve16:34
hatchI was pretty confident those worked in python.....because I wrote them :P16:34
hatchso I'm really curious what happened16:34
rick_h_hatch: yea, I bet they work, it's the go side that doesn't work and the python version that doesn't have an env test in the test_env_python16:34
bcsallerhatch: I'll look into that, odd that that same file passes the test.16:35
rick_h_hatch: did you want to chat then?16:35
hatchbcsaller: yeah that's what I was thinking....might be a side effect of you calling the methods directly in the test instead of relying on the whole app stack16:35
hatchrick_h_:  gimme a few to get a new env setup16:36
rick_h_hatch: rgr16:36
hatchrick_h_: ok calling16:40
benjihatch: you and I both wrote exactly the same commend on exactly the same line ("s/this//")16:45
hatchrofl16:45
hatch^516:45
benji^516:46
hatchwhat does the fox say? http://www.youtube.com/watch?v=jofNR_WkoCE17:11
* rick_h_ does a happy dance avert your eyes18:09
bcsallerhatch: fixed issue with branch I think if you'd take another look when you have a minute18:10
rick_h_jujugui need a review please https://codereview.appspot.com/1370604318:14
rick_h_I did a QA in my local lxc, if anyone wants to dupe instructions are in the proposal, but missing the steps to set the branch over18:15
rick_h_hatch: is the other branch going ok then? Or did you need a hand on that once this goes through?18:15
hatchrick_h_: I took an early lunch so haven't put a ton of time on it yet18:16
benjirick_h_: looking18:16
rick_h_hatch: k18:16
hatchjust reviewing bcsaller new branch18:16
rick_h_benji: ty18:16
rick_h_hatch: ok, going to hit EOD in an hour so just wanted to see what I can do to help unblock the release. If you've got it then I'll move along for the rest of the day18:16
benjiI have a cousin named "Ty" ("Tyson").18:16
rick_h_benji: :P ty ty18:16
benjiheh18:17
hatchyou COULD do it :P18:17
hatchjk18:17
rick_h_what's nice is you can read that either thank you ty, or ty thank you18:17
hatchbcsaller: your diff is all messed up now from the trunk merge :(18:17
hatchI wonder why that happens18:19
hatchit should pickup the diff properly18:19
hatchhehe implements!18:19
hatchbcsaller: so I see the fix for the qa failure - wondering if we should add a test for the full stack?18:20
rick_h_benji: replied, let me know if you disagree or have a better idea for a test to catch this type of issue going forward18:21
* benji looks18:22
benjirick_h_: +118:22
rick_h_benji: cool thanks for the review18:22
benjimy pleasure18:22
BradCrittendengary_poster: ping18:23
=== BradCrittenden is now known as bac
gary_posterbac on call will ping18:23
bacok18:23
hatchbcsaller: qa failed again :)18:23
hatchdid it not fail for you?18:23
bcsallerit worked here18:24
bcsallerlet me try it again18:24
hatchI get two errors "Relation added without matching service"18:24
bcsallerI get that now too, that from the trunk merge, it does work though which is odd18:25
bcsallerthe proper objects exist in both the fakebackend db and the client one18:25
bcsallerahh, the interaction with the delta stream is different18:26
bcsallerthe services are not in the delta data for this change maybe, but they come through anyway18:26
hatchahh - also bcsaller there is that delay from when I drop the file until the delta comes back...so on a real env those services could take...hours to come up?18:29
hatch*potentially*18:30
bcsallerhatch: absolutely 18:30
hatchso won't the user think that it's broken then?18:30
bcsallerthere is no UX around the status call18:30
bcsallerat this time, sure, that UX is a 'later' task18:30
bcsallerintegrated with notifications we can status running imports18:31
bcsallerthey queue as well so two dnd actions will result in pending imports18:31
hatchohh ok - could we just create a Panel which says 'deployment imported successfully, please wait for the services to become active'18:31
bcsallerand the delta does the real work at that point18:31
hatchjust 'something' to tell the people that it's working18:31
bcsallerwhich is no different than today18:31
bcsallercould change the message, sure18:32
hatchthe new notifications can't come soon enough :)18:33
rick_h_boooo stupid ci, why for you cranky today?19:00
gary_posterbac ping?19:01
hatchrick_h_: yeah I have no idea what's going on there19:05
rick_h_hatch: yea, looks like it didn't come up?19:05
rick_h_but there's another one wiithin a minute that passes19:05
hatchfor some reason it can't restart it19:05
rick_h_do we run multiple IE runs for each submission? /me didn't expect to see ie runs at 14:(47, 48, 50)19:06
hatchI don't understand the question19:08
rick_h_hatch: hangout real quick?19:09
hatchsure19:09
hatchmy 'server room' ran out of plugins19:45
benjijuju-gui: I have a branch up for review https://codereview.appspot.com/13592047/20:10
bacbenji: i'll look20:11
benjithanks20:11
bacbenji: i see you just missed the 400 line limit20:11
benjiso close20:12
bacbenji: your branch may be very long but it makes up for it through brute force boringness20:21
benjiit's much like my original operas20:22
gary_posterheh20:22
hatchlol20:23
gary_posterjujugui I have a pretty short branch long on tests and short on other code (but it hooks up the cancel buttons!).  May I have a reviewer? https://codereview.appspot.com/13677044/20:23
bcsallergary_poster: checking now20:23
gary_posterthank you bcsaller 20:23
hatchbcsaller: did you happen to push up a fix for that last failure?20:49
hatchjust want to make sure I didn't miss it and am holding you up20:49
bcsallerhatch: Still working on it, there is some disparity in how the relation import works wrt endpoint normalization, it does the import but sends only partial information in the delta20:50
hatchhmnm, anything I can help with?20:50
hatchor is it a one man project?20:50
bcsallerhatch: thanks for the offer, I'll poke at it a little more, if I don't have something soon I might ping you20:52
hatchsure thing20:52
gary_posterjujugui I just made a team Google calendar.  everyone should have privs to edit it.  I scheduled everyone on the calendar, biwweekly, as we discussed.20:57
gary_posterfor the exploratory QA day I mean20:57
bacgary_poster: got it20:57
hatchcoolio20:57
gary_poster:-)20:57
hatchthe 27th is the apps day off of being qa'd20:58
hatchevery second friday is it's EDO20:59
gary_poster:-)20:59
gary_posterbye y'all!  have a great weekend!21:04
hatchyou too21:04
hatchcya!21:04
hatchuploading 600pics to g+ sure takes a long time21:57
hatch:)21:57
rick_h_heh21:59
hatchit would be faster from my phone but I couldn't figure out how to upload them via the G+ app21:59
hatchI could only 'share' them which would share the low res version22:00
rick_h_set it to auto upload photos and sync22:00
rick_h_but yea, I use flickr because I hate the G+ photo integration these days22:01
hatchI hate flickr more actually haha22:01
hatchbest I've found is smugmug22:01
hatchI actually have a lot of pictures of the back of your head22:04
hatchyou gota quit walking infront of me22:04
hatchlol22:04
rick_h_lol, what?22:07
hatchon the team suppers and stuff22:07
hatchyou apparently walk in front of me a lot22:07
hatchhaha22:07
rick_h_sorry, don't realize it I guess22:08
hatchlol it's no big deal22:08
hatchthis htc one takes some darn good pictures22:08
hatchrick_h_: so on your machine are you always running in the lxc's ? Or do you use some other trickery to also test it spinng up new machines?22:10
rick_h_hatch: well I have a gui and charmworld lxcs always running. 22:10
rick_h_hatch: the juju stuff I bootstrap/destroy as I need22:11
hatchoh ok but always on the lxc...you aren't running openstack or anything22:11
rick_h_no22:11
rick_h_just lxc so far. If I need more than that I'd go to ec2/prodstack22:11
hatchok cool, my extra machine is an i5 with 8gb of ram so that should be more than enough to test out a pretty solid lxc juju deployment22:12
rick_h_yea22:12
rick_h_though my daily run on my desktop tends to run around 10gb of ram22:12
rick_h_but that's with vbox/windows always running, the two work lxcs, etc22:12
rick_h_chrome/ff both 22:12
hatchahh yeah ok22:15
hatchthis thing won't even be running a gui22:15
hatchso it should be good for juju testing22:16
hatchat 8gb22:16
rick_h_cool22:16
hatchthe trick will be figuring out how to expose it to the outside world so that I can use it on sprints22:19
rick_h_ssh tunnels ftw22:19
hatchthe issue seems to be my switch and router22:22
hatchthey never could agree on anything22:22
=== gary_poster is now known as gary_poster|away

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!