[02:06] <thumper> axw or wallyworld: Rietveld: https://codereview.appspot.com/13717044
[02:06] <thumper> wallyworld: how's baldrick?
[02:06] <axw> thumper: otp
[02:06] <wallyworld> ok. stupid tail
[02:06] <thumper> axw: ack
[02:07] <thumper> stupid tail or stupid dog?
[02:07] <wallyworld> both
[02:07] <wallyworld> thumper: did you talk to william?
[02:08] <thumper> wallyworld: yeah, but he was packing and moving yesterday
[02:08] <thumper> wallyworld: landed the first part where it doesn't write to the agent conf
[02:08] <thumper> and I don't need to any more
[02:08] <wallyworld> ok
[02:08] <thumper> so now we have just one place where the logging conf is saved
[02:08] <thumper> and that is in state
[02:08] <wallyworld> great
[02:09] <thumper> so we start the machine and unit agents with --debug
[02:09] <thumper> always
[02:09] <thumper> and the logger worker updates as necessary
[02:09] <thumper> as soon as it starts
[02:09] <wallyworld> sounds good
[02:11] <wallyworld> thumper: i'm not 100% across it - will unilaterally removing the file writer stuff up new environments? don't we want to only remove it for old envs?
[02:12] <thumper> wallyworld: the new environments won't ever set it
[02:13] <wallyworld> ok
[02:13] <thumper> wallyworld: and unfortunately we have no way to know which version it is from
[02:13] <thumper> no point asking if it is there
[02:13] <wallyworld> ok
[02:13] <thumper> the method returns an error if it isn't there
[02:13] <thumper> but we just ignore it
[02:45] <axw> sorry thumper was having my one-on-one with robbie ... reading back now
[02:45] <thumper> np, wallyworld handled it
[02:45] <thumper> was just a review
[02:45] <axw> ah cool
[02:45] <thumper> I have another coming
[03:10] <thumper> wallyworld: re: an integration style test, no we don't have one, and I think the effort in all the wiring up is out of proportion to result
[03:10] <thumper> given that all the parts are tested
[03:10] <wallyworld> famous last words :-P
[03:10] <wallyworld> ok though
[03:10] <thumper> perhaps it is something that we want to add to the more "live tests" that we do daily with jenkins
[03:10] <wallyworld> yeah
[03:11] <thumper> wallyworld: well, we have tests for all the parts
[03:11] <thumper> so I'm pretty confident there
[03:11] <wallyworld> ok
[03:20] <thumper> 24 files changed, 31 insertions(+), 158 deletions(-)
[03:20] <thumper> that is a good metric I reckon
[03:21]  * thumper waits for lbox to calculate the diff that LP has already done
[03:22] <thumper> wallyworld or axw: https://code.launchpad.net/~thumper/juju-core/add-cleanup/+merge/185964
[03:22] <thumper> lbox finally caught up
[03:22] <thumper> the description has the link now
[03:23] <wallyworld> just fixing some stuff, will look in a sec
[03:24] <thumper> kk
[03:31] <axw> thumper: just one question on rietveld
[03:31] <thumper> shoot
[03:32] <axw> no I mean, there's a question waiting for you on your MP
[03:32] <thumper> oh
[03:32] <thumper> ok
[03:34] <thumper> replied
[03:38] <axw> thumper: thanks, LGTM
[03:38] <thumper> ta
[03:58] <wallyworld> axw: whenever you have a moment, i've updated https://codereview.appspot.com/13725043/ to move the httpstorage as requested
[03:59] <axw> thanks wallyworld, I'll take a look
[03:59] <wallyworld> ta, no real urgency
[04:00] <axw> wallyworld: I thought it was ok being in environs, since it's used by things other than the provider. doesn't really matter I suppose.
[04:00] <wallyworld> axw: in environs, i'd prefer to keep stuff there generic. if it's ec2 specific, it belongs under the ec2 package imo
[04:01] <wallyworld> i'd also prefer that stuff not use it outside the provider i guess
[04:01] <wallyworld> since it is ec2 specific
[04:01] <wallyworld> and general code should not depend on ec2 isms
[04:02] <wallyworld> there's been way too much of that which has caused grief dealing with other providers
[04:02] <axw> doesn't tools lookup still use this to fall back on?
[04:02] <wallyworld> tools uses a http data source
[04:02] <wallyworld> which is not ec2 specific
[04:03] <wallyworld> i really wish the ec2 specific one would go away
[04:04] <axw> ok. for some reason I thought FindTools still depended on it
[04:05] <axw> wallyworld: ah, right. it's the sync code that I'm thinking of.
[04:06] <wallyworld> yeah, that will be migrated to use http://juju.canonical.com as soon as that is ready
[04:06] <wallyworld> so it's short term
[04:42] <wallyworld> axw: thanks for the review, i'll address the issues
[04:43] <wallyworld> i really wish Go had better debugging facilities
[04:43] <wallyworld> feels like a bad 1970's timewarp sometimes. everything is sooooo primitive
[04:48] <axw> wallyworld: heh :)   there is gdb support...
[04:48] <wallyworld> but not good IDe support
[04:48] <axw> I believe there's even some IDE integration with gdb/go
[04:48] <axw> liteide?
[04:48] <wallyworld> i use intellij
[04:48] <wallyworld> liteide may work, i will need to take another look i guess
[04:49] <wallyworld> wasn't much last time i looked from memory
[04:49] <axw> wallyworld: it certainly isn't up to par with Java, but I'll take it over C++ any day for debugging
[04:49] <wallyworld> really?
[04:50] <axw> then again, I'm not much of an IDE person :)
[04:50] <wallyworld> apart from java, which is first class, python is also great
[04:50] <axw> yeah
[04:50] <wallyworld> so how to you refactor etc with good ide support?
[04:50] <axw> to  be fair, they're much older
[04:50] <wallyworld> or navigate code, or find semantic usages etc
[04:50] <wallyworld> well go is 4 or 5 years old now?
[04:51] <axw> yeah, 4
[04:51] <axw> erm, the hard way :)
[04:51] <wallyworld> 4 years is plenty long enough for good tools to have emerged
[04:52] <axw> not sure if you follow the mailing lists, but there was an announcement last week of a new tool called "The Go Oracle"
[04:52] <axw> this will drive IDE developments
[04:52] <axw> for doing callgraph analyses and whatnot
[05:01] <wallyworld> yay, about time :-P
[05:05] <axw> wallyworld: also, there's basic renaming/refactoring capabilities in gofmt
[05:05] <axw> godoc gofmt
[05:05] <axw> if you're not aware of it..
[05:05] <wallyworld> i was not :-)
[05:06] <wallyworld> although in 2013 "basic" isn't enough anymore :-)
[05:06] <axw> yeah, it's certainly not all there
[05:46] <davecheney> why the fuck is the juju-core repo 22mb ?!?!
[05:46] <davecheney> who has been storing guttenberg in there
[05:55] <davecheney> help
[05:55] <davecheney> % bzr push  bzr+ssh://bazaar.launchpad.net/~go-bot/juju-core/1.14
[05:55] <davecheney> bzr: ERROR: Cannot lock LockDir(chroot-80212880:///~go-bot/juju-core/1.14/.bzr/branch/lock): Transport operation not possible: readonly transport
[05:55] <davecheney> cannot tag 1.14
[05:55] <davecheney> cannot tag 1.14.0
[06:51] <davechen1y> axw_: is there an issue for juju debug-log screwing up ?
[06:52] <axw_> davechen1y: not that I'm aware of?
[06:52] <davechen1y> ok
[06:52] <davechen1y> i guess that one went through to th keeper
[06:52] <davechen1y> but it's fixed ? right
[06:52] <davechen1y> on 1.14.0 ?
[06:52] <axw_> oh sorry
[06:52] <axw_> yes there was one
[06:53] <axw_> and yes it was fixed a while ago
[06:53] <axw_> I thought you meant one outstanding
[06:53] <axw_> I'll have a look for it
[06:54] <axw_> davechen1y:  here's one https://bugs.launchpad.net/juju-core/+bug/1211147
[06:54] <_mup_> Bug #1211147: Deploying service to bootstrap node causes debug-log to spew messages <juju-core:Fix Released by axwalk> <https://launchpad.net/bugs/1211147>
[06:55] <axw_> I can't remember what the other issue was...
[06:59] <axw_> davechen1y: https://bugs.launchpad.net/juju-core/+bug/1212148
[06:59] <_mup_> Bug #1212148: rsyslog accumulator strips newlines <juju-core:Fix Released by axwalk> <https://launchpad.net/bugs/1212148>
[06:59] <axw_> both merged in 1.13.2
[07:01] <rogpeppe> mornin' all
[07:02] <rogpeppe> i'll be out this morning for a doctor's appointment for a couple of hours (hopefully less), leaving in an hour.
[07:03] <axw_> hey rogpeppe. okey dokey.
[07:03] <rogpeppe> axw_: hiya
[08:02] <rogpeppe> dimitern, jam: i've got a doctor's appointment now. back before the standup i hope.
[09:03] <wallyworld___> jam: if you are interested - https://codereview.appspot.com/13632056 is part 1, part 2 to follow. part 2 will adjust tools fetching to use retry logic when necessary. this current work always does not use retry logic for tools fetching. bootstrap is fast again :-)
[09:04] <wallyworld___> well, upload tools is still slow
[09:04] <wallyworld___> but tools seeking is fast
[09:42] <rogpeppe> back
[09:59] <mgz> jam: mumble?
[10:58] <arosales> jam, ping
[11:12] <davecheney> jam: help
[11:12] <davecheney> i can't tag the 1.14 branch
[11:13] <mgz> davecheney: what's up sepcifically?
[11:14] <mgz> you should just be able to set your user to the bot and run tag against the remote branch as usual
[11:14] <davecheney> mgz: hmm, maybe that was it
[11:14] <davecheney> my history from the last tag is missing
[11:15] <jam> davecheney, arosales: ?
[11:15] <davecheney> mgz: bzr push  bzr+ssh://bazaar.launchpad.net/~go-bot/juju-core/1.14
[11:15] <davecheney> what am I missing ?
[11:15] <arosales> jam, davecheney needs some assistance with the tagging of 1.4
[11:15] <mgz> ah, that's not creating the tag, you want to make the branch?
[11:15] <arosales> 1.14, blocking the release needed today
[11:15] <jam> davecheney: "bzr tag -d bzr+ssh://go-bot@bazaar.launchpad.net/~go-bot/juju-core/1.14"
[11:15] <mgz> you need ://go-bot@
[11:15] <jam> well, you need to specify the tag as well :0
[11:15] <mgz> otherwise you're probably running it as dave
[11:16] <jam> bzr tag -d bzr+ssh://go-bot@bazaar.launchpad.net/~go-bot/juju-core/1.14 -r -1 juju-core-1.14
[11:16] <jam> natefinch: https://wiki.canonical.com/CDO/UbuntuServer/IOM-Lab is the "garage maas" that we have set up (I believe)
[11:17]  * TheMue => lunch
[11:17] <davecheney> jam: mgz thank you
[11:18] <natefinch> jam: thanks
[11:21] <davecheney> jam: mgz https://code.launchpad.net/~go-bot/gwacl/test
[11:21] <davecheney> ^ is this lp:gwacl ?
[11:22] <mgz> davecheney: nope.though it's probably a branch of it
[11:23] <mgz> lp:gwacl is ~gwacl-hackers/gwacl/trunk
[11:26] <davecheney> mgz: i'm confused the bot doesn't own the branch
[11:26] <davecheney> the bot owns the test branch
[11:28] <mgz> davecheney: the bot only owns branches that it manages
[11:28] <davecheney> meh
[11:28] <davecheney> no time for scenary today
[11:29] <davecheney> need to get mr page a release
[11:31] <arosales> mgz, jam, davecheney, once we have the source tar ball any way the ubuntu package can be built without directly (without going through saucy first)?
[11:32] <arosales> sorry, let me restate
[11:32] <arosales> mgz, jam, davecheney, once we have the source tar ball any way the ubuntu package can be built  directly (without going through saucy first)?
[11:32] <davecheney> arosales: no, but I can build from the source of the tarball to test
[11:32] <mgz> ...I'm still not sure I understand
[11:32] <davecheney> might need some jiggery pokery to get the tools to work
[11:32] <mgz> you can pull the tarball into the packaging branch and build that with the normal debian tools
[11:33] <davecheney> mgz: good idea
[11:33] <davecheney> that will work
[11:33] <davecheney> but probably not necessary
[11:33] <davecheney> i think I can fake the tools
[11:33] <arosales> mgz, I think davecheney dputs the built packages once they are available in saucy
[11:33] <davecheney> arosales: the build-release-tarball also does a smoke test compile of the source after building it anyway
[11:34] <arosales> I was asking if we could just build directly, and avoid the dput step
[11:34] <davecheney> arosales: no, i _want_ to do that, but we don't currently
[11:35] <arosales> davecheney, ah so you currently don't wait for it to be available in saucy.
[11:35] <davecheney> arosales: we need to wait for saucy _AND_ the ppa backports before we can announce the release
[11:35] <davecheney> but we do not need to wait for either of those to test it
[11:35] <davecheney> there will be ways of working around that
[11:36] <arosales> technically I don't see why we need to wait for saucy. That was my questions about building directly
[11:37] <davecheney> arosales: my mistake
[11:37] <davecheney> i was not clear in understanding your goal
[11:37]  * arosales not wording well either mgz didn't understand either.
[11:38] <davecheney> arosales: what do you want, not what do you want us to do :)
[11:39] <arosales> once you have the source tar ball building the packages should be identical to what gets built in saucy.
[11:39] <davecheney> arosales: correct
[11:39] <davecheney> not should
[11:39] <davecheney> _is_
[11:39] <davecheney> the tarball contains all the source code
[11:39] <davecheney> there are no external build depdencies
[11:40] <arosales> Thus to help get the release in the ppa today would it be possible to build juju 1.14 outside of the saucy archive so it is available in juju/stable sooner?
[11:40] <davecheney> arosales: no, that is not possible
[11:41] <davecheney> we do not have a build recipe for that
[11:41] <davecheney> i would *like* the juju source to contain the debian/ build recipe
[11:41] <davecheney> but at the moment that is not done
[11:41] <davecheney> ok 1/2 branches waiting on the bot to merge
[11:42] <davecheney> the other can be submitte after the release
[11:42] <arosales> davecheney, ok . . .
[11:42] <davecheney> arosales: i have not been clear
[11:42] <davecheney> the build release tarball contains the upstream source
[11:43] <davecheney> the magical ubuntu debian parts are missing
[11:43] <davecheney> so while you can build juju from the srouce
[11:43] <davecheney> you cannot replicate the packaging
[11:43] <davecheney> that magic is not something i have access too
[11:43] <davecheney> however, I do not think this is a major hurdle for smoke testing
[11:44] <arosales> smoke no, maybe for getting something out the door today.
[11:44] <arosales> afik anyone can build a ppa if they have the upstream source and the debian source package
[11:44] <davecheney> arosales: yes, it is possible
[11:44] <davecheney> no, we do not have the magic to do so
[11:45] <davecheney> arosales: i am working as fast as possible
[11:45] <arosales> davecheney, I know and its appreciated. I know your up late too. I was just inquiring about the getting the release into juju/stable step.
[11:45] <davecheney> arosales: in theory it is possible to skip that step
[11:46] <davecheney> at the 11th hour, without ever having tried it
[11:46] <davecheney> i don't know how to do it
[11:46] <davecheney> nor recommend it
[11:46] <mgz> arosales: so, I've not found the ppa useful or a good recommendation
[11:46] <davecheney> arosales: what do you need, and what time do you need it by ?
[11:46] <davecheney> when is the announcement ?
[11:46] <arosales> mgz, juju/stable?
[11:47] <davecheney> will a binary .zip be sufficient ?
[11:47] <mgz> but, it would be pretty trivial to change it to do basically what the release into saucy does, by just making it use a packaging branch straight up and merging the tarball into that
[11:47] <davecheney> jamespage: hello
[11:47] <arosales> davecheney, we'll need a ubuntu package.
[11:48] <arosales> davecheney, time wise it was never set to an actual hour. If it is not available in the next 4 hours then we'll probably miss today as the UK folks go offline and they are the web team that will do the announce.
[11:48] <davecheney> tarball is ~30 mins away
[11:48] <davecheney> less
[11:51] <dimitern> rogpeppe, ping
[11:51] <rogpeppe> dimitern: pong
[11:52] <dimitern> rogpeppe, I have a weird panic in a test when I run the full suite, but it's ok if I run each test on its own
[11:52] <rogpeppe> dimitern: which suite?
[11:52] <hazmat> so.. right now the most stable version of juju till the next tarball is ppa/devel
[11:52] <natefinch> jam: FYI logging in to garage maas is not working.  Seems likely I don't have permission.
[11:52] <rogpeppe> dimitern: and what's the panic?
[11:52] <davecheney> arg, fucking build falied
[11:52] <dimitern> rogpeppe, http://paste.ubuntu.com/6119111/
[11:52] <davecheney> trying again
[11:53] <dimitern> rogpeppe, provisioner - this is the code http://paste.ubuntu.com/6119112/
[11:53] <hazmat> arosales, davecheney re new stable version.. afaics we should have 1.13.3 in stable ppa
[11:53] <davecheney> hazmat: NO
[11:53] <dimitern> rogpeppe, it doesn't happen with the deployer, which also uses PasswordChanger the same way
[11:53] <davecheney> no, no no, a thousand nos
[11:53] <hazmat> davecheney,  why not.. forget the  undocumented even/odd stuff..
[11:54] <davecheney> hazmat: even if I could
[11:54] <davecheney> the tools owuldn't work
[11:54] <davecheney> really
[11:54] <davecheney> no
[11:54] <hazmat> hmm
[11:54] <davecheney> this is not a good idea to be trying
[11:54] <hazmat> trunk has a bunch of tools issues
[11:54] <davecheney> hazmat: sure, we're not releasing trunk
[11:54] <hazmat> davecheney, didn't you tell me to use 1.13.3 earlier today for a customer setup?
[11:54] <davecheney> we are relasing 1.14.0 which is 1.13.3 + 4 small patches
[11:54] <hazmat> ah.. ic
[11:54] <rogpeppe> dimitern: does it happen consistently?
[11:54] <davecheney> so, the best version of juju we have
[11:54] <dimitern> rogpeppe, so far on each run
[11:54] <davecheney> plus some azure fixes from brisbane
[11:55] <davecheney> so it's even betterer
[11:55] <dimitern> rogpeppe, tried updating mgo to r240, as the dependencies.tsv says - still the same error
[11:55] <hazmat> davecheney, so what's the transition process from dev to stable?  last dev gets incremental fixes.. till its marked stable?
[11:55] <dimitern> rogpeppe, would've tried with the latest mgo tip, but that just fails on its own tests
[11:56] <davecheney> hazmat: as it stands, we develop on trunk under an unstable dev version
[11:56] <davecheney> then a decision is made that a particular unstable tag looks good
[11:56] <davecheney> so we branch from there
[11:56] <davecheney> then start a new unstable series
[11:56] <davecheney> so
[11:56] <davecheney> 1.13.3 -> 1.14.0
[11:56] <rogpeppe> dimitern: could you put a log print just before line 114?
[11:56] <davecheney>        -> 1.15.0 -> 1.15.1
[11:58] <rogpeppe> dimitern: the weird thing is line 35
[11:58] <davecheney> arosales: 15 minute delay, the bot failed to run the tests correctly
[11:58] <davecheney> trynig again
[11:58] <hazmat> davecheney, so basically we tag a version of trunk or dev tag as release series, and create a release series branch against that and then do bug fixes against till its stable?
[11:58] <davecheney> if it fails, we'll go around th bot
[11:58] <dimitern> rogpeppe, the log doesn't show at all
[11:58] <dimitern> rogpeppe, what's weird about line 35?
[11:58] <davecheney> hazmat: no
[11:59] <davecheney> hazmat: docs/juju-release-process.txt
[11:59] <rogpeppe> dimitern: provisioner.SetPasswords should make an API call, right?
[11:59] <davecheney> hazmat: also https://docs.google.com/a/canonical.com/document/d/1bxekJclEzXT3b8fEmP2wHfZ2hiiYI-ojzBnr_2mVfpo/edit
[11:59] <dimitern> rogpeppe, no
[11:59] <davecheney> and about a million other google docs
[11:59] <dimitern> rogpeppe, that's the server-side test
[11:59] <hazmat> davecheney, if only they could be searched ;-) thanks
[12:00] <davecheney> hazmat: i believe you can ask your govt. for assistance there
[12:00] <rogpeppe> dimitern: oh, of course, sorry.
[12:00] <hazmat> davecheney, nice. citizens only get guns.. info requires using it
[12:00] <dimitern> rogpeppe, why is the session getting closed anyway? and why only on the last test
[12:00] <rogpeppe> dimitern: but you're not seeing a log message that's printed just before line 114?
[12:01] <arosales> davecheney, thanks for the continued work on it.
[12:01] <dimitern> rogpeppe, ah, sorry I see it yes
[12:01] <dimitern> rogpeppe, just after that the log continues with reset dummy environment
[12:02] <rogpeppe> dimitern: so you see the reset *after* the log message?
[12:02] <dimitern> rogpeppe, yes
[12:02] <davecheney> arosales: no problem, it's what i;m here for
[12:02] <davecheney> arosales: we're really close
[12:03] <davecheney> i'd like to not cowboy the packaging
[12:03] <davecheney> it is one of the few things that works well
[12:03] <rogpeppe> dimitern: could you print out the callers of dummy.Reset?
[12:03] <davecheney> and we'll only cock it up if we rush
[12:03] <rogpeppe> dimitern: (you can use "code.google.com/p/rog-go/exp/runtime/debug".Callers(0, 20))
[12:04] <rogpeppe> dimitern: e.g. log.Infof("dummy resetting; callers: %s", debug.Callers(0, 20))
[12:04] <arosales> davecheney, ack we should follow the process
[12:04] <dimitern> rogpeppe, just a sec
[12:05] <davecheney> arosales: merged, tag updated, building tarball
[12:05] <arosales> getting closer :-)
[12:06] <hazmat> davecheney, that doc seem quite right.. there is only one dev branch and tags.. so my previous description seems accurate. but the doc states.. "For stable releases they are branched from a known working devel branch"
[12:06] <hazmat> er.. doesn't seem quite right
[12:08] <davecheney> hazmat: for the 2 stable releases ive done
[12:08] <davecheney> one of which I am doing right now
[12:08] <davecheney> I branched from a devel tag
[12:08] <davecheney> that is all I can tell you
[12:09] <hazmat> davecheney, k
[12:10] <davecheney> hazmat: the pirate code is more, um, a guideline
[12:10] <natefinch> davecheney: nice
[12:10] <dimitern> rogpeppe, http://paste.ubuntu.com/6119176/
[12:11] <davecheney> arrr
[12:11] <natefinch> arosales, davecheney:  I'm building the 1.14 juju client windows installer.  I have a windows build of the juju client that I made off of the 1.14 branch.   I believe that's all that is required.  is there anything I'm missing?   The windows installer code didn't actually make it into 1.14, but it's completely separate from the client code, so it shouldn't matter.
[12:12] <davecheney> natefinch: just make sure you get the right revisions of GWACL et al
[12:12] <dimitern> rogpeppe, it seems somehow TearDownTest gets called
[12:12] <davecheney> the revisions are in the build-release-tools script
[12:12] <davecheney> dependencies.txt in the root of the 1.14 branch is incorrect
[12:12] <davecheney> in fact
[12:12] <davecheney> i'm going to delet eit
[12:12] <davecheney> arosales: release tarball: /home/dfc/devel/juju-core/1.14/scripts/build-release-tarball/juju-core_1.14.0.tar.gz
[12:12] <davecheney> DONE!
[12:12] <rogpeppe> dimitern: could you paste the log from running with -gocheck.vv
[12:12] <arosales> natefinch, I defer to davecheney
[12:13] <davecheney> jamespage: relase incoming in ~ 5 mins
[12:14] <dimitern> rogpeppe, http://paste.ubuntu.com/6119185/
[12:14] <arosales> jamespage, do you have a rough estimate on when saucy could have 1.14 available ?
[12:14] <jamespage> arosales, I'll pick it up tomorrow AM
[12:14] <jamespage> need to checkin with the release team as well
[12:15] <rogpeppe> dimitern: that is weird
[12:15] <jamespage> but as its 'stable 1.13' that should not be to much of a problem
[12:15] <dimitern> rogpeppe, it seems it calls both SetUpTest and TearDownTest before trying the actual test
[12:16] <rogpeppe> dimitern: could you push the branch - there are a couple of things i want to check
[12:16] <jamespage> davecheney, arosales, mramm: speaking of which I really need to get what we want to ship in Saucy nailed down here - https://bugs.launchpad.net/ubuntu/+source/juju-core/+bug/1219879
[12:16] <_mup_> Bug #1219879: [FFe] juju-core to 1.14.0 stable release for Ubuntu 13.10 <juju-core (Ubuntu):New> <https://launchpad.net/bugs/1219879>
[12:17] <davecheney> jamespage: arosales i would like to assign that bug to mark ramm
[12:17] <davecheney> does he have the bandwidth to deal with it ATM ?
[12:19] <dimitern> rogpeppe, https://codereview.appspot.com/13720045
[12:19] <arosales> jamespage, ack.  I will follow up on that bug. I think thumper-afk and jam had some ideas on bits needed for Saucy.
[12:20] <davecheney> arosales: will you please hold the bug for the moment
[12:20] <davecheney> jamespage: arosales https://launchpad.net/juju-core/1.14/1.14.0
[12:20] <davecheney> sinzui: https://launchpad.net/juju-core/1.14/1.14.0
[12:20] <davecheney> ^ sorry mate, stole your thunder
[12:20] <arosales> davecheney, will do. I was mostly going to sync up with thumper-afk and jam on saucy and update bug comments.
[12:21] <davecheney> jamespage: is it possible to build this release directly into the juju:ppa/stable PPA ?
[12:21] <davecheney> for P, Q, R and S ?
[12:21] <rogpeppe> dimitern: ok, i can reproduce the problem at least
[12:22] <jamespage> davecheney, I'm just prepping for saucy now then I can backport (have a script)
[12:22] <sinzui> davecheney, no
[12:22] <dimitern> rogpeppe, good start :)
[12:22] <arosales> davecheney, thanks for getting it built
[12:22] <sinzui> davecheney, jam controls gobot? did you ask jam to add the tags to goose and 1.14 branch?
[12:22] <davecheney> jamespage: BOJAH
[12:22] <davecheney> sinzui: looks lie he did gwacl
[12:22] <davecheney> see https://docs.google.com/a/canonical.com/document/d/1DuQfYq3SB1MJigrnpcuKBkfJfMJaTstQc4bRzN5Q0Uo/edit#
[12:22] <davecheney> i did the rest
[12:22] <sinzui> I did gwacl because I had permission
[12:23] <davecheney> ahhh
[12:23] <davecheney> cool
[12:23]  * davecheney table flips over our stupid permission model
[12:31] <rogpeppe> dimitern: this is very odd - somehow the call to mgo.Query.One is triggering the TearDownTest call
[12:32] <dimitern> rogpeppe, hmmm
[12:36] <davecheney> https://code.launchpad.net/~dave-cheney/juju-core/9001-update-release-tarball-for-1.14.0/+merge/186024
[12:40] <natefinch> arosales, davecheney: <unintelligible swearing>  my windows fixes didn't make it into 1.14... which means when you run juju on windows, what you get is "error: cannot determine juju home, neither $JUJU_HOME nor $HOME are set"
[12:41] <jam> natefinch: why didn't those get landed?
[12:41] <natefinch> they were landed the day after 1.14 was cut
[12:41] <natefinch> ... after 3 landing tries failed
[12:42] <natefinch> (from conflicts and then some bot problems IIRC)
[12:42] <davecheney> natefinch: are you sure
[12:42] <davecheney> oh
[12:42] <davecheney> so they only landed on trunk
[12:42] <davecheney> and they were not backported to 1.14 series
[12:42] <davecheney> well, fuck
[12:42] <natefinch> correct
[12:42] <natefinch> indeed
[12:42] <davecheney> arosales: what do you want to do ?
[12:42] <davecheney> i recommend not cutting a new release
[12:42] <mgz> 1.14.1 with some more things from trunk is fine
[12:43] <davecheney> but comitting nates fix to 1.14
[12:43] <davecheney> and he can do a dodgy .zip release
[12:43] <mgz> right.
[12:43] <davecheney> it'll be fine
[12:43] <davecheney> natefinch: can you please propse the merge anyhoo
[12:43] <natefinch> davecheney: sure
[12:43] <davecheney> we'll figure out the policy reguardless
[12:44] <dimitern> rogpeppe, any more progress?
[12:44] <davecheney> can I get a F'yeah for https://code.launchpad.net/~dave-cheney/juju-core/9001-update-release-tarball-for-1.14.0/+merge/186024
[12:44] <rogpeppe> dimitern: just more weirdness
[12:44] <mgz> davecheney: I don't like it much, because just fixing the release script is easy... but it seems okay for now
[12:44] <rogpeppe> dimitern: i'm starting to suspect a compiler bug - i'll try against go tip
[12:45] <jam> davecheney: I find it very inverted to have juju-1.14 as a label on gwacl/goose, but I can understand it from a pragmatic perspective.
[12:45] <arosales> davecheney, yes we'll need to get nate fixes in. Sounds like a 1.14.1 is needed.
[12:45] <dimitern> rogpeppe, wow.. these always come to me
[12:45] <rogpeppe> dimitern: yeah
[12:45] <rogpeppe> dimitern: i think somehow a stack frame may be being mashed
[12:46] <davecheney> jam: it was something that happened without much thought
[12:46] <natefinch> jam, mgz: how do I cherry pick revisions to merge into 1.14?  I have 1.14 checked out... but I don't want to waste people's time figuring out the bzr syntax
[12:46] <arosales> davecheney, so is it correct to state that a 1.14.1 is needed?
[12:46] <davecheney> a while back wallyworld___ and I started tagging goose with juju-x.y.z tags
[12:46] <davecheney> and it snowballed form there
[12:46] <davecheney> from there
[12:46] <mgz> natefinch: similar to your revert the other day
[12:46] <davecheney> arosales: i'd like to avoid it
[12:46] <jam> natefinch: cd $1.14 branch
[12:46] <rogpeppe> dimitern: because i can put a defer func(){sleep(some time); log.Printf("returning")}() into mgo.Query.One and it sleeps and i see the print
[12:46] <jam> natefinch: bzr merge -c REVINTRUNKITLANDED lp:juju-core
[12:47] <davecheney> and cut a special .zip file for windows from the tip of 1.14 series
[12:47] <rogpeppe> dimitern: but a log statement immediately after the return i never see
[12:47] <dimitern> rogpeppe, right
[12:47] <dimitern> rogpeppe, well, if it works with tip, we have something at least
[12:47] <arosales> davecheney, will there be a tools mismatch if natefinch pull from 1.14 tip?
[12:48] <davecheney> arosales: no, they won't notice
[12:48] <dimitern> rogpeppe, any ideas how to work around it?
[12:48] <rogpeppe> dimitern: i need to characterise it first
[12:48] <arosales> they = juju, correct?
[12:48] <davecheney> because nate's build will still think it is 1.14.0
[12:48] <arosales> davecheney, akc
[12:48] <arosales> ack
[12:48] <davecheney> to be sure, this is a BAD idea
[12:48] <davecheney> but something we can live with
[12:48] <davecheney> to avoid resetting the clock with the work jamespage is doing
[12:48] <arosales> davecheney, ok
[12:49] <jam> natefinch: with the caveat that you have to then backout your logrotaet changes again
[12:49] <jamespage> davecheney, don't like the sound of that
[12:49] <jamespage> I just uploaded to saucy
[12:49] <jam> natefinch:  "bzr merge -c 1788 lp:juju-core" should be about right
[12:49] <natefinch> jam: yep, had already taken that into account
[12:49] <davecheney> jamespage: thank you
[12:49] <davecheney> arosales: this is more importnat than a small bodge
[12:49] <rogpeppe> dimitern: thank goodness the bug doesn't seem to be too sensitive to code changes
[12:50] <davecheney> jamespage: i can cut 1.14.1 as soon as natefinch 's change is ready
[12:50] <davecheney> can you upload that to sauce and backport today ?
[12:50] <natefinch> jam: should I be merging directly into the 1.14 branch or a branch off of that?
[12:50] <dimitern> rogpeppe, good
[12:51] <davecheney> natefinch: checkout 1.14 branch
[12:51] <davecheney> merge the change there
[12:51] <natefinch> davecheney: cool
[12:51] <davecheney> bzr push lp:~natefinch/juju-core/1000-fix-windows-build
[12:51] <rogpeppe> dimitern: just building go tip
[12:51] <jamespage> davecheney, later tonight yes - you caught me on a baby break :-)
[12:51] <davecheney> then go to lp
[12:51] <davecheney> jamespage: ok, we'll do it properly
[12:52] <davecheney> sinzui: do you want to drive 1.14.1 ?
[12:53] <dimitern> rogpeppe, did you manage to isolate it to a minimal code snippet?
[12:53] <sinzui> davecheney, I suppose so.
[12:53] <davecheney> sinzui: "no" is a perfectly acceptable answer
[12:53] <rogpeppe> dimitern: ha ha
[12:53] <dimitern> rogpeppe, what?
[12:53] <davecheney> natefinch: is there a bug for the JUJU_HOME thing ?
[12:53] <davecheney> i need to assign it to a 1.14.1 milestone
[12:54] <natefinch> davecheney: I think so, lemme look
[12:54] <rogpeppe> dimitern: no chance!
[12:54] <sinzui> davecheney, Is dependencies.tsv really wrong in the 1.14 branch?
[12:54] <rogpeppe> dimitern: (not yet anyway)
[12:54] <natefinch> davecheney: at least indirectly
[12:54] <davecheney> sinzui: yes
[12:54] <davecheney> and we dont' use it
[12:54]  * rogpeppe now *actually* builds go tip
[12:54] <davecheney> and we can always add back a correct one in the future
[12:54] <davecheney> but an incorrect file is a hand grenade with the pin loose
[12:56] <davecheney> sinzui: in the future the goal is for the release-tarball script (and everything else) to consume dependencies.tsv
[12:56] <davecheney> but it doesn't today
[12:56] <davecheney> so on this stable branch
[12:56] <davecheney> i have voted to remove it
[12:56] <davecheney> as a 2nd pair of underpands
[12:56] <davecheney> pants
[12:57] <davecheney> natefinch: https://launchpad.net/juju-core/+milestone/1.14.1
[12:57] <davecheney> please adjust the JUJU_HOME bug to include this series
[12:57] <davecheney> or give me the original bug number and I'll do it
[12:57] <jamespage> davecheney, backports for p q and r uploaded to stable ppa as well
[12:57] <davecheney> jamespage: wonderful
[12:57] <davecheney> sorry, you're going tohave to do it all again in 40 minutes
[12:57] <rogpeppe> dimitern: ok, the issue's still there in go tip
[12:58] <sinzui> davecheney, understood. I see you removed dependencies.tsv from your branch to avoid confusion
[12:58] <natefinch> davecheney: should I not be using lbox propose? It keeps trying to propose against trunk
[12:59] <davecheney> natefinch: nah, that'll fuck up
[12:59] <davecheney> just propose the branch by hand
[12:59] <davecheney> sinzui: correct, this is just to avoid confusion
[12:59] <davecheney> we can always add a correct one tomorrow
[12:59] <dimitern> rogpeppe, bugger..
[13:00] <davecheney> ... for small values of tomorrow
[13:00] <natefinch> davecheney: https://code.launchpad.net/~natefinch/juju-core/014-fix-windows-build/+merge/186028
[13:00] <rogpeppe> dimitern: now trying to isolate
[13:00] <sinzui> davecheney, I only hesitate because I have just gotten up and finishing my first cup of coffee. I try not to commit when I don't have my wits about me
[13:00] <dimitern> rogpeppe, great
[13:00] <davecheney> sinzui: https://code.launchpad.net/~dave-cheney/juju-core/9002-set-stable-release-version-to-1.14.1/+merge/186029
[13:00] <davecheney> sets the version to 1.14.1
[13:00] <davecheney> sinzui: like i said, "no" is a perfectly acceptable answer
[13:01] <davecheney> there will be many more releases
[13:01] <davecheney> some less shotgun
[13:01] <davecheney> natefinch: bloody hell, this isn't a small change
[13:02] <natefinch> davecheney: 99% is mechanical, changing $HOME to a small function call
[13:02] <davecheney> ok, jam rogpeppe dimitern etc, https://code.launchpad.net/~natefinch/juju-core/014-fix-windows-build/+merge/186028
[13:02] <natefinch> davecheney: the comment is unfortunate, since it was written when the change was just a single line :/
[13:02] <davecheney> can we get a _1
[13:02] <davecheney> +1
[13:03] <davecheney> natefinch: found that bug ?
[13:03] <davecheney> sinzui: i'm going to reuse the 1.14.1 release notes
[13:03] <sinzui> understood
[13:03] <sinzui> davecheney, LGTM
[13:03] <davecheney> tradition dictates that i mention that 1.14.0 was replaced with 1.14.1
[13:03] <davecheney> nobody seems to care
[13:04] <rogpeppe> natefinch: please can you use lbox propose (you can use lbox propose -for lp:juju-core/1.14) so the changes can be seen in context
[13:04] <davecheney> sinzui:
[13:04] <davecheney> 1.11.4 is a small bugfix release for 1.11.3, please refer to the
[13:04] <davecheney> release notes for 1.11.3 for full details.
[13:04] <natefinch> rogpeppe: I tried that and it still tried to do it into trunk
[13:04] <davecheney> ^ for example, this was one previous release note
[13:04] <rogpeppe> natefinch: it worked ok for me recently
[13:04] <natefinch> davecheney: I think I was hallucinating... no bug for that, but we do have: https://bugs.launchpad.net/juju-core/+bug/1195757
[13:04] <_mup_> Bug #1195757: Package Juju for Windows <juju-core:Triaged> <https://launchpad.net/bugs/1195757>
[13:05] <davecheney> natefinch: that's a paddling
[13:05] <rogpeppe> natefinch: it might work now if you just do lbox propose
[13:05] <davecheney> I have to AFK for 10 mins to meet my partner at the train station (it is late, and she's coming home on her own)
[13:05] <davecheney> i will be back v shortly
[13:06] <natefinch> rogpeppe: trying
[13:10] <natefinch> rogpeppe: no luck
[13:10] <natefinch> rogpeppe: it completes, but nothing is in rietveld
[13:11] <rogpeppe> natefinch: did it print a codereview link?
[13:11] <natefinch> rogpeppe:  no :/
[13:11] <rogpeppe> natefinch: try "lbox propose -cr -for lp:juju-core/1.14"
[13:12] <natefinch> rogpeppe: right, oops
[13:12]  * natefinch forgot the -cr
[13:12] <rogpeppe> natefinch: the -cr *should* be automatic, but...
[13:12] <natefinch> rogpeppe:  still nothing printed out
[13:13] <natefinch> rogpeppe:  and nothing in rietveld....
[13:13] <rogpeppe> natefinch: odd. what does it print if you use the -verbose (or -debug) flag?
[13:15] <natefinch> rogpeppe:  it's really spammy, but looks like it's bailing because it was already proposed.... http://pastebin.ubuntu.com/6119401/
[13:15] <natefinch> rogpeppe: I gotta run for a few to help my wife with the kids, sorry
[13:16] <natefinch> rogpeppe: already put her off for a half hour
[13:16] <rogpeppe> natefinch: ok, np - i'll pull it locally and have a look in a bit
[13:16] <natefinch> rogpeppe:  thanks
[13:16] <rogpeppe> natefinch: currently trying to track down dimiter's bug
[13:18] <davecheney> bak
[13:19] <rogpeppe> dimitern: there's definitely *something* wrong going on. i've got it down to this so far: http://paste.ubuntu.com/6119414/
[13:19] <davecheney> rogpeppe: natefinch i think it would be better not to overcomplicate things nad just propose this via lp
[13:19] <rogpeppe> dimitern: if i change line 42 to use s.machine not s.machines[0], the test passes
[13:19] <davecheney> natefinch: rogpeppe please be mindful of jamespage 's time
[13:19] <davecheney> the more screwing around we do
[13:19] <davecheney> the more time he has to wait
[13:19] <rogpeppe> davecheney: ok, i'm on it
[13:20] <davecheney> rogpeppe: thanks
[13:20] <sinzui> for fsck's sake...my computer just rebooted and mir blocked me from logging back in
[13:22] <davecheney> you can take raring from my cold dead hands
[13:22] <davecheney> i'm not falling for the unstabl eupgrade trap again
[13:22] <jamespage> davecheney, I'm out for the next ~8 hours or so
[13:22] <dimitern> rogpeppe, interesting
[13:22] <jamespage> if you need more time I can do first thing UK time tomorrow
[13:22] <dimitern> rogpeppe, so it might be a stack overflow kind of thing perhaps? with the slice present
[13:22] <davecheney> jamespage: understood
[13:23] <rogpeppe> natefinch: in config.expandTilde, shouldn't path.Join in expandTilde be filepath.Join ?
[13:23] <rogpeppe> dimitern: no
[13:23] <sinzui> saucy has been quite a naught series. My keyboard is often unmapped and the audio drivers work on the roll of the dice
[13:23] <rogpeppe> dimitern: it really seems like a compiler bug
[13:23] <rogpeppe> dimitern: ha ha!
[13:23] <rogpeppe> dimitern: i thought you meant something suitable for a stackoverflow.com question!
[13:23] <rogpeppe> dimitern: i don't *think* it looks like stack overflow
[13:24] <rogpeppe> dimitern: after i've done this review, i'll have a look at the assembly
[13:24] <arosales> davecheney, so jamespage  uploaded 1.14.0 to the ppa but the client still needed a 1.14.1 release, which is in progress, correct?
[13:25] <davecheney> arosales: yes
[13:25]  * arosales thought natefinch was just going to use 1.14 tip . .  .
[13:25] <davecheney> arosales: we changed our minds about 2 pages ago
[13:25] <arosales> ok
[13:25] <davecheney> jamespage prefered that we did it correctly and said there was no blocker in getting 1.14.1 done 1st thing UK time
[13:26] <arosales> aside from to companies holding their PR announces
[13:26] <arosales> s/to/two/
[13:26] <davecheney> arosales: i need you to give me clear directoin
[13:26] <arosales> I guess I let folks know we'll shoot for tomorrow
[13:26] <dimitern> rogpeppe, ok, thanks for the help
[13:27] <davecheney> i can sto the 1.14.1 process and as soon as nates' windows fiz lands we can build a dodgy .zip version from trunk
[13:27] <davecheney> /s/trunk/tip
[13:27] <arosales> davecheney, jamespage: do you think we'll have a 1.14.1 ready UK morning?
[13:27] <arosales> davecheney, nah is already in progress
[13:30] <davecheney> arosales: ok, understood, the plan is to continue to release a 1.14.1 as soon as possible
[13:30] <arosales> davecheney, to confirm does 1.14.1 have natefinch fixes? Or is that still under review by rogpeppe ?
[13:30] <davecheney> still in review
[13:31] <davecheney> when it lands 1.14.1 will contain nates fixes
[13:31] <sinzui> davecheney, who is adding the tags to goose and 1.14.x branch? You?
[13:31] <rogpeppe> arosales: still in review, sorry - it's quite a substantial change
[13:31] <davecheney> bot is batting 2 for 0
[13:31] <davecheney> sinzui: I will do it
[13:32]  * arosales not sure how davecheney is cutting a 1.14.1 release with code still under review
[13:33]  * arosales goes to break the news that we are not releasing 1.14 today . .  .
[13:35] <davecheney> arosales: stop
[13:35] <davecheney> we _CAN_ release a 1.14.x today
[13:35] <davecheney> we can bodge up a windows client release without going through the release process
[13:36] <davecheney> arosales: i can cut the release as soon as the banch land
[13:36] <davecheney> the commands are queued up in my buffer
[13:38] <davecheney> arosales: i am waiting on your word to try for a proper 1.14.1 or keep 1.14.0 that we have now and bodge in the windows zip fix
[13:39] <davecheney> if we go for the latter option
[13:39] <davecheney> we can fix it in short order with a proper 1.14.1 release on the next day
[13:40] <arosales> it would be nice to have something that works today
[13:40] <arosales> and then we can fix the bits behind the scenes by tomorrow
[13:41] <arosales> davecheney, what if we go with the former option
[13:41] <davecheney> arosales: both options need natefinch rogpeppe  to land that branch
[13:41] <davecheney> going with a proper 1.14.1 probably adds another 8 hours delay
[13:41] <davecheney> at minimum
[13:41] <rogpeppe> davecheney: i've just finished the review
[13:41] <davecheney> rogpeppe: sweet
[13:41] <rogpeppe> davecheney: it LGTM with one minor issue
[13:41] <davecheney> mark that sukka as approved
[13:41] <davecheney> oh
[13:42] <rogpeppe> davecheney: one place is using path.Join instead of filepath.Join
[13:42] <rogpeppe> davecheney: as nate's not around, i think i might just fix it, and approve it myself
[13:43] <rogpeppe> davecheney: could you confirm my comment on https://code.launchpad.net/~natefinch/juju-core/014-fix-windows-build/+merge/186028 please?
[13:44] <natefinch> rogpeppe:  sorry... wrangling two kids right now... yes, you're probably right
[13:44] <rogpeppe> natefinch: are you able to fix it and approve soon, or i could do it if you can't
[13:44] <natefinch> rogpeppe: probably better for you
[13:46] <natefinch> rogpeppe: sorry and thanks
[13:46] <arosales> davecheney, lets proceed with the following:
[13:46] <arosales> for today we use the 1.14.0 with a hacked 1.14.0 msft client installer
[13:47] <arosales> tomorrow we update the links to use the 1.14.1 msft installer
[13:47] <arosales> davecheney, ack?
[13:47] <davecheney> arosales: ack
[13:47] <davecheney> arosales: hold
[13:48] <davecheney> i am locating the 1.14.0 debs to produce tools
[13:48] <arosales> natefinch, I'll need a 1.14.0 tools that uses 1.14.0 tip download link
[13:50] <davecheney> arosales: um, can you say again please
[13:50] <rogpeppe> davecheney: approved
[13:50] <davecheney> because we havne't bumped the version string in 1.14 trunk
[13:50] <davecheney> any release produced from there thinks it is 1.14.0
[13:51] <davecheney> rogpeppe: thanks
[13:51] <arosales> davecheney, I was saying for today we can use the 1.14.0 release jamespage already uploaded with natefinch msft client that pulls from tip.
[13:52] <arosales> after natefinch has the 1.14.0 build from tip we can proceede with a 1.14.1 proper release and I can adjust download links tomorrow.
[13:52] <davecheney> arosales: yes, that is is correct
[13:52] <davecheney> arosales: yes, that is also correct
[13:53] <arosales> ok so now I just need natefinch to kick a 1.14.0 msft client build that pulls from tip.
[13:54] <davecheney> ok, please hold
[13:54] <davecheney> https://code.launchpad.net/~dave-cheney/juju-core/9002-set-stable-release-version-to-1.14.1/+merge/186029
[13:54] <davecheney> waiting on this merge to fail
[13:55] <davecheney> if it _succeeds_ i'll have to back it out
[14:00] <sinzui> arosales, by adjust the download links, I think you mean remove the 1.4.0 tarballs from Lp after the 1.4.1 files re uploaded. Lp will show the new links because they are the latest uploads and since they are the only uploads on series 1.14, that is the only links available for that series
[14:01] <arosales> sinzui, no I mean downloads links of the msft installer from juju.u.c/install
[14:01] <davecheney> arosales: sinzui which we haven't yet procued
[14:01] <davecheney> so we can bodge that
[14:02] <davecheney> sinzui: arosales ignore
[14:02] <davecheney> what i just said was wrong
[14:02] <davecheney> ignore it
[14:02] <davecheney> i will _not_ be changing the tarball on the milestone
[14:03] <davecheney> as jamespage has alreday submitted it
[14:03] <sinzui> ah!
[14:03] <davecheney> nate, do this to make yorself a new tarball
[14:03] <davecheney> cd scripts/build-release-tarball/
[14:04] <davecheney> change line 41 to read
[14:04] <davecheney> bzr-checkout lp:juju-core/1.14 $TAG launchpad.net/juju-core
[14:04] <davecheney> bzr-checkout lp:juju-core/1.14 -1 launchpad.net/juju-core
[14:04] <davecheney> then run
[14:04] <davecheney> bash build-release-tarball.bash juju-1.14.0
[14:04] <davecheney> this will produce a tarball that is identical to what we uploaded to the milestone, but follows 1.14 trunk
[14:04] <davecheney> then you should be able to feed that to whatever prodeuces your windows .zip build
[14:08] <arosales> natefinch, note I'll need a msft download link to give the web team asap.
[14:09] <davecheney> natefinch: ping me if my instructions are unclear
[14:10] <rogpeppe> dimitern: i still don't know the underlying cause, but i've discovered a quick workaround for your problem (which also fixes a bug in your code)
[14:10] <rogpeppe> dimitern: set s.machines to nil at the start of provisionerSuite.SetUpTest
[14:11] <dimitern> rogpeppe, ah, ok will do, tyvm
[14:12] <dimitern> rogpeppe, if you manage to isolate and file a golang bug report, please give me a link to put it in a comment there
[14:13] <rogpeppe> dimitern: that's something you want to do anyway - otherwise you add 3 new machines in each test, ending up with 9 in total by the start of the last test
[14:13] <natefinch> arosales, rogpeppe, davecheney: back, sorry for the delay
[14:13] <rogpeppe> dimitern: tbh, you could probably just rename to SetUpSuite
[14:14] <dimitern> rogpeppe, no, I need a SetUpTest with the machines created before each case
[14:15] <rogpeppe> dimitern: ah, ok
[14:15] <rogpeppe> dimitern: in which case you want to reset the slice
[14:15] <rogpeppe> dimitern: aaaargh!
[14:15] <rogpeppe> dimitern: i see the problem!
[14:16] <rogpeppe> dimitern: it's not a compiler bug at all
[14:16] <rogpeppe> dimitern: the above issue *is* your problem
[14:16] <rogpeppe> dimitern: and that's it
[14:16] <arosales> natefinch, no worries I understand daddy duty
[14:16] <rogpeppe> dimitern: you're using Machines with stale state
[14:16] <arosales> natefinch, I was just needing a msft client installer that uses 1.14.0 tip
[14:17] <rogpeppe> dimitern: hmm, though...
[14:17] <natefinch> arosales: no problem, working on it
[14:18] <rogpeppe> dimitern: i still don't see why TearDownTest is being called
[14:18] <arosales> natefinch, thanks, ping me when you have it.
[14:18] <rogpeppe> dimitern: ah, yes, i understand that too now
[14:18] <rogpeppe> dimitern: it all becomes crystal clear, phew
[14:19] <davecheney> arosales: i have located the ppa's for 1.14.0
[14:19] <davecheney> proceeding to make tools
[14:20] <davecheney> lets hope this release bloody works
[14:20] <arosales> davecheney, lol
[14:20] <natefinch> arosales: http://ubuntuone.com/7aKY92pbRTXGe6IiSVzcMl
[14:20]  * rogpeppe crosses his fingers for the release
[14:20] <dimitern> robbiew, oh really?
[14:20] <robbiew> rogpeppe: ^
[14:20] <robbiew> lol
[14:20] <rogpeppe> lol
[14:20] <dimitern> oops :) sorry
[14:21] <arosales> I did that yesterday
[14:21] <rogpeppe> dimitern: yeah
[14:21] <mgz> it's funny every time it happens... :)
[14:21] <arosales> dang auto complete
[14:21] <dimitern> quassel had better tab completion than xchat it seems
[14:21] <dimitern> until it stopped working at all
[14:21] <rogpeppe> dimitern: it would have helped the diagnosis quite a bit if mongo didn't panic in Session.cluster, but returned an error instead
[14:22] <dimitern> rogpeppe, so you replaced the panic and caught it?
[14:22] <rogpeppe> dimitern: no
[14:22] <rogpeppe> dimitern: the panic was just a symptom of the bug in your code
[14:23] <dimitern> rogpeppe, what's the bug?
[14:23] <rogpeppe> dimitern: the bug is the one i pointed out above - you don't reset the slice in SetUpTest
[14:24] <rogpeppe> dimitern: which means that the first machines that you call Refresh on are from a previous test, and so have a stale mongo connection
[14:24] <dimitern> rogpeppe, oh god, yes!
[14:24] <rogpeppe> dimitern: innit
[14:25] <dimitern> rogpeppe, so it's no compiler bug then
[14:25] <rogpeppe> dimitern: no indeed.
[14:25] <dimitern> robbiew, whew :)
[14:25] <dimitern> robbiew, sorry
[14:25] <rogpeppe> dimitern: and my ba
[14:26] <dimitern> rogpeppe, I really ought to start typing 2 chars at least before pressing tab
[14:26] <dimitern> 3 actually
[14:26] <rogpeppe> dimitern: and my length of time to find the problem was exacerbated by the fact that i was seeing Query.One return - which it was, but only because a panic was happening
[14:26] <rogpeppe> dimitern: your IRC client should be better behaved
[14:27] <rogpeppe> dimitern: and choose the last-addressed username by default
[14:27] <dimitern> rogpeppe, absolutely - quassel does that
[14:27] <rogpeppe> dimitern: (mine seems to do that)
[14:27] <rogpeppe> dimitern: Konversation works pretty well for me
[14:28] <dimitern> rogpeppe, ah, there it is - just a option I need to tweak, and now it completes last spoken to nick
[14:30] <natefinch> davecheney: is there a script or something that sets the release number in the code?  I need to get the windows installer script hooked into something like that, so we don't have to hand-update the version in the script
[14:30] <davecheney> natefinch: there is a little logic in the package recipe that extracts the detail from version/version.go
[14:30]  * davecheney finds link
[14:31] <sinzui> okay, davecheney , natefinch I don't understand how we are avoiding a tools mismatch...oh, ^ are we tinkering with the version?
[14:32] <davecheney> natefinch: http://bazaar.launchpad.net/~dave-cheney/juju-core/package/view/head:/debian/rules#L10
[14:32] <davecheney> sinzui: no, no tinkering
[14:32] <davecheney> the version/version.go file continues to report 1.14.0
[14:32] <natefinch> sinzui: tinkering would be required for it to know it's a different version
[14:32] <davecheney> it sounds like nates biuld script doesn't extract the version automagically like the packageing does
[14:34] <natefinch> davecheney: right now my build script is cd cmd/juju && go-windows-386 build
[14:34] <davecheney> natefinch: that'l work fine
[14:35] <davecheney> seeya mup
[14:35] <sinzui> Are we incrementing to 1.14.1 *after* natefinch cuts the window's installer. Thus the windows release is different from the *nix release?
[14:35] <natefinch> davecheney: good :)  ...and then open up a windows VM and build the installer from the stuff under scripts/win-installer    ...my intent is to try to get it done via wine and an actual script at some point
[14:36] <davecheney> sgtm, lets boil one ocean at at eim
[14:36] <davecheney> time
[14:36] <natefinch> davecheney: agreed
[14:36] <davecheney> sinzui: http://paste.ubuntu.com/6119698/
[14:37] <davecheney> ^ how to bodge the tools uploader for saucy universe packages
[14:38] <sinzui> ! thank you davecheney
[14:38] <davecheney> im sorry for the hack
[14:39] <davecheney> folling the various naming gyrations is complicated
[14:40] <davecheney> following
[14:40] <davecheney> arosales: et al, tools coming online very shortly
[14:40] <davecheney> saucy is there
[14:40] <davecheney> raring is coming
[14:40] <davecheney> if anyone is running those series
[14:40] <davecheney> and wants to test
[14:40] <davecheney> now is the time
[14:41] <davecheney> sudo apt-add-repository -r  ppa:juju/devel
[14:41] <davecheney> sudo apt-add-repository ppa:juju/stable
[14:41] <davecheney> sudo apt-get update && sudo apt-get install juju-core
[14:41] <davecheney> make sure $(which juju) points to /usr/bin/juju
[14:42] <arosales> davecheney, for aws only correct?
[14:42] <davecheney> arosales: at this stage yes
[14:42] <arosales> davecheney, ok
[14:43] <davecheney> we can sync-tools in a sec
[14:43] <davecheney> but lets make sure nothing is cocked up
[14:43] <arosales> davecheney, ack
[14:44] <davecheney> jam, mgz: are you able to sync-tools to hp cloud and canonistack ?
[14:45] <mgz> davecheney: I should have the instructions and creds in my inbox somewhere
[14:46] <davecheney> mgz: ta
[14:47] <davecheney> mgz hold for a few mins
[14:47] <davecheney> still getting Q and P tools
[14:47] <mgz> sure.
[14:49] <davecheney> natefinch: i'm getting the wind up here
[14:50] <davecheney> how is your confidence on makig the 1.14.0 windows release ?
[14:50] <natefinch> davecheney: 100%.  I already gave the installer to arosales (at least, I gave him a link)
[14:50] <davecheney> mgz: sync tools
[14:50] <davecheney> arosales: 1.13.3 to 1.14.0 upgrade worked fine
[14:51] <davecheney> natefinch: cool
[14:51] <davecheney> i need to sign off very shortly
[14:51] <davecheney> otherwise there won't be much of me left to sign on tomorrow
[14:51] <natefinch> davecheney: thanks for all the hard work so late at night
[14:52] <davecheney> natefinch: not a problem, it is what i am here for
[14:52] <davecheney> mgz will confirm this is nothing like the hilarity of the 1.10.0 release
[14:52] <mgz> that was indeed fun.
[14:53] <davecheney> http://paste.ubuntu.com/6119756/
[14:53] <natefinch> in case I get hit by a bus, here's the build process for the windows installer: https://docs.google.com/document/d/1WMm6lcUTDA4wZnmA8YzfSXyLnQRz6Fqrr5g2lDtZZes
[14:53] <davecheney> OH SHIT
[14:53] <davecheney> this is not good
[14:53] <davecheney> well
[14:53] <davecheney> it's not terrible
[14:53] <davecheney> but fucking auto sync tools is extending the bootstrap time
[14:54] <davecheney> mgz: is this because the 'waves hands' magic data in simple streams needs to be updated ?
[14:55] <davecheney> hmm, only appears to affect ap-southeast-1
[14:55] <davecheney> too bad
[14:55] <davecheney> we'll live with it
[14:55] <davecheney> bootstrap works fine on ap-southeast-2
[14:55] <mgz> davecheney: maybe, I'm not up to date on what error messages are what with simplestreams
[14:56] <davecheney> yup, just a problem with ap-southeast-1
[14:56] <davecheney> we'll survive
[14:56] <davecheney> ap-southeast-2 and us-west-2 work fine
[14:56] <davecheney> this is another hilarous eventually consisent problem on aws
[14:56] <sinzui> :(
[14:56] <davecheney> arosales: i think, to the extent that I can test at 1 am
[14:56] <davecheney> we're good
[14:57] <arosales> davecheney, thank you sir for the late night hard push
[14:57] <arosales> mgz, let me know when aws, hp cloud tools are sync'ed
[14:57] <davecheney> if anyone wants to test in hp cloud
[14:57] <arosales> I can work on Azure
[14:58] <davecheney> it will work right now without tools synced
[14:58] <davecheney> it will just take longer
[14:58] <davecheney> to bootstrap
[14:58] <davecheney> -v, always -v
[14:58] <mgz> arosales: I'm assuming aws is done, because I'm using that as a source
[15:02] <davecheney> natefinch: don't forget to port your patches for the windows fixes, path => filepath back to trunk
[15:02] <natefinch> davecheney: thanks
[15:07] <mgz> hm, sync-tools needs a -v
[15:07] <mgz> having it just sitting there quietly makes me nervous
[15:07] <mgz> okay, canonistack done
[15:08] <davecheney> arosales: http://ec2-54-202-26-90.us-west-2.compute.amazonaws.com/?p=4
[15:08] <davecheney> done
[15:08] <mgz> and cute, 1.14 includes the armhf binaries, if canonistack grows an arm region :)
[15:08] <davecheney> mgz: but only for saucy
[15:08] <davecheney> atm
[15:08] <davecheney> all: i have to sign off
[15:08] <davecheney> be online in (insert short amount of time)
[15:08] <sinzui> thank you davecheney
[15:08] <davecheney> we'll do a proper 1.14.1 tomorrow
[15:08] <mgz> hp... I need to check creds with arosales I think
[15:08] <arosales> davecheney, woot
[15:08] <mgz> davecheney: thanks, have a good night
[15:08] <davecheney> night ya'll
[15:09] <arosales> davecheney, have a good night
[15:09] <arosales> thanks for your work
[15:09] <arosales> i'll sync with sinzui on 1.14.1
[15:09] <arosales> mgz, do you need a password reset for hp?
[15:14] <mgz> arosales: I'm going to check now
[15:14] <mgz> can't remember where we left it last time
[15:14] <arosales> ok, let me know.
[15:15] <arosales> I think you said you were able to login, but we had to update your info.
[15:17] <mgz> arosales: what user name do you have for me on that account?
[15:17] <sinzui> arosales, Lp will not promote the 1.14x releases because they are on an older series: https://launchpad.net/juju-core lists the latest release from trunk
[15:18] <mgz> the issue is my own account uses my canonical email address, so not sure how I log into the tools one instead
[15:18] <sinzui> https://launchpad.net/juju-core/+download lists the release after it lists all the releases from trunk
[15:31] <dimitern> ok, wrong channel
[15:31] <rogpeppe> dimitern: lovely, looking
[15:31] <dimitern> rogpeppe, https://codereview.appspot.com/13720045/ I have a review for you :)
[15:31] <dimitern> rogpeppe, thanks
[15:32] <gary_poster> dimitern, we like having you over there though :-)
[15:33] <dimitern> gary_poster, I'm there all the time :)
[15:33] <gary_poster> cool :-)
[15:55] <rogpeppe> dimitern: ping
[15:56] <dimitern> rogpeppe, here
[15:57] <rogpeppe> dimitern: just wondering why the provisioner auth function allows access to any machine
[15:57] <dimitern> rogpeppe, how else would you do it?
[15:57] <rogpeppe> dimitern: doesn't that depend on whether the machine is an environmanager or not?
[15:57] <dimitern> rogpeppe, hmm it should yeah
[15:58] <rogpeppe> dimitern: as it is, any machine can remove any other machine...
[15:58] <dimitern> rogpeppe, how about the lxc provisioner?
[15:59] <dimitern> rogpeppe, it has to be able to change any machine, which has parentId == currently auth'ed machine's id
[15:59] <rogpeppe> dimitern: that sounds reasonable
[15:59] <dimitern> rogpeppe, ok, so I'll make the getAuthFunc smarter
[16:00] <rogpeppe> dimitern: sgtm
[16:00] <dimitern> rogpeppe, it has to be either an environ manager, hence - access to all machines, or a machine agent, and access only that machine's children
[16:01] <rogpeppe> dimitern: seems reasonable. although...
[16:01] <rogpeppe> dimitern: should the environ manager be able to remove machines several levels deep?
[16:01] <rogpeppe> dimitern: i guess it probably should, as i suppose we should be able to force-remove a machine
[16:02] <dimitern> rogpeppe, yeah, leave a fallback option
[16:02] <rogpeppe> dimitern: i wonder if that should be the case for machine agents too
[16:02] <dimitern> rogpeppe, what?
[16:02] <rogpeppe> dimitern: so you're allowed access to all machines below the current machine
[16:03] <dimitern> rogpeppe, I don't think this is easier
[16:03] <rogpeppe> dimitern: i wasn't suggesting it because it was easier
[16:03] <dimitern> rogpeppe, it's easy enough to check the parent of a machine, but all parents up?
[16:03] <rogpeppe> dimitern: but because i think it might be more correct
[16:04] <dimitern> rogpeppe, don't think so
[16:04] <rogpeppe> dimitern: why should the global provisioner be able to force-remove a machine, but a machine-local provisioner not be able to force-remove a container?
[16:04] <dimitern> rogpeppe, we shouldn't jump levels of agents like that
[16:04] <dimitern> rogpeppe, it will be, but not more than 1 level deep
[16:05] <dimitern> rogpeppe, same goes for the environ provisioner
[16:05] <rogpeppe> dimitern: that means if you've got a totally broken instance/container, you won't ever be able to remove it, no?
[16:05] <dimitern> rogpeppe, can you do that now?
[16:06] <rogpeppe> dimitern: i don't know, but it's a definite issue
[16:06] <dimitern> rogpeppe, if it is, it's not an agent api problem
[16:06] <rogpeppe> dimitern: things do break, and we need to be able to clean up when they do
[16:06] <dimitern> rogpeppe, it's more like a management cli/api thing
[16:06] <rogpeppe> dimitern: hmm, you may well be right
[16:07] <dimitern> rogpeppe, yeah, let's not overcomplicate things just now
[16:07] <rogpeppe> dimitern: so the client does the remova
[16:07] <rogpeppe> l
[16:07] <rogpeppe> dimitern: sgtm
[16:07] <dimitern> rogpeppe, well, the cli does that now - and it's the only way
[16:07] <rogpeppe> dimitern: so i guess the environ manager *doesn't* get access to all machines
[16:08] <dimitern> rogpeppe, only the ones without a parent?
[16:08] <rogpeppe> dimitern: yeah
[16:08] <dimitern> rogpeppe, ok, looks better to me this way, nicely symmetrical
[16:09] <rogpeppe> dimitern: yeah
[16:09]  * dimitern has to step out for 10m
[16:26]  * dimitern is back
[16:30] <dimitern> rogpeppe, so, about that review?
[16:30] <rogpeppe> dimitern: still on it
[16:31] <dimitern> rogpeppe, ah, ok, sorry
[16:37] <rogpeppe> dimitern: reviewed
[16:37] <dimitern> rogpeppe, cheers
[17:49] <arosales> natefinch, juju-tools uploaded to Azure, when you have  a spare moment could you test msft client 1.14.0 with 1.14.0-juju-core in Azure?
[17:49]  * rogpeppe finishes for the day
[17:50] <arosales> mgz, did you get the hp tools uploaded?
[17:50] <rogpeppe> g'night all
[17:50] <natefinch> arosales: will do
[17:50] <arosales> rogpeppe, night
[17:50] <arosales> natefinch, thanks.
[17:51] <natefinch> arosales: I presume normally, we'd do that *before* the announcement, right? :)
[17:53] <arosales> yes, normally it would be part of the release process
[17:54] <arosales> mgz, for aws I see all the tools at /tools
[17:54] <arosales> http://juju-dist.s3.amazonaws.com/
[17:55] <arosales> mgz, however for hpcloud I see the 1.14.0 juju-tools @ tools/releases
[17:55] <arosales> for azure I followed the aws convention
[18:07] <natefinch> arosales: bootstrapped, waiting for machine 0 to get out of pending state
[18:15] <TheMue> *phew* all tests work
[18:29] <TheMue> so, time to leave. good night all.
[18:35] <natefinch> arosales: hmm didn't notice this before, but juju ssh doesn't work, because it expects to run the ssh command (which doesn't exist on windows)  I had always assumed we just used an ssh implementation in Go, but evidently not.
[19:03] <arosales> natefinch, hmm
[19:04] <arosales> natefinch, btw did your bootstrap come back with the default juju-tools bucket?
[19:04] <arosales> on the precise release stream?
[19:04] <arosales> natefinch, not sure how to handle ssh on windows but be good to log a bug for tracking/triage purposes
[19:07] <natefinch> arosales: how can I tell what bucket it uses?
[19:07] <natefinch> arosales: juju status gives me
[19:07] <natefinch> environment: azure
[19:07] <natefinch> machines:
[19:07] <natefinch>   "0":
[19:07] <natefinch>     agent-state: pending
[19:07] <natefinch>     dns-name: juju-azure-x4upm0herf.cloudapp.net
[19:07] <natefinch>     instance-id: juju-azure-x4upm0herf
[19:07] <natefinch>     instance-state: Created
[19:07] <natefinch>     series: precise
[19:07] <natefinch> services: {}
[19:07] <arosales> hmm, not sure post bootstarp
[19:07] <natefinch> arosales: it hasn't ever gotten off pending
[19:07] <arosales> during bootstrap you can see which tools are choosen during a --debug
[19:08]  * arosales will fire up an instance from ubuntu
[19:08] <natefinch> ahh ok. I'll rebootstrap after I try deploynig some stuff
[19:10] <arosales> natefinch, without ssh on windows your nice page, https://juju.ubuntu.com/docs/getting-started-keygen-win.html, is invalid, correct?
[19:10] <arosales> natefinch, well not invalid just doensn't function atm
[19:11] <natefinch> arosales: no no. That's still valid and needed to connect to the clouds... it's just that trying to do "juju ssh 0" won't work
[19:12] <sinzui> natefinch, I bootstrap with the -v which tells you what was used.
[19:12]  * sinzui looks for hidden log
[19:12] <natefinch> yeah, seems like everyone uses -debug or -v ... seems like we should have some better default than no output
[19:13] <sinzui> natefinch, As a developer withing with unstable tools, it becomes common. Canonistack has good months and bad weeks. I like to know when it is a bad week
[19:13] <arosales> natefinch, ah you are saying for msft clients connecting to clouds other than Azure
[19:14] <natefinch> arosales: yep, exactly
[19:15] <arosales> gotcha, just 'juju ssh 0' won't work
[19:27] <natefinch> arosales: I think there's a major bug with the windows client
[19:30] <natefinch> arosales: major is probably an understatement.  Critical? Catastrophic?  Will not function.
[19:31] <arosales> :-(
[19:31] <arosales> I don't think the juju tools got up thier correctly
[19:31] <arosales> I am re-uploading
[19:31] <arosales> not sure if that is what you are hitting.
[19:32] <natefinch> arosales: unlikely.  This looks like the client is telling the server to create directories with windows-style backslash path separators
[19:32] <arosales> natefinch, ok, I'll let you debug then
[19:33] <natefinch> arosales: I'll switch to EC2 to double check that it's not azure
[19:33] <arosales> natefinch, ack
[19:38] <arosales> well at least you hit that issue too
[19:39]  * arosales types into wrong window
[19:46] <hazmat> natefinch, you should be able to ssh into and have a look at the cloud init log
[19:49] <hazmat> natefinch, you can't use juju ssh .. but you should be able to ssh into the dns name with an ssh client.. juju ssh uses the bootstrap node
[19:50] <natefinch> hazmat: yeah, ssh is working, and ec2 shows the same symptoms when bootstrapped from the windows client
[19:50] <natefinch> sigh
[19:50] <hazmat> sinzui,  natefinch, incidentally  on the topic of using -v --debug all the time.. bug 1226786
[19:50] <_mup_> Bug #1226786: mechanism to set default --params to commands <juju-core:New> <https://launchpad.net/bugs/1226786>
[19:50] <hazmat> natefinch, can you pastebin /var/log/cloud-init-output.log
[19:51] <natefinch> haz
[19:51] <natefinch> hazmat: yep
[19:55] <natefinch> hazmat: https://pastebin.canonical.com/97613/
[19:57] <natefinch> hazmat: an example of the problem is   mkdir -p varlibjujudb/journal
[19:57] <hazmat> jam, incidentally all the places your doing for ssl cert support are all the same places we'll need to hit up again for proxy afaics
[20:00] <hazmat> natefinch,  that does look suspicious, client path separator perhaps.. is juju running on the machine?.. the end state there looks sane (mongo running, juju state initialized)
[20:02] <natefinch> hazmat: yeah, the path separator was my first thought.  I also see  \varlogjujumachine-0.log and  \var\lib\juju\server.pem as files in the root directory  (note, those are the filenames... not a path)
[20:04] <natefinch> hazmat: mongo is running, but jujud is not
[20:04] <hazmat> natefinch, we've got tons of filepath.Join which is going to be problematic
[20:04] <natefinch> hazmat: yeah.... ironically, by using the "right" function... we're shooting ourselves in the foot
[20:04] <hazmat> it would be nice to see the raw cloudinit, i'm curious how yaml is treating the \ separation
[20:04] <hazmat> indeed
[20:05] <natefinch> hazmat: I'm kinda surprised that the client is the one that defines the paths that get set up on the server
[20:05] <hazmat> natefinch, its only for bootstrap's cloudinit
[20:05] <hazmat> natefinch, although possible we'll see other issues with charm deploys and bundle assembly
[20:05] <natefinch> hazmat: I guess that makes sense
[20:05] <hazmat> since those are also client assembled
[20:06] <hazmat> natefinch, so the quick fix for this release, is to make a utils.PathJoin which does the unix thing, and replace extant uses of filepath.Join
[20:06] <hazmat> although we really need to check for other uses of filepath i guess since there are others uses of os.PathSep
[20:06] <natefinch> hazmat: yeah
[20:07] <hazmat> natefinch, and then revisit as we get further into windows support
[20:09] <natefinch> hazmat: k. I'll start working on that
[20:09] <natefinch> hazmat: if it were me, I'd pull the current installer off the website... it's just cause heartache and pain
[20:09] <hazmat> natefinch, given we have a press release out..
[20:10] <natefinch> hazmat: yes, but the big announcement was azure, not windows client.  I was looking for the windows client announcement, and almost didn't see it
[20:10] <hazmat> i'd rather yank it to be honest, and replace with a note for windows then have peopl dl something totally broken
[20:10] <hazmat> arosales, ^
[20:11] <hazmat> yeah.. its making its way through the news wires/pundit sphere now..
[20:11] <hazmat> natefinch, i don't actually see the download though
[20:12] <natefinch> hazmat: https://juju.ubuntu.com/install/
[20:12] <hazmat> oh. there it is
[20:12] <hazmat> jcastro, do you know how to update that till we get this fixed
[20:13] <hazmat> the windows download link.. its off of juju.ubuntu.com which we could fix there.. but really we also want to yank the binary from http://assets.ubuntu.com/sites/ubuntu/latest/u/files/juju/juju-setup-1.14.0.exe
[20:14]  * hazmat escalates via email
[20:14] <hazmat> mramm, ^
[20:14] <natefinch> hazmat: thanks, I was going to do the same
[20:14] <natefinch> hazmat: also: Searching 784 files for "filepath.Join"  307 matches across 92 files
[20:15] <mramm> arosales: ^^^^
[20:16]  * arosales reading backscroll
[20:16] <natefinch> arosales: short version: windows client is unusable
[20:16] <hazmat> arosales, posted to canonical-juju
[20:17] <arosales> hazmat, mramm, jcastro and I no longer have access to juju.u.c
[20:18] <arosales> I can file an RT and hopefully the IS team have access, but other than than we'll need to await the web team.
[20:18]  * arosales sure the IS does.
[20:18] <mramm> I would file an RT, IS does have access!
[20:18] <mramm> ;)
[20:18] <arosales> s/IS/IS team/
[20:19] <arosales> natefinch, is this a 1.14 specific issue you didn't see in your earlier testing?
[20:20] <hazmat> mramm, WTF to the rescue ;-)
[20:20] <natefinch> arosales: windows-specific ...  the version doesn't really matter.  Yes, I didn't see it in earlier testing. My testing was a lot lighter than it should have been. I thought it had already been tested, so I just tested the fixes I made.
[20:25] <hazmat> natefinch, really we only need to the filepath.Join fix on cloudinit parts
[20:26] <hazmat> natefinch, at least thats worth testing to see if that works by itself  for bootstrap and deploy
[20:26] <arosales> RT filed
[20:26] <hazmat> arosales, cool
[20:26] <natefinch> hazmat:  yep, definitely the place to start.  *at least* those parts need to be fixed
[20:27] <arosales> technically mark baker said in his blog availability tomorrow so natefinch you may have some time to cut a new release if you find the bug.
[20:27]  * hazmat returns to prepping training
[20:27] <natefinch> arosales: the problem is, it could be 100 spots in the code.
[20:29] <arosales> natefinch, understood, just letting you know
[21:04] <andreas__> natefinch: could line termination be an issue too? Just wondering, since it's another difference between windows and *nux
[21:06] <natefinch> andreas__: could be.   The immediate problems I saw were definitely path separators, though.
[21:07] <andreas__> yeah, sure, that was very visible
[21:07] <andreas__> in a screenshot someone sent to the list
[21:07] <andreas__> just wondering if the content is ok
[21:07] <natefinch> me :)
[21:07] <andreas__> ah :)
[21:08] <andreas__> do you still have that instance up? Might want to run cat -vet on one of those files
[21:08] <andreas__> should end in $, not ^M$
[21:08] <andreas__> iirc
[21:08] <natefinch> it's gone now... but in general, Go is actually really good about always just using \n and not \r\n, even on windows
[21:13] <natefinch> andreas__: fixed a couple spots in cloud init where we definitely want unix line endings (or rather, line endings that match the server OS, not the client OS).... seeing what else breaks now
[21:23] <natefinch> thumper: good morning
[21:23] <thumper> hi natefinch
[21:27]  * thumper trawls through the emails
[21:36] <sinzui> natefinch, arosales do we want to file a bug about the win client path non-sense and target it to the 1.14.1 milestone?
[21:37] <arosales> sinzui, yes as we'll need that but for the milestone and release
[21:38] <arosales> sinzui, I don't have the error but I can file a bug and assign to natefinch
[21:39] <arosales> 1.14 on Azure seems to be working on a sniff test
[21:39] <arosales> http://juju-azure-8jdith6sql.cloudapp.net/
[21:39] <arosales> sinzui, were you able to do any preliminary testing on HP?
[21:39] <thumper> natefinch: how goes the windows path fun?
[21:40] <sinzui> arosales, natefinch I think the bug just needs to state that the windows client needs to make unix paths when working with the bootstrap node.
[21:40] <sinzui> arosales, I have not
[21:43] <natefinch> thumper: I found at least one spot that needed to be fixed.. but still seem to be having problems
[21:44] <thumper> natefinch: need any help or someone to talk to?
[21:44] <arosales> bug 1226840 opened
[21:44] <_mup_> Bug #1226840: Windows client needs to make unix paths when working with the bootstrap node <juju-core:New> <https://launchpad.net/bugs/1226840>
[21:45] <natefinch> thumper: yeah... I don't know the cloud init stuff well.  Not to mention, my in-laws came over for the evening and it's about dinner time
[21:45] <thumper> natefinch, arosales: does the bug have all the details?
[21:45] <arosales> natefinch, mind putting your findings in the bug 1226840 and handing off?
[21:45] <_mup_> Bug #1226840: Windows client needs to make unix paths when working with the bootstrap node <juju-core:In Progress by natefinch> <https://launchpad.net/bugs/1226840>
[21:46] <natefinch> yep
[21:46] <thumper> heh, the dreaded slash vs. backslash issue
[21:46] <thumper> using filepath instead of path
[21:47] <natefinch> thumper: yep
[21:47] <thumper> I think path.Join always uses / yes?
[21:47] <natefinch> thumper: yep
[21:47] <thumper> but filepath.Join will use local
[21:47] <thumper> natefinch: so I may need to go grab a windows laptop?
[21:47] <thumper> at least I have one in the lounge
[21:47] <thumper> natefinch: how hard is the windows setup?
[21:48] <natefinch> thumper: you'd want to build on linux... I don't even know if it'll build on windows
[21:48] <natefinch> thumper: using Dave's cross compile scripts, at least, that's what I did
[21:48] <thumper> oh...
[21:48] <arosales> thumper, if you want to see the error the installer natefinch is nice for widows
[21:48] <thumper> natefinch: do you have a branch in progress?
[21:48] <thumper> I've poked the cloudinit stuff a lot before
[21:48] <natefinch> thumper: I have a couple changes, but they're really small
[21:49] <thumper> natefinch: can you commit and push?
[21:49] <natefinch> yep
[21:49] <thumper> and give me the branch
[21:49] <thumper> I could use it as a starting point
[21:49] <thumper> and I'll work with Ian and Andrew and Dave to move forwards
[21:49] <thumper> davecheney: you around?
[21:49] <arosales> thumper, current installer is at http://ubuntuone.com/7aKY92pbRTXGe6IiSVzcMl  per natefinch
[21:49] <thumper> arosales: no point me using that if it is broken
[21:50] <natefinch> thumper: branch is here: bzr+ssh://bazaar.launchpad.net/~natefinch/juju-core/014-fix-windows-build/
[21:50] <arosales> thumper, ack. Wasn't sure if you wanted to see the current error
[21:50] <thumper> natefinch: I wonder how go get works on windows with git & hg branches
[21:50] <thumper> arosales: can see it in the bug
[21:50] <natefinch> thumper: you have to install git and hg
[21:50] <natefinch> thumper: and bzr, obviously
[21:51] <thumper> and also, should be easy enough to find the parts in cloud init
[21:51] <thumper> if you know what you are looking for
[21:51] <thumper> it is the old problem
[21:51] <thumper> $1 to hit the machine with the hammer
[21:51] <thumper> $9999 to know where to hit it
[21:51] <arosales> thumper ok thanks. Any help on moving the bug forward would be a plus so we can move https://juju.ubuntu.com/install/ back to a download button.
[21:53] <natefinch> thumper: really appreciate the help.   Is there anything I need to do to give you permission to work on my branch?
[21:55] <thumper> natefinch: all I do is branch yours and commit locally
[21:55] <thumper> can then push to my area
[21:55] <thumper> and it has your changes
[21:55] <thumper> DVCS FTW
[21:55] <natefinch> thumper: btw, I made a "utils.JoinServerPath" so that we could 1.) find all the spots where we're intentionally not using filepath.Join, and 2.) use it later in case we ever have the client on linux and server on windows (not implemented, but available)
[21:55] <natefinch> thumper: ahh, right. awesome
[21:56] <thumper> natefinch: ah intersting point
[21:56] <thumper> although
[21:56] <natefinch> thumper: right now it just passes through to path.Join
[21:57] <natefinch> thumper: and the couple of spots in cloud init that use it seem to fix the problems I saw with files in root with backslashes...  but it seems to never finish bootstrap
[21:57] <natefinch> (even with the new fix that is)
[21:57] <natefinch> that's where I stopped
[22:00] <thumper> otp
[22:02] <thumper> ok
[22:03] <thumper> natefinch: so you are bootstrapping ec2 from a windows box?
[22:03] <natefinch> thumper: correct
[22:03]  * thumper nods
[22:03] <natefinch> thumper: also tried azure, same deal
[22:04] <thumper> ok, I'll take a look and talk with davecheney about his cross comple stuff
[22:04] <thumper> and grab one of the kids laptops to test on
[22:05] <arosales> thumper, note I didn't see this problem on 1.14 with ubuntu on Azure, and davecheney tried aws
[22:05] <arosales> I'll bootstrap hpcloud real quick too
[22:05] <thumper> arosales: you *don't* see the problem?
[22:05] <natefinch> thumper: cross compile is pretty easy.  basically just need  to be running Go from source, run Dave's script to generate the different builders, and then you can run "go-windows-386  build"   (or generically go-OS-arch  in place of regular go tool to run that tool)
[22:06] <thumper> natefinch: is your branch based on 1.14 or trunk?
[22:06] <arosales> thumper, correct, I do _not_ see the problem on ubuntu clients
[22:06] <natefinch> thumper: the one I linked is based on 1.14
[22:06] <thumper> so who does see a problem?
[22:06] <natefinch> thumper: he's not running the client from windows
[22:06] <thumper> ah
[22:06] <thumper> in which case arosales, you don't count
[22:07] <thumper> natefinch: hmm, I'm not running go from source
[22:07] <thumper> I may ask davecheney to do the actual compiles for me :-)
[22:07] <thumper> hmm...
[22:07]  * thumper starts
[22:08] <thumper> natefinch: we aren't likely to use cloudinit on windows servers
[22:08] <thumper> natefinch: so using a server path there not such a big deal
[22:08] <thumper> natefinch: but useful to have the method for all the agents
[22:11] <arosales> thumper, just passing along a data point.  I'll let you get to it.
[22:11] <thumper> :)
[22:11] <thumper> ack
[22:20] <natefinch> thumper: thanks again for the help.  I'm going AFK for dinner, but will check in after. You can also throw builds at me to run until Dave gets online.  he may be in late, he was up until 1am.
[22:21]  * thumper nods
[22:21] <thumper> found and fixed one
[22:21] <natefinch-afk> thumper: nice
[22:23] <thumper> in a way, this is kind of funny
[22:49] <thumper> natefinch-afk: lp:~thumper/juju-core/014-fix-windows-build, I have just used path.Join in cloudinit and upstart, as those are linux specific as far as I know
[22:49] <thumper> and I think we need more thought about supporting multiple server operating systems
[22:50] <thumper> I also added a trace to write out the cloud init that is generated
[22:50] <thumper> so the commandline can see the bootstrapped cloudinit
[22:50] <thumper> davecheney: can you ping when you arrive?
[22:50] <thumper> davecheney: although if you are starting late due to your late start, you might hit me at the gym, so I'll reply when back
[22:51] <thumper> natefinch-afk: at least writing out the cloudinit will let us eyeball the setup so we can see if there are other places where we are missing slash/backslash tweaks
[22:51] <thumper> simplest way to see it is to do this:
[22:52] <thumper> juju bootstrap --log-config=juju.environs=TRACE --show-log
[22:52] <natefinch-afk> thumper: back
[22:52] <natefinch-afk> thumper: good thinking about printing out cloudinit ... probably handy to have anyway
[22:53] <thumper> gah, I hit the 1.14 / trunk azure thing trying locally
[22:53] <thumper> natefinch-afk: yeah, I think so
[22:53] <thumper> and since it is at TRACE level
[22:53] <thumper> you have to explicitly ask for it
[22:53] <thumper> --debug won't show it
[22:53] <thumper> natefinch-afk: there was another place in cloudinit you had missed, but also the upstart service scripts
[22:54] <thumper> it seems that go tries to be magic
[22:54] <thumper> if you call filepath.Join('/var/lib/juju', 'blah') on windows it gives you '\var\lib\juju\blah'
[22:55] <thumper> at least that is what it looks like
[22:55] <thumper> not tried it
[22:55] <natefinch-afk> thumper: ug... that seems like too much magic.
[22:56] <thumper> I think that is why we see 'varlibjujudb'
[22:56] <thumper> as the \v -> v
[22:56] <thumper> weird that sometimes the slashes get switched completely
[22:56] <thumper> and sometimes, just bits of it
[22:56] <natefinch-afk> it's interesting that in certain spots we were getting no separator and certain spots we got backslashes
[22:56] <natefinch-afk> yeah
[22:57] <thumper> if you are able to comple and run that branch, with the logging and pastebin the cloudinit, we can eyeball it while it tries to start
[22:57] <thumper> natefinch: in two weeks, I'll be an hour clouser to you
[22:57] <thumper> as nz hits UTC+13
[22:57] <natefinch> heh
[22:58] <thumper> seems that there is a month of that, then we hit another hour closer as you fall back an hour
[22:58] <thumper> hi davecheney
[22:58] <thumper> and your alter ego davechen1y
[22:59] <natefinch> thumper: error: flag provided but not defined: --show-log
[22:59] <thumper> ah... yeah
[22:59] <thumper> use --debug isntead
[22:59] <thumper> but the log-config should still work
[22:59] <thumper> --show-log is obviously just on trunk
[23:01] <natefinch> thumper: <unintelligible swearing>   why the hell does the command line's scrollback default to like 200 lines :/
[23:01] <thumper> haha
[23:01] <thumper> can you set it to bigger?
[23:01] <natefinch> thumper: yeah
[23:02] <natefinch> default is 300.... wtf is this, 1990? :/
[23:04] <natefinch> thumper: http://pastebin.ubuntu.com/6121592/
[23:04] <natefinch> thumper: apologies ahead of time for line ending munging
[23:05] <natefinch> thumper: actually sort of nice for the certs, though :)
[23:05]  * thumper reads
[23:07] <thumper> natefinch: ok, that looks like it should work
[23:07] <thumper> lets wait and see
[23:08] <natefinch> thumper: looking good.... machine 0 is up
[23:09] <thumper> \o/
[23:09] <thumper> now the rest of the cloudinit bits are created by machine 0
[23:09] <thumper> so there shouldn't be any more issues
[23:09] <thumper> lets get this merged into 1.14
[23:09] <thumper> and then into trunk
[23:10] <thumper> natefinch: I can push and propose mine, and you can review if you like
[23:10] <natefinch> sounds good
[23:11] <thumper> oh ffs
[23:11]  * thumper just uses LP
[23:11] <natefinch> haha
[23:12] <natefinch> thumper: just in case, here's the contents of cloud-init-output.log: http://pastebin.ubuntu.com/6121614/
[23:14] <thumper> natefinch: https://code.launchpad.net/~thumper/juju-core/014-fix-windows-build/+merge/186179
[23:15] <thumper> natefinch: so you were able to get a successful 'juju status' from windows?
[23:15] <natefinch> yep
[23:15] <thumper> awesome
[23:15] <natefinch> thumper: http://ec2-23-20-77-242.compute-1.amazonaws.com/wp-admin/install.php
[23:16] <natefinch> thumper: end to end.  makes me happy.
[23:16] <thumper> \o/
[23:19] <thumper> natefinch: fyi, you don't need to claim the review before you do it, if you are a member of the team that has a pending review, and you provide a review status with the comment, you claim it automagically
[23:20] <natefinch> cool
[23:23] <arosales> wallyworld___, hello do you have an RT open for hosting juju-tools simple streams?
[23:23] <wallyworld___> arosales: yes - you were cc'ed on it :-)
[23:23] <wallyworld___> i can look up the number
[23:24] <wallyworld___> 63925
[23:25] <arosales> wallyworld___, thanks for reminding me. I'll post to that RT
[23:25] <wallyworld___> ok. hope they act on it soon
[23:25] <natefinch> thumper: reviewed, approved.  I gotta close it up for the night
[23:27] <wallyworld___> thumper: looks like i missed some fun with windows. i skimmed some of the backscroll
[23:28] <natefinch> wallyworld___: fun.... yeah.
[23:28] <natefinch> I'm at EOD. Thanks for the help thumper.
[23:31] <davecheney> sinzui: ping, we should tool up for a 1.14.1 release later this week
[23:31] <davecheney> just as a tester
[23:32] <thumper> wallyworld___: yeah
[23:33] <thumper> wallyworld___: there is a clear difference between something running on windows and not crashing, and having the tool actually work
[23:33] <thumper> wallyworld___: magic path issues
[23:33] <wallyworld___> sigh
[23:33] <wallyworld___> unix was there first
[23:33] <thumper> expect more pain like this when we want to have the server be windows
[23:33] <wallyworld___> why didn't windows stick to convention
[23:33]  * thumper shrugs
[23:34] <thumper> I expect that msdos just followed the earlier dos
[23:34] <thumper> and it flowed from there
[23:34] <wallyworld___> cpm
[23:34] <wallyworld___> thumper: i have a thing at the school today at the same time as the code review meeting
[23:34] <thumper> ok
[23:34] <wallyworld___> so we could reschedule till tomotrrow
[23:34] <thumper> did you want to do it earlier?
[23:35] <thumper> I'm also happy to reschedule
[23:35] <wallyworld___> i'd prefer to do some coding :-)
[23:35] <thumper> haha
[23:35] <wallyworld___> i want to get some bootstrap things done
[23:35] <thumper> ack
[23:35] <wallyworld___> should be finished today though, hence clear my plate wrt that issue
[23:36] <wallyworld___> i just wish my branch had been looked at by the ocr last night :-(
[23:36] <wallyworld___> sigh
[23:42] <thumper> wallyworld___: which branch, I could look
[23:42] <wallyworld___> thumper: that would be neat, but be careful what you wish for :-) https://codereview.appspot.com/13632056/
[23:43] <wallyworld___> i had a high level pre imp with roger, but the exact implementation was not discussed, just the high level removing of reties in s3
[23:43] <thumper> wow
[23:43] <wallyworld___> it's a lot of files touched, but only a few lines in each
[23:44] <thumper> I'll look when back from the gym
[23:44]  * thumper nods
[23:44] <wallyworld___> ok, thanks muchly
[23:44] <wallyworld___> bootstrap is fast again now :-)
[23:44] <wallyworld___> and live tests on ec2 pass
[23:44] <wallyworld___> but they sure do take ages to run
[23:46] <thumper> \o/
[23:46] <thumper> I know what you mean about wanting to code again
[23:46] <wallyworld___> yeah
[23:46] <thumper> I've now cleared my plate from all previous pending branches
[23:47] <thumper> and was going to start with the kvm stuff this morning
[23:47] <thumper> but saw the windows bootstrap issues
[23:47] <wallyworld___> cool
[23:47] <thumper> so helped out there
[23:47] <thumper> will look at your review this avo, and start poking kvm
[23:47] <wallyworld___> ok, ta