[05:16] StevenK: https://code.launchpad.net/~wgrant/launchpad/bm-buildercache/+merge/185968 [05:17] wgrant: http://pastebin.ubuntu.com/6117968/ [05:20] StevenK: headerspan still confuses me, not least because person !== null surely makes more sense. [05:21] headerspan seems to look completely different depending on whether it's a draft or not. [05:21] Perhaps construct it independently in those two cases. [05:22] But otherwise it's looking much more sane. [05:25] wgrant: http://pastebin.ubuntu.com/6117982/ [05:26] + var headerspan = null; [05:27] Also consider headerspan = Y.Node.create('Comment by on ') [05:28] Roughly as readable as a template, without the overhead of using an actual template engine. [05:28] wgrant: Then we don't need the extra span [05:29] wgrant: I wasn't sure how JS was about if (...) {\n var blah; } else { var blah; } [05:30] Oh, we do need the span, so we can use .set(), right [05:30] StevenK: They should both end up in function scope. [05:31] I don't think ECMAScript has block scope. [05:32] 81: 'headerspan' is already defined. [05:32] 84: 'headerspan' used out of scope. [05:32] 87: 'headerspan' used out of scope. [05:32] From that lovely thing, make lint [05:32] Bah [05:32] OK, var headerspan; [05:32] But uninitialised > null; [05:33] So [05:33] Now this code is in a form that I can vaguely understand what it does! [05:33] wgrant: http://pastebin.ubuntu.com/6117991/ [05:36] StevenK: Why do you insert before the next row, rather than after the matching row? [05:38] wgrant: To handle multiple comments on one row [05:38] So they're shown in order [05:38] Would it make more sense to have a comment container row that then just has a sequence of comment divs for that line within it? [05:39] Hmmm, do I really want to rewrite this again? :-) [05:39] Won't the IDs conflict if there are multiple comments on a single line? [05:39] No, we only set ids for draft comments now [05:39] Ah [05:40] Because they are only rows we are going to want to find again [05:40] Published comments are displayed, but are static [05:44] * StevenK sighs [05:45] if (draft === true) { .... if (draft === true) { ... } } [05:49] wgrant: r=me [05:54] Thanks === tasdomas_afk is now known as tasdomas === tasdomas is now known as tasdomas_afk === tasdomas_afk is now known as tasdomas [11:26] is there a way to upload files quickly to launchpad bug reports without using http? ftp maybe? [11:27] HTTP is a better file transfer protocol than FTP anyway ... [11:27] yes but launchpad easily fails on it [11:27] very easily sometimes [11:27] and there is no recovery eother [11:27] You'd probably do better to quote an OOPS ID or something [11:28] It's possible to attach files using the API; it's still over HTTPS, but a somewhat different path from the web UI [11:28] cjwatson, how does it work exactly? command line driven? [11:29] https://help.launchpad.net/API/launchpadlib [11:29] However, like I say, if you're hitting an OOPS you should quote it before wasting time on different methods [12:17] cjwatson, ok thanks. Next OOPS I get I'll try and come back === tasdomas is now known as tasdomas_afk === tasdomas_afk is now known as tasdomas === lifeless_ is now known as lifeless [15:16] Ursinha: How's bug 1201485 going? Just wanted to make sure that we'd have it in time for use before release [15:16] <_mup_> Bug #1201485: Need to import translations for the unity daily builds [15:31] cjwatson, I'm writing the final tests, should put it for review today [15:31] Brilliant :-) [15:31] :) [15:32] seb128 will be your friend === tasdomas is now known as tasdomas_afk === tasdomas_afk is now known as tasdomas === tasdomas is now known as tasdomas_afk