[01:29] hi axw [01:29] hey thumper [01:30] axw: what does ReadFull do? [01:30] ReadFull reads exactly len(buf) bytes from r into buf. It returns the [01:30] number of bytes copied and an error if fewer bytes were read. [01:30] oh cool [01:30] yeah, that's better than the loop [01:36] axw: I only noticed it because I occasionally habitually run "make check" when I switch to an updated trunk [01:36] and it errored the first time and not the second [01:36] actually, it didn't fail again [01:37] that's race conditions for you :) [01:37] glad it didn't cause too much strife [01:42] thumper: last one for the 1.15 release i hope https://codereview.appspot.com/13800043 [01:42] axw: no, not strife. I've spent lots of time in the past dealing with race conditions [01:50] * thumper objects horribly [01:52] thumper: re jc.Set? [01:52] yes [01:52] now on juju-cev [01:52] dev [01:53] how about testing/basesuite [01:53] or basesuties [01:53] suites [01:53] testing/testbase? [01:53] I'd be happy with that [01:53] shall I do it now? [01:53] doesn't have to be about suites [01:53] sure [01:54] worth having any test helper methods and functions that don't drag in extra dependencies [01:54] keep it loopless if possible [01:54] should be possible [01:54] I say go for it [01:55] * thumper finishes wallyworld's review then goes for it [01:55] \o/ [01:55] s/review/reviews [01:55] and we need to talk about logging [01:56] ack [01:56] * thumper dedicates 20 minutes to this task [01:56] if it takes longer than that, interrupt me [01:56] make that 30 minutes [01:57] thumper: it can wait till later, but am I likely to get a lgtm on sshstorage today? [01:57] axw: yes, I'm at the disposal of you two today [01:57] after this hacking [01:57] bueno [01:57] thanks [01:58] * axw looks at authenticated httpstorage [02:06] bugger [02:07] * thumper forgot to add the directory before moving things to it [02:07] bzr lost track [02:08] * thumper found bzr mv --after [02:08] hey thumper got a couple of min? [02:09] I think robbie (kvm robbie not cdo robbie) is out all next week [02:09] sure [02:09] so if you want to round trip with him on kvm issues it is going to have to be today :/ [02:09] yeah... [02:09] he scheduled a meeting 1am nz saturday [02:09] ouch!!!! [02:09] that is nutto [02:11] yeah, at least I'm down as optional :) [02:11] mramm: did you want to hangout? [02:11] I just wanted to tell you that news [02:12] and to let you know that Dan is *very* concerned about kvm stuff [02:12] he says it is pretty well tested on his end, and wanted me to give him a detailed view of what problems you've had [02:12] I'll forward you the email [02:13] thanks [02:14] mramm: is there background on the kvm issue ? [02:14] i have heard 512mb + kernel overcommit == 0 is the issue ? [02:14] mramm: we believe this is fixed in golang trunk [02:16] fixed is an oversimplification of the problem [02:16] if this is the problem I think it is [02:16] dan will have the same issue running jvm applications in those small kvm containers [02:17] thumper: mramm ping [02:17] hi davecheney [02:17] thumper: may i butt into this issue [02:17] i believe i have experience [02:18] davecheney: the issue is with the kvm wrappers that they wrote [02:18] not in any way with jvm [02:19] and it's just about us supporting kvm containers *inside juju* [02:19] mramm: ok [02:19] thanks [02:19] mramm: what does kvm inside juju mean ? [02:21] like lxc containers but kvm containers [02:21] EG deploy ceph inside kvm on a machine as part of an openstack install [02:23] ok, gotta run [02:23] getting late here. [02:25] gnight [02:29] mramm: how does this problem relate to the 1gb issue ? [02:29] are they unrelated [02:29] i'm only interested in the latter [02:29] which problem? [02:29] kvm? [02:29] mramm: yes [02:29] they are completely unrelated [02:29] yes [02:29] ok [02:30] please view my comments above with respect only to the 1gb issue [02:30] and the later is that we can't bootstrap on a 512 node anymore [02:30] mramm: ahh, that is why i am confused [02:30] 512mb nodes are a kvm thing ? [02:30] correct ? [02:37] mramm: is there an issue for the 1gb / 512mb problem ? [02:43] mramm: sorry those emails hadn't arrived, I thought I had sent them but the email client was stuck asking me to sign things [02:45] dave I don't know where the issue is or even if there is a bug filed, sorry [02:47] mramm: i will follow up with rog to see if he raised an issue [02:47] mramm: i've seen the other side of the conversation on the golang-dev ML [02:49] the gui has just crapped out on me as well [02:49] looking at the unit [02:49] the gui process has died ... [02:51] oooooooooooooh, interesting [02:51] this is a chrome issue [02:51] one chrome tab was showing the SSL warning [02:51] which was blocking any other connectino to that site .... [02:54] nice huge mechanical branch coming [02:58] wallyworld, axw: rack up the reviews you need in the order you need them [02:58] I'll drill through them after I have kids from school [02:58] * thumper goes to put on shoes [02:58] thumper: I see you've lgtm'd sshstorage (thanks); just this one now: https://code.launchpad.net/~axwalk/juju-core/sanity-check-constraints/+merge/185015 [02:58] https://codereview.appspot.com/13763044/ [02:59] https://codereview.appspot.com/13800043/ [02:59] axw: you can take a look at my testbase branch [02:59] thumper: yep, will do [02:59] https://codereview.appspot.com/13694046 [02:59] all it does is move a few things [03:09] axw: are you landing the sshstorage? [03:09] if so, I'll wait for my as they'll clash [03:09] thumper: I can wait for you to land that one if you like [03:10] ok, I'll land it [03:10] thanks [03:10] axw: I'd prefer to avoid importing checkers into testbase, but we could, as long as we make sure that it is just that [03:10] thumper: nps, just leave it till it's an issue [03:11] approved it, so lets see if it lands :) [03:11] thumper: did you land the sshstorage test one? [03:11] yes [03:12] yes [03:14] thumper: does mocking out ssh/sudo really make the test whitebox? the fact that it's in the same package is really just an unfortunate requirement [03:14] hmm... [03:14] perhaps not [03:14] I'm flexible [03:15] I'll leave it. I think we may move the SSH stuff out to another package later anyway, for centralising common flags [03:23] wallyworld: /environs/tools/tools_test.go is still using filepath, do you know where? [03:23] in the mp? [03:24] nm [03:24] I' look [03:24] and it is ok [03:24] sigh, another one https://codereview.appspot.com/13694047 === jtv1 is now known as jtv [03:32] kid says "take me to hockey now, I have a game at 4" [03:32] * thumper afk for a few minutes. [03:57] axw, wallyworld: where are we up to on reviews needed? [03:57] thumper: i've got 3 [03:57] thumper: I'm all good now [03:57] let me check them to see what's approved [03:58] thumper: I'm just going to make sure my null provider stuff still works with all the changes to sshstorage and co, then I'll land manual bootstrap and propose null provider [03:58] thumper: default hp cloud set up is not needed anymore because there's nothing hp cloud specific anymore [03:59] wallyworld: how do the users point openstack at hpcloud? [03:59] what do you mean? [03:59] axw: ok [03:59] wallyworld: well, I want to go bootstrap [03:59] they set their credentials same as now [03:59] how does it know where to look? [03:59] it uses the credentials [03:59] you suggest os env vars [04:00] ? [04:00] no, they set in yaml or env vars [04:00] their choice [04:00] ok, fair enough [04:00] do the users know that hpcloud is openstack? [04:00] before, hp cloud was different because the public bucket url was needed [04:00] they don't need to know that [04:01] I'm just wondering if it is nice to keep hpcloud as an option since it is a certified cloud [04:01] the only hp cloud difference was the public bucket url, else it is just standard openstack [04:01] wallyworld: but you have removed hpcloud as an option [04:01] no need [04:01] in the config [04:01] yes, because there is no hp cloud specific config [04:01] I know there is no *need*, I just think it is useful [04:01] it's done via credentials [04:01] useful how? [04:01] * thumper slaps wallyworld for not listening [04:02] * wallyworld slaps thumper for the same reason [04:02] * thumper slaps wallyworld for slapping him [04:02] hangout perhaps? [04:02] wallyworld: yes, please [04:02] however [04:02] I need to go get kid 3 in 2 minutes [04:02] ok [04:02] only takes a few minutes [04:02] with the tests, i deliberately used text [04:02] I'll create a hangout and ping you when I'm back [04:02] not a const [04:02] ok [04:19] wallyworld: https://plus.google.com/hangouts/_/6f17da147ed6be734a284c49eb9c67086eef59b0?hl=en [04:57] davecheney: hi still working on getting the code for the release ready. i'll update the release notes tonight. i assume that will be ok? [04:59] wallyworld: sure [05:00] wallyworld: it's more important to get it right, than to get it out there tonight [05:00] if you need more time, just say [05:00] yep. pushing shit uphill, but getting there [05:01] wallyworld: the friday date is fairly arbitary [05:01] i've 3 branches to land then test === tasdomas_afk is now known as tasdomas [05:26] davecheney: do you have credentials to write to the s3 public bucket? [05:26] wallyworld: will /msg [05:26] ok [05:29] ick [05:29] axw: got a minute? [05:29] thumper: yes? [05:30] axw: hangout? [05:30] sure [05:30] axw: https://plus.google.com/hangouts/_/43172cdd0670d5faaae767a84e0c0fe72923a9ea?hl=en [05:37] AAAAAAAAAAAAARHRHG [05:37] lucky(~/charms/precise/galaxy/hooks) % juju add-machine -n10 [05:37] error: flag provided but not defined: -n [05:37] WHY [05:38] davecheney: are you thinking of add-unit? [05:39] add-machine doesn't take a -n parameter [05:46] wallyworld: it would be good if it did [05:46] yeah. no one has asked for it that i know of [05:46] https://bugs.launchpad.net/juju-core/+bug/1214209 [05:46] <_mup_> Bug #1214209: cmd/juju: add-machine should take a -n param

[05:47] fair enough [05:58] :( [05:59] thumper: you know how I changed sshstorage to create/remove the tempdir on Put? [05:59] it's not going to work [05:59] why [05:59] storage goes to /var/lib/juju/storage [05:59] tempdir to /var/lib/juju/storage.tmp [06:00] and... [06:00] /var/lib/juju/storage gets created under sudo, and chown'd to $SUDO_UID [06:00] then.,.. [06:00] hmm [06:00] how about /var/lib/juju/storate/.tmp ? [06:00] another, non-sudo shell is executed to do the transfers [06:00] that just means we can't have .tmp in storage, which I suppose is reasonable [06:01] mornin' all [06:01] morning rogpeppe [06:01] axw: hiya [06:01] ave [06:02] thumper: by which I mean, the user can't Put anything starting with ".tmp" [06:03] axw: yeah... [06:03] axw: however your tmp dir is now removed after right? [06:03] axw: doesn't the function to create a tmpdir take a prefix? [06:03] and won't clash with names? [06:04] thumper: yes, but if you die before removing it [06:04] then you have something in storage [06:04] yes, that is a risk [06:05] but managable compared to the other options I think [06:10] thumper: testbase looks good (not keen on "base" in names in general, but can't think of a better one here) [06:10] rogpeppe: axw and I brainstormed some names [06:10] and it was the best we could come up with [06:10] I'm particularly fond of the test that makes sure it doesn't grow dependencies [06:11] thumper: one thing though: how about Patch rather than PatchValue? the lines that use it tend to be longish anyway, so the extra horizontal space is useful. [06:11] Patch doesn't say what it is patching [06:11] it isn't a descriptive name [06:12] thumper: it's patching its argument, which is (by definition) a value [06:12] no, sorry I disagree [06:12] thumper: "Value" doesn't really add any, erm, value there [06:13] thumper: i think it works well for the basic patching mechanism [06:13] thumper: and it's a reasonable compromise between PatchValue and Set :-) [06:14] my suggesting is this: if you still think strongly that we should change it by the time we all get together in SFO, then we can get a team concensus [06:14] then we can run sed -i on the codebase [06:14] but give it a little time to settle [06:15] we should schedule a session for pure bikeshedding :) [06:15] * thumper is at EOW [06:15] * rogpeppe sobs that it was his shed originally :-) [06:15] thumper: have fun [06:15] * thumper throws pink paint at rogpeppe's shed and runs [06:16] rogpeppe: are you an ec2 expert? we are getting access denied trying to access http://juju-dist.s3.amazonaws.com/ and i have no idea why [06:16] hence juju is currently broken for ec2 [06:16] wallyworld: oh shit [06:17] wallyworld: i am by no means an ec2 expert [06:17] i tried sync tools and aborted it after it had uploaded a few tarballs. not sure if that caused it. i can't see how [06:17] i also aborted uploads to hp cloud etc and no problem [06:17] that *shouldn't* have caused a problem [06:18] wallyworld: so did it stop working immediately after your abort? [06:18] i think so [06:22] may fwereade knows? or mgz? [06:23] wallyworld: i don't have any s3 access at all [06:23] wallyworld: i wonder if this might be an amazon issue [06:23] i sure hope so [06:23] % s3 put /tmp/x s3://pefkesnjesesvds [06:23] ERROR: S3 error: 403 (InvalidAccessKeyId): The AWS Access Key Id you provided does not exist in our records. [06:24] so i guess we wait a bit [06:24] and see if they fix anything [06:24] wallyworld: hmm, status.aws.amazon.com doesn't indicate anything amiss [06:25] wallyworld: could you install s3cmd and try making a bucket, please? [06:25] wallyworld: just to see if you get the same issue [06:25] ok [06:26] i can create one [06:28] wallyworld: do i need to declare an emergency [06:28] wallyworld, i'm an expert.. [06:28] it's 3:30pm in japan [06:28] hazmat: any idea why we are getting access denied all of a sudden trying to read the juju-dist bucket? [06:28] davecheney, its sounds like its just an upload issue not a public issue [06:29] wallyworld, are you using the correct account.. [06:29] wallyworld, are you sure you don't have some openstack/canonistack stuff in your env [06:29] hazmat: i was testing sync-tools and aborted a tarball upload part way through with Ctrl^C. but surely that could not have caused it? [06:29] hazmat: it should be globally readable [06:29] ie. your actually using an aws account [06:29] hazmat: yes [06:29] rogpeppe, we're talking about upload [06:29] wallyworld, i've seen that error when i accidentally try to use an openstack account against aws [06:30] alternatively when an iam account i'm using is deleted [06:30] hazmat: i can't access that url, which i think i should be able to [06:30] rogpeppe, who is the owner of the account / bucket? [06:30] hazmat: i'm almost 100% sure i used the correct account details [06:30] hazmat: gustavo [06:30] hazmat: niemeyer [06:31] hmm.. too early for him.. [06:31] one moment.. checking the bucket with creds [06:35] wallyworld, hazmat: FWIW i see the same issue, though i can in fact upload to my own buckets (i'm not sure why s3cmd was failing to do that) [06:35] wallyworld, davecheney, rogpeppe ... okay verified the account works [06:36] i can upload files to the bucket, and remove them [06:36] hazmat: to juju-dist? [06:36] rogpeppe, yes [06:36] the problem is that the permissions on the account are restricted [06:36] so why do we get access denied reading it? [06:36] i can't for example list all the buckets on the account [06:36] but i can list th contents of that bucket, and r/w to that bucket [06:37] read access to juju-dist would be a separate issue [06:37] er... public read access [06:37] oh, ffs, s3cmd doesn't look at the usual env vars [06:38] hazmat: so you can fix the permissions? [06:38] i wonder how they changed [06:38] wallyworld, well first i want to verify if its an actual issue [06:38] juju doesn't work [06:38] wallyworld, it works for me.. [06:38] not for me or rogpeppe :-( or davecheney [06:39] i'm in the middle of a class, and we've been deploying units and services in different envs this whole time [06:39] those envs were already bootstrapped though.. but the tool logic is pretty constant on pinging the pub bucket [06:39] once bootstrap happens i don't think it uses the pub bucket anymore [06:40] wallyworld, hmm.. ic what you mean [06:40] wallyworld, checking [06:40] wallyworld, you can still download tools from the bucket.. http://juju-dist.s3.amazonaws.com/tools/juju-1.13.2-saucy-i386.tgz [06:40] ahh, but we cannot list the bucket ... [06:40] for example [06:41] hazmat: yes [06:41] i woner if we've passed some limit [06:41] we should be using an explicit index anyways.. [06:41] ie, the number of rows to return ? [06:41] ie. a json/yaml file we create.. [06:41] maybe it isn't 200 [06:41] relying on aws default output isn't sane [06:42] hazmat: you can't rely on list-bucket? [06:42] * hazmat looks into the bucket perms [06:42] hazmat: i guessed at the limit [06:42] rogpeppe, juju does not do list-bucket [06:42] rogpeppe, we don't require every use to have an aws account [06:42] every user. [06:43] juju does list buvket [06:43] hazmat: list-bucket is just a GET of the bucket, no? [06:43] when it looks for the tools [06:43] not quite [06:43] rogpeppe, yes.. but its a bit more involved for pagination, etc [06:43] * wallyworld has to run away for a bit. back a bit later [06:43] hazmat: agreed. but we do that. [06:43] hazmat: is there a problem with doing that? [06:44] hazmat: there are definite advantages to relying on ec2 itself to provide data about what files are uploaded [06:45] rogpeppe, wallyworld, davecheney fixed [06:45] hazmat: in particular it means that you can concurrently upload tools without worrying about maintaining a shared "directory" file (something i'm not is possible in s3) [06:45] http://juju-dist.s3.amazonaws.com [06:45] hazmat: yup, that's better [06:45] hazmat: what was the problem? [06:45] rogpeppe, we control the upload process, we should define our format [06:45] rogpeppe, the bucket perms had changed to not be public [06:45] hazmat: how tf did that happen? [06:46] rogpeppe, and updating an index file allows us the flexibility to host tools elsewhere [06:46] hazmat: we're moving towards using "simple" streams for all of this [06:46] relying on aws .. means they change something and we break.. and we have multiple impls if we have to go somewhere else [06:46] rogpeppe, good [06:48] rogpeppe, wallyworld, davecheney if you want the gory xml details.. here's previous and current of the bucket acl.. http://pastebin.ubuntu.com/6131371/ [06:49] something reset the bucket perms.. [06:49] it seems like [06:50] to only allow owner access.. anyways.. its fixed afaics, heading back to class [06:50] hazmat: yeah [06:50] hazmat: thanks [06:50] np [08:55] fwereade, dimitern, mgz, axw: small review anyone? https://codereview.appspot.com/13806043/ [08:56] rogpeppe: looking [08:56] axw: thanks! === allenap` is now known as allenap [10:04] i have a branch for review for the 1.15 release. tim started it but got stuck when ec2 failed earlier. i took his work and added a test and here it is https://codereview.appspot.com/13642045 [10:06] wallyworld: looking [10:06] thanks :-) [10:29] Is it just me, or do the menus on www.ubuntu.com look totlaly messed up? [10:39] natefinch: me too [10:40] another trivial review: https://codereview.appspot.com/13780044/ [10:40] rogpeppe: I'll take a look [10:40] natefinch: thanks [10:42] rogpeppe: done [10:42] natefinch: ta! [10:43] rogpeppe: who should I poke about www.ubuntu.com? [10:43] natefinch: i have no idea, sorry [10:43] heh no problem [10:46] natefinch, fwereade, rogpeppe, wallyworld: standup? [10:54] rogpeppe, fwereade : a quick review after standup? https://codereview.appspot.com/13636044/ [11:06] rogpeppe, wallyworld, mgz, dimitern, natefinch: sorry, I'm trying to get back in [11:19] gents, my audio is appallingly bad, I think we stick with "don't do that then" and hope that everybody can remember that until we have simplestreams online [12:16] * fwereade pops out for coffee [12:18] * rogpeppe just got bitten by this bug. it really confused me! https://bugs.launchpad.net/gocheck/+bug/1228105 [12:18] <_mup_> Bug #1228105: panic in TearDownTest obscures original test panic === natefinch is now known as natefinch-afk [13:26] natefinch-afk, does https://launchpad.net/juju-core/+milestone/1.14.1 need a bug fix to address the missing azure documentation? [13:35] trivial review anyone? https://codereview.appspot.com/13775046 [13:35] took a while to diagnose that! [13:36] fwereade, dimitern, mgz: ^ [13:37] rogpeppe, looking [13:38] metoo [13:38] fwereade: oh it would be so good to sort out JujuConnSuite. i think we're heading in the right direction with the configstore interface actually [13:39] ugh, this is all so fragile [13:39] mgz: yeah [13:40] rogpeppe, LGTM [13:40] mgz: most of it's actually unnecessary in fact [13:40] fwereade: thanks [13:41] still waiting for a review on https://codereview.appspot.com/13636044/ please [13:41] rogpeppe, fwereade ^^ ? [13:41] fwereade: i kind of agree about nestable fixtures, but i'm not really sure why this CL implies the need [13:42] dimitern: looking, sorry [13:43] rogpeppe, it looked like we were half-assing a fixture with sub-Test-method setup/teardown effectively [13:44] fwereade: that actually works ok in general - it's not really nesting as such, more splitting. [13:44] fwereade: i wish fixtures looked less like test suites though [13:47]