| hatch | morning huwshimi | 00:29 |
|---|---|---|
| hatch | "bold all the things!" | 00:30 |
| gary_poster | morning huwshimi :-) | 00:31 |
| hatch | http://orteil.dashnet.org/cookieclicker/ | 00:32 |
| * hatch is a pusher | 00:32 | |
| === gary_poster is now known as gary_poster|away | ||
| rick_h_ | hmm, won't load here. Wifi is pretty bad | 00:34 |
| hatch | rick_h_: oh you're missing it, it's the perfect game for on vacation :D | 00:34 |
| rick_h_ | playing with my moto x :P | 00:35 |
| hatch | OOooo you went with the x hey? | 00:35 |
| hatch | how is it? | 00:35 |
| rick_h_ | nice, really quick. Love the small touches | 00:35 |
| hatch | does that run stock android? | 00:35 |
| rick_h_ | pick it up and it goes to the unlock screen vs waiting for you to hit the power button | 00:35 |
| hatch | oh very cool | 00:35 |
| rick_h_ | auto unlocks when my pebble is attached so no pin code | 00:35 |
| rick_h_ | it's pretty stock. The notification thingy and the always listening for google now are non-stock currently | 00:36 |
| rick_h_ | but I'd expect those to hit 4.4 tbh | 00:36 |
| rick_h_ | picking up the DC metro/zoo apps for tomorow | 00:36 |
| rick_h_ | we live in the future heh | 00:37 |
| hatch | heh always listening....ehhh | 00:37 |
| hatch | *caugh*no-privacy*caugh* :P | 00:37 |
| rick_h_ | yea, getting the griffin car dock. Full hands free use with it | 00:37 |
| rick_h_ | since you can wake it from sleep with you voice, tell it to write out a text, done | 00:37 |
| hatch | that is pretty cool | 00:38 |
| hatch | I'm paranoid though that it would be recording me :) | 00:38 |
| rick_h_ | yea, oh well. They can hear me tell the wife I'm on my way :P | 00:38 |
| hatch | lol | 00:38 |
| hatch | good point | 00:39 |
| hatch | rick_h_: while I have you here, can you tell me what actually shows the Tokens? I see the token-container.js but I don't see what is actually showing each child | 00:44 |
| rick_h_ | hatch: it uses the YUI parent/child widget relationship. | 00:45 |
| rick_h_ | hatch: there are Views that create the TokenContainers based on a bunch of data | 00:45 |
| rick_h_ | and the TokenContainers use YUI to create the Tokens since they're the child widget | 00:45 |
| rick_h_ | hatch: so the container.items is the list of data for Tokens | 00:46 |
| hatch | so are they all shown by default? | 00:46 |
| hatch | and hideSomeChildren hides the specific ones? | 00:46 |
| rick_h_ | hatch: no, the container gets called with a limit to show by default | 00:46 |
| rick_h_ | hatch: well yea, they're all rendered and the container controls how many are visible (not display: none;) and the events for show/hide the rest | 00:47 |
| hatch | right, but I can't find what actually renders each child | 00:47 |
| hatch | ohh ok so they are all visible, then we hide the extras | 00:47 |
| rick_h_ | hatch: right, it's behind the scenes in the container. Once the container is rendered, YUI renders the tokens | 00:47 |
| rick_h_ | as the children of the parent widget | 00:47 |
| hatch | I didn't know that the parent auto-rendered the children | 00:48 |
| hatch | good to know | 00:48 |
| hatch | thanks | 00:49 |
| rick_h_ | http://yuilibrary.com/yui/docs/api/files/widget-parent_js_Widget-Parent.js.html#l713 maybe? when the child is added it auto renders | 00:49 |
| hatch | I haven't used widgetparent/child in like....ohhhh 3 years | 00:49 |
| hatch | haha | 00:49 |
| rick_h_ | hatch: yea, it was a really nice fit for our needs though | 00:50 |
| rick_h_ | made a lot of sense and helped with the container/token split | 00:50 |
| rick_h_ | some things do toksn on their own, related charms, autocomplete suggestions for instance | 00:51 |
| hatch | yeah I was actually thinking of a refactor for this area last night | 00:51 |
| hatch | was thinking about things like rendering just the markup and then enhancing it | 00:51 |
| hatch | wondering if we could do it simpler | 00:51 |
| rick_h_ | careful, what's there is nice/works imo. I don't want to viewlet it :P | 00:51 |
| hatch | this is assuming fullscreen goes away of course | 00:51 |
| hatch | oh yeah I'm not actually proposing we do it | 00:51 |
| hatch | just thinking about it | 00:52 |
| hatch | :) | 00:52 |
| rick_h_ | ok, well I'm all for chatting on things. I was hoping to be more involved when bundles came along but alas | 00:52 |
| hatch | did you see the email thread that huwshimi started about the animations? | 00:52 |
| hatch | I figured you would have some input on it and my response | 00:53 |
| rick_h_ | I kind of saw it. I figure I don't have the ime to give a great response atm. Animations is involved. :/ and it seemed limited to the tabs themselves which should be easier to deal with | 00:53 |
| hatch | yeah basically it involved a refactor haha | 00:54 |
| rick_h_ | animations anywhere will. Animations require both bits to be visible at once and nothing we've done works that way. tab widget, browser Y.Views, etc | 00:55 |
| hatch | right | 00:55 |
| rick_h_ | it needs an overseer to handle all loading/unloading of bits | 00:55 |
| rick_h_ | and that needs to get baked one layer above the things you want to animate | 00:55 |
| rick_h_ | refactor time | 00:55 |
| hatch | you're not doing anything right now...get at it :P | 00:55 |
| rick_h_ | hah, I'm planning a trip into washington DC right now :P | 00:55 |
| hatch | with your phone that listens to you no need - they will already know you're coming | 00:56 |
| hatch | haha | 00:56 |
| rick_h_ | hah, well they're not going to give me a transit plan when I show up at the bus station tomorrow | 00:56 |
| rick_h_ | even if they already know what I want to do | 00:56 |
| hatch | give it time....give it time | 00:56 |
| rick_h_ | lol | 00:57 |
| rick_h_ | night, time to head in and start locking things down. Getting chilly out here | 01:01 |
| hatch | alrighty, have a good one | 01:02 |
| === gary_poster|away is now known as gary_poster | ||
| gary_poster | hey frankban. I struggled against local provider issues all afternoon when I was not on calls, so I never was able to qa. apparently local on saucy might have issues. I gave Tim details. I will try one more time this morning on local and then will go to ec2 while on calls. If you can find someone in a better position to qa then you are welcome to. :-) | 11:12 |
| gary_poster | But, sorry. :-/ | 11:12 |
| frankban | gary_poster: np, fwiw lxc works for me using revno 1750 of juju-core. but I am on raring | 11:14 |
| frankban | I also have problems with trunk, i.e. 1229286 | 11:14 |
| frankban | bug 1229286 | 11:14 |
| _mup_ | Bug #1229286: debug-log and boolean options are broken in trunk <juju-core:New> <https://launchpad.net/bugs/1229286> | 11:14 |
| gary_poster | frankban, I am on call with juju mgrs right now. I just raised that one to tim and william fwiw | 11:17 |
| frankban | gary_poster: cool thanks | 11:17 |
| gary_poster | frankban, config issue looks like bug. Wm is on it, I think. Tim says log issue is as designed. He will write email about it tomorow but he gave this summary: "effectively our logging is now more "productiony" | 11:25 |
| gary_poster | you can set the log level when you bootstrap, and that is used for the environment | 11:25 |
| gary_poster | or set it later using "juju set-env"" | 11:25 |
| frankban | gary_poster: yes, he explained the same in #juju-dev | 11:27 |
| gary_poster | frankban, oh! I see, cool :-) | 11:28 |
| gary_poster | frankban, with you soon--2 or 3 more minutes late, sorry | 12:02 |
| frankban | gary_poster: np | 12:03 |
| bac | hey gary_poster, staging.jc.com is dead,dead,dead. there is no good reason for that, right? | 12:37 |
| gary_poster | correct bac | 12:38 |
| bac | gary_poster: cool. i'll try go to get it alive again. its death looks somewhat premediated: http://paste.ubuntu.com/6158533/ | 12:39 |
| gary_poster | bac thank you | 12:40 |
| hatch | frankban: thanks a lot for the QA | 13:34 |
| frankban | hatch: welcome | 13:35 |
| bac | hi abentley, do you know why staging would be shutdown? i've been trying to deploy it using the staging-tools scripts but not having any luck. | 13:39 |
| abentley | bac: Yes. See #is topic. OTP | 13:40 |
| bac | thanks | 13:41 |
| bac | abentley: please ping me when you are free. | 13:41 |
| gary_poster | hey hatch, you could merge/include huw's https://codereview.appspot.com/13954043/ in your bundle detail page work if you want, or we can do it separately later | 13:46 |
| gary_poster | hey luca__ . what's status of approved bundle token ux/visuals? if we can get ux at least no later than today that would be great. is that possible? | 13:47 |
| hatch | frankban: so I had no idea that services can go into an error state on destroy | 13:51 |
| hatch | ohh nm I missread your qa | 13:51 |
| frankban | hatch: the problem I highlighted is for services already in an error state, but I confirm a service can go in an error state also on destroy (i.e. if the stop hook exits with an error) | 13:52 |
| frankban | hatch: in both cases the service will be dying, but not removed | 13:53 |
| abentley | bac: free now. | 13:53 |
| hatch | gary_poster: mind taking a peek at frankban's QA of my branch when you have a second - I think we'll need to switch to the original plan | 13:54 |
| gary_poster | on call but will in a bit hatch | 13:55 |
| luca__ | gary_poster: are you after the bundle token? | 13:59 |
| gary_poster | luca__, yeah | 13:59 |
| luca__ | gary_poster: It's been signed off, I'll send it through in 10 mins | 13:59 |
| gary_poster | cool ty | 14:00 |
| frankban | guihelp: how do you dismiss a ghost service block? The cancel button in the ghost inspector doesn't work for me in https://jujucharms.com/sidebar/ : it closes the inspector but the service block is still there. | 14:18 |
| hatch | frankban: destroy the service | 14:18 |
| hatch | gary_poster: if you want me to try juju on my Saucy VM I can try and give it some more ram and see if it works | 14:20 |
| gary_poster | hatch cool. if you can unblock frankban by qa'ing his branch that would be fab | 14:20 |
| hatch | yeah I can do that | 14:21 |
| frankban | hatch: thanks | 14:22 |
| frankban | hatch: locally, with make devel, destroying a ghost gives me a weird error notification, and leaves the ghost block | 14:22 |
| hatch | with my branch? | 14:22 |
| frankban | hatch: no, in trunk | 14:23 |
| frankban | Error destroying service: Service name: 55274347$ | 14:23 |
| hatch | ok that makes sense.... | 14:23 |
| hatch | but it shouldn't be erroring | 14:23 |
| hatch | can you create a ticket plz | 14:23 |
| frankban | hatch: sure | 14:24 |
| hatch | and I'll see what's up after QA'ing your branch | 14:24 |
| frankban | hatch: is this something specific to the go sandbox, or to the go env in general? | 14:25 |
| hatch | frankban: it's a symptom of switching to a single service model - ghosts are given a random unique id so they -cannot- clash with anything potentially returned from juju-core | 14:25 |
| hatch | and so that you can have multiple ghosts with the same name | 14:25 |
| hatch | as to why it can't destroy it - I have no idea | 14:26 |
| frankban | hatch: ok, but it's a regression, in jujucharms works, in comingsoon is broken | 14:26 |
| hatch | yeah it was done after release | 14:26 |
| hatch | it's definitely not supposed to throw an error :) | 14:27 |
| frankban | cool | 14:27 |
| frankban | hatch: filed bug 1231487 | 14:29 |
| _mup_ | Bug #1231487: Error while trying to destroy a ghost service from the inspector <juju-gui:Triaged> <https://launchpad.net/bugs/1231487> | 14:29 |
| hatch | thanks! | 14:29 |
| luca__ | gary_poster: just sent you the Bundle token | 14:37 |
| gary_poster | looking while on call luca__ ;-) thank you! | 14:37 |
| benji | adeuring: hi, I have a question about charmworld's elastic search. Where in charmworld do we configure ES? Is there an initialization script or something similar? I ask because we're considering enabling n-gram tokenization to get better substring searching. | 14:37 |
| gary_poster | oh luca__ I had feedback on your email from yesterday that I didn't get around to sending :-( | 14:38 |
| gary_poster | not a big chagnge but will right it out, in short, only bundle yaml is pertinent for the functionality that you are describing | 14:38 |
| hatch | frankban: I can't seem to get your branch to save any config changes - do I need to be on a certain charm version? | 14:39 |
| frankban | hatch: what version of juju-core are you using? | 14:40 |
| hatch | cs:precise/juju-gui-76 | 14:40 |
| adeuring | benji: We have right now just two config parameters: number of shards and number of replicas; that's defined in the .ini file- | 14:40 |
| hatch | umm sec | 14:40 |
| hatch | 1.14.1-precise-amd64 | 14:40 |
| adeuring | benji: additionally, we should define the ES cluster name, but that's done vie "juju config" | 14:40 |
| frankban | hatch: weird. have you switched the charm to my branch? | 14:41 |
| hatch | yep it says it's your branch | 14:41 |
| hatch | oh wait a second.... | 14:42 |
| benji | adeuring: ok, I saw those but wondered if there were more. If we were to want to enable n-gram tokenization how do you suggest that would work? I assume we would need both to set the configuration on a new deployment and a script to reindex the existing production ES. | 14:42 |
| hatch | frankban: ok when I change the setting 'juju-gui-console-enabled' in the GUI it clears out every config field | 14:42 |
| hatch | then on refresh it's now saved | 14:42 |
| hatch | so yes it works....but it breaks the GUI | 14:42 |
| hatch | I'll reply on the review | 14:43 |
| gary_poster | luca__, is that bundle icon finalized? if so, could we have the svg? | 14:43 |
| luca__ | gary_poster: sure | 14:43 |
| gary_poster | thanks luca__ | 14:43 |
| frankban | hatch: I'm not sure I understood the problem | 14:43 |
| adeuring | benji: I am not very familiar with ES myself, but I assume that you need to create a new index with the right parameters. That would probably be similar to the put_mapping() call, which is already a sort of configuration (in addition to the shards/replicas) too. | 14:44 |
| adeuring | benji: and the best mechanism there is to run an "exodus" | 14:44 |
| benji | ok, that makes sense | 14:44 |
| hatch | frankban: responded with repro steps in the review | 14:45 |
| frankban | hatch: pl | 14:45 |
| frankban | ok even | 14:45 |
| hatch | :) | 14:45 |
| luca__ | gary_poster: sent it over | 14:45 |
| gary_poster | luca__, button states & bundle tokens look great. I thik we need one other bundle state for inspector notifications list button: "in progress" or something like that. If I click on "Resolve" or similar it may take a few (10?) seconds to actually complete | 14:46 |
| adeuring | benji: migration 019 is an example -- that's a really trivial exodus (in the sense that the exodus machinery does all the tricky stuff but you don't have to care about it) | 14:46 |
| benji | adeuring: I thought "migration" and "exodus" were different things. | 14:47 |
| gary_poster | luca__, thanks for icon! | 14:47 |
| hatch | luca__: we will need assets for those checkbox states FYI | 14:47 |
| luca__ | gary_poster: can you email me about the "in progress" thing, then I can just pass it on the jamie. | 14:48 |
| hatch | the little ones for the unit list that is | 14:48 |
| gary_poster | luca__, will do thx | 14:48 |
| hatch | and nice bundle icon :) | 14:48 |
| hatch | icon/token | 14:48 |
| gary_poster | hatch do we have/need the orange "recommended" triangle, do you know? | 14:48 |
| hatch | we can do it in css | 14:49 |
| luca__ | hatch: the checkboxes are in the document | 14:49 |
| hatch | luca__: document? | 14:49 |
| adeuring | benji: the exodus is a migrations, where you can apply all changes to new mongoDB collections/ES indexes, while the old data is still in use. | 14:49 |
| benji | hmm, I must not understand something about the mechanism | 14:50 |
| luca__ | hatch: in the button states document | 14:50 |
| gary_poster | luca__, the doc is a png though | 14:50 |
| luca__ | gary_poster: oh! right, assets, duh | 14:51 |
| luca__ | gary_poster: haha | 14:51 |
| gary_poster | :-) | 14:51 |
| luca__ | gary_poster: hatch sorry | 14:51 |
| hatch | :) gotcha | 14:51 |
| hatch | np | 14:51 |
| gary_poster | np :-) | 14:51 |
| luca__ | hatch: how do you want them supplied? | 14:51 |
| luca__ | hatch: I thought it was just code | 14:51 |
| hatch | silver platter | 14:51 |
| hatch | :P | 14:51 |
| luca__ | :P | 14:51 |
| hatch | nah, we can't actually style checkboxes cross browser reliably | 14:51 |
| luca__ | no cushion? | 14:52 |
| hatch | I MIGHT be able to re-create those with markup/css | 14:52 |
| frankban | hatch: could you please try to deploy another charm and check if the behavior you described happens also there? | 14:52 |
| luca__ | hatch: ok, if you need them just email Jamie (cc me) | 14:53 |
| hatch | frankban: sure trying now | 14:53 |
| frankban | hatch: thanks | 14:53 |
| hatch | luca__: ok sure thanks | 14:53 |
| hatch | luca__: could we get some colour codes? | 14:53 |
| frankban | hatch: thanks | 14:53 |
| frankban | ops | 14:53 |
| gary_poster | hatch on calls calls calls, but saw frankban's qa of your branch. we talked about this case. I'll ping you asap to talk through. | 14:53 |
| hatch | gary_poster: yep np | 14:53 |
| hatch | I'm not -doing nothing- yet :D | 14:53 |
| hatch | at that point I'll get antsy | 14:53 |
| luca__ | hatch: sure, we created the document to make it easy to catalogue all of this so we can expand it and improve it | 14:53 |
| hatch | haha | 14:53 |
| gary_poster | :-) k | 14:53 |
| hatch | frankban: deploying mediawiki - it'll be probably 10mins or so | 14:54 |
| gary_poster | luca__, yes, +1 and thank your that btw. the catalog is a great approach I think | 14:54 |
| hatch | yeah I really like the idea of the overview in a single place | 14:54 |
| gary_poster | "thank your that" == "thank you for that" :-P | 14:54 |
| frankban | hatch: but you can try changing options even when it's pending | 14:54 |
| hatch | frankban: yup, change the option and they dissapear | 14:55 |
| hatch | I can screenshare if you like? | 14:55 |
| frankban | hatch: I am trying to dupe | 14:55 |
| hatch | luca__: are my eyes playing tricks or is the 'Notificatios list button' pre-depressed? | 14:56 |
| hatch | man I really like the new tokens.... | 14:57 |
| gary_poster | hatch that's the suru style | 14:57 |
| gary_poster | you depress somethat's already depressed. you really hit em when they are down... | 14:57 |
| hatch | lol!! | 14:58 |
| frankban | hatch: reproduced, but I think it's not my branch. this is another bug, I guess we do not handle correctly delta streams in the inspector | 15:05 |
| hatch | well as soon as I click save it wipes the rest out | 15:05 |
| hatch | I'm pretty sure this didn't happen before | 15:05 |
| hatch | maybe because it was failing | 15:05 |
| hatch | haha | 15:05 |
| hatch | could you take a look to see if it was your branch which caused it? | 15:05 |
| hatch | or if it should be a follow-up | 15:06 |
| hatch | I'm ok if it's going to be a follow-up, I'd just like to not introduce a bug if possible :) | 15:06 |
| frankban | hatch: my branch just changes a parameter in an API call in the env layer: it does not interact with the form in any way | 15:07 |
| hatch | right - but I 'think' the form uses the old params to fetch the config options | 15:07 |
| hatch | so if they are empty - then the fields will be empty | 15:07 |
| hatch | the databinding would have updated causing it to wipe clean | 15:07 |
| frankban | hatch: juju sends back something like {"RequestId":5,"Response":{"Deltas":[["service","change",{"Name":"mediawiki","Exposed":false,"CharmURL":"cs:precise/mediawiki-10","Life":"alive","MinUnits":0,"Constraints":{},"Config":{"name":"asd"}}]]}} | 15:08 |
| frankban | hatch: so Config is just {"name":"asd"}, and my first impression is that the i the handler the other default settings are ignored. | 15:11 |
| hatch | You need to refresh the GUI to get the configs back | 15:12 |
| frankban | hatch: the machinery to fetch the settings is not changed in my branch | 15:12 |
| hatch | yeah - I'm saying it might need to be | 15:12 |
| hatch | if you wait long enough the settings come back | 15:13 |
| hatch | on the next delta i'd presume | 15:13 |
| hatch | frankban might be https://codereview.appspot.com/13917043/diff/1/app/store/env/go.js ln 1027 | 15:16 |
| hatch | because the bindings are listening on 'config' | 15:18 |
| frankban | hatch: hum, perhaps inspector.js line 755? | 15:19 |
| frankban | hatch: ISTM it sets service.config to only the new values | 15:19 |
| hatch | ahhh so it's responsing with only the changed values and then we are clearing out the model and setting it to only that | 15:19 |
| hatch | right | 15:19 |
| hatch | ok definitely not from your branch | 15:19 |
| hatch | then | 15:19 |
| hatch | :) | 15:19 |
| frankban | hatch: so, it was pre-existent, if you agree, I'll land this and work on a fix for this new bug | 15:20 |
| hatch | done and done | 15:20 |
| frankban | hatch: thanks | 15:20 |
| frankban | great QA, I missed that | 15:21 |
| hatch | frankban: re your review of my branch - if a user in the console destroys a service which then goes into an error state you would expect the inspector to stay open as long as the icon is on the canvas, correct? | 15:43 |
| hatch | so we need to listen to lifeChange and being removed and then check to see if it has any errors on its units | 15:43 |
| frankban | hatch: yes | 15:43 |
| hatch | poop | 15:43 |
| hatch | :) | 15:44 |
| hatch | thanks | 15:44 |
| frankban | hatch: speaking of poop, utils.removeUnchangedConfigOptions modifies the config in place | 15:44 |
| frankban | and then returns the config | 15:44 |
| frankban | leaving on you that oppressive sense of bitterness | 15:45 |
| hatch | lol | 15:46 |
| frankban | hatch: and that's the real emptied inputs problem. | 15:46 |
| hatch | should that method not only be called when sending the values to the server? | 15:46 |
| hatch | ohh I see what you're saying | 15:46 |
| frankban | hatch: yes, but it modifies an object in place, and that object is then propagated in the callback. | 15:47 |
| hatch | right right | 15:47 |
| hatch | should we maybe 'mix' the incoming deltas in as well? | 15:47 |
| hatch | this definitely needs to be fixed | 15:48 |
| hatch | but should we mix the two also? | 15:48 |
| Makyo | jujugui call in 10 kanban now | 15:50 |
| frankban | hatch: I think we have 2 easy fixes: 1) do not modify in place the new config (so that the callback will receive the whole config object) or 2) mix the current config and the new values in the callback | 15:50 |
| hatch | 3) both | 15:50 |
| hatch | :P | 15:50 |
| hatch | honestly though 1) definitely needs to be done | 15:50 |
| hatch | 2) if you wanted | 15:51 |
| hatch | not sure if doing #2 will gain us anything after #1 is fixed | 15:51 |
| frankban | hatch: I am ok with modify objects in place if that's documented and the function returns undefined. I am confused instead when a function changes an object in place AND returns the changed object | 15:52 |
| frankban | hatch: and maybe there is some value in the callback receiving only the new values | 15:52 |
| hatch | frankban: yeah that happens a lot in javascript apps ive found | 15:53 |
| hatch | maybe | 15:53 |
| hatch | I'll leave the implementation up to you | 15:53 |
| frankban | hatch: ok thanks | 15:53 |
| gary_poster | ugh, I have meeting ennui :-) | 15:54 |
| hatch | I just googled it | 15:56 |
| hatch | you used that word wrong | 15:56 |
| hatch | lol | 15:56 |
| gary_poster | hatch, in what way? | 15:57 |
| hatch | ok maybe not | 15:58 |
| hatch | I found another example | 15:58 |
| hatch | dammmnnnn youuuuuuu | 15:58 |
| gary_poster | lol. meeting-induced ennui might be more accurate, but I think what I said is close enough | 15:58 |
| gary_poster | jujugui call in 2 | 15:58 |
| hatch | haha yes it is | 15:59 |
| bac | benji: the charmworld new lander works just like the old lander | 16:06 |
| benji | heh, k | 16:07 |
| hatch | Makyo: https://plus.google.com/hangouts/_/f3152089747387222abf5a2f310ec7fdf4473cb6?authuser=1 | 16:10 |
| hatch | I wonder if that's an android thing - if you use up 95% of the 'disk space' it gets very very slow | 16:17 |
| hatch | stepping out for about 20 | 16:41 |
| hatch | bbl | 16:42 |
| bac | hi bcsaller, can i ask you about a change you made to makeFakeStore? | 17:50 |
| bcsaller | yeah, let me pull it up | 17:50 |
| bcsaller | ok, whats up? | 17:51 |
| bac | you added the cache parameter, and it is used in one test suite. but, looking at it i don't see it ever used. | 17:51 |
| bac | bcsaller: i'm not sure what you intended. removing it doesn't break any tests... | 17:52 |
| bcsaller | the actual store charm methods take a cache | 17:52 |
| bac | bcsaller: what i wrote was confusing. i mean one call site passes in a cache but i don't see makeFakeStore using it | 17:52 |
| bcsaller | the idea is only to accumulate the charms into a model list, tests don't have such a list to keep things for the most part | 17:54 |
| bcsaller | it might be good to do all the imports on load though with a real model list and have fakestore resolve them from there to speed up the tests | 17:55 |
| hatch | yes!! | 17:55 |
| hatch | :) | 17:55 |
| bac | bcsaller: yeah but in http://paste.ubuntu.com/6159694/ the cache in line 1 is not the same one used in 3-19. | 17:56 |
| bac | so i think i see your intent but (unless i'm confused) don't think it got implemented correctly | 17:56 |
| bcsaller | bac: have you looked at app/store/charm.js:202? | 17:58 |
| bac | bcsaller: yes | 17:59 |
| bcsaller | I think it was just to mimic the actual call, if we never use it we can remove it from the mock, but I'd have thought we did | 18:02 |
| bac | bcsaller: if i rewrite makeFakeStore like http://paste.ubuntu.com/6159728/ i think it is clearer that the param is never used | 18:02 |
| bac | bcsaller: i'm happy to fix it to do what you intended...but i'm not sure how. | 18:03 |
| bcsaller | ahh, I didn't see what you meant, I'm being dense, I see it now | 18:05 |
| bcsaller | yeah, I'm not sure what the best thing to do there is, if the top level cache was passed in we could update that (after changing that argument name) and adding it to that list as well | 18:08 |
| bcsaller | or just take it out | 18:08 |
| bcsaller | the real fix would be to reduce the IO in there when cached_charms are computed | 18:09 |
| bac | bcsaller: ok, thanks | 18:16 |
| bcsaller | bac: sorry I wasn't more helpful. but I can make changes as a fly by on the branch I'm working on now if you'd rather | 18:16 |
| bac | bcsaller: maybe just paste a snippet of what you're thinking. i need to change the signature too, so i'd rather do it in my branch | 18:17 |
| Makyo | jujugui Anyone else (bac, I think?) having issues with `make check` running into a 404 trying to get /login/data/wordpress.json on the test-debug step? | 18:18 |
| Makyo | If so, I think I found a solution but...I don't understand it. | 18:18 |
| hatch | I'm not, but interested to hear | 18:18 |
| bcsaller | bac: well for now removing the first unused cache should be enough based on what you said. | 18:18 |
| bac | ok | 18:19 |
| Makyo | check runs test-prod test-debug in that order. If I swap them, I can't reproduce the error. | 18:21 |
| Makyo | prerequisite rules are run synchronously, correct? | 18:23 |
| hatch | correct | 18:24 |
| hatch | and shouldn't have any effect on eachother | 18:24 |
| Makyo | Exactly. | 18:27 |
| hatch | benji: will the ngram tokenizer give us fuzzy style searching? | 18:27 |
| Makyo | I don't get the error if I `make test-prod; make test-debug`. | 18:30 |
| bac | hatch, you want fuzzy logic? buy a rice cooker. | 18:32 |
| hatch | bac: shroden cooker you mean - you don't know if it's done until you look at it | 18:33 |
| Makyo | Now it's happening on test-prod. I hate everything. | 18:33 |
| benji | hatch: [sorry, I was AFK] It depends on what you mean by "fuzzy". | 18:35 |
| hatch | benji: package name: foobarbaz search: bar | 18:35 |
| hatch | would match | 18:35 |
| benji | yep | 18:36 |
| hatch | SHIP IT! | 18:36 |
| benji | :) | 18:38 |
| benji | bac: what is the status of v3 API bundle output? I'm looking for something to do and was considering one of the wire-it-up cards. | 18:44 |
| bac | benji: coming along but i got sidetracked a bit. something end of day i hope. | 18:45 |
| benji | k | 18:45 |
| hatch | I don't know who fixed 'make devel' but it's so fast now | 18:48 |
| hatch | +1 whoever that was | 18:48 |
| hatch | in huws notification branch he removed the events but didn't remove the methods which those events call | 18:52 |
| hatch | does anyone know if he plans to do that in a followup? | 18:52 |
| hatch | jujugui ^ | 18:52 |
| gary_poster | hatch, he added a card to high kanban group that looks pertinent | 18:53 |
| gary_poster | "Remove remaining notification page(s) and code" | 18:53 |
| hatch | ohh woops I missed that | 18:53 |
| hatch | thanks | 18:53 |
| hatch | qa'd ok so I'm going to land | 18:53 |
| hatch | anyone else getting a bunch of old RT emails? | 19:02 |
| gary_poster | not i | 19:04 |
| * Makyo fails at proposing for the umpteenth time, tries from other computer. | 19:07 | |
| hatch | ok so my latest branch has failed on juju-core with a hook failed error | 19:08 |
| hatch | how should I debug this? | 19:08 |
| hatch | ssh into the machine and read the juju log? | 19:08 |
| hatch | got it | 19:11 |
| hatch | man I wish juju would tell you if it's doing something | 19:13 |
| Makyo | There's debug-log for that, right? And a ticket in for hook logs in debug-log, I think... | 19:14 |
| hatch | well I was thinking status should tell you if there are any active hooks on a service | 19:15 |
| hatch | service/machine | 19:15 |
| hatch | somehow my gui instance is stuck on dying | 19:18 |
| hatch | juju pull-the-plug juju-gui --forceful | 19:18 |
| hatch | :D | 19:18 |
| gary_poster | :-) | 19:21 |
| Makyo | Aaaargh, everything works from the branch dir, just not the lightweight checkout. | 19:26 |
| hatch | Makyo: I'll review your branch | 19:35 |
| hatch | waiting for core-y stuff | 19:35 |
| Makyo | hatch, cool, thanks. | 19:35 |
| gary_poster | ok, I need to stop now. be back in 3 hours or so | 19:38 |
| hatch | Makyo: review done - have some q's before QA | 19:39 |
| Makyo | hatch, first question - it does. Visibility is bound to charmChanged. | 19:40 |
| hatch | oh ok - I didn't see that, must have been from a previous branch? | 19:40 |
| Makyo | hatch, second question - Good point. Will think about it. | 19:40 |
| hatch | cool thanks | 19:41 |
| Makyo | hatch, What about the instance of someone clicking close right as the 'service was upgraded' message comes in? If they open the inspector again to read the message, it won't be there. Since, in this case, that link doesn't do anything but dismiss the message, it seems a small thing to just leave it there. | 19:49 |
| Makyo | hatch, wording isn't final, fyi, just a functional branch until we have bandwidth from design to nail that down. | 19:49 |
| hatch | right but won't the configChanged attribute still be true? | 19:50 |
| Makyo | configChanged? | 19:50 |
| hatch | er | 19:50 |
| Makyo | hatch, charmChanged? | 19:50 |
| hatch | charmChanged | 19:50 |
| hatch | yeah | 19:50 |
| Makyo | hatch, Yes, but the only reason for that attribute is to control the visibility of that message. | 19:50 |
| hatch | ohh - so then can I propose it be renamed? | 19:51 |
| hatch | I assumed it had greater purpose | 19:51 |
| Makyo | You can propose, but that's exactly what has happened - the charm for the service has been changed. If you can think of something better that still gets that idea across, be my guest. | 19:51 |
| Makyo | That is, if we need to rely on it later and it's something like "showThisStupidMessage", I'll probably veto :) | 19:51 |
| hatch | ok so.... | 19:54 |
| hatch | if userX upgrades, then closes the inspector via the X then never goes back | 19:55 |
| hatch | the model will be in 'charmChanged' true state | 19:55 |
| hatch | then what happens if a new charm comes available? | 19:56 |
| Makyo | If they then open the inspector, they'll see the message "service has been upgraded to service-n", and below that they'll see "a new upgrade is available", which will be charm-(n+1) | 19:57 |
| Makyo | If they haven't closed their browser, etc. etc. | 19:57 |
| hatch | right | 19:57 |
| hatch | right | 19:57 |
| hatch | yeah ok I guess that's not horrible | 19:58 |
| Makyo | Buuuuut that won't ever happen. | 19:58 |
| Makyo | So nevermind. | 19:58 |
| Makyo | Only if way that UX would show is if they downgraded, or if they upgraded to not-the-latest. | 19:58 |
| hatch | or a new charm was uploaded? | 19:59 |
| Makyo | No, because we don't receive events for that. | 19:59 |
| Makyo | We only ever request data from charm store - we never receive it un-asked-for. | 19:59 |
| Makyo | And we only ever do that on the service-add delta, which only happens once. | 19:59 |
| hatch | ahh ok gotcha | 20:00 |
| hatch | I suppose as a user I might think that closing and re-opening the inspector is akin to refreshing | 20:00 |
| hatch | but maybe not | 20:00 |
| hatch | ok code LGTM | 20:00 |
| hatch | will qa soon :) | 20:00 |
| Makyo | Yeah, that's a question we already have for design; I just picked random words :) | 20:00 |
| hatch | lol | 20:06 |
| hatch | boat starfish desk credit card -refresh- bottle window paint sign | 20:07 |
| hatch | I think it gets the point across | 20:07 |
| Makyo | Working on a project for a friend right now that pops up random bits of idea stubs that you can string together into an idea as a prompt for creative writing, actually, so basically that :D | 20:08 |
| Makyo | Well, not RIGHT now. | 20:09 |
| hatch | lol | 20:09 |
| hatch | Makyo: no luck on the QA - hitting refresh wipes out the config | 20:14 |
| hatch | so it's empty | 20:14 |
| Makyo | As in just a black rectangle, or as in the fields are empty? | 20:16 |
| Makyo | Because I had the black rectangle problem earlier on. | 20:17 |
| hatch | well everything else is there | 20:17 |
| Makyo | YEah, just config I mean | 20:17 |
| hatch | and the template renders the proper markup | 20:17 |
| hatch | ohh yeah | 20:18 |
| hatch | I see the issue | 20:18 |
| hatch | I'll reply in review | 20:18 |
| Makyo | Okay. Works for me, so be specific. | 20:19 |
| hatch | really? it shouldn't :) | 20:19 |
| Makyo | You still haven't even answered my question, so I'm having to guess what you mean. :P | 20:20 |
| hatch | oh sorry | 20:20 |
| hatch | the viewlet is empty | 20:20 |
| Makyo | It's not for me. | 20:20 |
| Makyo | I'm going through the diff now to make sure it's not a problem from having to lbox from the branch, rather than the checkout. | 20:20 |
| hatch | ahh ok - yeah because it's definitely broken here with and w/o the flag in the url | 20:21 |
| hatch | and reading the code it definitely shouldn't work | 20:21 |
| Makyo | Huh, seems to match what I have. Curious as to why it works for me but not for you. | 20:24 |
| hatch | yeah - if you see the render method of the viewlet you can see why it 'shouldn't work | 20:26 |
| hatch | because it's creating a new container and rendering into that | 20:26 |
| hatch | which is never attached to the DOM | 20:27 |
| Makyo | This is why we had the call :/ | 20:27 |
| Makyo | Why it works for me aside, what's the next step? | 20:27 |
| Makyo | Calling show? | 20:27 |
| hatch | if(!this.container) { Y.Node.create(this.templateWrapper); } | 20:29 |
| hatch | line 85 of service-config.js | 20:29 |
| hatch | I'll test that to see if it works here | 20:29 |
| hatch | Makyo: yep that's the fix | 20:31 |
| Makyo | Hell if I can test. | 20:31 |
| hatch | bah although then the events are not bound properly | 20:31 |
| hatch | for real - it's working for you? | 20:31 |
| Makyo | Oh for pete's sake. | 20:31 |
| Makyo | Yes. | 20:31 |
| Makyo | I'm going for a walk. This is a bit too much. | 20:32 |
| hatch | sure - lemme know when you're back and I'll tell you the next steps | 20:44 |
| hatch | Makyo: here is a diff which fixes the expanding textarea and blacking out issue: https://gist.github.com/hatched/6720366 I don't know where the code is attached which causes the 'cancel/save' butons to popup is attached | 20:53 |
| bac | gary_poster: would you moderate my mailing list message and add my brad.crittenden address? | 21:03 |
| bac | i think it gives you the option when approving | 21:03 |
| gary_poster | bac done | 21:04 |
| bac | ty | 21:04 |
| bac | mail aliases seemed like a good idea | 21:04 |
| bac | benji: i'll propose this branch in a little bit so it'll be ready for review first thing tomorrow | 21:16 |
| benji | cool | 21:16 |
| hatch | gary_poster: huwshimi call in 10? | 22:20 |
| huwshimi | Morning | 22:21 |
| hatch | morning | 22:24 |
| * bcsaller goes to hide after posting the embarrassingly large https://codereview.appspot.com/13997043 | 22:25 | |
| hatch | you...suck | 22:28 |
| hatch | lol | 22:28 |
| hatch | I GUESSS I'll do it | 22:28 |
| bcsaller | ha, sorry | 22:28 |
| bcsaller | owe you beer | 22:28 |
| hatch | good thing we're going to CA, I hear they like beer there | 22:29 |
| bcsaller | to be fair 38 files changed, 1293 insertions(+), 6413 deletions(-) | 22:29 |
| bcsaller | mostly removes code | 22:29 |
| hatch | before I start is there anywhere you think would bennefit from some reviwer notes? | 22:29 |
| hatch | reviewer even | 22:29 |
| bcsaller | I'll do a pass over the CR, but its mostly not so complex | 22:30 |
| huwshimi | hatch: What url are we using today? | 22:31 |
| huwshimi | (For the hangout) | 22:31 |
| hatch | we use the ones in the calendar link | 22:31 |
| hatch | it has a 'join this hangout' button | 22:31 |
| hatch | I don't think gary_poster is around yet though | 22:31 |
| bcsaller | hatch: there are notes now | 22:39 |
| hatch | cool thanks | 22:41 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!