[01:12] <wgrant> StevenK: https://code.launchpad.net/~wgrant/launchpad/bi-dependencies-1/+merge/188489 and https://code.launchpad.net/~wgrant/launchpad/bi-dependencies/+merge/188493
[01:12] <StevenK> Ursinha, wgrant: What do you think about reverting r16775?
[01:13] <wgrant> The fix is probably very simple
[01:13] <wgrant> Not sure how Ursinha's going with that, though.
[01:13] <StevenK> wgrant: https://code.launchpad.net/~stevenk/launchpad/drop-kick-getBugTasks/+merge/188490
[01:13] <StevenK> wgrant: Oh, is that a minus one, as opposed to dash one?
[01:13] <wgrant> StevenK: k
[01:13] <wgrant> StevenK: Er, yeah, I missed a -
[01:14] <Ursinha> wgrant, it depends on how much you guys need to deploy new stuff today
[01:14] <wgrant> Was meant to be dash-minus-1
[01:14] <StevenK> Ursinha: It would be nice to deploy, but we can wait a bit
[01:15] <StevenK> Ursinha: I have my own QA to finish off, so please don't rush on my account. :-)
[01:16] <Ursinha> okay
[01:21] <StevenK> 471+ self.assertEqual(('snap crackle pop', ''), output)
[01:21] <StevenK> wgrant: You must answer for your crimes.
[01:22] <wgrant> StevenK: Hey, the test had 'pop' in the final position, and there was a hole in the test coverage for buildd_name, so the test string ended up with three elements, 'pop' in the last. My hands were tied.
[01:23] <StevenK> wgrant: Tell it to the judge.
[01:24] <StevenK> wgrant: r=me for -1, with one niggle
[02:23] <Ursinha> wgrant, so, PackageUploads that refer to copies don't have a SourcePackageRelease, and attachTranslationFiles is a spr method
[02:23] <Ursinha> should I move it somewhere else? or add one for copies?
[02:30] <wgrant> Ursinha: It might be worth moving somewhere else, but you will still need to find a SourcePackageRelease.
[02:30] <wgrant> I suspect.
[02:30] <wgrant> Unless you can just use the source name, let me see.
[02:31] <wgrant> Hmm
[02:31] <wgrant> Ursinha: I'd move attachTranslationFiles elsewhere, yeah. It doesn't really need a SourcePackageRelease; you have all you need on the PackageCopyJob too.
[02:31] <wgrant> I'd just put it in a non-method function somewhere, I think.
[02:31] <wgrant> StevenK: Thanks.
[02:33] <Ursinha> wgrant, what I did so far is to add a component_name and target_distroseries properties in PackageUpload, following the pattern of other properties that vary according to them being copies or not
[02:34] <wgrant> Ursinha: PackageUpload.distroseries already exists
[02:35] <Ursinha> wgrant, I saw that, but it made no sense to me that other parts of the code query sourcepackagerelease to know the target
[02:35] <wgrant> But you'll need to look up the component name from the relevant SourcePackagePublishingHistory in the target. I'm not sure if there are existing methods to help with that.
[02:35] <Ursinha> so I thought this might mean something else
[02:35] <wgrant> Ursinha: It used to make sense, sort of.
[02:35] <Ursinha> haha
[02:35] <wgrant> This code was already buggy in some copy circumstances.
[02:35] <Ursinha> can I safely use PackageUpload.distroseries as target then?
[02:35] <wgrant> Yes.
[02:36] <Ursinha> okay.
[02:36] <wgrant> PackageUpload.archive, PackageUpload.distroseries, PackageUpload.pocket are accurate
[02:36] <wgrant> But you can't use sourcepackagerelease.component. You'll probably need to find the latest SPPH for the relevant (archive, distroseries, pocket, sourcepackagename), and look up the component from that.
[02:37] <wgrant> That component lookup was already buggy for some security updates, but it is a lot more important now.
[02:37] <Ursinha> wgrant, so it was buggy before?
[02:38] <wgrant> Yes, for source copies.
[02:38] <wgrant> This is probably actually more of a problem than I thought.
[02:38] <Ursinha> hehe
[02:39] <wgrant> Or maybe not.
[02:39] <wgrant> The component check only applies to pre-oneiric, so its brokenness isn't too bad.
[02:39] <wgrant> But it's still only a few lines to fix, so we probably should.
[02:42] <wgrant> StevenK: Do you have a testfix?
[03:06] <Ursinha> wgrant, should I use the SPR.publishings or query the archive with getPublishedSources?
[03:11] <wgrant> Ursinha: You'll have to use getPublishedSources.
[03:22] <StevenK> wgrant: Looking now, I was grabbing lunch.
[03:22] <StevenK> Sounds like a few more deletions are needed.
[03:34] <StevenK> wgrant: testfix == r16787
[04:16] <StevenK> wgrant: With the death of proc_families, should I QA to packagecloner on DF?
[04:16] <StevenK> s/to/the/
[04:17] <wgrant> StevenK: Yeah. Can hopefully do just a small PS.
[04:18] <StevenK> IDS{,J} got the same treatment, but I don't really want to do that.
[04:26] <wgrant> StevenK: IDSJs are easy and cheap to test
[04:27] <wgrant> StevenK: Just create one with a tiny PS
[04:27] <wgrant> I normally create a µbuntu containing only bzr packages, IIRC
[04:33]  * StevenK stabs SSO until it bleeds to death
[04:35] <wgrant> Why?
[04:36] <StevenK> wgrant: Because of the stale page error if you mis-type or don't hold down the yubikey long enough and it puts the default token in, and because once it logs me in it wants me to update my details and there's no way to say "Go away and auth to the site I was originally at"
[04:37] <wgrant> Ah, handy
[04:37] <wgrant> Filed a bug?
[04:42] <StevenK> Not yet
[04:42] <Ursinha> wgrant, is that ok if I move the content of attachTranslationFiles to run() in the PackageTranslationsUploadJob? having a packageupload at that point is enough (it seems), so I'd provide the packageupload and the libraryfilealias to the job
[04:43] <wgrant> Ursinha: It might be useful to have it in a separate function in the job's module so you can continue to test it directly. But otherwise that sounds fine.
[04:43]  * StevenK tries to remember how to create an IDSJ
[04:44] <wgrant> StevenK: Create a new distro, create a series within it, initialise series.
[04:46] <StevenK> Hm
[04:46]  * StevenK anoints himself
[04:49] <Ursinha> wgrant, okay, done :) now, the importer is currently sourcepackagerelease.creator, who should it be if it's a copy?
[04:50] <StevenK> PCJ.requester
[04:50] <StevenK> Or something close
[04:51] <wgrant> Probably PU.findPersonToNotify
[04:51] <wgrant> Which uses PCJ.requester when appropriate
[04:51] <wgrant> I think we already use that for the job creator, don't we?
[04:51] <StevenK> lib/lp/soyuz/model/packagecopyjob.py doesn't mention findPersonToNotify
[04:52] <wgrant> Not PCJ, PTUJ.
[04:52] <StevenK> lib/lp/soyuz/model/packagetranslationsuploadjob.py also doesn't mention findPersonToNotify
[04:53] <StevenK> And findPersonToNotify wants an SPR, it doesn't deal with PCJs
[04:53] <wgrant>         blamee = packageupload.findPersonToNotify()
[04:53] <wgrant>         getUtility(IPackageTranslationsUploadJobSource).create(
[04:53] <wgrant>             sourcepackagerelease, libraryfilealias, blamee)
[04:53] <wgrant> Ah right
[04:53] <wgrant> At this point we have an SPPH, though
[04:53] <Ursinha> wgrant, attachTranslationsUpload uses the requester, it's another thing
[04:54] <wgrant> So it'll use SPPH.creator, which should be the PCJ requester.
[04:54] <Ursinha> I recall the same confusion during the sprint
[04:54] <Ursinha> it rendered a testfix that time
[04:54] <Ursinha> :)
[04:55] <StevenK> Grr.
[04:55]  * StevenK pokes around for pubconf
[04:55] <wgrant> Ursinha: Use PTUJ.requester, rather than SPR.creator.
[04:55] <wgrant> StevenK: Pubconfs can be set in the UI
[04:56] <StevenK> wgrant: But the details don't matter?
[04:57] <wgrant> StevenK: Not particularly, unless you want to publish it.
[05:00] <StevenK> The initialization of Turgid Turtle has been scheduled and should run shortly.
[05:00] <StevenK> I blame infinity
[05:00] <wgrant> ...
[05:00] <wgrant> µbuntu
[05:00] <wgrant> Not microbuntu!
[05:01] <wgrant> We aren't Fedora
[05:01] <wgrant> Our infrastructure likes Unicode.
[05:01] <StevenK> wgrant: It didn't for the name
[05:01] <wgrant> Not for the name, no. :(
[05:02] <StevenK> wgrant: How about that, then
[05:02] <wgrant> Superior.
[05:12] <StevenK> wgrant: Hm, where do OOPSes go? :-(
[05:13] <wgrant> StevenK: Should be /srv/launchpad.net/dogfood-logs/
[05:13] <StevenK> ProgrammingError: permission denied for relation packageupload
[05:13] <StevenK> WAT
[05:13] <wgrant> Oh
[05:13] <wgrant> I was trying to remember why I had that diff on DF
[05:13] <wgrant> That was it
[05:14] <StevenK> So it was your fault? :-(
[05:14] <wgrant> Not exactly, I just locally patched that permission in last time I was testing this
[05:14] <wgrant> Because it had broken due to PCJ changes, IIRC.
[05:14] <wgrant> Specifically CUC
[05:14] <wgrant> I think
[05:15] <StevenK> Do we want to land a security.cfg change?
[05:15] <wgrant> Test on DF and land, yeah
[05:15] <StevenK> Yup
[05:15] <StevenK> Digging out the job so I can mangle it back to Waiting
[05:15] <wgrant> I'd just create a new one.
[05:17] <StevenK> Hm, IDS has SELECT on packageupload*
[05:18] <StevenK> Ah
[05:18] <StevenK> It wants INSERT on it and PUC
[05:24] <StevenK> OH
[05:24] <StevenK> And UPDATE
[05:24] <StevenK> Damn searchable_names :-P
[05:40] <StevenK> wgrant: https://dogfood.launchpad.net/microbuntu/turgid
[05:40] <StevenK> wgrant: That's IDSJ run, and then harness'ing up updatePackageCount()
[05:41] <wgrant> eh
[05:41] <wgrant> Heh
[05:41] <wgrant> So you know how I said our Unicode support was good
[05:41] <wgrant> https://dogfood.launchpad.net/microbuntu/turgid/+source/2ping
[05:42] <StevenK> HAHA
[05:43] <wgrant> Fortunately Python 3 prevents people from writing such retarded code.
[05:43] <StevenK> wgrant: How tasty are those words you're now eating?
[05:44] <wgrant> Not entirely.
[05:46] <StevenK> wgrant: Landing security.cfg change
[05:47] <lifeless> turgid eh
[05:47] <StevenK> lifeless: It was infinity's suggestion for what T would be
[05:48] <StevenK> And it's a crappy test series on DF, so meh? :-)
[05:48] <lifeless> I think you've been trolled
[05:48] <StevenK> wgrant: Are you bouncing the appserver?
[05:48] <wgrant> I am
[05:48] <wgrant> It didn't come back up...
[05:48] <StevenK> Haha
[05:50] <StevenK> Hm, that looks better
[05:51] <StevenK> wgrant: Facepalm at the diff
[05:52] <wgrant> It won't affect many places
[05:52] <wgrant> Because .format is backported from 3, it is slightly more Unicode-pedantic.
[05:52] <wgrant> % works fine
[05:55] <StevenK> wgrant: So I'm happy enough to qa-ok it, any objections?
[05:56] <wgrant> Sure
[05:56] <wgrant> As long as you've tested the other changed bits
[05:57] <StevenK> wgrant: IArchive API bits, editing an archive and changing restricted processors, creating a distribution and doing the same, IDSJ and package cloner
[05:57] <wgrant> Right
[05:57] <wgrant> Sounds reasoanble.
[05:57] <StevenK> I don't think there is anything else
[06:26] <StevenK> wgrant: Is http://lpbuildbot.canonical.com/builders/lucid_lp_lxc/builds/892/steps/shell_9/logs/summary your fault?
[06:29] <wgrant> StevenK: I don't believe so.
[06:29] <wgrant> I haven't touched BuilderSlave, and that one has been occasionally failing 4eva.
[10:53] <Ursinha> cjwatson, I'm going to take a nap and should return soon, hopefully the fix for bug 1201485 will be able to land today
[10:53] <_mup_> Bug #1201485: Need to import translations for the unity daily builds <qa-bad> <langpack-o-matic:Triaged> <Launchpad itself:In Progress by ursinha> <Ubuntu Translations:Triaged> <https://launchpad.net/bugs/1201485>
[10:54] <cjwatson> OK, great
[10:54] <cjwatson> Happy to help reviewing
[22:18] <lifeless> wgrant: https://answers.launchpad.net/launchpad/+question/236697 when you get a chance
[22:19] <lifeless> wgrant: some of them I can do and am doing
[22:19] <lifeless> wgrant: but I think a little help will be needed
[23:41] <wgrant> lifeless: Do you just need the tuskar -> tripleo merge done?
[23:42] <lifeless> wgrant: and python-tuskarclient reowned
[23:44] <wgrant> lifeless: You can't ask the current owner to do that?
[23:44] <lifeless> wgrant: sure, they're at an offsite teambuilding thing today :P
[23:44] <lifeless> wgrant: but one thing at a time; the team merge first
[23:47] <wgrant> lifeless: tuskar has a mailing list.
[23:48] <lifeless> gnar
[23:48] <lifeless> ok, I'll just manually add the people I guess
[23:50] <StevenK> lifeless: API it?
[23:50] <wgrant> lifeless: Note that it still owns a couple of trunks, I think.
[23:51] <lifeless> wgrant: meh, mirrors from git