=== _salem is now known as salem_ === salem_ is now known as _salem === jono is now known as Guest53113 === iahmad_ is now known as iahmad|afk [08:44] pstolowski, just me who dropped out? === iahmad|afk is now known as iahmad === iahmad is now known as iahmad|afk [09:05] Saviq, got anything new for me to look at? [09:06] nic-doffay, what's the deal with filters? [09:07] Saviq, waiting on fginther to sort out an autopilot issue with the multi selector landing. === alan_g is now known as alan_g|afk [09:21] nic-doffay, there's a conflict in multi selector branch [09:21] dednick, pete-woods, so, we're ready to pull the plug [09:21] Saviq, another one? [09:21] Saviq: um? plug? [09:21] Saviq, I solved a conflict yesterday evening. [09:21] dednick, network indicator [09:21] nic-doffay, maybe you didn't push? [09:21] nic-doffay, or maybe something merged in the mean time [09:22] dednick, pete-woods I'll build unity8 and indicator-network packages with: [09:22] https://code.launchpad.net/~saviq/unity8/drop-network-agents/+merge/189009 [09:22] https://code.launchpad.net/~indicator-applet-developers/indicator-network/secret-agent/+merge/182898 [09:24] Saviq: yeah, assuming it all works :) === alan_g|afk is now known as alan_g [09:26] Saviq, looks like something new was merged. [09:26] dednick, you should proof-check that my cleanup there is not too trigger-happy [09:27] Saviq: doing now. [09:27] dednick, pete-woods, and then I'd like both of you (Mirco isn't here) to test on a newest image [09:27] * Saviq builds [09:28] Saviq: You sure we want to remove the IndicatorModel::indicatorData? We may need it later. [09:28] dednick, I think we shouldn't need it [09:28] dednick, and if we don't have it - there's more pressure to make it right [09:29] s/make/do/ [09:29] Saviq: ok. [09:29] my funeral i guess [09:29] dednick, and if need be - we can always bring it back - it's in the history [09:29] indeed [09:30] dednick, on that note - feels like IndicatorsModel should be a singleton now [09:30] but let's leave that for another cleanup [09:30] pstolowski: soo https://codereview.qt-project.org/#change,67214 [09:30] Saviq: ↑↑↑ [09:31] tsdgeos, did I tell you you ROCK, sir? [09:31] thank you [09:31] i kind of cheated [09:31] since the same bug is in there [09:32] is in a few other places [09:32] in the same qsortfilterproxymodel [09:32] and since we use it extensively [09:32] i should problable fix those too [09:32] but let's get this in first [09:32] and then get the others [09:35] Saviq: tbh i am not sure it is *the* fix, but looks quite like it i'd say [09:35] tsdgeos, yup, good [09:35] problem is [09:35] the only guy that knows about that told me he'd be drunk until next week :D [09:35] since oktoberfest and whatnot [09:35] so we aint going to get a review today nor tomorrow [09:36] tsdgeos, right ;) [09:36] tsdgeos, we'll distro-patch, as usual [09:36] * tsdgeos gets onto creating the bug [09:38] tsdgeos, thanks [09:38] tsdgeos, want me to prep a MP with the patch in place in the mean time? [09:40] Saviq: that'd be great [09:40] Saviq: btw the other one you created for the delegate range patch [09:40] you should mark it as merged or something [09:40] since the patch is already in [09:40] tsdgeos, is not? [09:40] i think not [09:40] tsdgeos, will do [09:42] tsdgeos, the new one's qtbase, right? [09:42] yep [09:45] tsdgeos, sorry, have the QTBUG handy? [09:45] nope [09:45] just the codereview [09:48] tsdgeos, it's https://codereview.qt-project.org/#change,66585 ? [09:48] no [09:48] Saviq: https://codereview.qt-project.org/#change,67214 [09:48] tsdgeos, that? didn't we want the thing for empty scope views? [09:48] tsdgeos, or is that handled already? [09:49] that's already integrated [09:49] aah [09:49] and Mirv's working on it [09:49] integrated in qt [09:49] upstream [09:49] yeah [09:49] I thought that's what we were after [09:49] Mirv: told me he was working in the distropatch yesterday [09:50] Saviq: no this one is one needed for pstolowski's https://code.launchpad.net/~stolowski/unity8/category-reordering [09:50] tsdgeos, yeah yeah, I know what it is [09:50] ok :-) [09:51] Mirv: https://bugs.launchpad.net/ubuntu/+source/qtbase-opensource-src/+bug/1234603 [09:51] Ubuntu bug 1234603 in qtbase-opensource-src (Ubuntu) "[Patch] Fix rowsInserted not being emmited in some cases in QSortFilterProxyModel" [Undecided,New] [09:53] tsdgeos: yep, it's in unapproved queue now, after tested by me today and chris etc. during the night [09:53] ook [09:53] tsdgeos: awesome, thanks! [09:53] Mirv: there's another one we'd need https://bugs.launchpad.net/ubuntu/+source/qtbase-opensource-src/+bug/1234603 [09:53] Ubuntu bug 1234603 in qtbase-opensource-src (Ubuntu) "[Patch] Fix rowsInserted not being emmited in some cases in QSortFilterProxyModel" [Undecided,New] [09:54] Saviq: slightly under zealous. http://pastebin.ubuntu.com/6187471/ [09:54] dednick, ah! [09:58] Saviq: otherwise all good [09:58] dednick, ok, packages coming right up [09:58] or well, in 10 mins [09:59] tsdgeos: ok.. [10:06] tsdgeos, Mirv https://code.launchpad.net/~saviq/ubuntu/saucy/qtbase-opensource-src/add-proxymodel-patch/+merge/189028 [10:07] tsdgeos, please do a sanity-check, there was a small conflict [10:07] Saviq: something's wrong [10:07] tsdgeos, no, it's right [10:08] you are adding the whole qsortfilterproxymodel.cpp file? [10:08] tsdgeos, yeah, quilt [10:08] tsdgeos, look at the paths [10:08] Saviq: thanks, I'm really busy at the moment with other integration [10:08] Saviq: ok, no clue how quilt works tbh [10:09] Saviq: where's the patch supposed to be? [10:09] tsdgeos, at the bottom ;) [10:09] tsdgeos, the changes to the actual files [10:09] i can't find it :D [10:09] tsdgeos, but launchpad won't display it [10:09] tsdgeos, launchpad crops at 5k lines [10:09] doh [10:09] ok [10:09] tsdgeos, will paste you just the patch, sec [10:10] there's a -1 line arrangement needed [10:10] tsdgeos, http://paste.ubuntu.com/6187511/ [10:10] yep, that's right [10:11] tsdgeos, quilt - long story short, it's a poor-man's version control - it stores all modified files before patching [10:11] tsdgeos, but is really nice in letting you rewind, drop a patch, replay [10:15] i see === alan_g is now known as alan_g|afk [10:34] dednick, ok, I broke something... [10:34] Saviq: ? [10:35] dednick, looking at unity8 logs [10:35] dednick, but https://people.canonical.com/~msawicz/ext-snaps/ [10:35] Saviq: hm. i cant get to that address [10:35] dednick, huh? [10:35] dednick, ah, perms [10:36] hm. the s in https [10:36] dednick, weird, it's a+rw [10:36] dednick, ah, interesting [10:37] Saviq: unity-notifications ? [10:37] dednick, right! [10:37] dednick, wait [10:37] dednick, that's released isn't it [10:37] Saviq: no [10:37] dednick, k, building [10:37] Saviq: unless you did a manual === iahmad|afk is now known as iahmad [10:40] dednick, but anyway, that's unrelated, as I'm just not getting any indicators [10:40] dednick, indicator pages, that is [10:41] dednick, I do get indicators, but not their pages [10:41] nor titles [10:42] must've removed too much === alan_g|afk is now known as alan_g [10:44] hm. [10:45] i ran it up on local build. seemed to be ok. [10:45] dednick, yeah, building locally now, too [10:47] Saviq: you get the icons though? [10:47] oh right, you did say [10:47] dednick, yes [10:47] trying a run_on_device. [10:49] Saviq: is their title coming in empty? or "indicator-XXX" [10:49] dednick, indicator-XX [10:50] heh... I cleaned my device, so now installing everything from scratch... [10:51] Sounds like the IndicatorPage not being able to load. === _salem is now known as salem_ [10:54] dednick, pushed unity-notifications to people.c.c === salem_ is now known as _salem [10:55] Saviq: file:///usr/lib/arm-linux-gnueabihf/unity8/qml/Unity/Indicators/MenuItemFactory.qml:22:1: module "Unity.Indicators.Network" plugin "IndicatorsNetworkQml" not found [10:55] dednick, right [10:56] dednick, I didn't build with that gone, hoped it's gonna be fine ;) [10:56] dednick, /me fixes [10:56] dednick, btw, we should've bumped some versions here and there... [10:58] dednick, plugin.qmltypes doesn't make sense there now either [11:00] Saviq: still getting an error. Cant load Indicators.IndicatorModel now. :( [11:00] *IndicatorsModel [11:00] dednick, I'm at 270/451 on the device... [11:01] i just edited the lib qmldir manually [11:02] that's really odd. i cant even create the Shell now. [11:03] oh. that's just because I'm retarded. [11:07] dednick, I'm getting Binding loop detected for property "indexActive" a lot [11:07] dednick, yeah, it works apart from ↑ [11:08] Saviq: yeah, i've seen that. it wont actually cause an problem. just an stupid thing in the MenuContentActivator. [11:08] *almost* worked, need to install notifications [11:11] Saviq: i installed. not popping up a notification though :( [11:11] dednick, did here? [11:11] just didn't show the text entry, 'cause notifications plugin was old [11:11] hm maybe i missed something [11:11] dednick, you rebooted? [11:11] yeah [11:12] might have multiple network indicators installed [11:14] oh. didnt install new network indicator. dpkg error [11:18] dednick, yeah, works fine here, will have a new unity8 pkg in a bit to retest [11:19] er. 'm having network issues :) cant download new package... === hikiko is now known as hikiko|lunch [11:28] mhr3_, hey michal, how do I know when a plugin is disabled? [11:41] Saviq, you know? ^ [11:51] here's the branch https://code.launchpad.net/~cimi/unity8/unity8.dash-plugins-renderer/+merge/189055 [11:51] Cimi, I think the icon source [11:51] Saviq, icon source? [11:52] Cimi, or not... [11:52] Cimi, maybe a hint then? [11:52] Cimi, just print out all the data you get from the scope ;) [11:52] Saviq, tried printing model.hints [11:52] Saviq, how do I print the whole thing? [11:52] console.log model? :D [11:53] Cimi, yeah, it's there in the metadata [11:53] Saviq: so that crash doesn't give us much :-/ [11:53] http://paste.ubuntu.com/6187816/ [11:54] tsdgeos, right [11:54] tsdgeos, apport-bug it [11:54] tsdgeos, and I'll try and apport-retrace it [11:54] Saviq, how do I print the whole model? [11:54] Cimi, don't [11:54] 0x42a65fe0 is inside /android/system/lib/libc.so and 0x4702d798 is inside no lib [11:54] Cimi, it's "scope_disabled" in the hints [11:54] Saviq, so how do I know the right rule? [11:55] wonder what it is, v8 autogenerated code¿? [11:55] Cimi, hints['scope_disabled'] == 1 [11:55] Cimi, or something like that [11:56] Cimi, make that metadata['scope_disabled'] == 1 [11:56] Cimi, libunity-tool -g is your friend :) [11:57] Saviq, model.hints['scope_disabled'] is undefined [11:57] Cimi, read [11:57] Cimi, metadata [11:57] Cimi, not hints [11:57] Cimi, if you'd look at categoryresults.{h,cpp} first, you'd know [11:58] dednick, updated the packages on people.c.c [11:59] Cimi, mhr3_, what's "toggled"? [12:00] Saviq, the rendererhint [12:00] Saviq, dunno why it's called that way [12:00] Cimi, I get it... but that seems not descriptive enough TBH... [12:00] Saviq, yeah === hikiko|lunch is now known as hikiko [12:02] dednick, it's worky! [12:02] pete-woods, you around? [12:03] Saviq: yep, been a little busy this morning, though [12:03] pete-woods, wanna merge snap decisions? [12:03] pete-woods, I just have one question - will we not break desktop? === alan_g is now known as alan_g|lunch [12:03] Saviq: (replied to your MR question), indicator-network isn't part of desktop [12:04] pete-woods, ah [12:04] pete-woods, nm-applet still? [12:04] Saviq: yep [12:05] Saviq: it's the only non-converged indicator, I think [12:05] Saviq, model.metadata['scope_disabled'] is undefined for me [12:05] Cimi, is metadata undefined, too? [12:05] Saviq, no it's a qvariant [12:05] pete-woods, so then, indicator-network should start depending on unity8, or maybe unity-notifications at a version > something (we'll bump unity-notifications version) [12:06] Cimi, go into scope.cpp to debug, then [12:06] jibel, Saviq bug 1234670 [12:06] bug 1234670 in unity8 (Ubuntu) "Cannot launch apps anymore" [High,New] https://launchpad.net/bugs/1234670 [12:06] Cimi, erm, categoryresults.cpp [12:07] om26er, thanks, we're reworking the whole focus machinery now, especially with mir around the corner [12:07] om26er, could you try the same under mir? [12:07] Saviq, ok, sure. [12:07] Saviq: whichever one you want, should probably be unity8, as that's what is actually exporting the dbus interface [12:08] pete-woods, btw, x-canonical-ext-snap-decisions isn't there anymore [12:08] pete-woods, x-canonical-private-menu-model is the only capability to advertise support for that [12:09] om26er, Saviq I have something very similar under Mir [12:09] but I had to close the calculator, then it doesn't reopen [12:09] jibel, could you try with unity-mir from https://code.launchpad.net/~gerboland/unity-mir/add-fail-and-resume-focus-support/+merge/188040/comments/432495 too [12:09] ? [12:10] Saviq: okay, does that mean I just delete the line that sets this? notificationHints["x-canonical-ext-snap-decisions"] = "true"; [12:11] pete-woods, yeah [12:11] pete-woods, depend on unity8 >= 7.82, too [12:14] Cimi, Saviq, it's in the icon actually, but unity8 doesn't have annotated icon [12:15] mhr3_, hmm, libunity-tool shows it in metadata? [12:15] but well... yea it's in the metadata too [12:15] Saviq: update pushed [12:15] pete-woods, cheers [12:15] mhr3_, can we use it for now? === jhodapp|afk is now known as jhodapp [12:24] dednick, https://code.launchpad.net/~saviq/unity-notifications/bump-to-0.1.1/+merge/189059 https://code.launchpad.net/~saviq/unity8/bump-to-7.82/+merge/189060 [12:25] pete-woods, is there a review needed on the indicator-network branch? [12:25] didrocks, help? [12:25] didrocks, unity8 will stop providing the network agent (password entry), indicator network will start (through unity8's notifications) [12:25] Saviq: yep, it should be fairly tight, though [12:26] pete-woods, can anyone on your team do that? [12:26] didrocks, so we need to make sure that they both get upgraded at the same time, or not at all - how do we do that? [12:26] dandrader: so we ended up merging a slightly mod'd version of what you mp'd y'day [12:26] https://code.launchpad.net/~robertcarr/mir/1233944-addendum/+merge/188983 [12:26] kgunn, yeah, I saw it [12:27] cool [12:27] reviewed even [12:27] dandrader: so y'day when you tested it, were you able to run an autopilot test ? [12:28] pete-woods, can you add a version bump to indicator-network so that we can Breaks: indicator-network < $the_new_version [12:28] pete-woods, I think that will make sure we upgrade both unity8 and indicator-network at the same time [12:28] kgunn, didn't do a full blown test. just checked that the fake (uinput) devices created by those autopilot tests did get loaded by android-input [12:28] Saviq: sure, will do that now [12:28] dandrader: ah...i ask, b/c we may stil not have a data point [12:29] kgunn, data point? [12:29] dandrader: lots of struggling with build/packages and then poor thomi ended up testing for a while but w/o mir enabled...doh [12:29] kgunn, but i'll try it today, as it might be that the input device created by autopilot is not fully recognized by android-input [12:29] Saviq: what should the new version be, like 0.5.1-0ubuntu1, or do I need to do something more complicated? [12:29] dandrader: data point as in...does it realy fully enable the AP's [12:30] pete-woods, bump the upstream version [12:30] dandrader: thanks to try.. [12:30] pete-woods, so 0.5.1 should be enough - the upstream merger will do the rest [12:30] pete-woods, assuming 0.5.1 is higher than what's there currently ;) [12:31] Saviq: it's 0.5.0+13.10.20130918-0ubuntu1 atm [12:31] pete-woods, yeah, 0.5.1 is good [12:32] okay, thanks, I have no idea about our versioning strategy [12:33] pete-woods, there is none ;D [12:33] pete-woods, with the upstream merger, no one cares anymore ;) [12:38] kgunn, we'll be ASKing for the extended snap decisions [12:38] kgunn, anything you have to hitch a ride? [12:45] Saviq: i don't think so...but thanks for asking [12:49] I have a trivial MR for the camera app if anyone does't mind helping: https://code.launchpad.net/~pete-woods/camera-app/minimum-infographic/+merge/188995 [12:50] pete-woods, drop the -0ubuntu1 [12:50] pete-woods, and it needs to be UNRELEASED for upstream merger [12:50] Saviq: thanks (I have no idea what I'm doing with the numbers) [12:50] (to make the merger happy that is) [12:50] Saviq: hmmm [12:50] pete-woods, nw [12:50] Saviq: can't apport-bug the report [12:51] tsdgeos, why? [12:51] in the pc says unity8 has changed since the crash [12:51] and in the phone i get *** Error: Invalid problem report [12:53] tsdgeos, yeah, you won't be able to do it from desktop [12:53] tsdgeos, ok, ignore [12:53] tsdgeos, it's not like we'd get more symbols anyway :/ [12:54] tsdgeos, let's see if it repeats [12:54] oka [12:56] sil2100, got a minute? [12:56] Saviq: what's up? [12:57] sil2100, so, the situation is: we're moving the secret agents for wifi passwords from unity8 to indicator-network [12:57] sil2100, so we need to upgrade both at the same time [12:57] sil2100, or none [12:58] sil2100, I've added Breaks: indicator-network (<< 0.5.1) to unity8, so they will not get installed together [12:58] https://code.launchpad.net/~saviq/unity8/drop-network-agents/+merge/189063 [12:58] sil2100, and Requires: unity8 (>> 7.82) to indicator-network, 'cause the password entry now goes through unity8's snap decisions [12:58] sil2100, sounds sane? [12:58] sil2100, https://code.launchpad.net/~indicator-applet-developers/indicator-network/secret-agent/+merge/182898 [12:59] sil2100, make that (>= 7.82) [12:59] pete-woods, I think you need to wrap in parens ↑ in debian/control, sil2100, that right? [13:00] Saviq: can confirm the indicator connection working. [13:01] Saviq: although it could probably use a "show password" field. [13:01] dednick, right, it's not there in the spec [13:01] i c [13:01] dednick, I did raise that with Mirco yesterday [13:01] Guys Music scope. if you do a search that results in one artist if you try clicking on it if move around the wheel but doesn't play, however if you turn the wheel to it when all are on display it plays when you click it [13:01] dednick, but well, it's not in the spec, so... [13:02] dednick, we'll be able to fix when the time comes [13:02] Saviq: yeah, i might just raise that with design today while i'm in the office [13:02] dednick, sure === alan_g|lunch is now known as alan_g [13:03] Saviq: functionally it's working though, so +1 on getting it in. [13:04] dednick, ok, you're it - you'll help me get this in, provided we get sil2100's ACK on packaging / dependencies [13:04] Saviq: yes, that sounds sane and looks ok - but you need the parents in the version in the indicator-network as you mentioned [13:04] sil2100, cool! [13:04] dednick, ok, you can start reviewing: [13:04] dednick, https://code.launchpad.net/~saviq/unity-notifications/bump-to-0.1.1/+merge/189059 [13:04] Saviq: please add that in the Landing Asks and noting that both are required to be released at the same time [13:04] sil2100, already there [13:05] dednick, https://code.launchpad.net/~saviq/unity8/drop-network-agents/+merge/189063 and https://code.launchpad.net/~saviq/unity8/bump-to-7.82 [13:05] (prerequisite) [13:05] sil2100, and well, in theory the deps should handle us releasing only one or the other ;) [13:06] Saviq: any idea why https://bugs.launchpad.net/unity8/+bug/1198282 appears in https://launchpad.net/~aacid/+upcomingwork if it's marked as dupe? [13:06] Ubuntu bug 1200374 in Unity 8 "duplicate for #1198282 Categories in Dash should only animate their height if visible" [Medium,Fix committed] [13:07] tsdgeos, probab;y 'cause it's stupid [13:07] makes sense :D [13:07] can you unassign me? i don't seem to be able to [13:08] tsdgeos, nope! [13:08] tsdgeos, I can't... [13:08] ok, let's just hope it goes away [13:08] yeah [13:08] tsdgeos, btw, I noticed yesterday... [13:09] tsdgeos, expand dash plugins, swipe to top, swipe back down [13:09] tsdgeos, HUGE pause :( [13:09] tsdgeos, ah, you need some apps running [13:10] HUGE pause on the scrolling? [13:10] or? [13:10] tsdgeos, yeah [13:10] like 4 apps running, so that the category gets scrapped [13:10] well that's where the "delegate range" thing comes in, no? [13:10] something's *not* async [13:10] tsdgeos, right! [13:10] forgot [13:10] Saviq: it's not about asyncness [13:10] well it is [13:11] but not everything can be async :D [13:11] tsdgeos, yeah, let's see how your stuff helps [13:11] tsdgeos, at least you have a way to test now [13:11] tsdgeos, TBH I expect UShape to be breaking the asyncness [13:11] e.g. everything in there is using the ubuntu shape and once i calculated that it took a good chunk of ms just to run [13:11] yep [13:11] s/expect/suspect/ [13:12] i once killed the UShape and everything was so much more better === iahmad is now known as iahmad|afk [13:13] more better! [13:13] much more better! [13:13] that's like REALLY GOOD lD [13:14] Saviq: why are there so many package req for unity-notifications? qtdeclarative5-unity-notifications-plugin | unity-notifications-impl ? [13:14] tsdgeos, sorry, I just had a proper espresso on empty stomach... [13:14] dednick, soo [13:14] dednick, unity-notifications-impl == *an* implementation of unity-notifications interface [13:14] :D [13:14] mhr3_, so how can I see if it's disabled or not? [13:14] dednick, unity-notifications-impl-2 == *an* implementation of unity-notifications interface at version 2 of that interface [13:15] Cimi, metadata['scope-disabled'] for now [13:15] Saviq, no plans for annotated icon at this point, right? [13:15] mhr3_, sure plans [13:15] so yea.. metadata ^ [13:15] mhr3_, not for 13.10 [13:15] dednick, qtdeclarativet5-unity-notifications-plugin - *the default* implementation of unity-notifications interface [13:15] dednick, we need that last one 'cause we need at least one non-virtual dependency [13:16] Cimi, iirc it will be defined only for results that actually are disabled [13:16] dednick, so what this all means: unity8 depends on an implementation of unity-notifications interface at version 2, of which the default is qtdeclarative5-unity-notifications-plugin [13:16] dednick, sounds ~sane? [13:16] dednick, the idea is that we can swap out the implementation, provided it implements the same interface [13:17] I thought the whole point of virtual was that you didnt require the concrete. [13:17] Saviq: just ensure it's listed on the landing entry (both project) and mention we need both with what to test [13:17] dednick, you need it if you want that dep to actually be pulled [13:17] Saviq: then, we'll take care of that [13:17] Saviq: but it's taken care of in seed isnt it? [13:18] oh, right, for apt [13:18] dednick, not if you apt [13:18] dednick, yeah [13:20] didrocks, done [13:20] dednick, but that's the thing - if the seed provides a different implementation of said interface, apt won't get the default one [13:22] Saviq: thanks! [13:22] Saviq: yup. ok, well the version bumps are fine and I've tested the drop agent, so I'm approving all. Ok to do now? [13:23]