| === Ursinha is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
| StevenK | wgrant: https://code.launchpad.net/~stevenk/launchpad/fix-linkify-email-multiple-icons/+merge/189212 | 05:57 |
|---|---|---|
| StevenK | cjwatson: I fixed your multiple icon changelog bug: https://code.launchpad.net/~stevenk/launchpad/fix-linkify-email-multiple-icons/+merge/189212 | 08:25 |
| cjwatson | Ta | 08:27 |
| StevenK | cjwatson: Can haz review? | 08:29 |
| cjwatson | Oh, right, sorry, still waking up :) | 08:29 |
| StevenK | cjwatson: :-) | 08:30 |
| cjwatson | StevenK: The expected_html looks weird - why isn't the <<a href="...">foo@example.org</a>> business a bug? | 08:35 |
| cjwatson | There's probably a more efficient algorithm that collects all the distinct e-mail addresses first and then does a single bulk query for all the ones it doesn't have preloaded, but that isn't a problem introduced by your patch | 08:35 |
| cjwatson | (In fact I bet that contributes to +changelog slowness) | 08:36 |
| cjwatson | Oh, I think it's just confusing input data, will leave a comment | 08:37 |
| cjwatson | r=me | 08:37 |
| StevenK | cjwatson: The function already allows you to stuff in a preload | 08:38 |
| === matsubara-afk is now known as matsubara | ||
| === matsubara is now known as matsubara-lunch | ||
| === matsubara-lunch is now known as matsubara | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!