/srv/irclogs.ubuntu.com/2013/10/07/#ubuntu-unity.txt

Saviqthomi, dude, you spent most of the day on two issues that are known / fixed already...07:27
Saviqthomi, https://bugs.launchpad.net/ubuntu/+source/mir/+bug/123515907:29
ubot5Ubuntu bug 1235159 in mir (Ubuntu) "Mir fails to start if there's a stale socket" [Medium,Triaged]07:29
Saviqthomi, and http://bazaar.launchpad.net/~unity-team/unity8/trunk/revision/39707:29
tsdgeosSaviq: so any special bug you want me to look at or shall i continue with the delegate creation range thing?07:38
Saviqtsdgeos, can you have a look at https://bugs.launchpad.net/unity8/+bug/112456707:39
ubot5Ubuntu bug 1124567 in Unity 8 "[DASH] activity indicator not shown while search process is ongoing " [High,In progress]07:39
Saviqtsdgeos, we've had to revert that over the weekend, 'cause the activity indicator used CPU all the time07:39
Saviqtsdgeos, if you can reduce to a testcase and fila a bug against SDK07:40
Saviqtsdgeos, hi, btw!07:40
tsdgeoshallo07:40
tsdgeosso devdays is today or tomorrow?07:40
tsdgeoss/is/starts07:40
Saviqtsdgeos, today07:40
tsdgeosi see07:41
CimiSaviq, morning07:42
Saviqhey Cimi07:42
CimiSaviq, good weekend? london finally got some sun, it's a pity it's monday :)07:42
SaviqCimi, nothing much, but thanks07:43
SaviqCimi, pretty London-y here now (dark'n'grey)07:43
CimiSaviq, here too, we have fog :(07:43
tsdgeosSaviq: not sure about that bug, is the bug "ActivittyIndicator takes lots of CPU" or "ActivittyIndicator takes lots of CPU even when not spinning"?07:44
Saviqtsdgeos, the latter07:44
CimiSaviq, I wanted to see why style is causing the hangs, you have ideas?07:44
tsdgeosi see07:44
Cimitsdgeos, it's the style SDK property causing the hanfs07:44
Cimitsdgeos, hangs07:44
tsdgeos:/07:44
CimiI might need help to debug07:45
CimiI think we might need to use some qtcreator debug modes/profiler07:45
SaviqCimi, that's easy07:45
Cimiwhich I never used07:45
SaviqCimi, get it to hang07:45
CimiSaviq, that's easy :)07:45
SaviqCimi, ah, run it through run_on_device, get it to hang07:46
Saviqor well, pass -qmljdebuggingport or whatever the option is (see in run_on_device near the top)07:46
SaviqCimi, then, in QtCreator Analyze → QML Profiler (External) → set "Host" to your device's IP → let it run for 10s07:48
SaviqCimi, but I'm 90% certain you'll get zilch - no QML events will happen - it's probably hanging in the scenegraph07:48
SaviqCimi, to confirm that - make it hang, and run `gdb program $(pidof unity8)`07:49
SaviqCimi, that will connect gdb to the process and let you see what the threads are doing07:49
tsdgeosSaviq: no bug in the ActivityIndicator, just a bug in our side08:22
* tsdgeos proposes branch08:23
Saviqtsdgeos, yay08:23
Saviqtsdgeos, couldn't pinpoint it late on Friday, and couldn't be bothered over the weekend ;)08:23
tsdgeos:-)08:23
greybackGreetings from Qt DevDays08:23
tsdgeosgreyback: aloha08:24
greybacktsdgeos: yo yo08:24
Saviqgreyback, o/08:25
greybackSaviq: hey08:26
* Saviq f**ed up for not being there08:26
mhr3Saviq, reverted activity-indicator? :(08:26
Saviqmhr3, will be right back08:26
Saviqmhr3, caused constant CPU usage, but tsdgeos just found the issue08:27
mhr3wonder how much is it going to conflict isactive08:27
tsdgeosnone08:27
tsdgeosjust wait08:27
tsdgeosuntil i commit my stuff08:27
tsdgeosor base your stuff in mine08:27
Saviqmhr3, just going through previews now, will get to -isactive afterwards08:28
tsdgeosit's just one line08:28
tsdgeoswell actually two08:28
tsdgeosmhr3: Saviq: https://code.launchpad.net/~aacid/unity8/unrevert376/+merge/18954408:29
mhr3why do we hide that empty search can take a while as well?08:29
tsdgeosdo what?08:30
Saviqtsdgeos, ah, we didn't protect against scope === undefined?08:30
mhr3tsdgeos,08:30
mhr3+                            name: "searching"08:30
mhr368+                            when: scope && scope.searchInProgress && searchField.text !== ""08:30
tsdgeosSaviq: yep08:31
Saviqstoopid08:31
tsdgeosmhr3: http://bazaar.launchpad.net/~aacid/unity8/unrevert376/revision/401 is my change08:31
tsdgeosmhr3: the rest was there already08:31
tsdgeosdon't ask me why you do something you did :D08:31
mhr3yes, i should have reviewed the qml part too, but this gives me second chance :)08:32
tsdgeosor someone else, not sure if it was you who did the original code08:32
tsdgeosah, it was nic-doffay's08:33
mhr3Saviq, your thoughts about removing the .text condition from the states?08:33
Saviqmhr3, right08:34
Saviqmhr3, didn't think that's when it'd come up08:34
Saviqtsdgeos, can you? drop the !== "" / === ""08:34
tsdgeosif you want me08:36
Saviqtsdgeos, yes please08:36
tsdgeosit's not like i've checked the code08:36
Saviqmhr3, any reason why a preview.subtitle would have newlines?08:36
tsdgeosSaviq: mhr3: pushed08:39
Saviqtsdgeos, thanks08:39
mhr3Saviq, not really... scopes misusing it for something?08:57
Saviqmhr3, right, that's what I thought - so removed "support" for it08:57
mhr3k08:57
Saviqseb128, I'm offended :P Why isn't PL in the set of languages installed on the device?09:09
Saviqseb128, more, why installing the langpacks and generating locale doesn't work anymore for setting the language? is there a new trick to change locale?09:10
seb128Saviq, the list is my number of speakers, you need to teach more being to speak pl it seems ;-)09:11
Saviqseb128, I don't mean the list in settings app09:12
seb128Saviq, it doesn't work because the system image is ro and you can't install langpacks...09:12
Saviqseb128, most recent image has some langpacks09:12
Saviqseb128, and that's where pl isn't included09:12
seb128Saviq, right, we seeded the same as on the desktop image09:12
seb128Saviq, zh > es > pt > de > fr09:12
seb128Saviq, that's ranked by "usefulness"09:12
Saviqseb128, but even making it rw and installing the langpack / changing /etc/environment doesn't seem to work correctly09:12
Saviqseb128, yeah, I know, j/k09:12
seb128Saviq, how "not correctly"?09:13
Saviqseb128, or well, it changes *some* of the UI09:13
Saviqseb128, but not e.g. scopes09:13
seb128Saviq, the settings app use accountsservice which writes ~/.pam_environment09:13
seb128Saviq, what langpack did you install?09:13
Saviqseb128, ah, let me try that09:13
Saviqseb128, -gnome-pl09:13
seb128Saviq, lot of the scopes strings are new09:13
seb128Saviq, https://translations.launchpad.net/ubuntu/saucy/+source/unity-scope-home/+pots/unity-scope-home09:14
seb128Saviq, yeah, there is no polish translation, stop slacking :p09:14
SaviqOH!09:14
seb128Saviq, not sure if you are part of the pl translators team, if you are, just go to https://translations.launchpad.net/ubuntu/saucy/+source/unity-scope-home/+translations and do some work ;-)09:15
Saviqseb128, yeah, will have to09:16
* Saviq frowns at the pl translators team09:16
Saviqmhr3, we had somewhere a fix that stopped activating entries other than apps, remember where?09:18
mhr3Saviq, dont remember such thing, why would we want that?09:19
Saviqmhr3, because we want previews for everything other than apps?09:19
mhr3Saviq, oh, that kind of activating... it's part of the previews transitions09:20
Saviqmhr3, right, good09:20
mhr3lp:~mzanetti/unity8/switching-previews09:20
mhr3Saviq, ^ that one09:20
Saviqmhr3, yup, next in my q09:21
=== ritz is now known as ritz|away
mhr3Cimi, will your branch adding the new styles for dash plugins and weather come back?10:12
Cimimhr3, who knows10:12
mhr3Cimi, needs to be fixed in sdk first?10:12
Cimimhr3, I think10:12
mhr3anyone working on that?10:13
Cimimhr3, but it's early to confirm10:13
CimiI'm compiling on the phone10:13
Cimislow boot this morning10:13
=== hikiko is now known as hikiko|lunch
mhr3Saviq, think we have an issue with caching - if results are showing "image://thumbnailer/foo" and preview uses the same string for their main image, it'll end up using the low-res image from the result instead of requesting new one with different requestedSize from thumbnailer10:22
Saviqmhr3, hmm, interesting... shouldn't happen IIUC10:23
Saviqmhr3, it should cache per-requestedSize10:23
mhr3Saviq, sure about that?10:23
Saviqmhr3, yeah - it'd break SVGs, for example, otherwise10:23
mhr3would explain why svgs look horrible10:24
mhr3:)10:24
Saviqmhr3, well, yeah10:24
Saviqmhr3, can you confirm with a small test? loading the same svgs twice with different sourceSize10:24
Saviqmhr3, and see if the order in which you load them makes a difference?10:25
mhr3was hoping you'd know this10:25
mhr3tsdgeos, maybe you do ^?10:25
tsdgeosmhr3: same url == same image10:26
tsdgeosif you want different images10:26
tsdgeosadd the image to the url or something10:26
mhr3tsdgeos, so noone cares that svgs are broken with qt?10:26
dednickmhr3: you sure you havent got a copy of the image as a png somewhere? i was having an issue where I had icons as svg and png, but it was loading the png10:26
tsdgeosmhr3: nope :D10:27
mhr3dednick, i'm coming to this conclusion from the thumbnailer, it just explains svgs as well10:27
tsdgeosmhr3: it's not that noone cares obviously, it's that there's noone with the willingness to fix it10:28
tsdgeoswhich is kind of the same thing :D10:28
dednickmhr3: my old thumbnailer?10:28
dednickfrom unity?10:28
mhr3dednick, nah, we have a new one now10:29
Saviqtsdgeos, really? it caches regardless of requestedSize? that's broken ;(10:29
dednickthank god10:29
mhr3dednick, but actually i think the caching in unity7 has exactly the same issue10:29
Saviqtsdgeos, mhr3 granted, it's not *that* simple - it's probably the image provider that should be able to provide a hash under which the image is cached10:29
tsdgeosSaviq: hmmm what's requestedSize?10:30
tsdgeosthere's no such property10:30
Saviqtsdgeos, sourceSize10:30
Saviqtsdgeos, → that's requestedSize when requesting an image from an image provider10:30
tsdgeosSaviq: well, you should not be touching sourceSize afaics10:30
tsdgeos"This property holds the actual width and height of the loaded image."10:30
Saviqtsdgeos, HUHE!Q10:30
Saviqtsdgeos, you get a slap10:30
tsdgeoshmmmm10:31
tsdgeosotoh10:31
tsdgeos"Note: Changing this property dynamically causes the image source to be reloaded, potentially even from the network, if it is not in the disk cache."10:31
Saviqtsdgeos, read the whole thing - print out10:31
Saviqtsdgeos, and stick over your bed10:31
mhr3Saviq, yep, that would fix it cleanly, but i don't think it's possible atm10:31
tsdgeosSaviq: my bed is behind me, won't help much sticking it there10:32
Saviqmhr3, yeah - let's just pass ?width=x&height=y?10:32
tsdgeosSaviq: ok, so the first line definition of the property is crap-ish10:33
Saviqtsdgeos, true10:33
Saviqmhr3, so that category renderer and preview request different, but static URLs?10:33
tsdgeosand yeah sounds like a bug that it doesn't take into account the size10:33
mhr3Saviq, i'm afraid we don't have that where the uri is created10:33
tsdgeosare we sure it's not us doing that?10:33
Saviqtsdgeos, you told us so! :D10:33
Saviqmhr3, can you verify?10:34
tsdgeosSaviq: well, i'm not infallible by far... :D10:34
Saviqmhr3, a simple two-Image with onClicked: source = "blah"10:34
mhr3yep, but not right away :)10:34
Saviqmhr3, ok, let me have a try10:34
tsdgeoshmmm10:35
* tsdgeos retracts the hmmm10:36
tsdgeoswho provides thumbnailer:// libunity?10:36
mhr3tsdgeos, sdk10:37
mhr3trunk sdk anyway10:37
tsdgeoshmmm10:39
tsdgeosdoesn't look like that code is doing anything with the desiredSize?10:39
tsdgeoswell, it is, but just to decide what other size it'll give you10:39
mhr3the difference between preview image size and results should be big enough10:40
tsdgeoshmmm10:40
tsdgeosactually not10:40
tsdgeosi should learn how to read :D10:41
tsdgeosman what a morning...10:41
sil2100Reading is overrated10:41
CimiSaviq, ok, I've ref lashed, compiled, had a couple of teas to wake up10:47
tsdgeosmhr3: Saviq: ok, code shows that requestedSize is taken into account for the caching10:47
CimiSaviq, I have gdb opened10:47
tsdgeosmhr3: Saviq: so it "should" work10:47
CimiSaviq, I run bt and it gives me10:47
Cimi#0  0x40b3568a in ?? () from /lib/arm-linux-gnueabihf/libc.so.610:47
Cimi#1  0x40b37324 in malloc () from /lib/arm-linux-gnueabihf/libc.so.610:47
Cimi#2  0xdea19b8e in ?? ()10:47
Cimi#3  0xdea19b8e in ?? ()10:47
CimiBacktrace stopped: previous frame identical to this frame (corrupt stack?)10:47
Cimiwhich is not very useful10:47
Cimi(sorry for not using paste bin, my fault)10:47
tsdgeosmhr3: Saviq: http://pastebin.kde.org/pqmpq60ka10:48
mhr3Cimi, i was looking at it on friday too, it changes depending when you break10:48
mhr3Cimi, i was getting this malloc thing or something quite deep in qtqml.so10:49
tsdgeosmhr3: so if you can verify it doesn't work it's probably broken somwhere up in the stack?10:49
Cimihelp guys10:49
tsdgeosCimi: start by install debug symbols for libc10:50
mhr3tsdgeos, hm, you sure that code path is executed? :)10:50
Saviqmhr3, hmm, nope, can't confirm what you're saying10:50
tsdgeosmhr3: pretty much10:50
tsdgeosmhr3: it's just after the requestImage code10:50
tsdgeosand that one does get executed :D10:50
mhr3hm, in that case thumbnailer must be broken10:50
tsdgeosmhr3: where's the thumbnailer code?10:51
Saviqmhr3, http://paste.ubuntu.com/6204437/10:51
Saviqmhr3, regardless of the order of clicking10:51
Saviqmhr3, the large image is the same10:51
Cimiguys, I throw it10:53
Cimiwould be nice to have a flag for phablet-flash that automatically enables developer mode (and some packages already preinstalled)10:53
Cimiso we flash a second zip with writeable root, all our development crap already installed10:54
Cimilike phablet-flash ubuntu-system --developer-mode10:55
mhr3tsdgeos, lp:thumbnailer10:56
SaviqCimi, thing is... which packages would you install?10:57
mhr3Saviq, ok my bad for svgs, was looking at some results from foursquare, thought it's giving svgs but they're low-res pngs :/10:57
CimiSaviq, the common stuff to both ubuntu sdk and shell10:58
CimiSaviq, writeable image10:58
mhr3dednick_, 1:0 for you10:58
SaviqCimi, I get what you mean, I'm not totally convinced, though ;)10:58
SaviqCimi, feels like that would only be useful for us, really10:59
CimiSaviq, well, we *all* do the same thing every time we install10:59
CimiSaviq, we enable and reinstall the usual packages10:59
CimiSaviq, "us" is many engineers10:59
SaviqCimi, that is true, so a channel=unity8-development or something10:59
CimiSaviq, whatever yeah10:59
SaviqCimi, yeah, but it's very specific to what we do10:59
SaviqCimi, and then we'd end up having hundreds of channels11:00
SaviqCimi, thing is you don't need to flash all the time11:00
CimiSaviq, well, we are the most important one11:00
Saviqof course we are lol11:00
mhr3anyway, i'll go bother satoris about something broken in thumbnailer11:00
SaviqCimi, if you make it read-write, just dist-upgrade11:00
Saviqmhr3, give him that QML for testing11:00
mhr3Saviq, right, thx for that11:00
CimiSaviq, would be nice to flash and start working immediately instead of wasting time apt-getting the same things and rebooting11:01
Saviqmhr3, if it results in two requests to the thumbnailer - tb is broken - otherwise it's Qt11:01
SaviqCimi, just don't waste time flashing11:01
SaviqCimi, and apt-get update / upgrade11:01
SaviqCimi, it's the same result11:01
SaviqCimi, unless you really need a particular image11:02
CimiSaviq, I'm super lazy and I'm trying to simplify my life11:02
CimiSaviq, laziness can be a great virtue ;)11:02
SaviqCimi, what's simpler about flashing than update/dist-upgrade?11:02
CimiSaviq, sometimes it screws11:03
Cimianyway ok11:03
SaviqCimi, `adb shell "apt-get update; apt-get -y dist-upgrade"`11:03
mhr3Saviq, i think it'd be the other way around ;)11:03
tsdgeoscaches everywhere! :D11:03
tsdgeosso we cache at the Thumbnailer level and at the QML level11:03
mhr3Saviq, ...eh, yea, no... nvm :)11:04
Saviqtsdgeos, but tb is on-disk, QML is in mem11:05
Saviqtsdgeos, and well, we disable caching in-mem for previews IIRC11:05
Saviqtsdgeos, also, tb is reusable between apps -  QML cache isn't11:05
=== hikiko|lunch is now known as hikiko
tsdgeosmhr3: ok, on a second look at the thumbnailer:// code11:09
tsdgeosi did read it correctly the first time11:09
tsdgeosand just uses the requestedSize to switch between TN_SIZE_SMALL, TN_SIZE_LARGE and TN_SIZE_ORIGINAL11:10
mhr3tsdgeos, what's wrong about that?11:11
tsdgeosthat it won't give you the size you really want?11:11
mhr3right, but previews are surely bigger than 25611:11
dednick_mhr3: cookie please11:12
mhr3dednick_, lots of them at the office :)11:13
tsdgeosmhr3: what you mean with "are surely bigger than 256"? that you should be getting the "original size"?11:13
mhr3tsdgeos,11:13
mhr3right11:13
Cimihttp://paste.ubuntu.com/6204498/11:13
mhr3i was seeing pixelation on video that had original res 1280x80011:13
tsdgeosok11:14
Cimitsdgeos, Saviq ^11:14
tsdgeosCimi: is it stuck there?11:14
Cimitsdgeos, yes11:14
Saviqnot good11:15
mhr3it's not stuck though... it's spinning around it11:15
mhr3somehow11:15
=== MacSlow is now known as MacSlow|lunch
tsdgeosCimi: so if you say continue and break again it'll get the same backtrace?11:16
Cimitsdgeos, continue?11:18
Cimiin gdb?11:18
tsdgeosCimi: ye11:18
Cimilet me rehang the thing11:18
Cimihttp://paste.ubuntu.com/6204523/11:21
Cimisame hang11:21
Cimijust a different call11:21
Cimilet me do continue11:21
Cimitsdgeos, what is continue supposed to do?11:22
tsdgeosCimi: continue executing the program?11:22
SaviqCimi, c11:22
Cimitsdgeos, well it says continuing11:22
SaviqCimi, continue11:22
Cimibut doesn't move11:22
SaviqCimi, then ctrl+c11:22
CimiI'll debug gdb now :P11:22
SaviqCimi, then bt again11:22
Cimigdb program pidof gdb :D11:22
Cimisame stuff guys11:23
Saviqtsdgeos, Cimi, feels like SDK's theming gets stuck in creating the delegate?11:23
tsdgeosCimi: is it exactly the same backtrace?11:24
Cimithis is after http://paste.ubuntu.com/6204545/11:24
Cimitsdgeos, no11:24
Cimilil difference11:24
CimiKaleo, ^11:24
SaviqCimi, remember he's in Brazil? ;)11:24
SaviqCimi, anyway, he won't be able to do *anything* from that11:25
CimiSaviq, I do, but he was replying :P11:25
Cimiin #sdk :)11:25
tsdgeosfrom what i can see from the BT11:25
tsdgeosit's trying to create the item with index 111:25
tsdgeoswhich now i see is done async11:26
Saviqtsdgeos, re: showNow11:26
* tsdgeos hits himselfs and hides at the same time11:26
Saviqtsdgeos, it's now in Mir's plate11:26
Saviqtsdgeos, they need to flush the buffers after blanking / before unblanking for us to be able to push a new frame11:27
KaleoSaviq: tsdgeos: Cimi before you go any further; bug report11:27
tsdgeosSaviq: ok11:27
tsdgeosSaviq: so approve?11:28
Saviqtsdgeos, yes11:28
tsdgeosah, it's async because it's inside the viewport, "makes sense" (talking to myself)11:30
CimiKaleo, https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/123631611:40
ubot5Ubuntu bug 1236316 in Ubuntu UI Toolkit "Unity dash hangs when using style delegates on Tile.qml" [Undecided,New]11:40
mhr3Saviq, this is weird - http://imgur.com/UsglIHA12:03
mhr3Saviq, that's what i see on the phone, yet the image itself it full-res12:04
Saviqmhr3, looks like sourceSize is bad there?12:04
Saviqmhr3, same with switching-previews branch?12:05
mhr3Saviq, don't have that one on the phone12:05
Saviqmhr3, you can run on desktop and should see the same12:05
mhr3time to install mediascanner12:06
CimiSaviq, shall I redo all the renderers without using style?12:09
SaviqCimi, not yet - we should instead try & solve the issue12:09
Saviqtsdgeos, you stopped talking to yourself? got somewhere?12:10
CimiSaviq, I dunno where to start though with this one12:10
CimiSaviq, downloading qt source and reading those files?12:11
SaviqCimi, tsdgeos will (is) look(ing) at it12:11
SaviqCimi, as it might be something int the LVWPH12:11
Saviq/food12:12
mhr3Saviq, seems to work fine with switching-preivews12:12
Cimi/food12:13
mhr3Saviq, otoh all previews look washed out with switching-previews12:13
mhr3like some semi-transparent layer was on top of them12:13
=== MacSlow|lunch is now known as MacSlow
MirvSaviq: any idea why some unity8 tests have started failing on desktop while they continue to work on device? http://10.97.0.1:8080/job/autopilot-saucy-daily_release/2409/label=autopilot-intel/artifact/results/autopilot/autopilot.log12:14
MirvSaviq: because of various cu2d problems I'm not sure if it happened already with the release that's in, or if the mir startup fix is somehow causing it.12:16
MirvI only know the errors happened this morning, twice, while they didn't happen on Friday morning12:16
SaviqMirv, looking at those errors I'd say notify-osd is running12:17
SaviqMirv, and taking the notifications over12:17
SaviqMirv, yeah "Service name already taken."12:18
SaviqMirv, until now it was fine 'cause nothing triggered notify-osd to start12:18
MirvSaviq: ok. given that we focus on touch and manual testing there gives +1, I'd tend to ignore it but good to check.12:18
MirvSaviq: so apparently now something triggers it then. do you want a bug about that?12:18
SaviqMirv, not against unity8, no ;)12:19
MirvSaviq: yeah I just started thinking that it's not unity8's problem as such :)12:19
SaviqMirv, we probably shouldn't be running unity7 under unity8 tests12:19
SaviqMirv, but while we are - we need to make sure notify-osd is killed12:19
SaviqMirv, are other tests ran in that run?12:19
SaviqMirv, like gallery or something?12:20
SaviqMirv, if that's the case - move unity8 to the front12:20
SaviqMirv, we've had the same on upstream merger12:20
=== alan_g is now known as alan_g|lunch
SaviqMirv, gallery tests triggered notify-osd and ours were failing12:20
MirvSaviq: not directly in that, gallery-app is ran with different set of packages12:21
MirvSaviq: it should be only running unity8-autopilot in case of unity8 stack12:21
MirvSaviq: anyhow, marked down a note about the problem on desktop side and published unity8 with the mir-side AP fix12:26
=== _salem is now known as salem_
SaviqMirv, thanks!12:31
tsdgeosSaviq: my internal talking was just about why something was being created sync, that i understood why12:55
tsdgeosSaviq: having a look at why stuff is hanging now12:55
tsdgeosCimi: it did not happen on the desktop right?12:55
Cimitsdgeos, no12:55
tsdgeosthat's weird indeed12:55
Cimitsdgeos, try no?12:57
Cimitsdgeos, just expand applications and scrol12:57
=== jhodapp|afk is now known as jhodapp
tsdgeoswops13:18
tsdgeosi changed run_on_device by mistake and nobody realized :D13:18
tsdgeosSaviq: https://code.launchpad.net/~aacid/unity8/bring_back_id_rsa/+merge/18959713:22
Saviqtsdgeos, yeah I saw that13:23
tsdgeossorry13:23
Saviqtsdgeos, while you're at it13:23
Saviqtsdgeos, can you fix ssh to not rm, but to truncate /etc/init/ssh.override?13:23
Saviqtsdgeos, or actually... start ssh on both -s and non-(-s)13:23
Saviqtsdgeos, we probably don't want to make ssh start by default for people13:24
Saviqtsdgeos, but enable it when needed instead13:24
tsdgeosSaviq: got lost, want me to do anything with /etc/init/ssh.override or just add the start ssh call?13:25
Saviqtsdgeos, let's not do anything with the .override13:26
Saviqtsdgeos, but start ssh when needed - not only on --setup13:26
tsdgeosyep13:26
=== alan_g|lunch is now known as alan_g
kgunnMacSlow: so rcv call notif ended up being a unity-mir bug ?13:33
MacSlowkgunn, partly...13:33
MacSlowkgunn, the fix needed to make it work on mir (adding an InputFilterArea around the notifications ListView) showed a bug in mir13:35
mterryracarr, do you know why enabing Mir would prevent unity8 from receiving signals from a dbus daemon that isn't root?13:37
kgunnalan_g: ^13:37
alan_gkgunn, mterry: Mir itself doesn't touch dbus13:39
mterryalan_g, that's what I would think.  Yet here we are  :)  It's probably (I'm guessing) more some effect enabling unity-mir has?13:39
kgunnalan_g: we're actually talking on the unity standup..thinking is that unity-mir might have a role here13:42
mterry"thinking" == "wild guess"  :)13:43
kgunnmterry: true...but at least it actually touches dbus in some way :)13:43
mterryfai13:43
mterryfair13:43
alan_gmterry: I'd be guessing. I don't know most of what enabling unity-mir entails.13:43
=== pete-woods is now known as pete-woods-back-
tsdgeosSaviq: https://code.launchpad.net/~aacid/unity8/start_ssh/+merge/18960213:46
Saviqtsdgeos, s/service/initctl/13:54
Saviqtsdgeos, and maybe we should get SSH_STARTED from initctl status ssh instead?13:55
Saviqtsdgeos, and maybe even stop it on exit13:55
Saviqtsdgeos, if it wasn't started before us13:55
tsdgeosok, can do that13:55
tsdgeoswas aiming for a low smartness solution :D13:55
tsdgeosso13:56
tsdgeoscheck status on start, start if needed, stop if was not started?13:56
tsdgeosSaviq: ↑↑13:56
Saviqtsdgeos, yeah13:57
Saviqtsdgeos, and merge with your bring_back_id_rsa - let's not torment jenkins13:57
tsdgeos:D13:58
tsdgeosok13:58
pstolowski_nic-doffay: ping14:01
tsdgeosSaviq: that hang stuff is ugly14:04
tsdgeosno clue why it only happens on the phone though14:05
tsdgeosbut it's basically stuff "loading" a component and that component thinks it's loaded14:05
tsdgeosor something like that14:05
tsdgeosnot totally sure i get it14:05
tsdgeosbut it's basically while looping "doing nothing"14:05
Saviqtsdgeos, ouch14:06
tsdgeoscompiling qtdeclarative on the device with debug enabled so i can add a few more qdebugs here and there14:06
Saviqmterry, ah, I forgot - the stats welcome screen qml test is somewhat flaky14:07
Saviqmterry, hrm wait, ignore14:07
Saviqdandrader, I meant your minimizingAppTakesToRunningApps test ↑↑14:08
Saviqdandrader, when you have some free cycles, try and see if it can be improved14:08
dandraderSaviq, it could just be skipped for now if it's giving Jenkins some headaches14:09
mterryphew  :)14:09
kgunndednick_: know anything about location services/indicator  not working like in the lastest image  ?14:12
=== dandrader_ is now known as dandrader
dednick_kgunn: nope. by not working, you mean not showing up?14:27
kgunndednick_: yeah...that's the report...like no effect in the ui (i suspect backend...but its going to get some attention soon)14:28
nic-doffaypstolowski_, what's up14:29
dednick_kgunn: i'll take a look14:33
kgunndednick_: thank you14:34
=== amithkk_ is now known as amithkk
=== amithkk is now known as Guest99228
kgunndandrader: i confirmed, the primary bug to fix is the focus on top (not necessarily the hot-key vol for apps in background)14:39
kgunnSaviq: ^ fyi14:40
dandraderkgunn, ok. it's likely gonna take a while for me. focus in mir involves some 13241 classes and interfaces14:40
kgunnSaviq: should we ask tvoss_ to help dandrader here on the input bug 1233245 ? vs the slowdown ?...i know you asked him to help on slow down14:43
ubot5bug 1233245 in unity-mir "[mir] key events not working through input devices (aka volume up/down)" [Critical,In progress] https://launchpad.net/bugs/123324514:43
dandraderkgunn, or I could simply pass the bug to racarr, the author of most of these classes14:44
kgunndandrader: ack14:44
dandraderkgunn, so, do I continue through this maze or pass it to racarr ?14:45
kgunndandrader: continuing would be good in order to prep racarr  when he comes on14:45
=== dandrader is now known as dandrader|afk
=== dandrader|afk is now known as dandrader
tsdgeosSaviq: Cimi: good/bad news15:13
tsdgeosit also happens on the desktop15:13
tsdgeosjust less often15:13
tsdgeosbut if you go to apps (i have "more suggestions" and then "dash plugins") expand dash plugins15:14
tsdgeosand keep scrolling up/down15:14
tsdgeosit'll eventually lock15:14
Cimitsdgeos, good15:14
tsdgeosi guess :D15:15
Saviqtsdgeos, you're getting somewhere, it's good, I'd say ;)15:21
tsdgeosMirv: ping15:36
tsdgeosSaviq: or you, do you know if we still have that ppa qith qt 5.1 and unity compiled for it?15:36
Saviqtsdgeos, should be https://launchpad.net/~canonical-qt5-edgers/+archive/qt5-beta-proper15:37
tsdgeoslet's try that otp while i debug this15:37
om26erSaviq, is there a way to force apps running inside unity8 to run in -testability ?16:00
Saviqom26er, initctl set-env QT_LOAD_TESTABILITY=1 should work16:01
Saviqom26er, since we're running them through upstart now16:01
Saviqom26er, although that might not be the case for sufraceflinger, only for unity-mir16:02
om26erSaviq, right, I am going to give that a try. last time I ran tests under Mir apps were not coming to the font16:02
mhr3for sf you can just "stop unity8" and run it with that env16:03
mhr3should get propagated then16:03
Saviqom26er, right ↑16:05
Saviqom26er, for sf just stop unity8, set the env, start unity8 - the env var will be there for sf apps too16:06
SaviqMacSlow, you here for some time still?16:06
om26erSaviq, sure, I'll try to do something in the upstart override so that I just stop unity8;change the upstart override;start unity816:07
Saviqotherwise dandrader, could you look at https://code.launchpad.net/~saviq/unity-mir/fix-inputarea/+merge/189647 and https://bugs.launchpad.net/unity8/+bug/123521516:07
ubot5Ubuntu bug 1235215 in unity8 (Ubuntu) "[Mir]cannot answer call when system settings are in the foreground" [Critical,In progress]16:07
Saviqdandrader, I meant https://code.launchpad.net/~saviq/unity8/add-notifications-inputarea/+merge/18937016:08
Saviqdandrader, two bugs: bug #1233411 bug #1235215 bug #1233411 should be fixed16:09
ubot5bug 1233411 in Unity 8 "Clicking on a snap decision action button is causing the click to hit the application underneath the notification area" [Critical,In progress] https://launchpad.net/bugs/123341116:09
ubot5bug 1235215 in unity8 (Ubuntu) "[Mir]cannot answer call when system settings are in the foreground" [Critical,In progress] https://launchpad.net/bugs/123521516:09
Saviqthat's three ;)16:09
dandraderSaviq, do you want me just to review the change or to test that this really fixes all those bugs?16:10
Saviqdandrader, isn't that the same thing? :D16:10
Saviqdandrader, that is, unless you're EOD'ing soon and/or have other things on your plate16:11
Saviqmterry, maybe you have some time still in your day and could tackle ↑↑↑↑?16:11
MacSlowSaviq, what's up?16:12
SaviqMacSlow, same ↑↑↑16:12
dandraderSaviq, no, I can stop trying to understand all the mir code related to focus (regarding the volume keys bug) and start reviewing your stuff, np16:12
Saviqdandrader, not passed on to racarr yet?16:12
tsdgeosmeh16:12
Saviqtsdgeos, found it?16:12
tsdgeosultra fail trying to run the shell with 5.116:13
tsdgeosnope16:13
Saviq;(16:13
tsdgeoscan't start the phone with 5.1 :-/16:13
SaviqMacSlow, you're EOD already, so let's let someone from a western-er tz handle it16:13
mterrySaviq, I can look at those instead of the infographic thing for a bit, sure16:13
tsdgeosi have a sligth idea of what may be the cause16:14
Saviqmterry, dandrader, fight!16:14
MacSlowSaviq, ok... but doesn't all this lead to the need to fix InputFilterArea?!16:14
tsdgeoswill check tomorrow morning16:14
* tsdgeos waves16:14
SaviqMacSlow, I fixed it16:14
MacSlowSaviq, that's pure mir-related...16:14
MacSlowSaviq, ah... cool!16:14
SaviqMacSlow, nah, lp:unity-mir16:14
MacSlowSaviq, so it's solved then16:14
SaviqMacSlow, good news: fixed unity-mir; bad news: seems keyboard is broken for shell under mir, so wifi input is b0rked, flashing now to see16:14
SaviqMacSlow, yes16:14
dandraderSaviq, he's no online yet. kgunn asked me to keep looking at it to give racarr some input on the issue, once he comes online. But that's kinda hopeless considering the time I need just to make sense of all those mir  interfaces16:15
MacSlowSaviq, I can be back in ~2 hours if more hands an needed still16:15
mterrydandrader, I'll test the snap decision click-through thing?16:15
MacSlowSaviq, I'm done with the low-impact ui-tweaks for notifications.16:15
mterrySaviq, you said you had three bugs in your message to dandrader earlier, but two of the numbers were the same16:16
MacSlowSaviq, I'll be back in two hours an will see what you assigned to me :) deal?16:16
dandradermterry, no, I'll do it16:16
mterrydandrader, OK, let me know if you want any testing help.  I can go back to my infographic problem  :)16:17
Saviqtrying again16:17
Saviqbug #1233411 bug #1235215 bug #123538316:17
ubot5bug 1233411 in Unity 8 "Clicking on a snap decision action button is causing the click to hit the application underneath the notification area" [Critical,In progress] https://launchpad.net/bugs/123341116:17
ubot5bug 1235215 in unity8 (Ubuntu) "[Mir]cannot answer call when system settings are in the foreground" [Critical,In progress] https://launchpad.net/bugs/123521516:17
ubot5bug 1235383 in unity-mir "InputFilterArea not always calculating geometry with respect to scene" [Critical,In progress] https://launchpad.net/bugs/123538316:17
Saviq\o/16:17
Saviqall are related to the two branches16:18
kgunndandrader: go ahead and help Saviq on the borked osk16:19
MacSlowI'll be back in ~2 hours16:20
kgunndandrader: just catch up with racarr when he comes on16:20
=== MacSlow is now known as MacSlow|afk
Saviqkgunn, borked osk is not yet confirmed16:20
Saviqkgunn, dandrader gtg, be back in ~1.5h to continue16:21
mhr3Saviq, scope-isactive wanted me to rename it to scope-needslove :)16:22
kdubwho knows how the screen blanking and unblanking works in surfaceflinger on the nexus 4?16:22
kdubi'm trying to rule out that powerd (or something else) and mir are both trying to assert control over the display16:23
=== dandrader is now known as dandrader|afk
=== dandrader|afk is now known as dandrader|lunch
kgunnricmm: rsalveti ^ maybe you guys know something about N4 screen blanking in the surfflinger case ?16:26
kgunnkdub: are you still able to repro ? (...i cannot)16:26
rsalvetikdub: powerd has a different path for mir/sf when blanking/unblanking16:26
rsalvetilet me check the code16:26
rsalvetikdub: in powerd/src/display.c, check for sf_blank16:27
rsalvetiit checks for /home/phablet/.display-mir, if available then it uses dbus instead16:28
kdubrsalveti, thanks16:28
rsalvetiotherwise it uses the hybris sf_blank/unblank function calls16:28
ricmmkdub: only unity-mir controls the blanking interface16:30
ricmmthe issue here is more about the GPU being in a low power state16:31
ricmmso an unblank() call fails16:31
ricmmpowerd has to exit suspend for it to work16:31
kdubricmm, so when powerd has exited suspend, the unblank call works?16:34
=== pete-woods-back- is now known as pete-woods
kdubi don't know that the gpu is involved though, hwc's blank call on the nexus 4 looks like it just calls fb ioctls16:35
dednick_Cimi: fixed typo16:36
ricmmkdub: yes16:37
ricmmkdub: press the power button16:37
ricmmyou'll see that unity8 comes up16:37
kdubright16:38
=== tvoss_ is now known as tvoss|quick_dinn
Cimiweird bug16:56
Cimilock screen half on screen16:57
Cimion top of everything16:57
Cimimterry,16:57
Cimiwell I can debug...16:57
kdubricmm, okay, so i see that its some interplay between powerd and mir (just using powerd and my basic fb testing program)16:58
* kdub reads powerd code16:59
mterryCimi, hello17:00
mterryCimi, half on screen?17:00
=== alan_g is now known as alan_g|EOD
Cimimterry, I did slide to unlock17:01
Cimimterry, but it's on screen17:01
Cimimterry, lock screen moved of like 3gu17:01
Cimimterry, i can see the app on background17:01
mterryCimi, odd...17:02
Cimiwell now it locked again17:02
Cimimterry, but yeah, there is an edge case when it gets stuck17:02
Cimimterry, not sure it's a flaw somewhere17:03
Cimiin the states logic17:03
ricmmkdub: it is, but its basically the suspend request17:05
ricmmusb cable holds a wakelock that will keep the system up17:05
ricmmbut its still suspending some things17:05
kdubricmm, and it does this through sysfs?17:09
Cimimterry, I see we have a wifi panel in settings app17:11
Cimimterry, time to integrate the last bit?17:11
ricmmkdub: not entirely sure of what it calls to suspend17:12
mterryCimi, not for 13.1017:12
=== dandrader|lunch is now known as dandrader
Cimimhr3, you in the office tomo?17:29
mhr3Cimi, yep17:29
Cimimhr3, so tomo we do the renderers17:32
kdubrsalveti, mfisch would either of you be the person to ask about how powerd on mako works?17:52
Saviqmhr3, it's next on my list tomorrow morning17:56
=== MacSlow|afk is now known as MacSlow
MacSlowSaviq, so what of the IFA-related bugs still need helping/testing hands?18:05
Saviqdandrader,  ↑?18:05
dandraderSaviq, compiling unity8 on my define at the moment18:05
Saviqdandrader, MacSlow, I can built unity-mir and unity8 packages for testing if you need it18:05
Saviqdandrader, k18:05
SaviqMacSlow, if you also want to test, I can have a set of packages in maybe 30 mins18:06
dandraderSaviq, there's also a need to build unity-mir for your bug fix?18:06
Saviqdandrader, yes, on Mir18:06
Saviqdandrader, the two linked branches work in concert18:06
MacSlowhm... I can build unity8 myself... only unity-mir I don't know anything about... not sure how much work it is to get into it... so packages for that would be good to have18:07
dandraderSaviq, ah, found it now18:07
SaviqMacSlow, coming right up18:09
Saviqdandrader, ugh, I think I didn't push to unity8....18:11
dandraderSaviq, so there's something missing in https://code.launchpad.net/~saviq/unity8/add-notifications-inputarea/+merge/189370 still?18:11
Saviqdandrader, on the contrary18:12
Saviqdandrader, there's one unnecessary commit18:12
Saviqdandrader, just pushed18:12
=== tvoss|quick_dinn is now known as tvoss_
dandraderSaviq, ah, I see18:12
Saviqdandrader, sorry about that18:12
dandraderSaviq, so your unity-mir fix made that unity8 commit unnecessary18:12
Saviqdandrader, yes exactly18:12
Saviqdandrader, and it's now the correct solution in that branch - just 4 lines diff now18:13
Saviqwell, ok, 618:13
MacSlowSaviq, dandrader: IFA is now (with the unity-mir fix) only needed/required in Notifications.qml itself?!18:13
SaviqMacSlow, only in Shell.qml18:13
dandraderMacSlow, "IFA"?18:14
Saviqdandrader, InputFilterArea18:14
MacSlowdandrader,  :)18:14
SaviqMacSlow, there's only one IFA that covers all of the notifications at once18:14
dandraderacronyms...18:14
MacSlowSaviq, I know... but I remember from Friday it was the other way around... anyways.18:14
MacSlowdandrader, *sigh* yeah :)18:14
SaviqMacSlow, yeah, but that was because of the unity-mir problem18:14
Saviqdandrader, if you're anal, s/blockInput/enabled/ would probably be called for ;)18:15
Saviqdandrader, let me know if you are ;D18:15
Saviqdandrader, or maybe not, it's compatible with both SurfaceFlinger and Mir this way18:16
Saviqwith enabled: it might not work correctly with SF18:16
dandraderSaviq, yes, that InputFilter API doesn't really make sense in Mir world. It has been kept just for API compatibility with SF18:23
Saviqdandrader, yeah18:23
MacSlowSaviq, looks like building your unity-mir branch on the device is not much of an issue... so I don't think I'll need the packages...18:31
SaviqMacSlow, sure it isn't18:31
MacSlowSaviq, just pulling in the build-dependencies...18:31
SaviqMacSlow, yeah, mk-build-dep; bzr bd is everything you need18:31
MacSlowSaviq, so I've your unity8 branch and your unity-mir one...18:32
MacSlowSaviq, so unity-mir is actually two shared-library objects...18:33
MacSlowwhich need to go where exactly?18:33
SaviqMacSlow, well, to be correct you should merge them on top of trunks - and that's when unity-mir needs upstart trunk18:33
SaviqMacSlow, into packages ;)18:33
SaviqMacSlow, or well, sudo make install18:33
SaviqMacSlow, but packages are good18:33
MacSlowSaviq, ok... I'll wait for those then :)18:34
SaviqMacSlow, bzr bd18:34
SaviqMacSlow, but yeah, if you want - I'll have the packages ready soon18:34
Saviq10-15 mins hopefully18:34
MacSlowok18:34
Saviqit still takes quite long to build, even with ccache18:35
* Saviq cries for cross builds...18:35
dandraderSaviq, at Nokia we used scratchbox, which is a qemu chroot + native cross-compiler. Worked well.18:44
kgunnSaviq: so, https://code.launchpad.net/~saviq/unity-mir/fix-inputarea actually fixes the "answer phone call"18:48
kgunnSaviq: making sure i'm not missing something the mir guys need to be focusing on helping with18:49
MacSlowSaviq, unity-mir/fix-inputarea is installed on the device... now just building unity8/add-notification-inputarea19:06
dandraderMacSlow, is there a way to force the appearance of a notification?19:23
MacSlowdandrader, yes...19:23
dandraderMacSlow, or to fake an incoming phone call19:24
dandraderwanna test that bug fix from Saviq19:24
MacSlowdandrader, use the examples from lp:unity-notifications (exampels directory) to trigger any type you like19:24
MacSlowdandrader, there's sd-example-incoming-call.py to do just that19:24
dandraderMacSlow, great. thanks19:25
MacSlowdandrader, you testing on a Nexus4 or GalaxyNexus?19:26
dandraderMacSlow,  galaxy19:27
dandraderMacSlow,  "ImportError: No module named pynotify" <- doesn't that come from python-notify2? Just installed it but the errror continues19:29
Saviqdandrader, python-notify19:30
Saviqdandrader, not 219:30
MacSlowdandrader, yeah ^19:30
Saviqdandrader, for the user-auth / wifi you'll need python-gi, too19:30
MacSlowdandrader, Saviq: I actually should unify this at some point19:31
MacSlowdandrader, Saviq: ... and also update the C-versions of the examples19:31
SaviqMacSlow, indeed - I think the tester from autopilot tests is probably a good start for that19:31
MacSlowhm... I'm not sure I'm really using mir on the device... despite having ~/.display-mir and having rebooted the device...19:32
Saviqdandrader, re: unity-mir19:32
Saviqdandrader, setSurface changes the surface, setEnabled does not19:33
Saviqdandrader, for changing surface, we need to uninstall it from the old one, install on the new one19:33
Saviqdandrader, when enabling, it remains on the same surface - no need to reinstall19:33
elopiohello!19:33
kgunnMacSlow: did you ps faux | grep surface ?19:33
elopiounity is not starting here, and I'm getting: Settings schema 'org.compiz.unityshell' does not contain a key named 'alt-tab-right'19:33
elopioany clue?19:33
MacSlowkgunn, now I did... no SF19:34
kgunnMacSlow: :) phew19:34
MacSlowkgunn, hm... nice then... seems there was some speed-improvement then19:34
SaviqMacSlow, yeah, it does feel more fluid, doesn't it19:35
MacSlowSaviq, although the scrolling of the elements in the weather-app is still a bit jerky19:36
SaviqMacSlow, probably not async19:36
Saviqfor loading images19:36
SaviqMacSlow, UShape has an effect like that, too, we suspect19:36
MacSlowI see19:37
dandraderSaviq, ah, ok. because it takes a pointer to the InputArea class, not the geometry directly19:39
Saviqdandrader, yeah, well, we probably shouldn't install it at all (as it's installed already)19:39
Saviqdandrader, but maybe that's the only way to get it updated?19:40
Saviqdandrader, I wouldn't like to touch it if we're not positive it's needed :)19:40
dandraderSaviq, it's q QSet so it won't store two identical items19:40
Saviqdandrader, yeah, so we shouldn't even need to install it again19:40
MacSlowSaviq, dandrader, kgunn: ok... seems to work.19:40
Saviq\o/19:40
dandraderSaviq, unless it was never installed before. e.g.: the first time you enable the thing19:41
SaviqMacSlow, did you get keyboard working on Mir, too? in the wifi case?19:41
MacSlowI can no longer reproduce the bugs described here https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/123521519:41
ubot5Ubuntu bug 1235215 in unity8 (Ubuntu) "[Mir]cannot answer call when system settings are in the foreground" [Critical,In progress]19:41
Saviqdandrader, true19:41
SaviqMacSlow, i.e. can you connect to a new WiFi when focused on an app?19:41
MacSlowSaviq, bug-#?19:41
SaviqMacSlow, no bug there, I didn't yet confirm it's an issue19:42
MacSlowah ok... one second...19:42
SaviqMacSlow, just trigger one of the extended snaps with wifi / user auth19:42
SaviqMacSlow, and see if keyboard behaves correctly19:42
kgunnMacSlow: dandrader Saviq ...this is good news on the phone call at least19:42
Saviqkgunn, yeah, that usecase will work19:42
Saviqkgunn, only possible problem is osk now19:42
kgunnSaviq: ok, still worth it to update the landing sheet for unity8 & unity-mir i would think...19:43
Saviqkgunn, yup19:45
kgunnSaviq: i put you on a invite just now...made  you optional...but since your up & on...would be grateful if you joined (no pressure if ur about to drop)19:45
Saviqkgunn, yeah, not in a state to join a HO now, running around the house here19:46
kgunnno worries19:46
MacSlowSaviq, kgunn, dandrader: the osk doesn't work (get any input) yet19:48
MacSlowSaviq, kgunn, dandrader: the osk comes up as I tap a text-field of an extended snap-decision, but entering text doesn't work19:49
SaviqMacSlow, yeah, input goes to the app in the back?19:50
kgunnMacSlow: help me...is that "new" with this fix for answering the incoming call19:50
Saviqkgunn, no, it's the same for search in dash19:50
kgunnack19:50
Saviqkgunn, osk got broken somehow19:50
MacSlowkgunn, I don't know... I didn't test that before19:50
Saviqkgunn, will try and pinpoint the image where this happens19:50
Saviqs/happens/happened/19:50
SaviqMacSlow, try in dialer, for example - you'll probably get numbers typed into the dialer instead of text into the shell19:51
MacSlowSaviq, correct... taps on the osk "fall through"19:51
SaviqMacSlow, yup, /me tries on a fresh #8419:52
Saviq:/19:53
Saviqseems to work there19:53
MacSlowdamn19:53
Saviqso the InputArea thing must've did something19:54
Saviqbut then19:54
Saviqmaybe it got fixed in the mean time19:54
* Saviq will install the new packages to see19:54
dandraderyeah, I cannot type on the OSK.19:54
dandraderseems like touches go through to the surface below the OSK19:55
Saviqdandrader, but you saw that before you tried the input fixes, right?19:56
Saviqdandrader, that's what you reported during standup today?19:56
MacSlowSaviq, does the osk also use an InputFilterArea?19:56
SaviqMacSlow, it shouldn't be able to19:56
SaviqMacSlow, but then it's a special surface / client, so maybe19:56
dandraderSaviq, it's been quite a while since I last played with unity8+OSK so I really cannot tell at the moment19:56
Saviqdandrader, you said something on the standup today19:56
Saviqdandrader, that you couldn't type into search in dash19:57
MacSlowSaviq, just being naive here and guessing it might need a similar fix like the notifications did19:57
SaviqMacSlow, well, it's a regression here - it was working before for sure19:57
SaviqMacSlow, so I'll be checking if we caused it19:57
MacSlowSaviq, ok... if you know that for certain... then it sounds like a regression19:57
dandraderSaviq, yeah. last time I tried I couldn't event make it show up. unlike now19:59
Saviqdandrader, k19:59
* Saviq digs19:59
SaviqMacSlow, you're off the hook, thanks for testing o/20:00
MacSlowSaviq, ok... I'll join the "fun" tomorrow again... good luck!20:01
kgunnMacSlow: thanks for staying and "playing"20:01
dandraderSaviq, I'm also looking at OSK-related code now in unity-mir to understand how things work there (and therefore what could have went wrong)20:03
dandrader"FYI"20:03
Saviqdandrader, thanks20:03
Saviqdandrader, I'll know in a few whether we actually broke it or not20:03
kgunnSaviq: you said "new unity-mir" causes the issue...but kind of implied...not the fix from https://code.launchpad.net/~saviq/unity-mir/fix-inputarea/+merge/18964720:18
Saviqdandrader, yeah, unity-mir trunk + my patch is introducing that, looking whether my patch has to do with it20:18
Saviqkgunn, both, for now20:18
kgunnack20:18
Saviqkgunn, will now be rolling back a commit at a time20:18
kgunnSaviq: fun :-/20:18
kgunnthank goodness there shouldn't be many20:19
SaviqI wonder who let greyback go to an event three days before the deadline ;D20:19
Saviqkgunn, yeah, a handful20:19
racarras for the shell receiving focus. I think I have a solid strategy, so we are looking at 30 minutes to get everything up to date and unity-mir build env20:19
racarr1 hour to fix it, 1 hour of churn and nonsense :p20:19
Saviqkgunn, a handfull == 1...20:20
Saviqgranted, one that has focus stuff20:20
kgunn:) i know i just looked...lol20:20
Saviqkgunn, "add workaround for handling of non-application sessions (like QtWebProcess and maliit)."20:24
Saviqkgunn, sthg smells funny20:24
kgunni saw that too....20:24
kgunncomplete with FIME20:24
kgunnor FIXME even20:24
Saviqkgunn, if I confirm that's the issue, what's the strategy? revert in unity-mir?20:29
kgunnSaviq: looking at bug...i think so20:30
kgunnSaviq: so risk is...you'll end up with loads of music app instances....which sucks20:30
kgunnbut not as bad as not being able to answer the phone20:30
Saviqkgunn, or connect to wifi20:30
Saviqmoment of truth20:31
Saviqkgunn, trunk good20:32
* Saviq builds with fix again20:33
Saviqkgunn, yeah, fix → broken keyboard20:34
Saviqcrap20:34
* Saviq drags maliit down20:34
Saviqracarr, confirmed, the fix in unity-mir causes the issue with maliit20:35
Saviqah, /me sees something20:36
racarrI am looking at the diff20:36
Saviqracarr, InputArea::setMirInputArea (this=0x518234e0, x=0.000000, y=740.000000, width=768.000000, height=540.000000)20:38
Saviqracarr, that should never happen, since x, y are in local coordinates20:38
Saviqracarr, must've been a workaround for the mapping issue20:39
Saviqracarr, must be something special in unity-mir20:39
Saviqracarr, yeah, OSKController.qml20:40
* Saviq will find what's up20:42
Saviqah20:43
Saviqnasty greyback20:43
Saviqracarr, kgunn, I can see the issue, not sure of a solution yet, though20:48
kgunnprogress....thanks for staying at it20:48
Saviqracarr, do you know if OSK's surface is fullscreen?20:48
kgunndandrader: ^ might know20:49
racarrSaviq: I dont think so but wouldnt be impossib;le20:49
dandraderSaviq, kgunn  In MeeGo it was fullscreen. don't know it if has changed20:51
racarrmaybe it is then20:51
racarrI just thought it wasn't because I hadnt heart about making it full screen20:51
SaviqQRect(0,1480 768x540) QRect(0,740 768x540)20:52
Saviqthe first one is the InputArea's rect *with* fix (incorrect)20:53
Saviqthe latter is *without* fix20:53
Saviqthe latter one is off-screen - and what Gerry was reffering to in his FIXME20:53
Saviqthat the rectangle is incorrect somehow20:54
Saviqbut I think I see what the issue is20:55
SaviqgeometryChanged is in *parent's* coords20:56
Saviqwhereas mapToScene is in *item's* coords20:56
Saviqracarr, kgunn ↑↑20:58
Saviqso we need to mapToScene from the parent, and all should be golden20:58
kgunnsweet...20:58
kgunndandrader: can you hang around for one more mp retest ?20:59
dandraderkgunn, yep, which one?20:59
Saviqdandrader, same unity-mir fix, but a proper one21:00
Saviqkeyboard: GOOD21:00
dandraderSaviq, did you push it?21:01
Saviqdandrader, testing21:01
kgunndandrader: he's gonna say...phone call all good...and then push21:03
Saviq:S21:03
kgunnor not21:03
* Saviq no get it21:03
* kgunn wonders if Saviq noticed greyback got on21:07
racarrJUMP HIM21:07
* greyback hides21:07
racarrIVE GOT AN ARM21:07
racarrHELP ME PIN HIM DOWN21:07
* Saviq just thinks there's a reason for the FIXME21:07
racarrGood evening Gerry :p21:08
Saviqhe's probably drunk anyway21:08
racarrarent we all it's 2 pm21:08
racarrerr21:08
racarr:p21:09
kgunndrunk on life racarr21:09
racarrthe sweet nectar of insanity.21:10
racarr* taps foot waiting on phone to install build deps*21:10
greyback<Saviq> he's probably drunk anyway21:10
greybackI don't know whether that hurts more than amuses me21:10
Saviqsee, he can't type21:10
Saviqgreyback, why would it hurt?21:10
greybackYou of all people throwing stereotypes around!21:11
SaviqAAARGH21:11
Saviqstupid /me21:11
greybackyou ahould be ashamed! :D21:11
Saviqif I'd have updated unity8 to the fixed version, that'd probably make more sense21:11
Saviqgreyback, how is it a stereotype?21:11
Saviqgreyback, about Gerrys?21:11
Saviqgreyback, I just know you - and good for you, having fun getting drunk there with mzanetti21:12
greybackSaviq: nah he's off on the formal Qt dinner. Instead zsombi and Christian and I had a few drinks at the Oktoberfest21:13
Saviqgreyback, good for you anyway21:13
greybackSaviq: wish you were here :X21:14
SaviqYES21:14
Saviqlol21:14
Saviqdandrader, pushing21:14
Saviqkgunn, racarr, dandrader, got it21:15
Saviqtoo many realms21:15
dandraderSaviq, got it. try it out now21:15
Saviqgreyback, remember that FIXME https://code.launchpad.net/~saviq/unity-mir/fix-inputarea/+merge/18964721:15
dandraders/try/trying21:15
Saviqdandrader, I did already ;)21:15
Saviqgreyback, I expect you found that the mapping gives you wrong output exactly how I made it wrong21:16
Saviqgreyback, there's three coords in play there - scene's, item's and *parent's*21:16
dandraderok, than EOD21:17
greybackSaviq: not forgotten, but it's been a busy day, I had no time ti sit to do anything21:17
Saviqgreyback, no no21:17
Saviqgreyback, geometryChanged is in *parent's* coords, but mapToScene takes item's coords, so we need to mapToScene on the parent, not on the item21:17
greybackSaviq: sounds logical21:18
Saviqgreyback, yeah, but the default thing you do is this->mapToScene() (or at least I do)21:19
greybackSaviq: yep, was my plan21:19
Saviqand it was working for some (where your item was at parent's 0,0)21:19
Saviqbut not for others21:19
Saviqso yeah, should be good now, and worky21:19
Saviqgreyback, you're dismissed21:20
greybackSaviq: aye aye captain21:20
* Saviq is a sucker for not being there21:20
kgunnyou had your chance :)21:21
kgunn...and we'd be totally screwed right now21:21
kgunnso...does this end up being a search and replace on 'this->' to parent->21:23
Saviqkgunn, no searching21:23
Saviqkgunn, just one place21:23
Saviqkgunn, where I was dumb enough to not think about it properly21:23
thomiShould unity8 be consuming 20% of CPU and 35% of memory on the mako all the time?21:25
thomiI'm guessing not...21:25
Saviqthomi, what version?21:27
Saviqthomi, there was a fixed release over the weekend21:27
Saviqthomi, for CPU at leat21:28
Saviqleast21:28
Saviqthomi, actually, it wasn't released yet21:29
Saviqscratch that21:29
Saviqthomi, 7.82+13.10.20131005-0ubuntu1 should not be hogging your CPU21:30
Saviqor higher, of course21:30
* thomi checks21:30
thomiI have 7.82+13.10.20131007-0ubuntu121:31
thomiSaviq: it's more memory than CPU21:31
Saviqthomi, leaky leaky - Mir or surfaceflinger?21:31
thomimir21:31
Saviqthomi, could be https://bugs.launchpad.net/ubuntu/+source/mir/+bug/123519021:32
ubot5Ubuntu bug 1235190 in mir (Ubuntu Saucy) "[mako] Unity8 on Mir got slow" [High,Confirmed]21:32
Saviqalthough there's a bunch of different issues like that21:32
Saviqthat we need to flesh out21:32
thomiSaviq: will add my info to that bug, thanks21:33
kgunnthomi: i think there's an upstart bug wrt leaking that is worse on mir seemingly...but also shows up on sf21:34
kgunnboth eventually leak to death21:34
Saviqyeah, that too21:35
Saviqoups, I didn't think Daniel would EOD after /me tested :D21:39
Saviqkgunn, care to test http://people.canonical.com/~msawicz/inputarea/ ?21:39
Saviqkgunn, actually let me limit the amount of packages there21:39
Saviqa feck it, it's working after all21:40
Saviqah and Gerry happroved21:41
kgunneven better21:43
kgunni'll update the ask sheet21:43
kgunnoh...even too late for that21:44
Saviqkgunn, still, if you take the packages from the above url, install them and make sure the two usecases (receive / decline call and wifi password) work, that'd be grand21:44
kgunnSaviq: i would....but i actually don't have a gsm sim21:45
Saviqkgunn, you can use examples from lp:unity-notifications21:45
kgunnah21:45
Saviqkgunn, same thing21:46
Saviqolli, fixed notification input, my fault for being dumb21:46
Saviqolli, are landing now21:46
=== jhodapp is now known as jhodapp|afk
thomikgunn: I wasn't using upstart....21:51
kgunndamn you thomi21:54
kgunnSaviq: how to on the notification examples ?....just adb push the *.py and run from shell command line on device ?21:58
Saviqkgunn, yeah, you need to install python-notify and python-gi on the device, though21:59
kgunncool21:59
Saviqkgunn, also, it's possibly best if you just bzr branch lp:unity-notifications on the device22:00
Saviqkgunn, faster, and you'll get the images and such22:00
kgunnok22:00
kgunnSaviq: do i have to be sudo -u phablet -i for that ?22:00
Saviqkgunn, yes22:00
racarrtesting my keyboard focus fix in t minus 1 :D22:05
Saviqracarr, let me know if I can help with that22:05
kgunnSaviq: ok...incoming call example worked22:05
Saviqkgunn, over app, too?22:06
kgunnosk using msg app works22:06
kgunnwill try incoming call over app now22:06
kgunnSaviq: seems to work (work == i get a notification, i select accept, it dismisses and returns to app)22:07
racarrSaviq: thanks...it may be done...lets seee22:07
=== _salem is now known as salem_
racarrugh getting fail to start22:10
racarrI only rebuilt unity mir against things from trunk though...22:10
thomikgunn: https://bugs.launchpad.net/ubuntu/+source/mir/+bug/1235190/comments/1622:10
ubot5Ubuntu bug 1235190 in mir (Ubuntu Saucy) "[mako] Unity8 on Mir got slow" [High,Confirmed]22:10
kgunnthomi: kdub and i just chatting ...he's on the hunt....we're hoping its a clocking issue at the device level possibly22:12
racarrok starting but not working yet22:12
kgunnracarr: worked for me...but i used his deb's which had a bunch of upstart stuff too22:13
racarrSaviq: how can I get things in to the unity8 environment?22:13
racarrkgunn: I am talking about22:13
racarrthe branch I am working ont o fix the volume keys22:13
kgunnoh my bad racarr ...i'll slink away22:13
thomikgunn: would that explain the very high memory usage?22:13
Saviqracarr, stop unity8; initctl set-env FOO=bar; start unity822:14
kgunnthomi: no, high mem use could very well be that we don't have bypass enabled22:14
kgunn(so for every set of frame buffers....x2)22:14
kgunn(with high res displays...this obviously adds up)22:14
kgunnthomi: correction...you should get x2 once22:15
kgunnbut still...its not cheap22:15
thomihmmmm22:16
thomihow much memory does the mako have?22:17
thomiunity was using 35% of that... which seems waaaaay too high - even with a potential bypass issue22:17
racarrSaviq: ok so22:18
racarrmir now believes it is sending the volume up and down keys to the shell surface and it gets focus properly22:18
racarrbut stll nothing when I press the volume keys22:18
racarrare we confident the rest is wired up?22:18
racarrIf so it must be something22:19
racarrin papi mirserver22:19
kgunnthomi: you running top ?22:19
thomikgunn: I was22:20
kgunnthomi: i would agree with you22:21
kgunn30% is a lot22:21
kgunnthomi: so ...am running here...22:21
kgunnjust noticed, that 30% seems transient22:21
racarrSaviq: w\hat I mean is I am getting key published and finished received events22:21
racarrwhich means its going all the way out to the client in this case the shell surface22:21
kgunnthomi: i specificially see it when the launcher is revealed22:21
racarrand the input reader at least is reading it off the socket and saying cool22:21
thomihmmm, it was like that for at least 10 minutes for me22:22
kgunnthomi: oh, scratch that looking at wrong column22:22
kgunnthomi: what apps do you have open22:26
kgunnthomi: and do you have a crash file ?22:26
kgunnbbiab22:27
thomikgunn: no apps open, and there's a _usr_lib_arm-linux-gnueabihf_indicator-network_indicator-network-service.32011.crash from about the right time22:27
Saviqracarr, yeah, it's wired up22:29
Saviqracarr, you can add:22:30
Saviq    Keys.onPressed: console.log(event)22:30
Saviq    Keys.onReleased: console.log(event)22:30
Saviqracarr, somewhere in the shell22:31
Saviqracarr, to see if it gets there22:31
Saviqracarr, lines 171-172 are where the volume keys are hooked up22:31
=== salem_ is now known as _salem
Saviqracarr, thing is, we've had problems with *any* keys getting to apps / shell from the event system22:32
Saviqracarr, OSK works, 'cause it works directly between toolkit and OSK22:32
Saviqracarr, but autopilot typing through /dev/uinput didn't work (well, and then it started working for me after some sessions)22:33
racarrSaviq: hmm ok. thanks22:40
racarrI heard there were some permission issues22:41
racarrin the past22:41
racarrbut those have been fixed22:41
Saviqracarr, yup22:41
racarrSaviq: ok I am getting QQuickKeyEvents22:51
racarrmaybe the mapping isn't correct22:51
racarris there some like22:51
racarrprintEventVerbosely22:51
racarrfunction22:51
Saviqracarr, no, you'll have to print the id http://qt-project.org/doc/qt-5.0/qtquick/qml-qtquick2-keyevent.html#accepted-prop22:54
Saviqracarr, http://qt-project.org/doc/qt-5.0/qtquick/qml-qtquick2-keyevent.html#key-prop I mean22:54
Saviqracarr, and http://qt-project.org/doc/qt-5.0/qtcore/qt.html#Key-enum for a mapping22:55
Saviqfginther, http://10.97.0.26:8080/job/autopilot-testrunner-otto-saucy/927/console stuck?22:55
Saviqracarr, how difficult would it be, as a first step, to let key events "fall through" apps to the shell if they don't handle it?22:57
Saviqfginther, http://10.97.0.26:8080/job/autopilot-testrunner-otto-saucy/928/console suggests being stuck, too22:58
Saviqunless recording test results takes really long22:58
racarrSaviq: The problem is the shell isn't using the input filter22:58
racarrif the shell could use the input filter, then that would be the behavior22:59
racarrbut how can we get22:59
racarrhandle/not handle out of Qt?22:59
Saviqracarr, .accepted22:59
racarrhmm interesting22:59
racarrill investigate with greyback soon23:00
Saviqracarr, anything that responds to a key event should set its accepted prop to true, so that it doesn't get further up the focus chain23:00
Saviqracarr, we could just "extend" that focus chain up to the shell for the generic case23:00
Saviqracarr, obviously input filter is needed for global hot keys23:00
racarrmm23:00
Saviqracarr, but that's not something we need to look at right now23:01
Saviqand it is something we need to talk to in a lot more detail23:01
Saviqricmm, huh? what is ApplicationManager.volumeUp/DownKeyPressed?23:03
racarrSaviq: ok I am not getting qt::key_unknown but am also not getting anything I can find in the mapping23:03
Saviqracarr, right, so looks like the mapping fails in the QPA plugin?23:04
racarrSaviq: Yes. seems so....23:05
racarrwheeeeeeee...:p23:07
racarrok23:08
racarrits not impossible it just needs to be added to an enum23:08
racarrdigging deeper23:08
ricmmoh23:11
ricmmlook at you guys23:11
ricmmwell first of all we'd like to filter key events in the shell as the applications dont really need to read them directly23:12
ricmmsecond, the issue is that the android stack doesnt see the shell as a focused window for *keyboard* events23:12
ricmmmotion ones are dispatched through another path and the focused window is irrelevant in that sense, as they deal with the touched window instead23:13
ricmmso input stack drops these events, mir-side23:13
racarrok building a new qtubuntu23:13
racarrricmm: It does see it as a focused window now :)23:13
ricmmand it still doesnt work?23:13
racarrwell in the branch23:13
racarrI am working on23:13
racarryes23:13
racarrkey mapping seems to have an issue as well23:13
racarrit may just be the volume keysymd oesnt correspont to a unicode character23:14
ricmmwheres the branch?23:14
racarrso it has to go in that special array of keysyms23:14
ricmmscan codes are 114 and 115, they match linux/input.h types23:14
racarrricmm: ~robertcarr/unity-mir/default-input-focus23:14
racarrI know it's not getting mapped to a qt key code though23:14
racarror at least not the correct one lol23:15
racarrim pretty hopeful this is going to work right here :D23:15
racarryep :)23:16
ricmmpro23:16
racarrpreparing mps for qtubuntu and unity-mir now23:16
racarrSaviq: kgunn: Linked branches to https://bugs.launchpad.net/mir/+bug/123324523:20
ubot5Ubuntu bug 1233245 in unity-mir "[mir] key events not working through input devices (aka volume up/down)" [Critical,Triaged]23:20
kdubthomi, can you reproduce that bug 'mir got slow' at the moment?23:20
racarrSaviq: of course this only solves23:20
kdubi have a magical command to try23:20
racarrthe shell now receives input focus when nothing else has it23:20
racarrbut still isn't getting volume events when an app has focus23:20
racarrwe can implement that using the input filter paired with input injector approach23:21
racarrat a later date23:21
racarrperhaps?23:21
Saviqracarr, yeah, we need to think it through23:21
racarrif ".accepted" really works as seems23:22
racarrwe can hack the heck out of the QPA and23:22
racarrinject stuff straight from the input filter23:22
racarrin to Qt23:22
racarrand short circuit all this nonsense23:22
racarrwith what would be expected23:22
racarri.e. the shell gets the event can consume it or pass it on23:22
racarrapplication gets a chance at the event23:22
racarrcan consume it or pass it on23:22
racarrthen the shell gets it one more time23:22
Saviqracarr, yeah, we'd need to differentiate between the "times" somehow23:23
ricmmracarr: this default_input_target only refers to the key event types?23:23
ricmmor does this prevent motion events from being dispatched to the session as well23:23
racarryes. I thik it says like default_keyboard_input_target in the23:23
racarrclass right?23:23
racarrok so the problem is23:23
racarrin mir focus is tracked session->surface23:24
Saviqracarr, i.e. the first time would have to go through a global-hotkey-handler or something, the second it'd have to be injected below it23:24
racarrso we can't really give focus to the shell surface23:24
racarrwithout a session23:24
racarrso what this is doing, is whenever focus would otherwise be cleared23:24
racarrwhich happens when the shell is focused (because greyback calls, set_focus_to(NULL) on unfocusedCurrentApplication out of unity)23:24
ricmmI understand that, my question is if giving input focus to shell would prevent the application from getting motion events23:24
racarrit sets the keyboard23:24
racarrfocus only23:24
ricmmok then never give keyboard focus to the application23:24
racarrno it's fine23:25
Saviqricmm, FWIW, IMO we should only filter the global hot key events before the app gets it, nothing else23:25
racarrits only giving it to the shell23:25
racarrwhen no application23:25
racarrhas focus23:25
ricmmyou are missing my point23:25
racarrok23:25
ricmmif you never give keyboard focus to applications, but always to shell, you wont miss key events when in application23:25
racarrautopilot23:25
Saviqricmm, then you need to give them focus *in* shell23:25
racarruses real key events23:25
racarrto apps23:25
ricmmI prefer to have applications *not* get key events rather than not being able to use the volume keys whiel in application23:25
ricmmah thats true23:25
ricmmthen whats the solution for that case?23:26
racarrricmm: My plan for taking them out of the application is to use the input injecter being developed for the HUD23:26
racarrbit23:26
ricmminjecting events to the shell directly from qtuubntu sounds bad23:26
racarrplus an event filter, and have in unity mir23:26
racarrlike23:27
racarr"KeybindingEventFilter"23:27
racarrwhich supports like bind_key(int key_code, Surface target)23:27
Saviqricmm, input will go like so:23:27
racarrand it looks for the keycode, and if it sees it23:27
racarrhandles the event by injecting it to the surface23:27
racarrthrough the normal input injection mechanism23:27
racarrinjecting it23:27
racarrto the shell surface in this case23:27
Saviqdevice → shell(hotkeys) → (app →) shell(standard)23:27
racarrinstead of allowing it to propagate to the focused23:27
racarrsurface23:28
ricmmas long as theres an injection mechanism that uses the normal event delivery thats fine23:28
racarryes23:28
racarrthat is what should hopefully land soon for the hud23:28
ricmmhow soon23:28
ricmmconsidering tomorrow is tuesday23:28
ricmm:D23:28
racarrtomorrow?23:28
ricmmok23:28
racarrIt didn't get a real round of reviews this morning23:28
racarrbecause instead people just asked if it was needed -.-23:28
racarrbut im pretty sure it is23:28
racarrhttps://code.launchpad.net/~robertcarr/mir/input-injecter-api/+merge/18890423:29
ricmmjesus 1200 lines23:29
ricmmok so considering freeze is in 72 hours or less23:29
racarrricmm: It's mostly23:29
ricmmwhat about just implementing a filter and delivering the event as a qt signal to the qml layer23:29
racarrif you look at android_input_lexicon.cpp and test_android_input_lexicon.cpp23:30
racarryou will see what it mostly is :p23:30
racarrsounds reasonable I guess23:30
racarrwe need to land23:30
racarrthe shell receiving focus fixes anyway23:30
racarrfor autopilot23:30
racarrwe also need to sort the HUD button, which is what the input-injecter is for23:30
ricmmright23:30
ricmmok then23:31
racarrif input injecter isnt landed in the morning23:31
racarrwell23:31
racarrI dunno23:31
racarrwe need to land it really because we dont have a backup plan for the hud23:32
ricmmok then23:32
ricmmwhat extra work does this require?23:32
ricmmunity-mir injector to deliver to hud surface?23:32
racarrricmm: the problem is the shell input area along the bottom of the screen to show the hud button23:33
racarris disabled because it would consume events from the client preventing them from seeing23:33
racarrthe bring menu up events at the bottom23:33
racarrso uynity-mir needs to inject all events in that area23:33
racarrdown to the client as well23:33
ricmmor it could use an EventFilter to register swipes in that region, and signal to Qt via other mechanisms23:34
ricmmwhile still letting events pass for clients23:34
ricmmI think that would work, as long as the math in the filter doesnt introduce an incredible overhead23:35
racarrI think the only real problem is23:35
racarrwhat is the math23:35
racarrcan you adapt the existing code23:35
racarrto run in that context easily23:35
ricmmI dont know either of those answers, the second might be possible to do without a lot of pain23:37
ricmmthe first... it would have to decide whether theres a bottom edge drag23:38
ricmmand signal when past the threshold for hud23:38
Saviqricmm, racarr, the whole thing was designed to receive the whole input stream - both the shell and the app23:38
Saviqricmm, racarr, there's an ugly side-channel called BottomBarVisibilityCommunicator or some such, that lets the app (panel) know what's happening23:39
Saviqricmm, racarr, recognizing an edge swipe really needs all of the input23:39
ricmmthats doable with the filter23:40
ricmmits more about how to define the hud threshold for example23:40
ricmmas the filter would live in unity-mir23:40
racarrI need to understand the gesture recognizer more to comment better I guess23:44
racarrthe way I have always imagined it working23:44
racarris there is an InputFilter, which does like GestureRecognizer->dealWithEvent(event)23:44
racarrand eventually gesture recognizer may emit23:45
racarrsignals to QML like23:45
racarrgesture happening, gesture over, etc23:45
ricmmright, well all that logic is internal to Qt right now23:45
racarrbut as I understand there is "some issue" with adapting the Gesture recognizer23:45
racarrright23:45
ricmmso its not like we would want for the event filter to implement it all23:45
ricmmim talking specific to the hud case23:45
racarrmaybe yeah23:45
ricmmwhere we just want to recognize something without registering for input explicitly23:45
ricmmuhh23:49
ricmmracarr: why dont we just make the shell be a monitor?23:49
ricmmas it works in the SF case23:50
ricmmthere, we set up its surface as monitor23:50
ricmmand it just sets itself up accordingly23:50
ricmmwith  InputReceptionMode::receives_all_input23:52
* ricmm tries that out23:54
ricmmalright so that works fine23:57
kgunnkdub: did thomi ever chime back in ?23:59
kgunnkdub: i don't think mem use & slowness are related23:59
kgunnbtw23:59

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!