| hatch | ahh - yeah one model might be cool - but I'm guessing that there is enough difference that keeping them separate is probably a good idea | 00:00 |
|---|---|---|
| hatch | I have no data/experience to back up that claim however ;) | 00:00 |
| rick_h_ | hatch: right, but one modellist, container can take either, token can take either, etc | 00:00 |
| rick_h_ | there's two models, but a LOT of code that we want to be able to use either. Showing a readme is the same either way | 00:01 |
| hatch | right | 00:01 |
| hatch | thats all shared | 00:01 |
| rick_h_ | yea, all good, carry on. Will look forward to poking at it tomorrow | 00:01 |
| hatch | https://code.launchpad.net/~hatch/juju-gui/bundle-detail-tabs | 00:01 |
| hatch | there is the functional branch without qa/tests | 00:01 |
| hatch | but the current tests/basic qa all pass | 00:02 |
| rick_h_ | why can they not share the tabview setup vs having it in bundle.js and charm.js? | 00:03 |
| hatch | because....I didn't think of that | 00:05 |
| hatch | SO THERE!! | 00:05 |
| rick_h_ | ok, you gave me the link. I'll wait until tomorrow :) | 00:05 |
| hatch | lol | 00:05 |
| hatch | no it's cool thanks | 00:05 |
| hatch | I'll do that | 00:05 |
| rick_h_ | and while you're in there, we should setup a common attr vs the whole storeId vs entityId thing. | 00:06 |
| rick_h_ | that's fugly | 00:06 |
| rick_h_ | other than that, initial look is good :) | 00:07 |
| hatch | yeah I was thinking the same | 00:07 |
| hatch | ok tabview is moved....id thing will have to wait | 00:08 |
| hatch | off to make supper | 00:08 |
| hatch | cyaz | 00:08 |
| rick_h_ | enjoy! | 00:08 |
| gary_poster | bcsaller, hey. was trying to figure out why deploying wasn't working so well, and hacked around and came to http://paste.ubuntu.com/6207496/ . Realized toward the end that I had encountered, at least in part, some of the same things you had mentioned. My sandbox hack does not handle pyJuju, for instance, which was the kind of thing you mentioned today on the standup. I found a few other things though, as you'll | 01:20 |
| gary_poster | see. Maybe we can compare notes tomorrow. Meanwhile, running off. :-) see you | 01:20 |
| === _mup__ is now known as _mup_ | ||
| rick_h_ | gary_poster: around? | 11:19 |
| gary_poster | rick_h_, am now, but about to go vite | 12:04 |
| gary_poster | vote | 12:04 |
| rick_h_ | gary_poster: all good, have fun | 12:04 |
| gary_poster | cool will ping when I return | 12:04 |
| rick_h_ | luca__: ping, got a sec? | 12:14 |
| gary_poster | rick_h_, here | 12:20 |
| rick_h_ | gary_poster: that was fast | 12:20 |
| gary_poster | rick_h_, I vote like the wind! | 12:20 |
| gary_poster | or something | 12:20 |
| rick_h_ | gary_poster: k, quick hangout then? I wanted to clear up yesterday so I'm on the right track for today | 12:21 |
| gary_poster | rick_h_, cool. https://plus.google.com/hangouts/_/f2514e8843a5c2c1877fda92051ec0612813c92f | 12:21 |
| rick_h_ | gary_poster: and reviewed huw's branch, small issues we need to clear with ux. screenshots included. https://codereview.appspot.com/14526043/ | 12:26 |
| rick_h_ | gary_poster: so that's going to hang for a bit | 12:27 |
| rick_h_ | but did review it | 12:27 |
| gary_poster | rick_h_, ok cool thanks. It looks right to me--the top border is a 3d highlight to my eye, so I don't expect the triangle to go "in" the crevice--but yeah, good to check with luca__ | 12:29 |
| gary_poster | oh rick_h_, can you do the three-line switch from jc: to bundle: if you have not already? | 12:31 |
| rick_h_ | gary_poster: yes, will do. | 12:31 |
| gary_poster | thank you | 12:31 |
| gary_poster | rick_h_, maybe interesting thought and maybe you've thought about already: if new icon paths redirect from various general paths to a *version-specific* icon path, then we can set the icon's version-specific path to cache headers of "forever" | 12:38 |
| rick_h_ | gary_poster: well, the issue is we support 'latest' (revisionless) ids and that would cause us issues | 12:40 |
| gary_poster | rick_h_, but if the revisionless ones are redirects as well.. | 12:40 |
| rick_h_ | gary_poster: I'll double check/look. | 12:40 |
| gary_poster | cool | 12:40 |
| benji | abentley: what time does sinzui normally get in? | 13:02 |
| abentley | benji: He's usually around by now. | 13:03 |
| abentley | benji: He's just not on this channel. | 13:03 |
| benji | ah, thanks | 13:03 |
| === TheRealMue is now known as TheMue | ||
| luca__ | rick_h_: heya | 13:56 |
| luca__ | rick_h_: it looks off | 13:56 |
| rick_h_ | luca__: yea, I thought so | 13:56 |
| rick_h_ | luca__: none of hte visuals go over the triangle I can see. They're all still stars | 13:57 |
| rick_h_ | luca__: I think it's because we had kind of a beveled divider between charms | 13:57 |
| luca__ | rick_h_: yeah | 13:57 |
| luca__ | rick_h_: ok, so after showing Spencer | 13:59 |
| luca__ | rick_h_: he says that the triangle on the charm token should line up to the dark line | 13:59 |
| luca__ | rick_h_: not the highlight | 13:59 |
| luca__ | rick_h_: and the triangle on the bundle details should be bigger at 20px x 20px | 14:00 |
| rick_h_ | luca__: ok, can you guys reply to the email for Huw to look to update the branch for tomorrow then? | 14:00 |
| luca__ | rick_h_: sure, will he need a bigger triangle asset for the bundle details? | 14:00 |
| rick_h_ | luca__: let me look | 14:00 |
| rick_h_ | luca__: I'm not sure on the size. If you guys have one to include inthe email that'd be great. | 14:03 |
| luca__ | ok | 14:04 |
| rick_h_ | luca__: thanks for looking at it. Let me know if you've got any thoughts on #2 in that email as well even if it's just a 'Nope, nothing right now' so I can answer the question when/if it comes up please. | 14:04 |
| luca__ | rick_h_: I think improving search should be something we discuss in SF | 14:05 |
| rick_h_ | luca__: rgr | 14:05 |
| luca__ | rick_h_: we need to look at it with all the new things we've got and the future features | 14:05 |
| luca__ | rick_h_: I'll get Ale to set up a meeting :) | 14:05 |
| rick_h_ | luca__: ok cool. Good enough for me. | 14:05 |
| * rick_h_ runs away | 14:05 | |
| luca__ | rick_h_: haha | 14:06 |
| hatch | rick_h_: why not use css for the triangle? | 14:09 |
| rick_h_ | hatch: no idea. I've not done enough triangle css to suggest it or know if it would fall over here. | 14:10 |
| rick_h_ | hatch: trying to keep involvement to a review :P | 14:10 |
| frankban | cool. the gui charm with a local release takes 50 secs on ec2 from the install hook invocation to deployed | 14:10 |
| rick_h_ | hatch: btw, since you're online now. I saw the new YUI, but notes include changes to route/app and such so between us let's make sure we watch out for it | 14:10 |
| rick_h_ | frankban: woot | 14:11 |
| hatch | rick_h_: ugh yeah - I don't agree with that change but whatever | 14:11 |
| rick_h_ | hatch: yea, the req object has some diff bits as well. Enough that I went "whoa, we'll have to update for this one" | 14:11 |
| hatch | yeah I don't get the idea behind the update besides being different | 14:13 |
| hatch | I don't see where the old techniques fell down | 14:13 |
| benji | LXC really is awesome | 14:16 |
| rick_h_ | benji: +1 | 14:16 |
| rick_h_ | gary_poster: hatch so for this story of "I drag a bundle file onto the gui and need charm icons to show up" story we were talking about an api call that supplied the icon via the info in the bundle. | 14:23 |
| rick_h_ | gary_poster: hatch but I'm wondering if we need the full charm data itself as well? For the rest of things to work? Or is that not necessary? | 14:23 |
| hatch | the bundle contains the deployment data | 14:23 |
| hatch | so it's just the images that are required | 14:23 |
| rick_h_ | hatch: ok, so there's nothing else in the UX besides the icon that we need from the charm that's not in the deployment data? | 14:23 |
| rick_h_ | hatch: ok cool, sounds like a plan to me then. | 14:24 |
| hatch | rick_h_: I was thinking that when we create the models for the services the model should check if it has the required data and go fetch it itself | 14:24 |
| gary_poster | rick_h_, on call | 14:24 |
| rick_h_ | hatch: right, just wanting to think this through once vs redoing it. If we'll need some extra data for all the charms does a single enpoint make sense? Are we going to call out once for every charm in a bnudle, etc? | 14:25 |
| hatch | it would be nice if the endpoint would take a series of id's | 14:26 |
| hatch | and return the paths for all of htem | 14:27 |
| rick_h_ | hatch: well it's going to return the actual icon. So you'll just have <img src="......"> | 14:27 |
| rick_h_ | but I was worried about other data | 14:27 |
| hatch | ohh ok I see, so the model still won't have the image path | 14:28 |
| rick_h_ | hatch: yea, it builds it currently. | 14:28 |
| rick_h_ | hte model never has the image path tbh | 14:28 |
| hatch | oh I suppose | 14:29 |
| hatch | well I guess it 'should' cache the image using this approach | 14:29 |
| hatch | don't know why it doesn't cache them here though :/ | 14:29 |
| rick_h_ | hatch: definitely, it's how it works now | 14:29 |
| rick_h_ | hatch: yea, you're broken. | 14:29 |
| hatch | I must have an extension somewhere which is causing it to break or something | 14:31 |
| hatch | ugh 700ms OPTIONS requests.....we gota fix that lol | 14:31 |
| rick_h_ | hatch: yea, or just turned off caching in the chome dev tools | 14:31 |
| rick_h_ | hatch: refresh a few times | 14:32 |
| rick_h_ | hatch: that should ONLY happen on the first one in a series after chrome closes the connection upstream | 14:32 |
| hatch | lol that's not a real sollution | 14:32 |
| rick_h_ | hatch: well it is in normal use. You take a hit on first load and then it's fast | 14:32 |
| hatch | hmm the waterflow sure seems to indicate a server issue | 14:35 |
| hatch | but ooookkkkkk | 14:35 |
| rick_h_ | hatch: :P | 14:39 |
| hatch | has anyone else done that 'javascript under pressure' ? it's pretty cool :) | 14:48 |
| hatch | should be used when hiring js devs haha | 14:49 |
| hatch | oh rick_h_ last night I finally got the colours all sorted out - had to drop zsh as it somehow conflicted with vim and the terminal colours | 14:56 |
| benji | I just had an expecially geeky moment. Instead of getting up and going to look in a mirror I turned on my webcam. | 15:11 |
| rick_h_ | benji: never thoght of that! | 15:12 |
| rick_h_ | thought...man I can't type today | 15:12 |
| rick_h_ | laptop keyboard gah | 15:12 |
| benji | I like my laptop keyboard so much | 15:13 |
| benji | I bought an external one | 15:13 |
| benji | (doesn't keep me from pressing enter too soon though) | 15:13 |
| rick_h_ | well with the more powerful desktop spending a LOT more time on it and the clicky larger keyboard | 15:13 |
| * benji adopts the e.e.cummings IRC technique. | 15:13 | |
| benji | yeah, if I could get a narrow model M with a good trackpoint I would be in keyboard heaven | 15:14 |
| rick_h_ | meh, one day I hope the patent stuff in the three button trackpoint ends so others can steal it | 15:14 |
| rick_h_ | and unicomp needs a 10less model so so bad | 15:15 |
| benji | I have seriously considered custom building a keyboard, but I need another project like I need a hole in the head. | 15:16 |
| hatch | heh buttons...you silly people without multitouch gesture support | 15:17 |
| gary_poster | benji did you hear back from kentb? | 15:18 |
| benji | gary_poster: yeah, he should be attempting the install nowish | 15:18 |
| gary_poster | great benji | 15:18 |
| benji | gary_poster: I'm presently wrestling with importing the charms; I have a charm ingested now, but it lacks all personality (no icon, readme, description, etc.) because the charm isn't in the charm store; working that out now | 15:20 |
| gary_poster | cool benji, thx & good luck :-) | 15:20 |
| benji | "we're all counting on you" | 15:20 |
| rick_h_ | may the ice cream be with you | 15:23 |
| hatch | lol | 15:24 |
| * hatch hopes its soy based | 15:24 | |
| Makyo | jujugui call in 10 | 15:50 |
| gary_poster | Mr Kotter! | 15:50 |
| gary_poster | ugh... | 15:50 |
| gary_poster | foiled again | 15:50 |
| Makyo | Hahah, has no one set up a calendar bot yet? :) | 15:52 |
| hatch | jujugui looking for a review/qa plz https://codereview.appspot.com/14531046 | 15:55 |
| rick_h_ | hatch: happy to but will be a little bit | 15:55 |
| hatch | like 5 minutes? | 15:55 |
| hatch | or 5 hours? | 15:55 |
| hatch | :P | 15:55 |
| rick_h_ | hatch: like before EOD, but probably not for 1-2hrs | 15:55 |
| hatch | ohh I want to keep moving on this stuff so someone else pick it up :) | 15:56 |
| Makyo | I'll get it. | 15:57 |
| hatch | thanks | 15:57 |
| gary_poster | jujugui call in 2. hatch, you doing the honors? | 15:58 |
| hatch | yup | 15:58 |
| Makyo | If I skipped out, nothing to say on my card. | 16:03 |
| Makyo | The two in upgrade charm are down to 6 failing tests. | 16:03 |
| hatch | gary_poster: any specific bundle card you want me on? Or just pick one from the details page? | 16:15 |
| frankban | guihelp: does anyone know what charm revision is running jujucharms.com? | 16:16 |
| hatch | frankban: my guess would be the charmers one | 16:16 |
| hatch | revno 76 I think | 16:17 |
| gary_poster | frankban, yes, I think most recent | 16:17 |
| * hatch would loooove a charm update though ;) | 16:17 | |
| gary_poster | hatch, charm icons or source tab | 16:18 |
| frankban | gary_poster, hatch: cool thanks, I'll use that when trying the charm upgrade steps | 16:18 |
| gary_poster | hatch, I had hacked on charn icons but I should not do it. I could share thoughts/code if you were interested though | 16:18 |
| hatch | alright I think I need my current branch to land for source tab so I'll do the charm icons | 16:18 |
| gary_poster | makes sense frankban | 16:18 |
| hatch | oh ok - yeah if you have a branch | 16:19 |
| hatch | I haven't looked at all at it | 16:19 |
| gary_poster | hatch, http://paste.ubuntu.com/6209987/ and https://plus.google.com/hangouts/_/10fe9c48d75b9ebbe273219cb03f4e53869ce4f7 ? | 16:21 |
| gary_poster | thank you for webops work rick_h_ . sounds like you're on the track of it. awesome, and sorry for the interruption. | 16:33 |
| rick_h_ | gary_poster: all good, sorry I'm out of date on how the stuff works floundering around so much. and thanks abentley for helping peek at it as well | 16:34 |
| abentley | rick_h_: you're welcome. | 16:36 |
| abentley | rick_h_: FWIW, I have no clue what's going wrong with the branches. The proofing happens at a later stage, so the branches should already be checked out by then. | 16:36 |
| rick_h_ | abentley: yea, well we copied over the branches | 16:37 |
| rick_h_ | so they exist on disk now | 16:37 |
| rick_h_ | abentley: originally when the data was copied without the branches ingest came behind and make all the config bits empty, emptied the summary, etc | 16:37 |
| rick_h_ | abentley: so the branches are there copied from the old server and guessing it's trying to proof and it's got a -60 rev version of proof tools missing bits needed? | 16:38 |
| abentley | rick_h_: Right, so we still don't know why we couldn't copy them. | 16:38 |
| rick_h_ | abentley: right, that's still a bug in the deploy for sure. | 16:39 |
| rick_h_ | it should have recreated them if it didn't have them on disk | 16:39 |
| abentley | I guess we can test that locally by doing a dump from staging. | 16:40 |
| === abentley is now known as abentley-lunch | ||
| rick_h_ | hatch: comments sent, but didn't qa or go over 100% since I'm just drive by inputting :P | 16:41 |
| rick_h_ | hatch: thanks for the updates though! | 16:41 |
| Makyo | jujugui ill, need to lay down, can someone else grab frankban's second review? https://codereview.appspot.com/14545044 | 16:42 |
| * gary_poster already reviewing it | 16:42 | |
| Makyo | I was #2 | 16:42 |
| Makyo | Will try to get to it later if I don't in a bit | 16:43 |
| Makyo | That didn't make sense. | 16:43 |
| Makyo | Whtever, back i na bit | 16:43 |
| gary_poster | feel better | 16:44 |
| hatch | rick_h_: thanks will look | 16:50 |
| hatch | man you really hate attributes hey? lol changing | 16:51 |
| rick_h_ | hatch: well <3 them when you need them. They're awesome and magical. | 16:51 |
| rick_h_ | hatch: but this is not a case of needing them | 16:51 |
| hatch | I really wish someone would write a native js object attribute shim | 16:52 |
| hatch | which could 'upgrade' when necessary | 16:52 |
| hatch | rick_h_: so I have changed it to be a static but I"m not sure it should be done like that | 17:08 |
| hatch | we now have to go instance.constructor.entityType to access it | 17:08 |
| hatch | which is not discoverable really | 17:08 |
| hatch | for those not in-the-know | 17:09 |
| Makyo | Ugh, okay, sorry. Will do that review if no one else picked it up. | 17:10 |
| hatch | Makyo: you were only down for 15 mins :) | 17:14 |
| Makyo | hatch, I'd rather be working :P | 17:15 |
| hatch | haha - I've been 'off' for about a week, I'm chalking it up to the weather | 17:16 |
| hatch | fall alergies and whatnot | 17:16 |
| Makyo | Yeah, lots of that going around. | 17:16 |
| Makyo | Lost my appetite, and Makyos cannot subsist on espresso alone, apparently, nice as that'd be :P | 17:17 |
| hatch | you probably could on espresso and sugar | 17:22 |
| hatch | at least for a few weeks | 17:22 |
| hatch | then you'd probably die though | 17:22 |
| Makyo | I can't imagine my kidneys would be very happy :) | 17:22 |
| Makyo | Hahaha | 17:22 |
| benji | gary_poster: status update: kentb has a working gui with stock charms, I have a gui with (mostly correct) ice cream charms | 17:31 |
| gary_poster | benji, yay! | 17:59 |
| hatch | quit...writing...tests...with...actual, expected...switched...around | 18:04 |
| gary_poster | problem is that different frameworks have different orders, IIRC | 18:04 |
| rick_h_ | yea, I'm back on python side and it's switched | 18:05 |
| rick_h_ | and I keep writing ; and this. | 18:05 |
| rick_h_ | gah! | 18:05 |
| benji | yep, and Python has done the only sensible thing, stopped prescribing an order | 18:05 |
| hatch | if you don't prescribe an order then you don't know which is correct | 18:06 |
| rick_h_ | the output should put them in the order give to it | 18:07 |
| rick_h_ | at least then it would match the code | 18:07 |
| rick_h_ | it's all this "words are better, let's write out full sentences and try to use english to explain your failure" crap :P | 18:07 |
| hatch | lol | 18:07 |
| rick_h_ | test_something failed: | 18:07 |
| rick_h_ | 1 != 2 | 18:07 |
| rick_h_ | all I want | 18:07 |
| rick_h_ | with a line # :) | 18:07 |
| hatch | that would be fine with me! | 18:08 |
| hatch | right now I have to actually investigate every variable to figure out what is what | 18:09 |
| rick_h_ | you can debugger; tests | 18:09 |
| rick_h_ | and then just use chrome to look at all vars in scope | 18:09 |
| rick_h_ | or firebug, or whatever | 18:09 |
| hatch | another step | 18:09 |
| rick_h_ | yea, but better than " investigate every variable" | 18:09 |
| hatch | that's what you just said to do lol | 18:09 |
| rick_h_ | hatch: gary_poster so this is setup that if we can't find the charm we just respond with the generic charm icon. I don't know why we'd 404, but the through crossed my mind so sharing my assumption | 18:10 |
| gary_poster | rick_h_, +1 | 18:10 |
| hatch | if we can't find it then how do we deploy it? | 18:11 |
| gary_poster | he's talking about icon | 18:11 |
| rick_h_ | yea, sorry. Get into my mental context darn it :P | 18:11 |
| hatch | ohh ok then yeah that's fine with me | 18:11 |
| hatch | :) | 18:11 |
| gary_poster | rick_h_, actually better: *redirect* to unchanging location of generic charm icon | 18:12 |
| gary_poster | rick_h_, better for cacheing | 18:12 |
| gary_poster | caching | 18:12 |
| gary_poster | agree? | 18:12 |
| rick_h_ | gary_poster: yea, all of this is a redirect | 18:12 |
| hatch | well it would have to be a 'temporary redirect' | 18:12 |
| hatch | so not sure if that would help cache anything | 18:12 |
| gary_poster | hatch it would cache the end result | 18:12 |
| rick_h_ | abentley-lunch: pointed that out to me. Even if found it redirects to the right icon under the right ID in the hopes you might already have that cached | 18:12 |
| gary_poster | excellent | 18:13 |
| === abentley-lunch is now known as abentley | ||
| hatch | oh right - but it'll still make the request | 18:13 |
| hatch | can you set an expires on a temporary redirect? | 18:13 |
| gary_poster | hatch yes will still make a request, but still much cheaper than actually downloading the svg over and over again | 18:14 |
| hatch | true dat! | 18:14 |
| gary_poster | I don't know anything about cacheing a redirect. interesting question | 18:14 |
| hatch | although we spend way more time connecting than downloading with our server for some reason | 18:14 |
| gary_poster | caching! :-/ | 18:14 |
| hatch | to the googles! | 18:15 |
| hatch | gary_poster: they do cache redirects | 18:15 |
| hatch | http://stackoverflow.com/questions/691877/why-does-the-browser-not-cache-a-301-within-an-ajax-request/691949#691949 | 18:15 |
| _mup_ | Bug #691949: Misleading description of language-pack-de <apport-bug> <i386> <maverick> <Package Descriptions for Ubuntu:Invalid> <Ubuntu Translations:Invalid> <language-pack-de (Ubuntu):Invalid> <https://launchpad.net/bugs/691949> | 18:15 |
| benji | browsers respect cache headers on redirects | 18:15 |
| hatch | cool so we could add that as well to speed things up a bit | 18:16 |
| gary_poster | apparently as of 2010 not so much but nowadays it is AOK | 18:16 |
| gary_poster | yeah | 18:16 |
| hatch | http://www.browserscope.org/?category=network | 18:17 |
| hatch | according to that we are good to go | 18:17 |
| gary_poster | I'm doing the test on my own browser now for amusement sake | 18:18 |
| gary_poster | cool | 18:18 |
| hatch | ok back to writing tests.....*grumble grumble grumble* | 18:18 |
| gary_poster | :-) | 18:18 |
| hatch | ugh apple broke itunes podcasts section again.... | 18:19 |
| hatch | man today is just not a good day | 18:19 |
| rick_h_ | man I <3 python | 18:43 |
| benji | me too | 18:55 |
| * benji and rick_h_ join hands and Kumbaya. | 18:55 | |
| rick_h_ | bah, hate it when tests out in no where fail. "But but but...I didn't touch that code!" | 19:01 |
| rick_h_ | benji: have a sec to review https://code.launchpad.net/~rharding/charmworld/bundle-icons/+merge/189942 ? and can you qa/make test and verify you also get a test failure on the misc test for the homeview? | 19:14 |
| rick_h_ | benji: I can't see wtf I did to change that and wondering if it's something local. | 19:15 |
| rick_h_ | man, trunk passes...I must have done something. | 19:16 |
| rick_h_ | die spurious test failures die | 19:21 |
| benji | gary_poster: I just sent Kent an updated setup with the ice cream charms after going through the full install myself | 19:22 |
| gary_poster | awesome, benji! | 19:22 |
| gary_poster | benji, did you see my reply to Mark Baker? | 19:22 |
| gary_poster | benji, and his reply | 19:23 |
| gary_poster | the export to a nfs shared mount seemed doable, yeah? | 19:23 |
| benji | gary_poster: I say your message, but I don't think I saw his | 19:23 |
| gary_poster | s/shared// :-) | 19:23 |
| gary_poster | benji, pertinent bit was "maybe just save the yaml file to a shared drive even. " | 19:24 |
| gary_poster | (he did send it to me alone, it seems) | 19:24 |
| benji | gary_poster: i.e. the export mechanism? | 19:24 |
| gary_poster | benji right | 19:24 |
| benji | I don't see why it wouldn't work, but I haven't tried it; I'll try now | 19:24 |
| abentley | rick_h_: May I use your landing as a guinnea pig for testing whether team-based permissions are working? I thought they were broken, but that may have been a bug in the charm. | 19:25 |
| gary_poster | benji cool thanks | 19:25 |
| rick_h_ | abentley: sure thing if I can get this stupid test to pass | 19:26 |
| rick_h_ | abentley: benji any experience with using enable_routes causing straing behaviour? | 19:27 |
| abentley | rick_h_: Nothing comes to mind. | 19:28 |
| rick_h_ | benji: doing a stupid stupid thing in this to move forward. Please avert your eyes and I'll file a bug | 19:29 |
| rick_h_ | jujugui or anyone else up for a charmworld review? https://code.launchpad.net/~rharding/charmworld/bundle-icons/+merge/189942 | 19:33 |
| gary_poster | will look soon if no takers | 19:33 |
| rick_h_ | cfvdtrbkktfvcinvjufbucbinibirinnb | 19:40 |
| rick_h_ | ccccccbgjgvcfiujgetvtenddglclldgrgldtelejbvk | 19:40 |
| rick_h_ | bah | 19:40 |
| hatch | lol | 19:42 |
| hatch | mine is in the side of my monitor so I can't hit it haha | 19:43 |
| hatch | or if I did....it was one heck of a party | 19:43 |
| hatch | rick_h_: lol awesome merge description | 19:51 |
| benji | gary_poster: the export works with the ice cream setup; my Chromium automatically saves the export in a directory and appends incrementing numbers to subsequent downloads, so theoretically someone could also access that directory and look at timestamps or be given the parenthetical number (which is displayed by chrome) | 20:00 |
| benji | ok, I have to go to my appointment now, back in about an hour | 20:00 |
| gary_poster | benji great! will pass it on, thanks | 20:01 |
| hatch | ugh this test is infuriating | 20:30 |
| * benji is back. | 20:53 | |
| gary_poster | jujugui small branch for review by one. https://codereview.appspot.com/14565044/ | 20:53 |
| hatch | I'll do it | 20:54 |
| gary_poster | hey benji | 20:54 |
| * hatch needs abreak | 20:54 | |
| gary_poster | thanks hatch | 20:54 |
| gary_poster | benji, you going to look at rick's charmworld branch, or shall I? I can look at code but am not yet set up for QA. If you do QA, could you verify that the svg he is using is the gray one, not the black one? | 20:54 |
| benji | gary_poster: I'm working on an issue Kent is having (he isn't seeing the icons) | 20:55 |
| gary_poster | benji ok cool, I'll take it. thx | 20:55 |
| * gary_poster was about to take break when he realized it was about to be EoD :-P | 20:56 | |
| rick_h_ | gary_poster: I've got the black one in there. Updating with the grey one now. | 20:58 |
| gary_poster | cool thanks rick_h_ | 20:58 |
| rick_h_ | updated to use https://docs.google.com/a/canonical.com/file/d/0B9WMKNMU_KombXJYUmt5OWJRY2c/edit?usp=drive_web and pushed up | 20:59 |
| rick_h_ | thanks for the reminder | 20:59 |
| gary_poster | rick_h_, did you have tests for the bundle icon thing? I'm sorely tempted to have you add it back in so we don't lose the work. wdyt? | 21:00 |
| gary_poster | (assuming that adding it back in means reverting a revision) | 21:00 |
| rick_h_ | not sure what the 'bundle icon thing' is? I added the icon, added the work to return it from charmworld, and did the charm icons via new api endpoints in there | 21:01 |
| rick_h_ | I didn't revert anything or go back. It was already done when we talked so just kep going forward | 21:01 |
| rick_h_ | gary_poster: I did not and had not gotten to serving out the icon.svg in the bundle if it was promulgated so that's just not complete | 21:01 |
| rick_h_ | but per our call we don't want that to occur right now | 21:01 |
| gary_poster | rick_h_, oh ok cool. that's what I meant. nm then, yeah | 21:01 |
| gary_poster | rick_h_, you "# See if we have a /series/name." should we also include logic for ~user/series/name? that's a question, not a request, to be clear. | 21:02 |
| rick_h_ | gary_poster: I didn't see that supported. If it uses the name it's only because it's a promugated charm. Let me pull back up the deployer file | 21:03 |
| hatch | gary_poster: done with trivial | 21:03 |
| gary_poster | hatch awesome thank you | 21:03 |
| gary_poster | rick_h_, ah promulgated. Maybe add a comment about that. | 21:04 |
| rick_h_ | gary_poster: rgr | 21:04 |
| rick_h_ | gary_poster: so the logic I followed for all of this was http://bazaar.launchpad.net/~juju-deployers/juju-deployer/trunk/view/head:/deployer/charm.py#L43 from the deployer | 21:05 |
| rick_h_ | gary_poster: so it's only checking the branch and charm keys in the service section of the deployer file if I read that right | 21:06 |
| rick_h_ | gary_poster: no owner/etc | 21:06 |
| gary_poster | ack, looking | 21:07 |
| rick_h_ | bah, looks like I did transfer that wrong. There's a charm_url, charm, and branch. Missing charm_url. wonder what that is. | 21:08 |
| rick_h_ | well, not wrong, but incomplete | 21:08 |
| gary_poster | looks like it is another cs:, rick_h_ | 21:09 |
| gary_poster | that was my assumption, but...assumption :-) | 21:09 |
| rick_h_ | gary_poster: I think it's for local? http://bazaar.launchpad.net/~juju-deployers/juju-deployer/trunk/view/head:/deployer/charm.py#L75 | 21:09 |
| rick_h_ | in which case we'd just not find the charm anyway. | 21:09 |
| gary_poster | yeah | 21:10 |
| gary_poster | though I don't even know what d is in this context | 21:10 |
| rick_h_ | but anyway, that's the general idea is to support the data that deployer function does. | 21:10 |
| gary_poster | and don't want to dig to find out this second | 21:10 |
| gary_poster | gotcha. comment to that effect sounds sufficient | 21:10 |
| rick_h_ | d in this context is the service dict from the data.services section of the deployer file | 21:10 |
| gary_poster | rick_h_, as further populated by that other code you mentioned? | 21:11 |
| gary_poster | http://bazaar.launchpad.net/~juju-deployers/juju-deployer/trunk/view/head:/deployer/charm.py#L75 | 21:11 |
| rick_h_ | gary_poster: yea, I'm assuming that the d charm_url is the same one it would generate from the object here. | 21:12 |
| gary_poster | gotcha | 21:12 |
| rick_h_ | gary_poster: the result of this parsing is then passed back to Charm.__init__() | 21:12 |
| rick_h_ | gary_poster: the result of this 'from_service' call | 21:12 |
| gary_poster | rick_h_, code LGTM. I'd love to see test verification that the end result url has a version in it, but I'm guessing we already have similar tests of API3._get_api_id. Wuld also be nice to have tests of cache headers, but I doubt we're generating them. maybe file bug? | 21:14 |
| gary_poster | Meanwhile I have not qad. Doing so will take me awhile, since I have never built charmworld. do you need me to? | 21:14 |
| gary_poster | Or is code LGTM sufficient? | 21:14 |
| rick_h_ | gary_poster: I think a LGTM will be good. We'll hit staging first. We can it against the data there. and maybe even get to QA it with Gui changes before it goes to production | 21:15 |
| rick_h_ | and right, the version info is based on the lp branch of cs: urls passed in. I've got other tests that verify that the right charms are found/built | 21:16 |
| rick_h_ | you're right I didn't make sure there are cache headers on this calls, but because they're not versioned, the ones to cache are the redirected icon urls | 21:17 |
| rick_h_ | they're so fluid ugh, but it's what the deployer does | 21:17 |
| gary_poster | right | 21:18 |
| gary_poster | Approval is in there | 21:18 |
| gary_poster | thank you! | 21:18 |
| gary_poster | hatch, before your EoD today, could you ask huwshimi to style what you've landed today--details view & readme I think? | 21:32 |
| hatch | once I get it landed :/ | 21:32 |
| gary_poster | heh | 21:32 |
| hatch | I've been fighting for hours writing the tests | 21:32 |
| gary_poster | ok | 21:32 |
| gary_poster | :-( | 21:32 |
| hatch | either the promise or the assertion captures the failures | 21:33 |
| bcsaller | hatch: is this something you'd like to talk through? | 21:33 |
| hatch | so it's very difficult to debug | 21:33 |
| hatch | bcsaller: nah I'm on the home stretch now, thanks though | 21:33 |
| hatch | gary_poster: did you ever reply about my comment? | 21:59 |
| hatch | sorry I was actually curious as to what the resulting difference was :) | 22:00 |
| hatch | bcsaller: so I"m all done now - but I was curious if you had a technique to avoid the assertion failures being captured by the promises | 22:02 |
| bcsaller | hatch: usually after the final call you can add .then(undefined, done) to the chain | 22:03 |
| hatch | that's only if the call returns a promise | 22:03 |
| hatch | thought of that ;) | 22:03 |
| huwshimi | Morning | 22:04 |
| bcsaller | your test didn't happen in the .then of a promise return? | 22:04 |
| hatch | the promises happened inside of the view's render | 22:05 |
| hatch | bcsaller: it's proposing now so you can take a look in a few | 22:05 |
| hatch | if you like that is | 22:05 |
| hatch | morning huwshimi | 22:05 |
| bcsaller | ha | 22:05 |
| hatch | huwshimi: re gary's email - I think it's already styled properly but will be landing soon | 22:06 |
| huwshimi | hatch: OK, will take a look, thanks. | 22:07 |
| hatch | jujugui could I get a quick follow-up reivew on https://codereview.appspot.com/14531046/ plz | 22:11 |
| Makyo | Two more tests~ But first, dogwalk. | 22:13 |
| hatch | Makyo: did you mean I needed two more? | 22:14 |
| hatch | or you do? | 22:14 |
| Makyo | I do, my bad | 22:14 |
| hatch | :) | 22:14 |
| hatch | phew | 22:14 |
| hatch | ok I made a few small cleanup changes to my branch and I'm landing it | 22:16 |
| hatch | huwshimi: ok landed | 22:27 |
| huwshimi | hatch: Great, thanks! | 22:28 |
| hatch | huwshimi: doesn't look like it works on comingsoon, so you'll need to pull it down locally unfortunately and run on staging | 22:31 |
| hatch | staging.jujucharms.com that is | 22:31 |
| hatch | jujugui manage.jujucharms.com is not allowing comingsoon because of Access-Control-Allow-Origin | 22:31 |
| hatch | actually the real issue is the url | 22:32 |
| hatch | yeah ignore me comingsoon is still on manage.jujucharms.com | 22:33 |
| huwshimi | hatch: Do you know which part Gary is referring to when he says "that charm detail box that the icon produces should probably always have a set size"? | 22:36 |
| rick_h_ | hatch: catchin gup, just got back online | 22:36 |
| rick_h_ | mjc isn't allowing comingsoon? mjc hard codes the headers :/ | 22:36 |
| hatch | rick_h_: the issue is that comingsoon is running manage.jujucharms.com and not staging.jujucharms.com | 22:37 |
| hatch | so it doesn't have all of the data required to make a proper request | 22:37 |
| rick_h_ | hatch: ah, right. | 22:37 |
| hatch | and instead of 404'ing or whatever manage is rejecting it because of that hah | 22:37 |
| rick_h_ | hatch: think I follow, maybe not. | 22:38 |
| rick_h_ | so it's your call that's failing? | 22:38 |
| hatch | http://comingsoon.jujucharms.com/sidebar/search/bundle/:flags:/charmworldv3/?text=benji | 22:38 |
| hatch | watch the network tab | 22:38 |
| rick_h_ | loads here | 22:38 |
| rick_h_ | ah, right not the details call | 22:39 |
| rick_h_ | hatch: yea, that's just not going to work. Should we point coming soon to staging for a bit? | 22:39 |
| rick_h_ | should bring it up on the call | 22:39 |
| rick_h_ | hatch: ok so submitted so you're all set then? | 22:39 |
| hatch | yup all done | 22:40 |
| hatch | promises and assertions are the devil | 22:40 |
| rick_h_ | hatch: maybe make a card to bring up dealing with tests aroud promises. Souds like you hit a pita to share | 22:40 |
| rick_h_ | hatch: sorry to bring that up but glad it worked out. | 22:40 |
| hatch | well really it's just a symptom of a much larger issue - that we don't have a proper mock structure | 22:40 |
| rick_h_ | it's JS :P | 22:41 |
| hatch | tbh that should mean we could write one easier | 22:41 |
| hatch | because we can overwrite and inject whatever we want | 22:41 |
| rick_h_ | right | 22:42 |
| hatch | we might be able to do this mocking with Y.Do | 22:42 |
| hatch | i'll have to look into it at some point | 22:43 |
| hatch | sinon looks interesting | 22:46 |
| hatch | not sure how it works with instances though | 22:47 |
| rick_h_ | yea, we used sinon on something. I'm trying to recall which project | 22:48 |
| rick_h_ | hatch: did we figure out what's up with CI? | 22:50 |
| hatch | rick_h_: gary was able to run it locally just fine so chalking it up to saucelabs/canonistack | 22:51 |
| hatch | priority right now is on bundling | 22:52 |
| rick_h_ | hatch: gotcha, cool | 22:52 |
| rick_h_ | just saw an email so was curious | 22:52 |
| hatch | well i need to get off this thing | 22:54 |
| hatch | ttyl have a good night | 22:54 |
| rick_h_ | c-ya | 22:55 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!