| === _salem is now known as salem_ | ||
| === salem_ is now known as _salem | ||
| === jasoncwarner_ is now known as jasoncwarner | ||
| === iahmad is now known as iahmad|afk | ||
| tsdgeos | pstolowski: ping | 08:16 |
|---|---|---|
| pstolowski | tsdgeos, pong | 08:16 |
| tsdgeos | see the first change at https://code.launchpad.net/~stolowski/unity8/category-reordering/+merge/189263 | 08:16 |
| tsdgeos | you're adding an include that's already there :D | 08:16 |
| tsdgeos | like, two lines above ;-) | 08:17 |
| pstolowski | tsdgeos, indeed :) thanks | 08:17 |
| pstolowski | tsdgeos, pushed | 08:20 |
| tsdgeos | pstolowski: const & the vector of onCategoryOrderChanged to avoid copying the uints all the time? | 08:24 |
| pstolowski | tsdgeos, agree, I'm not sure why didn't I do it :/ | 08:26 |
| tsdgeos | pstolowski: on the qWarning("beginMoveRows failed"); thing, maybe add old_pos and target_pos? i don't think this will ever fail by reading the code of beginMoveRows, but if it fails, we'll want to know what the indexes were | 08:29 |
| tsdgeos | pstolowski: also i don't like this change | 08:33 |
| tsdgeos | http://paste.ubuntu.com/6212868/ | 08:33 |
| tsdgeos | it's just making things slower | 08:34 |
| tsdgeos | since basically contains has to look for the thing in the set | 08:34 |
| tsdgeos | which is what << does already | 08:34 |
| tsdgeos | so if it's not there | 08:34 |
| tsdgeos | you end up doing "two searches" | 08:34 |
| tsdgeos | otoh contains does not detach and << always detaches even if not necessary | 08:37 |
| tsdgeos | so not sure anymore :D | 08:39 |
| tsdgeos | feel free to ignore | 08:39 |
| * tsdgeos feels like he's talking to himself | 08:40 | |
| dholbach | hiya | 08:40 |
| dholbach | how much work would it be to create a desktop session for unity8? or what kind of work would be involved? | 08:41 |
| tsdgeos | dholbach: we don't do much of the typical "desktop management" on the desktop, so not sure it'd be much useful | 08:49 |
| nic-doffay | Cimi, ping | 08:50 |
| dholbach | tsdgeos, I just thought that it'd help with testing, trying it out, it might be good for app devs to test their click apps there too and it will be required on the path to convergence too - so I was just wondering what would need to be done to offer a session | 08:50 |
| tsdgeos | dholbach: not sure to be honest, but i don't see how it'd help to test click apps if it doesn't even do proper alt+tab, etc, anyway Saviq is your man a proper answer for that | 08:55 |
| Saviq | dholbach, we've not even *tried* to run proper unity8 on the desktop under Mir | 08:56 |
| Saviq | dholbach, which is a requirement for being able to launch any apps there | 08:56 |
| dholbach | Saviq, ok - shall I ask again after saucy release? :-) | 08:58 |
| nic-doffay | Saviq, those autopilot issues with the sdk branch have been fixed. I'm going to get that reviewed today. | 08:58 |
| nic-doffay | finally. | 08:58 |
| nic-doffay | So the filters can be looked at again. | 08:59 |
| Saviq | nic-doffay, cool | 09:03 |
| pstolowski | tsdgeos, what did you mean with your last comment about saving on lookup? | 09:10 |
| tsdgeos | pstolowski: we don't need the variable at all, so remove the indexOf call? | 09:11 |
| pstolowski | tsdgeos, ah, ok, indeed | 09:12 |
| Cimi | nic-doffay, pong | 09:15 |
| Saviq | tsdgeos, can I throw https://code.launchpad.net/~unity-team/unity8/albumart-provider/+merge/189923 on you afterwards? | 09:16 |
| tsdgeos | Saviq: sure | 09:16 |
| * tsdgeos throws it to himself | 09:16 | |
| dednick | mzanetti: : I'm getting an error running qmltests on jenkins for ubuntu-settings-components "qmltestrunner: could not find a Qt installation of ''" | 09:18 |
| dednick | mzanetti: could be missing something from deps? | 09:18 |
| tsdgeos | dednick: guess mzanetti stil at devdays, not sure how online he'll be | 09:19 |
| dednick | tsdgeos: ah. ok | 09:19 |
| tsdgeos | dednick: sounds as if qt5-default was not installed maybe? | 09:19 |
| pstolowski | tsdgeos, just experienced this when playing with category reordering branch - http://ubuntuone.com/5CJqELstdZQw6dRR44acoy | 09:19 |
| dednick | Saviq: ^ ? | 09:20 |
| pstolowski | tsdgeos, (it's my branch with all trunk changes in) | 09:20 |
| tsdgeos | pstolowski: wops | 09:20 |
| tsdgeos | pstolowski: not good :_/ | 09:20 |
| Saviq | dednick, that would be caused by missing qt5-default | 09:20 |
| tsdgeos | pstolowski: i guess not reproduceable? | 09:20 |
| Saviq | dednick, where? | 09:20 |
| dednick | Saviq: http://10.97.0.26:8080/job/ubuntu-settings-components-qmltests-saucy/4/console | 09:21 |
| pstolowski | tsdgeos, it still works and stays like that, till I drag all the contents up/down, then it's back to normal | 09:21 |
| tsdgeos | pstolowski: yeah the LVWPH "fixes" itself in some cases | 09:21 |
| tsdgeos | in others just crashes :D | 09:21 |
| dednick | Saviq: ok, it is missing from packaging | 09:21 |
| Saviq | dednick, it shouldn't be there, arguably... | 09:21 |
| dednick | Saviq: can you see if you notice anything else? http://bazaar.launchpad.net/~ubuntu-settings-components-team/ubuntu-settings-components/trunk/view/head:/debian/control | 09:22 |
| Saviq | dednick, we don't have it, do we | 09:22 |
| tsdgeos | pstolowski: but of course it should never happen, just that not sure how to end up where you ended up to fix it | 09:22 |
| Saviq | "we" == unity8 | 09:22 |
| dednick | Saviq: it does | 09:22 |
| Saviq | dednick, ah, build deps, yeah | 09:22 |
| dednick | Saviq: qtdeclarative5-test-plugin ? | 09:22 |
| pstolowski | tsdgeos, well, I saw it before a couple of times, but not easily reproducible | 09:22 |
| Saviq | dednick, yeah, and tools | 09:23 |
| nic-doffay | Cimi, can you pull on that branch and see if the tests pass? | 09:24 |
| === iahmad|afk is now known as iahmad | ||
| dednick | Saviq: qtbase5-dev-tools or qtdeclarative5-dev-tools? | 09:24 |
| nic-doffay | Cimi, they pass on jenkins. | 09:24 |
| nic-doffay | Which means it's some sort of local issue. | 09:25 |
| Saviq | dednick, declarative | 09:25 |
| Cimi | nic-doffay, the test is wrong | 09:25 |
| Saviq | dednick, you'll need qtquick too, for testing | 09:26 |
| Cimi | nic-doffay, you're clicking on the inverse mouse area, directly | 09:26 |
| tsdgeos | pstolowski: so what do you do when you reproduce it? just search random words or is there a pattern? | 09:26 |
| Cimi | nic-doffay, of course it caches it | 09:26 |
| Saviq | dednick, 'cause qmluitests only install build deps | 09:26 |
| Cimi | nic-doffay, you should instead click on coordinates relatives to where you want it to have the mouse area | 09:26 |
| Cimi | and verify it really s | 09:27 |
| Cimi | nic-doffay, on my test and nick | 09:27 |
| Cimi | nic-doffay, touches are not detected a little bit down the search box till half the screen | 09:27 |
| nic-doffay | Cimi, I disagree. | 09:28 |
| dednick | Saviq: thanks | 09:29 |
| nic-doffay | Cimi, what do you mean a little bit down the search box? | 09:29 |
| Cimi | nic-doffay, 20% y of the screen | 09:30 |
| nic-doffay | I'm trying to ascertain why this works for me and not for you. | 09:30 |
| Cimi | nic-doffay, for example, when ou have an opened app | 09:30 |
| Cimi | nic-doffay, and you're on the app lens | 09:30 |
| Cimi | nic-doffay, right to the miniature of the opened app | 09:30 |
| Cimi | nic-doffay, nothing happens there | 09:31 |
| pstolowski | tsdgeos, didn't noticed a pattern yet; just search a couple of times | 09:31 |
| tsdgeos | ok | 09:31 |
| nic-doffay | Cimi, but the rest now works for you? | 09:31 |
| nic-doffay | I'm still not following what you mean. | 09:31 |
| Cimi | nic-doffay, it was worning | 09:32 |
| pstolowski | tsdgeos, I've updated category-reordering branch | 09:32 |
| Cimi | nic-doffay, i didn't test today | 09:32 |
| nic-doffay | Cimi, but it wasn't working yesterday? | 09:32 |
| Cimi | dednick, can you explain nic-doffay what's wrong? my english might suck | 09:32 |
| tsdgeos | pstolowski: tx | 09:32 |
| tsdgeos | pstolowski: any reason RoleRendererHint: uses index for the query and not realIndex? or just a merge mistake? | 09:34 |
| dednick | Cimi: yeah | 09:34 |
| pstolowski | tsdgeos, ah, merge mistake, it was added to trunk after my changes, thanks for spotting | 09:35 |
| pstolowski | tsdgeos, fixing | 09:35 |
| dednick | 1) have home lens open. | 09:37 |
| dednick | 2) tap search panel, search bar opens at top. | 09:37 |
| dednick | 3) type "plop", no results | 09:37 |
| dednick | 4) half way between keyboad and search bar, tap on screan. | 09:37 |
| dednick | 5) keyboard does not close. | 09:37 |
| dednick | 6) tap "just" above the keyboard, keyboard closes. | 09:37 |
| dednick | nic-doffay: ^ | 09:37 |
| nic-doffay | dednick, cool going to give it a go. | 09:38 |
| dednick | and screan obviously = screen :) | 09:38 |
| nic-doffay | dednick, other conditions work properly though? | 09:38 |
| dednick | nic-doffay: it's very hit and miss. it seems if you tap anywhere where there could be a dash category row (even if there are no results), it doesnt close. | 09:39 |
| pstolowski | tsdgeos, pushed | 09:41 |
| dednick | nic-doffay: sometimes closes randomly if i tap the search bar again. sometimes not, sometimes tap on panel closes... | 09:41 |
| nic-doffay | dednick, hmm that most likely is an inverse mouse area issue imo | 09:42 |
| nic-doffay | The second one you mentioned. | 09:42 |
| nic-doffay | Saviq, what are your thoughts on all of this? ^ | 09:42 |
| Saviq | nic-doffay, none atm, sorry | 09:43 |
| dednick | nic-doffay: i have no idea how the InverseMouseArea works in the case of z-order press events. I would have thought tapping ANYWHERE that is not the searchbar would close it, but it seems that everything else that accepts press events and is above in z-order is getting them. | 09:45 |
| nic-doffay | dednick, I'm going to try change the z order to see if it makes any difference. | 09:46 |
| dednick | nic-doffay: i think zorder is only for children on same object. | 09:47 |
| nic-doffay | dednick, well that approach worked for the filters. | 09:47 |
| nic-doffay | Everything below the filter selectors drop down cannot be clicked. | 09:47 |
| nic-doffay | So I'm hoping it will help. | 09:47 |
| dednick | nic-doffay: we have filters? | 09:48 |
| dednick | need a friggin cancel search button as well... | 09:48 |
| Saviq | dednick, yeah we talked yesterday with mhr3 | 09:48 |
| Saviq | dednick, that there's a hidden feature in unity7 - you can still tap on the activity indicator to cancel ;) | 09:49 |
| nic-doffay | dednick, there's a branch waiting to land. | 09:49 |
| dednick | Saviq: heh. does that dismiss the search bar though? | 09:49 |
| Cimi | I can work on this bug if you want | 09:50 |
| Cimi | Saviq, do you have another bug for nic-doffay in case? | 09:50 |
| nic-doffay | Cimi, this might not be anything to do with the Unity8 code. | 09:50 |
| Saviq | Cimi, he's got some https://launchpad.net/~nicolas-doffay/+assignedbugs ;) | 09:52 |
| Cimi | nic-doffay, move to another one :) | 09:53 |
| Cimi | nic-doffay, I'll have a look in three hours | 09:53 |
| nic-doffay | Cimi, what's the point of passing it over? | 09:53 |
| Cimi | nic-doffay, so keep going | 09:53 |
| Cimi | nic-doffay, start drawing rectangles filling the inverse mouse areas | 09:54 |
| Cimi | nic-doffay, with different colors | 09:54 |
| Cimi | nic-doffay, so you see where they are | 09:54 |
| Cimi | and stuff like this.. | 09:54 |
| Cimi | nic-doffay, another point is that I had a chat with oren and he explained me how it should behave | 09:54 |
| nic-doffay | Cimi, how does it differ to the bug report that he filed? | 09:55 |
| nic-doffay | Cimi, I don't think the issue is as simple as you think either. | 09:56 |
| Cimi | nic-doffay, ok so keep debugging and find out why it's not working | 09:56 |
| Cimi | nic-doffay, we cannot accept half fixes | 09:56 |
| Cimi | or well, we shouldn't | 09:56 |
| nic-doffay | Cimi, who said we were going to? | 09:57 |
| nic-doffay | You're making an awful lot of assumptions here. | 09:57 |
| === alan_g is now known as alan_g|tea | ||
| Cimi | nic-doffay, hey sorry for upsetting you | 09:57 |
| tsdgeos | pstolowski: i think your beginMoveRows is wrong | 09:57 |
| nic-doffay | Cimi, I'm still confused, you told me yesterday it didn't work at all. | 09:58 |
| tsdgeos | pstolowski: beginMoveRows is braindead and takes into account the thing itself | 09:58 |
| tsdgeos | so you need something like | 09:58 |
| nic-doffay | But today it apparently has other issues according to dednick | 09:58 |
| tsdgeos | int newModelIndex = newIndex > oldIndex ? newIndex+1 : newIndex; | 09:58 |
| tsdgeos | like we have in the launcherlistmodel | 09:59 |
| tsdgeos | launchermodel sorry | 09:59 |
| Cimi | nic-doffay, I might have explained badly | 09:59 |
| Cimi | nic-doffay, yesterday I had same issues of dednick | 09:59 |
| nic-doffay | Cimi, ok right got it. | 09:59 |
| nic-doffay | MacSlow, I read your review and you said this works for you. Have you run into any of dednick 's issues? (If you've been following this at all0 | 10:01 |
| nic-doffay | MacSlow: <dednick> 1) have home lens open. | 10:02 |
| nic-doffay | <dednick> 2) tap search panel, search bar opens at top. | 10:02 |
| nic-doffay | <dednick> 3) type "plop", no results | 10:02 |
| nic-doffay | <dednick> 4) half way between keyboad and search bar, tap on screan. | 10:02 |
| nic-doffay | <dednick> 5) keyboard does not close. | 10:02 |
| nic-doffay | <dednick> 6) tap "just" above the keyboard, keyboard closes. | 10:02 |
| nic-doffay | dednick, btw does it dismiss the search entry after those steps? | 10:04 |
| pstolowski | tsdgeos, yeah, I saw it in the qt docs, fixing | 10:04 |
| nic-doffay | Even if the keyboard doesn't close properly? | 10:04 |
| === alan_g|tea is now known as alan_g | ||
| pstolowski | tsdgeos, pushed | 10:13 |
| tsdgeos | cool | 10:13 |
| dednick | nic-doffay: yeah. if you close the popup first. | 10:13 |
| dednick | nic-doffay: not really sure why you have 2 inverse areas though. wont the other one always catch everything not in itself and close? | 10:17 |
| tsdgeos | pstolowski: one last question | 10:18 |
| tsdgeos | pstolowski: the "// populate category order vector with 0..n" part in ::data | 10:19 |
| nic-doffay | dednick, nah | 10:19 |
| nic-doffay | the one is for the top bit | 10:19 |
| nic-doffay | which is a different layer | 10:19 |
| tsdgeos | pstolowski: does it make more sense somewhere else? | 10:19 |
| nic-doffay | Sorry, let me try explain in more detail. | 10:19 |
| nic-doffay | The one for the pageHeader, the other is for the rest of the area below the page header. | 10:19 |
| nic-doffay | So the first is to catch the inverse of the textEntry in the pageHeader | 10:20 |
| nic-doffay | the other is for everything below. | 10:20 |
| nic-doffay | dednick, it's a small area in the case of the first inverse area, but I figured it should be added anyway. | 10:20 |
| dednick | nic-doffay: but the sensitive area is the root item. "Everything not in this area" includes the other InverseMouseArea region | 10:20 |
| nic-doffay | dednick, I don't think so. I recall doing a print to test if the presses were caught, they were not | 10:21 |
| nic-doffay | but let me check again... | 10:21 |
| nic-doffay | dednick, confirmed. | 10:22 |
| dednick | nic-doffay: where you testing on device or on desktop? it works for me on desktop | 10:25 |
| nic-doffay | dednick, I've had issues on the device before which I mentioned to Saviq but the desktop works 100% for me. | 10:26 |
| nic-doffay | Which is what leads me to believe it's an issue with the InverseMouseArea SDK component. | 10:26 |
| nic-doffay | On desktop, everything is caught, and the focus is disabled. | 10:27 |
| MacSlow | nic-doffay, I'll try to replicate that... | 10:27 |
| nic-doffay | MacSlow, ta | 10:27 |
| nic-doffay | MacSlow, try on the device though, the desktop works for me every time... | 10:28 |
| nic-doffay | Unless you were already? O_o | 10:28 |
| MacSlow | nic-doffay, I always try it on the device... unless it's just some API-change with tests | 10:29 |
| nic-doffay | MacSlow, ergh ok. | 10:30 |
| nic-doffay | I hope something does break, otherwise this is even more confusing. | 10:30 |
| MacSlow | nic-doffay, not that it should matter... I'm testing it on a GalaxyNexus... what device did dednick try it on? | 10:32 |
| dednick | MacSlow: same | 10:33 |
| dednick | it's obviously only an issue on the device. | 10:33 |
| dednick | It probably has something to do with the keyboard | 10:33 |
| MacSlow | dednick, nic-doffay: I can confirm this odd behaviour here too | 10:34 |
| pstolowski | tsdgeos, this was the best place I could think of.. the problem is it has to happen when category model is fully established. and we can't do this in onCategoryOrderChanges because we may never get this signal (or get it after call to data()) | 10:34 |
| nic-doffay | MacSlow, mind just adding that as a review comment. Thanks dednick thanks for the feedback too. | 10:34 |
| MacSlow | nic-doffay, just doing that | 10:34 |
| nic-doffay | MacSlow, does it work fine on desktop out of interest? | 10:34 |
| nic-doffay | (sorry for being a pain) | 10:35 |
| nic-doffay | I just want to make 100% sure this behaviour is the same for multiple people. | 10:35 |
| tsdgeos | pstolowski: hooking up to onRowCountChanged/modelreset/layoutchanged? | 10:35 |
| MacSlow | nic-doffay, well there's no osk when I run it on the desktop | 10:35 |
| tsdgeos | pstolowski: though otoh in ::data is just easier | 10:36 |
| pstolowski | indeed | 10:36 |
| tsdgeos | pstolowski: but means we destroy the ordering when the rowCount changes, is that what is expected? | 10:36 |
| MacSlow | nic-doffay, but as soon as you type the tap outside doesn't close the searchbar anymore | 10:36 |
| nic-doffay | MacSlow, true. | 10:38 |
| nic-doffay | MacSlow, but it should disable the search bar focus still. | 10:38 |
| nic-doffay | MacSlow, so you won't be able to type any more... | 10:39 |
| nic-doffay | MacSlow, the behaviour apparently differs with the component on desktop and mobile. | 10:39 |
| MacSlow | nic-doffay, the keyboard-focus is gone (for the desktop-case) | 10:40 |
| pstolowski | tsdgeos, we don't support changes to category model after the scope is created, so this shouldn't be an issue | 10:40 |
| tsdgeos | pstolowski: so basically the row count never changes after it has been set up? | 10:41 |
| MacSlow | nic-doffay, updated the MR with all the new info | 10:41 |
| pstolowski | tsdgeos, actually let me double check that | 10:41 |
| nic-doffay | MacSlow, thanks it's helpful. I'm going to give Tomas a shout to see if he can shed more light on this. | 10:42 |
| pstolowski | mhr3, category model will never get updates after scope is set up, correct? | 10:43 |
| mhr3 | pstolowski, it's better if you don't assume that | 10:43 |
| tsdgeos | pstolowski: mhr3: the question is not that if it does not change, the question is, if row count changes, is it ok to "reset" the ordering? | 10:44 |
| mhr3 | sure | 10:44 |
| pstolowski | mhr3, tsdgeos : I don't see any handling of that in categories.cpp (for the main category model) | 10:44 |
| pstolowski | mhr3, tsdgeos : only the change of the entire model is handled | 10:44 |
| mhr3 | pstolowski, well model reset is row count change, no? | 10:45 |
| mhr3 | well.. can be | 10:45 |
| pstolowski | mhr3, adding rows to existing model won't trigger model.changed in unitycore, will it? | 10:46 |
| pstolowski | mhr3, anyway, we don't support that in libunity afair | 10:47 |
| mhr3 | pstolowski, but there are ways it can happen, restarting scopes etc | 10:47 |
| tsdgeos | pstolowski: mhr3: so how do we deal with that? | 10:53 |
| mhr3 | tsdgeos, if the cat model changes, forget about the overridden order and wait for new signal that will override it | 10:54 |
| mhr3 | tsdgeos, is that what you're asking^? | 10:54 |
| pstolowski | tsdgeos, I'l add m_categoryOrder.clear() for the case when categories model changes | 10:58 |
| pstolowski | tsdgeos, just to start off with a default order | 10:59 |
| tsdgeos | ok | 11:01 |
| === MacSlow is now known as MacSlow|lunch | ||
| larsu | mhr3: how did you reproduce bug #1236249 ? The bluetooth indicator and the setting in system-settings vanishes when I turn off bluetooth | 11:51 |
| ubot5 | bug 1236249 in unity8 (Ubuntu) "unity8 crashed with SIGSEGV in UnityMenuModelPrivate::itemState()" [High,Confirmed] https://launchpad.net/bugs/1236249 | 11:51 |
| mhr3 | larsu, there's a mir bug describing the exact steps, but if you use sf instead of mir you get this bt | 11:54 |
| larsu | mhr3: ah thanks, I also just managed to get the crash when activating the action on the bus manually | 11:54 |
| seb128 | larsu, mhr3: to reproduce I think you should use the bluetooth panel in system settings | 11:55 |
| mhr3 | larsu, do you need link to that mir bug? | 11:55 |
| larsu | mhr3: only if you don't need to search for it ;) (like I said, I can reproduce already) | 11:55 |
| seb128 | larsu, mhr3: it's only the switch in the battery which has the vanishing issue | 11:56 |
| mhr3 | larsu, cool... i would have to :) | 11:56 |
| larsu | seb128: ah of course! Sorry about that. (I spent too much time in the battery panel today) | 11:56 |
| larsu | mhr3: ya, don't worry about it then | 11:56 |
| seb128 | larsu, lol, I know what you mean, I had the same issue a couple of time, looking at the wrong panel | 11:57 |
| larsu | seb128: tbh, I think hiding the option and the indicator is wrong... | 11:58 |
| seb128 | larsu, what option/indicator? | 11:59 |
| larsu | bluetooth | 11:59 |
| seb128 | oh, bluetooth | 11:59 |
| seb128 | the option in settings is a bug | 11:59 |
| seb128 | due to the indicator object being hidding | 11:59 |
| seb128 | charles is going to fix | 11:59 |
| larsu | ah cool | 11:59 |
| seb128 | the indicator is a mpt's design decision to spare panel space on the small screen | 11:59 |
| === alan_g is now known as alan_g|lunch | ||
| === MacSlow|lunch is now known as MacSlow | ||
| Cimi | Saviq, a little explanation | 12:16 |
| Cimi | Saviq, why online category in Videos dash are processed by GenericScopeView? | 12:16 |
| Cimi | and not DashVideos.qml | 12:16 |
| Saviq | Cimi, DashVideos is deprecated | 12:17 |
| Saviq | Cimi, if it's still there at all - should go | 12:17 |
| Cimi | Saviq, ok | 12:17 |
| Saviq | Cimi, same for DashMusic, for that matter | 12:17 |
| Cimi | Saviq, ok gotcha | 12:18 |
| === _salem is now known as salem_ | ||
| Cimi | Saviq, I thought UbuntuShape was able to take ShaderEffectSource | 12:36 |
| Cimi | Saviq, how do I fill the video renderer with black otherwise? | 12:36 |
| Saviq | Cimi, make the whole UShape black | 12:37 |
| Saviq | Cimi, and overlay a cropped image | 12:37 |
| Cimi | Saviq, ah yeah | 12:37 |
| Saviq | Cimi, no need to shape the image | 12:37 |
| Cimi | Saviq, so why we said the ubuntushape didn't support that? | 12:37 |
| Saviq | Cimi, because it should do it internally | 12:38 |
| Saviq | Cimi, right, so for now you can put the "film" image in the UbuntuShape | 12:38 |
| Saviq | Cimi, and overlay a cropped image | 12:38 |
| Cimi | Saviq, what should do internally? | 12:38 |
| Saviq | Cimi, UShape should take both the background image | 12:39 |
| Saviq | Cimi, and the overlay image | 12:39 |
| Saviq | Cimi, or well... maybe not | 12:39 |
| Saviq | Cimi, so, it's probably even easier not to use UShape at all | 12:39 |
| Saviq | Cimi, but have an UShaped image already | 12:39 |
| Saviq | Cimi, and just overlay a cropped image on top | 12:40 |
| Saviq | Cimi, I think the "mounting" is a left over from back when it was supposed to be slightly more complicated - or maybe we simply didn't take the needed step-back | 12:40 |
| Saviq | to see how to do it the simplest | 12:41 |
| Cimi | Saviq, shaderEffectSource support :) | 12:41 |
| Saviq | Cimi, no UShape at all | 12:41 |
| Saviq | -Cimi, Image { source: "background.png"; width: foo; height: bar; Image { source: the_source; anchors { fill: parent; topMargin: units.gu(5); bottomMargin: units.gu(5) }; fillMode: Image.PreserveAspectCrop; sourceSize.height: height } | 12:42 |
| Saviq | } | 12:42 |
| Saviq | Cimi, where background.png is simply the mount background, already "ubuntu-shaped" | 12:43 |
| Saviq | Cimi, get what I mean? | 12:43 |
| Cimi | Saviq, sure | 12:43 |
| Cimi | Saviq, but we need videos that have aspect ratio not squared | 12:43 |
| Saviq | Cimi, not sure what you mean there? | 12:44 |
| larsu | dednick: I've half-fixed bug #1236249 - can you please have a look at the other half? (see last comment) | 12:44 |
| ubot5 | bug 1236249 in unity8 (Ubuntu) "unity8 crashed with SIGSEGV in UnityMenuModelPrivate::itemState()" [High,Confirmed] https://launchpad.net/bugs/1236249 | 12:44 |
| Saviq | Cimi, right now everything in Videos will be square, only movie posters are meant to be portrait - but we don't have those | 12:44 |
| Cimi | Saviq, ok | 12:44 |
| Saviq | Cimi, and posters don't need to be mounted | 12:44 |
| Saviq | Cimi, so all in all - you can implement the end solution already | 12:45 |
| Cimi | Saviq, I need that mounted shape asses | 12:45 |
| Saviq | Cimi, yes | 12:45 |
| Saviq | Cimi, jounih will get it for you | 12:46 |
| tsdgeos | ci borked again? | 12:50 |
| tsdgeos | pstolowski: so that should cover all regarding ordering and rowcount changes, right? | 12:52 |
| mhr3 | dednick, lost time again :/ | 12:58 |
| dednick | mhr3: can you check if indicator-datetime is running? | 13:05 |
| === vila is now known as vila-laaaate-lun | ||
| mhr3 | dednick, it's not | 13:05 |
| dednick | mhr3: hm. musta crashed | 13:05 |
| dednick | larsu: i'll take a look | 13:06 |
| mhr3 | any log to check? | 13:06 |
| larsu | dednick: thanks | 13:06 |
| Cimi | Saviq, music renderer is instead a square with more text? | 13:08 |
| Saviq | Cimi, left-aligned | 13:09 |
| Saviq | Cimi, so it's pretty close to what we have already | 13:09 |
| Cimi | ok | 13:09 |
| Saviq | Cimi, can you start with carousel delegate though? | 13:09 |
| Saviq | Cimi, we need to put the black overlay with song name on there | 13:09 |
| Saviq | Cimi, like we had for people lens | 13:10 |
| Cimi | Saviq, ah ok | 13:10 |
| Cimi | Saviq, for a reason I missed this | 13:10 |
| Cimi | Saviq, I thought the carousel just needed to be loaded with count > 5 | 13:10 |
| Saviq | Cimi, I think the reason is because it's missing from the visual design spec... | 13:10 |
| Saviq | Cimi, that, too, yes | 13:10 |
| Saviq | Cimi, oh well, it's not there in the visual design | 13:10 |
| pstolowski | tsdgeos, right | 13:11 |
| === vila-laaaate-lun is now known as vila-late-lunch | ||
| dednick | mhr3: dont know. /var/crash ? | 13:15 |
| mhr3 | dednick, if there was something indicator-related you'd have it already ;) | 13:15 |
| Saviq | Cimi, for the overlay in carousel - there's no design I'm afraid | 13:15 |
| Cimi | ok | 13:16 |
| Saviq | Cimi, so start with the grid indeed | 13:16 |
| Saviq | Cimi, and I'll try and get you a design in the mean time | 13:16 |
| === alan_g|lunch is now known as alan_g | ||
| mhr3 | Saviq, songs names in carousel? the visual spec doesn't have that, something new? | 13:18 |
| Saviq | mhr3, it's described in the UX spec | 13:18 |
| Saviq | mhr3, "The hero item in a carousel (the biggest thumbnail) has an overlay that will show the song name so songs will be differentiated through the title." | 13:19 |
| mhr3 | yey for even more inconsistencies in the specs | 13:20 |
| Saviq | Cimi, let's go for left-aligned two lines with right-eliding to start with - you'll chose the right font size | 13:21 |
| tsdgeos | pstolowski: ok, approving then, the problems you're having with LVWPH are not your fault, and if this makes them easier to repro that may even be a good thing. Agreed? | 13:21 |
| dednick | hey...where is my datetime indicator | 13:21 |
| dednick | ! | 13:21 |
| Saviq | dednick, desktop? | 13:21 |
| dednick | Saviq: phone | 13:22 |
| dednick | and process is running. grr | 13:22 |
| Saviq | dednick, oh, is consistently there for me... | 13:22 |
| dednick | Saviq: mine is normally. i just restarted my phone and poof | 13:22 |
| Cimi | Saviq, dimensions? | 13:24 |
| dednick | hm. actually, process was on desktop. no ssh on phone :( | 13:24 |
| Cimi | Saviq, should be as big as now or smaller? | 13:24 |
| Saviq | Cimi, check out the https://docs.google.com/a/canonical.com/presentation/d/1X3_G6reCpcFJxzxn1Xtv9wK5n3-wOW-6z2l0qSZ8-sg/present#slide=id.gefe99b49_00 | 13:25 |
| tsdgeos | kgunn: video standup today? | 13:25 |
| Saviq | Cimi, https://lh6.googleusercontent.com/DiFH5zJxUPhXES9dICX4ydlmQzpkKFMNeJlq3NsPhPIUAzbAH8XjX4YlZ0eii1w5csbAX2ZqnW9l6bjLSDzzd8Y1oCJf2qKzJYZ49lDeg5dPDbCiCEI-3eyi8Fs says 18GU | 13:26 |
| Cimi | Saviq, but this is carousel | 13:27 |
| kgunn | tsdgeos: yeah...we should | 13:27 |
| Saviq | Cimi, ah grid is there, too - 11GU | 13:28 |
| Cimi | yeah | 13:28 |
| Cimi | Saviq, total 16 with text | 13:28 |
| Saviq | Cimi, yup | 13:28 |
| === vila-late-lunch is now known as vila | ||
| pstolowski | tsdgeos, yup, thanks! | 13:34 |
| Cimi | Saviq, can you give me the link of the image of video with grid? | 13:35 |
| Cimi | I right click and cannot see it | 13:35 |
| Cimi | might use inspector in case.. | 13:35 |
| Saviq | Cimi, https://lh5.googleusercontent.com/YJsbwT4BhY1HuNX9vaLwtOruPFxSRVWs8zIcVoqHUTLFdi4ETM3SUDrJKb0sHn3AOoh7TFnGSos7MidzXW5fbgKLwcfYQRDjOXvUU3R8be6s-z4dYfLLSUM1Nts ? | 13:36 |
| Cimi | Saviq, thanks! | 13:36 |
| dednick | mhr3: hm. not sure about that datetime problem. looks like it crashes, but would expect to come back up. | 13:40 |
| mhr3 | dednick, yea, it's back now | 13:43 |
| mhr3 | but it took a while | 13:43 |
| dednick | what triggers dbus service to restart process? | 13:44 |
| dednick | mhr3: ^ ? | 13:44 |
| mhr3 | dednick, a call to that service | 13:44 |
| mhr3 | any call to that service | 13:44 |
| larsu | dednick: do you have any idea why the volume slider in the sound menu doesn't work when I add a parameter to the volume action? | 13:45 |
| larsu | dednick: it shouldn't have any influence... | 13:45 |
| dednick | larsu: er, you match the type in the menu item? | 13:48 |
| Cimi | nic-doffay, you joining hangout? | 13:49 |
| mterry | MacSlow, https://code.launchpad.net/~mterry/unity8/hide-greeter-on-app-launch/+merge/189948 | 13:52 |
| kgunn | MacSlow: curious, what's the worst scenario in terms of rendering performance ? | 13:52 |
| * mterry hugs MacSlow | 13:53 | |
| larsu | dednick: yeah, nothing but the parameter type changed | 13:53 |
| MacSlow | mterry, tkx | 13:53 |
| larsu | dednick: I've got to run now unfortunately. If you want to have a look, the branch is at https://code.launchpad.net/~larsu/indicator-sound/volume-action-activation | 13:54 |
| larsu | dednick: it is supposed to fix bug #1236292 | 13:54 |
| ubot5 | bug 1236292 in Unity 8 "Using volume buttons on phone triggers spurious popup" [High,Triaged] https://launchpad.net/bugs/1236292 | 13:54 |
| MacSlow | kgunn, scrolling gets really slow and choppy with 3 or more apps running... sometimes it doesn't even react anymore to swiping/scolling... all that on GalaxyNexus | 13:54 |
| dednick | larsu: ok, i'll try if it i have some time | 13:55 |
| larsu | thanks | 13:55 |
| MacSlow | kgunn, you want that in some bug-report against mir/unity-mir? | 13:55 |
| dednick | larsu: but from quick look, dont you need to set_action_and_target on the menu item? | 13:55 |
| kgunn | MacSlow: oh no, we have a bug :) but hmmm...so i don't have one, but david moreland provided me this video http://www.youtube.com/watch?v=Tq6wCRwIIYw | 13:55 |
| kgunn | and compared to this http://www.youtube.com/watch?v=5jh2mOOwya4 | 13:56 |
| larsu | dednick: I don't think so, no. The menu item itself will never activate this action. It works fine in unity7 | 13:56 |
| kgunn | so yeah, the mir config is slower...but...not unusable...what you describe is near unusable | 13:56 |
| larsu | dednick: if it won't work, I'll just introduce another action | 13:56 |
| dednick | larsu: yeah, but the types have to match for unitymenumodel. | 13:56 |
| davmor2 | kgunn: Morley ;) | 13:57 |
| kgunn | davmor2: i rename people all the time | 13:57 |
| MacSlow | kgunn, taking a look after the standup | 13:57 |
| davmor2 | kgunn: that's okay I can never remember peoples real names and am forced to call them by nicks :D | 13:58 |
| dednick | larsu: http://pastebin.ubuntu.com/6213854/ | 13:58 |
| kgunn | MacSlow: actually that might actually be clocks...and the fix i was mentioning may help | 13:58 |
| Saviq | Cimi, for the carousel - if you need help digging the old people lens out, let me know | 13:59 |
| kgunn | MacSlow: hmmm....b/c i know that hw very well...there could be one other dreaded thing happening....gpu hwrecovery (if you feed it something it no like, it will reset, "silently"...but takes ~100ms) | 13:59 |
| kgunn | and can get into a cycle... | 13:59 |
| MacSlow | kgunn, it sounds like that would help... scrolling gets a bit better, if I flick through the running apps a few time (right swipe)... maybe it's also a caching-issue? | 13:59 |
| MacSlow | kgunn, I gladly test any branches that tried to improve on this | 14:00 |
| === dandrader is now known as dandrader|afk | ||
| davmor2 | kgunn: maliit not appearing so I swiped the app from the right and then brought it back to the front and I get these characters in the text filed http://ubuntuone.com/1icbmYJxANRRWc8sB4HsC5 this happens opening maliit for the first time on any new app too but only under mir | 14:02 |
| kgunn | davmor2: there is work ongoing around mallit as we speak.... | 14:03 |
| MacSlow | kgunn, yeah... these two videos reflect pretty much my experience with performance-difference between sf and mir | 14:04 |
| MacSlow | kgunn, btw... is that popey doing the demonstrations? | 14:05 |
| MacSlow | kgunn, at least sounds a bit like him | 14:05 |
| kgunn | MacSlow: its davmor2 | 14:05 |
| MacSlow | kgunn, ok oops :) | 14:06 |
| MacSlow | kgunn, still sounds a bit like Alan :) | 14:06 |
| nic-doffay | MacSlow, I think with these new additions from that branch your issue will be solved | 14:08 |
| nic-doffay | You should just be able to assign -1 to the selectedIndex alias. | 14:08 |
| MacSlow | nic-doffay, which branch of yours it it? I'll give it a try later this evening and update my MR for the last ext. snap-decision making it depend on your branch then | 14:09 |
| nic-doffay | MacSlow, confirmed | 14:09 |
| nic-doffay | i've also added an example to the gallery. | 14:09 |
| MacSlow | nic-doffay, great! | 14:10 |
| davidcalle | sil2100, ping | 14:12 |
| nic-doffay | MacSlow, here's the branch. lp:~nicolas-doffay/ubuntu-ui-toolkit/multi-selectors | 14:12 |
| davmor2 | MacSlow: I don't know who should be more offended me or popey ;) | 14:12 |
| MacSlow | davmor2, hehe | 14:12 |
| nic-doffay | Sorry, I can't keep track of what I've added to that and what I haven't without double checking haha. | 14:12 |
| davidcalle | Mirv, ping | 14:15 |
| MacSlow | kgunn, btw... another observation regarding mir on the GN... with 4 apps open... starting Terminal seems to hang the device... it's no longer reacting to any input. | 14:15 |
| kgunn | MacSlow: hey...this one getting attention https://bugs.launchpad.net/ubuntu/+source/indicator-sound/+bug/1236292 | 14:18 |
| ubot5 | Ubuntu bug 1236292 in Unity 8 "Using volume buttons on phone triggers spurious popup" [High,Triaged] | 14:18 |
| kgunn | could you focus on that one | 14:19 |
| davmor2 | MacSlow: that is the issue I have it seems to happen randomly | 14:19 |
| MacSlow | kgunn, according to seb128 that is already fixed in some branch... indicator-sound just has to not issue any notification (as confirmation-notifications currently are not meant to be on Touch as per Design) | 14:19 |
| davmor2 | MacSlow: adb doesn't work either right? | 14:20 |
| seb128 | kgunn, MacSlow: https://code.launchpad.net/~larsu/indicator-sound/volume-action-activation | 14:20 |
| MacSlow | davmor2, yeah... device seems just to be deah... only the battery-out-battery-in helps at this point | 14:21 |
| davmor2 | MacSlow: yeah I'm trying to get a set of sane steps to reproduce it. There is nothing obvious in /var/crash though right? | 14:22 |
| MacSlow | davmor2, I'm not really chasing this bug... doing reviews mostly atm | 14:23 |
| dednick | larsu: enabling bluetooth after you've switched it off is buggered | 14:24 |
| davmor2 | MacSlow: if you find out please god let me know I'd love to see it go away :) | 14:25 |
| MacSlow | davmor2, sure thing... but don't hold your breath... at least not today :) | 14:25 |
| pstolowski | tsdgeos, I think category-reordering still needs your approval? | 14:26 |
| davmor2 | MacSlow: I'm going to keep trying to find reproducible steps for a bug in the meantime | 14:26 |
| MacSlow | davmor2, good luck! | 14:27 |
| sil2100 | davidcalle: pong! | 14:27 |
| tsdgeos | pstolowski: sure | 14:27 |
| sil2100 | davidcalle: hi! | 14:27 |
| tsdgeos | was going to do it now | 14:27 |
| sil2100 | davidcalle: you saw this? https://launchpadlibrarian.net/153086899/buildlog_ubuntu-saucy-i386.unity-scope-github_0.1%2B13.10.20130723-0ubuntu1_FAILEDTOBUILD.txt.gz | 14:27 |
| tsdgeos | pstolowski: done | 14:29 |
| pstolowski | tsdgeos, thanks | 14:29 |
| === alan_g is now known as alan_g|tea | ||
| nic-doffay | MacSlow, the branch will land tomorrow | 14:30 |
| davidcalle | sil2100, hi, yes that's why I pinged you for https://code.launchpad.net/~davidc3/cupstream2distro-config/github-scope/+merge/190141 :) | 14:32 |
| MacSlow | kgunn, seb128: commented on the sychronous-notification issue on unity8 -> https://bugs.launchpad.net/ubuntu/+source/indicator-sound/+bug/1236292/comments/7 | 14:32 |
| ubot5 | Ubuntu bug 1236292 in Unity 8 "Using volume buttons on phone triggers spurious popup" [High,Triaged] | 14:32 |
| seb128 | kgunn, MacSlow: shrug, as said yesterday, it's being fixed from the indicator-sound side, c.f the vcs I just pointed out | 14:33 |
| tsdgeos | Saviq: that artwork provider thing, code looks ok, but seems like we copied it from somewhere, which makes my bugfixing hat sad, and also makes my Qt hat sad since it's all C++/glib instead of Qt we kind of mostly do in Unity8 code. Commented so on the review | 14:34 |
| Saviq | tsdgeos, it's temporary | 14:34 |
| MacSlow | seb128, ok... works for me too | 14:34 |
| tsdgeos | Saviq: ah, and has no tests either :D | 14:34 |
| tsdgeos | damnit, forgot to comment that | 14:34 |
| Saviq | tsdgeos, we just need a place for it now for 13.10 - it'll get refactored away post 13.10 | 14:34 |
| tsdgeos | Saviq: temporary as in ? | 14:34 |
| Saviq | tsdgeos, it will go and live in the thumbnailer or so | 14:35 |
| tsdgeos | ok | 14:35 |
| davidcalle | sil2100, btw, where does this build come from ? | 14:35 |
| tsdgeos | Saviq: well, if it's going to be temporary i guess "it's ok" | 14:35 |
| tsdgeos | but hope it's not one of those "temporary-forever" things | 14:35 |
| sil2100 | davidcalle: aaaah, so it's not to be released/built? | 14:39 |
| davidcalle | sil2100, it shouldn't since it's not in distro anymore, just on the server | 14:40 |
| tsdgeos | Saviq: any special review you want me to look at? | 14:42 |
| sil2100 | davidcalle: I'll check the cu2d merge, but I think anyway we'll need this to be buildable on saucy right? At least so that it can be used on the server - or is something else used on the server? | 14:42 |
| * sil2100 is a noob in the new server scoped ;) | 14:43 | |
| pstolowski | tsdgeos, re your comments to https://code.launchpad.net/~unity-team/unity8/albumart-provider/+merge/189923 | 14:43 |
| === alan_g|tea is now known as alan_g | ||
| Saviq | tsdgeos, https://code.launchpad.net/~mterry/unity8/hide-greeter-on-app-launch/+merge/189948 would be good | 14:44 |
| mterry | MacSlow is looking at it too, but more eyeballs might help. It's a big, 7-branch fixup :) | 14:44 |
| davidcalle | sil2100, the failing test is fixed and the ^ mp is for the merger to merge it so yes, it will build. (Also, the server doesn't need builds, it extracts files from specific branches and runs them, but it's still nice to have things that can be installed anywhere) | 14:47 |
| pstolowski | tsdgeos, this branch is a result of a collective work of ~3 people and we are under pressure to get it done asap. it's under manual testing on the phone today (and looking good so far), but we don't have time and resources to add automated tests and we would like to avoid refactoring at this point (not to mention moving mediaartcache to a library; it's from mediascanner btw) | 14:48 |
| pstolowski | tsdgeos, we hope to clear it out and rework after 13.10 | 14:48 |
| tsdgeos | Saviq: ok | 14:49 |
| tsdgeos | pstolowski: sure, if it has to go in, it has to go in :D | 14:49 |
| pstolowski | tsdgeos, at this point we would appreciate if the shortcomings were accepted ;) unless you see a real blocker ;) | 14:49 |
| sil2100 | davidcalle: I'm shocked that this scope didn't have a merger set-up! ;) | 14:50 |
| tsdgeos | pstolowski: no, i don't see a real blocker, the QEventLoop thing scares me a bit, but there's no other way around it i can think of | 14:50 |
| sil2100 | davidcalle: (or it had but I removed it by accident) | 14:50 |
| sil2100 | davidcalle: I would guess it's the latter... ;p | 14:50 |
| pstolowski | tsdgeos, right; we want an async call | 14:50 |
| sil2100 | fginther: hello! We approved https://code.launchpad.net/~davidc3/cupstream2distro-config/github-scope/+merge/190141 , could you re-setup the merger? | 14:50 |
| pstolowski | tsdgeos, sync, I mean | 14:51 |
| davidcalle | sil2100, ;-) | 14:51 |
| fginther | sil2100, ack | 14:51 |
| sil2100 | fginther: thank you! | 14:51 |
| Cimi | Saviq, I noticed horizontal alignment and vertical is only read by the ubuntushape with the icon | 14:55 |
| Cimi | Saviq, on the tileStyles we have | 14:55 |
| Cimi | Saviq, looks like a mistake while we want the ubuntushape to be always centered | 14:55 |
| Cimi | Saviq, but the text moved? | 14:55 |
| Saviq | Cimi, probably, yes - but most of the images are tile-styled anyway | 14:56 |
| kgunn | dednick: lucky you...the pin unlock thing is now a release blocker :) | 14:56 |
| kgunn | dednick: not for mir, but phone v1 in general | 14:56 |
| Cimi | Saviq, I think you did this code while simplifying… my bad I approved the review | 14:57 |
| kgunn | dednick: let me know if you need any help with getting attention from folks | 14:57 |
| tsdgeos | MacSlow: are you going to do https://code.launchpad.net/~mterry/unity8/hide-greeter-on-app-launch/+merge/189948 or want me to? | 15:04 |
| kgunn | Saviq: so alf will need to manually merge https://code.launchpad.net/~afrantzis/qtubuntu/fix-1237052 into trunk since autolanding is off....right | 15:14 |
| Saviq | kgunn, yes | 15:14 |
| MacSlow | tsdgeos, I'm on it... although I'm not very familiar with the involved pieces... but if you feel you're faster go ahead. | 15:15 |
| tsdgeos | MacSlow: i'm as unfamiliar as you are if you're on it, don't want to step on your toes | 15:15 |
| MacSlow | tsdgeos, then leave it to me :) | 15:15 |
| kgunn | http://reports.qa.ubuntu.com/smokeng/saucy/touch_mir/mako/89:20131009.1:20131009.1/4639/ boom | 15:16 |
| MacSlow | kgunn, almost 77% doesn't sound so bad | 15:18 |
| MacSlow | kgunn, just hoping the remaining 23% aren't that hard to get too | 15:19 |
| kgunn | MacSlow: not too bad...but we got some big ones to chase...unity8 AP | 15:19 |
| MacSlow | kgunn, outch... didn't scroll down that far... 0% :/ | 15:20 |
| * mterry cradles unity8 AP's dying body | 15:24 | |
| dednick | kgunn: er. ok, thanks | 15:27 |
| kgunn | mterry: you can perform cpr on it if you like.... | 15:28 |
| kgunn | Saviq: actually, didn't we test unity8 AP ? | 15:28 |
| mterry | kgunn, I'm trying to run them on my device... | 15:28 |
| kgunn | thanks! | 15:28 |
| Saviq | kgunn, unity8 is crashing on exit | 15:29 |
| Saviq | kgunn, leaving the socket around | 15:29 |
| kgunn | geeze so picky | 15:29 |
| Saviq | kgunn, so only the first test ever passes | 15:29 |
| mterry | Saviq, the mir socket? Yeah, it likes to do that | 15:29 |
| mterry | really annoying | 15:29 |
| Saviq | kgunn, but the automation was supposed to take care of that for now | 15:29 |
| Saviq | kgunn, same as for powerd | 15:30 |
| kgunn | right the screen unblank thingy....thot so too | 15:30 |
| kgunn | hmmm | 15:30 |
| tsdgeos | dednick: https://code.launchpad.net/~nick-dedekind/unity8/indicator.submenu-reinit/+merge/187885 | 15:31 |
| kgunn | ok.... Saviq dednick tsdgeos Cimi MacSlow mterry dandrader nic-doffay ....want to hear what i learned about autolanding | 15:32 |
| tsdgeos | mterry: what do i do so that i appreciate the need for https://code.launchpad.net/~mterry/unity8/greeter-disable-draghandle/+merge/190158 ? | 15:32 |
| tsdgeos | kgunn: yep :-) | 15:32 |
| MacSlow | kgunn, shoot | 15:32 |
| kgunn | https://plus.google.com/hangouts/_/abb8a5dc8aa980cbd0e08e877b276b2b70fe6acb?pqs=1&authuser=0&hl=en | 15:32 |
| kgunn | join me here ^ it'll be better than typing | 15:32 |
| kgunn | Saviq dednick tsdgeos Cimi MacSlow mterry dandrader nic-doffay ^ | 15:33 |
| dandrader | kgunn, just a minute. have to turn on my laptop as google hangouts work only there | 15:34 |
| seb128 | dednick, hey, why are all those FramedMenuItem, BaseMenuItem, etc widget needed for the indicators (ted copied that for the settings, but it makes things look non standard UI elements) | 15:35 |
| seb128 | dednick, e.g making FramedMenuItem use a ListItem.Standard rather than a BaseMenuItem seems much nicer in the UI | 15:35 |
| mterry | tsdgeos, in a default image, enable mir, then do the dial-number 199 trick in the merge description while in the greete | 15:36 |
| mterry | r | 15:36 |
| mterry | tsdgeos, try to answer the phone, see that the phone never comes up | 15:36 |
| tsdgeos | mterry: hmmm, all that about https://code.launchpad.net/~mterry/unity8/greeter-disable-draghandle/+merge/190158 ¿ | 15:52 |
| dednick | seb128: it's been removed in the latest iteration, when i moved to ubuntu-settings-components | 15:52 |
| mterry | tsdgeos, oh god | 15:52 |
| mterry | tsdgeos, sorry | 15:52 |
| mterry | tsdgeos, I was still thinking of the branch from earlier this morning | 15:52 |
| dednick | seb128: but i havent switched over to it in unity8 | 15:52 |
| seb128 | dednick, k | 15:52 |
| mterry | tsdgeos, for the draghandle branch, follow the instructions in the bug | 15:52 |
| seb128 | dednick, is that using standard widgets? | 15:52 |
| seb128 | dednick, do you see an issue if we replace BaseMenuItem{} by a ListItem.Standard{} in FramedMenuItem? | 15:53 |
| === dandrader is now known as dandrader|lunch | ||
| seb128 | dednick, I'm just trying to make sure I don't screw up, I don't understand why the complexity/all those custom widgets | 15:53 |
| seb128 | dednick, is that only because indicators are non standard layouted UI (which is not the case of settings)? | 15:54 |
| dednick | seb128: there is no Base/Frame/etc in the new one. | 15:54 |
| dednick | only use Standard/Empty | 15:54 |
| seb128 | \o/ | 15:54 |
| seb128 | dednick, well, I'm looking at an easy fix for v1 | 15:54 |
| dednick | seb128: um. | 15:54 |
| seb128 | dednick, I doubt we are going to switch over to the new stuff this week | 15:54 |
| dednick | seb128: to fix what? | 15:55 |
| dednick | seb128: i think we're going to have to change back to a standard item for all settings. ListItem.Standard doesnt work in all cases. | 15:56 |
| seb128 | dednick, to fix http://ubuntuone.com/4vpeQcR3Wt7ycIEb4gIBFD | 15:56 |
| mterry | mzanetti, heyo! Did you look more at bug 1219871? I recall you were close to reproducing at will? | 15:56 |
| ubot5 | bug 1219871 in unity8 (Ubuntu) "when idle with screen blank, unity8 generates hundreds of context switches per second" [High,Confirmed] https://launchpad.net/bugs/1219871 | 15:56 |
| seb128 | dednick, the white lines between the wifis | 15:56 |
| seb128 | dednick, that should be a normal list, like in other panels which use ListItems | 15:57 |
| seb128 | dednick, not a weird gu(7) height list with white line between elements | 15:57 |
| dednick | seb128: hm. that's not per spec. check is supposed to be on left. I've already changed it in unity8 | 15:57 |
| seb128 | dednick, right, that's another stuff I want to fix | 15:57 |
| seb128 | dednick, I just don't understand the complexity behind and I preferred to ask what was the reason | 15:58 |
| seb128 | dednick, where did you fix the left/right issue? (I want to copy the fix) | 15:58 |
| dednick | seb128: right, well this was all done before styles had been done. It was just backlog of TODOs from ages ago. | 15:58 |
| seb128 | dednick, ok, no worry, we can clean that with the components soon | 15:59 |
| dednick | seb128: yeah, changes are in unity8. | 15:59 |
| seb128 | dednick, but for that release I just want easy tweaks | 15:59 |
| seb128 | dednick, thanks, I'm going to have a look | 15:59 |
| dednick | seb128: i'll get you the file link | 15:59 |
| seb128 | dednick, thanks! | 15:59 |
| dednick | seb128: http://bazaar.launchpad.net/~unity-team/unity8/trunk/view/head:/plugins/Unity/Indicators/Network/qml/AccessPoint.qml | 16:01 |
| seb128 | dednick, great | 16:02 |
| dednick | seb128: not sure how much has changed qith API since ted leeched it though | 16:02 |
| dednick | seb128: and as for the image: "qrc:/indicators/artwork/network/secure.svg"; it's been put in the ubuntu-mobile theme now ("network-secure"), I just havent changed the code to reflect that yet. | 16:04 |
| seb128 | ok | 16:04 |
| dednick | tedg: ping | 16:05 |
| tedg | dednick, Howdy | 16:05 |
| dednick | tedg: hey. I'm having trouble compiling indicator-network on device. missing gobject-introspection. But i have it installed. | 16:06 |
| dednick | tedg: pkg-config --variable=g_ir_scanner gobject-introspection-1.0 | 16:06 |
| dednick | returns nothing. | 16:06 |
| dednick | tedg: any idea? | 16:07 |
| tedg | dednick, apt-get build-dep indicator-network ? | 16:07 |
| dednick | tedg: done. doesnt help | 16:07 |
| tedg | dednick, Do you have a gobject-introspection-1.0.pc file? | 16:07 |
| tedg | dednick, It should be in libgirepository1.0-dev | 16:08 |
| dednick | tedg: ah. that would be it then | 16:08 |
| Cimi | Saviq, the scope files use a function getRenderer to decide the renderer | 16:08 |
| Cimi | Saviq, how do I pass the model count? | 16:09 |
| Saviq | mhr3_, you had an idea about that ↑? | 16:09 |
| Cimi | Saviq, I believe we don't have the count straight away right, we need the model of each category | 16:09 |
| Saviq | Cimi, not there, we need it to change live onCountChanged | 16:09 |
| Cimi | ah ok | 16:09 |
| dednick | tedg: yeah, that was it. Might need to add that to source deps. | 16:10 |
| Saviq | Cimi, so getRenderer would return an array of renderers maybe | 16:10 |
| Cimi | Saviq, yeah exactly | 16:10 |
| Saviq | Cimi, but the bigger problem is that we don't know how many | 16:10 |
| Cimi | Saviq, and we need an item in between | 16:10 |
| Saviq | Cimi, before we actually load the renderers | 16:10 |
| Saviq | Cimi, i.e. on tablet it's going to be 10 items - on phone just 6 | 16:10 |
| Saviq | for carousel to be useful - and it depends on orientation, too | 16:11 |
| Cimi | ok | 16:11 |
| om26er | There is a little problem with the category expansion in the new Image | 16:11 |
| om26er | expanding the Installed category does not show all the installed apps right away | 16:12 |
| seb128 | dednick, in the screenshot I pointed before, do you have any idea what puts the checkboxes from the non-aps items on the left? | 16:14 |
| seb128 | dednick, oh, also, do you know if there is a way to make the bottom entry a Caption rather than a Standard? | 16:15 |
| Cimi | Saviq, iirc carousel doesn't change number of displayed items on orientation changes | 16:15 |
| Cimi | Saviq, it just makes the carousel smaller | 16:15 |
| mhr3_ | Saviq, eek, let's not do count-based stuff at this point | 16:17 |
| dednick | seb128: that would likely be the StandardMenuItem | 16:18 |
| mhr3_ | Saviq, cause you know, we don't want to uncover yet another bug where the shell freezes and stuff :P | 16:19 |
| seb128 | dednick, that's identic to the unity8 one | 16:19 |
| seb128 | dednick, but yeah, it has a | 16:19 |
| seb128 | Components.CheckBox { | 16:19 |
| seb128 | anchors.verticalCenter: parent.verticalCenter | 16:19 |
| seb128 | anchors.left: parent.left | 16:19 |
| dednick | seb128: think i realised that was not needed with since the ListItem.Standard controlled position | 16:21 |
| dednick | seb128: i have no idea where that bottom menu comes from | 16:22 |
| seb128 | dednick, ok, I'm done annoying you with questions I think, thanks | 16:22 |
| om26er | bug 1237501 | 16:26 |
| ubot5 | bug 1237501 in unity8 (Ubuntu) "[Regression] Expanding Installed category does not show all the installed apps at once" [Medium,New] https://launchpad.net/bugs/1237501 | 16:26 |
| Cimi | Saviq, getRenderer will choose a root Item that will load the renderers | 16:30 |
| Cimi | Saviq, we will send this item the rendererId | 16:30 |
| Cimi | Saviq, internally it will decide the final renderer to load? | 16:31 |
| dednick | MacSlow: ping | 16:34 |
| davmor2 | MacSlow: Hey dude, so for me the maguro randomly gets slower and slower until pop nothing, You can have lots of apps open, 1 app open, or just be sliding a launcher out. The common factor seems to be you need to open and close apps so far | 16:35 |
| om26er | Saviq, hey! did you get the chance to play with the latest image ? There is a lot of disappearance <--> reappearance of categories going on there. | 16:35 |
| MacSlow | davmor2, ok... dednick was first :) | 16:36 |
| MacSlow | dednick, what' sup? | 16:36 |
| dednick | MacSlow: did you remove the ext snap decision type from unity-notifications? | 16:36 |
| MacSlow | dednick, yes... on Saviq's request... I updated the examples and related bits accordingly | 16:38 |
| dednick | MacSlow: nevermind. reasing the log for merge. | 16:38 |
| dednick | ok | 16:38 |
| davmor2 | MacSlow: no pressure on mine it's more of an observation while I try and find a specific set of steps | 16:42 |
| MacSlow | davmor2, sounds like a memory-issue of some sort | 16:43 |
| davmor2 | MacSlow: I'm thinking so too. | 16:43 |
| MacSlow | davmor2, maybe some leak... and since the bus on the GalaxyNexus' GPU isn't as wide as the one on the Nexus4 it shows pretty fast, if it starts swapping itself to death | 16:44 |
| === dandrader|lunch is now known as dandrader | ||
| davmor2 | MacSlow: camera killed it so now the phone is sat there doing the shutter tut at me constantly :D | 16:47 |
| MacSlow | davmor2, now only the battery in/out trick helps :) | 16:48 |
| MacSlow | davmor2, out/in rather | 16:48 |
| davmor2 | MacSlow: indeed :) | 16:48 |
| dednick | MacSlow: it's not working when using "x-canonical-snap-decisions", but is with "x-canonical-ext-snap-decisions". wtf? | 16:48 |
| davmor2 | MacSlow: we wont to hope it doesn't happen on the N4 it's a bit harder to remove the battery in that | 16:49 |
| MacSlow | dednick, what image are you using? | 16:49 |
| dednick | MacSlow: 86 i think. | 16:49 |
| dednick | MacSlow: but i've upgraded unity-notifications and unity8 | 16:50 |
| MacSlow | dednick, I've flashed today and used the examples from lp:unity-notifications trunk just 30 min ago and the three exmaples all worked | 16:50 |
| dednick | MacSlow: what do i need to install to get the examples working? neds gi | 16:50 |
| MacSlow | dednick, python-gi, gir1.2-notify-0.7, gobject-introspection | 16:50 |
| MacSlow | dednick, those should to the trick | 16:50 |
| dednick | MacSlow: ta | 16:51 |
| MacSlow | dednick, did you install lp:unity-notifications on the device and then did run_on_device with lp:unity8 ? | 16:51 |
| dednick | MacSlow: hm. yeah, the pinlock example worked for me. | 16:52 |
| MacSlow | davmor2, the battery in the N4 is soldered in, right? | 16:52 |
| MacSlow | dednick, password and user-auth also work | 16:52 |
| davmor2 | MacSlow: and a solid unit the back doesn't come off | 16:52 |
| MacSlow | davmor2, hm... some problems just need a tiny bit of raw force ;) | 16:53 |
| dednick | MacSlow: right, it's the actions. my sim unlock doesnt have any... | 16:54 |
| davmor2 | MacSlow: It's only a glass back, and you have a motorbike right? Pad out the front and get you to ride a cross country track should be able to access the battery with ease then :D | 16:55 |
| MacSlow | dednick, oh it shoudl :) | 16:55 |
| MacSlow | davmor2, or what's left of it | 16:56 |
| MacSlow | after that treatment | 16:56 |
| dednick | MacSlow: the "cancel" is part of the pin entry control, and the "ok" is automatic. | 16:56 |
| davmor2 | MacSlow: just thinking outside the box :D | 16:56 |
| davmor2 | MacSlow: if it is a memory thing though then the n4 has more memory any how | 16:57 |
| dednick | MacSlow: do you have design for the pin entry dialog? | 16:57 |
| MacSlow | dednick, no... just did best guessing | 16:57 |
| MacSlow | dednick, both actions (ok, cancel) need to be regular libnotify-actions | 16:58 |
| MacSlow | dednick, btw... I'm on Touch-image 89 iirc | 16:59 |
| dednick | MacSlow: but why do we need notification actions for it to be a snap decision? we can use actions from the model. | 17:00 |
| dednick | i dont understand why there is a contraint | 17:00 |
| dednick | *constraint | 17:00 |
| dednick | also that it must be an even number of actions? | 17:01 |
| MacSlow | dednick, it needs to have actions otherwise it would not pass as a snap-decision... especially if we don't have a dedicated ext. snap-decision type | 17:01 |
| MacSlow | dednick, "one" libnotify-action is always two strings (one label, one id) | 17:02 |
| Saviq | MacSlow, so that's wrong | 17:02 |
| dednick | MacSlow: i understand that it is not passing because it doesnt have the actions. But why does it require the actions as a part of the implementation? | 17:02 |
| Saviq | MacSlow, it shouldn't require actions from libnotify if there's the private-menu-model hint | 17:02 |
| MacSlow | Saviq, changing that right now isn't cheap... | 17:06 |
| dednick | MacSlow: it's cheaper than redesigning the pinpad. | 17:07 |
| MacSlow | Saviq, I currently don't know how this would work with getting correctly added into the queue. | 17:07 |
| Cimi | Saviq, lp:~unity-team/unity8/music-video_renderers | 17:07 |
| Saviq | Cimi, cool! | 17:07 |
| MacSlow | dednick, Saviq: so... no more reviews... but this change? | 17:07 |
| Cimi | Saviq, carousel not yet done | 17:07 |
| === alan_g is now known as alan_g|EOD | ||
| Saviq | MacSlow, who said no more reviews? | 17:08 |
| Saviq | MacSlow, we're just manual for the time being | 17:08 |
| Saviq | Cimi, separate branch or want us to merge that already? | 17:08 |
| Cimi | Saviq, I'm testing :P | 17:08 |
| Saviq | Cimi, k ;) | 17:08 |
| Cimi | Saviq, I disabled the portait | 17:08 |
| Cimi | Saviq, for movies | 17:08 |
| Cimi | still not sure when we want it | 17:09 |
| Saviq | Cimi, we don't | 17:09 |
| Saviq | Cimi, not at the moment | 17:09 |
| Cimi | Saviq, it works on my phone but looks bad | 17:09 |
| Saviq | Cimi, "it"? | 17:10 |
| Cimi | Saviq, video | 17:10 |
| Saviq | Cimi, why does it look bad? | 17:10 |
| Saviq | Cimi, and what does look bad | 17:11 |
| Cimi | Saviq, the texture | 17:11 |
| Cimi | I don't like it | 17:11 |
| Saviq | Cimi, does it look like the design? | 17:11 |
| MacSlow | dednick, so what's the SIM-unlock notification meant to look like? | 17:12 |
| dednick | MacSlow: same as example, without the buttons at the bottom | 17:12 |
| MacSlow | dednick, is there a mockup I don't know about... | 17:12 |
| dednick | MacSlow: nope. It'll probably change later. | 17:12 |
| MacSlow | dednick, Saviq: I've to think about the required changes and impact on this SIM-case... | 17:13 |
| MacSlow | dednick, Saviq: really thought that all these things were sorted | 17:14 |
| dednick | MacSlow: they were. but the ext type was removed. | 17:14 |
| dednick | it didnt have action constraint | 17:14 |
| Saviq | dednick, MacSlow, snap decisions should require actions *or* menumodel, that not good enough? | 17:15 |
| Saviq | dednick, MacSlow if it's easier to bring back the ext hint, let's do it - I just didn't know what's it use was | 17:15 |
| Saviq | and no one told me | 17:15 |
| dednick | MacSlow: what do you mean by impact? What other impact do actions have to the notification other than feedback to the caller. | 17:16 |
| dednick | ? | 17:16 |
| MacSlow | Saviq, not sure... I want to think about it and not rush any decision... gut-feeling says I rather stick just with the snap-decision | 17:16 |
| Cimi | Saviq, ok I aligned text and fixed some padding, looks better now | 17:23 |
| MacSlow | Saviq, so any snap-decision notification passing in a menu-model is assumed/required to provide their own actions? Leaving them out is meant to be regarded as invalid and be rejecetd by the queue? Just want to be sure we agree upon what the change should incorporate. | 17:24 |
| Saviq | MacSlow, I think it should be either actions or menu-model | 17:24 |
| Saviq | MacSlow, or and/or menu-model, for that matter | 17:24 |
| Saviq | MacSlow, so either is required, but both are supported at the same time | 17:25 |
| dednick | Saviq, MacSlow: I have it all working now. | 17:25 |
| MacSlow | so( libnotify)actions, (libnotify) actions and menu-model, menu-model (with own actions) | 17:26 |
| dednick | MacSlow: shall I propose branches to unity8/unity-notifications and you can check them over to see if i missed anything? | 17:26 |
| MacSlow | dednick, ok... but I'll do that tomorrow... I'm pretty worn out atm... and I don't want to overlook anything... | 17:26 |
| Saviq | MacSlow, yes, at least one of them needs to be there | 17:27 |
| Saviq | MacSlow, dednick there might be just one important thing there | 17:27 |
| Saviq | MacSlow, dednick triggering libnotify actions closes the notification | 17:27 |
| Saviq | MacSlow, dednick if there is none - the app would need to handle it | 17:27 |
| dednick | Saviq: yeah. i know. I close manually on cancel action. | 17:27 |
| dednick | from model i mean | 17:28 |
| MacSlow | dednick, using the close-handler? | 17:28 |
| dednick | MacSlow: yeah, Notification.close(). | 17:29 |
| Cimi | Saviq, https://code.launchpad.net/~unity-team/unity8/music-video_renderers/+merge/190198 | 17:30 |
| Cimi | mhr3_, ^ | 17:30 |
| Saviq | Cimi, coolio | 17:30 |
| Saviq | Cimi, link to the bug(s) please | 17:30 |
| mhr3_ | Cimi, noooooo! i just wanted to go eat... now i can't | 17:30 |
| Cimi | lol | 17:30 |
| Cimi | mhr3_, that's why I work from the kitchen ;) | 17:31 |
| MacSlow | dednick, when you push your branches regarding these changes can you ping me via email or so... | 17:31 |
| mterry | MacSlow, sorry, was off IRC for a few minutes, but got your email | 17:31 |
| mhr3_ | Cimi, that's a good idea, but assumes that there's some food in my kitchen :) | 17:32 |
| dednick | MacSlow: yup | 17:32 |
| Cimi | mhr3_, ocado | 17:32 |
| MacSlow | mterry, np... I'm off and be doing reviews on dednick's branches regarding the notification-changes I mention in the email tomorrow... maybe I still can get back to your branch after that. | 17:32 |
| MacSlow | dednick, thanks | 17:33 |
| mhr3_ | Cimi, nah, i'm old fashioned, heading out to actual shop now, your branch will have to wait :) | 17:33 |
| mterry | MacSlow, oh yeah... that compile error is weird. You need to remove the touch version of qtmultimedia, because it has some incomplete diverts | 17:33 |
| mterry | guh, you disappeared | 17:33 |
| mterry | If anyone has review cycles to spare, I need eyes on my receive-call-in-greeter branch... | 17:39 |
| Saviq | mterry, looks like unity8 ap on Mir are failing due to: CrossFadeImage.qml:126:5: QML QQuickImage: Cannot open: file:///build/buildd/unity8-7.82+13.10.20131008.1/graphics/phone_background.jpg | 17:42 |
| Saviq | mterry, any idea how could that happen? | 17:42 |
| mterry | Saviq, maybe... | 17:43 |
| Saviq | mterry, added points: why does it pass on the first test in an ap run, but not subsequent ones? | 17:43 |
| mterry | Saviq, the mock is probably using a hardcoded buildtime path | 17:43 |
| mterry | Saviq, that I'm not sure.. | 17:43 |
| Saviq | mterry, right, but then it should fall back to the default image shouldn't it? | 17:43 |
| Saviq | mterry, so maybe it's actually not why it's failing... | 17:44 |
| * Saviq needs more debugging | 17:44 | |
| mterry | Saviq, that is the default image | 17:44 |
| mterry | Saviq, ./mocks/AccountsService/AccountsService.cpp uses TOP_SRCDIR | 17:44 |
| Saviq | mterry, ah | 17:44 |
| mhr3_ | Cimi, it changes just the grids, not the carousels? | 17:44 |
| Saviq | mterry, but wait - there is a fallback in QML | 17:45 |
| mterry | Saviq, when I suppose it should try to detect whether it is in local run or system run | 17:45 |
| Saviq | mterry, and anyway... | 17:45 |
| Saviq | mterry, background is loaded | 17:45 |
| mterry | Saviq, there should be. That shouldn't be a crashing problem | 17:45 |
| Saviq | mterry, but Greeter.created never gets true | 17:45 |
| * mterry looks | 17:46 | |
| Saviq | mterry, you'll want https://code.launchpad.net/~saviq/unity8/remove-socket-in-ap-tests/+merge/190175 | 17:46 |
| Cimi | mhr3_, no carousels | 17:47 |
| Saviq | mterry, and run PYTHONPATH=tests/autopilot/ autopilot run -v unity8.shell.tests.test_hud.TestHud.test_hide_hud | 17:47 |
| Saviq | mterry, there's two tests, the latter of which will fail... | 17:47 |
| mterry | Saviq, OK | 17:47 |
| * Saviq builds unity8 on mako, too | 17:47 | |
| mterry | Saviq, locally? or on the device? | 17:47 |
| Saviq | mterry, on Mir | 17:47 |
| mterry | Saviq, like, do I need mir for this? | 17:47 |
| mterry | I'm guessing so | 17:48 |
| mterry | ok | 17:48 |
| Saviq | mterry, well, I didn't try on SF | 17:48 |
| Saviq | mterry, but I think we'd know if it failed on SF too | 17:48 |
| mhr3_ | Cimi, the left-alignment is a bit odd when you use it in tablet mode, but otherwise looks exactly like specced | 17:48 |
| mterry | dandrader, do you have any review cycles? | 17:49 |
| Cimi | mhr3_, didn't try tablet | 17:49 |
| dandrader | mterry, is a small and friendly patch? | 17:50 |
| dandrader | is it | 17:50 |
| * Cimi -> bed to relax | 17:50 | |
| Cimi | dead | 17:50 |
| mterry | dandrader, nope, it's hard to test, involving 7 different packages totoal | 17:50 |
| * dandrader knows he must be kidding | 17:50 | |
| dandrader | mterry, so, what is it? | 17:51 |
| mterry | dandrader, actually, just 5. A bargain | 17:51 |
| mterry | dandrader, https://code.launchpad.net/~mterry/unity8/hide-greeter-on-app-launch/+merge/189948 | 17:51 |
| mterry | dandrader, it's the bug preventing us from accepting incoming calls when the greeter is up | 17:51 |
| kgunn | mterry: oh snap...guess that's gonna be a must | 17:52 |
| mterry | kgunn, right. It's marked as a v1 bug | 17:52 |
| kgunn | mterry: so, are the changes all manually merge (/me cringes just asking) | 17:53 |
| kgunn | mterry: or you need review/test first | 17:53 |
| mterry | kgunn, of the 5 needed, only 3 haven't merged yet (unity8, telephony-service, dialer-app) | 17:53 |
| dandrader | mterry, well, your bug trumps mine (lp1236489). so reviewing your stuff now | 17:53 |
| mterry | kgunn, I've reviewed / approved telephony-service and dialer-app, but they are waiting on final approval | 17:54 |
| mterry | kgunn, need unity8 bit done by someone else | 17:54 |
| mterry | dandrader, hah | 17:54 |
| mterry | dandrader, maybe I can trade review tasks? | 17:54 |
| kgunn | there you go...a victi...i mean volunteer | 17:54 |
| mterry | dandrader, really though you should blame macslow for begging off earlier to do a different bug | 17:54 |
| mterry | (with cause, I'm not blaming him, just saying that if you want revenge, go at him :)) | 17:55 |
| Saviq | dandrader, so you want to separate the keyboard rotation fix? | 17:58 |
| Saviq | dandrader, and get this merged first? | 17:58 |
| dandrader | Saviq, yes | 17:58 |
| Saviq | dandrader, k, building | 17:58 |
| mterry | Saviq, building that branch, will be able to test in a bit | 18:00 |
| mterry | Saviq, (the remove-socket branch to test the greeter.created thing) | 18:00 |
| Saviq | mterry, no real need to build, but yeah - easier to debug when you can edit locally and push | 18:01 |
| Saviq | using run_on_device | 18:01 |
| Saviq | if only hud wasn't dying all the time ;/ | 18:05 |
| Saviq | mterry, ah wait! | 18:11 |
| Saviq | mterry, it's the other way 'round | 18:11 |
| mterry | Saviq, hm? | 18:12 |
| Saviq | mterry, it's failing 'cause greeter isn't *destroyed* | 18:12 |
| Saviq | mterry, i.e. it doesn't swipe it away - seems we're losing ap input after the first run | 18:12 |
| mterry | Saviq, heh, OK... I'm not super familiar with Qml lifecycles. What normally destroys it? | 18:12 |
| mterry | Saviq, you mean hidden or destroyed? | 18:12 |
| Saviq | mterry, it's not QML lifecycles - we destroy it when hidden | 18:13 |
| Saviq | mterry, to save resources | 18:13 |
| mterry | Saviq, oh really? Ok | 18:13 |
| Saviq | mterry, we unset the Loader's source, basically | 18:13 |
| mterry | Saviq, is that a normal Qml thing or a unity8 optimization? | 18:13 |
| mterry | Saviq, ah OK. I never noticed that | 18:13 |
| Saviq | mterry, optim | 18:13 |
| Saviq | mterry, we're not doing enough of that across unity8 | 18:13 |
| Saviq | to keep mem usage down | 18:13 |
| mterry | Saviq, truth | 18:14 |
| mterry | Saviq, so OK. Is that just a missing swipe call in autopilot or is there a real bug? | 18:14 |
| mterry | presumably this works in SF... which makes me think bug | 18:14 |
| Saviq | mterry, yeah, bug *somewhere* | 18:15 |
| Saviq | mterry, but not in unity8 at least | 18:15 |
| mterry | Saviq, right. I see both tests do add a call to swipe away the greeter at the start. So you're saying one of those swipes doesn't take? | 18:17 |
| Saviq | mterry, well, do you see it taking? ;) | 18:17 |
| Saviq | mterry, if you drag it yourself, it will go further | 18:17 |
| Saviq | mterry, and fail on the next input | 18:17 |
| Saviq | like tapping on an item in the dash or something | 18:18 |
| mterry | that sounds familiar. I think we had the same symptom earlier this cycle | 18:18 |
| Saviq | indeed | 18:19 |
| Saviq | when we were first enabling the dashboard | 18:19 |
| === dandrader is now known as dandrader|afk | ||
| === dandrader|afk is now known as dandrader | ||
| thomi | morning | 19:09 |
| Saviq | hey tho | 19:13 |
| Saviq | mi | 19:13 |
| kgunn | thomi \o/ | 19:19 |
| * thomi ducks for cover | 19:19 | |
| davmor2 | thomi: we can see you, you're under the table, at least hide when you duck for cover ;) | 19:27 |
| thomi | :-/ | 19:27 |
| dandrader | mterry, while reviewing your MP I came across this: http://paste.ubuntu.com/6215196/ in tests/qmltests/tst_Shell.qml:159 | 19:43 |
| dandrader | I was puzzled | 19:43 |
| dandrader | because the use of tryCompareFunction there is useless | 19:43 |
| dandrader | as mainApp will get a copy of the value in ApplicationManager.focusedApplicationId; | 19:44 |
| dandrader | mterry, so querying it again will never yield different results | 19:44 |
| dandrader | i.e., it's not a qml property bind | 19:45 |
| mterry | dandrader, looking | 19:47 |
| mterry | dandrader, we don't query it again. We later test that ApplicationManager.focusedApplicationId is returned to the original value (mainApp) | 19:48 |
| mterry | dandrader, I guess your question was about tryCompareFunction. I suppose it could just be an assertEqual | 19:48 |
| dandrader | mterry, exactly | 19:49 |
| mterry | Or NotEqual as the case may be | 19:49 |
| mterry | dandrader, agreed that I was high when I wrote that | 19:49 |
| mterry | dandrader, but it's still accurate, just convoluted | 19:49 |
| dandrader | mterry, sure. if you could take the opportunity and clear that up in your MP as it changes code nearby | 19:51 |
| mterry | dandrader, OK | 19:51 |
| mterry | dandrader, oh I remember why. I didn't know a better way to test not-equals in QML | 19:53 |
| mterry | dandrader, there doesn't seem to be a compareNot without using a function | 19:54 |
| mterry | it's not like python with its million specialized assert methods | 19:54 |
| dandrader | something like assert(ApplicationManager.focusedApplicationId != "") | 19:55 |
| dandrader | mterry, is enough | 19:55 |
| dandrader | although I don't recall the exact syntax of the "assert" function... | 19:56 |
| dandrader | s/syntax/name | 19:56 |
| mterry | dandrader, I recall it being compare(), but that takes two arguments, not one | 19:56 |
| mterry | Saviq, is there a function for qmltests that acts like python's self.assertNotEqual? | 19:57 |
| mterry | Saviq, I'm currently using tryCompareFunction to get the same effect, but surely there is something prettier | 19:58 |
| dandrader | mterry, compare(ApplicationManager.focusedApplicationId != "", true) | 19:59 |
| dandrader | not perfect but better | 19:59 |
| Saviq | verify | 19:59 |
| Saviq | not compare | 19:59 |
| Saviq | ? | 19:59 |
| dandrader | aha! | 19:59 |
| Saviq | ah that | 19:59 |
| Saviq | but | 19:59 |
| Saviq | dandrader, but I think mterry wants to make sure stuff don't change within some timeout | 19:59 |
| Saviq | dandrader, mterry, I'd experiment with expectFail(); tryCompare() | 19:59 |
| mterry | Saviq, no in this case, just an instantaneous compare | 20:00 |
| dandrader | Saviq, no, he doesn't. that's the whole point | 20:00 |
| Saviq | mterry, then yeah, verify(a != b) | 20:00 |
| mterry | Saviq, awesome, thanks | 20:00 |
| mterry | dandrader, pushed as r414 | 20:02 |
| dandrader | mterry, thanks! | 20:04 |
| kgunn | Saviq: was MacSlow supposedly reviewing https://code.launchpad.net/~nick-dedekind/unity8/simunlock.dialog/+merge/190211 | 20:07 |
| mterry | kgunn, Saviq: speaking of reviewing, I have review cycles now if we have something we want to squeeze in | 20:11 |
| kgunn | mterry: it'd be awesome if you could review this...altho, as for test, do you have a lockable sim? | 20:13 |
| kgunn | us U.S. guys usually don't | 20:13 |
| mterry | kgunn, nope! | 20:14 |
| mterry | just a boring normal sim | 20:14 |
| mterry | I'll leave that for MacSlow then | 20:14 |
| kgunn | mterry: how about htis one https://code.launchpad.net/~saviq/unity8/remove-socket-in-ap-tests/+merge/190175 | 20:24 |
| kgunn | this would be good to land asap | 20:24 |
| mterry | sure | 20:24 |
| kgunn | just ping me when approved.... | 20:24 |
| mterry | that will fix most AP tests, eh | 20:24 |
| kgunn | yes sir | 20:25 |
| dandrader | mterry, what am I missing? http://paste.ubuntu.com/6215361/ | 20:25 |
| dandrader | maybe I have to apt-get dist-upgrade.... | 20:26 |
| mterry | dandrader, you will get an error. But I think I got a different one | 20:27 |
| mterry | dandrader, pitti's instructions said you get an error, then a little later you get a call. Which I found to be true | 20:27 |
| mterry | dandrader, but if I had restarted unity8 in the session, it didn't work anymore. Seemed like I had to restart ofono too or something | 20:27 |
| mterry | dandrader, so I would just reboot when ofono got broken like that | 20:28 |
| mterry | dandrader, but I don't recall the UnknownMethod error, I think it was a different one | 20:28 |
| mterry | dandrader, so maybe try dist-upgrading and rebooting | 20:28 |
| === salem_ is now known as _salem | ||
| dandrader | mterry, so I have to install my unity8 build then | 20:29 |
| dandrader | if I cannot restart it | 20:29 |
| mterry | dandrader, I only tested with installed unity8. The problem with restarting unity8 wasn't 100% consistent. But I generally found if I stopped it, the dial script didn't work anymore | 20:30 |
| dandrader | mterry, ok. good to know | 20:30 |
| mterry | dandrader, sorry, I had forgotten about that bit too. Getting into the position where I could test this branch was harder than I remember :) | 20:32 |
| mterry | dandrader, will add comment to MR | 20:32 |
| dandrader | damn, and I'm past my EOD already... | 20:32 |
| Cimi | Saviq, kgunn all the failures I see on CI, is due to mir? | 20:33 |
| mterry | dandrader, sorry. Maybe MacSlow or tsgeos can pick it up later | 20:33 |
| Cimi | obviously we didn't have time to ask for surfaceflinger | 20:33 |
| Cimi | isnit it? | 20:33 |
| Saviq | Cimi, only if they happen on mako or maguro | 20:34 |
| Saviq | Cimi, which ones? | 20:34 |
| kgunn | Cimi: link? | 20:34 |
| Cimi | https://code.launchpad.net/~unity-team/unity8/music-video_renderers/+merge/190198 | 20:34 |
| Cimi | maguro indeed | 20:34 |
| Cimi | oh yeah, I broke the tests :D | 20:35 |
| Cimi | filter grid at least | 20:35 |
| Cimi | weird though | 20:35 |
| * Cimi fixes | 20:36 | |
| mterry | Saviq, are parts of the phone using XDG_RUNTIME_DIR/mir_socket yet? I thought we were still on /tmp/mir_socket | 20:37 |
| Saviq | mterry, we are, but bug #1236912 | 20:38 |
| ubot5 | bug 1236912 in apparmor-easyprof-ubuntu (Ubuntu Saucy) "please use XDG_RUNTIME_DIR instead of /tmp for mir_socket" [High,Triaged] https://launchpad.net/bugs/1236912 | 20:38 |
| Saviq | mterry, let's be ready ;) | 20:38 |
| Saviq | mterry, already merged | 20:38 |
| mterry | Saviq, ah OK. I had a branch making that change staged, but thought it was only needed once we went to USC and a split greeter. Didn't know about the apparmor problem | 20:39 |
| * Cimi fixed | 20:40 | |
| mterry | Hrm, interesting. In the sprint in lexington, we agreed to not change it in Mir, but to do it as a configuration thing in ubuntu-touch-session, so as not to stop the demo instructions from working | 20:40 |
| mterry | Ah well | 20:40 |
| mterry | Saviq, I'm not seeing it being placed in either location.... not in /run/user/32011 or /tmp... | 20:44 |
| Saviq | mterry, sure you running under mir? | 20:45 |
| Saviq | /tmp/mir_socket is it currently | 20:45 |
| Saviq | mterry, oh interesting | 20:45 |
| mterry | Saviq, nope, I'm not sure! :) I remember, I changed to SF to test a system-setting thing | 20:46 |
| Saviq | mterry, ah, right, mine isn't there 'cause I built mir from trunk | 20:46 |
| Saviq | mterry, it's there in /run/user/32011/mir_socket, though | 20:47 |
| mterry | Saviq, I'm sure it is, I just needed to switch to mir | 20:47 |
| Saviq | :) | 20:47 |
| mterry | Saviq, this only tries the /tmp fallback if XDG_RUNTIME_DIR isn't set, which is unlikely | 20:53 |
| Saviq | mterry, right | 20:53 |
| Saviq | mterry, fixing | 20:53 |
| mterry | kgunn, so I don't have a current reviewer for my branch. Next person that pings you with open time, sock it to 'em. https://code.launchpad.net/~mterry/unity8/hide-greeter-on-app-launch/+merge/189948 | 20:57 |
| Saviq | mterry, pushed | 20:58 |
| mterry | kgunn, this is the receive-a-call-in-greeter bug | 20:58 |
| Saviq | mterry, dandrader reviewed it? ah but EOD'd? | 20:58 |
| Saviq | mterry, pushed fix | 20:58 |
| mterry | yeah | 20:58 |
| mterry | Saviq, ok, looking | 20:58 |
| mterry | Saviq, probably don't need the /tmp fallback for XDG anymore then | 21:00 |
| mterry | Saviq, so things are better... Good enough for now I guesss. But running the full suite seems to have got me hung on a black screen | 21:04 |
| Saviq | mterry, well, I need to fall back to *something* | 21:04 |
| fginther | Saviq, unity8 jobs keep failing otto because of a missing dependency on "libunity-mir1" | 21:04 |
| Saviq | mterry, or I could except for TypeError | 21:04 |
| mterry | Saviq, fair enough. Easier to do /tmp twice than add an if for xdg | 21:05 |
| Saviq | fginther, probably need to release unity-mir then | 21:05 |
| fginther | Saviq, :-) | 21:05 |
| Saviq | fginther, or! | 21:05 |
| Saviq | fginther, otto not using mbs again ;( | 21:05 |
| Saviq | fginther, ah well | 21:06 |
| Saviq | fginther, autolanding | 21:06 |
| Saviq | fginther, we don't have autolanding - we don't have mbs | 21:06 |
| Saviq | fginther, so yes, unity-mir needs releaseing | 21:06 |
| Saviq | -e | 21:06 |
| fginther | Saviq, is that package supplied by unity-mir? | 21:07 |
| Saviq | fginther, yes | 21:07 |
| fginther | Saviq, thanks, something weird is going on | 21:07 |
| fginther | looking into it | 21:07 |
| Saviq | fginther, isn't there a >> for libunity-mir1? | 21:07 |
| Saviq | fginther, or maybe libunity-mir1 is not installable for some other dependency reasons? | 21:08 |
| Saviq | fginther, right, no version required from our side | 21:08 |
| fginther | Saviq, I'll debug this to see what's up | 21:09 |
| Saviq | fginther, yeah, libunity-mir1 is uninstallable due to some deps probably | 21:12 |
| boiko | Saviq: hey, is the desktop file's X-Screenshot tag support already merged/released in unity? | 21:13 |
| Saviq | boiko, it's the scope that needs to read it - and no, not as far as I know | 21:14 |
| boiko | Saviq: ah ok, do you by chance know where that code lives? | 21:14 |
| Saviq | boiko, http://code.launchpad.net/applications-lens | 21:14 |
| boiko | Saviq: thanks | 21:14 |
| Saviq | boiko, erm | 21:14 |
| Saviq | boiko, https://code.launchpad.net/unity-applications-lens | 21:14 |
| Saviq | aaargh | 21:14 |
| boiko | lol | 21:15 |
| Saviq | https://launchpad.net/unity-lens-applications | 21:15 |
| Saviq | HERE | 21:15 |
| mterry | Saviq, kgunn: approved on that branch | 21:15 |
| boiko | Saviq: thanks :) | 21:15 |
| Saviq | mterry, thanks, merging, or am I? | 21:15 |
| kgunn | mterry: ta | 21:15 |
| mterry | Saviq, ah you can, I have a shitty connection right now | 21:15 |
| Saviq | mterry, on ~mterry/unity8/hide-greeter-on-app-launch - I agree with dandrader's comment - setFocused could be named better | 21:19 |
| mterry | Saviq, renaming right now | 21:21 |
| mterry | Saviq, updated | 21:24 |
| Saviq | mterry, thanks | 21:24 |
| mterry | Saviq, do we not want that mir_socket fix in unity8 itself? | 21:29 |
| jose | hey mterry! have a minute? | 21:29 |
| Saviq | mterry, yes, we want to not crash ;) | 21:29 |
| mterry | jose, I do! | 21:29 |
| Saviq | mterry, as it's cleared by libmirserver, but stuck if we're crashing | 21:29 |
| mterry | Saviq, I mean, I assume we want something in Mir for that | 21:29 |
| jose | mterry: how's life? long time no see! just wanted to confirm if you guys are still hosting a weekly Q&A with Unity Developers in here | 21:30 |
| mterry | jose, oh I'm not the person to know... Saviq? ^ | 21:30 |
| Saviq | mterry, we *could* think of trying to find out whether it's stale and remove it on startup | 21:30 |
| mterry | jose, I'm doing well though :) | 21:30 |
| jose | good to hear | 21:30 |
| Saviq | mterry, jose, not on my watch :) but I'd gladly do something like that | 21:30 |
| jose | Saviq: it's been listed on the fridge calendar for a long time know, no idea if it was still hosted | 21:31 |
| jose | if you're not, I can just delete it, however, if you want to resume those I can leave it in the cal | 21:31 |
| mterry | Saviq, I think it'd be reasonable, in Mir to do that when it tries to make the file. Mir could even be fancy about it and see if anyone is using the socket first, using fuser or similar, I bet | 21:31 |
| Saviq | mterry, https://bugs.launchpad.net/ubuntu/+source/mir/+bug/1235159 | 21:32 |
| ubot5 | Ubuntu bug 1235159 in mir (Ubuntu) "Mir fails to start if there's a stale socket" [Medium,Triaged] | 21:32 |
| Saviq | mterry, so yeah, there's many levels where we could "work around this" | 21:32 |
| mterry | Saviq, beautiful. Did I also hear that the unblank error is due to powerd? | 21:33 |
| Saviq | mterry, powerd + mir somewhere, yes - not sure really | 21:33 |
| Saviq | mterry, https://bugs.launchpad.net/ubuntu/+source/mir/+bug/1235000 | 21:33 |
| ubot5 | Ubuntu bug 1236525 in unity-mir "duplicate for #1235000 unity8 killed/crash then restart can result in mir unable "could not unblank display"" [Critical,Triaged] | 21:33 |
| Saviq | jose, is it scheduled for a set time now? | 21:33 |
| jose | hmm, it says 18 UTC each friday | 21:33 |
| jose | Saviq: ^ | 21:34 |
| Saviq | jose, that's 8pm for me at least, so not gonna happen if I'm to be there ;) | 21:35 |
| Saviq | jose, we (unity8 devs) are mostly EU timezones | 21:35 |
| Saviq | jose, so something on that side of the pond timezone-wise would be preferred | 21:36 |
| jose | Saviq: what do you think if I just delete the meeting until we can agree with a timezone that fits for everyone? | 21:36 |
| jose | so maybe you're not the only dev in here :) | 21:36 |
| jose | also, we can move it to ubuntuonair.com, for it to be more dynamic | 21:36 |
| Saviq | jose, sure, | 21:36 |
| Saviq | jose, do I talk to you to make it happen? | 21:37 |
| jose | then I'll come around here next week and see what can we agree on :) | 21:37 |
| jose | Saviq: yeah, I'm the one who manages ubuntuonair too | 21:37 |
| Saviq | jose, great, thanks | 21:37 |
| jose | want to talk about it now? | 21:37 |
| Saviq | jose, not really, coming up 12am here... | 21:37 |
| jose | next week then | 21:37 |
| jose | see you, and thanks again! | 21:37 |
| Saviq | jose, thanks! | 21:37 |
| === jhodapp is now known as jhodapp|afk | ||
| thomi | kdub_: ping? | 23:19 |
| kdub_ | thomi, pong | 23:19 |
| thomi | kgunn: kdub_: I managed to reproduce the "unity8 goes slow" bug | 23:19 |
| thomi | on mako | 23:19 |
| thomi | and after running "echo performance > /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor" | 23:20 |
| thomi | it's better, but obviously still pretty messed up | 23:20 |
| kdub_ | thomi, we've split that bug into two | 23:20 |
| kdub_ | this is the one tracking the power management https://bugs.launchpad.net/powerd/+bug/1233257 | 23:20 |
| ubot5 | Ubuntu bug 1233257 in powerd "[mako] waking from deep sleep, phone is pretty slow, takes a few seconds to get back to normal speed" [High,Fix committed] | 23:20 |
| kdub_ | and this one https://bugs.launchpad.net/ubuntu/+source/mir/+bug/1235190, i'm tracking down an improvement that might help | 23:21 |
| ubot5 | Ubuntu bug 1235190 in mir (Ubuntu Saucy) "[mako] Scrolling and animations are very slow with Mir" [High,Confirmed] | 23:21 |
| thomi | kdub_: ok, this happened after running AP test suites, i don't think it's related to sleeping the phone | 23:21 |
| thomi | ahh, sounds like I need the second one | 23:21 |
| thomi | kdub_: are you looking at that second bug? | 23:22 |
| kdub_ | yep, tracking down some improvements | 23:22 |
| kdub_ | within mir | 23:22 |
| thomi | anything I can do to help? | 23:22 |
| thomi | otherwise I'll reboot this phone to get a usable test system again | 23:24 |
| kdub_ | thomi, no, i have to dig within mir for a while | 23:24 |
| kdub_ | thanks though :) | 23:25 |
| thomi | ok, cool | 23:25 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!