| huwshimi | hatch: I don't think we have an asset for that ellipsis yet, so maybe you can crop it out of the mockup for now | 00:00 |
|---|---|---|
| gary_poster | hatch, for the source view, "Nice tests. LGTM with additional text I mention. qa good. Thank you!" | 00:07 |
| gary_poster | huwshimi, I think I don't have any bundle tasks for you today. Are you choosing one from your backlog? | 00:08 |
| huwshimi | gary_poster: I'm just adding the icon to the bundle charm details panel and trying to get showing/hiding working and then I'll move to the backlog | 00:08 |
| hatch | gary_poster: thanks :) | 00:08 |
| hatch | huwshimi: damn why won't you guys let me use UNICODE!!!!!! … … … … … | 00:09 |
| hatch | lol | 00:09 |
| gary_poster | huwshimi, sounds perfect. thanks! hatch, notice huwshimi is trying to do that part of what we talked about, but there's still other bits | 00:09 |
| gary_poster | hatch, huwshimi, running away. ttyl and thanks! | 00:09 |
| hatch | enjoy! | 00:10 |
| huwshimi | gary_poster: Have a good evening :) | 00:10 |
| huwshimi | hatch: You can use unicode if you can make it look like the mockup :) | 00:10 |
| hatch | lol | 00:10 |
| hatch | deal! | 00:10 |
| huwshimi | hatch: (hint, you won't be able to) :) | 00:10 |
| hatch | ok I'm going to be taking over from where you leave off on that panel so don't forget to push your changes up :) | 00:10 |
| hatch | haha | 00:10 |
| huwshimi | hatch: Yep, nearly done here | 00:11 |
| hatch | oh haha cool | 00:15 |
| huwshimi | hatch: What does scene inside events mean "events: { scene: {"? | 00:20 |
| huwshimi | hatch: This is inside topology/bundle.js | 00:21 |
| bcsaller | huwshimi: event bindings | 00:23 |
| huwshimi | bcsaller: how does that differ to our usual bindings which just live inside 'events' without the scene? | 00:24 |
| bcsaller | they are mapped to d3's event system | 00:24 |
| bcsaller | part of the topology system, the docs on d3-components go over this, should be in the docs dir | 00:25 |
| huwshimi | bcsaller: Ah I see | 00:25 |
| huwshimi | I'll take a look, thanks | 00:25 |
| huwshimi | bcsaller: So how do I get the event from a scene event? | 00:30 |
| bcsaller | huwshimi: you mean in the handler? | 00:30 |
| bcsaller | often you don't need to, 'this' is the DOM element and the 1st arg is the bound model that was triggered, but if you need the event d3.event should be correct | 00:31 |
| huwshimi | bcsaller: yeah, I want to do a "[event].halt()" | 00:31 |
| bcsaller | d3.event.halt() then | 00:32 |
| huwshimi | bcsaller: Forgive my ignorance, the d3 in that case is the first function parameter of the handler? | 00:34 |
| bcsaller | d3 is a global | 00:34 |
| bcsaller | d3.event is also global, js is single threaded so there can only be one event at a time | 00:35 |
| huwshimi | bcsaller: Heh, yeah, I just figured that out :) | 00:35 |
| huwshimi | bcsaller: Thanks for that, this is working now :) | 00:36 |
| bcsaller | great | 00:36 |
| huwshimi | hatch: That branch is now proposed, so once that lands you are good to go. | 00:46 |
| bac | hi rick | 11:12 |
| bac | rick_h_: i mean | 11:12 |
| bac | rick_h_: when you're around could you review the changes that benji asked for in https://code.launchpad.net/~bac/charmworld/update-branch/+merge/190229 . he's marked it approved but i think the lander will want the new revision approved too. on interesting change is adding 'lint' to 'make check' | 11:14 |
| rick_h_ | bac: looking | 11:47 |
| rick_h_ | bac: cool approved | 11:50 |
| rick_h_ | bac: the new landing from jenkins doesn't care about the new revs ime but cool to peek | 11:50 |
| rick_h_ | bac: marked approved and watching staging whee | 11:51 |
| bac | thanks rick_h_. i'll write a commit message and then it should go. | 11:52 |
| rick_h_ | oh oops, hah | 11:52 |
| bac | done | 11:52 |
| rick_h_ | bac: hmm, CI isn't picking it up. Are you a member of juju-jitsu? | 12:12 |
| rick_h_ | looks like you are | 12:13 |
| rick_h_ | abentley isn't around yet to ask about it. He was changing stuff with it the other day | 12:14 |
| bac | rick_h_: do you have any insight into the lander? or just been watching the MP? | 12:37 |
| rick_h_ | bac: I was watching jenkins | 12:38 |
| rick_h_ | bac: the way things are working now jenkins pulls the branch on its own | 12:39 |
| rick_h_ | bac: so since it's not loading it, I'm guessing it's due to recent changes. It was working for my branches earlier this week | 12:39 |
| rick_h_ | abentley should be around in the next hour to ask about it. | 12:39 |
| rick_h_ | he'll probably want to test something :) | 12:40 |
| bac | rick_h_: ok. abentley said it runs every minute so we'll just have to wait | 12:40 |
| bac | for him to appear and enlighten us | 12:40 |
| rick_h_ | yea | 12:40 |
| rick_h_ | gary_poster: around for one-one or bypass this week? | 12:41 |
| gary_poster | rick_h_, sorry trying to wrap up | 12:41 |
| rick_h_ | gary_poster: np | 12:41 |
| bac | hi abentley, when you have a chance could you look into why the lander is not picking up my branch, reviewed and approved at https://code.launchpad.net/~bac/charmworld/update-branch/+merge/190229 ? | 12:54 |
| gary_poster | rick_h_, ok now :-P | 12:54 |
| gary_poster | benji, will be late :-/ | 12:54 |
| benji | gary_poster: np | 12:55 |
| abentley | bac: I will. Thanks for pointing it out. | 12:55 |
| bac | thanks | 12:55 |
| frankban | gary_poster: added "Charm details link not working correctly" to urgent | 13:07 |
| gary_poster | frankban, thank you | 13:07 |
| abentley | bac: That issue turned out to be a config issue where a list was expected but a string was supplied. | 13:09 |
| abentley | bac: The previous code was using "if x in y", so it didn't notice that y was a string, not a collection. | 13:10 |
| adeuring | bac, benji, abentley: could one of you review this mp: https://code.launchpad.net/~adeuring/charmworld/use-charmtools-tarball/+merge/190361 ? | 13:14 |
| benji | adeuring: I'll take a look. | 13:14 |
| adeuring | thanks | 13:14 |
| bac | abentley: so is the lander working on a queue of branches? i see gary's is up now. | 13:19 |
| abentley | bac: It's not an explicit queue, it just finds the first thing it can land and tries landing it. | 13:20 |
| bac | abentley: oh, i see my MP is marked merged. cool. | 13:21 |
| bac | abentley: does the lander update the charmworld revno on staging automatically now? | 13:35 |
| abentley | bac: yes. | 13:36 |
| bac | oh, cool. i was just about to do it manually. hey is the process documented somewhere so i can quit bugging you with dumb questions? | 13:36 |
| bac | abentley: ^^ | 13:37 |
| abentley | OTP | 13:38 |
| abentley | benji: Your canary work is preventing download-cache from being updated, which means that adeuring's branch cannot land: http://162.213.35.27:8080/job/charmworld-autoland-lxc/28/console | 14:00 |
| benji | :( | 14:01 |
| abentley | bac: So, the first question wasn't dumb at all-- I had misconfigured the lander as part of the change I announced yesterday. That's a one-time thing. | 14:03 |
| gary_poster | benji do you need to address that or can we talk now? | 14:03 |
| abentley | bac: What sort of documentation would be helpful? | 14:04 |
| benji | gary_poster: I don't know. abentley: do you want me to address that issue? | 14:04 |
| abentley | benji: Could you please discuss it with adeuring, figure out a solution, and then one of you can implement it? | 14:04 |
| benji | abentley: sure | 14:05 |
| benji | gary_poster: I'll ping you when I'm available (or we can postpone) | 14:05 |
| rick_h_ | anthonydillon: sorry for the delay. If you get back around let me know and can walk you through it | 14:05 |
| bac | gary_poster: our call is now. or are you talking to benji first? | 14:05 |
| abentley | benji: Thanks. | 14:05 |
| gary_poster | benji, ack | 14:05 |
| adeuring | benji: well, I'd like to land my last branch sooner or later ;) It's not a matter of minutes, of course | 14:05 |
| gary_poster | bac, are you available now? | 14:05 |
| bac | i am | 14:06 |
| gary_poster | bac, let's do it | 14:06 |
| benji | abentley: does the lander update a long-lived checkout or build a new one every time? | 14:06 |
| abentley | benji: It updates a long-lived checkout. | 14:06 |
| benji | :( | 14:06 |
| benji | It would be better to do fresh checkouts every time (not just for issues like this, but it's better hygiene in general). | 14:07 |
| abentley | benji: Makefiles wouldn't be necessary if we didn't use long-lived source trees. | 14:07 |
| * benji ponders that assertion. | 14:08 | |
| abentley | benji: If you were always building from scratch, you wouldn't want a dependency system, you'd want a traditional script. | 14:08 |
| benji | true, but no one ever *always* builds from scratch | 14:09 |
| abentley | benji: So ideally, build-from-scratch and incrementally-update-and-build should both work. We could test both. I'm not convinced one is better than the other. | 14:11 |
| benji | yep both should definately work; build-from-scratch must work, otherwise we just have software that only exists in a usable form on particular had disks scatered across the planet :) | 14:13 |
| benji | from my perspective incrementally-update-and-build is a nicity that -- given the limitations of make -- can never be truely achieved | 14:14 |
| abentley | benji: But incrementally-update is trickier, so I think that's the one worth testing. | 14:14 |
| benji | I disagree. From-scratch must work, so it must be tested. | 14:15 |
| benji | (if it's not tested, it doesn't work, and all that) | 14:15 |
| abentley | benji: I disagree. We have a vcs, so we can incrementally build every revision starting with revno 1 if necessary, so build-from-scratch is no more necesary than incremental. | 14:17 |
| benji | I've already stated my rebuttle to that argument, and I need to work on the issue at hand. | 14:18 |
| abentley | benji: I don't see a rebuttal. I just introduced a new argument. | 14:20 |
| benji | I may have misunderstood. We can talk about it once I've addressed the immediate issue. | 14:20 |
| luca__ | gary_poster: is there a url flag so we can see Bundles and Ice-cream? | 14:28 |
| rick_h_ | bac: http://staging.jujucharms.com/charms/precise/juju-gui/json looks good and complete! | 14:32 |
| rick_h_ | bac: so I think we'll call this case closed with your branch fix? | 14:32 |
| abentley | benji: I think the syntax on "then : bzr up download-cache" may be malformed. I think the colon is preventing execution of the "bzr up". | 14:33 |
| bac | cool rick_h_, OTP | 14:33 |
| rick_h_ | bac: k | 14:33 |
| frankban | guihelp: I need 1 review + 1 QA for https://codereview.appspot.com/14439054 . Is anyone available? thanks! | 14:33 |
| benji | abentley: hmm, I'll take a look at that | 14:33 |
| hatch | frankban: I can | 14:33 |
| frankban | hatch: thanks | 14:34 |
| gary_poster | frankban, had a good conversation about quickstart with rick_h_ . should share with you | 14:34 |
| gary_poster | maybe after our daily call | 14:35 |
| frankban | gary_poster: sounds good | 14:35 |
| bac | rick_h_: just looked, yep it does look good. | 14:36 |
| benji | abentley: I think you're right. | 14:39 |
| abentley | benji: I know that colon is a do-nothing in some contexts. e.g. ": echo foo" does not echo. | 14:40 |
| adeuring | benji: , abentley: yes, that seems to be the problem. I'll remove the ':' in my branch. | 14:41 |
| benji | yeah, it is for evaluating expressions for their side-effects | 14:41 |
| benji | that's how I'll make my millions: an easy way to test make files | 14:42 |
| benji | so... this works in dev because pip actually downloads the file from the Internet; we should disable that so dev matches the IC/prod enviroment | 14:44 |
| benji | gary_poster: ok, I'm ready for a call whenever | 14:44 |
| gary_poster | thanks benji. arranged it in calendar | 14:45 |
| benji | k | 14:46 |
| benji | I retract that. pip didn't download from the internet. | 14:48 |
| hatch | frankban: still spinning up core to qa - will hopefully have it all tested in 20minss | 14:52 |
| frankban | hatch: cool | 14:52 |
| hatch | ORDER PLACED: Oct. 1 2013 DELIVERY ESTIMATE: Friday Oct. 25 2013 - Friday Nov. 1 2013 by 8:00pm | 14:54 |
| hatch | NOOOOOOO amazon why do you hate me so | 14:54 |
| rick_h_ | hatch: lol | 14:55 |
| rick_h_ | hatch: gotta go prime baby | 14:55 |
| hatch | haha I'm guessing the book isn't in stock | 14:55 |
| hatch | that's even slow for their usual Canadian dogsled delivery team | 14:55 |
| hatch | I was thinking of going prime, but I can't remember the last time I paid for shipping | 14:56 |
| adeuring | abentley: my branch failed again. Do I understand the report right that lint errors are considered bad too? | 15:03 |
| rick_h_ | adeuring: that was a recent change bac included | 15:06 |
| hatch | frankban: I'm hoping it's still switching to your branch - but it's been rejecting my connections for a while now | 15:06 |
| rick_h_ | adeuring: make check now checks lint as well | 15:06 |
| hatch | and of course | 15:06 |
| hatch | there it goes | 15:06 |
| hatch | lol | 15:06 |
| rick_h_ | hatch: it takes a while | 15:06 |
| rick_h_ | hatch: I ran into that yesterday with Makyo's branch | 15:06 |
| adeuring | rick_h_: thanks. I was just not sure if missed something | 15:06 |
| rick_h_ | adeuring: naw, we're shifting the sand beneath your feet :) | 15:06 |
| adeuring | ;) | 15:07 |
| abentley | adeuring: That's how it looks. I'm just running a make target. | 15:07 |
| bac | adeuring: yes, that just landed. i should've announced it but it came out of a discussion we had yesterday, after your EOD | 15:07 |
| abentley | adeuring: I'm just running "make check". Whatever's in that target will run. | 15:07 |
| frankban | hatch: on ec2 "juju debug-log" can help. if you are using the local provider, then you can just "tailf ~/.juju/local/log/unit-juju-gui-0.log" | 15:07 |
| hatch | ahh I should do that from now on | 15:08 |
| hatch | yeah using local provider | 15:08 |
| hatch | done | 15:09 |
| hatch | sorry forgot to type LGTM ;) | 15:09 |
| frankban | :-) | 15:09 |
| hatch | hmm the card I was working on is gone | 15:10 |
| hatch | ohh huw stole it | 15:10 |
| bac | there is a new fitbit out that allows you to check the time of day, right on your wrist! revolutionary! | 15:13 |
| hatch | bac: HAHA I was JUST thinkign the same thing | 15:13 |
| hatch | lol | 15:13 |
| bac | i sure hope they patent that wrist-mounted time display | 15:13 |
| hatch | I think it would clash with my watches | 15:14 |
| abentley | hatch: How many watches do you wear at a time? | 15:14 |
| hatch | one - but none are digital or silicone :) | 15:15 |
| abentley | rick_h_: You said bootstrap-dropdown isn't working. I remember the tools dropdown working. How long has it not been working? | 15:16 |
| rick_h_ | abentley: oh, I just know we had JS that was never wired up. I didn't realize that it was working tbh | 15:16 |
| * rick_h_ shrinks my window really small | 15:16 | |
| frankban | gary_poster: should I add a card in urgent to remember us to make a new charm release after we release the GUI? | 15:16 |
| gary_poster | frankban, yes thank you | 15:17 |
| rick_h_ | abentley: no idea. If it's meant to work then I'll try to track history on it and see why it's 404'ing then. | 15:17 |
| abentley | rick_h_: Not very important functionality, and if it's been disabled for a while, no rush to restore it. | 15:22 |
| rick_h_ | abentley: I think this was work when huw moved the ui to be with ubuntu style guidelines | 15:22 |
| rick_h_ | abentley: all of bootstrap is removed so removing the file. | 15:23 |
| bac | bcsaller: i see export is now using blob urls. did that just happen? sadly safari cannot handle them. | 15:31 |
| rick_h_ | bac: or benji got a sec for a tiny review please? https://code.launchpad.net/~rharding/charmworld/jc-bundle/+merge/190396 | 15:32 |
| bac | rick_h_: yes | 15:32 |
| rick_h_ | ty | 15:32 |
| hatch | gary_poster: is where huw left the bundle topology details popup where we want to leave it for now? | 15:34 |
| gary_poster | hatch, hey. yeah, meant to highlight that to you. I think we could add next/prev, but lower priority. later | 15:35 |
| hatch | ok cool - so I'll do the charms panel now? | 15:35 |
| bcsaller | bac: I believe that has been there for some time. There are very few options for generating downloadable files in the browser. When did safari make the supported list? | 15:35 |
| bac | bcsaller: it hasn't but there have been discussions. | 15:36 |
| bac | bcsaller: it was more of a sad-face comment than something than a bug. | 15:36 |
| rick_h_ | bac: bcsaller there was a thread about supporting it recently though I don't think it made the official list | 15:37 |
| rick_h_ | safari that is | 15:37 |
| bcsaller | bac: with the server doing exports now we can generate a url there and get more support, but with fakebackend and so on I think the blob stuff is still a good option | 15:37 |
| rick_h_ | hatch: those icons in the bundle looking purdy | 15:39 |
| hatch | rick_h_: I know right? For the amount of crap I give you about the tokens it was sure easy to implement :P | 15:40 |
| hatch | but don't tell rick_h_ I said that | 15:40 |
| hatch | it'll go to his head | 15:40 |
| rick_h_ | hatch: :) yea hopefully you're finding that once you get past learning the 'rules' the browser stuff isn't as horrible as it seems | 15:40 |
| rick_h_ | hatch: if not then shush no one asked you anyway :P | 15:41 |
| hatch | lol | 15:41 |
| hatch | did you get a chance to look into that attribute issue last night? | 15:41 |
| bac | rick_h_: done | 15:41 |
| hatch | I didn't :/ | 15:41 |
| rick_h_ | hatch: no, I was busy trying to implement chrome 'add to homescreen' to my own app. :P | 15:42 |
| rick_h_ | bac: ty much kind sir! | 15:42 |
| hatch | rick_h_: hah - hard to do? | 15:42 |
| rick_h_ | hatch: no, it just hates me and won't give me the pretty icon on the home screen I wanted | 15:42 |
| rick_h_ | hatch: and then started redoing the chrome extension without any framework bits | 15:43 |
| hatch | ahh cool cool | 15:43 |
| rick_h_ | so no, I didn't play with the ATTR setter thing at all. off time and all that :) | 15:43 |
| hatch | haha | 15:44 |
| hatch | those triangles still look weird to me | 15:44 |
| rick_h_ | hatch: +1 | 15:44 |
| hatch | http://comingsoon.jujucharms.com/precise/juju-gui-77/#bws-related-charms | 15:44 |
| hatch | on the details page they even look worse | 15:44 |
| hatch | they looked good in the mockups | 15:45 |
| hatch | I don't know why not here | 15:45 |
| rick_h_ | hatch: can you find the mockups? I was looking trying to find some wireframe to see what we're missing but all the wireframe/visuals i can find in google docs have the * | 15:45 |
| hatch | hmm | 15:45 |
| rick_h_ | hatch: because I'm kind of with you. I've never been a big fan but I don't remember it looking this 'off' | 15:46 |
| hatch | rick_h_: https://drive.google.com/a/canonical.com/#folders/0B7XG_QBXNwY1NEtGaHJYZGM4enM the button states png | 15:48 |
| hatch | I think it's because on the bundle token it had more 'stuff' to fill in the whitespace | 15:48 |
| rick_h_ | hatch: yea, and not really in context for things like the related charms/etc | 15:48 |
| rick_h_ | many things look ok in isolation, but in context... | 15:48 |
| rick_h_ | hatch: the background colors of the tokens isn't right either. | 15:49 |
| gary_poster | jujugui call in 10! | 15:50 |
| rick_h_ | hatch: oh nvm | 15:50 |
| gary_poster | hah! | 15:50 |
| Makyo | jujugui call in 10 | 15:50 |
| hatch | lol | 15:50 |
| rick_h_ | hatch: we don't have the hover color change | 15:50 |
| Makyo | Darn :) | 15:50 |
| rick_h_ | Weekly Numbers: Makyo - 3; gary_poster - 1 | 15:50 |
| gary_poster | my shining moment | 15:50 |
| rick_h_ | :P | 15:50 |
| gary_poster | :-) | 15:50 |
| gary_poster | hey benji, did you have the call with mark b? did he get back to us? I've been a bit swamped | 15:51 |
| benji | gary_poster: he never got back to us (that I saw) | 15:51 |
| gary_poster | ok | 15:51 |
| gary_poster | too bad | 15:52 |
| gary_poster | hey jujugui, somebody give the second review of bcsaller's https://codereview.appspot.com/14485046/ so he can land it! | 15:53 |
| hatch | on it | 15:53 |
| gary_poster | thanks hatch | 15:53 |
| gary_poster | Makyo, that branch should replace some but not all of my branch that I shared with you yesterday evening . We can talk about details later if you want | 15:54 |
| hatch | gary_poster: to QA just drag the deployer file? | 15:54 |
| Makyo | gary_poster, alright, just going through the annotations stuff now. It is annotation, but I need to make sure which ones need changing. | 15:54 |
| gary_poster | cool thanks Makyo | 15:55 |
| gary_poster | hatch, I think verifying that export has x-y annotations again is the core qa element. bcsaller, am I right? | 15:56 |
| gary_poster | hatch, drag deployer file might not yet work still until we have my change--or at least my change makes it more reliable | 15:56 |
| bcsaller | gary_poster: actually its a little trickier than that for a reason that caught me, the gui-x/y didn't make it back to the client models before, but even once it started working I couldn't tell at first because we delete them as soon as we apply them in the draw code | 15:57 |
| hatch | yeah it fails | 15:57 |
| bcsaller | I spent a while on that in the "this should be working stage" | 15:57 |
| hatch | can't dd the wp-deployer.yaml | 15:57 |
| bcsaller | that worked for me last night, testing | 15:57 |
| bcsaller | and the tests import that all the time | 15:58 |
| hatch | Object {err: "[object Object]", DeploymentId: undefined} | 15:58 |
| hatch | ohh | 15:58 |
| gary_poster | the way we handle next in the go sandbox is broken without my branch <shrug> | 15:58 |
| hatch | manage.jujucharms.com doesn't have mysql-26 or wordpress-15 | 15:58 |
| Makyo | jujugui call in 2 | 15:58 |
| gary_poster | hatch try benji's | 15:59 |
| gary_poster | might work | 15:59 |
| gary_poster | but gui will always miss the first delta returned to it until my branch lands | 15:59 |
| bac | rick_h_: i just put both of our faces on the release card. first one to it tomorrow wins. | 16:04 |
| rick_h_ | bac: cool, see you at noon :P | 16:04 |
| bac | :) | 16:04 |
| bcsaller | hatch: the dnd import has issues with the charmworldv3 flag, works without, seeing if there is a simple resolution | 16:19 |
| hatch | cool thanks - yeah that should probably be fixed heh | 16:24 |
| bcsaller | hatch: it appears to be an issue with not having backfilled charms in api3, if I set the revision in the import to current it works fine, but it gets 'no such charm' for older version in the bundle | 16:28 |
| hatch | ohhh ok cool | 16:29 |
| hatch | I'll qa without the flag | 16:29 |
| rick_h_ | bcsaller: yep, benji is working on that so hopefully made better soon | 16:32 |
| hatch | bcsaller: so I drag it to the canvas, it lays out in a certain 'layout' then it snaps to a different layout on the next delta | 16:33 |
| hatch | bcsaller: so I add 3 services, relate them, lay them out, export, refresh, import - layout is different | 16:36 |
| hatch | does that mean that QA is no good? | 16:37 |
| bcsaller | hatch: There is an issue with export, its using the client db, and we delete the position annotations, when we apply them. It should either use an env call to get its YAML or we can't delete env. Either of those are non-trivial changes | 16:38 |
| hatch | ok so as long as the export file has the annotations we are good? | 16:38 |
| bcsaller | hatch: yes, but it won't the way its setup now. | 16:39 |
| bcsaller | the server and the client both get the annotation | 16:39 |
| bcsaller | thats what this branch fixed | 16:39 |
| bcsaller | but then the client deletes the position | 16:39 |
| bcsaller | so more changes are required | 16:39 |
| hatch | oh ok so there is no way to qa this | 16:41 |
| hatch | because the export doesn't contain the xy annotations | 16:41 |
| bcsaller | the export should have position, that isn't what I was verifying before | 16:41 |
| hatch | hmm | 16:41 |
| bcsaller | maybe that should be another branch, but I could do it here | 16:41 |
| hatch | yeah it's definitely not in there | 16:42 |
| bcsaller | yes, are you reading what I'm saying? does it not make sense? :) | 16:42 |
| rick_h_ | hatch: lol anthonydillon got bit by double dispatch. "Yep, we know about that one" :) | 16:42 |
| hatch | lol | 16:42 |
| bcsaller | itit gets set on the client, applied and then removed by the client | 16:43 |
| bcsaller | and then we use the client db for the export | 16:43 |
| bcsaller | which no longer has it | 16:43 |
| anthonydillon | rick_h_, Good to know :) | 16:43 |
| hatch | ok then because you just said it should have it haha | 16:43 |
| hatch | so I was confused | 16:43 |
| bcsaller | it does have it, but then it removes it when used. so it has it only till it draws it in the right position | 16:44 |
| hatch | no the file does not have the xy positions | 16:44 |
| bcsaller | ahh, right | 16:44 |
| hatch | which makes sense from what you're saying | 16:44 |
| hatch | I think we were just talkign around eachother haha | 16:44 |
| bcsaller | yeah, the wire protocol was broken before | 16:44 |
| bcsaller | hatch: so this is a real fix and I'd like to land it. The solution to the other problem should be another branch. Ideally that would be the server doing the export but that really means core support. Because we don't have that I need to look at a) not deleting the position on application (which might be a big change) or b) polling the position on client generated export (which is best but another branch) | 16:48 |
| bcsaller | I guess that means the export deployer call can take an optional topology to ask for position info during the export | 16:49 |
| hatch | it's lgtm'd | 16:50 |
| hatch | hmm | 16:50 |
| hatch | well we really need a way to export the xy's - without it they won't be able to make layouts for the bundles | 16:51 |
| hatch | I guess I don't understand where we are deleting the annotations on export | 16:51 |
| bcsaller | hatch: not on export, on draw | 16:52 |
| hatch | but they aren't in the export either | 16:52 |
| bcsaller | how could they be, they were deleted from the model on draw ^^ | 16:52 |
| hatch | so we delete them from the model, waiting for the delta to re-populate? | 16:53 |
| bcsaller | I can explain it in a hangout if you'd like | 16:53 |
| hatch | yeah I think that's best haha | 16:54 |
| bcsaller | too much typing | 16:54 |
| bcsaller | :) | 16:54 |
| hatch | allll cleared up! | 17:01 |
| gary_poster | bcsaller, (b) is very high priority then, yeah? Because exporting x/y is very important | 17:03 |
| gary_poster | sounds pretty easy? | 17:03 |
| bcsaller | gary_poster: it is, and its my next task, should be about an hour | 17:04 |
| gary_poster | mm, no, middlin | 17:04 |
| gary_poster | ok awesome | 17:04 |
| hatch | hmm the inspector no longer shows the unit count on comingsoon | 17:12 |
| hatch | could someone else confirm this for me? | 17:12 |
| hatch | deploy a service with 10 units, the inspector after deploy will show 0/0 | 17:12 |
| rick_h_ | shows 0 until I set 10 then it updates to 10 running | 17:13 |
| rick_h_ | now I can't change it :/ | 17:13 |
| rick_h_ | the units field got disabled? | 17:14 |
| rick_h_ | so after you set the number of units, the field gets disabled | 17:14 |
| rick_h_ | hatch: only doing it on the first one deployed to me | 17:15 |
| rick_h_ | hatch: once I close it and deploy a new service the count works and doesn't show 0 | 17:16 |
| rick_h_ | hatch: I'm qa'ing on juju trunk and not seeing it, but ther'es already a charm in the env (the gui charm) | 17:20 |
| hatch | hmm | 17:20 |
| hatch | this is a critical bug | 17:21 |
| hatch | Makyo: before release we need to fix ^ | 17:21 |
| hatch | oh wait | 17:21 |
| hatch | is comingsoon running an old version? | 17:21 |
| rick_h_ | no idea | 17:21 |
| hatch | nope | 17:21 |
| hatch | frankban: your branch landed right? | 17:22 |
| frankban | hatch: yes | 17:22 |
| hatch | the handle for the side bar is under the charm details on comingsoon | 17:22 |
| rick_h_ | hatch: the minimize tab? | 17:22 |
| hatch | I wonder if comingsoon needs a 'make clean-all && make' | 17:22 |
| hatch | yeah | 17:22 |
| rick_h_ | hatch: yea, ther's a bug for that | 17:22 |
| rick_h_ | hatch: filed that one the other day | 17:23 |
| hatch | frankban fixed it | 17:23 |
| hatch | rick_h_: do you know how to log into comingsoon and re-make it? | 17:23 |
| rick_h_ | hatch: no, bac and gary_poster have access | 17:24 |
| bac | hatch: what's up? | 17:24 |
| hatch | can you clean-all and make comingsoon ? | 17:24 |
| bac | hatch: sure | 17:24 |
| hatch | it doesn't appear to be running the latest code | 17:24 |
| hatch | thanks | 17:24 |
| rick_h_ | hatch: https://bugs.launchpad.net/juju-gui/+bug/1234321 | 17:24 |
| _mup_ | Bug #1234321: the minimize tab should have a higher z-index than the inspector charm details <juju-gui:Triaged> <https://launchpad.net/bugs/1234321> | 17:24 |
| rick_h_ | hatch: that's not what he did, is this what you mean? | 17:25 |
| hatch | rick_h_: yes - frankban fixed that in his last branch | 17:25 |
| rick_h_ | hatch: oh, didn't realize that. | 17:25 |
| frankban | rick_h_: ah, didn't know there was a bug | 17:25 |
| rick_h_ | frankban: all good, updating now. Thanks for the fix! | 17:26 |
| hatch | yeah comingsoon is very broken compared to local trunk | 17:26 |
| hatch | but it does disable the unit scale still | 17:26 |
| rick_h_ | hatch: yea, I'm filing that bug as my QA bug :) | 17:26 |
| hatch | haha deal! | 17:26 |
| hatch | make a critical card too plz | 17:27 |
| hatch | we can't release with that | 17:27 |
| rick_h_ | hatch: rgr | 17:27 |
| rick_h_ | hatch: noooooo https://bugs.launchpad.net/juju-gui/+bug/1236427 | 17:27 |
| _mup_ | Bug #1236427: Scale up input stops working after units are added/removed <juju-gui:Triaged> <https://launchpad.net/bugs/1236427> | 17:27 |
| rick_h_ | frankban: beat me to it | 17:27 |
| hatch | lol | 17:28 |
| frankban | :-) | 17:28 |
| rick_h_ | hatch: card added though | 17:28 |
| gary_poster | benji, https://plus.google.com/hangouts/_/55ecf5ce6f3c3ad26992f6b8bb2db173e572ffb6 if you can | 17:31 |
| benji | gary_poster: coming | 17:31 |
| bac | jujugui: reminder, monday is a US holiday: http://theoatmeal.com/comics/columbus_day | 17:55 |
| hatch | bac: lol that comic was funny | 17:56 |
| gary_poster | lol thanks bac | 17:56 |
| hatch | I don't know how much of that is true but if it is that's funny | 17:58 |
| hatch | bac: so which holiday are you going to enjoy? :) | 18:09 |
| bac | hatch: dunno, i may work and take off the friday after thanksgiving. haven't decided. | 18:10 |
| hatch | our thanksgiving is monday | 18:10 |
| benji | gary_poster: laptop battery died; back in a second | 18:13 |
| gary_poster | ok benji | 18:13 |
| marcoceppi | rick_h_: I've updated the blueprint with the response stuff, https://blueprints.launchpad.net/charm-tools/+spec/charm-bundle-support | 18:13 |
| rick_h_ | Makyo: do we have a bug about the canvas jumping on your while pending units are coming up? | 18:14 |
| hatch | bcsaller: kickin around? I have a databinding question | 18:14 |
| bcsaller | hatch: yeah | 18:14 |
| hatch | quick hangout? | 18:14 |
| rick_h_ | marcoceppi: cool, I'd rather keep thigns lower case and spelled out so will do error, warning, information | 18:14 |
| Makyo | rick_h_, only new services; it should center new services. | 18:14 |
| marcoceppi | rick_h_: fine by me | 18:14 |
| rick_h_ | marcoceppi: ah ok, so I' deployed a secnod service, it went into pending. I moved the canvas over to see everything, and then it jumped back to center the new one coming up still | 18:15 |
| rick_h_ | errr Makyo ^^ | 18:15 |
| rick_h_ | Makyo: rinse/repeat | 18:15 |
| rick_h_ | Makyo: then, once it's up and running, it seems to stop trying to force center | 18:15 |
| Makyo | rick_h_, okay. File a bug please.. | 18:16 |
| rick_h_ | Makyo: will do. | 18:17 |
| rick_h_ | Makyo: marking high but really not sure if it's really low. Low seems to be where things would go to die sometimes | 18:19 |
| Makyo | rick_h_, High is fine. If it comes up I can retriage. Still trying to sort diffs. | 18:19 |
| bac | hatch: i forgot to ask, did the 'make clean' on comingsoon clear up the problems you were seeing? | 18:30 |
| hatch | checking | 18:30 |
| rick_h_ | bac: yep, change dto 610 | 18:30 |
| bac | great | 18:31 |
| hatch | bac: yep that's working now - still have the unit issue | 18:31 |
| hatch | but tha'ts a separate bug | 18:31 |
| hatch | thanks | 18:31 |
| bac | np | 18:31 |
| hatch | wonder why it didn't rebuild the css | 18:31 |
| rick_h_ | hatch: did you file that then? I did not as I could not dupe that in my juju-core-lxc env I'm qa'ing in | 18:31 |
| hatch | oh I thought it already was | 18:31 |
| hatch | ok will file | 18:32 |
| rick_h_ | hatch: wait, what unit bug? | 18:32 |
| * rick_h_ thinks hatch and him are crossing wires | 18:32 | |
| hatch | comingsoon > deploy mysql > inspector will show 0/0 for units | 18:32 |
| rick_h_ | hatch: ok yea is that an existing bug then? I wasn't aware of it. | 18:32 |
| rick_h_ | hatch: can you dbl check/file? | 18:32 |
| hatch | if you enter a value other than 1 in the ghost it will change to that number after the next delta | 18:33 |
| hatch | if it's still1 then it'll be 0 | 18:33 |
| hatch | yep I'll file/card it | 18:33 |
| gary_poster | hatch, rick_h_ , sorry, known bug, I gave fix to Makyo | 18:34 |
| rick_h_ | man this upgrade service thing is killing me | 18:34 |
| Makyo | hatch, rick_h_ gary_poster already has a diff I'm trying to get in there. | 18:34 |
| hatch | ohh ok cool | 18:34 |
| rick_h_ | Makyo: ah ok cool | 18:34 |
| * hatch closes bug window | 18:34 | |
| * rick_h_ didn't catch that was the diff in question | 18:34 | |
| hatch | gary_poster: Makyo does this also fix the disabled unit input bug? | 18:34 |
| Makyo | My bad. | 18:34 |
| gary_poster | hatch no | 18:35 |
| gary_poster | hey guys I need to take off. thanks all, and I'll see some of you with Huw. | 18:35 |
| hatch | alright I'll leave that one there | 18:35 |
| hatch | cya | 18:35 |
| rick_h_ | Makyo: heads up, sent some more feedback to luca/-peeps on the upgrade. Let me know if any of that is nuts or doesn't make sense. | 18:41 |
| Makyo | rick_h_, ah, yeah. I don't think it'd be too hard to have a [current revision] for whichever version or whatever. | 18:48 |
| Makyo | Another time, though | 18:49 |
| bac | hi rick_h_, in charmworld it looks like you made a change recently about how icons are served up. do you have a sec to talk about it? | 18:59 |
| hatch | bcsaller: is this waht you had in mind? https://gist.github.com/hatched/55964a4dfae5de925e27 | 19:13 |
| hatch | bcsaller: I ask because I now get the reported error whenever trying to open anything into that slot again | 19:14 |
| bac | benji, gary_poster: we currently are using the default icon for all bundles. is that a temporary thing? | 19:16 |
| benji | yeah, I would think so | 19:17 |
| bac | benji: as is, if the bundle has an icon we substitute the default. if it has no icon then it gets nothing, rather than the default. | 19:21 |
| benji | heh, that's probably not what was intended | 19:22 |
| hatch | lunching | 19:37 |
| bac | benji: would you have time to review https://code.launchpad.net/~bac/charmworld/bundle-icon-path/+merge/190470 | 20:07 |
| benji | bac: sure | 20:07 |
| Makyo | jujugui Current status, two bugs in sandbox: when deploying a service, you get 1 of [0] units when the inspector opens the first time, opens to 1 of [1] units each time after. Also the field disabled after changing unit count. Any others? | 20:09 |
| Makyo | (trying these in lxc next) | 20:09 |
| benji | bac: the branch looks good; I saw a couple of very small things | 20:11 |
| bac | benji: great, thanks | 20:11 |
| bcsaller | hatch: I think the diff looks good, what error are you seeing? | 20:39 |
| bac | hey benji would you re-approve https://code.launchpad.net/~bac/charmworld/bundle-icon-path/+merge/190470 ? it was stated early that the new lander didn't care about new revisions but it very much does. | 20:40 |
| hatch | bcsaller: just got back from lunch sorry | 20:40 |
| bac | s/early/earlier today/ | 20:40 |
| hatch | so I fixed the issue I had mentioned - but the original issue still remains, so I'm going to be tracking on that now | 20:40 |
| hatch | it appears that for some reason the viewlet in updateDOM is the unitDetails viewlet and not the charmDetails one | 20:41 |
| hatch | so going to have to track that one back | 20:41 |
| hatch | I know that diff is working because the bindings length now goes up when you open the panel and then returns back to the original when closed | 20:41 |
| gary_poster | Makyo, sounds good. you mean you have those two fixed? If so, do you want to go ahead and get those landed? I can try to get them through for you if that helps. | 20:42 |
| bcsaller | hatch: don't all the viewlets still update? You'd see them all | 20:42 |
| hatch | the unitDetails viewlet is closed | 20:42 |
| hatch | but for some reason updateDOM is being called on it | 20:42 |
| hatch | when I try and open the charmDetails viewlet | 20:42 |
| Makyo | gary_poster, those are left. Checking more on a real env | 20:42 |
| bcsaller | hatch: close is different than a hidden tab how? cause those are kept up to date too | 20:42 |
| gary_poster | Makyo, I think hatch fixed your #2? | 20:43 |
| gary_poster | "the field disabled after changing unit count" | 20:44 |
| Makyo | Oh? Maybe I'm a little out of date, then. | 20:44 |
| hatch | bcsaller: the left tabs we remove the content from the DOM | 20:45 |
| hatch | at least that's what the code shows | 20:45 |
| gary_poster | Makyo, could be completely confused. wait to see if hatch confirms/denies | 20:45 |
| hatch | sorry reading the backlog | 20:45 |
| gary_poster | bug 1236427 | 20:45 |
| _mup_ | Bug #1236427: Scale up input stops working after units are added/removed <juju-gui:Triaged> <https://launchpad.net/bugs/1236427> | 20:45 |
| hatch | that one still exists | 20:45 |
| hatch | I am working on the charm details one | 20:46 |
| hatch | I don't know if there is a bug for mine - it's not on the card | 20:46 |
| Makyo | That one as well. Had assumed it was a misbound event was all :( | 20:47 |
| benji | bac: I think you just need to re-mark it as approved (at the top) | 20:47 |
| hatch | Makyo: gary_poster on comingsoon when I deploy using the default settings there are never any units in the inspector it's always 0/0 | 20:47 |
| benji | (I've had the same issue) | 20:47 |
| bac | benji: no, i think it needs a vot | 20:47 |
| bac | vote | 20:48 |
| benji | :( | 20:48 |
| hatch | Makyo: it's a databinding issue - so far I've found one bug and resolved it but tracking down another | 20:48 |
| Makyo | hatch, Have that fixed locally as we mentioned with gary_poster's changes. | 20:48 |
| hatch | oh ok cool | 20:48 |
| hatch | then it's just the scale up input bug | 20:48 |
| Makyo | hatch, and yours, correct? Just those two? | 20:48 |
| benji | bac: will you try? I'd like to know for sure. | 20:48 |
| hatch | yes, and I have no ETA on mine, sorry | 20:48 |
| Makyo | okay | 20:48 |
| bac | benji: that is what i did previously. after your approval i made my changes, pushed them, and marked the MP approved. | 20:49 |
| benji | bac: done | 20:50 |
| bac | thanks | 20:51 |
| hatch | Makyo: as a status update (sometimes a good break helps break through the problem) I have solved the original issue now, another issue, and now exposed another so hopefully nearing the end | 20:56 |
| Makyo | hatch, alright. I'm running into issues with coordinates and centering in a real env., will keep posted. | 20:57 |
| hatch | sweet fixed | 21:02 |
| hatch | three bug fixes all within the same 'patch' haha | 21:02 |
| hatch | I better comment this else noone will know what's going on | 21:03 |
| Makyo | Oh, good, it affects dragging services now too. Augh. I am really tired of solving this same thing over and over again. | 21:09 |
| Makyo | </scarcasm? | 21:09 |
| Makyo | > | 21:09 |
| hatch | I think you put your close tag in the wrong spot | 21:13 |
| hatch | ;) | 21:13 |
| hatch | bcsaller: I still have to write a test for this - but would like it if you could take a peek https://codereview.appspot.com/14489044/ just to make sure it's done in the proper spot | 21:13 |
| * bcsaller peeks | 21:14 | |
| bcsaller | hatch: notes sent | 21:22 |
| hatch | thanks | 21:23 |
| hatch | bcsaller: re your comment on the loop - I need to loop through this model and compare with the key because it appears that there are bindings which match the model id which are associated to other areas | 21:32 |
| hatch | this could be another bug? | 21:32 |
| hatch | I can investigate further if you like | 21:32 |
| bcsaller | hatch: it sounds like we're conflating what that method should do in that case | 21:32 |
| hatch | I could split this loop out | 21:33 |
| hatch | but it's a nice place to put it because every time this method is called it should do this loop | 21:33 |
| hatch | but it could be broken out into a private utility like method | 21:34 |
| bcsaller | sounds like we want unbindModel and unbindViewlet that can filter the list either way | 21:34 |
| bcsaller | this is unbind model | 21:35 |
| hatch | agreed, but that's probably more work than I want to do atm | 21:35 |
| bcsaller | and engine.unbind is for all | 21:35 |
| hatch | since this is blocking release | 21:35 |
| bcsaller | well, its just the one new method that unbinds by viewlet name I think | 21:35 |
| bcsaller | I'm not sure about the semantics of needing to loop the keys when the only argument is a model, maybe an optional viewlet arg as well? | 21:37 |
| hatch | that sounds like an idea - so you want the viewlet.remove() method to call the original 2 then another to remove the bindings via the viewlet name? | 21:38 |
| bcsaller | I think that is what we're actually after, no? | 21:39 |
| hatch | yeah that makes sense | 21:41 |
| hatch | so in this case it would be the viewlet, I'm not sure when model would be required | 21:41 |
| hatch | or when it would be called for that matter | 21:41 |
| hatch | well actually unbind doesn't remove anything from the _bindings list | 21:42 |
| hatch | so in there would be unbindModel | 21:42 |
| Makyo | No luck on this positioning thing, gonna walk the dogs and see if that helps. | 21:47 |
| bcsaller | Makyo: I'm also looking at the position issues, happy to sync up when you get back | 21:49 |
| huwshimi | Morning | 22:08 |
| hatch | morning | 22:11 |
| hatch | Makyo: so is it looking like release will not be until tomorrow? | 22:13 |
| Makyo | hatch, correct. The locked fields and dragging causing service jumps (same issue as rick_h_'s centering bug, I think) have been show stoppers in the past, not comfortable with them today. | 22:20 |
| hatch | alright no problem | 22:21 |
| hatch | I'm about to land my fix so that won't be holding you up | 22:21 |
| hatch | I just have to figure out a good way to test it | 22:21 |
| hatch | :) | 22:21 |
| Makyo | bcsaller, still around? Zonked, but willing to chat. | 22:26 |
| Makyo | FWIW I'm running into the delayed annotations thing, where if I try to drag, the service jumps to the old position, but still moves with my cursor, however many pixels away. Ditto centering: centers on old position. | 22:28 |
| bcsaller | Makyo: I'm seeing that as well | 22:29 |
| gary_poster | jujugui (hi huwshimi!) call in 1 or 2 for those who want to attend | 22:29 |
| bcsaller | Makyo: I was trying to flow diagram all the places we manipulate x/y and see if I could simplify it | 22:30 |
| Makyo | bcsaller, yeah, I think that's a good idea. There's x/y attrs on services, x/y props on service_boxes, and gui-x/y annotations. A little too organic to keep up with. | 22:31 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!