| === _salem is now known as salem_ | ||
| === salem_ is now known as _salem | ||
| elopio | ping iahmad: can you please review this one? | 05:42 |
|---|---|---|
| elopio | https://code.launchpad.net/~elopio/ubuntuone-credentials/fix1237112-autopilot_base_test_case/+merge/190002 | 05:43 |
| jibel | Good morning | 05:43 |
| elopio | It's biggie. But most of the things I'm changing there are the things I think we should refactor on the gallery test cases, so your comments will be nice. | 05:43 |
| elopio | jibel: hello | 05:43 |
| jibel | hey elopio | 05:45 |
| iahmad | elopio, I ll review but may not be today as I need to finish few in progress things | 06:38 |
| DanChapman | Good Morning | 06:39 |
| Noskcaj | DanChapman, Is there any change you could finish my gtk3 branch? All the python stuff looks ready. It just needs the glade part (and gsettings, but i could do that) | 06:49 |
| elopio | iahmad: sure, no problem. You can look at it when you have time. | 07:14 |
| iahmad | elopio, ack | 07:15 |
| DanChapman | Noskcaj: I thought you wanted it to use the new quickly template? Thats what i was doing in my branch anyways. | 07:16 |
| Noskcaj | DanChapman, won't quickly still work if we use the existing code the "quickly upgrade"? | 07:17 |
| DanChapman | Noskcaj: I tried that mate after using pygi-conv etc but the structure is all wrong and it complains about something. I can't remember what right now. Will just have a peek now | 07:19 |
| Noskcaj | oh, ok. As i've said before, i lack the skills to do this right. That said, i don't think it's absolutely necessary to use quickly | 07:20 |
| DanChapman | Noskcaj: just gotta take my boy to school, will chat with you about it when i get back :-) | 07:32 |
| Noskcaj | ok, see you then | 07:33 |
| === iahmad is now known as iahmad|afk | ||
| jibel | with phone build 90 is anyone able to see videos uploaded to the device in the video scope? | 08:43 |
| jibel | rhuddie, gema ^? | 08:43 |
| rhuddie | jibel, let me check that | 08:45 |
| rhuddie | jibel, I tried copying AVI file to device, but was not able to see it in video scope | 08:51 |
| slickymaster | morning all | 08:55 |
| rhuddie | jibel, although after rebooting device, there is now an empty window showing under "My videos" section | 08:56 |
| jibel | rhuddie, I don't have anything, thanks for the verification. | 09:02 |
| === iahmad|afk is now known as iahmad | ||
| davmor2 | Morning all | 10:01 |
| jibel | pitti, several auto-retrace failed because the retracer uses obsolete dbgsym e.g bug 1237786 is there any manual action to do or it is just a matter of wait for some process to publish these packages? | 11:38 |
| ubot5 | bug 1237786 in ubuntu-system-settings (Ubuntu) "system-settings crashed with SIGABRT" [Undecided,Invalid] https://launchpad.net/bugs/1237786 | 11:38 |
| pitti | jibel: queueing (I really need to get some lunch, I keep getting pinged away from it :) ) | 11:47 |
| pitti | jibel: I actually rebuilt the indexes yesterday, I was hoping that would have fixed it | 11:47 |
| pitti | jibel: ah, that message is probalby a red herring; gdb just can't figure out a proper stack trace here for some reason :( | 11:48 |
| jibel | pitti, ok, it happened at least twice this morning, and it reported the same obsolete symbol files. | 11:49 |
| jibel | pitti, but lunch first :) Enjoy it | 11:49 |
| jibel | ! | 11:49 |
| === _salem is now known as salem_ | ||
| knome | balloons, i assume there will be RC images/milestones on the tracker? | 12:54 |
| jfunk | nuclearbob, this defect is not showing up in the list | 13:05 |
| jfunk | nuclearbob, this defect is not showing up in the list | 13:06 |
| jfunk | https://bugs.launchpad.net/signon-ui/+bug/1237496 | 13:06 |
| ubot5 | Ubuntu bug 1237496 in Online Accounts: Sign-on UI "signon-ui fails to start in Ubuntu Touch" [Critical,New] | 13:06 |
| nuclearbob | jfunk: the won't fix might be causing the problem, I'll take a look | 13:06 |
| jfunk | nuclearbob, it may also be the online accounts project is not in the list | 13:06 |
| nuclearbob | jfunk: quite possibly, yes. If that's the case, I can fix that easily | 13:07 |
| nuclearbob | jfunk: yeah, it's not in the bugs file I pull before filtering by status, I'll add signon-ui to the list of projects we check | 13:08 |
| === psivaa is now known as psivaa-afk | ||
| om26er | ubuntu-qa - can anyone confirm bug 1238010 ? | 13:21 |
| ubot5 | bug 1238010 in dialer-app (Ubuntu) "Dialer crashes when it tries to open the messaging app to send a message." [High,New] https://launchpad.net/bugs/1238010 | 13:21 |
| om26er | (please) | 13:22 |
| jibel | om26er, it could be the same than rhuddie found this morning | 13:25 |
| jibel | om26er, any crash file? | 13:25 |
| om26er | jibel, I talked to the dev he says its kind of expected. we are transition to a new mechanism. it should fix it soon | 13:26 |
| rhuddie | jibel, om26er, sounds similar. This is the bug I raised that got rejected because of outdated symbol package. This bug was pressing the Contact profile option in the dialer. | 13:28 |
| om26er | rhuddie, right. should we keep this bug? if you have another we can duplicate. | 13:29 |
| rhuddie | jibel, om26er, I haven't entered in another one yet, but I can do so now. It is reproducible every time. | 13:30 |
| om26er | rhuddie, I have reported a new one, can you please confirm that | 13:30 |
| om26er | rhuddie, I talked to the developer about the issue. he knows the problem and expects the fix to land soon | 13:31 |
| rhuddie | om26er sure | 13:31 |
| rhuddie | om26er, I have a couple of bugs that you could confirm too | 13:32 |
| davmor2 | jibel, om26er: I was just discovering a similar issue, if you open contacts and select text it seems to kill both apps | 13:33 |
| davmor2 | jibel, om26er: also if you text yourself can you then add that number to contacts that seems to be crashing both apps too | 13:35 |
| jibel | davmor2, why would I text myself? | 13:35 |
| rhuddie | davmor2, I raised a similar sounding defect: https://bugs.launchpad.net/ubuntu/+source/address-book-app/+bug/1235271 | 13:35 |
| ubot5 | Ubuntu bug 1235271 in address-book-app (Ubuntu Saucy) "Contacts app closes after pressing call or message option on contact with Mir enabled" [Critical,Triaged] | 13:35 |
| davmor2 | jibel: to test sms in both direstions :) | 13:36 |
| davmor2 | rhuddie: yeap sound very similar :) | 13:37 |
| rhuddie | om26er, I don't have a sim in my device, so I can't test the call log | 13:46 |
| rhuddie | om26er, would you be able to confirm this bug for me, please: https://bugs.launchpad.net/ubuntu/+source/dialer-app/+bug/1238026 | 13:55 |
| ubot5 | Ubuntu bug 1238026 in dialer-app (Ubuntu Saucy) "dialer-app crashed with SIGSEGV when viewing contact's profile" [High,New] | 13:55 |
| om26er | rhuddie, let me see | 13:59 |
| om26er | rhuddie, that's the same root cause as bug 1238010 | 14:01 |
| ubot5 | bug 1238010 in dialer-app (Ubuntu) "Dialer crashes when it tries to open the messaging app to send a message." [High,Confirmed] https://launchpad.net/bugs/1238010 | 14:01 |
| rhuddie | om26er, ok. So should this still be confirmed, or marked as duplicate, as the functionality is different? | 14:05 |
| elopio | good morning! | 14:10 |
| jfunk | nuclearbob, I am looking at 'past day' and seeing only bugs from yesterday, when I know that there's been some defects entered today, any thoughts? | 14:16 |
| nuclearbob | jfunk: I'm taking a look at that per what we taked about yesterday. I'm doing time calculations in python right now, but I think I may start using some of the age fields provided by launchpad instead. I'll let you know when I've tested that | 14:18 |
| jfunk | nuclearbob, it should be very simple, the script I sent you awhile ago had it there | 14:25 |
| jfunk | nuclearbob, tasks.extend(project.searchTasks(created_since=DATE_START, created_before=DATE_BEFORE, tags=['avengers'])) | 14:26 |
| balloons | knome, if you are still about, yes RC milestone is due out today | 14:26 |
| jfunk | nuclearbob, set the created_before date in the future | 14:26 |
| jfunk | nuclearbob, and set the created_since to the the day before today | 14:26 |
| nuclearbob | jfunk: right now I'm doing one launchpad query for all the bugs and filtering locally. I can do separate launchpad queries for each date range, but that's going to slow down the report a lot | 14:36 |
| === psivaa-afk is now known as psivaa | ||
| alesage | would somebody pls confirm this, it's very very weird https://bugs.launchpad.net/ubuntu/+source/mir/+bug/1236998 | 14:50 |
| ubot5 | Ubuntu bug 1236998 in mir (Ubuntu) "TZ settings location entry opens with " `" filled-in" [Medium,New] | 14:50 |
| alesage | advise starting from reboot | 14:51 |
| jibel | alesage, same then rhuddie reported earlier | 15:02 |
| jibel | bug 1237341 | 15:03 |
| ubot5 | bug 1237341 in ubuntu-keyboard (Ubuntu Saucy) "Extended characters incorrectly inserted into browser address bar when Mir enabled" [High,Confirmed] https://launchpad.net/bugs/1237341 | 15:03 |
| alesage | jibel, thanks--which should we mark as dupe? seb128 reassigned mine to mir, do you think that's correct? | 15:05 |
| alesage | maybe it gets more traction that way (?) | 15:06 |
| rhuddie | om26er, what do you think we should do with the dialer-app defects? | 15:18 |
| balloons | fginther, are you tracking which apps have automerging and which don't somewhere (beyond your static email list? )? | 15:43 |
| fginther | balloons, I don't have a list anywhere, there is a whitelist of branches in the actual trigger job | 15:44 |
| balloons | fginther, ahh that would be definitive then | 15:44 |
| fginther | balloons, trigger-autolanding-whitelist | 15:44 |
| knome | balloons, yep, cheers | 15:58 |
| smartboyhw | May the world be frozen:P | 16:01 |
| om26er | rhuddie, that's being taken care of now :) | 16:07 |
| rhuddie | om26er, cool. Should I mark mine as duplicate of yours? | 16:07 |
| om26er | rhuddie, yes, please. | 16:08 |
| rhuddie | om26er, ok will do | 16:08 |
| om26er | bug 1238010 was just retitled so I think it covers your issue as well | 16:08 |
| ubot5 | bug 1238010 in dialer-app (Ubuntu Saucy) "[mir] telephony apps and address book can't communicate" [High,In progress] https://launchpad.net/bugs/1238010 | 16:08 |
| jibel | alesage, I used rhuddie's as master, seb128 is pretty good at reassigning what has nothing to do on his plate :) | 16:13 |
| alesage | jibel ok yes seb128 has many talents :) | 16:14 |
| === yofel_ is now known as yofel | ||
| DanChapman | jibel, hey mate. Do you reckon you will have any time this week to setup the ubiquity tests for me? | 17:03 |
| * balloons waves @ DanChapman | 17:05 | |
| * DanChapman waves back o/ | 17:06 | |
| === chihchun_afk is now known as chihchun | ||
| === balloons changed the topic of #ubuntu-quality to: Welcome to Ubuntu Quality | http://wiki.ubuntu.com/QATeam | Testing Saucy Final, http://iso.qa.ubuntu.com/qatracker/milestones/305/builds | Final Release for Saucy Oct 17th | ||
| balloons | DanChapman, so I take it everything is ready eh? What needs setup? | 17:36 |
| balloons | ^^ lookey there we've got queuebot again ;-) | 17:37 |
| DanChapman | balloons Yeah getting there now. Custom install is in working order just some improvements to be made but they are all ready to be run. Its just the test names on jenkins need updating. | 17:40 |
| balloons | I don't believe I can do anything there, but let me see | 17:40 |
| elfy | yay - I can quietly leave -release then | 17:42 |
| balloons | DanChapman, nope, can't do anything on that jenkins :-) | 17:45 |
| DanChapman | balloons: no worries. Thanks for checking :-) | 17:49 |
| sergiusens | balloons, hey, this is for you https://code.launchpad.net/~sergiusens/stock-ticker-mobile-app/tested_storage_location/+merge/190444 | 18:15 |
| balloons | sergiusens, stock ticker eh? kk | 18:16 |
| balloons | does pep8 and pyflakes pass on it/ | 18:16 |
| sergiusens | balloons, still doesn't fix the test, but should be using the standard location with that | 18:16 |
| sergiusens | balloons, I have those run on each save ;-) | 18:17 |
| balloons | sergiusens, yea, seems robert says the tests will be broken | 18:17 |
| sergiusens | balloons, that's why I removed the unsused imports | 18:17 |
| sergiusens | balloons, AttributeError: 'NoneType' object has no attribute 'visible' | 18:17 |
| balloons | sergiusens, right.. I asked because if it's passing fginther can add pep8 and pyflakes to it | 18:17 |
| sergiusens | /home/phablet/autopilot/stock_ticker/tests/test_Subtabs.py | 18:17 |
| balloons | fginther, can you add pep8 and pyflakes requirements to rssreader and stock ticker app when you have a chance. no rush :-) | 18:18 |
| fginther | balloons, ack | 18:18 |
| sergiusens | balloons, so I only fixed pep8 and pyflakes for the file I edited | 18:18 |
| sergiusens | balloons, you want a full fix? | 18:18 |
| balloons | sergiusens, if you don't mind.. if not it'll have to happen on the next commit :-) | 18:18 |
| sergiusens | fginther, how long until the core community apps get merging working again? | 18:18 |
| sergiusens | balloons, hmm 73 peps :-) | 18:19 |
| fginther | sergiusens, until we get a mir image with fully passing tests. They are being enabled as they start passing | 18:19 |
| sergiusens | let me fix | 18:19 |
| balloons | sergiusens, ohh, a big one :-) | 18:19 |
| sergiusens | fginther, is there a current list? can you start a pad we can all just refer to to know? | 18:20 |
| fginther | sergiusens, I can add them to the jenkins banner | 18:20 |
| sergiusens | fginther, i guess that works, if it's easier for you good | 18:21 |
| fginther | sergiusens, done | 18:27 |
| Noskcaj | Morning everyone | 18:48 |
| elfy | hi Noskcaj | 18:57 |
| thomi | morning | 19:11 |
| renato_ | elopio, balloons could you guys help me implement a emulator for a class on SDK? | 19:34 |
| balloons | which clasS? | 19:34 |
| renato_ | balloons, ListItem.Empty | 19:35 |
| renato_ | balloons, this is my current code: http://bazaar.launchpad.net/~renatofilho/ubuntu-ui-toolkit/fix-1236464/revision/792 | 19:35 |
| renato_ | balloons, this is falling to retrieve the object: 483 item5 = self.main_view.select_single(emulators.ListItemEmpty, | 19:36 |
| renato_ | 484 objectName='listitem_5') | 19:36 |
| elopio | renato_: I think the name of the class should be ListItem, not ListItemEmpty. | 19:39 |
| elopio | oh, no, Empty instead of ListItemEmpty. That's one of the things that suck on autopilot, it ignores the namespace. | 19:40 |
| elopio | renato_: let me run it. | 19:41 |
| elopio | renato_: ok, according to autopilot vis, the type of name of your QML object is 'Standard' | 19:53 |
| renato_ | elopio, but Standard has Empty as base class | 19:55 |
| elopio | renato_: yes, but autopilot can't handle that. | 19:55 |
| elopio | when you do select_single(Empty), it expects 'Empty' to be on the tree. | 19:56 |
| renato_ | like the CheckBox and Switch | 19:56 |
| renato_ | but how the previous test can work with CheckBox | 19:56 |
| elopio | renato_: oh, that's a good example. Take a look at the CheckBox emulator, it handles also Switch but never does select_single(Switch) | 19:56 |
| renato_ | elopio, but it retrive the switch with type CheckBox | 19:57 |
| renato_ | is that what I am trying | 19:57 |
| renato_ | get the Standard using the base class Empty | 19:58 |
| elopio | renato_: it's different because a Switch is just a styled check box, isn't it? | 19:58 |
| elopio | I don't know much about QML yet. | 19:59 |
| elopio | what I know is that when I make a Switch, autopilot sees a CheckBox on the tree. | 19:59 |
| renato_ | elopio, no Switch is a nes Class based on CheckBox | 19:59 |
| renato_ | humm strange | 19:59 |
| renato_ | the Switch and CheckBox is the same as Standard and Empty from my point of view | 20:00 |
| elopio | there must be something different from the autopilot point of view. | 20:01 |
| elopio | but I have holes on my QML knowledge and on my autopilot knowledge :) | 20:01 |
| elopio | renato_: have you tried autopilot vis? | 20:02 |
| renato_ | elopio, yes the vis is saying that the item is Standard, but I thought autopilot some how check the base classes | 20:03 |
| thomi | renato_: Qt doesn't expose that information to us :-/ | 20:03 |
| renato_ | thomi, but how this works with switch and checkbox? | 20:04 |
| renato_ | thomi, any way to help autopilot to discovery that ? | 20:05 |
| balloons | sorry to sidetrack, but thomi, what did you find out about core apps and mir failures btw? I'm in headfirst on these now :-) | 20:05 |
| thomi | balloons: as far as I could tell, the ones I was looking at (weather-app mostly) looked like genuine failures, but yesterday I kept getting distracted by people asking me questions ;) | 20:07 |
| thomi | balloons: so I didn't get much done | 20:07 |
| thomi | renato_: hmmm | 20:07 |
| thomi | renato_: elopio: AIUI, you expect a certain type to appear, and a different type is showing up? | 20:07 |
| balloons | thomi, that's all i wanted to hear.. if there might be something systematic or not | 20:07 |
| * balloons notes he was one of the ones asking questions :-) | 20:08 | |
| thomi | I didn't see anything like that | 20:08 |
| thomi | balloons: once I knock over this bug I'm working on, I'll come help you out again | 20:08 |
| thomi | but... you know how it is :) | 20:08 |
| elopio | thomi: it's like this: | 20:09 |
| elopio | we have Standard { Empty }, and autopilot shows Standard. And we have Switch { Checkbox } and autopilot shows Checkbox. | 20:09 |
| balloons | one bug at a time :-) | 20:09 |
| renato_ | thomi, for some reason I can retrieve a checkbox or switch item using; | 20:09 |
| renato_ | self.main_view.select_single(emulators.CheckBox, | 20:09 |
| thomi | renato_: ahhhh | 20:09 |
| thomi | renato_: yeah, so what happens is... | 20:09 |
| renato_ | but this does not work with standard and empty | 20:09 |
| thomi | renato_: the Qml engine will optimise away any Qml type that does not specialise it's base type | 20:10 |
| thomi | renato_: before autopilot sees it. So you need to add some properties or something to make Standard different to EMpty | 20:10 |
| thomi | it's a known limitation of autopilot on Qml,and I can't think of a way to fix it, short of patching Qt | 20:10 |
| renato_ | thomi, I want the opposite :D , I want the Standard to be a Empty too :D | 20:11 |
| elopio | renato_: but I see no reason for doing that. | 20:11 |
| thomi | oh, sorry, I guess I'm confused then | 20:11 |
| elopio | just name your emulator Standard, and it will work just the same, right? | 20:11 |
| renato_ | elopio, thomi, what I need is a emulator to help people to test the swipe to delete function | 20:12 |
| elopio | thomi: your diagnose sounds right, your conclusion was wrong. "So you need to add some properties or something to make Switch different to Checkbox" | 20:12 |
| elopio | renato_: yes. And all the Standard items will ahve that function. So it's ok to call the emulator Standard. | 20:12 |
| thomi | elopio: probably. | 20:12 |
| thomi | not that it helps here, but in 1.4 you'll be able to apply an custom proxy classt o more than one type... | 20:13 |
| renato_ | and since the apps uses different class empty/Standard/MultiValue/etc... i need to make this work with any class | 20:13 |
| renato_ | and Empty is the base class | 20:13 |
| renato_ | thomi, elopio, maybe you guys have a better solution :d | 20:14 |
| elopio | renato_: make an Empty class. And then make a Standard class that inherits from Empty. | 20:14 |
| elopio | I think that will work. | 20:14 |
| thomi | renato_: in 1.4 this will be easier for you. Until then, I suggest making a Mixin class that contains the code you want, and then separate emulators for each specific type | 20:14 |
| thomi | elopio: no, not quite like that | 20:15 |
| thomi | hang on, let me paste something... | 20:15 |
| thomi | elopio: renato_: like this: http://pastebin.ubuntu.com/6219572/ | 20:17 |
| renato_ | thomi, great thanks | 20:18 |
| renato_ | thomi, elopio, thanks for the help | 20:18 |
| thomi | I mean, I haven't tested that or anything, but I don't see why it wouldnt work :) | 20:18 |
| thomi | just make sure you have the inheritence order the right way around :) | 20:19 |
| renato_ | thomi, i let you know if its fails :D | 20:19 |
| thomi | i.e.- CustomEmulatorBase first :) | 20:19 |
| elopio | thomi: and why wouldn't it work to make Standard inherit from CustomEmulatorBase and Empty? | 20:19 |
| thomi | elopio: are you sure you want to know? It's an internal autopilot implementation detail | 20:19 |
| elopio | thomi: you are scary when you talk like that :) I would like to know, but it might open many other questions. | 20:20 |
| thomi | well, the short version is... | 20:21 |
| elopio | so maybe when you are not so busy. I'll note it on my whiteboard. | 20:21 |
| thomi | uhhh... actually | 20:21 |
| thomi | now that I think about it | 20:21 |
| thomi | it might work... | 20:21 |
| thomi | hmmm | 20:21 |
| thomi | elopio: you should try it :) | 20:21 |
| thomi | I think this way is cleaner anyway :) | 20:21 |
| elopio | thomi: I will. It's not cleaner if the only elements that provide the swipe to delete are the ones that extend the Empty qml object. | 20:22 |
| thomi | elopio: good point :) | 20:22 |
| thomi | elopio: well, as long as *all* objects that extend Empty support it | 20:23 |
| elopio | thomi: I think that how QML works is that if you want an object that extends Empty not to be delete-able, you can disable it. | 20:23 |
| elopio | but that's what comes of playing with something like inheritance on declarative languages. Anyway, I'm like one month away to finish the QML tutorials, later I'll have a better opinion on this subjects. | 20:24 |
| thomi | elopio: right, so if you have half the EMpty-extended objects that support deletion, and half that don't, then all of a sudden my way is much better ;) | 20:25 |
| elopio | renato_: I know you haven't finished your branch, but can I make some suggestions? | 20:25 |
| thomi | elopio: otherwise you'll have objects with a 'delete' method that don't support deletion | 20:25 |
| renato_ | elopio, sure | 20:25 |
| elopio | thomi: yes, I agree. However, you will not be able to match an emulator with a half empty-extended object, because they disable things on properties. You can have a half extended Standard, and a fully extended Standard. | 20:26 |
| renato_ | thomi, elopio : to enable swipe-to-delete you need set the property "removable" to "true" | 20:26 |
| elopio | renato_: ok, please be patient with me. I'm a freak. | 20:26 |
| elopio | the methods on ListItemEmpty should be all lower case, separated by _ | 20:26 |
| elopio | renato_: test_list_item_popover_emulator should be called test_standard_emulator or test_empty_emulator. | 20:27 |
| renato_ | ok | 20:28 |
| elopio | renato_: test_delete_a_item should be test_delete_an_item or test_delete_item. I'm inclined to the second. | 20:28 |
| renato_ | :D | 20:28 |
| elopio | renato_: on the method swipe_to_delete, you should add an else clause where an exception is thrown if you try to delete an undeletable item. | 20:29 |
| elopio | renato_: but that might be because you are still working on it. So, it would be nice if you let me know when it's finished give you my review. | 20:29 |
| renato_ | elopio, nice I will do | 20:30 |
| elopio | thank you renato_. | 20:33 |
| elopio | I'll break a little. bbl. | 20:33 |
| renato_ | elopio, how I can check if a signal was fired? | 20:45 |
| elopio | renato_: you shouldn't. | 20:46 |
| renato_ | :D | 20:46 |
| elopio | if you need to check that, you need a qmlrunner test, not an autopilot test. | 20:47 |
| elopio | or, maybe you are missing to give the user a visual clue of what's going on. | 20:47 |
| thomi | elopio: well, autopilot *can* do that, but you're right, it's probably not a good idea | 20:47 |
| slickymaster | night all | 20:51 |
| jfunk | ToyKeeper, ping ready to meet? | 21:00 |
| renato_ | elopio, https://code.launchpad.net/~renatofilho/ubuntu-ui-toolkit/fix-1236464/+merge/190496 | 21:36 |
| elopio | renato_: ok, I'll take a look. | 21:37 |
| elopio | hey renato_, are you from the SDK team? | 21:37 |
| renato_ | elopio, no, contact app/server | 21:37 |
| elopio | um, ok. I have a problem with going to the end of a text field. | 21:38 |
| renato_ | elopio, I have problems with text field to :D | 21:40 |
| elopio | renato_: have you seen that when you long press a text field a dialgo is shown? | 21:41 |
| elopio | I think it's only shown when the text field is not focused. | 21:41 |
| renato_ | elopio, no :D, I have the problem to go back to the beginner of the text when the text is bigger the text area | 21:42 |
| renato_ | elopio, you should ask about that on ubuntu-app-devel | 21:42 |
| elopio | hey, we are on the same problem, but backwards! | 21:42 |
| renato_ | ?D | 21:43 |
| renato_ | :D | 21:43 |
| elopio | I think that when we long press on a text field, one of the options of this dialog should be go to the end | 21:43 |
| elopio | and now, go to the begining. | 21:43 |
| elopio | renato_: I think it would be enough to test one of the objects that inherit from SwipeToDeleteTestCase, and then to test that all the emulators you added inherit from SwipeToDeleteTestCase. | 21:50 |
| elopio | and that second test would be a little dumb, so I would just leave either the empty or the standard item on your test. | 21:50 |
| elopio | renato_: every time you do select_single, and continue on the next line, you have a pep8 error there because of the extra space. | 21:50 |
| elopio | so jenkins is going to reject your branch for that. | 21:51 |
| renato_ | elopio, ok let me fix this | 21:54 |
| elopio | renato_: you are missing some tests to cover all the possible flows: | 21:54 |
| elopio | test_delete_item -> with default direction value | 21:54 |
| elopio | test_delete_item_swiping_to_the_left | 21:54 |
| elopio | test_delete_non_removable_item | 21:54 |
| elopio | test_confirm_removal_when_item_was_not_swiped | 21:54 |
| elopio | renato_: and I don't like this: 109+ self.implicitHeight.wait_for(0) | 21:56 |
| elopio | if the dialog doesn't have a visible property that works, or an opened property or something like that, I think we should fix it to be | 21:56 |
| elopio | self.visible.wait_for(False) | 21:56 |
| elopio | I say "we" as in somebody who know how to do it, not me :) | 21:56 |
| renato_ | elopio, let me check that | 21:57 |
| renato_ | elopio, new revision pushed | 22:19 |
| renato_ | elopio, about the: 109 + self.implicitHeight.wait_for(0) | 22:19 |
| renato_ | the other way to check when the item is removed is by the signal itemRemoved | 22:19 |
| elopio | renato_: IMO, that's lack of testability, and should be fixed. But I'm ok if it's not fixed on your branch. | 22:21 |
| elopio | thanks for making the changes. | 22:22 |
| elopio | renato_: a question: why do you need the repeater, the column and the flickable? Wouldn't it work just putting one Standard inside the MainView? | 22:22 |
| renato_ | elopio, I am justing creating more than one to make the test more real | 22:26 |
| elopio | renato_: I think here we should strive to do the smallest possible working test case. It shouldn't be the role of emulator self-test to check that this also work when inside a repeater, inside a flickable. | 22:28 |
| elopio | that's a component test, problably to be written for qmlrunner. | 22:28 |
| elopio | having a more complex QML doesn't increase the level of coverage we are doing here. Or well, it does, but in an obscure way, I think. | 22:29 |
| renato_ | elopio, ok I can reduce the qml example | 22:30 |
| renato_ | elopio, done | 22:32 |
| elopio | awesome :) | 22:34 |
| elopio | renato_: I'm sorry, can I go on with some pita suggestions? | 22:34 |
| renato_ | elopio, sure | 22:35 |
| elopio | renato_: make a setUp method, and put there | 22:35 |
| elopio | self.item = self.main_view.select_single( | 22:35 |
| elopio | emulators.Standard, objectName='listitem_standard') | 22:35 |
| elopio | then you won't have to duplicate it in the tests. | 22:35 |
| elopio | renato_: on the QML, you left the Empty item, but you are not using it on the tests. I would remove it. | 22:36 |
| phillw | balloons: can you give me a ping when you have a spare couple of minutes, thanks. | 22:36 |
| renato_ | elopio, I am using it on test_delete_non_removable_item | 22:36 |
| elopio | renato_: ah, I see. I'm sorry. | 22:37 |
| elopio | then on the set up I would make it self.standard_item, so it's clear. | 22:37 |
| elopio | renato_: and to put a cherry on the cake, for consistency it would be nice if the python code used only single quotes for strings. | 22:38 |
| elopio | but when I get to this level of suggestions, you can start ignoring me :) I have problems. | 22:38 |
| renato_ | :D | 22:38 |
| elopio | renato_: I'm approving your branch. I'm not able to review the QML changes you made, so it would be nice if you get a review from some qml developer. | 22:39 |
| renato_ | elopio, ok thanks | 22:39 |
| renato_ | elopio, pushed | 22:41 |
| elopio | renato_: love it! Just please move the setUp to be the first method on the test class. | 22:43 |
| renato_ | :( | 22:43 |
| elopio | renato_: hey, please don't be sad. I'm sorry. | 22:47 |
| elopio | You have two white spaces at the end of the file tests/autopilot/ubuntuuitoolkit/tests/test_emulators.py | 22:47 |
| elopio | pep8 is not going to like that. | 22:47 |
| renato_ | done | 22:49 |
| elopio | renato_: I owe you a beer :) | 22:50 |
| elopio | ok, I'm going. Will be back in ~4 hours to work a little with the europeans. | 22:50 |
| renato_ | elopio, I think I owe you a beer because you help me with that | 22:52 |
| renato_ | thanks | 22:52 |
| === salem_ is now known as _salem | ||
| === chihchun_afk is now known as chihchun | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!