/srv/irclogs.ubuntu.com/2013/10/11/#juju-gui.txt

gary_posterMakyo, hey.  It might be reasonable to try to land the fixes you have now.  That will make it easier for us all to know where we stand, and keep us from discovering and/or solving the same bugs repeatedly.  If you'd like me to help with that, send me a branch and I'll tackle it tomorrow morning.00:26
* gary_poster steps away00:26
Makyogary_poster, Will do, they're a minimal mix of what you had and trunk, now that bcsaller landed.  Little else I tried worked.  Will keep poking at locations, but push first.00:27
gary_postercool thanks Makyo00:29
rick_h_<3 my job. Working from the campground tomorrow. Had to run out at the last minute tonight when I called and they said "We've got 8 spots left" and only had 3 to pick from when I got here. 01:51
bacmorning ranger rick_h_, you around?11:19
rick_h_bac: around11:40
bachi rick_h_, get the good camp spot?11:40
rick_h_adeuring: did your branch land?11:40
rick_h_bac: meh, right by the zone entrance so lots of traffic and dust, but the wife is exstatic as it's 'boo bash' weekend with trick or treating and such11:41
bacrick_h_: i've taken the card for updating manage.jujucharms.com to r416, which includes my icon fix.11:41
rick_h_bac: ok, I wanted to check on adeuring's branch. There was talk in a call of something that broke something and might need to be fixed? 11:41
bacrick_h_: sounds vaguely familiar.11:42
* rick_h_ is checking changelog 11:42
bacrick_h_: i also saw one spurious test failure in trunk locally.  looking at that.11:42
rick_h_bac: ok cool, looks like adeuring's branch landed and was related to an issue we ran into setting up the new charmworld instance11:43
rick_h_bac: so r416 looks peachy to me11:43
bac+111:43
rick_h_thanks for taking the upgrade11:44
rick_h_bac: did you check with gary_poster on the icon fix? I was told that bundles will not support icons right now and we'll not show them. 11:55
bacrick_h_: it is showing the default icon. before the path was broken and showing a broken link in charmworld11:55
rick_h_bac: the gui will never show them, even for promulgated. I guess showing on charmworld could be different. 11:55
bacrick_h_: now it correctly shows the default icon for all bundles11:55
rick_h_bac: oh showing bundle.png?11:56
rick_h_ah, gotcha11:56
bacrick_h_: default.svg or whatever11:56
rick_h_it's calling /file/icon.svg which will show bundle.svg so ok cool All good11:56
rick_h_bac: gotcha, thanks for the clarification. 11:56
bacnp11:57
frankbanguihelp: could anyone please review https://codereview.appspot.com/14531051 ? It's just a documentation branch.12:18
rick_h_frankban: sure thing12:20
frankbanrick_h_: thanks!12:20
rick_h_gah, that's just a few steps. 12:21
bacgeez frankban, i'm exhausted just glancing at those steps.  you need to end with 'have a beer, cigarrette, or mountain dew'12:22
frankbanheh... I agree. Otherwise we can add "drink a glass of wine each time you type `bzr`" at the beginning...12:24
rick_h_missed the step "move card from monday to done done now that it's friday"12:25
frankbanit must be friday, that's taken from granted12:25
rick_h_oh right!12:26
frankbanthanks rick_h_ 12:27
gary_poster:-P :-)12:44
frankbangary_poster: morning! I am inclined to move my card in landing to done after reading Kent's email. Do you agree?12:59
gary_posterfrankban, agree, thank you.  I was going to ask benji if he had experience in mimicking firewalls for us to explore the bug he filed.  That seems like a benji sort of thing to know. :-)13:00
benjiheh13:00
gary_posterthe bug Kent filed, I mean13:00
frankbancool13:00
benjiwell...13:00
benjiI was thinking that it wouldn't be too hard to set up iptables to give us the effect we're looking for.13:02
gary_posterbenji, cool.  Maybe something to explore end of next week if we have time.  Would be cool to have that documented so we all can set it up and tear it down.  Meanwhile, Kent didn't give the info I was asking for in the bug report, probably because he doesn't know the JS tools.  If I have time I might try to hangout with him and look at the JS console.  I wouldn't be surprised if this is a "duh" moment once we see the13:05
gary_poster console.13:05
benjisounds good13:06
frankbangary_poster: re your quickstart email, it's all good, and I created the cards. Unfortunately I don't have an better story for the password, and I guess we don't want the password to be set on the charm. A not-so-good idea could be pre-filling the form once the page is opened... meh. I am not sure about tornado for the CLI. If the story is "the user waits for something to happen, and there is only one thing that can happen at the tim13:21
frankbane" I guess we can block and still have gradual feedback. But surely I am missing something, and I'd also be happy to be proved wrong.13:21
adeuringbenji, bac, abentley: could one of you have a look at this MP: https://code.launchpad.net/~adeuring/charmworld/bump-charmtools-version/+merge/190648 ?13:21
bacadeuring: sure13:22
adeuringthanks!13:22
gary_posterfrankban, cards: thank you!  look good on first scan, and I'll look closer in a few minutes.  password: yeah.  If we could prefill the form locally somehow...sending  stuff on the query string is the only approach that the python webbrowser module supports & would technically be safe IIRC because we are using https, but it seems a bit ugly.  Thinking about it some more, there probably is some kind of SSO-like token 13:36
gary_posterstory available.  Example: quickstart generates a one time pair of openssh keys.  It sends the private key to the gui server over https API call and the gui server agrees to remember it for 1 minute only.  We encrypt the admin secret with public key and then that is included in query string, and the browser logs in with that value.  gui charm decrypts password with private key, authenticates against juju, and we're 13:36
gary_posteroff.  There's probably a simpler version of that, but that would work, I think.  WDYT? tornado: ok, I trust your hunch.  If we can move faster without it and still have a good experience, then cool, I'll trust your hunch.  I just thought it would be nice to be able to show progress.13:36
gary_postergui could be responsible for generating the public/private key, actually, and then it would send the public key back.  That would be less weird13:37
gary_posterquickstart to gui: Please generate a onetime public key for me13:38
gary_postergui to quickstart: ok, here you go.  I will remember it for one minute13:38
gary_posterquickstart to browser: here, I encrypted the admin secret with the public key.13:38
gary_posterbrowser to gui charm: hey , here's the encrypted key13:39
bachey benji do you have a second to talk about bug 123478013:39
_mup_Bug #1234780: Dict has no attribute series <bundles> <charmworld:In Progress by bac> <https://launchpad.net/bugs/1234780>13:39
benjibac: sure13:39
baci'll start a hangout13:39
gary_posterThis is arguably super paranoid.  https really should be sufficient.  This way the URLs are a a poor attack vector, at least, though.13:39
gary_poster<shrug>13:39
bacbenji: https://plus.google.com/hangouts/_/98f14bc332fe7144160604ebfa68d0ee12c35566?hl=en13:41
rick_h_bac: with that bug, as far as ingest is concerned, it's only optional if we can find the charm without it13:41
frankbangary_poster: that's interesting! I was only thinking about some sort of selenium-like "i'll put your password in the form ad then click login for you", but your story is definitely better :-) re tornado: I am still not sure, I guess we can start with tornado and then quickly step back if we realize it's giving as nothing but "yields"13:41
rick_h_bac: it's kind of related to what I'm tring to do to add proof checks for finding the charm and using series is one way to do that13:41
rick_h_bac: in case it relates to anything13:41
frankbans/giving as/giving us13:42
gary_posterfrankban, tornado: ok cool.  Or should we start with the simplest story, without tornado, and only add it if we start to feel pain?  simple is good.13:42
rick_h_bac benji when you get done, I've pulled trunk and can no longer run things as it can't find the python charmtools module. I've installed the package, but not seeing where there's a python lib for it?13:43
benjirick_h_: we moved charmtools into the included dependencies, so the system charmtools isn't used any more13:46
benjiwe had an issue yesterday with the packaged dependencies being updated, but I thought that was fixed13:46
rick_h_benji: into the download-cache?13:47
rick_h_benji: ok, got it. For some reason my bzr up didn't up I guess13:49
frankbangary_poster: heh, ok, I'll wait and think about it. the weekend is there for this kind of implementation details illuminations ;-)13:49
gary_posterfrankban, lol ok13:49
benjiri13:50
gary_posterback in a few13:50
benjirick_h_: did you run make after updating?  That should have updated the download cache.13:50
rick_h_oh, I was running make sysdeps vs make deps and it didn't get updated since I was looking in the wrong place. 13:50
rick_h_benji: so we can remove the charm-tools from the sysdeps line now then?13:50
benjirick_h_: yep13:50
rick_h_benji: no, I looked for charm-tools in the makefile and foud it in sysdeps and so ran sysdeps manually13:51
benjialso, just "make" will be all you should need now (other than if you need sysdeps)13:51
rick_h_benji: right, since it was listed I thought I was missing something from sysdeps13:51
benjiyep13:51
* frankban biab13:52
bacadeuring: your branch looks good.  i'm just running tests now.13:54
adeuringbac: thanks!13:54
hatchyay I could finally connect14:04
bacbenji, rick_h_, adeuring: could one of you look at https://code.launchpad.net/~bac/charmworld/bug-1234780/+merge/19067614:06
benjibac: I'll take a look.14:06
rick_h_benji: got a sec to chat after that?14:06
benjirick_h_: sure14:06
benjirick_h_: I'm available.14:08
rick_h_benji: k, your webrtc link then?14:09
benjirick_h_: sure (benjiyork.com/chat)14:09
rick_h_benji: http://paste.mitechie.com/show/1039/ 14:10
gary_posterMakyo, proposing my change now14:21
Makyogary_poster, okay, cool14:22
gary_posterjujugui, looking for 1 review and qa of small branch: https://codereview.appspot.com/1454805014:26
MakyoOn it.14:26
Makyogary_poster, LGTM (been QAing w/ this change this morning, go for it)14:29
benjithere's a bit of an antipattern going on in charmworld: several places pass around dictionaries (charm info mostly) and different callees assume different things are in the dict.  It makes understanding the code harder than it would be if we passed the individual bits of data each function needed.14:43
rick_h_benji: yea, so that came to be an issue from the whole mongodb flexible document thing. The answer to some of that was supposed to be "Charm(dict)" and then we had a more stable 'model' to use14:49
Makyojujugui call in 1014:50
Makyo\o/14:50
rick_h_Makyo: 4, gary_poster 1 - this weeks "closest to his meeting reminder and keyboard" winner is Makyo!14:51
rick_h_benji: it's why we've got all the Charm(charm) calls around if I recall correctly14:52
MakyoI'll have you know I heard my phone buzz while I was making coffee and ran over to ping.14:52
benjirick_h_: the model helps quite a bit; unfortunately for the thing I'm doing we don't have all the charm data, just bits and pieces14:52
rick_h_benji: heh yea I was just typing "though in principal I'm with you on ...provide data required" kind of thing. 14:53
benjiyep14:53
rick_h_benji: though I'm not looking where you're looking so kind of not 100% sure14:53
rick_h_e.g. if the method name is "do_some_for_charm" then a charm model seems legit14:53
rick_h_vs bits14:53
benjiI see the same problem with objects a lot too, some deep chain of function calls operate on an object and you never know which attributes are touched along the way14:54
abentleyjcsackett: Did you push add-github-job up directly instead of letting the jenkins lander handle it?14:54
gary_poster:-)14:55
gary_posterhey Makyo, thank you very much for review.  I'd suggest using trunk now, rather than your branch: there's one part of what I gave you that you should discard, because Ben fixed it better.  trunk has only the good bit14:56
bacabentley: this failure appears to be spurious.  thought you might like to see it. http://162.213.35.27:8080/job/charmworld-autoland-lxc/36/14:56
abentleybac: Thanks.14:56
Makyogary_poster, that's the part I pulled out yesterday, but I think trunk and my branch are now equal except for my changes.  Just to be safe, though, I'll pull my changes out and move them to trunk.14:56
Makyo(mostly just tracing coordinate stuff, granted)14:57
gary_postercool thanks Makyo.14:57
abentleybac: Do you have any idea why it failed to install ycssmin.tar.gz ?14:58
Makyojujugui call in 214:58
gary_posterbac call now :-)15:00
abentleybac: The file /var/lib/jenkins/jobs/charmworld-autoland-lxc/workspace/npm-debug.log mentioned in the build does not exist.  Without it, there's not much I can do to debug this.15:07
bacabentley: ok.  the next attempt was successful.15:07
antdillonHi, what is the best way to store a user setting in the gui?15:27
rick_h_antdillon: I think we were thinking of using localstorage to detect if you've seen it before/not15:28
antdillonrick_h_, Ok, is there a plan to have a localstorage class to getting and setting?15:29
rick_h_antdillon: not sure, wait to see what others thik15:31
rick_h_think15:31
antdillonrick_h_, Cool thanks15:34
gary_posterantdillon, two approaches.  (1) we have some sessionStorage code in app/store/env/base.js.  You could try extracting that.  Important note: gui should work with cookies turned off!  you'll see there's a bit of code for this case.15:44
Makyogary_poster, re positions: I'm going to work on a fix for release, bcsaller is working on simplification to help prevent (or at least ease debugging of) this sort of thing in the future.15:44
gary_posterMakyo, sounds great, thank you.15:44
gary_posterantdillon, (2) app/assets/javascripts/app-cookies-extension.js15:46
gary_posternot sure what to do with that one :-)15:46
antdillongary_poster, Ok I'll check them out, base.js seems like it has good stuff15:47
gary_postercool antdillon 15:47
antdillongary_poster, Thanks15:48
gary_posterwelcome15:48
hatchso do the people who turn cookies off also turn off local storage? or is that ok?15:48
hatchlol15:48
* hatch doesn't get it15:48
rick_h_can you turn of local storage? /me doesn't remember a setting15:48
rick_h_hatch: well localstorage isn't sent on every request in the headers so things like invisible gifs won't ping/send data15:49
rick_h_hatch: you actually have to download a file, and get access. and can't cross domain bounds. 15:49
hatchwell tracking gifs work by just being downloaded15:49
rick_h_hatch: but then there's the "turn off JS" folks I still don't understand15:49
rick_h_hatch: right, but the request can return any cookie headers15:50
rick_h_/can/will15:50
hatchoh right15:50
rick_h_e.g. you can set a cookie from a gif request15:50
rick_h_anyway, the cookie thing is all EU, crazy people :P15:50
hatchmaybe it's a knee jerk reaction to the surveillance state :D15:51
abentleyadeuring: charmworld is complaining that "string" is not a valid value for "type", http://staging.jujucharms.com/~juju-jitsu/precise/charmworld but according to the docs, it is: https://juju.ubuntu.com/docs/authors-charm-config.html15:52
hatchrick_h_: enjoying working from the camper? :)15:53
adeuringabentley: interesting.... That page is new; I assumed that "str" is correct based on an older version. Seems that another update of charmworld is needed...15:54
hatch65" 4K Sony TV $6000 - that seems like a good deal15:56
jcsackettabentley: sorry for delay in response, and yes, i forgot you had jenkins set up for our charm as well now. :-(15:56
hatch(no I'm not buying one)15:56
hatch:)15:56
abentleyjcsackett: No, I don't actually.  I missed the fact that it was on the charm.  Carry on.15:57
jcsackettabentley: fantastic. misunderstandings both ways. :-P15:57
jcsackettglad i didn't eff anything up. :-)15:58
hatchgary_poster: do the users have the ability to alter any of the bundle settings before deploying?16:26
hatchit looks like the DD just calls deployerImport()16:27
hatchis this the same interaction we want for the details view 'add' button?16:27
hatchanyone else use the chrome devtools 'watch expressions' section when in a loop? makes things so easy to debug16:45
gary_posterhatch, no they do not, until we develop that functonality (I am calling it bundle v2 in the slides and such)16:52
gary_posterand yes, I use watch expressions16:52
hatchok cool16:52
gary_posterand I am returning to lunch :-)16:52
hatchso this is going to be a little more work than just 'hooking up the button'16:52
hatchjust FYI16:52
gary_posterhatch, oh?  why?16:53
hatchright now the 'deploy charm' button calls the deployCharm method which is bound to the App16:53
hatcher deployService16:53
gary_poster(can hangout if you want)16:53
hatchsure tha'll be faster16:53
gary_posterk16:53
gary_posterhatch https://plus.google.com/hangouts/_/10fe9c48d75b9ebbe273219cb03f4e53869ce4f716:53
hatchis there a known bug where you deploy a bundle and pan/zoom no longer work on the canvas in sandbox?17:16
hatchactually all canvas events appear to be broken17:16
bacgary_poster: webops is pushing back on a friday charmworld deployment.  worth pressing?17:16
hatchwell not all17:16
hatchannnnd done17:18
hatchgary_poster: good thing we had that chat lol17:18
bacgary_poster: nm, i have overwhelmed them with my rhetorical skillz17:21
bachey rick_h_, i'm a bit confused.  this record looks good in production http://manage.jujucharms.com/charms/precise/juju-gui/json17:25
bacrick_h_: but the fix (r412) has not yet been deployed.  can you see what i'm missing?17:25
hatchbac: lol17:27
bachatch: what you laughing at?17:28
hatch""nm, i have overwhelmed them with my rhetorical skillz""17:28
bacoh, not my unbrokenforunknownreasons code17:28
bacrick_h_: now we'll never know as the patch has been applied17:29
gary_posterbac, lol17:36
gary_posterhatch, cool :-)17:37
gary_posterhatch, if you are looking for something to do next, feel free to steal my bug 1236427.  I still suspect it will be easy but have not gotten to it yet.17:38
_mup_Bug #1236427: Scale up input stops working after units are added/removed <juju-gui:Triaged> <https://launchpad.net/bugs/1236427>17:38
hatchI'm just workign on the notifications now17:38
hatchand they are being...odd17:38
gary_posteroh ok17:38
gary_posterbad odd but good that you are working on them :-)17:38
* gary_poster steps away for just a couple more minutes, then will tackle that bug17:39
bacjujugui: manage.jc.com is now on 41617:39
gary_posterbac, awesome thank you17:39
MakyoGoing to step away to grab food for lunch, we're out.  Back in a few.17:40
gary_posterm.j.c looks healthy to me17:40
hatchohh sandbox doesn't call the rpc callbacks does it?17:41
rick_h_bac: yea, not sure. I wonder if it's some sort of 'recovers itself on successive' runs thing17:42
rick_h_bac: yay for upgrade17:42
bacrick_h_: don't see how it could've given that code structure.  dunno.17:42
bacrick_h_: maybe the upgrade and ingest just happened so fast i was looking at new data17:43
rick_h_bac: yea, me either. :/ 17:43
rick_h_possible I guess17:43
baci'm not going to lose sleep over it working properly17:43
hatchcan anyone confirm that the sandbox does not call the rpc callbacks? I always thought that it did17:43
rick_h_bac: :)17:44
hatchI think I broke something17:44
rick_h_hatch: stop doing that17:44
hatchfixed17:45
hatchsyntax error the linter didn't catch17:45
rick_h_lies!17:45
* hatch shakes fist at linter17:45
rick_h_the linter is all knowing!17:45
hatchor all-dumbing!17:46
hatchyeah....I went there17:46
baci love the new RT feedback form17:47
bacyou rate the effort by picking :(    :|   or  :)17:47
benjiI would hack the form to submit :P17:49
hatchso...hungry...17:51
hatchok proposing now going to grab some lunch18:00
hatchgary_poster: when I get back I can look at your bug if you aren't on it already18:00
gary_posterhatch, cool.  I'll see if I make progress18:02
hatchjujugui lf review https://codereview.appspot.com/1441906218:02
hatchannnnd I'm out18:02
gary_posteron it18:02
hatchthanks18:02
gary_poster"error: old chunk mismatch"18:04
gary_posterwonder what does that18:04
gary_posterhatch LGTM18:22
ahasenackhi guys, is [45133532 bytes] the size of the juju-gui charm in this verbose output? http://pastebin.ubuntu.com/6223679/18:34
gary_posterahasenack, don't know the log messages, but quite possibly.  the charm now includes the gui, rather than downloading it separately from LP, so once the charm is downloaded, the rest should go very quickly--and the total time should be as good or better than before.  This change supports deployments behind a firewall. be no slower than before, and arguably faster.18:39
ahasenackthat's a 40Mb+ upload18:40
ahasenacknot even landscape is that big18:40
ahasenackand it's still not finished18:40
ahasenack(the upload, not landscape ;)18:40
ahasenackwell, I don't know what it's doing now18:41
ahasenackgary_poster: are you saying the charm contains the juju-gui release tarball?18:42
gary_posterahasenack, yes18:42
gary_postertarball includes build tools.  does not need to.  but not a new issue.  should not be a problem, unless downloading charms is slower than downloading from LP?  how long has this taken, ahasenack?18:43
ahasenackit hasn't finished yet18:44
ahasenack"writing charm to storage [45133532 bytes]" took 10min18:44
ahasenackand that finished 12min ago18:44
gary_posterahasenack, huh.  what env?18:44
ahasenackcanonistack18:44
gary_posterah :-(18:44
ahasenackso, before this would all happen remotely18:44
bac45M.18:45
ahasenacknow it's actually a roundtrip? I download from jujucharms (UK -> BR), and then upload back to the UK?18:45
bacoops18:45
bac  /home/bac/charms/precise/juju-gui> du -sh .18:45
bac45M.18:45
bacso, yeah, the size you see is right18:45
ahasenackhow about versions? Before I could select trunk, release, etc. Now with the tarball inside the charm, how is that handled?18:46
gary_posterahasenack, charms are always a roundtrip.18:46
ahasenackgary_poster: yes, but not a 45Mb one :)18:46
gary_posterbut yes, if connection is slow, that's pretty painful18:46
gary_posterahasenack, yeah you can do all of that as before.  The default juju-gui-source is now "local"18:46
gary_posterbut if you choose something else behavior is still there18:47
gary_posterahasenack, we will prioritize two relatd bugs.  should get size  to less than 80% of current18:47
gary_posterI mean18:47
gary_postershould get it smaller than 20% of current size18:48
ahasenackthat helps :)18:48
ahasenackI can deploy landscape several times over while I'm waiting for "juju deploy juju-gui" to finish :)18:48
ahasenackI'll leave it running just for curiosity18:48
gary_posterahasenack, yeah, that's pretty bad.  We've had happy reports from this change, but yours is the first sad one :-)18:49
ahasenackI don't get what's wrong with a package in a source url, like ppa (you could open it up in a firewall), or even pointing to a local mirror18:49
ahasenackbut ok, people with big pipes win18:50
gary_posterahasenack, opening it up in a firewall leads to sucky directions.  setting up a local mirror leads to sucky directions.  this was prioritized because we repeatedly had enterprise situations in which this was a big annoyance, and then someone documented what was necessary to use the gui behind a firewall in preparation for publishing it, and it was horrible.  We wanted the story to be way better than that.  The thing18:52
gary_poster is, it would be good if we didn't cause huge pain for people with smaller pipes too.18:52
gary_posterSo hopefully shring to <20% will be enough of a win that it will work for both18:53
gary_postershrinking18:53
bacahasenack: are you using pyjuju?18:53
ahasenackthese guys seill need to be able to reach the charm store anyway18:53
ahasenackbac: no, core 1.1618:53
ahasenackand I think the icons are also fetched from the store at runtime18:53
bacahasenack: with juju-core it doesn't download locally, it goes straight from the charm store to the environment, iirc18:54
ahasenackbac: well, I don't know what's happening here, I could start some tcpdumps18:54
ahasenackbut this is my console right now:18:54
ahasenackhttp://pastebin.ubuntu.com/6223751/18:55
bacso a deploy to canonistack should be pretty fast regardless of where you're sitting (he says sitting behind crap isp)18:55
ahasenackand now would be 18:55 according to that timezone (it's using utc for some reason)18:55
ahasenackI think it's uploading, because my irc lag is 3.6s18:56
ahasenackmeaning upload link saturated18:56
bacright, just not the behavior i'd expect18:56
ahasenackyeah, it's talking to bootstrap18:57
ahasenackfinished18:57
ahasenack34min51s for "juju deploy juju-gui" to finish18:58
gary_poster:-(18:58
gary_posterahasenack, (1) we'll prioritize those bugs.  Hopefully that helps. (2) We'll ask juju core about this behavior, since we apparently don't expect it.18:58
ahasenackhttp://pastebin.ubuntu.com/6223761/18:58
ahasenackok18:59
bacah, since the juju-gui-source is local, it is our charm downloading it and then uploading again.  the charm went straight to canonistack but the juju-gui tgz did not.18:59
bacgary_poster: ^^18:59
gary_posterbac, ? why?19:00
gary_posterbac, when "local", it uses the juju-gui tgz that is part of the charm19:01
bacgary_poster: no, i think i got it wrong. i'm back to not understanding19:01
gary_posterk19:01
* bac afk for a bit19:04
ahasenackgary_poster: why was juju-gui the only charm with firewall problems? All charms before this one need to apt-get install something, so why were they not impacted?19:10
ahasenackbecause the ubuntu archive is a "known" variable, and the admins have it open in the firewall/proxy?19:11
gary_posteryes ahasenack 19:11
ahasenackand you don't have debian packages for juju-gui I presume19:11
gary_posterahasenack, bug 1238931; subscribed you.19:11
_mup_Bug #1238931: Juju GUI charm takes an inordinately long time to deploy over small connections <juju-gui:Triaged> <https://launchpad.net/bugs/1238931>19:11
ahasenackok19:12
gary_posterno, it's a pile of static files19:12
ahasenackok19:12
hatchgary_poster: re your comment - I'm pretty sure the topology doesn't have access to the app outside of the global 'app' pointer19:22
gary_posterhatch, no?  I'm pretty sure it has access to env, though, in which case this could be a helper that takes an env and a bundle?19:23
gary_posterhatch, just trying to reduce duplication19:24
hatchwell...we 'could' modify the deployerImport method to take a 'db' param so that it could deal with the notifications internally19:25
hatchbut that doesn't feel right19:25
gary_posterno19:25
gary_posterI meant19:25
gary_postera separate helper19:25
gary_posterthat takes, say, db, env, and the bundle19:26
gary_posterand handles it19:26
hatchohh, hmm we could....19:27
hatchtopology is kind of 'odd'19:27
hatchwe could pass it in19:27
hatchI suppose we are doing that already19:27
hatchenvironment.js:35419:27
gary_posterhatch I was thinking we could define it in a utils19:28
gary_posterbecause it would need a context19:28
gary_posterif you passed enough of one in19:28
hatchok how about this - I add a method in utils which is simply the callback for the env call19:29
gary_poster+1 I buy it19:29
hatchdeal!19:29
gary_poster:-) thanks hatch19:29
hatchno problemo19:29
benjigary_poster: I have backfilling working, but there are a few issues:19:31
* gary_poster listens19:32
benji1) my changes are completely untested (but they aren't huge changes, so I don't think that's too bad)19:32
benji2) because of the way ingest works, the elastic search index briefly contains *older* versions of the charms (because everything that comes in is indexed, there was no consideration that the things enqueued might not be the most recent version)19:33
benji3) the code needs to be spiffed up a little (lint, comments, etc.)19:33
* gary_poster does not yet understand #2 yet19:34
benji4) the way I got it working isn't the best in the world; once the above are fixed, it would be landable, IMO, but some deep thought ane refactoring of the injest mechanism is in our future19:34
benjigary_poster: call?19:35
gary_postersure.  can try your magic url again if you want, or https://plus.google.com/hangouts/_/10fe9c48d75b9ebbe273219cb03f4e53869ce4f719:35
benjithe hangout is fine19:35
gary_posterjujugui quick review/qa request for https://codereview.appspot.com/1451205619:36
Makyogary_poster, on it19:36
hatchon it19:36
hatchdamn19:36
gary_poster:-)19:36
Makyoup to you hatch 19:36
gary_posterthank you both19:37
MakyoI'll take a look, either way.  want to QA hatch ?19:37
hatchsure19:37
hatchdo we know why it was set to disabled on line 200 to begin with?19:38
MakyoBecause that was yanked from old code.19:38
MakyoI was wondering if it might be something like that.19:38
MakyoCheers to finding it, +1 gary_poster 19:38
gary_posterthanks Makyo 19:39
MakyoThose mixins are mostly view functions from old internal views, hatch 19:39
hatchahh19:39
hatchcoolio19:39
hatchthat would explain the lack of docs as well :P19:39
MakyoPerhaps.19:39
MakyoOne of these sleepless nights I'll go on a docs binge.19:39
Makyo(well, I'll probably watch a movie, but one can hope)19:40
hatchhaha19:40
hatchI think about project ideas and then write them down19:40
hatchif I dont' write them down I'm up all night19:40
hatchqa ok19:43
hatchdoes the constraints element do a wierd jittery jump for everyone else too?19:43
hatchat first I thought it was just on my laptop but now I noticed it on my desktop19:44
benjibac: I need to do some knowledge transfer with you about my current card, but I don't have time now; how long will you be around today / are you going to be here Monday?19:55
bacbenji: i will be in monday20:01
benjibac: ok, I'll get you early Monday then20:01
bacok.  benji did you get my email about that old branch of yours?20:02
benjibac: I hadn't seen it but I'll look as soon as I get back from my appointment.20:02
bacok.  have a good weekend20:03
hatchgary_poster: created the utils method, qa'd ok, wrote tests for it - I'm just going to submit if that's ok?20:11
gary_posterhatch +1 thanks!20:11
hatchcool - I open a new tab and chrome says google has updated their policies - I click the link, and it gives me a plain text version of what's changing and a direct link on how to fix it20:13
hatchI'm so used to 'our terms have changed, here are 300 pages of legal BS, try and figure out what changed'20:14
hatchgary_poster: so what now? mojitos?20:16
hatchI'm going to tidy up the SUmmary page20:32
hatchoh turns out it's already hooked u20:38
hatchp20:38
hatchheh20:38
gary_posterhatch, :-)20:40
hatchcan you think of anything for a 2h job?20:41
hatchelse I'd like to write a cache for the json load requests for our tests20:41
gary_posterhatch, "if bundle does not have x, y annotations we handle it gracefully (example: don't show visualization)" is good.  just marked it high.  what's the json load?  you mean from the local server?20:42
hatchok that'll work20:43
hatchyeah - so we aren't hitting IO every test :)20:43
gary_posterhatch, either one is fine.  do whichever you wish.20:43
gary_posterIf you want me to make up my mind, I'll choose the bundle one, but happy for you to choose.20:43
hatchnah I'll do the bundle one20:44
hatchreal work comes first :)20:44
gary_poster:-) k20:44
hatchgary_poster: just fyi after this branch lands we won't ever see a bundle env again :)20:53
hatchbecause none of them have xy's hah20:53
gary_posterhatch I know :-( .  Maybe make a feature flag?20:54
hatchyeah that's kind of what I was thinking too20:55
gary_posterugh apache hates me21:28
hatchdon't feel bad, apache hates everyone21:37
hatchit's all like "don't act like we're friends....you don't know me!"21:38
gary_poster:-)21:39
gary_posterhatch btw your fancy ghost inspector name checker no longer works.  if you are still looking for something to do at some point you could fix that up :-) but no rush21:41
gary_posterIs Upgrade not supposed to work in sandbox?21:41
Makyogary_poster, I was just thinking about that.  In sandbox, there's no juju backend to provide the older charms.21:42
hatchgary_poster: hmm, which fancy namechecker is that?21:43
* hatch pleeds the 5th21:43
gary_posterMakyo, ah ok.  Sounds like something we could build eventually, but for now we ought to say "if sandbox hide"?  Which I bet would be annoying, since you just ripped out the featureflag code :-/21:43
gary_posterhatch, for instance, deploy mediawiki twice21:43
Makyogary_poster, that's what I was thinking.  It's not too big of a deal, though, since a lot of those checks were in other if statements.21:43
gary_posterhatch o i c21:44
gary_posterhatch it works but it doesn't initialize properly21:44
hatchoh I see21:44
gary_posterso for instance if you deploy a mediawiki without changing the name21:44
hatchyeah soemthing must have changed there21:44
gary_posterand then try it again21:44
gary_posterit should have an x21:44
hatchright21:44
MakyoSo this position thing is a race condition with removing annotations, which finally showed up in FF because I left the debugger on a breakpoint while talking to roommate. :P21:44
gary_posterbut if you change it and change it back the x appears21:44
gary_posterMakyo, heh21:45
gary_posterhatch oh but now x does not get removed either.  I'll file bug later21:45
hatchgary_poster: ok - I can look at it right away, just lboxing the graceful failing code right now21:46
gary_postergreat thanks hatch21:46
gary_posterI have a nice change that reduces our distribution tarfile by >80%.  21:47
gary_posterBut I can't figure out how to test it in apache other than symlinking build-prod contents in /var/www :-(21:47
gary_posterby enabled custom site is ignored21:47
gary_postermy21:47
gary_posterand I need to include instructions for how to test it in a release21:48
gary_posterMaybe I should try nginx :-P21:48
hatchhmm I did know how to do that21:49
gary_posterI copied everything out of our charm; I have permissions right on files and in config file; no errors; it is enabled, because when I make a deliberate error, it throws up; but I always only ever get the /var/www content21:50
hatchhmm21:50
hatchI just looked through my httpd.conf file and it's all giberish to me now :/21:51
hatchsorry21:51
gary_posterlol np thanks.  trying nginx21:51
hatchjujugui lf a review and qa of https://codereview.appspot.com/14502061/ plz21:58
gary_posteron it21:58
hatchthanks21:59
gary_posterhatch made a small test request; otherwise LGTM.  Doing qa now22:04
hatchthanks22:04
gary_posterbcsaller, hey.  what do we need to do to produce exports with x y annotations?  really would be great to have those asap.  I think you have this figured out?22:06
* gary_poster curses at xchat internally yet again22:10
gary_posterhatch, qa ok as intended.  Feel free to land with my thanks.  Am I right that it would not be a trivial task to make the Bundle tab hide instead, or to default to Summary if the xy coords are not there?22:11
hatchyup - we could just delete the elements from the template then they won't get PE'd when we render the tabview22:12
hatchwould you prefer I do that instead?22:12
hatchFYI according to the tests it takes 50ms to render the bundle topology off screen :)22:15
hatchthat's actually pretty substancial22:15
gary_posterhatch, I think that would be better to delete but welcome your opinion22:16
gary_posterhatch, re: rendering time, is there something to do?22:17
hatchprobably not22:17
hatchat least not without looking into the actual topology code22:17
hatchto see what's happening there22:17
gary_posterok22:18
gary_posterI don't see a danger there yet22:18
hatchas far as deleting the tab goes a) the user is none the wiser and it looks better for it b) the user wonders why it doesn't have the topology while others do22:18
gary_posterso won't do anything22:18
hatchnah I wouldn't waste time on it now22:18
gary_posterok22:18
gary_postera: yes22:18
gary_posterb: arguably similar to the default icon  story?22:18
hatchoh there is a c)22:19
hatchc) we autolayout the bundle22:19
hatch:)22:19
hatch(always need a c)22:19
gary_posterheh22:20
gary_posteryeah c is alright but no time :-P22:20
hatchI'm sure Makyo is just looking for new layout features to add right now22:20
gary_posterand results are not good22:20
hatchlol22:20
gary_posterheh22:20
hatchalright a) it is22:20
hatchd) it could delete the tab and land on the charm tab so it has the charm details22:21
hatch:)22:21
gary_posterhatch, that's actually even better :-)22:22
gary_posterif you get around to it22:22
gary_postermust run22:22
gary_posterhave a great vacation hatch! enjoy!22:23
hatchthanks, have a good weekend!22:23
gary_posterthanks :-)22:23
bcsallergary_poster: sorry missed your question before,  I can extract that patch now, its very small22:38
bcsallergary_poster: http://paste.ubuntu.com/6224554/22:40
bcsalleroh, too late22:41
hatch:)22:49
hatchoh crap I proposed instead of submitted22:52
hatchoh well22:52
hatchheh22:52

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!