/srv/irclogs.ubuntu.com/2013/10/11/#ubuntu-unity.txt

tsdgeosSaviq: i can't change the dash while it's rebounding :S07:47
mzanettio/07:54
greyback\o07:54
mzanettiSaviq: any high priority issue to tackle or should I continue with fixing the preview stuff?07:54
tsdgeoscan any of you guys try to repro https://bugs.launchpad.net/unity8/+bug/1238094 ?08:03
ubot5Ubuntu bug 1238094 in unity8 (Ubuntu) "Header in LVWPH gets confused when rebounding" [Undecided,New]08:03
tsdgeosi don't seem to be able to sweep horizontally while it's rebounding08:03
tsdgeosoh08:06
greybacktsdgeos: I managed something08:06
tsdgeosi can if the scope doesn't fill all the screen08:06
tsdgeosinteresting08:06
tsdgeosnot anymor08:06
tsdgeosand now i can again08:07
tsdgeosthe question is, do we always want to simply disable h-swiping while rebounding or we always want to enable it?08:09
om26erwe are not caching thumbnails ? if I expand the 'more suggestions' category everytime there are blank icons and they load after a few seconds. that looks ugly08:11
om26erthe same happens in the Music scope or video08:12
om26ers/or/and08:12
mhr3tsdgeos, any ideas about https://bugs.launchpad.net/unity8/+bug/1238302 ?08:16
ubot5Ubuntu bug 1238302 in Unity 8 "Category reordering causing column "shifting" in overridden result model" [Undecided,New]08:16
tsdgeoshmmm08:16
tsdgeosnope, but it's interesting08:16
* tsdgeos has a look while someone who can decide what we want to do with #1238094 comes up (i.e. Saviq) :D08:17
tsdgeosmhr3: how do you reproduce exactly? can't seem to unerstand the bug text :-S08:18
mhr3tsdgeos, yea.. my bug reporting skills are low at midnight :/08:19
mhr3let me try again08:19
mhr3tsdgeos, perhaps now08:22
Saviqbug #123809408:22
ubot5bug 1238094 in unity8 (Ubuntu) "Header in LVWPH gets confused when rebounding" [Undecided,New] https://launchpad.net/bugs/123809408:22
Saviqtsdgeos, yeah, me neither08:23
tsdgeosmhr3: should the application category even be there?08:23
mhr3tsdgeos, well it shouldn't be overridden, but we're probably not going to fix that for 13.1008:24
tsdgeosSaviq: thing is, you can only swipe horizontally if you drag from an "empty space", i.e. if there's a category you can not drag horizontally to change the scope while it's vertically rebounding08:24
Saviqtsdgeos, ah08:24
tsdgeosSaviq: so basically i'd say "disable horizontal scrolling enterely" when we are rebounding08:25
tsdgeossaves us a lot of pain08:25
Saviqtsdgeos, huuh, btw, do you have like 6 horizontal dividers below "Apps" in home scope?08:25
Saviqtsdgeos, +1 - when it's moving - no moving to the sides08:25
tsdgeosSaviq: nope08:25
tsdgeosSaviq: but i saw that regularly before we fixed the bug in qsortproxymodel08:26
* Saviq flashes08:26
tsdgeosSaviq: maybe there's still something that needs more kicking in there? or your qt is old?08:26
Saviqtsdgeos, flashed yesterday...08:26
tsdgeosok, then it's defenitely not your qt08:26
Saviqtsdgeos, either way - I can't see any glitches when I *do* manage to swipe the dash while it's moving08:26
tsdgeosSaviq: sometimes the header gets in the middle08:27
tsdgeosit's maybe even easier if you do in applications scope08:27
tsdgeosscroll it up, then quickly left from the botto08:27
tsdgeoscome back08:27
tsdgeosthe header is in the middle08:27
Saviqtsdgeos, I can see it behaving weirdly while it moves - but never did get it to end up in the middle08:28
tsdgeosi can repro quite easily here08:29
tsdgeosbut tbh i agree we should just disable h-swipe if it's moving vertically08:29
Saviqtsdgeos, anyway +1 on disabling ←→ while ↓↑08:29
tsdgeossince we kind of half do that already08:29
* tsdgeos gets on it08:29
Saviqveebers, thanks for digging for input08:31
Saviqveebers, dashboard, fortunately, runs just one test at a time ;)08:33
tvoss_Saviq, good morning. Anything you want me to test or look into for u8?08:43
Saviqtvoss_, veebers did some digging for https://bugs.launchpad.net/mir/+bug/123841708:44
ubot5Ubuntu bug 1238417 in Mir "Unity does not process events from evdev device created before unity is restarted (autopilot tests)" [Critical,Confirmed]08:44
Saviqtvoss_, and what's more - found a workaround08:45
tvoss_woot08:45
Saviqtvoss_, I filed some crashers bug #1238287 bug #1238116 bug #1238107 - some of them you saw already08:45
ubot5bug 1238287 in unity8 (Ubuntu) "unity8 crashed with SIGABRT in raise()" [High,Confirmed] https://launchpad.net/bugs/123828708:46
ubot5bug 1238116 in unity8 (Ubuntu) "unity8 crashed with SIGSEGV in QIcon::~QIcon()" [Medium,New] https://launchpad.net/bugs/123811608:46
ubot5bug 1238107 in maliit-framework (Ubuntu) "maliit-server crashed with SIGSEGV in __GI___pthread_mutex_lock()" [Medium,New] https://launchpad.net/bugs/123810708:46
Saviqmzanetti, there?08:46
mzanettiSaviq: yes08:46
Saviqmzanetti, re: https://code.launchpad.net/~mzanetti/unity-mir/fix-appid-parsing/+merge/19041908:46
Saviqmzanetti, we need to make sure everything works as it did08:46
Saviqmzanetti, i.e. launching with --desktop-file-hint=/full/path08:47
Saviqerm _ _08:47
mzanettiSaviq: yes. this is exactly what it fixes08:47
Saviqmzanetti, or --desktop_file_hint=basename.desktop08:47
mzanettioh... is that supposed to work?08:47
Saviqas well as application:///full/path.desktop and application:///appid.desktop08:47
mzanettimhm... ok. need to check again08:47
mzanettiwill do now08:47
Saviqmzanetti, we did enable it for *some* reason08:48
Saviqmzanetti, obviously won't be able to tell you what the reason was08:48
Saviqmzanetti, but while we have this, let's not break it08:48
mzanettisure08:48
Saviqmzanetti, we also need to make sure it all works on sflinger08:48
mzanettiSaviq: this code isn't used with SF at all08:48
Saviqmzanetti, right, of course ;)08:49
mzanettiSaviq: and is only used when calling something from cmdline with --desktop_file_hint. but yeah. It probably breaks the two above08:49
mzanettiwill fix08:49
Saviqmzanetti, truth is, maybe we should adapt sflinger's appmanager to store the app id and not the desktop file path, but I'm not entirely sure we want to open that pandora's box08:51
mzanettiSaviq: not sure I understand... we DO use the appId. that's exactly the issue it fixes08:51
=== iahmad is now known as iahmad|afk
Saviqmzanetti, aah, but we didn't in unity-mir?08:52
Saviqmzanetti, k08:52
tvoss_Saviq, asked pitti to help with https://bugs.launchpad.net/mir/+bug/123841708:52
ubot5Ubuntu bug 1238417 in Mir "Unity does not process events from evdev device created before unity is restarted (autopilot tests)" [Critical,Confirmed]08:52
mzanettiSaviq: current code has an issue that it uses the full .desktop path when calling from cmdline08:52
mzanettiSaviq: but uses the appid everywhere else08:52
Saviqmzanetti, right, 'stood08:52
Saviqmzanetti, anyway, I'll stop now :)08:52
mzanettilemme add some better description to the MR08:53
tvoss_Saviq, got a better stack trace for https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/123828708:54
tvoss_?08:54
ubot5Ubuntu bug 1238287 in unity8 (Ubuntu) "unity8 crashed with SIGABRT in raise()" [High,Confirmed]08:54
Saviqtvoss_, I *did*, but f*cking retracing service removed it apparently08:55
Saviqtvoss_, when it decided to mark as dupe08:55
tvoss_Saviq, damn it08:55
Saviqtvoss_,  but I could easily reproduce it - let me try again08:56
Saviqyup, there it goes08:56
Saviqwill be with you in 508:56
tvoss_Saviq, thx08:57
tvoss_Saviq, see #ubuntu-mir08:57
tvoss_Saviq, https://launchpadlibrarian.net/153403487/StacktraceSource.txt indicates that maliit is trying to start, not to stop08:58
tvoss_which contradicts the bug description08:58
Saviqtvoss_, thing is this happens when unity8 is being stopped sometimes08:59
Saviqtvoss_, maliit spins the CPU08:59
Saviqtvoss_, and prevents unity8 from exiting08:59
Saviqtvoss_, but maybe the trace isn't right08:59
tvoss_Saviq, sure, but the stack trace is not the one of a spinning maliit, but the one of a restarting maliit wihtout u808:59
tvoss_running09:00
Saviqbtb09:00
Saviqbrb09:00
dednickCimi: https://code.launchpad.net/~nick-dedekind/ubuntu-settings-components/qmltest.deps/+merge/19055709:03
dednickwhen you get a minute :)09:04
mzanettiSaviq: hmm... just checked with the currently released code. none of those examples you made works right now09:09
mzanettiSaviq: and frankly, they seem wrong :D09:10
Cimidednick, ok09:10
tvoss_Saviq, mzanetti so the root cause of https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/123811609:14
ubot5Ubuntu bug 1238116 in unity8 (Ubuntu) "unity8 crashed with SIGSEGV in QIcon::~QIcon()" [Medium,New]09:14
tvoss_seems to be that an icon owns the icon engine it has been loaded from and deletes the engine in its private dtor, which in turn makes the engine delete all its associated icons ...09:15
tvoss_Saviq, mzanetti this happens after main, when destructing globals, i.e., the icon cache, which has already been cleared by a post routine09:16
* mzanetti reads through the bug09:16
mzanettimhm... I see09:17
tsdgeosSaviq: are we not using DashVideos and DashMusic anymore?09:19
tsdgeosor desktop != phone in this regar09:19
tsdgeosd09:19
mzanettitsdgeos: afaik at least DasVideos is obsolete09:21
tvoss_mzanetti, I don't understand why QIConPrivate should delete the engine pointer09:21
mzanettitsdgeos: and the whole Dash directory seems to desperately need a cleanup09:21
tsdgeosmzanetti: +1 :D09:21
tvoss_mzanetti, a quick fix would be: make the engine pointer a QSharedPointer in https://qt.gitorious.org/qt/qt/source/e709077eff4d8b05cc9022d85dcb48587d96c720:src/gui/image/qicon.cpp#L10909:22
tvoss_mzanetti, with that, we do not need to worry about deallocation at all, and the last icon will automatically take the engine down09:22
mzanettitvoss_: hmm... not sure... but I don't think that's something new.09:23
tsdgeostvoss_: because it's how it works :D09:23
Saviqtsdgeos, no, we're not using them09:23
tsdgeostvoss_: it's a QIconEngine not a QIconsEngine, i.e. it's for this particular icon09:23
tvoss_tsdgeos, not according to https://launchpadlibrarian.net/153404403/Stacktrace.txt09:24
Saviqmzanetti, wtym "none work"? :D09:25
tsdgeosSaviq: ok, so i'll propose a merge to kill them it's pretty confusing to still them have around09:25
Saviqtsdgeos, +109:25
mzanettiSaviq: log in your mir enabled phoen and try to launch some binary with --desktop_file_hint holding something else than an absolute file path09:25
mzanettiSaviq: won't work right now09:25
tsdgeostvoss_: what makes you say from that backtrace that there are two icons with the same icon engine?09:26
mzanettiSaviq: and imho --desktop_file_hint=application:///appId.desktop is plain wrong. same with application:///full/path.desktop09:26
Saviqmzanetti, `webbrowser-app --desktop_file_hint=webbrowser-app` worked for me09:26
Saviqmzanetti, right, of course, /me stupid09:27
Saviqmzanetti, the application:/// things were about using them in activation09:27
Saviqmzanetti, not with desktop hints09:27
Saviqmzanetti, like from the launcher or dash home apps09:27
mzanettiSaviq: right... true. the correct appId should work09:27
mzanettiSaviq: I can reenable that one as it doesn't seem totally wrong (just a little)09:27
tvoss_tsdgeos, hang on, reading through source code09:29
tsdgeostvoss_: i agree it could be that, but is not necesarily that09:29
tvoss_tsdgeos, looking what the engine is doing09:30
tvoss_tsdgeos, yup, circular delete. QIconLoaderEngine has multiple entries (ScalableEntry, which have a QIcon member), so we have a one-to-many-relation, which contradicts every icon exclusively owning the engine09:35
tsdgeostvoss_: not really, it's icon has it's own engine09:35
tsdgeostvoss_: check the code on how can you end up with different icons having the same engine09:36
tsdgeosyou can't09:36
tsdgeosthere's like 5 places where the engine is set, and it's always "new fooEngine"09:36
mzanettiSaviq: "fixed"09:37
Saviqmzanetti, not happy? ;)09:39
tvoss_tsdgeos, but https://qt.gitorious.org/qt/qtbase/source/6c06e14a49773ce5572935864ed6b9be219c6103:src/gui/image/qiconloader.cpp09:39
Saviqmzanetti, I'm generally of the opinion that we need to take a step back and stop parsing all that in 5 different places09:39
tvoss_tsdgeos, clearly says that the loader engine can have multiple entries ... which makes sense09:39
mzanettiSaviq: it feels still wrong to give some else than a desktop file in --desktop_file_hint :)09:39
Saviqmzanetti, *all* apps should be launched via url-dispatcher09:39
Cimiwhich are the id I can access from one component of the shell?09:40
CimiI know I can access shell09:40
mzanettiSaviq: yes. I agree09:40
Cimican I access the lock screen as well?09:40
Saviqmzanetti, as I said - I'm not even sure we need it, but we did enable it somewhere - maybe you can find the commit?09:40
Cimiwith id lock screen?09:40
mzanettiSaviq: well, of course we should still support running them in the command line09:40
Saviqmzanetti, through upstart09:40
Saviqmzanetti, or url-dispatcher09:40
tsdgeostvoss_: what line exactly?09:41
tvoss_tsdgeos, 33209:41
Saviqmzanetti, that's going to be the only way to launch apps - we need a single point where that happens - and match PIDs to app ids09:41
Saviqmzanetti, otherwise we'll end up with BAMF again09:41
mzanettiSaviq: wasn't there something new in the f.d.o spec that would solve that issue?09:42
Saviqmzanetti, yeah, launching via application:///09:42
Saviqmzanetti, or something09:42
Saviqmzanetti, either way - on Ubuntu it'll end up going through upstart09:42
tvoss_Saviq, why do we still need the desktop file hint?09:43
Saviqtvoss_, legacy09:43
tsdgeostvoss_: sure, a QIconLoaderEngine can have multiple m_entries which are QThemeIconEntries, some of them are QIcons and those will have different QIconEngines, that is all fine still, i don't see how it will end up in circular deletion09:43
Saviqtvoss_, just a workaround until we say "now it's over"09:43
tvoss_Saviq, ack09:43
mzanettiSaviq: well, anyways, my branch now shouldn't break anything existing any more and still fix the --desktop_file_hint thingie (and with it the autopilot tests)09:44
Saviqmzanetti, \o/09:44
Saviqgreyback, o/09:53
=== alan_g is now known as alan_g|vt
tvoss_tsdgeos, hmmm, just found a ocmment: simply reuse svg icon engine09:53
tvoss_greyback, o/09:53
tsdgeostvoss_: where's that?09:54
tvoss_tsdgeos, https://qt.gitorious.org/qt/qtbase/source/6c06e14a49773ce5572935864ed6b9be219c6103:src/gui/image/qiconloader.cpp09:54
tvoss_line 53109:54
greybackSaviq: tvoss_ hi!09:55
Saviqgreyback, see, and we don't even want anything from you!09:55
Saviqat least not straight away09:55
greybackI find that hard to believe09:56
greyback:)09:56
tsdgeostvoss_: the comment looks scary indeed, but then the code doesn't seem like it does anything scary :D09:56
tsdgeostvoss_: btw i'm not saying there's no bug, i'm saying i just don't see how it could happen by reading the code09:57
tvoss_tsdgeos, there has to be an engine being reused behind the scenes, otherwise, no icon would be loaded09:57
tvoss_tsdgeos, yup :) trying to convince you09:57
tsdgeostvoss_: why do you say the engine has to be reused?09:57
tvoss_tsdgeos, and I have a suspicion that a global instance is reused somewhere09:57
tsdgeosthere is a global cache of QIcons, that is true09:58
tvoss_tsdgeos for the icon to load anything it needs an engine instance: https://qt.gitorious.org/qt/qt/source/e709077eff4d8b05cc9022d85dcb48587d96c720:src/gui/image/qicon.cpp#L10909:58
tsdgeosyes, that's the global icon cache09:58
tsdgeosQCache<QString, QIcon> IconCache;09:59
tsdgeosand yes every QIcon has an engine to load stuff, but still from what i can see, every QIconPrivate has it's own engine10:00
Saviqmzanetti, can you see what you get with your fix and https://code.launchpad.net/~saviq/unity8/workaround-lp1238417/+merge/190574 on the device?10:05
Saviqmzanetti, the only remaining issues it seems would be crashes/hangs10:06
mzanettiSaviq: ack10:07
Saviqmzanetti, other than that - fix switching previews please!10:08
mzanettiSaviq: ok10:09
Saviqmzanetti, would be awesome to get them n10:09
Saviqin10:09
mzanettiSaviq: I agree it would be nice, didn't seem like top priority to me though. but if we're mostly good otherwise, I'm happy to fix them10:10
MacSlowSaviq, did you get a change to try out the sim-unlocking?10:10
SaviqMacSlow, yeah +1'd10:10
SaviqMacSlow, and it's merged, AFAIK10:10
MacSlowSaviq, :)10:10
SaviqMacSlow, notifications look awful on top of indicators though10:10
SaviqMacSlow, bug #123817410:11
ubot5bug 1238174 in Unity 8 "notifications / snap decisions over indicators blend into background" [Undecided,New] https://launchpad.net/bugs/123817410:11
MacSlowSaviq, *shrugg*10:11
SaviqMacSlow, also bug #123818210:11
ubot5bug 1238182 in Unity 8 "Should close indicators when triggered anotification or an application" [Undecided,Incomplete] https://launchpad.net/bugs/123818210:11
SaviqMacSlow, but not critical of course10:11
Saviqgreyback, can do https://code.launchpad.net/~mzanetti/unity-mir/fix-appid-parsing then?10:12
MacSlowSaviq, I'm in review/testing mode still... but if you want me to chase that I can10:12
Saviqgreyback, didn't get to it10:12
SaviqMacSlow, no no10:12
SaviqMacSlow, just filed them so that we don't forget10:13
greybackSaviq: please do10:13
MacSlowSaviq, ok... looks certainly like something for Design to look over10:13
Saviqgreyback, that was a "can you... do?" ;)10:13
greybackSaviq: oh, sure, yes I'll look after it then10:13
MacSlowSaviq, maybe it'll become less of issue once the much updated UbuntuShape lands in tookit trunk10:14
tsdgeosSaviq: https://code.launchpad.net/~aacid/unity8/dash_disable_hswipe_on_vswipe/+merge/19057610:14
tvoss_tsdgeos, I'm not referring to the global cache, the qiconloader engine has got multiple entries carrying a QICon, too10:14
tsdgeosSaviq: https://code.launchpad.net/~aacid/unity8/remove_unusued_dash_videos_music/+merge/19058810:14
MacSlowSaviq, with that outter shadows will be possible... probably providing some more contrast against the background... we'll see10:15
tsdgeostvoss_: yes, but for the crash to happen, the QIconPrivate of those QIcon should have as engine the same QIconLoaderEngine that is trying to delete them, and as far as i can see i see nowhere were QIcon*Engine are reused in different QIconPrivate10:16
SaviqMacSlow, yup10:17
tvoss_tsdgeos, well, it is already weird that the global dtor is actually finding icons in the cache, as the post cleanup function should already have cleared the cache10:19
tsdgeostvoss_: that is also true10:21
tsdgeoswonder if it's just crashing there because of bad luck10:21
tvoss_tsdgeos, it's weird that there is a cleanup function and a global static deleter wrapper thingy10:21
tsdgeosand it's just that memory is just broken already before reaching there10:21
tsdgeostvoss_: maybe one predates the other :D10:22
tsdgeoss/maybe/probably10:22
tvoss_tsdgeos, yup10:22
tsdgeosactually it's not until qt5 that they have static deleters afaik, copied/inspired by kde having them10:22
=== _salem is now known as salem_
tvoss_tsdgeos, perhaps removing the cleanup handler would already work10:23
tsdgeoswork as in "fix the crash" or work as in "still do what it's supposed to do"?10:24
tsdgeostvoss_: i guess we don't have the core file that caused that backtrace, no?10:30
tvoss_tsdgeos, that's a question for saviq10:30
Saviqtsdgeos, just start unity8 and stop unity810:30
Saviqtsdgeos, under Mir10:30
Saviqtsdgeos, if it's not attached to the bug, that is10:31
tsdgeosSaviq: crashes all the time? some? half?10:31
Saviqtsdgeos, all10:31
Saviqtsdgeos, although sometimes differently10:31
tsdgeosok10:31
Saviqtsdgeos, but if you just stop unity8; unity8; ^C10:31
Saviqtsdgeos, you should get it10:31
tsdgeosok10:31
=== hikiko is now known as hikiko|lunch
tvoss_Saviq, I thought you said https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1238287 had a better stacktrace now?10:34
ubot5Ubuntu bug 1238287 in unity8 (Ubuntu) "unity8 crashed with SIGABRT in raise()" [High,Confirmed]10:34
Saviqtvoss_, didn't retrace it yet10:35
tvoss_Saviq, ah10:35
Saviqtvoss_, or, the retrace failed10:35
Saviqtvoss_, but easy to repro, so I'll get it10:35
tvoss_Saviq, great, thx10:35
om26erMacSlow, suggestion. When the password dialog for wifi network appears. the focus should be on the password field so that OSK automatically appears :)10:46
MacSlowom26er, true10:47
SaviqMacSlow, om26er might be kinda tricky when there's more input fields10:55
SaviqMacSlow, om26er, maybe the indicator should mark one of the fields to be focused10:55
om26erSaviq, in that case focus the first input box10:55
Saviqom26er, yeah, we don't know how many there are ;)10:55
Saviqom26er, or the order they come in10:55
MacSlowSaviq, don't be the devil's advocate... more than two text-entries?! :)10:55
SaviqMacSlow, two is enough to not know :)10:56
SaviqIMO indicator should mark one that's supposed to be focused on creation10:56
tsdgeosah10:57
tsdgeosno ah10:57
Saviqtvoss_, uploade a retraced .crash file to bug #123828710:57
ubot5bug 1238287 in unity8 (Ubuntu) "unity8 crashed with SIGABRT in raise()" [High,Confirmed] https://launchpad.net/bugs/123828710:57
Saviqtsdgeos, rofl10:57
om26erMacSlow, slow if the password box appears and I tap 'Cancel' the dialog should vanish. right now it asks the password again10:57
om26er*also :)10:57
MacSlowom26er, that's the triggering app not the notifications10:58
MacSlowreponsibility10:59
om26eraah10:59
MacSlowresponsibility even10:59
MacSlowom26er, remember... notifications are not domain/context-aware11:00
=== shentey_ is now known as shentey
=== salem_ is now known as _salem
Saviqom26er, there's a bug11:07
Saviqom26er, bug #123638611:08
ubot5bug 1236386 in Network Menu "Wi-Fi selection offers two opportunities to connect" [Medium,Triaged] https://launchpad.net/bugs/123638611:08
om26erSaviq, cool. I have very small testing on a secure wifi network. I just happened to be at a place where the network was password projected so faced that issue11:08
=== MacSlow is now known as MacSlow|lunch
Saviqom26er, scary, as mentioned ;)11:09
Saviqom26er, you know securing networks is not about people not being able to "steal your internet" but "steal your data" instead? ;)11:09
om26erSaviq, I think no one in the neighborhood have those skills but I get your point :)11:10
Saviqom26er, "skills"? like connect to your network and access the services you left unintentionally open? ;)11:11
om26erSaviq, I don't mind they use some of the free internet ;). also this house is big even I don't get signals in some rooms..11:12
om26eri should enable password still..11:12
Saviq:D11:13
Saviqdidrocks, can we get the Qt fix in today?11:16
didrocksSaviq: which qt fix? we have 4 in flight :p11:17
Saviqdidrocks, ah, the looping11:17
Saviqdidrocks, bug #123676511:17
ubot5bug 1236765 in qtdeclarative-opensource-src (Ubuntu) "[PATCH] Fix infinite loop in QQmlIncubator::forceCompletion" [Undecided,In progress] https://launchpad.net/bugs/123676511:17
didrocksSaviq: already in proposed11:17
mzanettiSaviq: this is with our branches combined: http://paste.ubuntu.com/622195911:17
Saviqdidrocks, awesome11:17
Saviqmzanetti, how about the rest of the tests? :D11:18
Saviqmzanetti, but yeah, means it's working11:18
Saviqmzanetti, approve/merge, then?11:18
mzanettiSaviq: yeah... exactly... not sure, did tsdgeos fix the others yet?11:18
mzanettiSaviq: yep, can approve yours11:18
Saviqmzanetti, there were no other real failures11:18
mzanettiah ok11:18
Saviqmzanetti, only crashes and stuff11:18
mzanettiright... I had one crash too11:18
mzanettiSaviq: ah I think I'm close in reproducing the edge drag crash11:19
mzanettiSaviq: can reproduce it by frequently tapping 2 edges (e.g. left + right)11:19
Saviqmzanetti, oh good, if you get a .crash at any point11:19
Saviqmzanetti, send it to me11:19
tsdgeostvoss_: you know what's interesting? in the desktop that cache is not destructed if you kill -15 the process, just if you shut down it properly (i.e. alt+f4)11:19
mzanettiSaviq: well, I do have a quite useful crash trace.11:19
mzanettiSaviq: but reading through the code I'm not sure how we could end up in that situation11:20
Saviqmzanetti, ah11:20
tsdgeostvoss_: my current guess is that the thing is being executed when it should not, and the svg lib is already unloaded and thus can't delete properly the QSvgIconEngine because it has no clue on how to do it11:20
tsdgeostvoss_: but not sure if it can be possible that the svglib is already unloaded and no idea how to check if it has happened11:20
tsdgeosanyone knows enough about C++/elf app shutdown to say how/if libs are unloaded on shutdown?11:21
=== hikiko|lunch is now known as hikiko
tvoss_tsdgeos, why kill -15? kill -9 should be enough11:21
mzanettiSaviq: this is it btw: http://paste.ubuntu.com/6133905/11:22
tvoss_tsdgeos, I would think getting rid of the cleanup should help11:22
tsdgeosof course would help11:22
tsdgeosbut it's the wrong thing to do :D11:22
mzanettiSaviq: so what happens is that we get an invalid touch event in touchEvent_recognized(event *)11:22
tvoss_tsdgeos, not really, because the cache is destructed anyway in qt511:22
tsdgeostvoss_: wait, with cleanup you mean that11:22
Saviqmzanetti, :/11:22
tvoss_tsdgeos, post main, that is11:22
tsdgeostvoss_: no it won't help, that code is not executed on the phone11:22
mzanettiSaviq: would be easy to fix by adding a check there. but doesn't feel like its the right place to fix it11:22
tvoss_tsdgeos, ?11:23
tsdgeosbecause that code only executes on "correct" shutdown11:23
tsdgeosand we're killing it11:23
tsdgeosnot doing correct shutdown11:23
tvoss_tsdgeos, we are really just kill -9'ing it?11:23
tsdgeostvoss_: not sure what "stop unity8" does, but i guess something along the lines11:24
tsdgeosi mean how do you stop it otherwise?11:24
tvoss_tsdgeos, I would assume it sends a friendly sigterm first, before it gets out the gun11:24
tsdgeossure11:24
tsdgeos-1511:24
tsdgeosthat's what i said11:25
tvoss_tsdgeos, ah, sorry11:25
tsdgeosanyhow11:25
tsdgeoswhen we -15 it11:25
tvoss_tsdgeos, but the cleanup handler should run with -15, too11:25
tsdgeosit doesn't execute QCoreApplication deletion11:25
tsdgeosso the postroutines are not executed11:25
tsdgeosonly the static deletion ones11:26
Cimino idea what I'm doing wrong11:26
CimiI'm trying to connect the genericscopeview with the shell or greeter11:26
CimiI have this connection with proper target, nothing works11:26
tsdgeosCimi: code?11:34
Saviqoh interesting11:35
Saviqmzanetti, can you try: stop maliit-server; autopilot run unity8.shell.tests.test_lock_screen.TestLockscreen.test_can_unlock_passphrase_screen11:35
Saviqmzanetti, and do the same after starting maliit again11:35
mzanettiSaviq: sure11:35
Cimitsdgeos, with surprise I realised the unlock signal of lock screen and greeter is not what I thought it was11:35
CimiI don't think it's emitted when I slide the lockscreen11:36
Saviqmzanetti, for me I'm not getting keyboard input unless maliit is up11:36
mzanettiSaviq: confirmed11:38
mzanettiwhich seems really weird tho11:38
Saviqindeed11:38
mzanettiSaviq: I think there was some WIP to actually use maliit to inject the events. no idea how far that got11:39
mzanettiI thought we'd still use /dev/uinput11:40
Saviqmzanetti, not that it should matter anyway11:40
Saviqmzanetti, yeah we are11:40
mzanettiSaviq: must be something in the the qpa. as it obviously works on the desktop without maliit being up11:41
mzanettiSaviq: probably some if (!maliit.connected()) return11:41
om26erhttps://code.launchpad.net/~om26er/unity8/header_height_dash_5gu/+merge/19062211:45
Saviqthanks om26er11:48
greybackSaviq: hey, I've 2 branches attached to https://bugs.launchpad.net/unity8/+bug/1237850 - who can review?11:48
ubot5Ubuntu bug 1237850 in Unity 8 "Apps started via upstart don't participate in window management correctly" [Critical,In progress]11:48
CimiSaviq, is that assigned to me? https://bugs.launchpad.net/unity8/+bug/122622111:48
ubot5Ubuntu bug 1226221 in Unity 8 ""Recent searches" are not persistent and are not common between scopes" [Undecided,Triaged]11:48
Saviqmzanetti, you gonna merge the autopilot workaround or am I?11:52
mzanettiSaviq: this?11:53
mzanettihttps://code.launchpad.net/~saviq/unity8/workaround-lp1238417/+merge/19057411:53
Saviqmzanetti, yes11:53
mzanettialready approved11:53
Saviqmzanetti, and merge?11:53
Saviqmzanetti, we don't have automerging11:54
mzanettioh... missed that11:54
mzanettiSaviq: since when?11:54
Saviqmzanetti, oh right11:54
Mirvbregma: congrats btw, I got the best autopilot results so far that I've had today on local machine11:54
Saviqmzanetti, since Tuesday or so11:54
Saviqmzanetti, and until we get the dashboard green for unity811:54
mzanettimhm...11:54
Saviqmzanetti, I'll merge11:55
=== iahmad|afk is now known as iahmad
* mzanetti doesn't really see why manual merging would make a difference, but ok11:55
Saviqmzanetti, it does11:56
Saviqmzanetti, no tests are run11:56
Saviqbefore merging11:56
Saviqmzanetti, so yeah - it's better that way - no failures11:56
mzanettibut... how do failing merge tests have any impact on the dashboard?11:56
mzanettiwouldn't it actually increase the risk of something failing in the dashboard?11:57
Saviqmzanetti, you tell me12:00
mzanettioh well... sometimes it's better not to ask I guess12:03
Saviqhe won't12:03
=== MacSlow|lunch is now known as MacSlow
mzanettiwho wants this one? https://code.launchpad.net/~mzanetti/unity8/fix-greeter-time-update/+merge/19063612:17
om26ermzanetti, I have a bug number for that. linked now.12:19
om26erthere. did my part :)12:19
mzanettiom26er: ;) thanks12:20
Saviqmzanetti, hmm, I can't seem to reproduce the keyboard issue with a python console :/12:20
mzanettiSaviq: hum? what exactly do you try?12:20
mzanettiSaviq: opening a python console and injecting stuff through uinput?12:21
Saviqmzanetti, through autopilot, yeah12:21
mzanettiSaviq: yeah... you're not using the qpa plugin in that case12:21
Saviqmzanetti, hmm12:21
Saviqmzanetti, think the maliit input happened indeed?12:22
bregmasil2100, didrocks, if I couild get a moment of your tmie to look after https://code.launchpad.net/~bregma/cupstream2distro-config/branch-unity7-for-saucy/+merge/19040912:22
=== _salem is now known as salem_
mzanettiSaviq: no. I think the mir-only qpa plugin has something like "if (!maliit.connected()) return;" which stops processing input even from uinput.12:23
mzanettiits still only a guess tho ^^12:23
Saviqmzanetti, k, so you think an autopilot/qpa bug12:24
mzanettiSaviq: unity-mir would be the place I'd start looking12:24
Saviqmzanetti, but then it wouldn't work from a python autopilot console12:26
Saviqmzanetti, and it does work just fine12:26
mzanettiSaviq: maybe I understood you wrong. so you stop maliit, start unity8 and then inject something into /dev/uinput with some python stuff?12:27
Saviqmzanetti, yes, and it works12:27
mzanettiok... agreed, then my suspicion is wrong12:27
Saviqmzanetti, not directly, from autopilot.input.Keyboard, but yes - that's the net result12:27
CimiSaviq, https://bugs.launchpad.net/unity8/+bug/108322112:28
ubot5Ubuntu bug 1083221 in unity8 (Ubuntu) "Touchdown effect kicks in too soon" [Medium,Triaged]12:28
CimiSaviq, there are many ways to do this12:28
SaviqCimi, I know ;)12:28
mzanettito me this seems quite intended behavior tbh12:29
mzanettiit indicates that if you release now, that item is triggered12:29
Cimimmm12:30
Cimigood point12:30
SaviqCimi, but http://qt-project.org/doc/qt-5.0/qtquick/qml-qtquick2-flickable.html#pressDelay-prop is probably the right way12:30
Saviqmzanetti, no, it's about when you want to flick12:30
Saviqmzanetti, and stuff blink below your finger12:30
mzanettiyeah... seems still ok to me12:30
CimiSaviq, I can add a proxy boolean12:31
CimiSaviq, delayedPressed12:31
CimiSaviq, with that12:31
Cimiwhen pressed is true, timer...12:31
SaviqCimi, no12:31
SaviqCimi, just use the property from Flickable12:31
CimiSaviq, another idea is tweaking the behaviour :)12:31
CimiSaviq, so when you click a tile12:32
Saviqmzanetti, we don't see it much now12:32
Saviqmzanetti, but with the people lens we had a big area highlighting12:32
Saviqmzanetti, it wasn't nice12:32
Cimihttp://paste.ubuntu.com/6222187/12:32
CimiSaviq, ^12:32
Cimion our tileStyle12:32
Cimifor pressed12:33
SaviqCimi, ugh http://qt-project.org/doc/qt-5.0/qtquick/qml-qtquick2-pauseanimation.html12:34
SaviqCimi, and no, because this way you can get it activated without visual feedback12:34
SaviqCimi, that's not something the guys want12:34
SaviqCimi, BUTT12:35
mzanettilol12:35
SaviqCimi, we should probably revisit with the designers if that's actually still an issue12:35
mzanettias I said... seems really like the correct behavior to me right now12:35
Saviqmzanetti, yeah, with the tiles it's probably fine12:35
mzanettiit's also "correct" with the ole people lens...12:36
mzanettithe issue might be that the highlight effect was too intrusive12:36
CimiSaviq, even now it can get activated without visual feedback12:36
CimiSaviq, PauseAnimation is clever :P12:36
CimiSaviq, but mines is better12:36
SaviqCimi, probably too long for the opacity12:36
CimiSaviq, because it gets activated only when opacity is 012:36
CimiSaviq, at which point you'll say I could disable the pause animation when opacity is != 012:37
Cimi(is it possible?)12:38
Cimimight confuse with betaviours12:38
SaviqCimi, you can't disable animations, no12:38
SaviqCimi, anyway - I put the bug as incomplete for us - let's get a confirmation from design folk12:39
CimiSaviq, explain https://bugs.launchpad.net/unity8/+bug/119534912:45
ubot5Ubuntu bug 1195349 in Unity 8 "First few items in Carousel don't switch correctly" [Medium,Triaged]12:45
SaviqCimi, isn't it explained already?12:45
SaviqCimi, tap on first and second item12:45
CimiSaviq, I don't see the visual glitch12:45
SaviqCimi, let me find a carousel12:45
CimiSaviq, music12:46
Cimiadd songs12:46
CimiSaviq, might be possible that with the list view is gone12:49
SaviqCimi, if you click on 3rd or 4th item12:49
SaviqCimi, the list scrolls to the side and only then the new item goes to the front12:49
sil2100bregma: we'll take a look at that today, thanks@12:50
SaviqCimi, if you click on 1st or 2nd12:50
SaviqCimi, it happens in parallel12:50
SaviqCimi, which means the two items swap where they overlap12:50
CimiSaviq, ah ok12:50
nic-doffaySaviq, mind giving further thoughts on this? https://code.launchpad.net/~nicolas-doffay/unity8/expansion-transition-fix/+merge/18987213:06
nic-doffayLooking for more opinions from people with huge file scopes.13:06
Saviqnic-doffay, don't set duration at all13:06
nic-doffaySaviq, I'm not.13:07
Saviqnic-doffay, duration: -1 ?13:07
nic-doffaySaviq, that disables the duration...13:07
Saviqnic-doffay, that's the default value13:07
nic-doffayIf not it gets set to a default duration.13:07
nic-doffaySaviq, ah.13:07
Saviqnic-doffay, http://qt-project.org/doc/qt-5.0/qtquick/qml-qtquick2-smoothedanimation.html#duration-prop13:08
nic-doffaySaviq, are you happy with the functionality?13:08
Saviqnic-doffay, yeah, that's what the bug was about13:08
nic-doffaySaviq, mind giving the MP another look, I'd like to move on to another one on the list.13:09
didrocksbregma: we don't do those branching yet. everyone needs to focus on saucy until end of next week13:14
didrockssil2100: FYI ^13:14
Saviqnic-doffay, merged13:14
kgunnSaviq: is there someone free-ish to jump on this one ? https://bugs.launchpad.net/qtcreator-plugin-ubuntu/+bug/123803113:15
ubot5Ubuntu bug 1238031 in qtcreator-plugin-ubuntu "'Run on device' stopped working under mir" [Critical,Confirmed]13:15
kgunnappearantly we broke their run on device13:15
kgunnactually...will the socket moving solve this ?13:16
Saviqmzanetti, can you look ↑?13:18
mzanettiyes13:19
MacSlowkgunn, I still can't edit the spreadsheet13:20
SaviqMacSlow, I think kgunn didn't get to that email yet ;)13:21
Saviqkgunn, we have no write access to the sprint spreadsheet...13:21
MacSlowSaviq, some folks do already13:21
SaviqMacSlow, sure you're on @canonical.com account? work13:22
Saviqs here13:22
MacSlowSaviq, kgunn: working now... thx13:22
MacSlowSaviq, just got a new link13:23
=== jhodapp|afk is now known as jhodapp
Takso is there a sane way to programmatically set an application's icon and have it look nice in the launcher/switcher/etc.?13:36
mterryMacSlow, I could do some reviews, if you want to look at bug 1238098 as a change of pace13:37
ubot5bug 1238098 in ubuntu-keyboard "Autopilot test fails because of extra inserted characters" [High,Confirmed] https://launchpad.net/bugs/123809813:37
Takif I set via XWMHints or _NET_WM_ICON, the icon in the switcher looks like it was upscaled from 32x3213:37
Tak(using a 256x256 icon to test)13:37
MacSlowmterry, ok13:37
MacSlowCtrl-W'ed the wrong window...13:41
mterryMacSlow, heh, I hate that.  Also the closeness of Ctrl+Q13:42
* Tak always ctrl-q when I mean to ctrl-w13:42
mterryMacSlow, so if you like, throw me some review branches you want to offload13:42
MacSlowmterry, I only pick/claim one at a time... to avoid anybody from taking up the ones I'm not doing...13:43
MacSlowmterry, so I'll finish mzanetti's fix-greeter-time-update and switch to the #123809813:44
mterryMacSlow, ok, sure13:44
* mterry looks at queue13:44
tsdgeoscan anyone quick review https://code.launchpad.net/~aacid/unity8/fix_uninit_var_scope/+merge/190660 ?13:47
tsdgeosi can merge it myself if you guys prefer13:47
tsdgeospstolowski: mhr3: Saviq: ↑↑↑13:48
mhr3acked13:49
tsdgeostx, pushed13:50
* Saviq fail13:50
Saviqin both code and review ↑↑ ;)13:51
mzanettilol13:51
tsdgeossad thing is, i can't find how to tell valgrind how to pass the sigterm to the app13:51
mzanettiSaviq and his special chars13:51
tsdgeosso not useful for the crash we have on shutdown13:51
Saviq13:51
tsdgeosei, those are my special chars13:51
tsdgeos←↓→↑13:51
mzanettitsdgeos: check the sprint doc13:52
Saviqtsdgeos, nah, he meant in the spreadshit13:52
tsdgeosseen then13:52
tsdgeos-n+m13:52
tsdgeosoh, actually the sigterm is supposed to be passed13:53
tsdgeosit's just valgrind general slowness13:53
tsdgeos:D13:53
dandraderSaviq, is the mir socket file also going to follow that XDG_RUNTIME_DIR path?13:55
Saviqdandrader, already is13:57
Saviqdandrader, btw, #123845113:57
Saviqbug #123845113:57
ubot5bug 1238451 in ubuntu-keyboard (Ubuntu Saucy) "Cannot dismiss OSK" [High,Confirmed] https://launchpad.net/bugs/123845113:57
Saviqdandrader, is what I mentioned on the MP13:57
Saviqdandrader, we need a non-blocking input area on top of the OSK maybe?13:58
Saviqdandrader, so that you can both tap on the buttons and dismiss the keyboard easier13:58
mzanettiMirv: ping14:00
dandraderSaviq, I don't know. it's all a big hack. So I don't think it makes sense to spend time fine-tuning a hack. we would be better of spending our time working towards getting the proper architecture in place (OSK being a non-fullscreen mir surface, etc)14:00
dandraderSaviq, so our unity-mir code is to just have things usable while we work towards our goal14:01
Mirvmzanetti: kind of pong14:01
Saviqdandrader, it needs to be able to be fullscreen14:01
Saviqdandrader, anyway, we regressed - and that's not a nice one14:01
mzanettiMirv: where can I find the repository for this? /usr/share/qtcreator/ubuntu/scripts/qtc_device_run_app14:01
Saviqdandrader, and we won't get the correct architecture in place for yesterday14:02
Saviqdandrader, and that's when we need it fixed I'm afraid14:02
Mirvmzanetti: lp:qtcreator-plugin-ubuntu , fixes to run apps under Mir absolutely welcome :)14:02
mzanettiMirv: yeah. I have it working here. will propose a branch14:02
Mirvmzanetti: note the trunk needs that you use ppa:ubuntu-sdk-team/ppa already (QtC 2.8)14:04
Mirvmzanetti: but when the branch gets approved + merged, it gets autobuilt to every SDK PPA user for all ubuntu versions14:04
mzanettiMirv: the fix is so simple, I don't think I need to bother14:05
Saviqdandrader, ah, so it'd be a Qt.inputMethod issue that we don't get updates about stopped maliit, of course, sorry14:06
mzanettiMirv: https://code.launchpad.net/~mzanetti/qtcreator-plugin-ubuntu/fix-device_run_app-for-mir/+merge/19067714:06
* mzanetti wonders why we use "-platform ubuntu" for surfaceflinger instead of mir :D14:08
Mirvmzanetti: can you get someone to test/approve it, I can't at the moment?14:08
mzanettiMirv: sure14:08
pstolowskirsalveti, ping14:09
rsalvetipstolowski: pong14:09
pstolowskirsalveti, i've been debugging another crash in mediascanner, and it looks like it's coming from gst as well; does it ring any bells? http://pastebin.ubuntu.com/6222543/14:09
pstolowskirsalveti, so, "%s: overflow allocating %u*%u bytes" coming from libgstandroidmedia I guess14:11
rsalvetipstolowski: that should be improved with next version as well14:11
rsalvetijust building locally to test, and will push14:11
pstolowskirsalveti, great, thanks14:12
Saviqgreyback, re: https://code.launchpad.net/~gerboland/unity-mir/add-focus-requested-signal/+merge/190620/comments/43763214:15
Saviqgreyback, let's drop the other signal indeed14:15
greybackSaviq: ack14:16
kgunngreyback: ...so i was tinkering with collecting data with qml renderer timing....something i didn't expect...there's no rendering on rotates.(?)14:26
greybackkgunn: shell doesn't do anything on rotation, only the app14:27
greybackkgunn: unless you've the OSK up. Shell, might render then, as it needs to reposition the keyboard14:27
kgunngreyback: yeah....but i would have thot i would get _all_ rendering data with that flag14:27
kgunngreyback: i'll leave you be...14:28
=== dandrader_ is now known as dandrader
greybackkgunn: how are you using it? "stop unity8" and "QML_RENDERER_TIMING=1 unity8" ?14:28
kgunngreyback: yes14:28
greybackkgunn: yeah, in that case only unity8 will have that var set in it's env. Upstart launches the apps, so those apps don't get that flag. upstart redirects the app output to the .cache/log/ directory also14:29
greybacks/it's/its/14:29
kgunngreyback: oh...not sorry, to be more correct, i do export the QML_RENDERER_TIMING....but then upon unity8 restart its "QT_QPA_PLATFORM=ubuntumirserver unity8"14:31
kgunnwhich i suppose the result is the same...only unty8 gets the flag set14:32
greybackkgunn: I believe so, yes. If you stick QML_RENDERER_TIMING in /etc/environment, upstart might use it. Then you'll need to keep eye on the log for the timing output.14:33
kgunngreyback: thanks...14:33
greybackkgunn: else you can launch the app manually with the desktop_file_hint flag14:34
kgunngreyback: thanks...that all makes alot more sense now14:36
greybackkgunn: any time14:36
=== dandrader is now known as dandrader|afk
greybackmterry: you comment has been addressed, thanks: https://code.launchpad.net/~gerboland/unity-mir/add-focus-requested-signal/+merge/19062014:41
dednickSaviq: fix for bug #1236249 . https://code.launchpad.net/~nick-dedekind/unity8/lp1236249/+merge/19068714:41
ubot5bug 1236249 in unity8 (Ubuntu) "unity8 crashed with SIGSEGV in UnityMenuModelPrivate::itemState()" [High,Confirmed] https://launchpad.net/bugs/123624914:41
mterrygreyback, awesome.  I probably shouldn't do actual review, but seems fine14:43
Saviqdednick, tx14:43
Saviqmterry, greyback I'm on it14:43
seb128mterry, if the lock screen in unity8?14:49
mterryseb128, yeah14:50
mterryseb128, if you mean, is the source in unity814:50
mterryseb128, v1 doesn't use a lock screen14:50
seb128mterry, well, I was looking for debug output14:50
seb128so unity8.log it is14:50
mterryseb128, yup14:50
seb128mterry, I still have the issue that "apt-get install ubuntu-wallpapers-saucy; gdbus call --system -d org.freedesktop.Accounts -o /org/freedesktop/Accounts/User32011 -m org.freedesktop.Accounts.User.SetBackgroundFile '/usr/share/backgrounds/163_by_e4v.jpg'" gives me an empty background14:51
seb128mterry, the image is there and a jpg14:51
mterryseb128, :-/  I'll look at it later, but sounds like it's not super critical if we copy the image over via the picker14:52
mterryseb128, maybe file a bug?14:52
seb128mterry, yeah, it's a detail, I just wanted to see if I did something stupid14:52
mterryseb128, no, I guess there14:52
seb128mterry, I'm going to open a bug for next cycle, as you said, it's minor14:52
mterryis a real bug, but not sure how, we just ask qt to load the image14:52
dednickmterry: are you revieing one of my branches?14:53
mterrydednick, yeah was going to do https://code.launchpad.net/~nick-dedekind/unity8/lp1236249/+merge/19068714:53
dednickmterry: can you hold off? i want to make some changes. I think I can do something better.14:53
mterrydednick, OK14:53
dednickmterry: thanks14:54
mterrydednick, poke me when ready14:54
=== dandrader|afk is now known as dandrader
kgunnSaviq: is someone on unity or  mir team already looking at the thing veebers mailed about ? (second unity8 proc doesn't get inputs)15:07
kgunnhttps://bugs.launchpad.net/mir/+bug/123841715:07
ubot5Ubuntu bug 1238417 in Mir "Unity does not process events from evdev device created before unity is restarted (autopilot tests)" [Critical,Confirmed]15:07
Saviqkgunn, we have a workaround15:07
Saviqkgunn, in unity8 trunk already15:07
kgunnSaviq: thanks alot...already in ask sheet ?15:07
Saviqkgunn, no, I disregarded the ask sheet recently15:08
Saviqkgunn, and it wouldn't matter15:08
kgunnSaviq: ;D...i'll add15:08
Saviqkgunn, 'cause except for 1, the rest of the tests were run alone15:08
Saviqkgunn, bug #1238645 could get eyes on first - as it has no workaround15:08
ubot5bug 1238645 in Unity 8 "Shell does not get autopilot keyboard input if maliit isn't running" [Undecided,New] https://launchpad.net/bugs/123864515:08
Saviqdandrader, will you look into increasing the "handle" for dismissing OSK?15:09
dandraderSaviq, yes, It's on my queue15:10
Saviqdandrader, ok thank you15:10
dandraderSaviq, it that more important than kbd rotation?15:10
Saviqdandrader, probably not15:10
Saviqdandrader, as you can dismiss it, only it's more difficult15:10
Saviqdandrader, I know it's frustrating to work on such temporary stuff...15:10
Saviqdandrader, it's just that time of the year...15:11
dandraderSaviq, and that extra area will have events going both to osk and app behind it, right?15:12
dandraderlooks like a good case for the future gesture accept/reject scheme....15:13
Saviqdandrader, exactly15:14
mzanettiSaviq: need some of your braincells, the jumping arrow in the carousel happens because the arrow's position has an animation but also the center property moves as the carousel moves15:16
mzanettiSaviq: so it's colliding animations so to say. I still don't really know a way around that in QML. did you find something in the meantime?15:16
Saviqmzanetti, thought so15:17
mzanettiSaviq: a hacky solution would be not to animation the arrow in case of the carousel, that would cause it to immediately jump to the newly selected item and then move along with that15:17
Saviqmzanetti, maybe we should be waiting for the view to settle15:17
Saviqmzanetti, obviously it'd be best if they met in the middle ;)15:18
Saviqmzanetti, but I know how it is15:18
mzanettidammit... this is a topic to discuss with qml experts from digia... forgot that @ the devdays15:19
om26erSaviq, re: shell does not get keyboard input if maliit not running. I think that's because autopilot uses maliit backend to type stuff on touch devices15:20
mzanettiom26er: oh... does it already. yeah, we were wondering about that earlier today15:20
Saviqom26er, does it? not uinput directly?15:20
Saviqom26er, that new?15:20
om26erSaviq, its been like that for 1 month atleast.15:21
Saviqom26er, ok, that's weird IMO15:22
* Saviq starts maliit in unity8 tests15:22
mterryMacSlow, when does your extended snap decisions2 branch come into play?   Like, how do I test?15:23
dednickmterry: poke. MP is ready now.15:23
mterrydednick, ok15:23
MacSlowmterry, since - according to Saviq - there's no "user" of it (and it's regarded a feature rather than a bugfix) it won't land soon... which is a pity since it was quite a battle to get it where it is now :)15:24
mterrydednick, why drop the "m_menu->disconnect(this)" bit?15:24
mterry(in your most recent change, in the destructor)15:25
om26ermzanetti, here: https://code.launchpad.net/~veebers/autopilot/add_OSK_keyboard_backend/+merge/18145615:25
mterryMacSlow, ah ok.  Marked WIP then15:25
dednickmterry: it's automatically done when the object is destroyed.15:25
SaviqMacSlow, dednick unless you tell me network indicator can do it now (and apps can request network, for that matter)15:25
Saviqmterry, ↑ rather15:25
mterrydednick, that's part of Qt machinery?  OK15:25
dednickSaviq: how far up?15:26
Saviqdednick, not at all15:26
mzanettiom26er: cool stuff15:26
Saviqdednick, was about wifi selection snap decision15:26
MacSlowmterry, so landing is still some weeks away I fear... but if you want to give it a spin out of curiosity... grab lp:~macslow/unity-notifications/extended-snap-decisions-part2 and lp:~macslow/unity8/extended-snap-decisions-part215:26
MacSlowmterry, compile/install unity-notifications/extended-snap-decisions-part2 on the device directly...15:26
Saviqmzanetti, so you were right ;)15:26
dednickSaviq: no, i dont think there's anything that will trigger it atm.15:27
mzanettiSaviq: maybe that was even the reason why we had all those typing failures some weeks back15:27
MacSlowmterry, unity8/extended-snap-decisions-part2 would get the usual run_on_device treatment... and then trigger examples/sd-example-wifi-selection.py from the unity-notifications branch15:28
MacSlowmterry, it's not really WIP as it works/is done15:29
mterryMacSlow, yeah but it's not landable, so it's not "ready for review" either15:29
mterryMacSlow, I thought it was typical practice to use WIP to get branches off the active review board15:30
MacSlowmterry, I always took wip for what it really stands for :)15:30
MacSlowmterry, this is just cheating to get the review-board look cleaner ;)15:31
mterryMacSlow, well, maybe that's a distro thing15:31
MacSlowmterry, but j/k :)15:31
mterryMacSlow, review-board should be clean!  :)15:31
kgunngreyback: i was gonna queue up unity-mir...you gonna have any mp merge today ? if so i'll wait a bit15:34
greybackkgunn: yep have https://code.launchpad.net/~gerboland/unity-mir/add-focus-requested-signal/+merge/19062015:36
greybackkgunn: please wait until that lands15:37
dandraderSaviq, https://code.launchpad.net/~dandrader/ubuntu-keyboard/improve_kbd_info_ipc/+merge/190418 and https://code.launchpad.net/~dandrader/unity-mir/improve_osk_ipc/+merge/190417 have been updated15:37
kgunngreyback: np15:38
Saviqdandrader, thanks15:40
Saviqgreyback, 122+ print("focus request:", appId) ?15:46
greybackSaviq: doh15:46
Saviqah test15:46
Saviqgreyback, that's in a test15:46
Saviqgreyback, /me d'oh15:46
greybackSaviq: undoh15:46
mterrydednick, I commented on some style issues, but the branch seems to work fine15:49
dednickmterry: cool. will check it out15:50
Saviqkgunn, fix for bug #1237850 is in trunks15:52
ubot5bug 1237850 in Unity 8 "Apps started via upstart don't participate in window management correctly" [Critical,Fix committed] https://launchpad.net/bugs/123785015:52
kgunnta15:53
=== om26er is now known as om26er|food
Saviqfginther, is merger for ubuntu-keyboard enabled?15:56
fgintherSaviq, yes, there is a job running15:58
Saviqfginther, right, it started just after I asked ;)15:58
Saviqfginther, thanks15:58
* tsdgeos declares win over the QIcon crash15:59
Saviqfginther, ah no, I was just looking at the public jenkins <facepalm>15:59
tsdgeos\o/15:59
Saviqtsdgeos, awesome!15:59
Saviqtsdgeos, EOD? ;D15:59
* tsdgeos pushes some branches15:59
Saviqtsdgeos, you got 10s15:59
tsdgeos:D15:59
Saviqnow15:59
tsdgeosand you know what, the qicon was totally a red herring16:00
tsdgeosdamn **** :D16:00
Saviq:D16:00
Saviqkgunn, you should merge the two asks for keyboard and unity-mir/unity816:00
Saviqkgunn, unity-mir has all in trunk already, so they should land in concert16:00
kgunnSaviq: i was actually doing that16:01
Saviq!16:01
kgunni'll add a note to be clear tho16:01
tsdgeosSaviq: https://code.launchpad.net/~aacid/unity-mir/waitforme/+merge/19071616:07
tsdgeosSaviq: https://code.launchpad.net/~aacid/unity8/phone_crash_cleanup/+merge/19071716:07
tsdgeosSaviq: with those two it does not crash anymore on exit16:07
tsdgeosSaviq: though once it was stuck in a phtread_join inside mir's code16:07
tsdgeosi'm calling that one NOTOURBUG16:08
Saviqtsdgeos, cool16:08
tsdgeosof course still can have a look on monday16:08
tsdgeosbut it was much less frequent16:08
tsdgeosgreyback: https://code.launchpad.net/~aacid/unity-mir/waitforme/+merge/190716 for you if you have time16:09
greybacktsdgeos: on it16:09
kgunnhey mzanetti would this https://code.launchpad.net/~mzanetti/unity-mir/fix-appid-parsing/+merge/190419 fix this bug 123883216:09
ubot5bug 1238832 in unity-mir "[window stack] Incorrect app_id being sent in "window opened" signal for share-app" [High,New] https://launchpad.net/bugs/123883216:09
mzanettikgunn: very likely16:10
mzanettikgunn: the description doesn't give enough details to be 100% sure tho16:10
tsdgeosSaviq: btw now that 5.2 alpha is out someone should have a look at how much if at all we make the new V4 engine crash and report it with enough time so [hopefully] they fix it :D16:11
Saviqtsdgeos, lol yeah :)16:11
* tsdgeos takes a shower, leaving this open in case you find something wrong with my code once i finish16:14
kgunnbbiab16:17
* mterry is worried latest unity-mir/unity8 requestFocus changes messed up receiving calls in greeter again. will test16:19
greybackmterry: oh feck, I forgot greeter uses unity-mir now. I will add testing greeter workflow from now on16:25
mterrygreyback, well, this is an odd case16:26
sil2100jamesh: hi!16:28
sil2100jamesh: are you still around?16:29
nic-doffaypete-woods, ping16:30
sil2100jamesh: we have a ftbfs of mediascanner on powerpc due to a unit test failing16:31
sil2100jamesh: https://launchpadlibrarian.net/153485520/buildlog_ubuntu-saucy-powerpc.mediascanner_0.3.93%2B13.10.20131011-0ubuntu1_FAILEDTOBUILD.txt.gz16:31
mzanettiSaviq: fixed most of the switching-preview issues. replied to the others16:32
Saviqmzanetti, cool!16:36
=== dandrader is now known as dandrader|lunch
Saviqmzanetti, lp says conflict?16:36
pete-woodsnic-doffay: hi16:37
Saviqmzanetti, re: pointer - tried SmoothedAnimation?16:46
Saviqbzr revert16:47
nic-doffaypete-woods, got time for a small infographics related review?16:47
pete-woodsnic-doffay: sure16:47
nic-doffaypete-woods, cheers : https://code.launchpad.net/~nicolas-doffay/unity8/infographics-font-fix/+merge/19072516:47
nic-doffayhella small16:47
nic-doffay:P16:48
mzanettiSaviq: d'oh... will merge16:50
pete-woodsnic-doffay: done!16:51
pete-woodsnic-doffay: have you checked that this works on the tablet, btw? I guess it's not important right now, but I bet you need to come back and fix the font size for that16:52
tsdgeosgreyback: last chance, want to discuss something or next week?16:55
=== om26er|food is now known as om27er
=== om27er is now known as om26er
nic-doffaypete-woods, I don't have a tablet sadly :/16:56
greybacktsdgeos: next week16:57
tsdgeosokidoki16:57
* tsdgeos waves16:57
mzanettiSaviq: ouch... conflict is a bad one17:03
Saviqmzanetti, next week, then17:03
sergiusensSaviq, now that I think of it, the workaroudn won't work as the maliit-server is started on started unity817:11
sergiusensSaviq, so you'll need to cli launch it17:11
mzanettiSaviq: managed to catch a unity8 freeze on the desktop. this is the stacktrace when attaching: http://paste.ubuntu.com/6223360/17:12
mzanettiSaviq: any ideas how to get more information?17:12
mzanettior better: if there's something useful I should try to collect17:12
dednickmzanetti: looks like Shell qmltests arent working in trunk17:13
sergiusensSaviq, ignore that; should work17:13
mzanettidednick: ok. will fix17:13
Saviqmzanetti, it might be Albert's fix for the loop in incubation17:14
Saviqmzanetti, qt fix not released yet17:14
Saviqsergiusens, yeah it does sork17:14
Saviq*work17:14
dednickmzanetti: i think Unity.Indicators mock is missing the CachedUnityMenuModel17:14
sergiusensSaviq, my phone is overheating and not unlocking the greeter during tests though; got me confused on the wrong path :-/17:15
sergiusensSaviq, I found out why _usr_bin_unity-scope-loader.32011.crash _usr_bin_unity8.32011.crash17:16
sergiusensSaviq, let me flash again17:16
mzanettidednick: they seem to work here even after removing the datetime indicator17:20
dednickmzanetti: make testShell works?17:20
mzanettioh... I only tried make testClock as that's the one I changed17:21
dednickmzanetti: Added the Unity.Indicator module to the imports. the mocks in the shell tests override the plugins17:21
dednickmzanetti: i can sort it out if you want. I'm fixing up other breakages realated to it in another branch.17:22
mzanettidednick: ok, thanks a lot17:23
=== dandrader|lunch is now known as dandrader
kgunnSaviq: so do you agree or disagree that the shell has any responsibility wrt saving user settings ?18:15
kgunncouldn't see a resolution to the exchange you had in #ubuntu-desktop18:15
sergiusensSaviq, ok, added a comment18:24
kgunnmterry: just curious...any news on the bottom bar reveal issue during qa lab tests ?18:35
mterrykgunn, they seemed to go away18:36
kgunn...seems rumor yesterday might be an update was needed?18:36
mterrykgunn, we could never reproduce them out of lab and even lab isn't seeing them18:36
kgunnmterry: ah...my favorite...18:36
mterryanymore18:36
mterrykgunn, yeah...  so there may indeed be a problem, but it's hard to track18:36
kgunnmterry: well there's been a heap of good stuff land...18:36
om26erCimi, if you have not already fixed bug 1238837 I have a branch for that else please ignore.18:38
ubot5bug 1238837 in Unity 8 "[DASH - recent apps quit mode] Quit target shouldn't be the entire app thumbnail" [High,Triaged] https://launchpad.net/bugs/123883718:38
robotfuelkgunn: mterry: I found my devices had an old version of libgl, which a distupgrade fixed. I wonder if that was the upgrade rumor.  There was also a restarting unity8 with -testablility timing issue where the tests started before it was ready for action.18:39
om26erhttps://code.launchpad.net/~om26er/unity8/fix_1238837/+merge/19074318:40
kgunnrobotfuel: mmm, could be...we should keep an eye out...but yeah, lots of good stuff happened recently18:40
sergiusensSaviq, https://code.launchpad.net/~saviq/unity8/workaround-lp1238645/+merge/19072418:52
Saviqsergiusens, right, thanks19:26
Saviqfginther, hey, a question for the end of the day19:34
fgintherSaviq, so I can wait to answer it :-)19:34
Saviqfginther, do you think we could inherit daily releases' approach to builders19:35
Saviqfginther, so that we'd have a per-stack PPA instead of the mbs repo19:35
Saviqfginther, would reduce the load on jenkins'n'friends, improve the transparency slightly - and provide a "staging" PPA for all the stacks19:35
fgintherSaviq, that's something to consider19:37
Saviqfginther, to me that's one of the things that felt "right" in daily release :)19:37
Saviqfginther, would reduce the burden of maintaining pbuilder-jenkins and the complication of the jobs19:37
fgintherSaviq, are you suggesting just to replace the mbs repo with a ppa or something more?19:38
Saviqfginther, I would think that anything that builds packages in -ci or -autolanding jobs19:38
Saviqor well19:38
Saviqat least -autolanding19:38
Saviq-ci would have to be per-project PPA, so probably too much - or would it...19:39
Saviqfginther, [...] could be replaced by PPAs19:39
Saviqfginther, something to talk over in OAK?19:39
Saviqfginther, you coming?19:39
fgintherSaviq, right, I agree that some things are replaceable by a ppa, the mbs functionality is combersome19:40
Saviqfginther, I think the mbs would be just a perfect example for a PPA - per-stack19:40
fgintherSaviq, there is a upstream-merger 2.0 vision that involves moving everything to prodstack and ideally using a 'buildd'-stack as well19:40
Saviqfginther, sure - that'd be nice19:40
Saviqfginther, especially for -ci where we don't want the results to really be persistent between runs19:41
fgintherSaviq, I haven't been invited to OAK19:41
Saviqfginther, we need a temporary build19:41
Saviqfginther, bummer19:41
Saviqfginther, UDS session then19:41
* Saviq notes19:41
fgintherSaviq, yes19:41
fgintherSaviq, I'll try to keep you in the loop with things, you have a pretty good idea of what a consumer needs19:42
Saviq:)19:42
Saviqnot sure which track... client? foundations?19:43
Saviqcommunity?19:43
* Saviq puts as client to start with, wonder whether we need a QA track...19:43
Saviqfginther, https://blueprints.launchpad.net/ubuntu/+spec/client-1311-upstream-merger-2019:46
fgintherclient sounds good for now19:46
fgintherSaviq, thanks19:47
Saviqkgunn, one thing just occured to me19:48
Saviqkgunn, UDS is 11/19-2119:48
Saviq↑ see, I can do US dates (for dates > 12...)19:49
Saviqkgunn, so we probably try and avoid that for the possible sprint dates19:49
kgunnSaviq: mmm, thanks....yeah....1st week of dec looking best anyway19:49
Saviqkgunn, yeah exactly19:49
Saviqfginther, added some topics to the whiteboard19:51
Saviqkgunn, saw you've been registering blueprints - some of them could use a UDS session maybe?19:53
kgunnSaviq: yep...going to be a few more...we can decide in a bit which we want to have for session19:54
Saviqkgunn, yeah, OAK?19:54
Saviqjeez that's in two weeks already...19:54
kgunni know....feeling really behind19:54
kgunnxmir, then phone v1....i'm kinda tired19:55
kgunncan't imagine how you guys feel19:55
Saviqkgunn, hint:                                     ↑↑↑19:55
Saviqoops19:55
Saviq                            ↑↑↑19:55
Saviq                                    ↑↑↑19:55
Saviqalmost :D19:55
Saviqok, xchat gone craazy19:56
kgunnSaviq:  go have a weekend already19:56
Saviqkgunn, trying, but the wife fell asleep - boring ;d19:56
* Saviq needs a beer19:56
kgunn:))19:56
mhall119Saviq: previous vUDS we just spanned QA across all the tracks were appropriate19:57
Saviqmhall119, yeah... put it in client, although could be community19:57
Saviqkgunn, ah btw... I'm *not* going on holiday next week - managed to get confused enough with msm that was not cancelled ;)20:00
Saviqor maybe managed to confuse msm enough...20:00
kgunnok20:00
=== jalcine is now known as jalcine_
=== jhodapp is now known as jhodapp|afk
=== salem_ is now known as _salem
=== jalcine is now known as jalcine_

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!