| === freeflying_away is now known as freeflying | ||
| === freeflying is now known as freeflying_away | ||
| === freeflying_away is now known as freeflying | ||
| === freeflying is now known as freeflying_away | ||
| === freeflying_away is now known as freeflying | ||
| === CyberJacob|Away is now known as CyberJacob | ||
| bigjools | gmb: I noticed your branch kept getting rejected with failures yesterday, did you figure it out? | 07:10 |
|---|---|---|
| gmb | bigjools: Yeah, I hadn't fixed all the errors in the tests after my changes to how we shell out to external processes. It should be fixed now (or at least I don't get any errors on my machine). | 07:12 |
| bigjools | cool | 07:12 |
| bigjools | at least we get the test output in the MP comment now, previously it meant diving into a jenkins console | 07:12 |
| rvba | bigjools: thanks for the review on https://code.launchpad.net/~rvb/maas/delete-lease/+merge/190969. I'm wondering where exactly you want that comment added as the only code that this branch adds is already commented… | 07:32 |
| bigjools | rvba: at the site where the node is deleted | 07:33 |
| rvba | bigjools: in the test you mean? | 07:33 |
| bigjools | rvba: in the Node's deletion method | 07:34 |
| bigjools | well, maybe MAC actually | 07:34 |
| bigjools | since that's what the signal is connected to | 07:34 |
| bigjools | my problem with signals is that they are not obvious | 07:34 |
| rvba | bigjools: this is inside Django's code :) | 07:34 |
| bigjools | so a comment helps jog one's memories | 07:34 |
| * bigjools finds the exact file and line | 07:35 | |
| rvba | :) | 07:35 |
| bigjools | rvba: models/node.py at line 646 | 07:35 |
| rvba | bigjools: it would be really weird to add a comment there I think… | 07:36 |
| bigjools | all it would say is that a signal will fire that also deletes leases | 07:36 |
| bigjools | and ref the signal method | 07:36 |
| bigjools | the only way I found this bug in the first place was by looking at that code | 07:37 |
| bigjools | that code has not changed! So this is all a bit of Django magic. | 07:37 |
| rvba | All right, as you like it :) | 07:37 |
| bigjools | ta :) | 07:38 |
| bigjools | rvba: which doc? | 08:30 |
| rvba | bigjools: http://pad.ubuntu.com/DnNONX6kFB | 08:30 |
| === CyberJacob is now known as CyberJacob|Away | ||
| bigjools | rvba: ah the PAD :) | 08:59 |
| rvba | Yes, the *PAD* :) | 08:59 |
| rvba | allenap: gmb: my 3 branches are up for review: https://code.launchpad.net/~rvb/maas/agent-bug-1239488/+merge/191140 https://code.launchpad.net/~rvb/maas/agent-bug-1239488-acquire/+merge/191141 https://code.launchpad.net/~rvb/maas/agent-bug-1239488-list/+merge/191142 | 10:23 |
| allenap | rvba: Okay, I'll take a look once I've remembered Go. | 10:24 |
| rvba | allenap: all right :) | 10:24 |
| rvba | Thanks. | 10:24 |
| === freeflying is now known as freeflying_away | ||
| allenap | rvba: Would you be able to have a look at https://codereview.appspot.com/14696043? | 11:00 |
| === freeflying_away is now known as freeflying | ||
| rvba | allenap: approved. | 11:35 |
| allenap | rvba: Thanks! | 11:35 |
| === kentb-out is now known as kentb | ||
| === CyberJacob|Away is now known as CyberJacob | ||
| roaksoax | bigjools: bug #1240215 | 20:11 |
| ubot5 | bug 1240215 in MAAS "changing the default arches in import_pxe_files prevents maas-import-ephemerals from running" [Undecided,New] https://launchpad.net/bugs/1240215 | 20:11 |
| roaksoax | jt^^ | 20:11 |
| === CyberJacob is now known as CyberJacob|Away | ||
| smoser | roaksoax, you're aware that "arches" are i386/generic | 20:20 |
| smoser | right? | 20:20 |
| smoser | not i386 | 20:20 |
| roaksoax | smoser: yep | 20:20 |
| === CyberJacob|Away is now known as CyberJacob | ||
| smoser | roaksoax, i think you might be hitting bug : should not insert version if all items were filte | 20:42 |
| smoser | bug 1238227 | 20:42 |
| ubot5 | bug 1238227 in simplestreams (Ubuntu) "should not insert version if all items were filtered" [Medium,Confirmed] https://launchpad.net/bugs/1238227 | 20:42 |
| roaksoax | smoser: thanks for looking at it btw | 21:00 |
| smoser | i noticed that annoying behavior last week when i was doing probably the same thing you were doing. | 21:01 |
| bigjools | roaksoax: yay .... :/ | 22:34 |
| roaksoax | bigjools: it is release team decision whrther to accept fizes though | 22:41 |
| bigjools | yeah | 22:41 |
| === freeflying is now known as freeflying_away | ||
| === freeflying_away is now known as freeflying | ||
| === CyberJacob is now known as CyberJacob|Away | ||
| === freeflying is now known as freeflying_away | ||
| === freeflying_away is now known as freeflying | ||
| lifeless | bigjools: so how fast is the fastpath install? | 23:47 |
| bigjools | lifeless: the actuall installer is blinding, about 2 mins | 23:50 |
| lifeless | cool | 23:51 |
| bigjools | but you have reboots and cloud-init overhead on that | 23:51 |
| lifeless | yeah | 23:51 |
| lifeless | thats disk-image fast :>... I suspect it is disk image based, no? | 23:51 |
| bigjools | yes | 23:51 |
| bigjools | makes my life a little nicer doing the development dance | 23:52 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!