=== freeflying_away is now known as freeflying === freeflying is now known as freeflying_away === freeflying_away is now known as freeflying === freeflying is now known as freeflying_away === freeflying_away is now known as freeflying === CyberJacob|Away is now known as CyberJacob [07:10] gmb: I noticed your branch kept getting rejected with failures yesterday, did you figure it out? [07:12] bigjools: Yeah, I hadn't fixed all the errors in the tests after my changes to how we shell out to external processes. It should be fixed now (or at least I don't get any errors on my machine). [07:12] cool [07:12] at least we get the test output in the MP comment now, previously it meant diving into a jenkins console [07:32] bigjools: thanks for the review on https://code.launchpad.net/~rvb/maas/delete-lease/+merge/190969. I'm wondering where exactly you want that comment added as the only code that this branch adds is already commented… [07:33] rvba: at the site where the node is deleted [07:33] bigjools: in the test you mean? [07:34] rvba: in the Node's deletion method [07:34] well, maybe MAC actually [07:34] since that's what the signal is connected to [07:34] my problem with signals is that they are not obvious [07:34] bigjools: this is inside Django's code :) [07:34] so a comment helps jog one's memories [07:35] * bigjools finds the exact file and line [07:35] :) [07:35] rvba: models/node.py at line 646 [07:36] bigjools: it would be really weird to add a comment there I think… [07:36] all it would say is that a signal will fire that also deletes leases [07:36] and ref the signal method [07:37] the only way I found this bug in the first place was by looking at that code [07:37] that code has not changed! So this is all a bit of Django magic. [07:37] All right, as you like it :) [07:38] ta :) [08:30] rvba: which doc? [08:30] bigjools: http://pad.ubuntu.com/DnNONX6kFB === CyberJacob is now known as CyberJacob|Away [08:59] rvba: ah the PAD :) [08:59] Yes, the *PAD* :) [10:23] allenap: gmb: my 3 branches are up for review: https://code.launchpad.net/~rvb/maas/agent-bug-1239488/+merge/191140 https://code.launchpad.net/~rvb/maas/agent-bug-1239488-acquire/+merge/191141 https://code.launchpad.net/~rvb/maas/agent-bug-1239488-list/+merge/191142 [10:24] rvba: Okay, I'll take a look once I've remembered Go. [10:24] allenap: all right :) [10:24] Thanks. === freeflying is now known as freeflying_away [11:00] rvba: Would you be able to have a look at https://codereview.appspot.com/14696043? === freeflying_away is now known as freeflying [11:35] allenap: approved. [11:35] rvba: Thanks! === kentb-out is now known as kentb === CyberJacob|Away is now known as CyberJacob [20:11] bigjools: bug #1240215 [20:11] bug 1240215 in MAAS "changing the default arches in import_pxe_files prevents maas-import-ephemerals from running" [Undecided,New] https://launchpad.net/bugs/1240215 [20:11] jt^^ === CyberJacob is now known as CyberJacob|Away [20:20] roaksoax, you're aware that "arches" are i386/generic [20:20] right? [20:20] not i386 [20:20] smoser: yep === CyberJacob|Away is now known as CyberJacob [20:42] roaksoax, i think you might be hitting bug : should not insert version if all items were filte [20:42] bug 1238227 [20:42] bug 1238227 in simplestreams (Ubuntu) "should not insert version if all items were filtered" [Medium,Confirmed] https://launchpad.net/bugs/1238227 [21:00] smoser: thanks for looking at it btw [21:01] i noticed that annoying behavior last week when i was doing probably the same thing you were doing. [22:34] roaksoax: yay .... :/ [22:41] bigjools: it is release team decision whrther to accept fizes though [22:41] yeah === freeflying is now known as freeflying_away === freeflying_away is now known as freeflying === CyberJacob is now known as CyberJacob|Away === freeflying is now known as freeflying_away === freeflying_away is now known as freeflying [23:47] bigjools: so how fast is the fastpath install? [23:50] lifeless: the actuall installer is blinding, about 2 mins [23:51] cool [23:51] but you have reboots and cloud-init overhead on that [23:51] yeah [23:51] thats disk-image fast :>... I suspect it is disk image based, no? [23:51] yes [23:52] makes my life a little nicer doing the development dance