| === jhodapp is now known as jhodapp|afk | ||
| === chihchun_afk is now known as chihchun | ||
| === chihchun is now known as chihchun_afk | ||
| === chihchun_afk is now known as chihchun | ||
| rsalveti | one interesting issue when checking mir with nexus 10 | 04:39 |
|---|---|---|
| rsalveti | bug 1203268 | 04:39 |
| ubot5 | bug 1203268 in Mir "Mir fails to start on Nexus 10 as display is already unblanked" [Medium,Triaged] https://launchpad.net/bugs/1203268 | 04:39 |
| rsalveti | mir_demo_server_basic fails because unblank returns an error (already unblanked) | 04:39 |
| rsalveti | which shouldn't be fatal | 04:39 |
| RAOF | Mmm. 21s latency to google.com. My internet really knows how to party recently. | 04:58 |
| RAOF | This bodes excellently for the upcoming hangout! | 04:59 |
| tvoss | RAOF, ping | 05:02 |
| RAOF | tvoss: Pong | 05:04 |
| duflu | Perhaps the copper is jealous of the approaching fibre? | 05:30 |
| RAOF | Mayhap | 05:31 |
| duflu | Whereas my copper now needs to last till the next Labour government. | 05:33 |
| duflu | Or something | 05:34 |
| === chihchun is now known as chihchun_afk | ||
| === chihchun_afk is now known as chihchun | ||
| duflu | RAOF, hikiko hangout? | 06:11 |
| duflu | racarr? | 06:12 |
| * duflu assumes no kdub this time of day | 06:13 | |
| RAOF | Hm. missed the hangout? | 06:19 |
| duflu | RAOF: just cancelled | 06:20 |
| duflu | My audio is dead and no one other than alf turned up | 06:20 |
| Saviq | hey guys | 07:30 |
| Saviq | alf_, for https://code.launchpad.net/~afrantzis/mir/server-started-notification/+merge/191134 | 07:30 |
| Saviq | alf_, should we not have ABI / version bump there? so that we can depend on it? | 07:30 |
| alf_ | Saviq: no, we bump the ABI once when we merge from development-branch into lp:mir, to avoid ABI bump races (e.g. two branches increasing the ABI to the same value etc) | 07:32 |
| mlankhorst | RAOF: have you looked at my patch? :P | 08:00 |
| Saviq | alf_, yeah that's fine, I'm not asking straight away, but there will be a bump, yeah :) | 08:14 |
| Saviq | alf_, any idea what can we put in Build-Depends: libmirserver-dev (>= ???) then? | 08:15 |
| Saviq | alf_, we've >= 0.0.14 now | 08:16 |
| mlankhorst | RAOF: but yeah using gbm as 'native' backend would be preferred for create pixmap/lookup image | 08:19 |
| mlankhorst | makes life easiser | 08:19 |
| mlankhorst | -s | 08:19 |
| mlankhorst | my patch simply makes gbm creating screen not run into weird pointer issues | 08:19 |
| alf_ | Saviq: my guess is that we will go to 0.0.16 and libmirserver8, but kgunn should have a definitive answer | 08:20 |
| Saviq | alf_, k thanks | 08:20 |
| alf_ | duflu: btw, we could reduce coupling by using a NiceMock, so that we could just expect glEnable(GL_BLEND) = 0 times glDisable(GL_BLEND) = 1 time (and perhaps expect glDrawArrays() to ensure we Disable before drawing) | 08:27 |
| duflu | alf_: Umm, redesign the GLRenderer tests to be nicer, separately? It's done now | 08:28 |
| alf_ | duflu: ok | 08:28 |
| tvoss | alan_g, ping | 08:43 |
| alan_g | tvoss: hi | 08:43 |
| tvoss | alan_g, hey there, do you keep on digging into why mir/u8 becomes slow after the uitk tests? | 08:44 |
| alan_g | tvoss: yes, getting back to that | 08:47 |
| tvoss | alan_g, thx | 08:48 |
| * alan_g has broadband problems again :( | 08:50 | |
| mlankhorst | alf_: oh btw finally got around to testing nested mir, works unsurprisingly | 09:02 |
| alf_ | mlankhorst: \o/, excellent, thanks! | 09:03 |
| RAOF | mlankhorst: I have indeed looked at your patch. | 09:15 |
| mlankhorst | RAOF: well any work done should be on top of that as base, because it's the minimum to get gbm working ;) | 09:16 |
| RAOF | mlankhorst: Yeah. | 09:17 |
| RAOF | mlankhorst: I just still not convinced that getting gbm working is the appropriate goal :) | 09:17 |
| mlankhorst | RAOF: well not sure how you want to get nested mir working otherwise.. | 09:17 |
| RAOF | You pass in a gbm_bo to create_image_pixmap_khr, you pull the __DRIImage out of it, and you dupImage() it? | 09:18 |
| mlankhorst | RAOF: and hit the intel bug again? | 09:19 |
| mlankhorst | or maybe similar bugs in radeon/nouveau | 09:19 |
| RAOF | Of course, that doesn't actually *work*, but I don't see a good reason why it *shouldn't* work ☺ | 09:19 |
| mlankhorst | because you create 2 instances of screen | 09:19 |
| mlankhorst | which each have separate tracking | 09:19 |
| mlankhorst | for the same drm fd | 09:19 |
| mlankhorst | and there is no refcounting for gem, it's create/destroy only | 09:20 |
| RAOF | Right, but there *is* refcounting for __DRIImage | 09:20 |
| mlankhorst | ok fine | 09:20 |
| RAOF | I've traced it down, and the appropriate intel_region is reffed. | 09:20 |
| mlankhorst | libdrm/intel/intel_bufmgr_gem.c | 09:20 |
| mlankhorst | that is where the problem was | 09:20 |
| mlankhorst | sec | 09:21 |
| mlankhorst | you create 2 separate drm_intel_bufmgr_gems for the same fd | 09:21 |
| mlankhorst | create a bo against one, and validate it in the other | 09:21 |
| RAOF | Aaaah. | 09:22 |
| mlankhorst | this breaks down in drm_intel_add_validate_buffer2 | 09:22 |
| RAOF | *That* makes more sense. | 09:22 |
| mlankhorst | specifically the line drm_intel_bufmgr_gem *bufmgr_gem = (drm_intel_bufmgr_gem *)bo->bufmgr; | 09:22 |
| mlankhorst | and drm_intel_bufmgr_gem has its own dirty etc tracking that a your solution wouldn't cover, but i guess you get the point ;) | 09:22 |
| RAOF | Boo. | 09:23 |
| RAOF | Passing in the gbm_device is annoyingly ugly :( | 09:23 |
| mlankhorst | it's the only solution :P | 09:24 |
| mlankhorst | RAOF: or we could make a gbm mir backend and use platform_drm? :P | 09:25 |
| RAOF | I was actually thinking about that. | 09:25 |
| RAOF | Although, you know what would be easier? | 09:25 |
| mlankhorst | dno? | 09:26 |
| RAOF | An EGL extension inverting the problem! | 09:26 |
| mlankhorst | creating a gbm from egl? | 09:26 |
| RAOF | ie: rather than trying to import foreign buffers, export a buffer. | 09:26 |
| mlankhorst | erm you still hit the same issue | 09:26 |
| mlankhorst | same fd, can't validate it | 09:26 |
| RAOF | No, you'd end up with it imported on a different fd. | 09:27 |
| mlankhorst | meh just don't make life even harder, go with the solution I wrote. :S | 09:27 |
| RAOF | Yeah. | 09:27 |
| RAOF | Actually... isn't there already an "Export EGL image to dma-buf fd" jobby? | 09:28 |
| mlankhorst | i thought only importing | 09:28 |
| alf_ | tvoss: alan_g: another data point about unity8 slowness after AP tests: it seems that the whole system has become slower, especially I/O. For example, apt-get install progresses awfully slowly when "Reading package lists". Stopping unity8 restores performance. So my guess is something IO related is going on. | 09:28 |
| RAOF | Yeah. | 09:28 |
| RAOF | You're right. | 09:28 |
| tvoss | alf_, interesting. can you strace unity8? I think we will see some waits/polls there that shouldn't be there | 09:29 |
| alan_g | alf_: checked the memory footprint? | 09:29 |
| mlankhorst | fix XMir to work seamlessly first. ;) | 09:29 |
| alf_ | tvoss: I will, that what the apt-get install was for :) | 09:29 |
| RAOF | mlankhorst: Yeah, yeah... :) | 09:29 |
| tvoss | alf_, ;) | 09:29 |
| mlankhorst | You still have 4 months or so. ;D | 09:29 |
| * RAOF really really EODs | 09:30 | |
| tvoss | RAOF, bye | 09:30 |
| mlankhorst | and good night ;) | 09:30 |
| alf_ | alan_g: tvoss:good idea, and you are probably right... I see: 980m 624m 581m | 09:30 |
| tvoss | alf_, of unity8? | 09:31 |
| alf_ | tvoss: yes | 09:31 |
| tvoss | wow | 09:31 |
| tvoss | hmmm, valgrinding on the phone? :) | 09:31 |
| alf_ | tvoss: normal usage (before AP tests) is 425m 83m 48m | 09:32 |
| tvoss | aha | 09:33 |
| tvoss | alf_, mako or maguro? | 09:33 |
| alf_ | tvoss: mako | 09:33 |
| alan_g | tvoss: I've played around with unity8 for a while without seeing any surfaces leaked. (Now to work out how to run the tests) | 09:38 |
| tvoss | alan_g, ack, thx | 09:39 |
| alf_ | alan_g: tvoss: the memory piles up as new tests are being run. However, opening/closing apps manually seems to release memory normally (looking at top output). So perhaps there is something in the way that autopilot works that is causing the leaks? | 09:40 |
| tvoss | alf_, normal = opening/closing apps from the launcher ? | 09:41 |
| alf_ | tvoss: alan_g: Yes. Although, arguably, unity8 should not allow autopilot to cause leaks even if it misbehaves. | 09:42 |
| tvoss | alf_, it might be due to the upstart based app launching | 09:42 |
| tvoss | alf_, can you try invoking apps from the cmdline, please? | 09:42 |
| alf_ | tvoss: through upstart? | 09:42 |
| tvoss | alf_, yup, we start applications via the user upstart session nowadays | 09:43 |
| tvoss | alf_, that's how ap starts apps | 09:43 |
| alf_ | tvoss: hmm, so how do you actually start an app with upstart? 'start <appname>' doesn't work | 09:49 |
| tvoss | popey, can you help alf_ real quick?^ | 09:50 |
| * popey arrives | 09:51 | |
| popey | you need APP_ID | 09:51 |
| alf_ | popey: ok, where do I get that from? | 09:51 |
| popey | start application APP_ID=music-app | 09:51 |
| popey | something like that I think | 09:51 |
| popey | it's the bit of the .desktop file | 09:52 |
| popey | often found in /usr/share/applications or ~/.local/share/applications | 09:52 |
| alf_ | popey: great, thanks | 09:53 |
| alf_ | popey: can I use upstart to also stop an application? | 09:54 |
| popey | never tried ☻ | 09:56 |
| alf_ | popey: well, 'stop ...' doesn't work so I guess not | 10:01 |
| alf_ | alan_g: tvoss: aha, when killing (i.e. SIGTERM) an app, memory in unity8 is not released! | 10:02 |
| popey | oof | 10:02 |
| tvoss | alf_, that is, the friendly: please kill yourself SIGTERM is not registered by unity? | 10:03 |
| alan_g | alf_: does the server see the client has died? (connector report ought to say) | 10:04 |
| Saviq | tvoss, alf_, did memory usage increase enough to cause the slow down? i.e. are we swapping or somethng? | 10:05 |
| alf_ | alan_g: haven't checked yet, will start unity8 with MIR logging... | 10:05 |
| tvoss | Saviq, pre-test 425MB, post: 980MB | 10:05 |
| Saviq | tvoss, ok, yeah, that's bad | 10:05 |
| alf_ | tvoss: that's just virtual, resident was: 83m -> 624m | 10:06 |
| alan_g | alf_: and does the app actually exit? | 10:06 |
| tvoss | alf_, okay, that's even worse :) | 10:06 |
| alf_ | alan_g: yes | 10:06 |
| === chihchun is now known as chihchun_afk | ||
| alf_ | alan_g: tvoss: http://paste.ubuntu.com/6244872/ (ignore UbuntuKeyboardInfo - socket error, I am starting unity8 manually without maliit) | 10:17 |
| alf_ | alan_g: tvoss: the app drops the connection abruptly, so perhaps we are not cleaning up resources properly in this case? | 10:18 |
| alf_ | tvoss: So if autopilot stops apps like this, it would explain the leak. Can we find out how autopilot stops the test apps? | 10:21 |
| tvoss | alf_, good question. asac, can you help here? | 10:21 |
| tvoss | asac, alf_ I would assume first SIGTERM and SIGKILL if nothing happens | 10:22 |
| asac | would go for #qa | 10:23 |
| asac | and check with folks if anyone with autopilot know how is around... also you can check with osmonon | 10:23 |
| asac | and Saviq ... those have used autopilot a lot as well | 10:23 |
| asac | (and would at leaast have an idea how to find out) | 10:23 |
| asac | tvoss: alf_: ^^ | 10:24 |
| Saviq | tvoss, alf_, asac, it doesn't SIGKILL them | 10:25 |
| Saviq | tvoss, alf_, if the app under test is hanging, it will go "Killing app blah..." indefinitely | 10:25 |
| alf_ | Saviq: does it SIGTERM, thought? | 10:26 |
| alf_ | -t | 10:26 |
| Saviq | alf_, I imagine so, yes, how else? | 10:26 |
| asac | alf_: i think this might be the code: http://paste.ubuntu.com/6244898/ | 10:26 |
| asac | hmm. or not | 10:26 |
| asac | check out lp:autopilot ... testcase.py | 10:27 |
| asac | autopilot/testcase.py | 10:27 |
| Saviq | ok, so it never SIGKILLed for me... | 10:27 |
| asac | http://bazaar.launchpad.net/~autopilot/autopilot/trunk/view/head:/autopilot/testcase.py | 10:27 |
| asac | Saviq: did you see processes not getting TERM'ed? | 10:28 |
| tvoss | SIGTERM | 10:28 |
| asac | and it didnt KILL? feels like a bug then | 10:28 |
| jibel | tvoss, AP does a SIGTERM/SIGKILL to terminate applications | 10:29 |
| asac | but i dont think this is what we see here? | 10:29 |
| tvoss | jibel, so sigterm first, then sigkill? | 10:29 |
| asac | see the code. seems like it ... yes | 10:29 |
| asac | after 9 seconds :) | 10:29 |
| Saviq | asac, yeah, unity8 has an issue on TERM when it gets stuck if still animating | 10:29 |
| jibel | tvoss, yes, that's in the code asac found | 10:29 |
| asac | Saviq: so the kill code didnt work? | 10:30 |
| Saviq | asac, it didn't seem to indeed | 10:30 |
| asac | err ... never happened? | 10:30 |
| asac | Saviq: sure it was autopilot that was hanging and not unity? | 10:30 |
| asac | err ignore | 10:30 |
| Saviq | asac, with upstart it's working (assume upstart is SIGKILLing) | 10:30 |
| asac | well. hard to say without being able to reproduce | 10:30 |
| Saviq | asac, yeah, had to kill -9 unity8 | 10:30 |
| asac | maybe this is not the code that is getting run though | 10:30 |
| Saviq | asac, I expect it is - I saw the "Killing process..." indefinitely when unity8 hung | 10:31 |
| asac | there is also one hit for TERM in autopilot code here: | 10:31 |
| asac | bin/autopilot-sandbox-run:trap on_exit EXIT INT QUIT ABRT PIPE TERM | 10:31 |
| asac | err ignore | 10:31 |
| asac | not sure what that sandbox is and when its used though | 10:31 |
| alf_ | tvoss: asac: ok, so we have found when the unity8/mir leaks happen. Now to find out why unity8/mir doesn't clean up if a connection is terminated abruptly... on it... | 10:31 |
| tvoss | alf_, +1 | 10:31 |
| alf_ | after lunch :) | 10:32 |
| tvoss | alf_, enjoy | 10:32 |
| === alf_ is now known as alf|lunch | ||
| jibel | asac, that's for developer to run their code locally, not for production use | 10:32 |
| jibel | asac, it runs AP test inside xvfb or xephyr instead of using the active session | 10:33 |
| asac | ic ... thanks | 10:33 |
| asac | alf|lunch: what is exactly leaking? | 10:33 |
| asac | some resources related to maliit i figure? | 10:33 |
| alf|lunch | asac: no idea yet | 10:34 |
| === alan_g is now known as alan_g|afk | ||
| === hikiko is now known as hikiko|lunch | ||
| === alan_g|afk is now known as alan_g | ||
| Saviq | t1mp, alf|lunch and tvoss are looking into the uitk ap failures | 11:23 |
| t1mp | great, thanks | 11:23 |
| Saviq | and overall system slowdown after it | 11:24 |
| t1mp | alf|lunch, tvoss, Saviq so now it seems that individual tests pass if we run them after a reboot | 11:24 |
| t1mp | but if we run all the tests, or if we run a single test a lot of times (like 10-20), then they start to fail | 11:24 |
| t1mp | and after they fail, also qmlscene segfaults | 11:24 |
| t1mp | so it seems like an issue with cleaning up processes | 11:24 |
| kalikiana | ^^ I cannot always see them, but sometimes I see the dash filling up with thumbnails after those test runs | 11:25 |
| kalikiana | I'm guessing apparmor prevents me from "seeing" it in ps | 11:25 |
| tvoss | t1mp, yup, alf|lunch is tracking that down | 11:25 |
| t1mp | tvoss: great. please keep us informed also :) | 11:25 |
| t1mp | and let us know if we can help | 11:26 |
| tvoss | t1mp, please stay around here :) | 11:26 |
| t1mp | sure | 11:26 |
| === alf|lunch is now known as alf_ | ||
| t1mp | alf_: hello. I hope you enjoyed your lunch :) as you can see, SDK people are invading this channel so we can bug/help you with the UITK autopilot failures | 11:29 |
| alf_ | t1mp: ok, I am currently investigating the mir part of it, will let you know | 11:30 |
| t1mp | alf_: ok, great. | 11:30 |
| t1mp | alf_: are there other parts to it besides the mir part? | 11:31 |
| alf_ | t1mp: I am not sure yet. It seems that if an app is SIGTERMinated, not all resources are released properly, looking into what exactly is happening there. | 11:32 |
| alf_ | t1mp: => resources in the server, causing leaks | 11:33 |
| === hikiko|lunch is now known as hikiko | ||
| t1mp | alf_: ok | 11:53 |
| alan_g | alf_: I've been playing - Mir doesn't see (e.g. terminal) drop the connection if I send it a SIGTERM. | 12:00 |
| * alan_g was looking at this sort of issue in the client side comms before interrupt (and planning to look at same on the server next) | 12:02 | |
| === alan_g is now known as alan_g|lunch | ||
| alf_ | alan_g|lunch: I am getting server messages like "connection dropped without disconnect | 12:03 |
| alf_ | alan_g|lunch: aren't you getting any messages at all? | 12:04 |
| === alan_g|lunch is now known as alan_g | ||
| alan_g | alf_: I'm getting the connection messages, but nothing about disconnect - but maybe I've a slightly different scenario. | 12:44 |
| alf_ | alan_g: (Have you enabled all the REPORTS properly?) In my case, investigation shows that the shell::ApplicationSession is never destroyed, because unity-mir is keeping a strong handle to it, keeping the 'application' alive... | 12:47 |
| alan_g | alf_: (I'm starting the terminal from the u8 GUI and killing it from an adb shell) | 12:47 |
| alan_g | alf_: I've got DebugSurfaces report and connector report | 12:47 |
| alf_ | alan_g: FWIW, "connection dropped without disconnect" is a SessionMediatior report message | 12:49 |
| alan_g | alf_: adding it now | 12:49 |
| alf_ | alan_g: btw, we should change the connector report to use "Connector" instead of "SessionMediator" | 12:50 |
| alan_g | alf_: True | 12:50 |
| alan_g | alf_: I still don't see the server noticing the disconnect... | 12:54 |
| alan_g | alf_: my bad - it was on stderr, not stdout | 12:59 |
| alan_g | alf_: You're ahead of me here. (I'll go fix the report. ) | 13:03 |
| alf_ | alan_g: ok | 13:04 |
| alf_ | greyback: could you please explaing the logic of ApplicationManager::onSessionStopping() in unity-mir/src/modules/Unity/Application/application_manager.cpp ? | 13:43 |
| didrocks | tvoss: did you get any progress on the slowdown that we can trigger easily after running the ubuntuuitoolkit AP tests? | 14:12 |
| tvoss | didrocks, see backlog, alf_ and alan_g are looking into the issue and it seems to be a memory leak | 14:14 |
| didrocks | any ETA? | 14:14 |
| tvoss | alf_, alan_g ^ | 14:15 |
| alan_g | didrocks: tvoss: alf_ is the man | 14:15 |
| alf_ | didrocks: tomorrow for sure, maybe today but no promises | 14:16 |
| didrocks | alf_: ok, to be in finale, we need to avoid an ABI break though FYI (we just rejected the sigstop one because of that) | 14:17 |
| kalikiana | just keep in mind that this has been preventing uitk releases for days, no fix isn't exactly an option | 14:19 |
| tvoss | kalikiana, strong words don't help here, let alf_ keep on working | 14:19 |
| kalikiana | if didrocks talks about rejecting fixes those are strong words for me | 14:20 |
| tvoss | kalikiana, well, that's didrocks department and decision in the end. I'm pretty sure alf_ will try to avoid an ABI break | 14:20 |
| didrocks | (hence why I prefer to warn in advance) | 14:22 |
| greyback | alf_: If Mir reports an application has stopped, but shell/upstart wasn't one to stop it, we assume the lifecycle management killed it, so set the application state as "Stopped" - keeping the app in the list of running apps | 14:26 |
| greyback | alf_: that what you wanted to know? | 14:26 |
| tvoss | greyback, why would the lifecycle mgmt do something without unity/mir knowing? | 14:26 |
| === dandrader is now known as dandrader|afk | ||
| tvoss | greyback, the point is: how do you distinguish from autopilot sigterm'ing a test app? | 14:28 |
| greyback | tvoss: well nothing is telling unity/mir that the OOM has killed an app | 14:28 |
| greyback | tvoss: yep that's a problem. AP should really be using upstart, not relying on the desktop_file_hint hack | 14:29 |
| tvoss | greyback, what would need to be changed? | 14:30 |
| greyback | tvoss: well first, is this really a problem? Is it breaking anything? | 14:30 |
| tvoss | greyback, it causes u8 to slow down to a crawl | 14:31 |
| greyback | tvoss: second, AP would need to launch apps using upstart-app-launch | 14:31 |
| === dandrader|afk is now known as dandrader | ||
| alan_g | tvoss: @"how do you distinguish from autopilot sigterm'ing a test app?" why would you need to? | 14:46 |
| alan_g | tvoss: nm - I just understood the context | 14:47 |
| tvoss | alan_g, killed by lifecycle is a valid reason to keep the app as "running" around in the shell, killed by autopilot is not a valid reason | 14:47 |
| alan_g | tvoss: yeah. But the Mir resources still need to be cleaned up | 14:47 |
| alan_g | *session resources | 14:48 |
| tvoss | alan_g, yup, alf_ and greyback are on it | 14:48 |
| * alan_g thinks that is should be as simple as using a weak_ptr to the sh::Session instead of a shared_ptr | 14:50 | |
| alan_g | (From 50.000m) | 14:50 |
| tvoss | alf_, ^ | 14:52 |
| tvoss | ;) | 14:52 |
| alf_ | alan_g: possibly, although I think this may be too risky a change at this point for unity-mir (but I am not very familiar with the unity-mir internals). | 14:54 |
| alf_ | greyback: ^^? | 14:54 |
| greyback | alf_: yep, that's too big a change right now. I'm keeping it simple | 14:55 |
| alf_ | hikiko: kgunn: racarr: stand up | 15:03 |
| kgunn | alf_: gonna miss today...let me know if you got any questions | 15:04 |
| greyback | alf_: care to have a look? https://code.launchpad.net/~gerboland/unity-mir/fix-leaks/+merge/191449 | 16:04 |
| alf_ | greyback: looking | 16:04 |
| tvoss | greyback, did you try that patch with the uitk testsuite? | 16:11 |
| greyback | tvoss: no, I ran through the steps in the bug. | 16:11 |
| greyback | tvoss: but I'll do that, just to check | 16:12 |
| tvoss | greyback, yup | 16:12 |
| alan_g | greyback: I lack the surrounding context - but why is the delete only when "application == m_focusedApplication"? | 16:14 |
| alf_ | greyback: tested successfully on phone, now running uitk too | 16:15 |
| alf_ | greyback: (phone == single app case) | 16:16 |
| greyback | alan_g: if app not in forefront, and it dies, we are pretending the app is still alive. If the user then requests that app, we will launch it again, hopefully restore its state, and give that to the user | 16:16 |
| greyback | alan_g: so ideally they'll not realise the app was dead | 16:16 |
| alf_ | greyback: would it make sense to also add application->setSession(nullptr); to some cases in ApplicationManager::onProcessStopped() ? | 16:18 |
| alan_g | greyback: Is there another line that releases the sh::Session pointer? setSession()? | 16:18 |
| greyback | alf_: actually yeah, there's one place, nice spot | 16:20 |
| greyback | alan_g: is it the Application object that's holding the sh::Session pointer. Calling setSession(nullptr) deletes that shared pointer | 16:21 |
| alan_g | greyback: I get it | 16:22 |
| alf_ | greyback: tvoss: verified ubuntuuitoolkit tests run fine, system fluid after tests | 16:24 |
| greyback | alf_: yep here too | 16:24 |
| asac | alf_: fixed? | 16:25 |
| greyback | alf_: pushed one other fix | 16:25 |
| alf_ | asac: yes, with greyback's MP: https://code.launchpad.net/~gerboland/unity-mir/fix-leaks/+merge/191449 | 16:25 |
| asac | alf_: do you feel the issue is fully understood now? | 16:26 |
| asac | and this is a clean fix? | 16:26 |
| asac | or rather a hack in the hope of ... :)? | 16:26 |
| didrocks | and is it the only fix? | 16:27 |
| asac | right :) | 16:27 |
| asac | also that | 16:27 |
| asac | alf_: greyback: ^^ | 16:27 |
| alf_ | asac: didrocks: clean fix, plugging a memory leak | 16:27 |
| alf_ | asac: didrocks: what do you mean by only fix? | 16:27 |
| asac | alf_: is this the only patch we need to take? | 16:28 |
| didrocks | alf_: like this is the cause of all the slowliness we see after launching ubuntuuitoolkit AP tests? | 16:28 |
| asac | compared to 99 | 16:28 |
| greyback | asac: was my bug, problem clear, fix is correct | 16:28 |
| greyback | asac: my bug as in I introduced the bug :) | 16:29 |
| alf_ | asac: yes, slowness was because unity8 process ended up taking up 700MB resident memory, including graphics surfaces | 16:29 |
| asac | greyback: well, so what else was committed to mir branch after 99 image content | 16:29 |
| asac | err unity-mir | 16:29 |
| asac | didrocks: maybe check and make a call :) | 16:29 |
| didrocks | I'm checking | 16:29 |
| asac | the patch looks good | 16:29 |
| didrocks | yeah | 16:29 |
| greyback | asac: an OOM value setter by tvoss | 16:29 |
| asac | didrocks: we would take the OOM anyway? | 16:29 |
| asac | i remember seeing it on landing | 16:30 |
| didrocks | asac: yeah, but unity-mir wasn't part of the landing ask | 16:30 |
| didrocks | so not that part | 16:30 |
| * didrocks looks at the code | 16:30 | |
| didrocks | hum, I don't like it | 16:31 |
| didrocks | (rev 127) | 16:31 |
| didrocks | greyback: did you test with that one? | 16:31 |
| greyback | didrocks: yes, it works | 16:31 |
| didrocks | greyback: trusting you on rev 127 then (the OOM one) :) | 16:32 |
| greyback | didrocks: ack | 16:33 |
| asac | didrocks: check with tvoss | 16:34 |
| asac | tvoss: http://bazaar.launchpad.net/~mir-team/unity-mir/trunk/revision/127 | 16:34 |
| tvoss | asac, didrocks waiting for lool to revisit https://code.launchpad.net/~thomas-voss/unity-mir/less-aggressive-scores/+merge/191440 | 16:45 |
| tvoss | asac, didrocks making the oom score adjustments more conservative | 16:45 |
| lool | tvoss: So do we want to test this too? | 16:45 |
| lool | tvoss: I started looking, but to land this we'd also want to test the OOM again | 16:45 |
| didrocks | lool: is this really wanted for finale? ^ | 16:46 |
| lool | didrocks: well mu | 16:46 |
| lool | didrocks: I personally think it can come in an update | 16:46 |
| didrocks | I don't want pushing the finale cut forever | 16:46 |
| didrocks | ok, let's get that tomorrow, once we are happy with the image | 16:46 |
| lool | we have tested OOM, it has a small bug | 16:47 |
| lool | this version will be cleaner, but it can land in a couple of days | 16:47 |
| asac | didrocks: we could ask folks for the performance fix isolated | 16:48 |
| asac | backing out the oom commit | 16:48 |
| asac | so we can take it | 16:48 |
| asac | ... just saying that that is an option | 16:48 |
| asac | (not saying we should do that... leave that to you) | 16:48 |
| didrocks | asac: greyback tested with the oom commit | 16:49 |
| didrocks | asac: I have full trust on him :) | 16:49 |
| lool | tvoss: Hmm why file.open(QIODevice::WriteOnly | QIODevice::Text) on the adjuster's oom file? | 16:49 |
| didrocks | asac: otherwise, I would have ask for a revert TBH | 16:49 |
| lool | tvoss: dont we want ReadOnly? | 16:50 |
| tvoss | lool, oh, good point | 16:52 |
| lool | tvoss: let's not rush this in; we could even take the time to write tests along side, the way you've split the functions is very nice for testability actually | 16:53 |
| tvoss | lool, yup, happy to iterate | 16:54 |
| tvoss | lool, that said, I will look into it tomorrow again | 16:54 |
| tvoss | lool, fine for you? | 16:54 |
| lool | tvoss: Not being very good on the C++ side, I dont understand whether int * float to int will be nice | 16:54 |
| lool | tvoss: Sure, I can review tomorrow, dont think we will land tomorrow though | 16:54 |
| lool | friday rather | 16:54 |
| tvoss | lool, ack | 16:54 |
| tvoss | greyback, alan_g, alf_ thanks for the fix :) | 16:54 |
| lool | tvoss: so I would have written * 80 / 100 rather than * 0.8 | 16:54 |
| lool | but perhaps that's ridiculous given what the compiler already knows | 16:55 |
| tvoss | lool, yup | 16:55 |
| * tvoss grabs dinner | 16:55 | |
| tvoss | back in ~30 mintues | 16:55 |
| === dandrader is now known as dandrader|lunch | ||
| lool | I will slowly walk away | 16:58 |
| lool | might take a sneak peek to see if last landings come in nicely | 16:58 |
| lool | but everything for image #100 is set | 16:58 |
| tvoss | lool, thanks :) | 17:09 |
| * greyback eod | 17:10 | |
| tvoss | greyback, o/ | 17:10 |
| t1mp | alf_: any news for the uitk autopilot tests? | 17:50 |
| kalikiana | t1mp: https://code.launchpad.net/~gerboland/unity-mir/fix-leaks/+merge/191449 | 17:51 |
| kalikiana | but haven't tested it myself yet | 17:51 |
| kalikiana | (eod for me) | 17:51 |
| t1mp | kalikiana: at least the name of the branch sounds good :D | 17:51 |
| t1mp | if it fixes our issues that's awesome :) | 17:51 |
| t1mp | but yeah, I'll also see tomorrow. eod time | 17:51 |
| alf_ | t1mp: yes, tested it fixes the slowness after uitk | 17:52 |
| t1mp | alf_: and the uitk autopilot tests run then? | 17:52 |
| alf_ | t1mp: I have run the full uitk twice without problems with this branch | 17:53 |
| alf_ | t1mp: (60 tests) | 17:53 |
| t1mp | wow. super :D | 17:53 |
| t1mp | alf_: thanks! | 17:53 |
| t1mp | ah greyback is offline, I'll thank him tomorrow :) | 17:53 |
| davmor2 | tvoss, kgunn: http://ubuntuone.com/0Vem5WU2FOKaY5QVVnnmcC sorry for the sideways view bit of weirdness with android videoing, but you should at least be able to tell that it is much snappier now :) | 17:56 |
| racarr | I'm concerned that the ui toolkit tests | 18:01 |
| racarr | passed yesterday? and failed today :* | 18:01 |
| racarr | :(* | 18:01 |
| t1mp | racarr: passed yesterday? they are failing since last week. | 18:03 |
| racarr | t1mp: You mean the autopilot tests? | 18:07 |
| davmor2 | tvoss, kgunn: that is image 99 by the way :) feels a much nicer place to be :) | 18:07 |
| racarr | I think I looked | 18:08 |
| racarr | at the wrong report yesterday a bit :p ignore me | 18:08 |
| t1mp | racarr: yes | 18:08 |
| t1mp | racarr: ok :) | 18:08 |
| tvoss | davmor2, thx :) | 18:08 |
| t1mp | racarr: I was talking about this https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1239646 | 18:09 |
| ubot5 | Ubuntu bug 1239646 in Ubuntu UI Toolkit "CI fails most tests on UITK trunk" [Critical,In progress] | 18:09 |
| racarr | I don't understand the failures up there though.... | 18:09 |
| t1mp | racarr: might be fixed in mir now | 18:09 |
| tvoss | racarr, I'm pretty sure things are fixed now | 18:09 |
| tvoss | t1mp, in unity-mir | 18:09 |
| racarr | Ok | 18:09 |
| racarr | how to interpret test failures like http://reports.qa.ubuntu.com/smokeng/saucy/touch_mir/mako/99:20131015.2:20131015/4749/ubuntu-ui-toolkit-autopilot/491077/ | 18:10 |
| racarr | though | 18:10 |
| racarr | oh is it the OOM killer | 18:11 |
| tvoss | yup | 18:11 |
| racarr | fun | 18:11 |
| t1mp | tvoss: yeah that's great. I'll try the tests tomorrow :) | 18:13 |
| tvoss | racarr, not :) | 18:16 |
| tvoss | there he is | 18:16 |
| tvoss | greyback, o/ | 18:16 |
| greyback | yes? | 18:19 |
| tvoss | you rock :) | 18:19 |
| greyback | alf_ deserves the credit, he tracked down the issue | 18:19 |
| tvoss | well, you guys just worked together really well, thanks :) | 18:22 |
| === dandrader|lunch is now known as dandrader | ||
| kgunn | kdub: do you consider "support for bypassing unity8 surface" to the be the same thing as what I call "android bypass" ?? if its different...let me know how | 19:35 |
| thomi | morning | 19:36 |
| kdub | kgunn, both are 'bypass' but the path they will take in the code is different | 19:37 |
| kdub | unity 8 is internal, so there's less plumbing to hash out when compared to a bypassed IPC client | 19:38 |
| kdub | morning thomi | 19:38 |
| thomi | o/ | 19:38 |
| kgunn | kdub: hmmm....not sure i follow, are you caling unity8 bypass really just the shell ? whereas IPC client bypass would be apps ? | 19:40 |
| kgunn | thomi: \o | 19:40 |
| kdub | kgunn, right | 19:41 |
| kgunn | kdub: are both tied to android ? | 19:42 |
| kgunn | wondering how it differs from what we already have | 19:43 |
| kgunn | ...i guess what we have is closer to ipc bypass...just on gbm | 19:43 |
| kdub | right, xmir (an ipc client) is bypassed | 19:43 |
| racarr | kdub: Wait so are you doing unity8 bypass? | 19:58 |
| kdub | not right now, i think we're just organizing the future | 19:58 |
| racarr | Ok | 19:58 |
| racarr | I have an idea for a simple fix for | 19:59 |
| racarr | https://bugs.launchpad.net/mir/+bug/1227739 | 19:59 |
| ubot5 | Ubuntu bug 1227739 in Mir "Mir continues to render background application surfaces even when they're not visible" [High,In progress] | 19:59 |
| === dandrader is now known as dandrader|afk | ||
| === dandrader|afk is now known as dandrader | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!