| gary_poster | hey frankban, forgot about juju server for bug 1240708 | 11:16 |
|---|---|---|
| _mup_ | Bug #1240708: API server falls over repeatably during AllWatcher Next, killing GUI <juju-core:New> <juju-gui:Triaged> <https://launchpad.net/bugs/1240708> | 11:16 |
| gary_poster | I still don't see why it would be on our side | 11:16 |
| gary_poster | but as long as it is fixed, I'm ok with it :-) | 11:16 |
| frankban | gary_poster: the builtin server is enabled by default in the new charm release. if you switch to the legacy server, the problems (errors in console, inspector frozen) disappear | 11:18 |
| gary_poster | frankban, ah ok | 11:19 |
| gary_poster | :-/ | 11:19 |
| frankban | gary_poster: I am investigating and it seems to be (drum roll and shame on me) a string encoding problem in a log message (when the charm info includes non-ascii bytes) | 11:20 |
| gary_poster | frankban, lol, yay string encoding | 11:21 |
| frankban | gary_poster: I stupidly assumed the ws messages were already encoded, but tornado (a good guy) gives them to me as unicode objects | 11:21 |
| gary_poster | frankban, completely understandable. ugh string encoding in Python. yay for easy fix, hopefully. | 11:23 |
| frankban | gary_poster: the fix is easy: add .encode('utf-8') to all the log calls which include a ws message | 11:23 |
| gary_poster | frankban, ideally we would have had some people using the server when we asked ;-) | 11:23 |
| gary_poster | cool frankban. have you verified that this fixes the symptoms? | 11:24 |
| frankban | gary_poster: https://ec2-54-234-223-41.compute-1.amazonaws.com/ (password in pvt): could you please double check? that's running the builtin server. | 11:26 |
| gary_poster | frankban, perfect | 11:28 |
| gary_poster | frankban, I still don't see exactly how this would have resulted in a stop in the core logs. Our server fell over and disconnected from core? | 11:29 |
| frankban | gary_poster: at least the builtin server was trying to get our attention: "Juju API unexpectedly disconnected". when a message arrives from the iostream, tornado calls the async callback previously registered. if an exception is raised by the callback, it aborts the connection. In out case the callback is WebSocketClientConnection.on_message, which calls WebSocketHandler.on_juju_message, which calls "logging.debug | 11:35 |
| frankban | (self._summary + 'juju -> client: {}'.format(message))". the error in the juju-core logs refers to a next() response not being able to be sent because the connection is dropped (I guess) | 11:35 |
| gary_poster | frankban, I did have a related thought: we ought to make our server disconnect webserver connections when we get disconnected from core | 11:35 |
| gary_poster | frankban, ah ok | 11:36 |
| gary_poster | frankban, do you want to postpone 1-on-1 or go ahead? completely up to you | 12:02 |
| frankban | gary_poster: joining | 12:02 |
| rick_h_ | antdillon: did you see the feedback on your branch? | 12:57 |
| rick_h_ | antdillon: make sense/in progress or need a hand with that? | 12:57 |
| rick_h_ | gary_poster: thinking on the conversation about the error stuff with promises I added a high maint. card for a generic 'smart' promise error catcher with some ideas in the notes | 13:00 |
| rick_h_ | gary_poster: let me know if that's not a good plan or there's a better one out there. | 13:00 |
| gary_poster | rick_h_, cool. I'll see if I can have an explicit time for this conversation in SF. thank you | 13:06 |
| frankban | gary_poster: could you please review https://codereview.appspot.com/14772044 ? | 13:24 |
| gary_poster | frankban, on it | 13:24 |
| frankban | gary_poster: if you need an environment ready to qa, you can use https://ec2-54-242-218-111.compute-1.amazonaws.com/ | 13:24 |
| gary_poster | perfect thanks frankban | 13:25 |
| gary_poster | frankban, had to look up {!r} :-) | 13:29 |
| frankban | :-) | 13:30 |
| gary_poster | frankban, shouldn't we have encoding protection for logging in server/guiserver/auth.py and server/guiserver/bundles/utils.py? Looking to see how _summary is generated also... | 13:34 |
| gary_poster | _summary looks fine as is | 13:35 |
| gary_poster | well, no... | 13:36 |
| gary_poster | request.uri can have unicode, right frankban ? | 13:36 |
| gary_poster | (server/guiserver/utils.py in request_summary function) | 13:36 |
| frankban | gary_poster: I'll check if request.uri is unicode. for the other places with logging, I'll add !r | 13:38 |
| gary_poster | cool thanks frankban. qa looks good and LGTM with those comments. recording on rv now | 13:38 |
| frankban | thanks | 13:38 |
| gary_poster | done | 13:40 |
| jcastro | hey gary_poster | 13:43 |
| jcastro | so I just deployed gui just now in AWS | 13:43 |
| gary_poster | rick_h_, antdillon did my comments on https://codereview.appspot.com/14700043/ make sense? antdillon, rick_h_ and I would love to get this landed | 13:43 |
| gary_poster | jcastro, listening | 13:43 |
| jcastro | and now in the inspector the link is not only unclickable | 13:43 |
| jcastro | I can't even highlight it to copy and paste | 13:43 |
| gary_poster | jcastro, what link? | 13:43 |
| jcastro | in the inspector | 13:43 |
| gary_poster | oh | 13:43 |
| jcastro | if I click wordpress/0 under running units | 13:44 |
| rick_h_ | gary_poster: yes, made sense to me. I've ping'd antdillon and if I don't hear back I'll take it over and get it done once I finish huw's here. | 13:44 |
| gary_poster | cool thanks rick_h_ | 13:44 |
| rick_h_ | *tsk *tsk huw forgot to add tests | 13:44 |
| gary_poster | I noticed :-) | 13:44 |
| rick_h_ | so adding to help it move forward so we'll have it on the tab | 13:44 |
| gary_poster | jcastro, hoping to make a release with the fix for the bug you reported today. unable to copy and paste is pretty odd | 13:44 |
| gary_poster | that is, hoping to make a release today of the bug you reported a week or so ago | 13:45 |
| jcastro | yeah I think that might be a browser bug | 13:45 |
| jcastro | gary_poster, is it within 3 hours? I am doing a demo during the ubuntu demo hangout | 13:45 |
| jcastro | so I can either work around or wait, I can do either or | 13:45 |
| jcastro | rick_h_, also, new presentation with the gui trick | 13:45 |
| jcastro | since google hangouts let you share only one window | 13:45 |
| jcastro | I added the google ssh for chrome extension, and then I ssh to localhost to do the juju cli stuff | 13:46 |
| gary_poster | jcastro, work around I'm afraid. we have one more blocker and person working on it doesn't start for a few minutes. I'll ping you if I have good news, but for now assume we won't make t in 3 | 13:46 |
| jcastro | that lets me tab back and forth from the gui and the CLI in one window, badass | 13:46 |
| gary_poster | jcastro, actually | 13:46 |
| rick_h_ | jcastro: hah! awesome | 13:46 |
| gary_poster | jcastro, if you want you could try using juju set juju-gui juju-gui-source=lp:juju-gui | 13:47 |
| gary_poster | jcastro if that works better for you, use it | 13:47 |
| antdillon | rick_h_, Hey, sorry knee deep in release. I read the comments, will fix them up now and push them | 13:47 |
| gary_poster | it will take about 10 min to build, during which the original release will be served | 13:47 |
| jcastro | gary_poster, I'll rehearse with the release for now and workaround | 13:47 |
| jcastro | I learned my lesson from demoing trunk | 13:48 |
| jcastro | not your trunk, I mean trunk in general | 13:48 |
| gary_poster | jcastro, :-) ack and understood. FWIW, we have an instance running 0.10.1 right now and copy/paste of url seems to be fine. :-/ | 13:49 |
| gary_poster | on ec2 | 13:49 |
| gary_poster | so dunno | 13:49 |
| jcastro | gary_poster, ok that appears to be a browser issue on my side | 13:49 |
| gary_poster | ok cool | 13:49 |
| jcastro | I killed chrome with a -9 and respawned it now it magically works | 13:49 |
| gary_poster | heh | 13:50 |
| gary_poster | ok | 13:50 |
| hatch | morning | 13:53 |
| jcastro | hey hatch | 13:53 |
| jcastro | and rick_h_ | 13:53 |
| jcastro | a guy put haste in the store | 13:53 |
| jcastro | it's a nodejs pastebin, same one that runs hastebin.com | 13:53 |
| jcastro | it demos nice | 13:53 |
| hatch | oh very cool, I'll have to check it out | 13:53 |
| gary_poster | hatch, welcome back! | 13:53 |
| gary_poster | nice time? | 13:53 |
| hatch | thanks! glad to be back | 13:54 |
| rick_h_ | jcastro: nice | 13:54 |
| hatch | it was nice to not be on a computer for a while :) | 13:54 |
| antdillon | rick_h_, gary_poster Do you know how I should implement the routing code for onboarding? | 13:57 |
| rick_h_ | antdillon: you don't need to. There's no routing really involved | 13:57 |
| gary_poster | antdillon, did you see the patch I provided? It's not perfect, but it's not bad. :-) | 13:57 |
| hatch | now onto the 400+ emails | 13:58 |
| rick_h_ | antdillon: oh yea there's a pastebin link gary gave you | 13:58 |
| gary_poster | only 400+? bah :-) | 13:58 |
| hatch | haha I tried to stay on-top of them | 13:58 |
| hatch | failed I guess | 13:58 |
| hatch | lol | 13:58 |
| gary_poster | :-) | 13:58 |
| antdillon | gary_poster, Ah sorry missed it, is it in the qa? | 13:58 |
| gary_poster | antdillon, yeah. lemme find... | 13:59 |
| gary_poster | antdillon, http://paste.ubuntu.com/6247161/ | 13:59 |
| antdillon | gary_poster, Awesome thanks | 14:00 |
| gary_poster | welcome | 14:00 |
| frankban | gary_poster: request.uri is already a string, fixed the other occurrences | 14:12 |
| bac | hey gary_poster. chat? | 14:13 |
| bac | hi hatch | 14:14 |
| hatch | hey bac | 14:14 |
| gary_poster | frankban, awesome. bac, sorry, realized I was missing when I got some water. coming over now | 14:17 |
| hatch | emails done | 14:48 |
| hatch | gary_poster: any specific task you'd like me on right now? | 14:49 |
| gary_poster | hatch, wow, right you are here. :-) Makyo is working on the remaining critical bug, so f he could use help that would be great. Otherwise...you could qa new bundle stuff you haven't seen, you could try making a version of the wiki bundle that has x/y annotations and make sure that works properly, or... | 14:52 |
| Makyo | hatch, fix firebug so that it doesn't close websockets if you set breakpoints. | 14:53 |
| gary_poster | hatch, bundle vis pan and zoom if you are up for challenge | 14:54 |
| gary_poster | hatch also could go for some clean up branches | 14:54 |
| gary_poster | hey luca__ I gave you a branch showing the behavior of hiding the inspector when you made a relation | 14:54 |
| rick_h_ | added a bug today about the activeTab support missing from the bundle details | 14:55 |
| gary_poster | you want that? | 14:55 |
| gary_poster | hatch ^^^ rick_h_ | 14:55 |
| rick_h_ | trivial | 14:55 |
| luca__ | gary_poster: ah yeah, I have not looked at that yet | 14:55 |
| hatch | sure | 14:55 |
| luca__ | gary_poster: it might be better to review it next week quickly when together | 14:55 |
| gary_poster | luca__, :-P I make you a branch and everything! :-) ok cool | 14:55 |
| hatch | and Makyo sorry can't help there - does the native FF inspector work yet? :) | 14:55 |
| luca__ | gary_poster: haha sorry :D | 14:55 |
| gary_poster | np :-) | 14:56 |
| Makyo | hatch, heh, I haven't tried in so long, come to think of it. Should just use gary_poster's trick rather than messing with config-debug so I can just use chrome. | 14:56 |
| Makyo | I guess that's better for QA than dev, though | 14:57 |
| luca__ | gary_poster: Also, I think having a 0 unit state could actually really help us | 15:06 |
| hatch | rick_h_: I will review your onboarding branch | 15:07 |
| rick_h_ | hatch: I'm actually reviewing/landing that for antdillon | 15:08 |
| rick_h_ | gary_poster: 's done a second review | 15:08 |
| rick_h_ | hatch: so we're good | 15:08 |
| * hatch rejects | 15:08 | |
| gary_poster | <snort> | 15:08 |
| hatch | missing description and camelcase in app.js (so far) | 15:09 |
| * hatch really would have rejected that branch | 15:17 | |
| * rick_h_ adds a description and fixes camelCase | 15:17 | |
| rick_h_ | hatch: due to the url hackery? | 15:17 |
| hatch | 4 event handlers for a hover change, url wakyness, plus some other minors | 15:17 |
| rick_h_ | well as you can see it's not been without it's dicussions | 15:18 |
| rick_h_ | and it's a first pass, it'll get updated. | 15:18 |
| rick_h_ | behind a FF | 15:18 |
| hatch | I guess....... | 15:19 |
| hatch | I'd like to at least see cards for the follow-ups | 15:19 |
| hatch | just so that the 'bad' code doesn't stick around | 15:20 |
| hatch | sorry that came off a little...harsh - it wasn't meant to be like that :) | 15:21 |
| hatch | 4h of sleep is messing with my filter lol | 15:24 |
| hatch | love the skinnier header | 15:30 |
| rick_h_ | yep | 15:30 |
| hatch | and I see the charm token has been used 'again'! lol | 15:31 |
| hatch | should put a big warning at the top of that file - "used EVERYWHERE" | 15:31 |
| hatch | haha | 15:31 |
| rick_h_ | yep, jcsackett has claim for most reused bit of code in the gui anywhere | 15:31 |
| hatch | oh I thought the token was your baby? | 15:32 |
| hatch | or did you just adopt it when he left? | 15:32 |
| rick_h_ | well I helped think hard about it :) | 15:32 |
| hatch | (woah that was kind of morbid reading it back) | 15:32 |
| rick_h_ | lol | 15:32 |
| gary_poster | hatch: hover change: that's probably something you change in no time flat. slip it in? I forgot about the YUI hover helpers. url wackiness: not sure what you mean, once my patch is applied, other than the fact that the desired behavior is not clear to me until fullscreen mode is gone. I made a call with behavior I thought was ok in the patch. might be nicer if it were in browse code so it didn't have to repeat | 15:32 |
| gary_poster | the "sidebar" logic, but enh. Do you have more concrete concerns that we should make a bug for? other minors: slip 'em in? This was a code contribution, and as such I want us to help it go smoothly. | 15:32 |
| rick_h_ | gary_poster: it's in and landed. Created a card to move to the browser.js module when we add support for storing the state of 'did the user see this, don't show again' logic | 15:33 |
| gary_poster | rick_h_, ok cool. | 15:33 |
| gary_poster | thank you | 15:33 |
| rick_h_ | gary_poster: hover clean up can occur at that time as well, but we can get UX feedback as I've got some design concerns overall and prefer to get luca__ and company looking at it | 15:33 |
| gary_poster | cool | 15:33 |
| luca__ | rick_h_: gary_poster oh no, rick has design concerns! run for the hills :P | 15:34 |
| gary_poster | :-) | 15:34 |
| hatch | haha | 15:34 |
| rick_h_ | luca__: :P comingsoon is loading | 15:34 |
| rick_h_ | expect a ping any minute now :P | 15:34 |
| luca__ | rick_h_: rofl | 15:34 |
| hatch | gary_poster: the biggest issue I had was the url routing stuff should be handled via the routing code | 15:34 |
| rick_h_ | the onboarding masking is a bit nuts | 15:34 |
| hatch | but then rick_h_ infrmed me there was discussion around that already | 15:35 |
| rick_h_ | hatch: yea, and that'll go away entirely when it's in the browser | 15:35 |
| rick_h_ | it'll be able top just check the viewState.viewmode | 15:35 |
| hatch | modals can die the most painful way possible | 15:35 |
| gary_poster | heh | 15:35 |
| hatch | the WORST is when people put videos in modals | 15:35 |
| hatch | 'yes, I totally want to look at a black window while this video is buffering instead of reading your page content' | 15:36 |
| gary_poster | tar --exclude affects the sources of symlink files. weird | 15:37 |
| hatch | man I just sound bitter this morning | 15:37 |
| gary_poster | so if you have build-prod/juju-ui/assets/source/api as a symlink...oh wait a sec... | 15:38 |
| hatch | is the 'Add to my canvas' text shifted to the left for everyone else too? I'm having some caching issues so just want to make sure before I file a bug | 15:39 |
| gary_poster | hatch, charm? looks ok on comingsoon to me | 15:40 |
| hatch | hmm ok I'll screenshot it | 15:40 |
| gary_poster | bundle looks fine too | 15:40 |
| hatch | gary_poster: https://www.evernote.com/shard/s219/sh/75bfc4a3-83ae-4357-8803-903590073a59/f27d7423845e6b325848d3880255f296/res/f32bf30f-e9a9-47db-acd4-dfa4ea52e33a/skitch.png | 15:41 |
| gary_poster | that's where I see it hatch. wrong? | 15:42 |
| hatch | shouldn't the text be centered in the box? | 15:42 |
| gary_poster | oh! | 15:42 |
| gary_poster | hatch, that tells you how fabulous my eye is | 15:42 |
| gary_poster | yeah hatch | 15:42 |
| gary_poster | I bet the issue has something to do with the similar bundle button | 15:43 |
| gary_poster | which is centered | 15:43 |
| * bac wonders if that is the WORST. #firstworldproblems | 15:43 | |
| gary_poster | :-) | 15:43 |
| hatch | haha ok np, chrome has just been crashing for me a lot this morning and refuses to clear the cache so I wasn't sure if it was just me :) | 15:43 |
| hatch | bac: no, modal videos are clearly worse :P | 15:43 |
| bac | hatch: ok, yeah i see your point. | 15:44 |
| hatch | darn I missed http://www.kickstarter.com/projects/556341540/pressy-the-almighty-android-button while I was away | 15:45 |
| hatch | such a great idea! | 15:45 |
| hatch | rick_h_: ^ figured you'd like that | 15:47 |
| rick_h_ | hatch: yea, almost got into that | 15:47 |
| * Makyo pointedly goes to make coffee. | 15:49 | |
| hatch | rick_h_: I'm assuming that this tabview hash code is handled separately somehow? It should be handled by the tabview code by default but that doesn't appear to be the case on the bundle tabview even though it's using identical code | 15:49 |
| gary_poster | lol | 15:50 |
| hatch | jujugui call in 10 | 15:50 |
| * hatch waited until Makyo had left | 15:50 | |
| gary_poster | nicely done, all | 15:50 |
| * Makyo claps for hatch "Well done! You beat me to it!" | 15:51 | |
| bac | "pressy comes with fourteen click combinations" -- that does sound intuitive! i can rarely get double-click-to-skip song to work on my teeny tiny headphone button | 15:51 |
| bac | ugh, charmworld login tests fail if you lose network connectivity. | 15:53 |
| rick_h_ | hatch: the view has to handle an activeTab attr and get that from the browser.js state controller | 15:53 |
| rick_h_ | hatch: I didn't look into why it didn't work since I'd think it'd be shared. I wonder if the bundle stuff just isn't setting the activeTab in browser.js like for charm.js | 15:54 |
| rick_h_ | hatch: and then there's a line that takes the activeTab ATTR and forces the tabview widget to go to that tab | 15:54 |
| hatch | rick_h_: ahhh I see that now | 15:54 |
| hatch | I missed it because of the name difference | 15:54 |
| hatch | cool thanks | 15:54 |
| rick_h_ | hatch: coolio | 15:55 |
| hatch | yup trivial fix, I'll clean it up so it's shared | 15:55 |
| rick_h_ | hatch: awesome, thanks | 15:55 |
| hatch | do we know why it's not working by default? | 15:55 |
| hatch | like why the tabview code isn't reacting to the hash in the url? | 15:55 |
| hatch | probably knew at one point | 15:56 |
| rick_h_ | hatch: yea, trying to recall. The issue was that we ignore parts of the tabview because if it routes it causes issues | 15:56 |
| rick_h_ | changing the url, cauing a dispatch, wants to redraw, something | 15:56 |
| hatch | I'll accept that | 15:56 |
| hatch | lets blame double dispatch | 15:57 |
| rick_h_ | lol | 15:57 |
| rick_h_ | I feel like that 'Blame Candada!' song from south park | 15:57 |
| rick_h_ | "blame double dispatch! blame double dispatch!" | 15:58 |
| hatch | lol | 15:58 |
| gary_poster | jujugui call in 2 | 15:58 |
| jcsackett | rick_h_: technically isn't the charm model the most used code anywhere? | 16:01 |
| jcsackett | s/used/reused/ | 16:01 |
| rick_h_ | jcsackett: it' | 16:01 |
| rick_h_ | maybe I guess | 16:01 |
| hatch | jcsackett: I don't know what you just did, but your text changed :) | 16:01 |
| hatch | used changed to reused | 16:01 |
| jcsackett | hatch: i sent a substitute command, a la vim. some clients render it, and anyone using a client that doesn't probably knows what it means. | 16:02 |
| hatch | oh cool | 16:02 |
| hatch | /s/used/reused ? | 16:02 |
| * jcsackett nods | 16:03 | |
| jcsackett | less the leading slash. | 16:03 |
| hatch | coolio | 16:03 |
| hatch | s/coolio/foobar | 16:03 |
| hatch | doesn't look like I can do it | 16:03 |
| hatch | haha | 16:03 |
| jcsackett | ...that's odd. | 16:03 |
| jcsackett | if it worked for what i sent, it should work for what you send. | 16:03 |
| jcsackett | it's not part of IRC--it's just a thing some clients do. | 16:03 |
| jcsackett | oh, ending slash. | 16:04 |
| jcsackett | like, s/coolio/foobar/ | 16:04 |
| hatch | hmm | 16:04 |
| hatch | s/hmm/fooo/ | 16:04 |
| hatch | oh nice | 16:04 |
| hatch | :) | 16:04 |
| hatch | thanks | 16:04 |
| hatch | haha | 16:04 |
| jcsackett | rick_h_: mind you, i'm happy to take the reward for most reused code. :-) | 16:05 |
| hatch | gary_poster: in Ubuntu I get the same results as you - so there is something not quite right there | 16:15 |
| gary_poster | hatch, :-/ ok cool that means good stuff to fix :-) | 16:15 |
| rick_h_ | hatch: added two cards for the two things brought up in call | 16:16 |
| hatch | right - so was there discussion on a release date? I'm assuming that it was pushed? | 16:16 |
| rick_h_ | hatch: the bundle button and mystery charm token event helper | 16:16 |
| hatch | thanks | 16:16 |
| Makyo | Housemate wandered upstairs in his boxers with headphones in, I figured I'd spare you all. :P | 16:17 |
| gary_poster | :-) | 16:17 |
| hatch | haha - oh that would have been funny | 16:18 |
| gary_poster | hatch, we are making non-bundle release today. we will be able to demo bundle story 1 (display) & story 2 (deploy); we will have most of story 3 (stability) and maybe all of it. We will arrange with Jorge and Antonio to pre-populate approved bundles in store before we release. | 16:19 |
| hatch | coolio | 16:20 |
| gary_poster | hatch, for quickstart, we will have story 1 (equivalent to juju bootstrap --with-gui) in a PPA for testing, and maybe story 2 ready (adds ability to deploy bundles). story 3 (we handhold through init) we can maybe sneak in next week | 16:20 |
| gary_poster | that's 'bout it | 16:20 |
| hatch | is the quickstart stuff a separate ppa? | 16:21 |
| gary_poster | hatch yes will be for now | 16:21 |
| hatch | I noticed that it was python not go | 16:21 |
| hatch | ahh ok gotcha | 16:21 |
| gary_poster | frankban I will call project juju-quickstart? | 16:22 |
| gary_poster | on Launchpad | 16:22 |
| frankban | gary_poster: sounds good | 16:22 |
| hatch | I had lunch with a guy in Vanc who's using Juju in their startup | 16:26 |
| hatch | using it to deploy their app of course but also using it in CI like we do | 16:26 |
| gary_poster | her marcoceppi. we are making a juju-quickstart plugin. should we put it in https://launchpad.net/juju-plugins or make a new project? | 16:27 |
| gary_poster | cool, hatch! | 16:27 |
| hatch | yeah it was pretty cool talking to someone who's actually using it in production | 16:28 |
| hatch | http://www.picatic.com/ is the company | 16:28 |
| marcoceppi | gary_poster: you're welcome to put it in juju-plugins or start your own project. I haven't gotten around to making packaging for juju-plugins, but that could be the fire under me rear to do so | 16:28 |
| marcoceppi | gary_poster: the idea was to collect a lot of small plugins and put them there, to simplify packaging, etc. deployer (arguably a juju plugin), charm-tools, etc all have their own project. There's not forced convetion one way or the other | 16:30 |
| gary_poster | cool thanks marcoceppi, makes sense. wdyt frankban ? we have our own makefile stuff, so I'm thinking we should have our own project because that will be easier, at least for now. agree? | 16:30 |
| marcoceppi | Also, I've come to talk about "Providers" on the charm info page https://jujucharms.com/precise/wordpress I've gotten some reports of confusion from users assuming that those providers listed are the ONLY supported providers for the charm | 16:31 |
| frankban | gary_poster: agreed | 16:31 |
| frankban | gary_poster: for now a separate project is better imho | 16:32 |
| gary_poster | cool thanks frankban . https://launchpad.net/juju-quickstart | 16:37 |
| frankban | thanks gary_poster | 16:38 |
| gary_poster | marcoceppi, I just finally parsed what you were saying, sorry. ok... | 16:38 |
| gary_poster | You mean AWS/EC2 and LXc | 16:38 |
| marcoceppi | gary_poster: yes! Sorry, always feel free to smack me for clarification :) | 16:39 |
| marcoceppi | gary_poster: http://irclogs.ubuntu.com/2013/10/17/%23juju.html#t14:09 from earlier today, and jamespage had similar experience during a talk | 16:40 |
| gary_poster | marcoceppi, :-) . OK, I can understand that confusion. Would you mind filing a bug? I will if you need me to. If you have a suggestion for alternate wording, we'd really appreciate it. | 16:40 |
| frankban | gary_poster: pushed trunk to the new project | 16:40 |
| marcoceppi | gary_poster: I'll gladly open a bug, just wanted to make sure it wouldnt' be in vain if you guys had something else planned | 16:40 |
| gary_poster | frankban, could you push it to ~juju-gui? | 16:41 |
| gary_poster | marcoceppi, no, this would be great to hear | 16:41 |
| gary_poster | thank you | 16:41 |
| frankban | gary_poster: lp:~juju-gui/juju-quickstart? | 16:42 |
| gary_poster | frankban, lp:~juju-gui/juju-quickstart/trunk , yeah | 16:43 |
| frankban | gary_poster: done | 16:44 |
| frankban | gary_poster: so lp:juju-quickstart will be lp:~juju-gui/juju-quickstart/trunk, correct? | 16:44 |
| frankban | gary_poster: the real question is, what shoudl I put into .lbox? | 16:45 |
| gary_poster | frankban, yes, lp:juju-quickstart is that | 16:45 |
| gary_poster | frankban, heh. make check? | 16:45 |
| frankban | gary_poster: make check is already in .lbox.check | 16:46 |
| gary_poster | oh | 16:46 |
| gary_poster | right, .lbox | 16:46 |
| frankban | .lbox now contains "propose -cr -for lp:juju-quickstart" | 16:47 |
| gary_poster | frankban, I think that is right | 16:47 |
| frankban | gary_poster: hum... perhaps we have to change the trunk series in https://code.launchpad.net/juju-quickstart | 16:47 |
| marcoceppi | Do you guys have the concept of tooltips in the "store" portion of the GUI? | 16:48 |
| gary_poster | marcoceppi, no | 16:49 |
| gary_poster | frankban, looks right already to me | 16:49 |
| frankban | gary_poster: yes indeed, thank you | 16:50 |
| gary_poster | welcome :-) | 16:50 |
| marcoceppi | gary_poster: https://bugs.launchpad.net/juju-gui/+bug/1241075 | 16:54 |
| _mup_ | Bug #1241075: Wording of "Providers" confusing on charm information page <juju-gui:New> <https://launchpad.net/bugs/1241075> | 16:54 |
| marcoceppi | thanks again! | 16:56 |
| gary_poster | marcoceppi, I like your solution. Note that we explicitly call OpenStack "HP Cloud" because of concerns from Antonio and others about a lack of portability across OpenStack providers. I don't think that affects your solution though. I'll ask Luca to look at this. | 16:57 |
| frankban | guihelp: quickstart branch ready for 2 review 1 qa. could anyone please take a look? thanks! | 16:59 |
| Makyo | frankban, on it. | 16:59 |
| frankban | Makyo: ty | 16:59 |
| gary_poster | I'll take the other | 17:00 |
| marcoceppi | gary_poster: this is fine, I think including that in the caveat would be fine too, "OpenStack is tested against HP Cloud's public OpenStack service" or whatever | 17:00 |
| gary_poster | cool marcoceppi | 17:00 |
| hatch | jujugui looking for a quick review/qa https://codereview.appspot.com/14702045/ | 17:03 |
| Makyo | hatch, on it. | 17:03 |
| hatch | thanks | 17:03 |
| Makyo | *lboxing-light* | 17:03 |
| hatch | what is a '360 feedback' ? | 17:05 |
| rick_h_ | hatch: welcoem to the party! | 17:05 |
| hatch | rick_h_: lol I'm just doing the survey right now | 17:05 |
| hatch | I'm going to guess I don't do 360 feedback since I have no idea what it is? | 17:06 |
| Makyo | hatch, code LGTM, qa in a sec. | 17:06 |
| gary_poster | hatch, it is our yearly review | 17:07 |
| gary_poster | hatch it is "360" because you review manager, peers, and reports (if you have any) | 17:08 |
| hatch | ohh ok | 17:08 |
| Makyo | jujugui review+qa please: https://codereview.appspot.com/14771044 Please QA in a real environment as well as sandbox, incl. bundles. | 17:08 |
| hatch | Makyo: on it | 17:09 |
| hatch | it'll be a bit though - I need to fire up the juju-core box :) | 17:09 |
| frankban | gary_poster: reordered the quickstart cards: hight priority for minimum story one (normal for story one nice to have) | 17:14 |
| gary_poster | frankban, looks just right | 17:14 |
| frankban | gary_poster: cool, thanks and EOcrazyD. have a great evening! | 17:15 |
| gary_poster | frankban, :-) you too | 17:15 |
| gary_poster | thank you | 17:15 |
| hatch | Makyo: such a small diff for such a large issue :D | 17:21 |
| Makyo | hatch, I spent alittle too long trying to figure out why the env wouldn't work if I had a breakpoint in there, sorry. | 17:22 |
| Makyo | hatch, side effect from the recent refactor, though, which got the rest of the issues. Overall win,just this initial centering thing missing. | 17:22 |
| hatch | oh no that's fine - it just seems that every time we run into a canvas issue it's a lot of work to find the issue then a small fix :) I wonder if there is a way we can simplify it? | 17:23 |
| hatch | I really have no idea - you're the expert in this area :) | 17:23 |
| hatch | Makyo: so how should I qa this on a real env? | 17:24 |
| hatch | it's just pulling down your branch now | 17:24 |
| Makyo | Deploy a service, drag it somewhere, and refresh, it should be centered. | 17:25 |
| hatch | cool | 17:25 |
| Makyo | The issue was that if you refreshed, it'd be off the edge of the viewport. | 17:25 |
| hatch | ohh | 17:25 |
| hatch | yeah that's not ideal | 17:25 |
| gary_poster | jujugui, smallest review ever: https://codereview.appspot.com/14771045 . To qa, go to https://ec2-54-234-204-211.compute-1.amazonaws.com/ and verify in the inspector that sourcemaps are working for you. | 17:30 |
| hatch | on it | 17:30 |
| gary_poster | thank you | 17:31 |
| hatch | dunzo! | 17:32 |
| gary_poster | :-) | 17:35 |
| hatch | Makyo: sorry I'm having an issue deploying the GUI on core | 17:37 |
| hatch | it appears it can't install the python depts | 17:39 |
| hatch | anyone familiar with this issue or possibly a one off? | 17:39 |
| Makyo | Not seen that before | 17:40 |
| hatch | ok will kick it off again | 17:40 |
| hatch | when I run `juju resolved -r juju-gui/0` the unit is still in error state | 17:41 |
| hatch | is this a juju bug? | 17:42 |
| hatch | er | 17:42 |
| hatch | known juju bug | 17:42 |
| hatch | the -r is retry | 17:42 |
| gary_poster | hatch, is this LXC on saucy? | 17:44 |
| hatch | LXC on..... | 17:45 |
| hatch | precise | 17:45 |
| gary_poster | hatch, LXC is broken right now with that exact symptom. The apt-get is failing, right? | 17:45 |
| hatch | right | 17:45 |
| gary_poster | yeah, hatch, LXC is hosed. panic in the streets, etc. :-/ | 17:45 |
| hatch | aww darn | 17:46 |
| gary_poster | hatch, ec2 or etc. to the rescue | 17:46 |
| hatch | ok Makyo looks like I'll need to ec2 this, sorry for the delay | 17:46 |
| hatch | gary_poster: thanks for confirming | 17:46 |
| Makyo | hatch, nbd | 17:46 |
| gary_poster | welcome | 17:46 |
| * gary_poster goes for lunch | 17:46 | |
| gary_poster | goes downstairs, that is | 17:46 |
| * hatch also takes lunch | 17:50 | |
| * Makyo lunches too. Peer pressure. | 17:59 | |
| hatch | just took the dog to get his hair cut.....so he decided to throw up on the truck seat.....aweeeeesommmeee | 18:15 |
| rick_h_ | yay hatch | 18:18 |
| rick_h_ | welcome back! | 18:18 |
| rick_h_ | :P | 18:18 |
| hatch | I still haven't eaten | 18:18 |
| hatch | so I'm not actually here | 18:18 |
| * hatch ghost | 18:18 | |
| hatch | so glad I got my terminal colours all fixed on my laptop so that now I can actually use it without seizing | 18:22 |
| rick_h_ | bac: ping, got a sec to walk through a quick sanity check ? | 18:39 |
| gary_poster | Makyo, how goes landing your branch? Do you need another review? Time is growing short to make a non-Friday release | 18:53 |
| Makyo | Just got back, will land asap! | 18:54 |
| gary_poster | cool | 18:54 |
| Makyo | Well once hatch QAs, unless someone else wants to real quick. | 18:55 |
| hatch | Makyo: sorry just trying to get ec2 to spin up | 18:55 |
| hatch | maybe someone else wants to take the QA? | 18:55 |
| hatch | sorry :/ | 18:55 |
| rick_h_ | need me to run QA? What are we qa'ing again? | 18:57 |
| rick_h_ | Makyo: ^ | 18:57 |
| Makyo | https://codereview.appspot.com/14771044/ lp:~makyo/juju-gui/center - QA against a real env with positioned services; refreshing the page should center the services. | 18:58 |
| rick_h_ | Makyo: rgr | 18:59 |
| Makyo | Would also like to do a quick make-sure that sandbox still works. Will keep trying to break it, as it is. | 18:59 |
| hatch | rick_h_: cannot be LXC though, because it's broken | 19:00 |
| rick_h_ | hatch: I'm not on saucy :P | 19:00 |
| rick_h_ | but ssssh , don't tell anyone | 19:00 |
| hatch | I'm on precise and there is the same issue | 19:00 |
| Makyo | Works for me in precise :P | 19:00 |
| hatch | well my 'juju-core' machine is precise | 19:00 |
| hatch | Makyo: really? | 19:01 |
| hatch | hmm | 19:01 |
| rick_h_ | agent-state-info: 'hook failed: "install"' | 19:01 |
| hatch | what version of juju? | 19:01 |
| Makyo | hatch, yeah, works in quantal. | 19:01 |
| rick_h_ | :( | 19:01 |
| hatch | rick_h_: yeah see | 19:01 |
| hatch | :) | 19:01 |
| hatch | todaso | 19:01 |
| Makyo | Sorry, raring, derp. | 19:01 |
| rick_h_ | well then nvm, carry on hatch on ec2 | 19:01 |
| Makyo | 1.14.1-raring | 19:01 |
| hatch | rick_h_: I'm having issues getting ec2 to spin up | 19:01 |
| hatch | Makyo: 1.16 here | 19:01 |
| Makyo | Maaaybe i'll stick with this version for a bit loner. | 19:02 |
| Makyo | longer | 19:02 |
| hatch | haha yeah definitely | 19:02 |
| hatch | arg so frustrating | 19:03 |
| hatch | juju won't bootstrap, says it already IS - but then won't do a `status` and there are no instances on ec2 spun up | 19:03 |
| rick_h_ | juju switch ? | 19:03 |
| rick_h_ | hatch: are you looking at local env vs remote ec2 env? | 19:04 |
| hatch | rick_h_: have the default set to my ec2 version | 19:04 |
| hatch | `juju switch` shows that environment | 19:04 |
| rick_h_ | hatch: right, but have you used juju switch to check what env is set? | 19:04 |
| rick_h_ | ah ok | 19:04 |
| rick_h_ | hatch: and if you go to your aws console no machine is coming up? | 19:05 |
| hatch | nope nothing in there....if I `sudo juju status` it hangs hah | 19:05 |
| hatch | maybe I'll reboot | 19:05 |
| hatch | oh wait | 19:05 |
| hatch | my laptop has quantal | 19:05 |
| hatch | maybe that's not supported anylonger? | 19:05 |
| hatch | oh no I'm still on 1.14.1-quantal-amd64 | 19:06 |
| hatch | hmm | 19:06 |
| hatch | I'll try rebooting it | 19:06 |
| hatch | no luck...I wonder if there is an issue connecting | 19:08 |
| hatch | to the #juju channel | 19:08 |
| * hatch said that like batman saying "to the batcave" | 19:09 | |
| gary_poster | hatch try juju destroy-environment, I was told in similar circumstances | 19:09 |
| hatch | hmm it appears to be hanging | 19:09 |
| hatch | oh there it goes | 19:10 |
| gary_poster | jcastro, I'm marking myself in summit as attending various meetings, even though I arguably should be required on the ones I created at the very least, because I just can't be bothered. :-P Good enough? | 19:10 |
| hatch | gary_poster: looks like that has solved the issue thanks - so it's "environment flag" must be some config file that was never cleaned up then | 19:11 |
| gary_poster | yeah I dunno | 19:11 |
| gary_poster | glad it worked :-) | 19:11 |
| hatch | now, we wait | 19:12 |
| hatch | I hope? | 19:12 |
| hatch | haha | 19:12 |
| hatch | still doesn't show any instances spinning up | 19:12 |
| hatch | there it goes | 19:14 |
| hatch | yay! | 19:14 |
| hatch | I'd really love to install 13.10 on this thing :/ | 19:15 |
| hatch | Makyo: so how is the VM on the 'air' treating you? | 19:15 |
| Makyo | hatch, I've actually done little with it. I'll poke at it and make sure it's workable before the trip. | 19:16 |
| Makyo | Can always just bring both again, I guess. | 19:16 |
| hatch | haha noooo | 19:16 |
| hatch | I figured you might have converted to working on it :) | 19:17 |
| Makyo | There's some aspects of workflow that I haven't gotten to fixing yet. | 19:19 |
| Makyo | I use occasional mouse integration with vim, and that doesn't work. Keybindings for home/end/pgup/pgdn are wrong for me. | 19:20 |
| Makyo | Did finally get bzr working on metal, though not lbox. | 19:20 |
| Makyo | (which is fine) | 19:21 |
| hatch | Makyo: this might help http://fromanegg.com/post/45733384142/nfs-between-ubuntu-vm-and-osx-host | 19:21 |
| hatch | also if you find any errors/additions plz let me know :) | 19:21 |
| Makyo | Oh, I've got everything set up in virtualbox with raring server. Bit different :o) | 19:22 |
| Makyo | Still the NFS solution, though. | 19:23 |
| Makyo | Slightly tweaked. | 19:23 |
| hatch | Makyo: so when you do things like bzr do you need to do the 'exec ssh-agent bash' | 19:25 |
| hatch | then 'ssh-add <key>' | 19:26 |
| hatch | I can't seem to find a workaround to that irritatnt | 19:26 |
| Makyo | No, though like I said, I haven't done too much. | 19:26 |
| Makyo | bzr locally seems to work fine, though. | 19:26 |
| Makyo | As does at read actions in vm. | 19:27 |
| hatch | you're running it on osx? | 19:27 |
| hatch | bzr I mean | 19:27 |
| Makyo | Yeah, from brew, though I had to rejigger PYTHON_PATH | 19:27 |
| hatch | we'll have to chat in SF about it, sounds like you're doing things a little different than I | 19:27 |
| hatch | but yours might require less jiggerin | 19:28 |
| hatch | and speaking of jiggerin, I cannot get this ec2 to work | 19:28 |
| hatch | I got the bootstrap node but it just hangs when I try and deploy anything | 19:28 |
| hatch | jujugui anyone else available to QA Makyo's branch on ec2? | 19:29 |
| gary_poster | I'll do it | 19:29 |
| hatch | thanks - tonight I'll flush juju and the keys and whatnot and set it back up | 19:29 |
| hatch | hopefully something just got corrupted or whatever | 19:29 |
| gary_poster | hatch, Makyo, something we could do to productively get people into d3 in sprint might be to use the new error info to split up inspector categories by error type. If one non-d3 person pairs with Matt or Jeff on that then that might be productive. | 19:37 |
| hatch | actually on the same line of that I wouldn't mind sitting down with matt to see if there is a better way to do that | 19:37 |
| gary_poster | It would be good to have a list of Things We Want to Talk About so that when we have some spare moments we can go off and have a pre-considered list of things to do. | 19:37 |
| hatch | it's pretty hard to follow as-is | 19:37 |
| gary_poster | cool | 19:37 |
| hatch | it may be that that's how it is | 19:38 |
| Makyo | Sure. It can be our fourth refactor. | 19:38 |
| Makyo | </bitter> | 19:38 |
| hatch | rofl | 19:38 |
| hatch | hey we could switch to canvas | 19:38 |
| * hatch runs | 19:38 | |
| Makyo | I'd rather work on docs, unless someone can convince me that we have the time and resources to massively refactor yet again. | 19:39 |
| gary_poster | Makyo, he said *of the inspector*. That's a whole new field for refactoring! | 19:39 |
| Makyo | Oh! | 19:39 |
| gary_poster | Makyo, but seriously, he's talking 150 lines, not the env view | 19:39 |
| hatch | haha yeah | 19:39 |
| Makyo | I was thinking the env view, sorry. I missed that :( | 19:39 |
| hatch | the data enter/exit stuff is very confusing | 19:39 |
| hatch | is what I mean | 19:39 |
| Makyo | Ah, yeah. | 19:39 |
| Makyo | Welcome to d3 :/ | 19:39 |
| Makyo | Sorry about that, totally misread. | 19:40 |
| hatch | :) sok | 19:42 |
| gary_poster | I wonder if simply dividing it up into sub functions would make it easier to read | 19:42 |
| gary_poster | if the divisions were conceptual | 19:42 |
| gary_poster | update in particular I mean | 19:42 |
| gary_poster | it always seems to do so much | 19:42 |
| hatch | gary_poster: yeah that's what I was thinking too | 19:43 |
| gary_poster | Makyo qa ok. thank you! ship it. | 19:45 |
| * gary_poster has to go get boys from school. biab | 19:45 | |
| Makyo | *lboxing-light* | 19:46 |
| hatch | hehe | 19:52 |
| Makyo | I give up. lboxing still broken in lw checkouts with that same 404 if we run test-debug test-prod in the order we do. | 20:00 |
| Makyo | Thankfully it still works from the branch folder. | 20:00 |
| Makyo | If lbox had shins, I would kick them. | 20:01 |
| hatch | Makyo: I think I do lightweight checkouts and it works good here | 20:02 |
| hatch | bzr init the top folder then check out trunk and branch within that upper branch | 20:02 |
| Makyo | Propose works 50% of the time, submit always fails. | 20:02 |
| Makyo | That's what I have. | 20:02 |
| hatch | yeah works 100% of the time here | 20:02 |
| hatch | phantom crashes probably 50% of the time if I don't do it in lbox | 20:03 |
| hatch | heh | 20:03 |
| gary_poster | Makyo, if you need me to do anything (like land), ping me. Otherwise I should take a break before evening meetings | 20:05 |
| Makyo | gary_poster, landing now. What version did we decide on? 0.11? | 20:05 |
| gary_poster | yes Makyo | 20:05 |
| Makyo | \o/ | 20:05 |
| Makyo | Well, happy to see lbox also fail in the branch directory. | 20:06 |
| hatch | Makyo: busted battery, inability to lbox, <third problem here> - time to throw that computer out | 20:07 |
| Makyo | too heavy | 20:07 |
| hatch | lol | 20:07 |
| hatch | drag it out? | 20:07 |
| * Makyo sets it gently in the garbage. Still lboxing. | 20:07 | |
| hatch | Makyo: so every time I import benji's bundle using trunk it positions them differently in the canvas, I'm going to assume this is expected because it doesn't have xy annotations - but just want to confirm | 20:14 |
| hatch | and by import I mean drag and drop | 20:14 |
| Makyo | hatch, yeah, pretty sure. It's running an automated pack-layout on it, and there are a few variables that go into how that winds up working out. | 20:15 |
| hatch | sounds good | 20:15 |
| Makyo | FINALLY | 20:32 |
| hatch | heh ubuntu.com is down | 20:37 |
| hatch | woops | 20:37 |
| hatch | bcsaller: you kickin around with us this week still? | 20:38 |
| bcsaller | hatch: I'm around, what do you need? | 20:39 |
| hatch | so I'm tracking down an issue where if you click 'deploy bundle' button the canvas stops reacting to interactions (drag/zoom etc) | 20:39 |
| hatch | it looks like the button click is sending additional information to the deployer | 20:39 |
| hatch | but the 'required' data is in the proper place | 20:40 |
| hatch | so I was wondering if the fakebackend deployer code could be causing this issue? | 20:40 |
| hatch | figured I'd check before parsing the ingestDeployer :) | 20:40 |
| bcsaller | hatch: interacting with the canvas? no | 20:40 |
| bcsaller | ingest return data that can be acted on using fakebackend api calls | 20:41 |
| bcsaller | returns | 20:41 |
| hatch | bcsaller: actually I just figured it out haha | 20:42 |
| hatch | sorry | 20:42 |
| bcsaller | np | 20:42 |
| hatch | all those errors on the bundle topology cause the main topology to fall over | 20:42 |
| bcsaller | they shouldn't be related at all, that would be a serious issue | 20:44 |
| bcsaller | unconnected structures in memory | 20:44 |
| hatch | yeah I'll need to export a proper bundle | 20:46 |
| hatch | but it does look like that's the issue | 20:46 |
| bcsaller | is something using #id where is should be a class off the topology container? thats could be a conflict point | 20:46 |
| bcsaller | pan/zoom might do that with the +/- buttons | 20:46 |
| hatch | yeah I'm looking into that right now | 20:47 |
| hatch | yeah I think we have an odd internal issue because creating the bundle topology instance causes it to break, it doesn't even need to be rendered | 20:52 |
| hatch | oh well....investigation time@ | 20:52 |
| hatch | ! | 20:52 |
| hatch | oh this is interesting... | 20:54 |
| bcsaller | hatch: if you need to talk about it let me know | 21:04 |
| hatch | bcsaller: will do, I've tracked it down to the yui property of the events property in PanZoomModule | 21:05 |
| hatch | going to have to trace it down to how that's mixed in | 21:06 |
| bcsaller | oh, you think its a shared class level var rather than instance? hmm. I'd make sure that its not a #id thing first though | 21:06 |
| bcsaller | as that seems more likely | 21:06 |
| hatch | it's the panToPoint method actually | 21:08 |
| hatch | (sorry I'm just chatting while I track it down) :) | 21:08 |
| Makyo | Have to walk dogs so I can finish the release without them bugging me. | 21:19 |
| hatch | interesting 'zoom' in d3 can mean so much more | 21:44 |
| huwshimi | Morning | 22:02 |
| bac | gary_poster: my branch is proposed at https://codereview.appspot.com/14811043. i leave very early tomorrow but will try to check in from JFK. | 22:02 |
| bac | hi huwshimi | 22:02 |
| * bac walk | 22:02 | |
| hatch | hey huwshimi | 22:06 |
| * hatch can't figure out where d3 'yui' events are bound | 22:17 | |
| huwshimi | hatch: d3.events? | 22:18 |
| hatch | huwshimi: well I'm trying to figure out why the 'yui' property events in the PanZoomModule aren't being bound | 22:18 |
| hatch | or....rebound | 22:18 |
| huwshimi | oh | 22:19 |
| hatch | the comments say it's beign listened to with Y.on | 22:19 |
| hatch | but not anywhere I would expect it to be? | 22:19 |
| huwshimi | hatch: Could it be to do with the 'events': 'scene'? | 22:20 |
| Makyo | hatch, assets/javascript/d3-somethignsomething | 22:20 |
| Makyo | d3--component thingy? | 22:21 |
| Makyo | That one. | 22:21 |
| hatch | Makyo: yeah I'm in d3-components.js | 22:21 |
| hatch | there is no .on( for the yui events | 22:21 |
| huwshimi | hatch: There are some docs in docs/d3-component-framework.rst that cover d3 events | 22:22 |
| huwshimi | hatch: Not sure if any of that is useful | 22:22 |
| hatch | cool I'll cehck that out | 22:22 |
| Makyo | line249 | 22:22 |
| bcsaller | hatch: when you make the bundle view, check the 'interactive' flag | 22:22 |
| Makyo | hatch, ^^^ | 22:23 |
| hatch | it's set to true | 22:23 |
| Makyo | Specifically line 274 | 22:23 |
| bcsaller | then it should bind them | 22:23 |
| huwshimi | rick_h_: Thanks for the reviews, adding the cleanup for the tokens and landing my branches :) | 22:23 |
| hatch | oh jeebus | 22:24 |
| rick_h_ | huwshimi: np, I'll get you later in SFO for test-skipping :P | 22:24 |
| hatch | now I see it Makyo | 22:24 |
| hatch | thanks :/ | 22:24 |
| huwshimi | rick_h_: Oh dear, that was unintentional :( | 22:25 |
| hatch | lol | 22:25 |
| huwshimi | rick_h_: I very rarely add functions, only modify them, so it escaped my mind :( | 22:25 |
| hatch | huwshimi: did you see the video on the new additions to sass? | 22:26 |
| huwshimi | hatch: I did not | 22:26 |
| hatch | huwshimi: whenever you have some time to blow http://www.youtube.com/watch?v=-ZJeOJGazgE | 22:27 |
| hatch | soime pretty cool stuff there | 22:27 |
| huwshimi | hatch: Great, thanks. | 22:28 |
| * hatch takes bundle initializer and staples it to the top of the class | 22:29 | |
| hatch | :P | 22:29 |
| rick_h_ | hatch: alphabetical :P by type of functoin | 22:29 |
| rick_h_ | _private, then public | 22:30 |
| rick_h_ | hatch: all others fail becaues I now have to use search to find them | 22:30 |
| hatch | initializer and destructor are private | 22:30 |
| hatch | YUI for some reason doesn't _ them haha | 22:30 |
| hatch | honestly though from my time in C++ land I always put inits at the top and destructors at the bottom | 22:31 |
| hatch | maybe it's a convention? no idea, it's been 4 ever | 22:31 |
| hatch | haha | 22:31 |
| rick_h_ | hatch: stop doing it wrong | 22:31 |
| hatch | wouldn't you put public at the top? | 22:31 |
| rick_h_ | hatch: no | 22:31 |
| hatch | why not? | 22:32 |
| hatch | those are the methods people 'can' use | 22:32 |
| hatch | so....they should be easier to find? | 22:32 |
| hatch | honestly I use cmd+r to bounce to functions so I don't really care | 22:33 |
| hatch | :) | 22:33 |
| rick_h_ | just saying how it is | 22:33 |
| hatch | maybe in rick land!!! | 22:33 |
| gary_poster | Makyo hatch starting if you want to join | 22:33 |
| Makyo | gary_poster, would rather focus on release if that's okay | 22:34 |
| gary_poster | Makyo, +1 :-) | 22:34 |
| bac | rick_h_: would you review https://codereview.appspot.com/14811043 in the morning? | 22:38 |
| rick_h_ | bac: will do | 22:39 |
| bac | thanks | 22:40 |
| bac | oh, yay, the water is out | 22:40 |
| hatch | bcsaller: is there somewhere which handles detaching the topology events? | 22:50 |
| bcsaller | hatch: Not sure, it was written for a persistent singleton view so that path might not be well tested, but each module removed from the topo will unbind | 22:52 |
| bcsaller | hatch: just not sure there is any automatic triggering of that, but a destroy method looping the modules and calling removeModule or whatever would do that | 22:53 |
| hatch | bcsaller: hmm ok I'm trying to find out why creating a new instance of the topology causes the old handlers to get detached | 22:57 |
| hatch | but it looks like i'll probably be on that in the am | 22:58 |
| bcsaller | hatch: if you get stuck let me know, I might have some ideas (though I didn't see that myself) | 22:58 |
| hatch | bcsaller: if you want to see the issue...put a debugger in panzoom.js<zoomHandler> and put a debugger in topology.js<computeScales> in the "on('zoom')" callback - you'll notice that after you open the bundle details page, click deploy, the zoomHandler never gets called | 23:12 |
| hatch | but I'm not going to be working on it until the am so only if you were curious | 23:13 |
| bcsaller | hatch: just looking through addModule/bind to see if there is somewhere we need to copy a datastructure | 23:16 |
| bcsaller | hatch: I might see it | 23:16 |
| bcsaller | d3-components.js:300 | 23:17 |
| bcsaller | subscriptions is stored in events which I'm guessing is a shared reference to the module level decl | 23:17 |
| bcsaller | so if we copy events in addModule it goes away, or move subs elsewhere | 23:17 |
| bcsaller | because the subscription tracking is being shared | 23:18 |
| bcsaller | d3-components:133 modEvents = Y.mix(module.events); | 23:18 |
| bcsaller | should fix it I think | 23:19 |
| hatch | bcsaller: cool that's also what I was going to experiment with in the am | 23:20 |
| hatch | rick_h_: will you have some time in the am to show me how to add a bundle to the charmstore for testing? | 23:21 |
| hatch | I really like the service icon they are using on ubuntu.com under 'Ubuntu Openstack' | 23:37 |
| gary_poster | hey rick_h_ am I right that featured and popular and new categories now have their own separate collections for bundles? | 23:38 |
| gary_poster | I think I remember that | 23:38 |
| gary_poster | http://staging.jujucharms.com/api/3/search/interesting | 23:39 |
| Makyo | jujugui ping re: release | 23:58 |
| gary_poster | hiya | 23:58 |
| hatch | Makyo: yo | 23:59 |
| * hatch working on promises | 23:59 | |
| * hatch is worried rick_h_ will get violent | 23:59 | |
| Makyo | gary_poster, there's a step in here for running integration tests on the charm (everything else was good, so woo), but I get 'juju-test not found'. Is that bit outdated, or am I missing something? | 23:59 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
