[00:36] <aquarius> nik90, I have the device connected via usb
[00:36] <aquarius> but the devices tab says "no devices detected"
[01:47] <mhall119> aquarius: does adb devices show the device?
[01:48] <mhall119> aquarius: last I heard the plan was to ship openssh server on the system images, but not running it by default unless you activated an "app developer mode" on the device
[01:48] <mhall119> I haven't heard that this has happened yet though
[02:16] <mhall119> daker: http://www.zdnet.com/ubuntu-touch-the-next-hot-smartphone-operating-system_p14-7000022156/#photo
[07:06] <dholbach> good morning
[07:30] <mihir_> dpm: dholbach: Good Morning :)
[07:31] <dholbach> hi mihir_, hey dpm
[07:31] <dpm> good morning :)
[07:42] <dholbach> dpm, time for a quick call in a bit?
[08:35] <JamesTait> You got back safely then?
[08:35] <JamesTait> Good morning all; happy Apple Day! :-D
[08:48] <gusch> nerochiaro: please review https://code.launchpad.net/~schwann/ubuntu-ui-extras/extras-facebook-share-lazy-load/+merge/191786 and https://code.launchpad.net/~schwann/gallery-app/gallery-share-panel-loader/+merge/191787
[08:59] <nerochiaro> gusch: on it
[09:02] <nerochiaro> gusch: the problem you're trying to solve there is to save resources by loading the panel only when needed ? or was there any other reason ?
[09:03] <gusch> nerochiaro: yes - mostly it's avoiding the delay when opening a photo the first time
[09:17] <nerochiaro> gusch: why didn't you leave the call to update in the constructor ? the properties are going to be read immediately anyway so it doens't really make a difference to leave it there
[09:17] <nerochiaro> gusch: on top of that you update every single time a property is read, which seems a bit of a waste
[09:18] <gusch> nerochiaro: they are only updated, when the value is invalid
[09:19] <gusch> nerochiaro: and the properties are only read when you hit the share button
[09:21] <nerochiaro> gusch: fair enough, that class is all just a big hack anyway, so it doesn't terribly matter
[09:26] <aquarius> nik90, mhall119, the Ubuntu SDK works perfectly. The Ubuntu Device screen perfectly sets up the device. You just have to actually plug the USB cable into your laptop. We apologise for the confusion.
[09:28] <aquarius> however, actually *running* an app from the SDK on the device writes a bunch of ssh-looking stuff into the log and then says "bash: cannot set terminal process group (-1): Invalid argument. bash: no job control in this shell", and nothing else happens?
[09:28] <nerochiaro> gusch: you're good to go
[09:29] <gusch> nerochiaro: thx
[09:29] <nerochiaro> gusch: thanks to you
[09:29] <nerochiaro> have to skip for a few minutes, brb
[09:33] <JamesTait> aquarius, hi!
[09:33] <aquarius> heya JamesTait :) How was oggcamp?
[09:34] <JamesTait> aquarius, it was lots of fun, as usual. :)  There was a mysterious aquarius-shaped hole though. ;)
[09:34] <JamesTait> (Although we did have a smattering of Saggitarius in the raffle)
[09:34] <aquarius> weekend with my daughter, who is more fun :)
[09:35] <JamesTait> aquarius, understandable. :)  How old is she now?  There were quite a few kids there this year - there were mutterings about an OggCamp futures track next year.
[09:36] <JamesTait> Connagh thoroughly enjoyed it.
[09:37] <popey> SprOggCamp ☻
[09:37] <JamesTait> \o/
[09:39] <aquarius> She's not actually very interested in computers :)
[09:40] <aquarius> popey, do you have any advice about "Run Application on Device" not working for me?
[09:41] <popey> 13.10?
[09:41] <popey> what output do you get in qtcreator?
[09:41] <popey> a bash error?
[09:43] <popey> if so i would reecommend you add the sdk ppa and update qtcreator & friends from there
[09:45] <popey> dpm: developer.ubuntu.com seems to have broken in that i can't find a way to navigate to the page which tells me the ppa name for the sdk
[09:45] <aquarius> popey, 13.10 on my laptop; released Ubuntu Touch (build 100, I think? how do I check?) on device. The log in QtC doesn't show the commands that it's *running*, but the output looks like it's scp'ing over the contents of my package, and then says ""bash: cannot set terminal process group (-1): Invalid argument. bash: no job control in this shell"
[09:45] <popey> i end up in a loop through a number of pages
[09:45] <popey> aquarius: adb shell system-image-cli -i
[09:45] <popey> will tell you version number
[09:45] <popey> yes, that issue is fixed in the ppa
[09:46] <aquarius> version version: 100
[09:46] <aquarius> (thank you, that's a useful command).
[09:46] <dpm> popey, http://developer.ubuntu.com/apps/qml/overview/ - we need to get back the dedicated installation page, you're not the only one who can't find it
[09:46] <aquarius> OK. Do the PPA changes end up in saucy? I am trying hard here to be an app developer, not an OS developer: I don't want to run an environment of PPAs if I can avoid it.
[09:47] <aquarius> because then my advice stops being useful to others.
[09:47] <dpm> aquarius, that was the plan. However, I was told last week that we're back to recommending PPAs in saucy
[09:47] <aquarius> oh.
[09:48] <aquarius> so you have to run Ubuntu SDK out of a PPA in order to develop for Ubuntu for phones? :-(
[09:49] <dpm> Mirv, bzoltan, that's the latest advice, is that correct? We're recommending now to run from the PPA for 13.10 as well? ^
[09:50] <popey> AIUI yes
[09:50]  * dpm updates web page
[09:51]  * aquarius looks sad. OK. I know this sounds like me being a bit complainy, but developer.ubuntu.com should be updated to say that in big letters.
[09:51] <Mirv> dpm: AIUI yes
[09:51] <popey> aquarius: it used to
[09:52] <aquarius> doesn't now, 'cos I tried to work out last night how to deploy an app to my device from Ubuntu SDK and ended up having to ask here :)
[09:52] <t1mp> it seems like qtc has a newer version on the ppa than in saucy. not sure if that is required though
[09:52] <bzoltan> dpm, aquarius:  we are not _BACK_ to PPA ... the main delivery channel of the SDK is the archive ... but after the Saucy was frozen and before the Trusty was not open we delivered fixes via the PPA
[09:52] <Mirv> dpm: I have a web page loop http://developer.ubuntu.com/ -> Get started now -> Tutorial: Requirements: get Qt5 and Ubuntu toolkit -> back to front page, no instructions on how to install
[09:53] <nik90> aquarius: that issue of No bash control thing is fixed in the PPA. I had that issue sometime back but has been resolved.
[09:53] <dpm> Mirv, yes, after we deployed the new IA on d.u.c recently we lost the dedicated Get Started page, it's on my list to get it back
[09:53] <Mirv> dpm: also it recommends qtcreator via apt://qtcreator, but that doesn't install the Ubuntu components which apt://qtcreator-plugin-ubuntu would do (or apt://ubuntu-sdk)
[09:54] <aquarius> nik90, yeah; popey's helpfully filled me in on that. We are now discussing how developer.ubuntu.com needs to tell people that they have to use the PPA in order to develop on the device, and dpm is working on that :)
[09:54] <nik90> aquarius: previously a PPA was not necessary, however since trusty is now open, we need a PPA for 13.10 but not for 14.04
[09:54] <nik90> aquarius: nice
[09:54] <Mirv> dpm: ok. I'm just wondering which web page you then updated since I don't find any pointer to 'ubuntu-sdk' or the PPA now?
[09:55] <dpm> Mirv, http://developer.ubuntu.com/apps/qml/overview/ is the fallback page until we get the dedicated Get started back up
[09:56] <Mirv> dpm: aha, ok, so there you'll be adding 13.10 cool. but the link from Tutorial subpage now doesn't fall back since it points to http://developer.ubuntu.com/get-started/gomobile/#step-get-toolkit
[09:57] <nik90> I have a question regarding updates. So will the updates from the core apps trunk all make it to the images used by the users? Or are we limiting them to only trusty?
[09:57] <dpm> Mirv, yeah, that broken link is the old Get Started page
[09:57] <aquarius> popey, so the SDK (according to http://developer.ubuntu.com/apps/qml/overview/) is ppa:ubuntu-sdk-team/ppa ? That's the page I think dpm is updating to say that you need the PPA for 13.10 users as well
[09:57] <dpm> nik90, we'll be updating core apps via click packages
[09:57] <nik90> dpm: ah nice
[09:57] <dpm> Mirv, bzoltan, so does this look ok to you? -> http://pastebin.ubuntu.com/6275784/
[09:58] <Mirv> dpm: that overview page lacks the "sudo apt-get dist-upgrade" required for 13.04 which was fixed recently elsewhere (which was now hidden) - on 13.04 otherwise some components would stay at the archive version, causing problems.
[09:58] <Mirv> dpm: other than adding dist-upgrade, yes
[09:58] <Mirv> (or I guess just 'upgrade' would be fine as well)
[09:58] <bzoltan> dpm: I am good with it
[09:59] <dpm> Mirv, you're the expert, 'upgrade' or 'dist-upgrade'?
[09:59] <Mirv> dpm: I've only tested dist-upgrade
[09:59] <Mirv> I don't remember if there was a sort of thing that'd require it. it doesn't hurt, though.
[10:00] <dpm> ok, so everyone happy with: http://pastebin.ubuntu.com/6275801/ ?
[10:00] <nik90> nic-doffay: you asked me to remind you about exposing "selected" property as public. Hope I am on time
[10:00] <Mirv> dpm: could you also consider graphically guiding Dash -> Software Sources -> Add PPA, and then have a apt:///ubuntu-sdk link, instead of command line / text guide?
[10:00] <nik90> Is it possible to upgrade to trusty as of now?
[10:01] <Mirv> dpm: happy
[10:01] <popey> yes dpm
[10:04] <dpm> Mirv, that's a good point, let me have a think about it. I'm all for using graphical tools over terminal - the reason I did it with a command line is that in this particular case it's much easier to explain and to run on a terminal. I.e. doing it graphically you still have to paste the apt line and drop to a terminal to do the update && dist-upgrade
[10:07] <aquarius> dpm, I'm not sure about those instructions: I followed them, and nothing was upgraded
[10:08] <aquarius> dpm, if those instructions are only for people who did not have the Ubuntu SDK installed *at all* before, then we may need a new set of instructions for people who did have it installed before...
[10:08] <aquarius> if I apt-get dist-upgrade then I get new versions of a bunch of qtcreator stuff, though.
[10:09] <nik90> aquarius: without ppa you will be running qtcreator 2.7.1 while the latest is 2.8.1
[10:09] <dpm> aquarius, they should work in both cases, as the packages from the PPA are newer.
[10:09] <davmor2> dholbach: thanks for random cats
[10:09] <Mirv> dpm: yeah, it needs some thinking, and surely it's harder to instruct than just command line (but makes for better first impression). if you start from Software Updates, and add the PPA from there, you can also use the "check for updates" on earlier Ubuntus there. on 13.10 there's no manual button for that though, and also otherwise each version's Software Updates does look different.
[10:09] <dholbach> davmor2, haha :)
[10:09] <aquarius> dpm, yeah, but the instructions don't tell people to upgrade the packages from the PPA: they just say to apt-get install ubuntu-sdk
[10:09] <davmor2> dholbach: it kills my battery every day ;)
[10:10] <aquarius> dpm, i think the instructions you pastebinned need an "apt-get dist-upgrade" on the end :)
[10:10] <Mirv> dpm: of course quantal and raring won't be supported for more then a couple of months now, so around Jan-Feb it'll be 12.04 LTS + 13.10 + dev version only
[10:10] <dholbach> davmor2, really? is it that much of a battery killer?
[10:10] <Mirv> dpm: anyway, a good thing to think about
[10:11] <davmor2> dholbach: no I only tend to look at it at the end of the day so the battery is lowish any way.  So the added internet usage kills it off nicely :)
[10:11] <dpm> aquarius, you mean in addition to the dist-upgrade that there is already? I'll let Mirv comment on that, I'm not an expert on apt
[10:11] <Mirv> aquarius: did you check dpm's latest pastebin? http://pastebin.ubuntu.com/6275801/
[10:12] <aquarius> oh! Apologies. Thank you, Mirv -- I missed a pastebin :)
[10:12] <Mirv> ok, all cool then
[10:12] <aquarius> sorry dpm, you're fine :)
[10:12] <dpm> ah, cool
[10:12]  * dholbach hugs davmor2
[10:12]  * dholbach has two apps sitting in the review queue
[10:12] <davmor2> dholbach: don't look at my review queue it will scare you
[10:15] <aquarius> Excellent, that works. Thank you, dpm, popey, Mirv.
[10:15] <dpm> \o/
[10:15] <popey> super
[10:15] <dpm> now we'll get a clear, dedicated get started page, bear with me for a few hours
[10:15] <aquarius> Close Application on Device works perfectly if the app is the foreground app -- it doesn't seem to work as well if I've already exited back to the Dash
[10:16] <aquarius> also, my QR code displayer doesn't work, but that's not the SDK's fault, that's clearly my fault ;)
[10:18] <mattaustin> Hi all. After trying and failing to compile it myself over the weekend, I'd like to draw attention to a 'needs-packaging' bug I filed yesterday - https://bugs.launchpad.net/ubuntu/+bug/1242247. It's for a QML plugin called "pyotherside", which allows access to python from QML. I think I'll need it in order to port my app from SailfishOS to Ubuntu Touch.
[10:18] <ubot2> Launchpad bug 1242247 in Ubuntu "[needs-packaging] Package "pyotherside" for Python in QML" [Wishlist,New]
[10:41] <dpm> mattaustin, you might want to send an e-mail to the ubuntu-phone mailing list, there's been recent discussion about this IIRC -> https://launchpad.net/~ubuntu-phone
[10:42] <dpm> actually, the discussion might have been on G+
[10:42] <dpm> but it might be worth starting a thread
[10:55] <mattaustin> dpm: Thanks will do!
[12:08] <nerochiaro> zsombi: it seems that TextArea steals input from InverseMouseArea. is it a known issue ?
[12:08] <zsombi> nerochiaro: as IMA is now based on MA, it can happen...
[12:09] <nerochiaro> zsombi: anything i can do to ensure IMA gets all the input it should get ?
[12:10] <zsombi> nerochiaro: not sure whether you can do anything without touching the MA inside the TextArea...
[12:11] <zsombi> nerochiaro: we have in plans to revisit the TextArea/TextField at some point, let's hope that time will come sooner than January...
[12:12] <nerochiaro> zsombi: ok, let's see if i can find some workarounds until then...
[12:13] <zsombi> nerochiaro: the propagateComposedEvents + mouse.accept = false may help you, however the problem is not in your IMA but in the TextArea's internal one...
[12:13] <nerochiaro> zsombi: it is too "greedy", right ?
[12:13] <zsombi> nerochiaro: yep :) :(
[13:05] <om26er> what can I use in *Qt* to force a certain screen orientation in an App ?
[13:05] <om26er> landscape in my case
[13:21] <nik90> om26er: check out https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1239760
[13:21] <ubot2> Launchpad bug 1239760 in Ubuntu UI Toolkit "Cannot manually set orientation" [Medium,Confirmed]
[13:22] <nik90> om26er: it was reported just today with exactly what you want.. Universe answered your call :)
[13:22] <om26er> nik90, right, but I want to do that in Qt  inside a QQuickView
[14:10] <om26er> bfiller, https://bugs.launchpad.net/mediaplayer-app/+bug/1184608
[14:10] <ubot2> Launchpad bug 1184608 in mediaplayer-app "mediaplayer should have a way to force landscape mode" [High,Triaged]
[14:44] <nerochiaro> bfiller: everything we had pending was merged into ubuntu-ui-extras. it just needs a release I think
[15:20] <slinky_> ei!
[15:20] <slinky_> there's any italian?
[15:20] <slinky_> need help for listitem!
[15:29] <randomcpp> slinky_, italian help here
[16:04] <om26er> mpt, hello! is the system-settings going to use UbuntuShape as shown here: http://design.canonical.com/wp-content/uploads/phone-overview-visual.small_.png or did the plan change
[16:05] <om26er> considering that didn't happen for 13.10
[16:06] <odarbelaeze_> Hi there, I am looking forward to publish an app written in c++, but in developer.ubuntu.com I just find documentation for qt html and casandra, where can I find the old documentation about other languages ?
[16:06] <t1mp> dpm: ^
[16:07] <t1mp> om26er: I have no idea, but to me the current version without the ubuntushape seems cleaner
[16:07] <mpt> om26er, I don't know ... The visual designers haven't mocked up the overview screen since that image, though I think they're doing it this week. Why do you ask?
[16:07] <dpm> odarbelaeze_, t1mp, unfortunately there is no documentation yet on how to create C++ apps
[16:08] <om26er> mpt, no reason. I was just looking at the designs and noted that.
[16:08] <mpt> om26er, well spotted then. :-)
[16:08] <om26er> t1mp, but maybe if we have better looking icons it may look better then
[16:08] <om26er> inside UShape
[16:09] <om26er> I think the search bar can go into the header like we have in Dash. t1mp are there plans to provide such thing in the UIToolkit ?
[16:10] <om26er> tap on the search button in top panel, the header changes to search bar
[16:11] <odarbelaeze_> dpm and C/C++ bindings for the Unity dektop api?
[17:15] <t1mp> om26er: uhm.. something was happening with search bars
[17:15] <t1mp> om26er: I don't know the details, but we will support searching somehow in the UITK
[17:15] <t1mp> kalikiana: perhaps you know more about the search support in UITK?
[17:16] <mrqtros> Hi folks!
[17:24] <WebbyIT> hei mhall119, here the link 'Ubuntu.Components.Tabs' is broken ;)
[17:24] <WebbyIT> http://developer.ubuntu.com/api/qml/sdk-1.0/search/?query=tab
[17:25] <mhall119> WebbyIT: thanks, looks like a parse error
[17:27] <September1> Hello, can anyone link me to a manual or some other info page about HTML5 apps?
[17:27] <September1> The links on ubuntu site are defunct
[17:28] <mhall119> September1: what's wrong with http://developer.ubuntu.com/apps/html-5/overview/ ?
[17:30] <kalikiana> om26er: timppa indeed search in the header is planned. unfortunately there's a ton of things involved including design, user testing and connecting the dash and panel to the search in the app, so long story short, it'll take some more time to be finalized
[17:30] <t1mp> I'm timppa
[17:30] <om26er> lol
[17:31] <t1mp> kalikiana: I *FINALLY* have a test for the timeout of the toolbar....
[17:31] <kalikiana> and essentially people involved opted in favour of no compromise half solution even if the real deal takes time
[17:31] <om26er> kalikiana, cool. thanks
[17:31] <t1mp> kalikiana: sleep() seems to put the whole app (including Timers) to sleep. I needed to use wait() instead!
[17:31] <kalikiana> t1mp: oh, that's why you asked about timers earlier. interesting detail
[17:32] <t1mp> kalikiana: yeah that's much better. Otherwise we have to replace the compromise half solution eventually by the real deal, while still supporting the compromise half solution...
[17:32] <t1mp> kalikiana: it makes sense now.. but I didn't see it before.
[17:32] <t1mp> so I spent the whole day trying to figure out why my app worked perfectly outside of tests, and the timer didn't trigger anything when used in the test :)
[17:32] <t1mp> not :)
[17:32] <t1mp> well now :), before :(
[17:33] <kalikiana> :-D
[17:33] <kalikiana> imagine you're talking about a funeral with a big smile
[17:33] <kalikiana> that'd be awesome
[17:34] <kalikiana> I saw an episode of bullshit(pen&teller) and they suggested to have happy music and frown less
[17:35] <September1> mhall119: Yup, but I was looking for something like an API
[17:36] <t1mp> kalikiana: well.. http://www.youtube.com/watch?v=8o9-E-eMUHs
[17:36] <kalikiana> timppa: speaking of success, feest your eyes https://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/887/consoleText https://code.launchpad.net/~kalikiana/ubuntu-ui-toolkit/unit_x11_fixes/+merge/191968
[17:37] <kalikiana> oh it must be the 1 that's why I autocomplete the wrong guy
[17:37] <mhall119> September1: we're working on getting the API up for HTML5
[17:38] <t1mp> ahhhh
[17:38] <t1mp> kalikiana: I notice now that there is a timppa here. I thought you just made some weird typo
[17:39] <kalikiana> so that's not you?
[17:39] <t1mp> kalikiana: no
[17:39] <kalikiana> in that case sorry there timppa I'll buy you a beer if we ever meet :-D
[17:40] <t1mp> kalikiana: I'm even not timp. That was taken on freenode
[17:40] <t1mp> kalikiana: maybe it is jp under cover ;)
[17:42] <kalikiana> I used to "watch" two andrès fight over the nick andre, I would regularly see either one try to login and the other would complain
[17:42] <September1> mhall119: Ah well, thank you
[17:42] <t1mp> hmm
[17:43] <t1mp> on freenode you can register a nickname so the fighting should have ended soon
[17:46] <t1mp> kalikiana: https://code.launchpad.net/~kalikiana/ubuntu-ui-toolkit/unit_x11_fixes/+merge/191968 seems good.
[17:46] <t1mp> kalikiana: is it ready for approval?
[17:47] <kalikiana> t1mp: totally. maybe just to be on the safe side give it a quick local run, but this actually runs on jenkins not *only* locally
[17:48] <t1mp> kalikiana: that's what I'm doing at the moment :)
[17:48] <kalikiana> awesome
[17:48] <t1mp> kalikiana: textfield test fails
[17:49] <kalikiana> hrmpf. what error?
[17:49] <t1mp> kalikiana: https://pastebin.canonical.com/99310/
[17:50] <kalikiana> wtf does that error mean
[17:50] <kalikiana> it makes little sense
[17:52] <kalikiana> t1mp: what's the version of your qtdeclarative5-unity-action-plugin Ive got 1.0.0+13.10.20130716-0ubuntu1
[17:52] <kalikiana> maybe there's some binding change?
[17:53] <t1mp> 1.0.0+13.10.20130716bzr29saucy0
[17:53] <t1mp> hmm
[17:53] <t1mp> Action should be the Action from UITK I guess, not from Unity.Actions.
[17:56] <t1mp> kalikiana: the import you added is weird. Action doesn't need an import. And for UnityActions.Action.Type.Integer an import Ubuntu.Unity.Action 1.0 as UnityActions would be needed
[17:57] <t1mp> kalikiana: if I import like that, I get FAIL!  : components::TextFieldAPI::test_zz_ActionInputMethodHints() Uncaught exception: Cannot read property 'Integer' of undefined
[17:57] <t1mp> hmm...
[17:58] <t1mp> UnityActions used to be a fake implementation on desktop, so maybe UnityActions.Action.Type.Integer doesn't even exist there.
[17:58] <t1mp> in that case, this test never worked on desktop.
[17:58] <t1mp> Wellark: ^ any ideas what's happening here?
[17:59] <kalikiana> yes the import is for the type
[18:00] <t1mp> kalikiana: for the Action? There is an Action in UITK, so no additional import is needed
[18:00] <t1mp> or you mean for the Integer? Then it needs import *as*. But I tried it and it doesn't work for me as well.
[18:01] <kalikiana> by the type I meant the integer, yes. it's defined in unity.action only
[18:03] <t1mp> there used to be a cpp directory here http://developer.ubuntu.com/api/ that contained the unity actions api
[18:04] <kalikiana> qmlplugindump Ubuntu.Unity.Action 1.0 :-P
[18:04] <t1mp> hmm. in the checkout of unity-actions-api that I have, there has not been an update since July.
[18:06] <t1mp> kalikiana: http://pastebin.ubuntu.com/6278342/
[18:12] <kalikiana> hm seems the same I have
[18:13] <t1mp> kalikiana: UITK Action inherits from unity actions, so without the import,             textField.parameterType = Action.Type.Integer;
[18:14] <t1mp> should work.
[18:14] <t1mp> but it doesn't. I get Action is not defined :s which is weird
[18:16] <kalikiana> if that were true we'd not have both import for components and qtquick
[18:17] <t1mp> what do you mean?
[18:17] <t1mp> kalikiana: in our Action.qml, we import Ubuntu.Unity.Action, and our Action component inherits from that
[18:18] <kalikiana> then why does it need QtQuick also? surely we have a fair number of those by inheritence
[18:18] <kalikiana> I don't think this is covered by inheritence at all
[18:19] <t1mp> kalikiana: without QtQuick you wouldn't have for example Item or Rectangle.
[18:19] <t1mp> but there is an Action, even if you don't import unity actions.
[18:19] <t1mp> and our Action has everything that unity actions Action has
[18:19] <kalikiana> Action is a type just like Rectangle
[18:20] <t1mp> yes, but we don't define a Rectangle in the UITK
[18:20] <kalikiana> and we don't define Action.type either
[18:21] <kalikiana> same difference to me
[18:21] <t1mp> but that one is in Action from its parent class
[18:21] <kalikiana> no it's not a property, it's an enum
[18:21] <t1mp> hmm
[18:21] <t1mp> ok I don't know if those are inherited as well
[18:23] <t1mp> kalikiana: https://code.launchpad.net/~tpeeters/ubuntu-ui-toolkit/toolbar-reveal2/+merge/184678 passed CI. So if you are not eod yet and you like to look at someone else's code for a while, go ahead and review it :)
[18:23] <t1mp> kalikiana: you reviewed it already, before I added the timeout test.
[18:24] <kalikiana> for some reason I read "look at someone else's code for a while" and my brain inserts a different word there… but I'll have a look
[18:25]  * kalikiana has no gf pulling him out of his office right now so lucky for you
[18:25] <t1mp> I think I see which word your brain inserted but I don't even dare to guess ;)
[18:25] <t1mp> kalikiana: thanks.
[18:28] <kalikiana> I'm guessing "margin" in the test would be for fluctuation in the cpu?
[18:29] <t1mp> initially I added it to take the animation time of the hiding toolbar into account
[18:29] <t1mp> maybe it is not needed
[18:31] <t1mp> kalikiana: in theory the margin is not needed, but with no margin or a very small margin (100 ms), it fails
[18:33] <t1mp> kalikiana: when the timer is triggered, toolbar.close() is called, which sets toolbar.state to "", and toolbar.opened depends on that and should be false.
[18:33] <t1mp> kalikiana: but there is a small delay before it is really false. I don't know in which of those steps is the delay.
[18:43] <kalikiana> a good question would be if animation depends on gpu ticks or always goes exactly the time
[18:46] <t1mp> kalikiana: the way the properties are defined, opened should become false immediately, independent from the animation
[18:47] <t1mp> kalikiana: or at least with my reasoning it should be like that..
[18:48] <t1mp> kalikiana: so perhaps the timer is a little bit too late (trigger delayed), or there is a delay in updating the variables that lead to opened being false after the timer triggers
[18:49] <t1mp> or both
[19:01] <t1mp> kalikiana: EOD for me now. I guess the problem I have with your MR is an issue with the unity actions, but I'm not sure. Let's see tomorrow if other people have the same problem.
[19:02] <t1mp> kalikiana: if you have comments on my MR I'll check them tomorrow
[19:02] <t1mp> enjoy your evening!
[19:02] <kalikiana> I get one failure test_click_toolbar_button
[19:02] <t1mp> kalikiana: huh in the unit tests?
[19:03] <kalikiana> autopilot
[19:03] <t1mp> ok, please mention that in the MR. I'll fix it tomorrow.
[19:04] <t1mp> hmm
[19:04] <t1mp> weird that CI says all is fine.
[19:04] <t1mp> anyway,
[19:04]  * t1mp EOD
[19:04] <kalikiana> yup. have a nice one
[19:56] <WebbyIT> popey, are dpm and boiko on holiday?
[21:26] <balloons> ping nik90 https://code.launchpad.net/~nskaggs/ubuntu-clock-app/alarm-tests/+merge/191482 I think is ready as we spoke about.. tests for alarm commented out for now
[22:02] <nik90> balloons: hmm wierd I did not receive an irc ping for that.. but anways I reviewed your code
[22:14] <AskUbuntu> Building Jot for Non-photorealistic Renders | http://askubuntu.com/q/363366
[23:06] <snizzo> I can't get why this small piece of code doesn't work http://pastebin.ubuntu.com/6279885/
[23:06] <snizzo> download reply is never called