=== liam_ is now known as Guest63337
[03:01] <StevenK> wgrant: So, something about transistionToStatus. I respect your current reasoning, but do you still have an issue if createManyTasks forgoes the permission checks and calls the setting logic?
[03:01] <wgrant> StevenK: That might be more reasonable.
[03:02] <StevenK> I'm not sure I can hack create() to set them based on the status
[03:30] <StevenK> wgrant: http://pastebin.ubuntu.com/6280794/
[03:45] <wgrant> StevenK: Ew.
[03:45] <wgrant> StevenK: Can you factor that out?
[03:45] <wgrant> Surely transitionToStatus can use that.
[03:46] <StevenK> wgrant: transitionToStatus works on the changes from old status to new status
[03:47] <wgrant> StevenK: Right, and what's the problem?
[03:48] <StevenK> So transitionToStatus will only set date_triaged if old_status < TRIAGED and new_status >= TRIAGED
[03:48] <wgrant> Sure
[03:48] <wgrant> That logic works for createMultipleTasks too
[03:48] <wgrant> Because old_status is NEW
[03:51] <StevenK> wgrant: createManyTasks :-P and http://pastebin.ubuntu.com/6280868/
[03:52] <wgrant> That's no method name
[03:52] <StevenK> _set_date_properties ?
[04:03] <wgrant> StevenK: Methods are mixedCase
[04:06] <StevenK> wgrant: http://pastebin.ubuntu.com/6280909/
[04:07] <wgrant> StevenK: That looks relatively sane.
[04:11] <StevenK> wgrant: https://code.launchpad.net/~stevenk/launchpad/use-transitionToStatus-createManyTasks/+merge/191554 has updaed
[04:11] <StevenK> *updated
[04:13] <wgrant> r=me
[04:14] <wgrant> Do QA lots of cases, though
[04:14] <StevenK> Yeah, I'll go through NEW, INCOMPLETE, TRIAGED, CONFIRMED, FIX*
[04:23] <wgrant> StevenK: And creating new tasks directly or by release-targeting, and check the conjoined master and slave cases.
[04:28]  * StevenK stabs swift
[05:29] <lifeless> StevenK: how is swift-for-librarian working out ?
[05:31] <StevenK> lifeless: It is still waiting for review.
[05:34] <lifeless> StevenK: by you and wgrant ?
[05:35] <wgrant> Yes, I need to bring myself to look at it at some point.
[05:37] <StevenK> lifeless: We have a subunit stream that imports in 0.0.4, and spins for ~30 seconds in 0.0.17 and gives no failing tests.
[05:38] <lifeless> StevenK: v1 vs v2 probably; does | subunit-1to2 | <whatever processor you're using> do better?
[05:41] <StevenK> lifeless: Ah ha!
[05:42] <StevenK> lifeless: It can't tell the difference between v1 and v2 streams?
[05:48] <lifeless> StevenK: not automagically
[06:00] <StevenK> wgrant: The test_distroseries_context_with_no_series_task
[06:00] <StevenK> Bleh
[06:00] <wgrant> I agree.
[06:00] <StevenK> wgrant: The test_distroseries_context_with_no_series_task failure is strange -- none of those tests are invalidating caches
[06:01] <wgrant> It could be a test ordering issue.
[06:03] <StevenK> My fingers are itching to refactor that file to a shadow of its former self.
[06:13] <lifeless> StevenK: wgrant: so, having a review getting stale is just a bad idea; surely 'go live' is a separate problem to 'the code is good enough' ?
[06:50] <harishnavnit> hello all
[06:51] <harishnavnit> new to this place , need some help with bug fixes for launchpad
[06:51] <harishnavnit> can anyone help ??
[06:57] <harishnavnit> ping
[06:59] <wgrant> harishnavnit: Hi
[07:01] <harishnavnit> wgrant: hello
[07:04] <harishnavnit> @wgrant : can you help me contributing to launchpad ?
[07:04] <wgrant> harishnavnit: Have you found a bug that you want to fix?
[07:04] <harishnavnit> yes
[07:06] <wgrant> Which one?
[07:06] <harishnavnit> #128642
[07:06] <_mup_> Bug #128642: searching for a bug using #59348 fails <lp-bugs> <search> <trivial> <ui> <Launchpad itself:Triaged by harishnavnit> <https://launchpad.net/bugs/128642>
[07:07] <harishnavnit> yes
[07:07] <harishnavnit> what next ?
[07:08] <wgrant> harishnavnit: How far have you gotten?
[07:08] <harishnavnit> not very far . i'm yet to start coding
[07:09] <harishnavnit> i have the build
[07:09] <harishnavnit> lp-branches
[07:10] <wgrant> Have you managed to get Launchpad running?
[07:10] <wgrant> The code you probably want to alter is in BugTaskSearchListingView.buildSearchParams.
[07:11] <harishnavnit> well this is my first attempt for a bug fix
[07:12] <harishnavnit> can you elaborate please ?
[07:12] <harishnavnit> i haven't managed to get launchpad running
[07:13] <wgrant> https://dev.launchpad.net/Running describes how to get a local Launchpad instance running.
[07:17] <harishnavnit> yea , i had gone through it
[07:18] <harishnavnit> what is postgreSQL by the way ?
[07:18] <wgrant> http://www.postgresql.org/about/
[07:19] <harishnavnit> thank you
[10:02] <cjwatson> wgrant: The Nagios change that was blocking https://code.launchpad.net/~cjwatson/launchpad-buildd/remove-old-status/+merge/191809 should be in now
[10:07] <wgrant> cjwatson: Thanks, approved.