StevenK | wgrant: https://code.launchpad.net/~stevenk/launchpad/check-series-bug-changeitype/+merge/192449 | 01:12 |
---|---|---|
wgrant | chan gei type? chang eit ype? | 01:14 |
wgrant | No parsing sounds dreadfully plausible. | 01:14 |
wgrant | StevenK: I'd consider using bugtaskflat for that, but I guess other parts of the code will time out first on a large project. | 01:16 |
StevenK | wgrant: I'm happy to switch it to BTF if you wish | 01:18 |
wgrant | nah | 01:18 |
StevenK | It's like a three line change and involves no longer joining Bug and BugTask | 01:19 |
wgrant | I guess we already have other internal consistency checks based on the throwaway cache table | 01:19 |
wgrant | So OK | 01:20 |
StevenK | Hah, it ends up as +6/-6 | 01:23 |
StevenK | wgrant: http://pastebin.ubuntu.com/6292383/ | 01:24 |
wgrant | Right | 01:25 |
StevenK | I might switch that information_type for IS IN (PUBLIC), rather than IS NOT IN (PROPRIETARY) | 01:26 |
wgrant | That would be incorrect. | 01:26 |
wgrant | Private Security and Private are forbidden for proprietary projects | 01:26 |
StevenK | It would? | 01:26 |
wgrant | But there may be a non-proprietary list somewhere, I can't recall. | 01:26 |
StevenK | We're looking for public bugs, why would IS IN PUBLIC_INFORMATION_TYPES be wrong? | 01:27 |
StevenK | Oh | 01:28 |
StevenK | I get it | 01:28 |
StevenK | Right | 01:28 |
wgrant | We're looking for non-proprietary bugs | 01:29 |
wgrant | Not just public ones. | 01:29 |
StevenK | Right | 01:29 |
StevenK | FREE_INFORMATION_TYPES = ( | 01:29 |
StevenK | PUBLIC_INFORMATION_TYPES + FREE_PRIVATE_INFORMATION_TYPES) | 01:29 |
wgrant | That's the one. | 01:30 |
StevenK | So it looks like IS IN FREE_INFORMATION_TYPES would be fine too | 01:30 |
wgrant | That would be better, yes. | 01:30 |
wgrant | Indexable and stuff. | 01:30 |
StevenK | Right, hence why I wanted IS IN, rather than the inverse :-) | 01:30 |
StevenK | wgrant: I know you've already approved it, can you cast your eyes over it again given the BTF and FREE changes? | 01:35 |
StevenK | wgrant: And it's 'change itype' | 01:41 |
StevenK | check-series-bug-change-information-type seemed too long | 01:42 |
wgrant | StevenK: Looks good | 01:58 |
StevenK | wgrant: https://code.launchpad.net/~stevenk/launchpad/refactor-test-bugtaskfilter/+merge/192456 | 04:08 |
=== liam_ is now known as Guest1997 | ||
=== liam_ is now known as Guest32295 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!