/srv/irclogs.ubuntu.com/2013/10/24/#launchpad-dev.txt

StevenKwgrant: https://code.launchpad.net/~stevenk/launchpad/check-series-bug-changeitype/+merge/19244901:12
wgrantchan gei type? chang eit ype?01:14
wgrantNo parsing sounds dreadfully plausible.01:14
wgrantStevenK: I'd consider using bugtaskflat for that, but I guess other parts of the code will time out first on a large project.01:16
StevenKwgrant: I'm happy to switch it to BTF if you wish01:18
wgrantnah01:18
StevenKIt's like a three line change and involves no longer joining Bug and BugTask01:19
wgrantI guess we already have other internal consistency checks based on the throwaway cache table01:19
wgrantSo OK01:20
StevenKHah, it ends up as +6/-601:23
StevenKwgrant: http://pastebin.ubuntu.com/6292383/01:24
wgrantRight01:25
StevenKI might switch that information_type for IS IN (PUBLIC), rather than IS NOT IN (PROPRIETARY)01:26
wgrantThat would be incorrect.01:26
wgrantPrivate Security and Private are forbidden for proprietary projects01:26
StevenKIt would?01:26
wgrantBut there may be a non-proprietary list somewhere, I can't recall.01:26
StevenKWe're looking for public bugs, why would IS IN PUBLIC_INFORMATION_TYPES be wrong?01:27
StevenKOh01:28
StevenKI get it01:28
StevenKRight01:28
wgrantWe're looking for non-proprietary bugs01:29
wgrantNot just public ones.01:29
StevenKRight01:29
StevenKFREE_INFORMATION_TYPES = (01:29
StevenK    PUBLIC_INFORMATION_TYPES + FREE_PRIVATE_INFORMATION_TYPES)01:29
wgrantThat's the one.01:30
StevenKSo it looks like IS IN FREE_INFORMATION_TYPES would be fine too01:30
wgrantThat would be better, yes.01:30
wgrantIndexable and stuff.01:30
StevenKRight, hence why I wanted IS IN, rather than the inverse :-)01:30
StevenKwgrant: I know you've already approved it, can you cast your eyes over it again given the BTF and FREE changes?01:35
StevenKwgrant: And it's 'change itype'01:41
StevenKcheck-series-bug-change-information-type seemed too long01:42
wgrantStevenK: Looks good01:58
StevenKwgrant: https://code.launchpad.net/~stevenk/launchpad/refactor-test-bugtaskfilter/+merge/19245604:08
=== liam_ is now known as Guest1997
=== liam_ is now known as Guest32295

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!