[01:12] wgrant: https://code.launchpad.net/~stevenk/launchpad/check-series-bug-changeitype/+merge/192449 [01:14] chan gei type? chang eit ype? [01:14] No parsing sounds dreadfully plausible. [01:16] StevenK: I'd consider using bugtaskflat for that, but I guess other parts of the code will time out first on a large project. [01:18] wgrant: I'm happy to switch it to BTF if you wish [01:18] nah [01:19] It's like a three line change and involves no longer joining Bug and BugTask [01:19] I guess we already have other internal consistency checks based on the throwaway cache table [01:20] So OK [01:23] Hah, it ends up as +6/-6 [01:24] wgrant: http://pastebin.ubuntu.com/6292383/ [01:25] Right [01:26] I might switch that information_type for IS IN (PUBLIC), rather than IS NOT IN (PROPRIETARY) [01:26] That would be incorrect. [01:26] Private Security and Private are forbidden for proprietary projects [01:26] It would? [01:26] But there may be a non-proprietary list somewhere, I can't recall. [01:27] We're looking for public bugs, why would IS IN PUBLIC_INFORMATION_TYPES be wrong? [01:28] Oh [01:28] I get it [01:28] Right [01:29] We're looking for non-proprietary bugs [01:29] Not just public ones. [01:29] Right [01:29] FREE_INFORMATION_TYPES = ( [01:29] PUBLIC_INFORMATION_TYPES + FREE_PRIVATE_INFORMATION_TYPES) [01:30] That's the one. [01:30] So it looks like IS IN FREE_INFORMATION_TYPES would be fine too [01:30] That would be better, yes. [01:30] Indexable and stuff. [01:30] Right, hence why I wanted IS IN, rather than the inverse :-) [01:35] wgrant: I know you've already approved it, can you cast your eyes over it again given the BTF and FREE changes? [01:41] wgrant: And it's 'change itype' [01:42] check-series-bug-change-information-type seemed too long [01:58] StevenK: Looks good [04:08] wgrant: https://code.launchpad.net/~stevenk/launchpad/refactor-test-bugtaskfilter/+merge/192456 === liam_ is now known as Guest1997 === liam_ is now known as Guest32295