=== TheMuso` is now known as TheMuso
=== jalcine is now known as jalcine_
=== jalcine_ is now known as jalcine
=== jalcine is now known as jalcine_
=== jalcine_ is now known as jalcine
=== jalcine is now known as jalcine_
=== jalcine_ is now known as jalcine
=== jono is now known as Guest95491
=== jalcine is now known as jalcine_
=== jalcine_ is now known as jalcine
=== jalcine is now known as jalcine_
=== iahmad is now known as iahmad|afk
Saviqmzanetti, that's a duplicate - bug #1243889 - right? if you can remember the other one - please mark dupe08:35
ubot5bug 1243889 in unity8 (Ubuntu) "Launcher app where APP_ID is non legacy is lost on updates" [Undecided,New] https://launchpad.net/bugs/124388908:35
mzanettiSaviq: yes.08:36
mzanettinarf... I *always* click on the bug number and join weird channels08:37
=== iahmad|afk is now known as iahmad
tsdgeosdoes anybody know what causes the "up" animation in the preview?09:12
tsdgeosis it OpenEffect?09:12
tsdgeosSaviq: ↑↑↑ ?09:12
Saviqtsdgeos, "causes"?09:13
Saviqtsdgeos, OpenEffect splits the dash view, yes09:13
tsdgeosthat's unfortunate :/09:13
tsdgeosdoesn't take my new floating tabbar into account09:13
Saviqtsdgeos, right...09:13
Saviqtsdgeos, arguably, the preview could be moved up the stack09:14
Saviqtsdgeos, so that it's on top of the whole dash09:14
tsdgeosor at least the OpenEffect09:14
Saviqbut then that'd mean we're splitting all of the dash09:14
Saviqnot just the current view09:14
Saviqwhich means moar pixels :/09:14
tsdgeosSaviq: ?09:18
tsdgeosisn't "all of the dash" == "the current view"?09:19
tsdgeosah no09:19
Saviqtsdgeos, no, I mean the other scopes, too09:19
tsdgeoswe load everything09:19
tsdgeos        cacheBuffer: 214748364709:19
tsdgeosthe OpenEffect works over sourceItem.width, sourceItem.height09:19
tsdgeosnot sure we'd be moving more pixels than that09:19
Saviqif the effect is only as big as the view - it won't sample beyond that09:20
Saviqor affect anything beyond that09:20
Saviqtsdgeos, it feels like you should rebase on top of mzanetti's switching-previews before you start that09:20
Saviqwhich I should re-review btw :/09:21
tsdgeoshe he09:21
Saviqmzanetti, btw https://bugs.launchpad.net/unity8/+bug/1243824/comments/209:21
mzanettitsdgeos: lp:~unity-team/unity8/switching-previews09:21
ubot5Ubuntu bug 1243824 in Unity 8 "Fullscreen apps in landscape mode expose the right edge gesture by tapping" [Medium,Triaged]09:21
tsdgeosmzanetti: Saviq: i think i can "easily" fix it how it's now, let me get to almost-feature-finished09:21
tsdgeosand then i'll rebase09:21
Saviqtsdgeos, ok09:22
mzanettiSaviq: mhm. yeah. that matches with my suspicion09:22
Saviqmzanetti, the other movement in jhodapp's video (movement of the app itself) I'm not sure what it is09:24
Saviqmzanetti, it might be the screenshot, which doesn't cater for fullscreen apps...09:24
mzanettiSaviq: I think that's the panel09:24
mzanettiSaviq: ah no. the app's size seems to change09:25
mzanettibut that might well be related to the panel show/hide09:25
Saviqmzanetti, don't think so, as it doesn't happen in portrait09:26
mzanettihmm... interesting09:26
SaviqI mean09:26
Saviqin portrait when you touch the app-panel edge09:26
Saviqbut does happen on right edge09:26
Saviqand in gallery, too - but only if it's the only app09:27
mzanettiSaviq: because it's the right edge only09:27
mzanettiwould be interesting to see if happens the other way round too. with the launcher's edge09:27
Saviqmzanetti, yeah but I mean it's unrelated to the panel09:27
mzanettiok, yes09:27
mzanettiwait... I think we're confusing panels :D09:28
Saviqmzanetti, toolbar09:28
Saviqmzanetti, unrelated to toolbar09:28
mzanettiright, yes. agreed09:28
Saviqmzanetti, it's our hinting thingy for when there's only one app09:28
mzanettiyeah, sure09:28
Saviqmzanetti, so you'll fix it with your right edge rework ;)09:29
mzanettiSaviq: ok09:29
Saviqmzanetti, was kinda kidding, but yeah - it may very well be the output of your stuff09:29
mzanettiSaviq: btw. I managed to catch another one while testing with edges yesterday: https://code.launchpad.net/~mzanetti/unity8/dont-tease-while-moving/+merge/19236609:30
Saviqmzanetti, yeah, saw that09:30
Cimifixed? https://bugs.launchpad.net/unity8/+bug/123519009:31
ubot5Ubuntu bug 1235190 in Unity 8 "[regression] [mako] Scrolling and animations are very slow with Mir" [High,Confirmed]09:31
SaviqCimi, invalid - not our bug09:43
SaviqCimi, btw, can you dupe bug #1234921 to the one you were fixing, please09:43
ubot5bug 1234921 in unity8 (Ubuntu) "UX: awkward interface for 'Recent apps' after manually stopping an app" [Undecided,New] https://launchpad.net/bugs/123492109:43
Saviqmzanetti, how about bug #1232260 - seen it anywhere again?09:47
ubot5bug 1232260 in unity8 (Ubuntu) "unity8 crashed with SIGSEGV in typeinfo for QQmlEnginePrivate::Deletable()" [Medium,New] https://launchpad.net/bugs/123226009:47
mzanettiSaviq: hmm... Not knowingly. I did have some crashes lately, but didn't eagerly ready each and every stack trace any more in the last week09:48
mzanettiI'll watch out for it09:48
Saviqmzanetti, I'll make incomplete then09:50
mzanettiSaviq: I'm afraid the right edge thing will require to rethink all the stages stuff09:57
mzanettifrom both perspectives: Design and implementation09:57
=== iahmad is now known as iahmad|afk
Saviqmzanetti, of course it will09:59
Saviqmzanetti, there's no bug for the right edge prototype you're doing now is there?10:06
Saviqbug #1228733 fyi10:06
ubot5bug 1228733 in unity8 (Ubuntu) "Right swipe application switcher is inefficient " [Undecided,New] https://launchpad.net/bugs/122873310:07
mzanettiSaviq: cheers10:09
Saviqmzanetti, you got the gdbus call that you used to reset the launcher?10:10
* Saviq needs to turn the demo back on10:10
mzanettigdbus call --system --dest org.freedesktop.Accounts --object-path /org/freedesktop/Accounts/User32011 --method org.freedesktop.DBus.Properties.Set com.canonical.unity.AccountsService launcher-items "<[{'defaults' : <true>}]>"10:10
mzanettiSaviq: ^10:11
Saviqmzanetti, thanks10:11
Saviqjeez can we please fix the console over adb? kthxbai10:11
mzanetti+1 :D10:13
Saviqgreyback, is there a bug about parenting surfaces in mir/unity-mir? bug #1240611 could use a relation there10:20
ubot5bug 1240611 in Unity 8 "[content picking] Content picking mode does not reflect the current app that requires picking" [Undecided,New] https://launchpad.net/bugs/124061110:20
greybackSaviq: https://bugs.launchpad.net/unity-mir/+bug/123009110:21
ubot5Ubuntu bug 1230091 in unity-mir "[enhancement] Window reparenting (required for appstore app trust model)" [High,Triaged]10:21
Saviqgreyback, thanks10:21
Saviqyay for bug triaging...10:28
=== MacSlow is now known as MacSlow|lunch
Saviqmzanetti, hmm so you weren't shown all the video prototypes?10:30
mzanettiSaviq: if you ask like this the answer is probably: no10:30
Saviqmzanetti, for main + side stage, right-edge, the most probable solution would be to show the side and main stage apps next to each other, on separate stacks10:31
Saviqmzanetti, obviously this does conflict with dragging the side stage in10:31
Saviqmzanetti, and I don't think they have a ready-made answer10:32
mzanettiok. so the mail is still valid10:32
Saviqmzanetti, yeah of course it is10:32
Saviqmzanetti, please bug them so that they show you everything they have10:32
Saviqmzanetti, and at least nudge in the direction they're leaning towards10:33
greybackSaviq: mzanetti: can you send me link to those video prototypes please? I've lost it10:36
Saviqgreyback, we never had them ;)10:36
Saviqgreyback, Oren showed it from his laptop - he'll probably steal them now and not let us see! ;)10:36
mzanettigreyback: Saviq: there is a qml prototype in the willow-team repository10:36
Saviqmzanetti, yeah, that's old10:37
greybackSaviq: he didn't share??10:37
Saviqgreyback, AFAIR he shared the screen10:37
mzanettiit's quite close to the video that vesar showed me through the hangout10:37
Saviqgreyback, so that he could control10:37
Saviqmzanetti, yeah, problem is they're looking at some other similar approaches10:37
Saviqmzanetti, and you should see them all10:37
Saviqespecially when we're not yet sure which way to go10:38
mzanettivesar: ^^ *hint*10:38
Saviqif only for you to think of it in a way that would let us go between the different solutions a little bit easier10:38
greybackhmm, I've got the phone video10:38
greybackmight be old tho10:38
mzanettiI guess that's the one I saw in the meeting yesterday10:39
Saviqgreyback, yeah, it probably is the first one - and Oren showed us like 5 different ones then10:39
* Saviq really food10:39
* greyback away10:41
nic-doffaySaviq, how can I slow down the desktop gallery previews again? I recall you telling me this a while ago and forgot to make a note of it...10:50
Saviqnic-doffay, qmlscene --help10:58
=== _salem is now known as salem_
dednickmpt: ping12:12
=== MacSlow|lunch is now known as MacSlow
sil2100Trevinho: ping!12:51
sil2100bregma: hi! Do you know when Trevinho will be around today?12:53
bregmasil2100, he's in California, he might be around Monday12:54
bregmaevidently we allowed him a day or two of vacation12:54
bregmawon;t happen again12:54
mzanettidednick: I got assigned to do a reevaluation of things that need to be tested etc. what happened to the indicator autopilot tests?12:55
Saviqmzanetti, there weren't any ;)12:56
Saviqmzanetti, but alesage is working on new ones12:56
Saviqmzanetti, https://code.launchpad.net/~allanlesage/unity8/indicator-stubs/+merge/19205912:56
mzanettiok, thanks12:59
Saviqdednick, add a TODO on https://code.launchpad.net/~nick-dedekind/unity8/indicator-segfault-lp1243146/+merge/192121 to mention there *will* be a QTBUG please13:03
Saviq/we need to do another round of TODO / FIXME review13:04
greybackSaviq: to add to your list of TODOs, it would be great if we could get cross-building with pbuilder chroots working reliably.13:12
Saviqgreyback, oh yeah, that's there already13:12
Saviqgreyback, btw, just found a potentially nice trick13:12
greybackSaviq: oO, please share :)13:12
Saviqgreyback, system-image-cli --filter full13:12
Saviqgreyback, will revert your write-enabled phone13:12
Saviqto the latest pristine image13:13
Saviqwithout touching any other data13:13
greybackSaviq: cool13:13
Saviqwith --build 0 will replace the current image13:13
Saviqno way yet to downgrade - bug #1244208 and bug #124421113:14
ubot5bug 1244208 in Ubuntu system image "system-image-cli should allow selecting which image to upgrade / downgrade to" [Wishlist,Triaged] https://launchpad.net/bugs/124420813:14
ubot5bug 1244211 in system-image (Ubuntu) "system-image-cli hangs indefinitely at "Running group download reactor"" [Undecided,New] https://launchpad.net/bugs/124421113:14
Saviqbut that at least means we can easily revert to a clean image without losing $HOME and such13:15
Saviqwhich means I could start dog-fooding the phone after all13:15
dednickSaviq: ok13:29
dednickSaviq: done.13:32
greybacktsdgeos: updated my 5.2 build, now unity8 builds correctly13:35
greybackbut doesn't run :)13:35
tsdgeoshe he13:35
mhr3Saviq, btw were you able to get stacktrace from the carousel crash you mentioned?13:42
mterrySaviq, looks like I missed the meeting, sorry.  Had to run to a coffee shop because my internet was down13:44
mterrySaviq, will add notes myself13:44
Saviqmterry, sure, nw13:45
CimiSaviq, cannot reproduce this https://bugs.launchpad.net/unity8/+bug/123410813:59
ubot5Ubuntu bug 1234108 in Unity 8 "Swiping away to dash brings back the app automatically" [Medium,Triaged]13:59
=== dandrader is now known as dandrader|afk
SaviqCimi, https://bugs.launchpad.net/unity8/+bug/1234108/comments/414:00
CimiSaviq, I'm on sf14:00
SaviqCimi, fine, then - mark incomplete if you can't reproduce, although it'd be good to find out why14:00
CimiSaviq, I'll keep debugging14:01
CimiSaviq, one thing is sure14:01
CimiSaviq, if I swipe immediately when the app starts14:01
CimiSaviq, I go back to dash14:01
CimiSaviq, but when the app finishes loading14:01
CimiSaviq, it switches to the app14:01
SaviqCimi, different bug14:02
SaviqCimi, it's filed already - and happens on Mir, too14:02
CimiSaviq, can be fixed on the connection with the application manager14:03
CimiSaviq, that might mean that applicationManager.mainStageFocusedApplication is true14:04
Cimiwhile should be false when you swipe back to dash14:05
Saviqmzanetti, https://code.launchpad.net/~unity-team/unity8/fix-autopilot-touch can be removed, right?14:10
SaviqCimi, it's not that, the app gets focused when it's ready - it switches to focused, but it shouldn't, if you swiped away14:11
CimiSaviq, that's what I mean14:11
CimiSaviq, it should be false14:12
SaviqCimi, it's about it being null, for that matter, but even so - it *is* null when you swipe to dash, but then the app manager signals that the app wants to get the focus - and that's when we're still obeying, even though we should not14:13
SaviqCimi, we knew that already ;)14:13
Saviqgreyback, how about https://code.launchpad.net/~unity-team/unity8/refactor-wm-and-test/+merge/17258314:14
Saviqgreyback, abandoned or still development?14:14
greybackSaviq: working on that now14:14
Saviqgreyback, oh cool14:14
Saviqgreyback, https://code.launchpad.net/~unity-team/unity8/u8m-osk can be dropped, though?14:15
Saviqsame with https://code.launchpad.net/~unity-team/unity8/unity8-integrate-mir14:15
=== dandrader|afk is now known as dandrader
Saviqand https://code.launchpad.net/~unity-team/unity8/unity8-run-mir-plusLinkerFun14:15
greybackSaviq: done14:15
Saviqgreyback, cheers14:15
Saviqgreyback, https://code.launchpad.net/~unity-team/unity8/unity8-integrate-mir still there?14:16
greybackSaviq: yep, there are other branches with MRs up to merge into it, and a build recipe14:16
greybackSaviq: going through them14:16
Saviqgreyback, okies14:16
Saviqmfisch, hey, could https://code.launchpad.net/~mfisch/unity8/unity8-lp1215951 be deleted maybe?14:20
Saviqricmm, hey, could https://code.launchpad.net/~ricmm/unity8/use-volume-key-signals be deleted maybe?14:21
Saviqor marked abandoned?14:21
mfischSaviq: deleted14:21
Saviqsil2100, how about https://code.launchpad.net/~sil2100/unity8/test - delete / mark abandoned?14:21
Saviqmfisch, thanks!14:21
ricmmSaviq: yes14:21
Saviqricmm, thanks14:22
* Saviq likes Autumn clean-ups ;D14:22
Saviqssweeny, could https://code.launchpad.net/~ssweeny/unity8/unity8-lp1215951 be deleted?14:22
ssweenySaviq, yes it's been superseded14:23
Saviqssweeny, cool, could you please delete it?14:23
ssweenySaviq, sure14:23
Saviqssweeny, thanks14:23
ssweenySaviq, no worries14:24
Saviqpstolowski, hey, https://code.launchpad.net/~stolowski/unity8/monitor-network should probably stay, but https://code.launchpad.net/~stolowski/unity8/search-progress-prop ? could be deleted / marked abandoned?14:24
pstolowskiSaviq, right, going to remove the latter14:25
Saviqpstolowski, thanks!14:25
sil2100Saviq: I don't even remember what's this about, so delete I guess14:25
Saviqsil2100, please do :)14:26
Cimimzanetti, we don't have a qml test for that https://code.launchpad.net/~cimi/unity8/fix-1236286/+merge/19239914:27
SaviqCimi, great time to add one! ;)14:27
mzanettiCimi: I think there is one in Shell.qml. but if I'm wrong (which might well be) then yeah, what Saviq said14:27
Saviqtsdgeos, the search entry gets confused with the tabs if you run wide screen (./run -- --fullscreen)14:29
Saviqsomone's back from AMD :D14:31
Saviqtsdgeos, and clipping when overshooting in phone form factor, too14:31
Cimimzanetti, it's a simple one14:31
Cimimzanetti, and it still works with 26 because it's like 30 movement in the test14:32
Cimi(I checked if there was room for a test of it)14:32
Saviqtsdgeos, or maybe just the "fat bar" is confused14:32
tsdgeosSaviq: what do you mean gets confused?14:32
Saviqthe one between the page header and contents14:32
tsdgeosthat's it's whay of hiding14:32
tsdgeosfirst get wide as hell and then hide14:32
Saviqtsdgeos, the search entry? it shouldn't be hiding14:32
Saviqtsdgeos, it should only get wide and hide on screens < 60gu14:33
tsdgeosthat's not how the page header code was14:33
tsdgeosit took into account the length of the label14:33
tsdgeosand it's what the new code also does14:33
Saviqtsdgeos, it only took it into account to know if it should hide or not14:34
=== elopio_ is now known as elopio
Saviqtsdgeos, and it shouldn't take all tab labels into account, just the current one, somehow14:34
Saviqtsdgeos, on tablet it should never move, basically - just expand when you focus it14:34
tsdgeosSaviq: and if you expand it then what?14:34
tsdgeosthey'll overlap14:34
Saviqtsdgeos, it only expands to 60gu or so14:34
Saviqtsdgeos, never more14:34
tsdgeosSaviq: i mean the tab bar14:35
tsdgeosor should it clip ?14:35
Saviqtsdgeos, the tab bar should be reduced to width - textField.width14:35
Saviqtsdgeos, basically, on screens > 60gu, the only movement the search entry should do is expand to 60 gu14:36
=== pete-woods1 is now known as pete-woods
Saviqtsdgeos, or well, yeah if it fits with the label - it should not hide14:37
Saviqtsdgeos, which should not take the whole tab bar into account14:37
tsdgeosSaviq:  can you comment on the review request so i don't forget and whoever reviews next week also has it in mind?14:37
Saviqtsdgeos, yeah will do14:38
mzanettiCimi: add a data() function to it so that it runs twice, once with less than 26, once with more than 2614:39
Cimimzanetti, I'll see what's best14:40
mzanettiCimi: ok14:43
mzanettiCimi: I disapproved one of your other branches :/14:43
mzanettiCimi: https://code.launchpad.net/~unity-team/unity8/fix-1238232/+merge/19142414:44
mzanettiCimi: but I also marked the bug as invalid. so nothing personal to you :D14:46
Cimihah ok14:48
mzanettitsdgeos: you won't believe it. I still didn't apply your patch and today I had 2 crashes: one at 15:28 and one ad 16:4814:49
* tsdgeos leaves for the airport14:56
tsdgeossee you guys on monday14:56
nic-doffaySaviq, there's a black bar overlaying everything, any idea how I can disable this?15:00
Saviqnic-doffay, is it there in unity8 trunk?15:01
nic-doffaySaviq, let me confirm quickly...15:01
mzanettiMacSlow: ping15:09
MacSlowmzanetti, yup15:09
Cimimzanetti, tests updated15:09
mzanettiMacSlow: why would this require autopilot tests? https://code.launchpad.net/~nicolas-doffay/unity8/dismiss-keyboard/+merge/18859915:09
mzanettiCimi: cheers. I'll check it out soon15:09
MacSlowmzanetti, should that not be checked (protected against regressions in the future)?15:11
mzanettiMacSlow: this doesn't use any external processes or anything it communicates with15:12
mzanettiMacSlow: qml test is way to go15:12
MacSlowmzanetti, but isn't the triggering of the keyboard and the entry-field such a case?15:13
MacSlowmzanetti, I admit I don't know the implementation details atm15:14
mzanettiMacSlow: No. I think the OSK should autopilot tests to make sure it comes up with all sorts of textfields15:14
MacSlowmzanetti, ok then15:14
mzanettiMacSlow: but we in this particular case should have a wml test that makes sure we unfocus the textfield15:14
mzanettiwml -> qml15:15
MacSlowmzanetti, want me to update my comment there?15:15
mzanettiMacSlow: I added a comment, feel free to add one yourself if you want15:15
mzanettiMacSlow: added one more comment.15:17
Cimimzanetti, ti odio :D15:18
mzanettiCimi: piacere15:18
Cimimzanetti, praticamente sei passato in ogni mia review e hai aggiunto "test please" :D15:18
mzanettiCimi: sorry... I was assigned to walk through all bugs and check for tests :/15:18
Cimimzanetti, I hoped to get unnoticed15:19
mzanettiCimi: If I wouldn't do it, saviq would do it in 2 weeks15:19
mzanettiCimi: and its not just you. I even unapproved a already approved branch from dednick15:19
Cimimzanetti, I wouldn't test this though https://code.launchpad.net/~cimi/unity8/carousel-music-video/+merge/19211815:19
mzanettiCimi: and am accumulating testing todos for myself too15:19
SaviqCimi, do you need a testing-is-good talk again? ;P15:19
CimiSaviq, I know it's good15:20
CimiSaviq, good doesn't mean fun though :)15:20
mzanettiCimi: https://code.launchpad.net/~cimi/unity8/carousel-music-video/+merge/192118/comments/44306315:22
mzanettiCimi: however, I know that scopes are really badly mocked right now. I would be ok with skipping tests in this one. Given that soon enough we need to do a really big Dash+Scopes Testing+cleanup session15:24
mzanettiCimi: can you please just have a look if you think my comment is feasible right now or not15:25
Cimimzanetti, I already replied15:25
Cimimzanetti, it's on a different branch15:25
mzanettiCimi: damn. I confused it with the other one...15:26
mzanettisorry about that15:26
* mzanetti has seen too many branches in the last 2 hours15:26
Cimimzanetti, even if I hate you now, we're still friends by the way, don't worry :P15:27
CimiSaviq, I hate you too don't be jealous :P15:27
mzanettiCimi: But you know what I mean... we can write tests that at least load the component and check if it at least compiles15:27
* Cimi is joking15:27
* mzanetti => 10 minute break before going crazy15:28
Saviqok, EOW peeps, talk to you next time o/15:43
mzanettiSaviq: bye15:51
Cimiyou here guys? :)15:54
Cimimzanetti, or Saviq :)15:54
mzanettiI am15:54
mzanettiCimi: ^15:54
mzanettiCimi: notice something here? https://code.launchpad.net/~om26er/unity8/search_indicator_dash_only/+merge/19101215:58
Cimimzanetti, missing tests?15:59
mzanettiCimi: you should ask others for tests too. (including me and Saviq)15:59
mzanettiom26er: https://code.launchpad.net/~om26er/unity8/search_indicator_dash_only/+merge/19101216:01
om26ermzanetti, I am on vacation till 5th Nov. but if you give me pointers I'll fully try to write a test for that voluntarily16:02
mzanettiom26er: ah ok. I'll be away for one week starting on the 5th :)16:03
=== dandrader is now known as dandrader|lunch
om26ermzanetti, can you comment on the MR for what needs to be done. I would like to improve my qml testing skills for sure16:03
mzanettiom26er: well, it's quite straigt forward: there is a tests/qmltests/tst_shell.qml. Just add a new function in there, and do whatever you'd do in autopilot too. instead of select_single() etc you can use findChild()16:04
mzanettiom26er: the rest is the same, except it's easier in qml ;)16:04
mzanettithere is compare() just like Equals() and tryCompare() instead of Eventually(Equals())16:05
mzanettiom26er: ^16:05
om26ermzanetti, ok, I am *trying* to fix a bug in the terminal app on the phone, once I am done with that. I'll pick this one16:06
mzanettiom26er: feel free to ping me for help anytime16:06
om26ermzanetti, sure will do. Thanks :)16:06
mzanettiom26er: heh, found this. looks like its not that new for you after all :) https://code.launchpad.net/~om26er/unity8/fix_1238837/+merge/19074316:10
om26ermzanetti, yep, that was like my first qml test.16:10
mzanettiom26er: ok. because you said that I read through it and I think I spotted a problem16:11
mzanettior better a weakness16:11
mzanettiom26er: the test_clickTileNotClose() clicks on it and *immediately* checks if if the tile is still here16:12
om26ermzanetti, ah? what's that ?16:12
mzanettiom26er: while most likely it would take a couple of ms to actually close the app16:12
mzanettiand this test wouldn't notice16:12
om26ermzanetti, we are verifying that twice, first we make sure the running app is not in the model and only then check if the tile has finally vanished16:14
mzanettiyeah. but if there is one async operation in closing the app both checks would run before16:15
mzanettiom26er: as we're using mocks, most likely everything in the backend is syncronous. But remember, an autopilot test like this woule *never* fail even though the app would be closed when clicking on the tile16:16
om26ermzanetti, I have a hard time understanding that, do you mean we need an autopilot test for that or telling me qmltests are better ? :D16:20
mzanettiom26er: neither of that. actually scratch the autopilot comment16:21
mzanettiom26er: what I meant is that both, qmltests and autopilot tests are not really useful if written in such a way16:22
mzanettiom26er: as it's really easy to break the code without getting noticed by the test16:22
om26ermzanetti, in autopilot I would really make sure that the tile disappeared and the number of tiles previously and now is different16:23
mzanettiom26er: yeah that's the thing. this test checks if the number is still the same as before, and it does that immediately16:24
mzanettiom26er: so if the number of tiles changes a few milliseconds later, for example because of an async operation somewhere in the code, the test checks have already ra16:24
mzanettiand after the test passed the tile goes away16:24
om26ermzanetti, is there something like "Eventually" here ?16:25
mzanettiom26er: unfortunately not really16:25
mzanettiom26er: one of the rare cases where we allow to use wait() in qmltests16:25
om26ermzanetti, does that take a time parameter or it has its own timeout ?16:26
mzanettiom26er: because with wait(0) you trigger the event loop without really sleeping. so the test would still catch single async operations. still not ideal, I agree16:26
mzanettiom26er: wait(milliseconds)16:26
mzanettiwhereas 0 has the special meaning of triggering the event loop and continue _at the end_ of the scheduled things in the next event loop run16:27
mzanettisee QTimer docs for that16:28
om26ermzanetti, ack. I'll update this one, and add a new test for the other branch16:33
mzanettiom26er: thanks16:33
=== alan_g is now known as alan_g|EOD
=== dandrader|lunch is now known as dandrader
=== dandrader is now known as dandrader|afk
=== dandrader|afk is now known as dandrader
=== kdub is now known as kdub^lunch
=== salem_ is now known as _salem
=== kdub^lunch is now known as kdub

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!