| === gary_poster is now known as gary_poster|away | ||
| === gary_poster|away is now known as gary_poster | ||
| * gary_poster back in a few | 12:55 | |
| bac | jujugui: i'm currently unable to get my canonical email. use fn.ln@gmail.com if you need to send me something before it is resolved. | 13:16 |
|---|---|---|
| gary_poster | ack | 13:16 |
| rick_h_ | bac: rgr | 13:17 |
| benji | bac: hi, I am assigned to the change log in GUI card, but since I'm not sitting next to you at the moment, I don't know how to contribute ;) | 13:17 |
| bac | benji: yeah, i should take your face off and continue with it. just a matter of resolving the data differences between charms and bundles. shouldn't take long. | 13:18 |
| benji | sounds good | 13:18 |
| benji | I've never filed mileage to the airport, but it is over 100 miles round-trip; do we do milage? | 13:19 |
| bac | what's the alternative? just eating it? | 13:19 |
| gary_poster | yes benji, pretty sure. check company handbook, or ask your manager to do so ;-) | 13:19 |
| benji | heh | 13:19 |
| hatch | morning | 13:27 |
| Makyo | Hey | 13:28 |
| rick_h_ | hatch: morning | 13:28 |
| hatch | I also couldn't access my email :/ | 13:28 |
| Makyo | Can you get to it through the gmail interface? | 13:29 |
| hatch | it appears to be back up now | 13:29 |
| hatch | it wouldn't accept the pw for a bit there | 13:29 |
| bac | gary_poster: expenses filed. can you confirm receipt of email? | 13:29 |
| bac | hatch: that's what i'm seeing. mine i think is self-inflicted due to my inability not to fiddle with shiny new bits, i.e. icloud keychain. | 13:30 |
| hatch | ahh | 13:30 |
| gary_poster | bac I got receipts, yes. 509KB and 435 KB. Need me to actually look at them? :-) | 13:30 |
| bac | gary_poster: nope | 13:30 |
| gary_poster | cool | 13:31 |
| bac | gary_poster: just confirms canonical smtp is working for me just not imap | 13:31 |
| gary_poster | ah, gotcha | 13:31 |
| bac | we made the mistake of trying san juan's best chinese restaurant last night. big mistake so soon after SFO. | 13:32 |
| Makyo | I had so much Szechuan food out there. It was heaven. | 13:34 |
| rick_h_ | bah, just chased down a 'bug' in my branch that fails on comingsoon. Doh! | 13:52 |
| gary_poster | bac why no Friday Burlingame dinner in expenses? | 13:58 |
| bac | gary_poster: i was invited to be jc for the day for the orange team dinner. curtis paid. | 13:59 |
| gary_poster | bac oh cool | 13:59 |
| hatch | lol | 13:59 |
| Makyo | An honor! | 13:59 |
| bac | we went to a cool beer cellar | 13:59 |
| gary_poster | ok, I've approved everyone's canonicaladmin things (except a couple of 2014 things from hatch because I want to make sure we get those handled correctly with HR) | 14:01 |
| hatch | kewl | 14:01 |
| gary_poster | rick_h_, are you already reviewing huw's bundle o' branches? | 14:01 |
| hatch | if not I can | 14:01 |
| gary_poster | and antdillon's? | 14:01 |
| bac | great. gary_poster i've still got a few days of vacation that aren't set. i'll try to figure that out soonish. | 14:01 |
| gary_poster | I am on call now | 14:01 |
| gary_poster | so if anyone can take them that would be great | 14:02 |
| hatch | I'll take them all | 14:02 |
| hatch | gimme gimme gimmee | 14:02 |
| rick_h_ | gary_poster: no, I've been tryingto wrap up my 'quick' make deploy work from quicksearch atm | 14:02 |
| gary_poster | cool | 14:02 |
| hatch | my ubuntu vm being broken is really irritating :/ | 14:02 |
| rick_h_ | hatch: you cheating punk... | 14:05 |
| hatch | what did I do now? | 14:05 |
| rick_h_ | I've spent the last 2 hours trying to figure out how your bundle details view event freaking works | 14:05 |
| rick_h_ | because it seems like it shouldn't based on everything in bundle.js, quicksearch, etc. | 14:06 |
| rick_h_ | which is why you can't click a bundle in quicksearch and get it to open the details view | 14:06 |
| rick_h_ | finally figure out how you got it to work from the results page | 14:06 |
| hatch | oh yeah? how was that? | 14:07 |
| rick_h_ | hard coding a 'charmid' in the bundle handlebars to be '/bundle/{{id}}' | 14:08 |
| rick_h_ | so as long as you're dealing with something handling the token click event it 'works' by pretending to be a charm | 14:08 |
| hatch | so...You're saying I did it properly but that's not the way it's designed to work? :P | 14:09 |
| rick_h_ | I'm saying you cheated | 14:09 |
| hatch | antdillon: you will have to run the tests on yoru branch | 14:09 |
| hatch | there are quite a number of failures | 14:10 |
| rick_h_ | rather than make things support the idea of a 'bundle' you pretended to be a charm in one case you needed to work :P | 14:10 |
| hatch | ohh right right - I actually have a note here that says 'change browser charmid to entityid' | 14:10 |
| rick_h_ | heh, I just added a very similiar note | 14:11 |
| hatch | see this is really your fault....you should have KNOWN we were going to introduce bundles 6mo into the future and designed it to support that | 14:12 |
| * hatch runs | 14:12 | |
| rick_h_ | hatch: come back here, I still can't get a bundle deploy to work | 14:13 |
| rick_h_ | hatch: let me know if you have a sec to chat | 14:13 |
| antdillon | hatch, Huh, fails? OK will check it out | 14:13 |
| hatch | lol | 14:13 |
| hatch | rick_h_: I meant I was running away from you swinging at me for that comment :) | 14:13 |
| rick_h_ | antdillon: it's ok, hatch's machine just probably timed out and had to take a breather from all the work | 14:13 |
| hatch | lol | 14:13 |
| antdillon | rick_h_, He's getting a new one soon | 14:14 |
| rick_h_ | hatch: yea, I know. now come back and tell me how the ##$@# bundle deploy is supposed to work | 14:14 |
| hatch | rick_h_: so bundle deploy doesn't work? | 14:14 |
| hatch | unos momentos capitanos | 14:14 |
| rick_h_ | hatch: I'm trying to call it from a different place and it's failing on me in a confusing way | 14:14 |
| hatch | rick_h_: the subapps/browser/views/bundle.js listens for a click on .bundle .add and then calls _deployBundle | 14:15 |
| rick_h_ | hatch: yea, ignore me. Stupid mistake I think. /me reloads | 14:15 |
| rick_h_ | hatch: yea, got it called, now it's a real bundle failed error. All good | 14:16 |
| * rick_h_ has a lot of freaknig tests to write around this | 14:17 | |
| hatch | is this the deploy from the autocomplete? | 14:18 |
| rick_h_ | hatch: yea | 14:18 |
| hatch | you sure there is a lot? A bunch of it is tested already | 14:19 |
| rick_h_ | hatch: but yea, this is why the quicksearch results didn't close for you, there was an error | 14:19 |
| hatch | ohh | 14:19 |
| hatch | does this also fix the timeout issue? | 14:19 |
| hatch | where the ac pops open after a search if it's slow to return results? | 14:19 |
| rick_h_ | hatch: yea, I've got to do a bunch of conditional checks in there for bundle vs charm, firing the right deploy event, the views listening for that and handling a deploy correctly | 14:19 |
| rick_h_ | hatch: no, where when you hit enter or something it fails to close. It's trying to process the selection as a 'charm' but fails | 14:20 |
| hatch | ahh | 14:20 |
| hatch | odd there was no console error | 14:20 |
| rick_h_ | #1237457 I think | 14:21 |
| _mup_ | Bug #1237457: Hitting enter quickly in autocomplete causing result list to appear over real results <juju-gui:Triaged> <https://launchpad.net/bugs/1237457> | 14:21 |
| hatch | yeah that's the one | 14:21 |
| rick_h_ | bah, or not. It's the results coming back too long afterwards, nvm | 14:21 |
| rick_h_ | ok, well anyway, carry on. Thanks | 14:22 |
| hatch | :) | 14:22 |
| hatch | antdillon: fyi - now that I'm back on my big monitor the white space has returned on the footer of the fullscreen view - is there anyone there with a big high res monitor you can test this out on? | 14:26 |
| hatch | if not one of us can I'm sure | 14:26 |
| Makyo | Switching computers, back in a sec. | 14:28 |
| benji | here's an article on the rebase/merge decision when using git: http://blogs.atlassian.com/2013/10/git-team-workflows-merge-or-rebase/ | 14:29 |
| benji | I can't say I fully appreciate all of the points, but if we are going to start using git we'll need to figure this stuff out. | 14:29 |
| antdillon | hatch, Yep, I'll find the biggest I can find ... will have a fix in soon | 14:29 |
| Makyo | benji: hatch, rick_h_ and I started this discussion last week. We're leaning toward rebase. | 14:30 |
| hatch | haha thanks :) | 14:30 |
| hatch | +1 for rebase (hoping there is some type of 'auto-rebase') we can use | 14:30 |
| Makyo | They're leaning toward rebase. I hate rebase, but given that it's basically just a personal preference, meh, will go with whatever :) | 14:30 |
| rick_h_ | benji: +1 it's a long debated topic. | 14:31 |
| hatch | yeah - it needs the collapse functionality of bzr :) | 14:31 |
| benji | not knowing much about it, rebase sounds like a reasonable default | 14:31 |
| rick_h_ | benji: imo the rebase is good, but that's part of the win for the master vs develop branch. master is very clean, develop has more noise. | 14:31 |
| rick_h_ | benji: the real goal is to keep git biset a useful and meaningful tool | 14:32 |
| hatch | right - bisect friggen rocks | 14:33 |
| hatch | although as long as someone rebases 'checkpoint' commits and only commits logical ones I'd be happy with that too | 14:34 |
| hatch | just don't want broken commits in the shared branch | 14:34 |
| rick_h_ | hatch: yea, won't have that. You rebase in the branch merged to usually. Though what that means for landing branches is still tbd | 14:35 |
| Makyo | Well, no one does :P | 14:35 |
| hatch | rick_h_: sorry I have no idea what you were trying to say there :D | 14:35 |
| rick_h_ | hatch: so typically the process is "do work in my feature branch...get things working, qa'd, etc" | 14:36 |
| rick_h_ | hatch: then you git co develop, git merge feature, git rebase -i all that feature crap | 14:36 |
| rick_h_ | hatch: then git push origin develop | 14:36 |
| rick_h_ | so your feature branch is still a non-rebased mess, but develop is cleaned before pushing | 14:36 |
| rick_h_ | so no broken commits anywhere | 14:36 |
| hatch | git co ? | 14:37 |
| rick_h_ | hatch: but if the lander is doing the merge into develop, will have to figure that out | 14:37 |
| rick_h_ | git checkout | 14:37 |
| hatch | ahh | 14:37 |
| rick_h_ | don't you use aliases for things or do you just love typing? | 14:37 |
| hatch | love typing | 14:37 |
| hatch | lol | 14:37 |
| Makyo | Me too :) | 14:37 |
| hatch | I only alias long statements, not commands | 14:37 |
| rick_h_ | http://paste.mitechie.com/show/1051/ | 14:37 |
| rick_h_ | alias the $#$@ out of everything. makes it nice to sync aliases between bzr/git as well | 14:38 |
| hatch | rick_h_: I like that - my only concern with that is that the dev could accidentilly rebase away others commits | 14:38 |
| Makyo | We could sync with master if that happens, right? | 14:39 |
| hatch | as long as you don't use -f | 14:39 |
| Makyo | -f: not even once | 14:39 |
| rick_h_ | we'll see. if merging to develop is automated it shouldn't be an issue | 14:39 |
| hatch | ohh ok I see what you're doing | 14:39 |
| rick_h_ | just repeat after me, nothing is ever lost, the reflog is my friend :) | 14:40 |
| hatch | error: Pre-requisite lp:~huwshimi/juju-gui/remove-old-inspector-styles not yet merged. | 14:40 |
| hatch | hehe oh lbox u so smrt | 14:40 |
| hatch | not sure how it knows that | 14:41 |
| rick_h_ | https://code.launchpad.net/~huwshimi/juju-gui/more-css-removal/+merge/193002 " | 14:42 |
| rick_h_ | hatch: see the prerequisite field | 14:42 |
| hatch | oh cool!! | 14:43 |
| hatch | I like the new loading dialog | 14:43 |
| hatch | (on the gui) | 14:43 |
| hatch | shadowrun is 33% off today http://store.steampowered.com/app/234650 | 14:45 |
| Makyo | jujugui call in 10 | 14:50 |
| hatch | 2013/10/29 08:51:09 RIETVELD Failed to process response: server returned "403 Forbidden" | 14:51 |
| hatch | best message to see after spending 5minutes submitting | 14:52 |
| Makyo | You can still merge on Launchpad, though, right? | 14:52 |
| hatch | I could I suppose - it did pass lint and both tests | 14:52 |
| Makyo | Yeah. | 14:53 |
| Makyo | jujugui call in 2 | 14:58 |
| bac | jujugui: i can not read my canonical email again. fire away. | 15:14 |
| hazmat | bac, you mean s/not// ? | 15:14 |
| bac | yes, s/not// | 15:15 |
| antdillon | hatch, I have a fix for the white bar in browse: lp:~ya-bo-ng/juju-gui/white-bar-fix | 15:28 |
| antdillon | hatch, Your screen must be huge! | 15:28 |
| hatch | antdillon: 31" 2560x1600 | 15:29 |
| hatch | so yes | 15:29 |
| hatch | lol | 15:29 |
| hatch | and thank you very much :D | 15:29 |
| bac | darn, i was thinking my internet was working so much better | 15:30 |
| gary_poster | hatch, I think "bundle charm token click through works when it shouldn't until the events are updated" might be fixed, from me trying to dupe. Do you know anything about it? | 15:32 |
| hatch | gary_poster: it always did work | 15:33 |
| hatch | it shouldn't work | 15:33 |
| hatch | that's the bug :D | 15:33 |
| hatch | well | 15:33 |
| hatch | unless someone fixed it | 15:33 |
| hatch | which is entirely possible I guess | 15:33 |
| gary_poster | hatch, oh ok. could you come by https://plus.google.com/hangouts/_/calendar/Z2FyeS5wb3N0ZXJAY2Fub25pY2FsLmNvbQ.j0rk5d371ph8331ijtf48t2uj0 really quickly for higher bandwidth? | 15:33 |
| rick_h_ | hatch: there was some cleanup during the sprint with ant's and huw's branches I helped work ok that might have fixed it | 15:33 |
| hatch | oh awesome | 15:34 |
| rick_h_ | hatch: but didn't think to test it...so no promises | 15:34 |
| hatch | +1 | 15:34 |
| antdillon | hatch, Did you manage to sort out your comp yesterday? | 15:38 |
| hatch | antdillon: nope just using my VM as if it's a server atm | 15:38 |
| antdillon | hatch, Ouch | 15:39 |
| antdillon | hatch, need that new comp sooner then you thought | 15:39 |
| antdillon | hatch, Give me a shout if you find anything wrong with the linkify branch | 15:40 |
| hatch | sure thing - it looks good, will just need to QA | 15:40 |
| hatch | antdillon: one pedantic thing I -could- say is to use more descriptive function names | 15:41 |
| hatch | but linkify is close enough :D | 15:42 |
| antdillon | hatch, I spent more time on trying to pick a name for the function then I did in the function :/ | 15:42 |
| hatch | rofl - it happens | 15:42 |
| gary_poster | benji, first priority for you is helping rick_h_ on charmworld proof code. If rick_h_ has something you can tackle, great. If not, please tackle the charmworld metrics story. We can launch without that, but if we have it, it would be fantastic. | 15:43 |
| benji | gary_poster: sounds good (I'll clarify the details of charmworld metrics once I get there) | 15:44 |
| rick_h_ | gary_poster: benji if benji wants to get at the relation proof bits it's open. Otherwise the metrics is greenfield fun | 15:45 |
| gary_poster | benji, rick_h_ I'll leave it to you two to discuss and decide if benji can take over productively. That's our highest priority remaining. If you want me to participate in a call I'm happy to. | 15:46 |
| gary_poster | (But more than happy to leave you two to decide) | 15:46 |
| gary_poster | benji, for metrics, ack on details. cards exist at least, thanks to sprint discussions | 15:47 |
| benji | gary_poster: this charmworld bug will be quick and then Rick and I (and maybe you) will get on proof stuff | 15:47 |
| rick_h_ | gary_poster: benji one other thing that might come up is there's a charm someone ping'd about in irc yesterday not getting updated. It had a proof error, but had another partial update looking case. | 15:48 |
| gary_poster | perfect thanks | 15:48 |
| gary_poster | k | 15:48 |
| hatch | jcsackett: jcastro I'd like to get the Ghost charm in the store today/tomorrow - what's the git > lp story? | 15:51 |
| hatch | antdillon: did you say you updated your linkify branch to fix the test failures? | 15:52 |
| hatch | I don't see any new revisions | 15:52 |
| antdillon | hatch, Running tests now, is it not due to the bundle stuff? | 15:55 |
| hatch | no idea, I just saw the failures and moved on, sorry :) | 15:55 |
| antdillon | hatch, No prob, on it | 15:56 |
| hatch | from now on because you can't lbox you can just run this command `make lint && make test-debug && make test-prod` | 15:56 |
| hatch | before you push | 15:56 |
| hatch | it'll take a long time but avoid this in the future | 15:56 |
| antdillon | hatch, Cool, I've been testing and lint before pushing but must have missed something sorry | 15:57 |
| hatch | no problem | 15:57 |
| hatch | I'm still baffled by your lbox issues | 15:58 |
| hatch | gary_poster: I haven't read it yet but here is the review for the new mbp from engadget http://www.engadget.com/2013/10/29/macbook-pro-with-retina-display-review-13-inch-2013 | 16:03 |
| gary_poster | hatch, cool. I want anandtech to do it :-) | 16:09 |
| hatch | oh yeah I always forget about them | 16:09 |
| hatch | the interesting bit about this review from just glancing at it is that it's not that much more performant considering it has almost double the clock speed | 16:10 |
| hatch | than the air | 16:11 |
| rick_h_ | haswell != perf increase. When they released it haswell asctually tested 3-5% slower in most benchmarks. You just get a really nice battery usage/temp decrease | 16:11 |
| gary_poster | sure but he was comparing to air | 16:12 |
| gary_poster | apples to apples, as har as haswell is concerned | 16:12 |
| gary_poster | far | 16:12 |
| rick_h_ | oh, doh | 16:13 |
| hatch | yeah - I mean, there is an improvement, just not the jump I was expecting from such a dramatic clock speed difference | 16:16 |
| rick_h_ | yea, I wonder if the pro got the pcie upgrade? I mean that number is based off a mix of IO/etc I'm sure. Curious if something else held back the new pro vs the air | 16:17 |
| hatch | yeah - it'll be interesting to see the 15" because I remember some mumbling about the io pipeline being awesome on the 15s | 16:18 |
| gary_poster | benji, fwiw +1 to curtis suggestion that this returm the newest, not puke | 16:22 |
| benji | gary_poster: k | 16:22 |
| gary_poster | hatch, rick_h_ are one of you already handling https://code.launchpad.net/~ya-bo-ng/juju-gui/linkify-charm-descriptions/+merge/192852 ? | 16:25 |
| hatch | gary_poster: I am | 16:25 |
| hatch | tests fail so he is working on that | 16:25 |
| gary_poster | cool thanks | 16:25 |
| gary_poster | oh k | 16:25 |
| hatch | jujugui does anyone know if a bug has been filed with core about being unable to deploy the gui in lxc? | 16:31 |
| hazmat | hatch, what's the issue with that? | 16:32 |
| hatch | apt-get throws an error | 16:32 |
| rick_h_ | hatch: does it not work? /me did some core stuff this weekend ok in lxc | 16:32 |
| hazmat | hatch, pastebin? | 16:32 |
| hatch | I'll have to spin up a new instance | 16:32 |
| hatch | I'll get that going in the bg and report back | 16:32 |
| hazmat | hatch, cool, i'm doing the same to compare notes with | 16:33 |
| hatch | my core testing box is 12.04 so I'll make sure to do an update first | 16:33 |
| rick_h_ | hatch: working here in my lxc | 16:35 |
| hatch | rick_h_: what versions? | 16:35 |
| rick_h_ | http://paste.mitechie.com/show/1057/ hatch | 16:36 |
| rick_h_ | hatch: so this is on my desktop still on raring | 16:37 |
| hatch | cool thanks, just running deploy gui now | 16:37 |
| rick_h_ | hatch: I had that issue pre-sprints but after updates all was fine this weekend. Figured it was updated | 16:38 |
| hatch | ahh ok cool maybe the updates fixed it | 16:38 |
| hatch | I hope so, I need to demo this at a conf next week haha | 16:38 |
| hatch | rick_h_: looks like it works | 16:44 |
| hatch | now | 16:44 |
| hatch | hazmat: ^ | 16:44 |
| rick_h_ | hatch cool | 16:44 |
| jcastro | hey abentley | 16:55 |
| jcastro | how about tarmac as a config option in our jenkins charms? | 16:55 |
| jcastro | or is that dumb? | 16:55 |
| * Makyo steps out | 16:59 | |
| hatch | it would be awesome if there was a `juju ssh-tunnel <machine>` command :) | 17:01 |
| hazmat | hatch, cool | 17:02 |
| hatch | hazmat: what do you think of that command idea? | 17:02 |
| hazmat | hatch, well.. we can already do juju ssh unit|machine command | 17:03 |
| hazmat | hatch, ideally the tunnel is just done automatically for you where client doesn't have direct access | 17:03 |
| hazmat | hatch, worth filing a bug that juju ssh should tunnel automatically to reach destination | 17:03 |
| hatch | right, so I have a extra box which I run my juju-core stuff but from my desktop I cannot access the ip of the machines directly so that I can view thing slike the gui without creating a tunnel | 17:03 |
| hazmat | hatch, oh.. you mean construct a tunnel.. sorry | 17:04 |
| hazmat | thought you mean tunnel through a bastion to ssh run a command on unit | 17:04 |
| hatch | ohh no | 17:04 |
| hatch | :) | 17:04 |
| hatch | so now with that in mind....what do you think of the idea? :D | 17:05 |
| hazmat | hatch, so that should already be possible. ala juju ssh juju-gui/0 -L8081:127.0.0.1:443 | 17:05 |
| hazmat | additional params on that line should be passed through | 17:05 |
| hatch | oh cool | 17:05 |
| hatch | I didn't know that | 17:05 |
| hatch | I'll try | 17:05 |
| hatch | oh I destroyed the env already | 17:06 |
| hatch | I'll try later I guess :D | 17:06 |
| hazmat | hatch, that's not really what you want though.. although it works, really it sounds like you want a iptables port forward from host to container (ie. avoid ssh tunnel overhead) | 17:07 |
| hazmat | hatch, incidentally that syntax worked for me | 17:07 |
| hatch | yeah, I know that juju shoudln't be concerned about the firewall stuff | 17:08 |
| hatch | so thats why I was thinking some kind of convenience method | 17:08 |
| hatch | but your approach there sounds reasonable | 17:09 |
| abentley | jcastro: I don't know what that would mean. What would such a config option do? | 17:23 |
| jcastro | "tarmacify this jenkins"? | 17:23 |
| abentley | jcastro: There's not much integration between jenkins and Tarmac AIUI. It's just a way you can configure a job. So installing the tarmac package and configuring the job would be enough, without having a specific config. | 17:26 |
| jcastro | yeah I was thinking the config option would be the job configuration | 17:26 |
| * jcastro shrugs | 17:26 | |
| hatch | jcastro: did you see my msg earlier about the story of getting my ghost charm from github to lp? | 17:28 |
| abentley | jcastro: It's possible, but that would only give you a single job, and potentially the config would be pretty long to specify all the other job options. | 17:28 |
| jcastro | hatch, no, tell me! | 17:28 |
| abentley | jcastro: I've thought of providing jobs as subordinate charms. | 17:28 |
| hatch | jcastro: well what am I supposed to do? just check it out locally and push to lp? or do you have a tool/procedure for this? | 17:29 |
| jcastro | hatch, we don't have anything automated afaict | 17:29 |
| abentley | jcastro: We're kind of hamstrung by the fact that juju doesn't support complex configuration options (i.e. dicts and lists), and subordinates is a way to work around that. | 17:29 |
| jcastro | I know orange squad is/was going to work on the github workflow? | 17:29 |
| jcastro | abentley, yeah, I was just tossing it out as an idea | 17:30 |
| hatch | jcastro: ok cool I'll just do it manually then tonight | 17:30 |
| abentley | jcastro, hatch: jcsackett was working on that, but he's away this week. | 17:30 |
| jcastro | hatch, yeah! | 17:31 |
| jcastro | hatch, let's shoot for "working well enough to get noticed on the upstream forum" | 17:31 |
| hatch | the only thing it's missing is the http interface because I haven't had enough time to do it yet | 17:31 |
| hatch | but thanks to your qa we know that the mysql interface works well :) | 17:32 |
| hatch | bac: benji do you know what the command is to deploy a bundle from the juju command line? | 17:33 |
| bac | juju-deployer | 17:33 |
| bac | hatch: you need to get lp:juju-deployer or 'pip install juju-deployer'. benji is the pip version up-to-date? | 17:34 |
| hatch | thanks | 17:34 |
| hatch | hmm | 17:34 |
| hatch | ok maybe I'll leave that out of the GUI then | 17:34 |
| hatch | basically I'm adding a 'deploy' tab to the bundles page | 17:35 |
| hatch | nah it should be there | 17:35 |
| bac | hatch: you might find this useful: models.loadRecentCommits = function(revisions) { | 17:35 |
| bac | var commits = []; | 17:35 |
| bac | if (revisions) { | 17:35 |
| bac | Y.Array.each(revisions, function(commit) { | 17:35 |
| bac | commits.push({ | 17:35 |
| bac | author: { | 17:35 |
| bac | name: commit.authors[0].name, | 17:35 |
| bac | email: commit.authors[0].email | 17:35 |
| bac | }, | 17:35 |
| bac | date: new Date(commit.date), | 17:35 |
| bac | message: commit.message, | 17:35 |
| bac | revno: commit.revno | 17:35 |
| bac | }); | 17:35 |
| bac | }); | 17:35 |
| hatch | deploy by gui, deploy by quickstart, deploy by deployer | 17:35 |
| bac | hatch: this: https://docs.google.com/a/canonical.com/document/d/1paE70HEVgKA6LIjngzMa83OYr5jkZrOJ0hVNrYUuva0/edit#heading=h.rmx4dpm78c5i | 17:35 |
| hatch | ahh cool thanks | 17:36 |
| rick_h_ | woot! reading source code ftw. I'm a cheating cheater | 17:43 |
| benji | bac: sorry, I was at lunch; I don't know if the deployer is on pypi or if it is up to date | 18:23 |
| hatch | rick_h_: I'll take the review | 18:25 |
| rick_h_ | hatch: k, doing review comments now | 18:26 |
| hatch | oh ok cool I'll wait then | 18:26 |
| hatch | huw goes and removes lines of code and you go adding them all back in :P | 18:26 |
| rick_h_ | ying/yang :P | 18:27 |
| hatch | haha | 18:28 |
| rick_h_ | hatch: ok, have fun with the review | 18:32 |
| hatch | will do | 18:32 |
| rick_h_ | jujugui need another review please. I'll bug hatch to QA it. https://codereview.appspot.com/18920045/ | 18:32 |
| gary_poster | on it rick_h_ | 18:33 |
| rick_h_ | gary_poster: ty much | 18:33 |
| hatch | rick_h_: do you have a second to discuss a different approach to the monkeypatch? | 18:46 |
| rick_h_ | hatch: sure thing | 18:46 |
| hatch | https://plus.google.com/hangouts/_/calendar/Z2FyeS5wb3N0ZXJAY2Fub25pY2FsLmNvbQ.j0rk5d371ph8331ijtf48t2uj0?authuser=1 | 18:47 |
| rick_h_ | hatch: I'm an evil evil man bwuhahahaha | 18:54 |
| hatch | lol what now | 18:54 |
| rick_h_ | hatch: no, just that you want to find a better way, but I'm so evil doing things you can't | 18:54 |
| hatch | haha | 18:55 |
| * hatch resists offering 'well I would do it this way' comments | 18:57 | |
| hatch | :D | 18:57 |
| rick_h_ | hatch: they're legit. I'm open to new ideas as long as I get to ignore the ones I don't like :P | 18:57 |
| hatch | haha - nah they are dumb | 18:58 |
| gary_poster | rick_h_, I made some suggestions but fundamentally LGTM. Thank you! | 19:11 |
| rick_h_ | gary_poster: cool thanks for the look through | 19:12 |
| gary_poster | welcome | 19:12 |
| hatch | rick_h_: code review done - doing qa now | 19:22 |
| hatch | oh man I love how fast the sprite generation is now :D | 19:23 |
| hatch | rick_h_: so is the little dinky + button from design? | 19:24 |
| hatch | no [Deploy] button? :D | 19:24 |
| rick_h_ | hatch: yes | 19:27 |
| hatch | Booo | 19:27 |
| rick_h_ | hatch: it's straight from them, asked for one during sprints and got this | 19:27 |
| hatch | ok read my comments and lemme know if you want to discuss | 19:27 |
| rick_h_ | hatch: yea, figure they'll update once they see it, but figured it'll do until it's on comingsoon | 19:27 |
| rick_h_ | hatch: ok, you and gary_poster agree on the multiple so I'll back that out. Ugh for subclassing AC, but I can see the point since it's getting complex. It'll be nice because I can name it quicksearch or something as well, though it'll make the diff bigger | 19:29 |
| rick_h_ | hatch: nothing shuts down pending AC requests. It's a pure 'hide the list of suggestions' move. The tracking/killing AC requests in-flight will have to be a feature of the new widget since I don't think AC does it on its own | 19:30 |
| hatch | ahh gotcha | 19:30 |
| hatch | and I'm glad you agree on the subclassing :) | 19:30 |
| hatch | ok I'll LGTM pending that change then...cool? | 19:30 |
| rick_h_ | hatch: kinda :P | 19:30 |
| hatch | haha - well you agree it's the right thing to do....:P | 19:31 |
| rick_h_ | hatch: I feel that the new widget is a follow up branch? It'll be it's own diff, splitting tests, creating new file, etc | 19:31 |
| hatch | ok sounds good - just make a card so it doesn't get lost :) | 19:31 |
| hatch | lgtm'ing | 19:31 |
| rick_h_ | hatch: yea, I thought about it, but seemed like a lot of work for the 'three lines' duped so avoided it | 19:31 |
| hatch | lgtm'd | 19:32 |
| rick_h_ | thanks, will garden up the small stuff. New card added. | 19:33 |
| hatch | I'm so glad I can deploy the gui in a lxc again, I was worried I woudln't be able to demo it next week | 19:33 |
| gary_poster | benji, did #1229179 turn out to be bigger than we had hoped? | 19:34 |
| _mup_ | Bug #1229179: Revisionless bundle requests raise ValueError <oops> <charmworld:Triaged> <https://launchpad.net/bugs/1229179> | 19:34 |
| benji | gary_poster: not really, finishing writting a comment in the test now and it'll be submitted | 19:35 |
| hatch | is there documentation for the quickstart? I can't seem to find any on the drive | 19:35 |
| gary_poster | awesome benji. | 19:35 |
| gary_poster | hatch, no, one sec. | 19:36 |
| hatch | gary_poster: thanks | 19:37 |
| gary_poster | hatch: note that quickstart is in beta when you write docs. Steps are as follows. 1) install quickstart: sudo add-apt-repository ppa:juju-gui/quickstart-beta && sudo apt-get update && sudo apt-get install juju-quickstart | 19:40 |
| gary_poster | 2) juju quickstart [the same URL as used by deployer] | 19:41 |
| gary_poster | hatch, step 2 currently only works with files, not URLs, but frankban will be adding tomorrow, and should be trivial | 19:41 |
| hatch | ok awesome - so any updates to the deployer/quickstart we'll have to make sure we update the bundle deploy docs page | 19:42 |
| gary_poster | hatch ack. I guess you could say "there is no step 3": you simply wait for the GUI to launch, and after you type in the password, you will see that the GUI shows the bundle being deployed. Also, fwiw: | 19:43 |
| gary_poster | hatch, I don't think you need this, but http://pastebin.ubuntu.com/6325901/ | 19:44 |
| hatch | thanks | 19:44 |
| gary_poster | welcome | 19:44 |
| gary_poster | rick_h_, does "Reject bundles with cs: urls and charm key in services section" need to be done before we are done with proof work? I don't quite understand what it i means, so if we need to do it, we should make sure I'm following along. :-) | 20:03 |
| hatch | I feel like this install guide is missing some steps at the start http://bazaar.launchpad.net/~juju-deployers/juju-deployer/trunk/view/head:/README | 20:14 |
| bac | jujugui: any reason why we use this date format for charm/bundle change logs: 28/Aug/13 Brad Crittenden Added README and icon - REVNO2 | 20:14 |
| bac | as opposed to 2013-08-28 | 20:14 |
| benji | because we hate everyone? | 20:14 |
| gary_poster | bah | 20:14 |
| hatch | lol | 20:15 |
| bac | gary_poster: bah means what? | 20:15 |
| bac | gary_poster: does that mean you'll complain when i fix it? | 20:15 |
| gary_poster | I don't know why we do it that way, but as person familiar with computers, I prefer 2013-08-28, but I wonder if 28/Aug/13 is more friendly to others. "bah" means I don't think it is associated with hating everyone. :-P | 20:16 |
| gary_poster | bac, I'm ok with change if you are excited about it. I don't think it is an obvious win, myself, is all, despite the usual discussions. | 20:18 |
| hatch | 08-28-2013 ? | 20:18 |
| hatch | :P | 20:18 |
| hatch | 28-08-2013 | 20:18 |
| Makyo | 2013-08-28 because then it sorts :oP | 20:18 |
| bac | gary_poster: i'm in there | 20:18 |
| gary_poster | no, the format bac gave is the ISO one IITC | 20:18 |
| gary_poster | IIRC | 20:18 |
| hatch | right :) I was just being an ass | 20:18 |
| gary_poster | bac, yeah, I won't complain | 20:18 |
| hatch | :D | 20:18 |
| bac | gary_poster: i'm not looking to cause trouble but i'm adding the format for bundles. | 20:18 |
| gary_poster | :-P | 20:18 |
| gary_poster | bac, understood. do what you will. :-) I doubt the previous decision was deeply considered. | 20:19 |
| bac | rt | 20:20 |
| benji | jujugui, I need a review of a simple charmworld branch: https://codereview.appspot.com/19430043 | 20:23 |
| hatch | I'll do it | 20:31 |
| bac | has the juju-gui test suite gotten faster or is it me? i'm seeing test runs under 30 seconds now for test-debug | 20:31 |
| bac | i did upgrade to mavericks and fusion 6 | 20:32 |
| gary_poster | bac, it's you. you are getting faster. | 20:32 |
| hatch | benji: yeah I don't know enough of this stuff to say weather this is good or not :) | 20:34 |
| hatch | to me it looks like the routes are backwards :D | 20:34 |
| * benji looks | 20:34 | |
| hatch | smaller routes should hit first....but maybe not in python land? | 20:34 |
| benji | hatch: I believe it is order-sensitive, not length-sensitive | 20:36 |
| benji | since the tests pass (and the new test didn't before the code was changed) I'm pretty sure it is right now | 20:37 |
| hatch | intersting - I would have thought to switch the top two with the bottom two - must be a difference with the libs | 20:37 |
| benji | I did notice I duplicated a test that I shouldn't have, so fixing that | 20:37 |
| hatch | jujugui could I get a quick review/qa on https://codereview.appspot.com/18630045/ plz | 20:42 |
| gary_poster | hatch I think I made all the kanban cards we talked about. Please doublecheck | 20:42 |
| hatch | cool | 20:42 |
| gary_poster | I will take the review if no one else steps up, but trying to finish an email otherwise | 20:42 |
| hatch | gary_poster: re promises """hatch, so... I just merged a pull request that makes promises log errors when no handlers were added to it""" | 20:43 |
| gary_poster | hatch, !! | 20:43 |
| gary_poster | hatch, that's no handlers :-/ | 20:44 |
| gary_poster | not enough | 20:44 |
| gary_poster | agree? | 20:44 |
| hatch | right | 20:44 |
| hatch | done() is also in the pipeline | 20:44 |
| gary_poster | oh, cool | 20:44 |
| hatch | none of this will be available until the next version of YUI anyways | 20:44 |
| hatch | but I'm happy to know that it's actually in the pipeline | 20:44 |
| gary_poster | done() would answer my most critical concerns. I think it might be ok with done. | 20:45 |
| gary_poster | as long as done works as I expect :-P | 20:45 |
| hatch | it still requires people to add a done() | 20:46 |
| hatch | not an implied done | 20:46 |
| hatch | but maybe I could pressure that change | 20:46 |
| gary_poster | yeah, if done() means "after all handlers I have now are called I call done with the result" then we can work with it. A default "done" that logs errors seems like what we'd require for ourselves, and reasonable for upstream. | 20:47 |
| hatch | """hatch, from what I read I thought the TC39 solution was to do some implementation magic that makes the final `then` in the chain mostly act like done """ | 20:48 |
| hatch | ^ that would be nice | 20:48 |
| bac | jujugui: i haz branch: https://codereview.appspot.com/19380044 | 20:48 |
| benji | bac: I'll take a look | 20:49 |
| bac | ty | 20:49 |
| hatch | bac: I'll review your branch | 20:50 |
| rick_h_ | gary_poster: I'm not sure on that reject urls with cs: in them card. It was there before I got over to bundles. I don't understand why we'd reject them, but don't know the history of it | 20:50 |
| bac | hatch: thanks, i see i am a bit over the 400 LOC limit | 20:51 |
| hatch | yeah, now you owe me a beer | 20:51 |
| hatch | sorry, house rules | 20:51 |
| rick_h_ | gary_poster: then again, I created the card....so I *should* know. :/ | 20:51 |
| gary_poster | rick_h_, :-) | 20:51 |
| rick_h_ | gary_poster: so no...I think the card can go away. It goes back to april?! | 20:52 |
| gary_poster | rick_h_, ok I'm going to delete. neither of us can make sense of it. you and marco have thought a lot about proof, and this sounds like proofy things. Deletingf | 20:52 |
| rick_h_ | gary_poster: I didn't know wtf a bundle was in april and it seems really out of date now | 20:52 |
| gary_poster | rick_h_, :-) cool thank you | 20:52 |
| gary_poster | hatch did anyone ever take your branch? | 20:53 |
| hatch | dont' think so | 20:53 |
| gary_poster | bac, ^^^ ? | 20:53 |
| gary_poster | bac, I will tak if you can't | 20:54 |
| gary_poster | take | 20:54 |
| bac | gary_poster: oh, i thought you had | 20:54 |
| gary_poster | nope | 20:54 |
| bac | ok | 20:54 |
| gary_poster | trying to write an email | 20:54 |
| bac | hatch: your rietveld had chunky mismatches | 20:55 |
| hatch | boooo | 20:56 |
| hatch | if you view the inline diff it works | 20:57 |
| hatch | that's clicking on the path | 20:57 |
| hatch | bac: review/qa done | 21:08 |
| bac | thanks! | 21:08 |
| * gary_poster steps out. Night, all! | 21:11 | |
| hatch | have a good one! | 21:12 |
| bac | hatch: done. | 21:13 |
| bac | QA was fine | 21:13 |
| bac | suggested some text changes | 21:13 |
| hatch | thanks! | 21:13 |
| hatch | bac: so you updated to mavericks? any issues? | 21:38 |
| bac | hatch: no, just that my test runner is super speedy | 21:54 |
| bac | hatch: beware of the icloud keychain stuff! | 21:54 |
| hatch | yeah I don't use any of Apple's cloud stuff | 21:54 |
| hatch | morning huwshimi | 21:57 |
| huwshimi | Morning | 21:57 |
| huwshimi | hatch: Morning! | 21:58 |
| hatch | huwshimi: so I landed all your branches except one and then created and assigned two new tickets to you which were releated to those branches | 21:58 |
| huwshimi | hatch: Oh great, thanks! | 21:59 |
| antdillon | Worked out quitting dropbox frees up alot of watchers :) | 22:01 |
| hatch | haha yes it would | 22:02 |
| huwshimi | hatch: For bug #1246109 were you at the default zoom level in your browser? | 22:02 |
| _mup_ | Bug #1246109: 'Drop here' sprite on canvas has extra pixels bleeding in <juju-gui:New for huwshimi> <https://launchpad.net/bugs/1246109> | 22:02 |
| hatch | damnit... | 22:03 |
| hatch | I thought everything looked to clean | 22:03 |
| hatch | lol | 22:03 |
| hatch | sorry :) | 22:03 |
| huwshimi | hatch: It's all good :) | 22:05 |
| huwshimi | hatch: I'll mark it as invalid then :) | 22:06 |
| hatch | plz do | 22:06 |
| bac | hi huwshimi, make it home ok? | 22:13 |
| hatch | either that or he is very determined to get his work done ;) | 22:17 |
| huwshimi | bac: Yeah. Eventually! | 22:23 |
| hatch | did you ride on the new fancy plane again? | 22:27 |
| huwshimi | hatch: Yep. | 22:28 |
| hatch | saweeeeeet | 22:29 |
| huwshimi | hatch: I really notice how much louder other planes are now. | 22:30 |
| hatch | right? :D see I told ya haha | 22:30 |
| antdillon | hatch, Hey, I've fixed the linkify tests when you get a min | 22:31 |
| hatch | antdillon: woah working late today? :) | 22:31 |
| antdillon | hatch, Got 12 mailers to make tomorrow .... Wanna tidy up as much as I can before I enter that world of pain | 22:32 |
| hatch | oh cool so you do design work too? | 22:34 |
| hatch | and I'll get to your branch when I can tonight, it's EOD in 30mins but I want to get my current branch up for review regardless first | 22:34 |
| hatch | thanks for working late on it :) | 22:37 |
| antdillon | No prob, just working on improving the regex for links | 22:43 |
| hatch | good luck | 22:45 |
| hatch | as I'm sure you've seen, a url is very complex :) | 22:45 |
| hatch | so usually less is more in that case | 22:45 |
| antdillon | hatch, Yeah trying to keep in simple but found a case the it doesnt work | 22:48 |
| hatch | ahh so should I hold off on landing it then? | 22:48 |
| antdillon | hatch, Yeah can we, sorry just spotted it | 22:48 |
| hatch | no problem at all | 22:49 |
| hatch | rick_h__: FYI the filming for 22 Jump Street (sequel for 21 jump street) is in Regina Saskatchewan lol | 22:57 |
| hatch | jujugui looking for a review/qa whenever anyone gets a chance https://codereview.appspot.com/19570043/ | 23:15 |
| huwshimi | hatch: Do you remember why we needed to include yui3-skin-sam? | 23:46 |
| hatch | huwshimi: it used to be the tabview | 23:46 |
| hatch | not sure if that's still true | 23:46 |
| hatch | would looooove to remove it though | 23:46 |
| huwshimi | hatch: I was going to take a look at removing it... | 23:47 |
| huwshimi | hatch: It looks like we use it in a few places actually. I'll see what I can do. | 23:48 |
| huwshimi | hatch: Also, do we need to manually update the sprite.png on comingsoon? | 23:49 |
| hatch | it should be rebuilt automatically | 23:49 |
| hatch | might need someone to kick it | 23:49 |
| hatch | I think gary and brad have access | 23:49 |
| huwshimi | hatch: Ah well, was going to check how much that improved things. Not to worry. | 23:50 |
| huwshimi | hatch: We've already gone from 210KB of CSS down to 105KB and 270KB of sprites down to 50KB | 23:54 |
| hatch | haha awww yeah! | 23:54 |
| huwshimi | hatch: I'd like to take a look at speeding up our CSS selectors at some stage too, to improve the speed the CSS renders. | 23:55 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!