/srv/irclogs.ubuntu.com/2013/11/01/#juju-gui.txt

rick_h_benji: yea, it'll work. It just breaks things like storing a value with a '.' in it and then trying to query it back out01:03
gary_posterhey huwshimi.  how you. :-)01:48
huwshimigary_poster: Hey. Good. Doing QA :)01:49
gary_posterCool!  Thanks huwshimi.  Things looking OK?01:50
huwshimigary_poster: Yep, hit something small...01:50
gary_posterCool.  We're hoping to make a release early next week so it would be great if we were in good shape01:51
huwshimigary_poster: I've only just started, but things look pretty reasonable.01:51
huwshimigary_poster: Certainly  looks like the highest level of polish across the board that we've ever had.01:52
gary_posterAwesome. :-) huwshimi, I'm sorry I didn't call you this evening.  I talked with everyone else this week to ask if they had any post-sprint thoughts and if we ought to consider anything about ye olde yearly goals (https://docs.google.com/a/canonical.com/document/d/1hzcQ40d-z_xC0x62uc7o1uQR16NjIM3itF5XW8MtJkw/edit).  It looks to me like we are doing quite well with your goals.  Would you like to schedule a call on you01:57
gary_posterr Tuesday morning next week to talk about these things, or is everything ok, or...? :-)01:57
gary_poster(if everything is ok then we'll just wait till next week)01:57
huwshimigary_poster: I think things are going fine. I don't have any questions/concerns about goals, at least not from my end :)02:00
gary_posterheh, cool huwshimi 02:00
gary_posterok, have a great weekend and talk to you next week. :-)02:00
huwshimigary_poster: Thanks Gary, have a good evening and weekend :)02:00
gary_posterthanks :-)02:01
marcoceppirick_h_: I put charm-tools 1.1.0 on pypi for you ;)03:08
marcoceppirick_h_: that being said, 1.1.0 is "released" just waiting for the builders to finish03:09
marcoceppihow do you guys usually install it? from package or tarbal?03:09
=== rogpeppe1 is now known as rogpeppe
rick_h_marcoceppi: you rick!11:15
rick_h_marcoceppi: if it's on pypi we'll pull it downinto a download-cache so we can install it sans internet and such with a lock version11:16
rick_h_marcoceppi: I think last time we did a custom python package build and stuck it in there, so we just have to update it with the new .tar.gz11:16
gary_posterrick_h_, "you rick!" ? :-)12:05
rick_h_gary_poster: lol too early in the morning 12:05
gary_poster:-)12:05
rick_h_marcoceppi: there's more rocking than 'ricking' in that ^^12:05
rick_h_at least they keys are next to each other12:05
rick_h_I wasn't that nuts this morning12:05
gary_posterhey bac, when you are adding the basket name to search, could you double check that we include bundle charm names as search terms too?  If we don't do that now and it is easy to add that at the same time, please add it; if it is not that easy we can have a separate card.12:10
gary_posterBradCrittenden, ^^^12:11
rick_h_bundle charm names? The names of the charms inside the bundle?12:11
gary_posterrick_h_, yes12:12
BradCrittendengary_poster: yeah i'm pretty sure we do that12:24
BradCrittendenat least we have a test for it12:24
=== BradCrittenden is now known as bac
rick_h_gary_poster: bac yea http://comingsoon.jujucharms.com/sidebar/search/:flags:/charmworldv3/?text=mysql pulls upt he wiki/wordpress bundles12:26
rick_h_even though the search was for wordpress12:26
rick_h_err, mysql12:26
gary_posterbac, rick_h_ awesome, thanks12:26
gary_posteranother card bites the dust ;-)12:27
marcoceppirick_h_: YOU RICK AND ROLL!12:42
rick_h_marcoceppi: hah, tried not to go there12:43
marcoceppiit is early here12:43
gary_posterlol12:53
* gary_poster out for a bit13:09
bacjujugui: one review/qa please of https://codereview.appspot.com/20780043/ -- note QA instructions in follow-on email.13:10
bachey rick_h_, any free time to do the above review.  it is for the bug you filed!  :)  (very short too)13:26
rick_h_bac: yea, just in deep atm. Can look in a few. 13:26
bacthanks13:26
hatchso how was halloween for everyone?14:06
gary_postergood14:06
hatchwe only had 2 groups of kids haha14:06
hatchit started raining14:06
hatchand kids these days are weak!14:06
rick_h_bac: starting review/qa now, relations are freaking mind melting14:14
hatchfinally someone else who had to deal with them :P14:18
rick_h_hatch: rain didn't hurt too much http://www.flickr.com/photos/7508761@N03/10601718093/ they still bussed (literally) people in to the neighborhood. Later pics show the street just lining up with cars from outside the neighborhood. There's usually NO cars on the street14:20
hatchdo you live outside the city?14:20
rick_h_no, I live inside a small-ish town14:20
rick_h_in a sub division14:21
hatchohh - I was gona say....driving? lol14:21
hatchThe only time we drove was to get to family and friends who were on the other side of the city14:22
rick_h_benji: can you do qa on bac's branch please? My virtualenv is all out of date now witht he new deployer stuff I was working on14:22
hatchcould usually get more than enough candy within the neighbourhood14:23
* rick_h_ finds the downside of colo14:23
benjirick_h_: sure, which branch is it?14:23
rick_h_benji: lp:~bac/charmworld/bug-1246459 14:23
rick_h_benji: from https://codereview.appspot.com/20780043/14:23
rick_h_benji: thanks!14:23
benjinp14:23
rick_h_hatch: yea, we always run out so got $100 of candy this year and went through 3/4 of it. Without the rain I think I would have gotten closer to going through it all14:24
hatchwell with people bussing their kids in no kiddin14:24
hatchg14:24
hatchdid they at least say 'trick or treat' ?14:25
hatchor just ring the doorbell14:25
* hatch doesn't give candy to kids who just ring the doorbell14:25
rick_h_yea, scond year we got a limo, only this time it was a limo bus vs a limo car14:25
rick_h_yea, most say it, some have to be forced to say it. I ignore kids that come up to me and just hold out their pillow case14:25
hatchhaha yup14:25
hatchFYI you CAN just do a trick :)14:25
BradCrittendenhi rick_h_, thanks for the review.  as to the scoring question, i guess they can be reversed.  that just affects the order the results are shown, right?14:27
=== BradCrittenden is now known as bac
rick_h_bac: right14:27
bacrick_h_: i'll do it then14:27
rick_h_bac: thanks, I think it'll give better results that way14:27
bacrick_h_: qa ok?14:36
rick_h_bac: benji is doing qa. I've updated my colo-virtualenv a bit and makes it hard for me to qa 14:37
hatchthe windows 'tile' for the store always says I have updates, but when I open it, nothing....14:43
hatchit's probably a conspiracy14:44
* rick_h_ shakes fist at "old chunk mismatch"!!!!!!!!!!!14:46
rick_h_go through all of lbox for a pretty side by side review of my code and get nadda14:46
hatchrick_h_: well it also gives the rest of us peace of mind knowing that something else has 'reviewed' your code before we have to :P14:50
gary_posterjujugui call in 1014:50
rick_h_heh, I like to do that so "I" can review it before I ask everyone else to. -wip ftw14:50
rick_h_and help me find bits missing tests/etc14:50
hatchso when I try to do `make test-debug &` it breaks out of the background when the node process hits14:51
hatchI'm guessing I'm missing something?14:52
gary_posterjujugui call in 214:58
bacha, the cool ones are already there14:58
benjijujugui: I have a charmworld branch up for review that adds metrics tracking infrastructure (a model and source): https://codereview.appspot.com/2082004315:08
bacbenji: did you do the qa on my branch?  i'll review yours.15:09
benjibac: the injest is still running15:09
bacbenji: oh, you didn't change the limit to 10.15:09
benjibac: I ran the commands you put in the RV; you should have included rm -rf /15:10
bacoopsie15:10
jcastrohey gary_poster15:12
jcastrofor mediawiki you basically want me to cat the two files together15:12
jcastroand call it "mediawiki"15:12
gary_posterhey jcastro on call15:12
jcastrobut the environment names are like "mediawiki-simple", "mediawiki-scalable" and so on15:13
* jcastro nods15:13
gary_posterjcastro, can scalable inherit simple?15:13
jcastroI don't know anything about how inheritance works in bundles15:16
jcastroI know how to shift-d is about it, heh15:16
benjiarg, the ingest still isn't done; I guess I'll start again with a limit15:27
gary_posterjcastro, see http://bazaar.launchpad.net/~juju-deployers/juju-deployer/trunk/view/head:/configs/blog.yaml15:28
rick_h_gary_poster: yea, we ingest with inheritence, but I wasn't aware of it until recently. I'm not sure how that'll proof. That requires pulling in the deployer config stuff I think.15:28
gary_posterrick_h_, uh-oh15:28
* rick_h_ needs more test cases/examples ugh15:28
gary_posterrick_h_, could you confer with brad or benji on that?  they know where the inheritance bidies are buried15:29
rick_h_gary_poster: yea, that's the functionality we used the deployer for before that changed so much I copied it out to move forward. 15:29
gary_posterbodies15:29
rick_h_gary_poster: yep, will do. 15:29
gary_posterthanks15:29
benjiI would suspect proofing after inheritence would be the way to go.15:30
rick_h_benji: yea, since this just came up yesterday that's been my take and part of the trail of XXX: but worth a real bug to make sure proof supports inheritence15:30
benjiyeah, the proof tool needs to support inheritence because it will be given those kinds of deployer files to process, we won't have those though, so we should proof what actually gets stored in the DB15:31
rick_h_so jcastro, forget you heard about inheritence for a few days :)15:31
jcastrook so should I keep them seperate for now?15:32
jcastroI need to version them still though15:32
jcastrowant me to do that now?15:32
rick_h_version the services?15:33
gary_posterthe charms.  Yes please jcastro.  also, note that we display your branch name and the bundle name in the GUI, so that might affect how you name things15:40
gary_posterfor example15:41
gary_postersee http://comingsoon.jujucharms.com/sidebar/search/:flags:/charmworldv3/?text=jorge15:41
gary_posterwe could make those names smaller I suspect15:41
jcastroyou mean on the left?15:41
gary_posteryeah15:42
hatchjcastro: on Tuesday I'm going to be doing a demo of juju/GUI on my laptop what's a good collection of charms to deploy that will illustrate it's awesomeness the best?15:46
jcastrohatch, what's the audience?15:47
hatchhttp://www.prairiedevcon.com/15:47
hatchit's a windows slanted conference15:47
hatchbut mostly developers15:47
hatchI'll be sure to mention that it works on Azure & windows but it's definitely being demo'd on Ubuntu :)15:48
benjibac: QA looks good; I only got one result for the search "muletrain" (the expected bundle)15:48
jcastrohatch, dude, do the rails charm on azure15:49
jcastrothat would be epic15:49
bacbenji: cool.15:49
bacmy goal is to now right a proper muletrain bundle.15:49
hatchI know nothing of azure or rails haha, not sure I want to do that live15:49
jcastroso do what you know15:50
jcastroghost?15:50
jcastrorick_h_, ok versioned things pushed15:50
jcastrorick_h_, how can I test the bundle from the store itself15:51
hatchjcastro: I was thinking of doing it on lxc since it'll be at a conference I'm not sure how reliable the internet will be15:51
hatchand relying on hotspot probably isn't wise either15:51
jcastrolike If I wanted to deploy what's in the store in 15 minutes15:51
bacrick_h_: you didn't use the magic LGTM on my review15:51
bacrick_h_: found here https://codereview.appspot.com/20780043/15:52
bacit is all sad and ungreen15:52
bacand rv-submit hates it15:52
jcastrohatch, have something fired up and GUIed, the show it, then be like "ok, but our internet is flaky, so let's move locally"15:52
jcastrothen juju switch and show the same stack running on LXC.15:53
hatchoh that's cool15:53
jcastroyeah15:53
hatchI could do an apache/wordpress/haproxy/mysql deployment?15:53
rick_h_bac: because I was waiting for QA to do it15:54
rick_h_that's benji's job :P15:54
jcastroand then you say "Same deployment, on my cloud and on my laptop." and go right into rick's spiel on how you guys can fire things up easily and test just like you would on a real deployment15:54
jcastroif internet is fine just switch back and forth15:54
bacrick_h_, benji would one of you fine people approve my review?15:54
benjibac: sure15:54
jcastroyou want to show how you can do the same thing on any substrate15:54
rick_h_did qa get an ok? oh /me missed his irc omment15:55
benjibac: done15:55
bacty15:55
rick_h_jcastro: "test the bundle from the store itself"? you mean find it and deploy it on comingsoon?15:55
hatchjcastro: good idea thanks15:55
rick_h_jcastro: http://comingsoon.jujucharms.com/:flags:/charmworldv3/ search, hit deploy15:55
jcastrorick_h_, I mean deployed for real. or do I wait for the gui to land to do that, then deploy on the real thing?15:57
jcastrorick_h_, I think I'm asking chicken/egg.15:57
jcastrolet's say I want to test the bundles I am submitting15:57
rick_h_jcastro: you can use the deployer or the quickstart tool from the email that gary_poster sent out yesterday15:57
jcastrooh dude, the alpha quickstart one, totally missed it, thanks!15:58
gary_posterrick_h_, jcastro the version in the PPA only supports downloaded files.  URLs are in trunk but not in PPA yet, sorry :-/.  Next week15:58
jcastroyeah that's fine15:59
gary_posterdownloaded bundle files I mean15:59
gary_postercool15:59
rick_h_gary_poster: right, but jcastro can test his bundle file works locally15:59
jcastroI just didn't want to only test on deployer15:59
gary_posteroh, definitely15:59
rick_h_to lxc or aws or anything15:59
jcastroI am not worried about the bundle not working from my local file15:59
jcastroI am worried about testing it from the store15:59
gary_posteryeah, that's a great test because it uses the GUI charm to deploy15:59
gary_posterso it works in quickstart15:59
gary_posterthen you are testing the GUI15:59
gary_posterin one command15:59
hatchMakyo: did you see that bug come in about upgrade charm?16:03
hatchis that a gui or charmworld issue?16:04
Makyohatch, Both?16:05
Makyohatch, charmworld doesn't give us a list of downgradeable versions, though we do have revision info.16:06
MakyoWe could request against each version but that'd be dumb.16:06
hatchohh ok -16:06
hatchfor example precise/mysql-27/ shows me rev 28 no matter what16:06
Makyonon-linear charm versions is interesting, though.16:07
Makyohatch, I believe you get latest no matter what.16:07
MakyoThat was the backfilling, I believe.16:07
hatchok so the 'links' to show those versions is.....useless?16:07
MakyoUntil we move to api v3 I think16:07
rick_h_yep, api3 supports versioned charms as part of the bundle work16:08
hatchahh ok cool16:08
MakyoI can't really afford to switch right now, hatch.  That answer most concerns?16:08
hatchMakyo: yep that points me in the right direction16:09
hatchthanks16:09
MakyoCool16:09
hatchyeah mysql jumps from 22 to 28 which is odd I suppose :)16:13
jcastrowow gary_poster16:16
jcastrothis plugin is my new god16:16
gary_posterjcastro, lol awesome16:16
jcastrogary_poster, where do I file bugs?16:17
gary_posterjcastro, https://bugs.launchpad.net/juju-quickstart/+filebug16:18
jcastrohow is the bootstrap so fast?16:18
rick_h_:)16:18
gary_posterjcastro, getting the GUI up via the API means that we don't have to wait on downloading the charm to your local system and uploading it to the environment--it just goes straight from the charm store to the environment without a middleman; getting it up on machine 0 simply means we don't have to wait on another machine, but that's probably something you already do16:20
jcastroman, that is a thing of beauty16:20
jcastroI'm going to start filing bugs even though you mention the limitations in your mail so we can track them, is that cool? 16:21
gary_poster+1 thanks jcastro16:21
jcastroman, it's deploying the bundle16:24
jcastroawesome.16:24
jcastrodude, THANK YOU for putting the gui password in the console too16:24
jcastrothat is perfect16:24
jcastrook so the one thing I can't do is ... juju-quickstart <remote URL>, that's what's coming next week16:25
gary_posterright16:25
gary_posterwe will auto-log-you-in soon, too, and have the GUI tell you where to find your password in the future, or to just use quickstart again to open the GUI in this environment, so you don't have to look at the console16:26
hatchso with the upgrade charm details, do we want to open up the charm browser? or open it in the inspector breakout?16:32
MakyoFinally got this. Man, SVG scaling is weird. I can never remember when I need to take the scale into account.16:42
MakyoTest, then propose.16:43
hatchhmm huw found quite the bug with this linking issue16:51
hatchrick_h_: got a second?16:56
rick_h_hatch: yea16:57
hatchI THINK I found a browser routing bug...but not sure16:57
hatchsteps are16:57
hatchhttp://comingsoon.jujucharms.com/:flags:/charmworldv3/16:57
hatchdeploy mysql16:57
hatchclick 'upgrade service'16:58
hatchclick mysql-2716:58
hatch(it should open the browser)16:58
hatchclick the X in the browser details page16:58
hatchclick mysql-27 in the inspector again16:58
hatchnote the # in the url now16:58
rick_h_hatch: yea16:58
MakyoCute.  HaaS (hugs as a service) http://www.nowcheerup.me/  How would one charm a hug?16:59
rick_h_hatch: sec16:59
rick_h_hatch: I don't have time to go through it but I can walk you through what to check17:00
rick_h_hatch: hangout?17:00
hatchsure link?17:00
rick_h_https://plus.google.com/hangouts/_/72cpj09acjl4ip5f6bjgt8fkqg?hl=en17:00
bacbenji: after LP noticed your LGTM rv-submit was happy.  so the process is working as we'd hoped.17:04
benjibac: cool17:12
benjibac: how goes the review of https://codereview.appspot.com/20820043 ?17:15
hatchrick_h_: thought you'd find this interesting....viewNavigate is not being fired to open the panel :)17:16
hatchI think some of our routing code has become self aware17:16
rick_h_hatch: well then there's your problem. :)17:16
rick_h_hatch: so it's not updating _viewState in a sane way then I bet17:17
hatchthat's probably exactly it17:17
rick_h_hatch: so will be curious to see how _viewState is getting updated and such17:17
rick_h_what values it ends up with17:17
rick_h_hatch: but it makes sense, that version of the View isn't tied to the subapp/browser.js17:17
rick_h_hatch: I mean that the inspector isn't tied to the browser state like that. /me is trying to think but brain is fried17:18
hatchyeah that's fine I'll keep tracking it down17:18
rick_h_hatch: yea, I mean there's still something sticknig it in the hash17:18
hatchthe ie redirect is happening before that i've found17:19
hatchso this is a separate bug17:19
rick_h_hatch: the other thing to drop a debugger into is the sidebar: function in browser.js to check the request to see if the routing is passing it in as a hash then and we're picking it up17:19
rick_h_hatch: ok, yea, if that's not using the viewNavigate i wonder if it's just something where YUI isn't blocking the <a> for IE17:19
rick_h_hatch: it might just be a simple case of that the inspector needs to catch upgrade <a> clicks and do a manual navigate change 17:20
hatchyeah i'm going to hope that I can restore the pjax functionality17:20
hatchi'd rather not fire events all around17:20
rick_h_yea, true17:20
hatchok sidebar is not being called17:21
rick_h_hatch: the details view can't open without it being called :/17:22
hatchthe details view is rendered via 'renderEditorial' right?17:22
hatch(it's also not being called)17:22
rick_h_hatch: no, it's from sidebar17:23
hatchwhat in the....17:23
rick_h_benji: got a few min?17:23
benjirick_h_: sure17:23
rick_h_benji: https://plus.google.com/hangouts/_/72cpin08id5me7l01r1rnplpgg?hl=en17:24
hatchgary_poster: did you ever figure out why chrome wasn't catching your debugger statements?17:27
hatchI'm running into the same issue right now17:27
rick_h_hatch: you don't have them turned 'off' by change?17:29
rick_h_chance?17:29
hatchI wish17:29
hatchhaha17:29
rick_h_ok, just checking. It's the only way I know to stop them17:29
rick_h_well, and the dev tools are open?17:29
* rick_h_ ducks17:29
hatchlol17:29
hatchI have a debugger in routeDefault in browser.js and it's loading without stopping17:30
hatchthat's not even possible.....17:30
hatchhad to restart chrome17:30
hatchworking now17:30
rick_h_so it's connected to the window? Or did you split the debugger/window?17:30
rick_h_oh, cool17:30
gary_posterhatch on call sorry17:31
hatchno problem, a reboot fixed it17:32
gary_posterso...I keep thinking that, if we don't have a "ghost" stage for bundles, we need bundles to ask for configuration17:38
gary_posterThe only use case I had was openstack17:38
gary_posterwhich we were told was not a driver17:38
gary_posterbut what about passwords17:38
gary_posterwe want to have passwords and such excluded from export17:38
rick_h_yea, I've been wishing a couple of times for at least an editor window "edit this bnudle before deploying"17:38
gary_posteryeah17:39
hatchwhy is a ghost bundle stage so bad?17:39
gary_posterI'm picturing an inspector that lets you configure values that a bundle author has highlighted as needing configuration17:39
gary_posterbecause it is expensive to build and we have been told not to work on it :-)17:39
rick_h_heh, I was thinking a quick first pass is just loading the content as an editable field as yaml17:40
gary_posterhuh, could be17:40
rick_h_then hit deploy and it could validate and then go17:40
hatchhaha oh ok17:40
gary_posternot the GUI expereince though17:40
rick_h_true17:40
* gary_poster has to step away. back soon17:40
hatchI was thinking deploy the bundle as ghosts which the user can go into each service to modify17:40
hatchthen click one 'deploy all' button17:40
gary_posterthat was the original plan, yes17:40
gary_postereven that would arguably want an interface like the one I'm describing though17:41
hatchyup17:41
gary_poster"yeah, you can customize this thing, but you *really* ought to fill these out17:41
gary_poster"17:41
hatchI could see that as a logical progression from some type of form validation17:43
hatchor not...17:43
hatch:)17:43
Makyojujugui lf review/QA https://codereview.appspot.com/2087004317:50
hatchill do it17:50
hatchi need a break :)17:50
hatchMakyo: done lgtm qaok17:58
MakyoWhew~17:58
hatch8 minute review/qa turnaround17:58
hatchnot bad :P17:58
MakyoHeck yeah :D17:59
hatchI'm really getting nowhere with this routing issue18:00
rick_h_hatch: you hitting it enough to see if it's coming into the routed view handler's req object as with a hash?18:01
Makyohatch, I agree that we should introduce bounding box stuff to the real topology at some point, in another branch.  Rather than just centering the canvas, it would center and scale as with bundles.18:01
hatchrick_h_: well I've determined that it's before any of the browser stuff18:01
hatchit's definitely routing issues18:01
hatchMakyo: sounds good :)18:01
rick_h_hatch: yea, so walking through the ns-routing stuff is the fun part. Obvious chase anything with hash interactions first18:01
rick_h_someone's telling it to do it, just have to find where it's coming from18:02
hatchsometimes I really hate YUI wrapping everything for convenience18:03
hatch:)18:03
hatchI do know that it's an even listening on the body for clicks to a's18:05
hatch:)18:05
rick_h_yea, that's the app framework stuff18:05
hatchright, but setting linkSelector to '.not-an-a' should disable it18:06
benjirick_h_: I don't see any big problems with your branch (just a few lint-type things that we can address in the real review); I'm going to take a stab at a little refactoring to see if it looks like something you would want18:07
rick_h_benji: thanks, appreciate the punch-drunk sanity check18:08
hatchOoo getting closer18:09
hatch_navigate doesn't get called in IE18:09
bacbenji: in https://codereview.appspot.com/20820043/diff/1/charmworld/models.py on line 1905 how is bucket_index ever None?18:18
* benji looks18:18
hatchahah18:18
hatch!18:18
bacmaybe you're missing a test in the find method?18:18
hatchsometimes debugging the hard way gets the best results18:18
benjibac: if the increment is for a day that is so far in the past that there is no daily bucket for it18:19
benjiI will add something to that effect to the comment.18:19
bacbenji: but how?  i don't see any such logic in _find_day_offset18:19
benjibac: ooh!  you're right; there is a missing test that should have excersized that branch and pointed out the problem18:20
benjiI'll add that test and then fix.18:20
bacbenji: i'm not to the tests yet!18:20
benjiI would *really* like us to start using test coverage.  This is exactly the kind of problem it helps find.18:21
hatchrick_h_: so this bug is not at all related to the browser stuff - that's an entirely separate issue caused by pjax routing the link vs going through the navigate... just FYI18:22
rick_h_benji: I think nose is spitting out coverage already? /me goes to check makefile18:22
rick_h_hatch: yea, that's what I figured. The only way to prove it was to verify that it was happening in the req and not in our viewNavigate calls18:22
hatchit's a pretty rare sequence of events so that's why we never caught it before18:23
rick_h_rgr18:23
hatchhopefully the removal of the router stuff allows us to remove the browser url parsing18:23
benjirick_h_: I'm thinking of a very specific kind of coverage, i.e., define a set of tests that should cover a set of code and verify that the coverage is 100%18:23
rick_h_benji: ok, looks like we're not using it but nose supports using coverage.py if it's avail18:24
benjiyou can build such a thing from simple code coverage, but it takes some work (I have such a system for my termbeamer project and it is great, if a bit ridgid in its requirements)18:24
rick_h_https://nose.readthedocs.org/en/latest/plugins/cover.html18:24
hatchgoing to grab some lunch18:24
hatchbbiab18:24
rick_h_benji: yea, gotcha18:24
benjirick_h_: here is some example output: http://i.imgur.com/4KuW5WZ.jpg18:29
rick_h_benji: cool18:30
rick_h_benji: pushing up the api tests and some tweaks due to errors the tests pointed out18:37
rick_h_benji: lp:~rharding/charmworld/proof-relations18:38
bacbenji: i think it is safer to use datetime.utcnow().date() instead of datetime.date.today() given my yearning to live a tz-free existence.18:42
bacif huw were to run tests right now he'd get a different today than we would and that might break things.18:43
benjibac: I'm pretty confident that the tests will never fail do to time (but I'll give them another once-over to be sure), but I think naive dates are actually the right thing to do here, otherwise utcnow().date() might give us a day that isn't the right day 18:53
rick_h_benji: up for a follow up? I'll peek at the original notes of things to clean up and see what you think regardling reorg and try to finish up quick?18:55
benjirick_h_: I haven't written the lint-y notes yet, as I figured you might change some, but I'll be glad to do the follow-up now and include them there18:56
rick_h_benji: cool18:56
bacbenji: how could utcnow().date() not be the right date if we agree to always be in UTC?.  seems unintended date offset is more likely the other way.  but, having looked at your tests and they way you always used defined dates i agree it is unlikely.  could have problems if someone adds a test that uses current time...but i guess that's just a bad test.18:57
bacs/they way/the way/18:58
bacbenji: review done19:16
benjibac: thanks!19:17
rick_h_benji: https://codereview.appspot.com/20810043/ is up with reviewer comments. 19:19
rick_h_benji: thanks again for the help and sanity checks today19:19
benjirick_h_: my pleasure; looking now19:20
gary_posterjujugui, if anyone has any bandwidth to bring a hack home, http://paste.ubuntu.com/6343083/ makes all of jorge's non-broken bundles (that is, all but reviewboard) show up in the bundle visualization.  Makyo, I know you are making magic happen and I appreciate it, but if you apply that patch and then look at http://localhost:8888/sidebar/search/bundle/~jorge/mediawiki-scalable/4/mediawiki-scalable/:flags:/charmworldv19:44
gary_poster3/?text=jorge , you'll see the first bundle visualizatio that actually pushes a charm partially off the screen19:44
gary_posterhttp://localhost:8888/sidebar/search/bundle/~jorge/mediawiki-scalable/4/mediawiki-scalable/:flags:/charmworldv3/?text=jorge19:44
* gary_poster goes to get boys from school19:44
MakyoSomething's wonky about this bundle.19:56
MakyoThe 'contribute' command is listed as `bzr branch lp:~jorge/mediawiki-scalable/4/mediawiki-scalable` but should be `bzr branch lp:~jorge/charms/bundles/mediawiki-scalable/bundle`, and the yaml indentation is off (which may be the actual root of the problem)19:57
MakyoUh, nevermind the indentation, sorry, I'm a liar.19:58
gary_posterMakyo, the branch issue is in the GUI.  My branch fixes it20:01
gary_posterI mean, my hack :-P20:02
gary_posterjujugui, am I right in guessing that no-one took the branch?  If so, I'll get to it ASAP20:02
MakyoOh, I totally misread :(20:03
MakyoSorry :S  No, didn't pick it up.20:03
hatchgary_poster: hey sorry I can eventually, I'm just writing a repro of this IE bug to see if it's a YUI/IE issue or something in our app20:03
gary_posterMakyo, hatch, cool, np thanks, will carry it in a few20:08
hatchahah! it's a YUI bug20:18
hatchthat took way to long20:18
hatchjujugui anyone with IE10 available for a quick sanity check?20:19
MakyoYyyyyeah...just a sec.20:19
MakyoLet me start up.20:19
gary_poster:-)20:19
hatchMakyo: thanks :)20:19
hatchI just need a sanity check on this http://jsbin.com/ExoDUGIt/1/edit20:20
hatchthere is a monkey patch which, if deleted, will allow the 'rockon' url to be added to the address bar, but in chrome everything always works as expected20:20
hatchgary_poster: ok now I can do your branch above if still needed20:21
gary_posterhatch, oh, thanks, would be awesome.  Just wrote first test.  Probably need two more--one for situation of import with a yaml file that specifies a name, and *maybe* one for the small deploy tab fix I made.20:23
gary_posterLast one might be unnecessary.20:23
hatchalrighty, can you paste the new diff?20:24
gary_posteryeah, one sec20:24
Makyohatch, what am I looking for now?  URL doesn't change with or without monkey patch.20:25
MakyoOh, hmm.20:26
MakyoIE may just be lame.20:26
hatchohh it needs to be in not /edit mode sorry20:27
MakyoOh, okay20:28
gary_posterhatch, http://paste.ubuntu.com/6343329/ .  The charm id revision change may be nastier than I had hoped.  Test I wrote fails, as you'll see.  Feel free to toss it back, but I suspect you'll make short work of it.  Part of QA should be to verify that all of Jorge's working bundles now show a visualization20:29
Makyohatch, confirmed20:29
hatchMakyo: thanks :)20:29
hatchyour work here is done20:29
hatchyou may go20:29
gary_poster:-P20:30
hatchhaha20:30
* gary_poster returns to spreadsheet that he had escaped for a brief shining moment20:30
hatchok can you give me a real quick overview of what the problem/solution was20:30
benjirick_h_: I'm done with https://codereview.appspot.com/20810043/20:33
gary_posterhatch, sorry, yeah.  So, the main point of this is to make it so that Jorge's bundles actually had working bundle visualizations.20:36
gary_posterThe patch also has some unrelated text flybys on the bundle page20:36
gary_posterThe reason why the bundles were not visualizing was that they were not importing properly.  I discovered this by trying to deploy them, and getting the nice new error massages you made yesterday, hatch.20:37
gary_posterSo there were two issues.20:37
hatchsweet20:37
hatchhaha20:37
gary_posterFirst, the discourse bundle has a charm without a revision20:37
gary_posterthis caused a problem because the fake backend refused to handle it...because our charm id parser refused to handle it20:38
gary_posterI'm a little bit nervous that the change I made there will have repercussions.20:38
bacrick_h_: you have a moment for a quick call?20:39
hatchalrighty well I'll put it through its paces20:39
hatchand I'll land this wako ie fix at some point too20:39
gary_posterSecond, hatch, another bundle had an issue because it wanted to deploy mysql twice.  It turns out that the fakebackend was completely ignoring the service names in the deployer file.  It also turns out that it had a bunch of code that wasn't ever doing anything.  That's the code that I deleted in fakebackend, and replaced with just setting .name20:40
hatchhaha20:40
hatchawesome20:40
gary_posterThat's his "mediawiki-scalable" bundle, fwiw20:40
gary_posterSo those are the only two bundle-related fixes20:41
hatchsounds good20:44
marcoceppigary_poster: do you have a link to the doc from the sprint about bundles v2?20:47
gary_postermarcoceppi, https://docs.google.com/a/canonical.com/document/d/1fmlRgMoQhdwsF5w9jPApNrTM1obXHvDwuE85kx8EsbU/edit ?20:47
marcoceppigary_poster: Yes, thank you!20:47
gary_posterwelcome :-)20:48
gary_postermarcoceppi, unfortunately, we probably won't be doing that (because we have been told not to, because of other priorities :-) ).  Something I want to propose that we prioritize is that bundles gain config fields.  Before deploying, you would need to fill in, say, password fields or other bits like the ceph thing.  I think we probably need something like this eventually, but the question is importance/prioritization.20:50
gary_posterI'll be looking for opinions later20:51
gary_posterbut feel free to share now if you have any immediate ones :-)20:51
marcoceppigary_poster: oh, yeah I saw that. I just couldn't remember the word "immutable" embarrasingly enough and needed to use it. So, I know it was recorded during that session :)20:51
gary_posterheh, ok cool :-)20:51
marcoceppigary_poster: that idea starts to sound a lot like stacks at that point20:51
* marcoceppi wonders why we just don't grow bundles in to stacks20:52
* marcoceppi walks away wondering to himself20:52
hatchwhat happens with an immutable object encounters an immutable force?20:52
gary_postermarcoceppi, yeah, that's being proposed actively :-)20:52
hatch....wait that's not right... :P20:52
gary_poster<snort>20:52
marcoceppihatch: marriage? Is that the answer?20:52
hatchI'm not sure20:53
hatchthis sounds like a job for.....*spins around*......20:53
hatchHATCH MAN!20:53
rick_h_bac: sure thing, give me 2min?20:59
rick_h_benji: thanks for the review20:59
bacrick_h_: ok21:00
rick_h_bac: https://plus.google.com/hangouts/_/7acpjhgnd2ie5j8vpvbiko0b3o?hl=en21:01
* Makyo walks dogs.21:08
MakyoMay also head out a bit early today since last night was so messed up.21:08
marcoceppigreetings gui folks, there are two merges in the queue that have been here for a while. Not sure you guys were aware of it or not:  https://code.launchpad.net/~benji/charms/precise/juju-gui/fix-cache-headers/+merge/177958 and https://code.launchpad.net/~frankban/charms/precise/juju-gui/guiserver-bundles-initial/+merge/17975021:11
marcoceppiis there any action I can take on either of these?21:11
rick_h_benji: ^21:12
bacthanks rick21:12
* bac walks dog between storms (i hope)21:13
rick_h_bac: np, let me know if you need anything21:13
rick_h_and if proof gives you trouble blame marcoceppi :P21:13
* marcoceppi twiddles thumbs21:13
gary_poster:-)21:17
gary_posterjujugui, this is the new, new, new prioritized spreadsheet of possible Nov-Dec tasks for us.  We'll work down these as far as we can in the timeframe, while also responding to bugs and the like.  This is timeboxed: we get done what we get done in the time period.  https://docs.google.com/a/canonical.com/spreadsheet/ccc?key=0AtC9etoysSQldDQxMVdmTDB4dm1XXzA0NFlLSUQ4Mmc&usp=drive_web#gid=021:19
gary_posterComments welcome.  I'm sending it to mramm21:19
hatchgary_poster: you have no 'units' on your cost column21:20
hatchspreadsheet fail :P21:20
gary_posterNote I reordered some of the things from the discussion with luca, but it should look familiar21:20
gary_posterhatch :-P it is planning-poker style arbitrary units :-)21:20
hatchohhh haha gotcha21:21
gary_posterhatch that's why it says "relative" ;-)21:21
hatchiiiiiii seee now21:21
rick_h_hatch: don't try to out manager the manager :P21:21
gary_posterheh21:21
hatchhaha21:21
hatchMakyo: I found a issue with your algo for positioning bundles - view the bundle vis for mediawiki-scalable bundle - just FYI21:34
hatchI can file a bug if you don't want to look at it now :)21:35
hatchoh actually nm, this won't be an issue when we add pan/zoom21:38
Makyohatch, I thought that was the problem we were running into with gary_poster's branch? That whole bundle was busted for me.21:47
MakyoLike, most things about it.21:47
hatchMakyo: yeah sorry it's fixed now but only locally21:47
hatchso what happens is because it's to tall it doesn't fit becauseit looks like it has a padding on the canvas bottom21:48
MakyoOh, okay.21:48
MakyoYeh, probably later.  Surprise company in a few, and me, without any makeup on!21:49
hatchhaha21:49
hatchstill haven't been able to figure out a proper indention for chaining with the linter22:46
rick_h_because chaining is evil :P22:57
hatchbut but promises!23:00
* gary_poster runs away. have a great weekend everyone! If anyone has a review they need, I'll check in mail every now and then23:03
hatchyou too! I'll be proposing the branch with a bit of modifications :)23:04
gary_posterawesome23:04
=== gary_poster is now known as gary_poster|away
hatchgary_poster|away: whenever you pop back https://codereview.appspot.com/21020043/ I have added reviewer notes where things were modified from your diff23:12
hatchI'll get the IE branch proposed tonight sometime as well but now I need a break :)23:13

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!