| cjwatson | """A utility of this interface used to create _things_.""" | 02:54 |
|---|---|---|
| cjwatson | helpful comment is helpful | 02:54 |
| wgrant | cjwatson: :) | 02:58 |
| wgrant | We try. | 02:58 |
| wgrant | cjwatson: Oh, you're working on the master side of livefs things? | 02:59 |
| wgrant | cjwatson: That's about to less messy, though I'm off this week. | 02:59 |
| wgrant | about to become less messy, that is | 03:00 |
| alexhenrie | hello, is there currently an on-call reviewer? | 04:17 |
| wgrant | alexhenrie: It's a weekend, so not really. But I'm around. | 04:19 |
| alexhenrie | well if you can help me, great, and if not, no big deal. | 04:20 |
| alexhenrie | I just saw that my submission was marked "resubmit" | 04:20 |
| alexhenrie | https://code.launchpad.net/~alexhenrie24/ubuntu/saucy/lubuntu-default-settings/fix-for-1232578 | 04:20 |
| alexhenrie | I didn't get an email, and I don't see any explanation | 04:20 |
| alexhenrie | what am I supposed to do? | 04:20 |
| wgrant | alexhenrie: Hm, I think you might be a bit confused. Reviewers here review branches of the code that runs Launchpad.net, not every branch on Launchpad. But I see a comment in that merge proposal explaining the Resubmit vote. | 04:22 |
| wgrant | "Looks good to me, but can you please rebase this against lp:lubuntu-default-settings so that Lubuntu guys could take a look at this?" | 04:23 |
| alexhenrie | I'm new to Ubuntu's code submission process. where did you find that comment? | 04:24 |
| wgrant | At the URL you linked. | 04:25 |
| alexhenrie | did you have to click something to see it? | 04:26 |
| wgrant | No. | 04:26 |
| elmo | alexhenrie: https://code.launchpad.net/~alexhenrie24/ubuntu/saucy/lubuntu-default-settings/fix-for-1232578/+merge/191047 | 04:26 |
| wgrant | Oh | 04:27 |
| wgrant | I must have clicked through to the MP without thinking, sorry. | 04:27 |
| elmo | alexhenrie: the 'ready for review link | 04:27 |
| wgrant | alexhenrie: Anyway, #ubuntu-devel or a Lubuntu-related channel might be more relevant. | 04:27 |
| alexhenrie | okay thanks | 04:28 |
| alexhenrie | for now I want to concentrate on figuring out how to do what Dmitry asked | 04:28 |
| alexhenrie | I found a tutotial on this before but I can't find it now | 04:29 |
| wgrant | alexhenrie: bzr branch lp:lubuntu-default-settings; hack hack hack; bzr commit; bzr push lp:~alexhenrie24/lubuntu-default-settings/fix-for-1232578; then propose a merge using the web UI. | 04:31 |
| alexhenrie | thank you :) | 04:31 |
| alexhenrie | btw I found the page I was looking for: http://developer.ubuntu.com/packaging/html/fixing-a-bug.html | 04:34 |
| alexhenrie | okay I have another easy question | 04:42 |
| alexhenrie | was I supposed to have changed the revision from 0.35 to 0.35ubuntu1? http://bazaar.launchpad.net/~alexhenrie24/lubuntu-default-settings/fix-for-1232578/revision/263 | 04:42 |
| wgrant | alexhenrie: No, 0.35 is correct for that package. ubuntuX isn't appended to the version of some Ubuntu-native packages. | 04:45 |
| wgrant | (the ubuntuX suffix exists to disambiguate Ubuntu and Debian package versions, but it's unlikely that lubuntu-default-settings will ever be in Debian) | 04:47 |
| alexhenrie | okay so I need to edit my patch and resubmit | 04:49 |
| alexhenrie | is there anything else obviously wrong with it? | 04:49 |
| wgrant | alexhenrie: I'm no Lubuntu developer, but it looks sensible enough to me. | 04:52 |
| alexhenrie | thanks. I was just looking for errors in the commit message or whatever. | 04:57 |
| alexhenrie | I think I have it fixed now: https://code.launchpad.net/~alexhenrie24/lubuntu-default-settings/fix-for-1232578 | 04:57 |
| alexhenrie | thanks for the help! | 04:58 |
| wgrant | np | 05:02 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!