JamesTait | Good morning all; happy Use Your Common Sense Day! :-D | 09:52 |
---|---|---|
oSoMoN | nerochiaro, ping | 09:52 |
nerochiaro | oSoMoN: hey | 09:58 |
oSoMoN | nerochiaro, hey | 09:58 |
oSoMoN | nerochiaro, last week I had access to a nexus4 | 09:58 |
oSoMoN | nerochiaro, I looked into the failing autopilot test for notes-app | 09:58 |
oSoMoN | nerochiaro, never managed to reproduce the issue in several hundreds runs… | 09:59 |
nerochiaro | oSoMoN: so it might be just a jenkins issue you think ? | 09:59 |
oSoMoN | nerochiaro, Omer was able to reproduce it locally with his nexus4, so I don’t think so | 09:59 |
oSoMoN | nerochiaro, but it’s definitely a heisenbug | 10:00 |
nerochiaro | oSoMoN: that's really annoying | 10:00 |
oSoMoN | nerochiaro, while investigating the issue, I submitted https://code.launchpad.net/~osomon/notes-app/manually-create-db/+merge/193097 as a random attempt to fix it | 10:00 |
oSoMoN | nerochiaro, turns out it doesn’t fix the bug, but I still think the change is valid, would you mind taking a look? | 10:01 |
nerochiaro | oSoMoN: doing that now | 10:01 |
oSoMoN | nerochiaro, thanks | 10:01 |
nerochiaro | oSoMoN: the reason why i don't totally like that approach is that it embeds in the tests much more knowledge about the database structure than we need. by letting Qt create it we have (1) the ini file created properly by Qt, which might change between versions (2) the db structure created by the app, so if it's changed we have one less place to fix in the tests | 10:06 |
nerochiaro | oSoMoN: if the app starting and quitting isn't causing problems, i don't see why not use it to setup the tests | 10:07 |
oSoMoN | nerochiaro, I know, but on the other hand launching the app, then quitting it, then launching it again is probably not what autopilot is expecting | 10:07 |
nerochiaro | oSoMoN: i don't think it cares, it all happens before the tests are run | 10:07 |
oSoMoN | nerochiaro, an alternative would be to have a first dummy test that does nothing (but the app is started and thus the db created), and ensure this test is always run first | 10:08 |
nerochiaro | oSoMoN: that would be ok too, but it seems to me we're trying to fix a problem that is not really a problem | 10:08 |
oSoMoN | nerochiaro, yeah, maybe | 10:10 |
oSoMoN | nerochiaro, the code that finds the db file could still be simplified, I’ll see if I can extract this one into a separate MR | 10:11 |
nerochiaro | oSoMoN: if you think it's important, i can give a more in-depth review to that MR and we can change things that way. I'm not fully against it, I just dont't see the need for it, is all. | 10:11 |
oSoMoN | nerochiaro, or is there still a reason for looking the db in two different paths? | 10:11 |
oSoMoN | nerochiaro, nah you’re right, until it’s proven to be a problem, let’s keep it this way | 10:12 |
nerochiaro | oSoMoN: i don't think I wrote the code that looks in two different paths. I think when i wrote that function i was looking into just one, IIRC | 10:12 |
nerochiaro | oSoMoN: if we're sure it's always in the same place i'm happy to simplify that code | 10:13 |
gusch | tmoenicke: please review https://code.launchpad.net/~schwann/ubuntu-keyboard/keyboard-cpp-qml/+merge/193427 | 10:13 |
oSoMoN | nerochiaro, ok, I’ll go for a separate MR that simplifies that code then | 10:15 |
oSoMoN | nerochiaro, I also submitted https://code.launchpad.net/~osomon/notes-app/unskip-tests-desktop/+merge/193303, mind having a look? | 10:15 |
nerochiaro | oSoMoN: looking. i'll have an MR for you to review as well soon | 10:16 |
oSoMoN | nerochiaro, sure | 10:17 |
=== _salem is now known as salem_ | ||
nerochiaro | oSoMoN: MR to unskip tests, approved | 10:54 |
oSoMoN | nerochiaro, thanks | 10:55 |
oSoMoN | nerochiaro, I just submitted https://code.launchpad.net/~osomon/notes-app/simplify-db-lookup/+merge/193750 | 11:17 |
nerochiaro | oSoMoN: looking. can you have a go at this one instead ? https://code.launchpad.net/~amanzi-team/notes-app/notes-app-cursor-in-view/+merge/193743 | 11:54 |
oSoMoN | nerochiaro, yup | 11:54 |
oSoMoN | nerochiaro, does it fix a known bug? | 11:58 |
=== MacSlow is now known as MacSlow|lunch | ||
nerochiaro | oSoMoN: i don't think there's a report for it. essentially you can keep typing in a note and eventually you overflow the screen space and you can't see what you're typing anymore | 12:02 |
oSoMoN | nerochiaro, ok | 12:03 |
oSoMoN | nerochiaro, I need to flash the latest image before I can test, it’s gonna take a while, but I’ll test it today for sure | 12:03 |
nerochiaro | oSoMoN: no problem | 12:05 |
nerochiaro | oSoMoN: i was looking into the presentation that bill emailed everyone. it doesn't mention notes anywhere, does it mean there are no plans for notes for the next cycle ? | 12:06 |
nerochiaro | oSoMoN: actually there was a bug related (in part) to that MR i asked you to review: https://bugs.launchpad.net/notes-app/+bug/1170362 (i already linked it to the MR) | 12:16 |
ubot2 | Launchpad bug 1170362 in notes-app "[note pad] can't create a long content note" [High,In progress] | 12:16 |
nerochiaro | oSoMoN: one more thing: if i see a bug that's marked fix committed but i know the fix is in the current image, can i just mark it fix released myself (or is that something QA should do) ? | 12:17 |
gusch | nerochiaro tmoenicke I don't get the onTextChanged events from bug 1243164 | 12:19 |
ubot2 | Launchpad bug 1243164 in Ubuntu UI Toolkit "TextArea generates onTextChanged events when OSK is displayed or screen is rotated" [Undecided,New] https://launchpad.net/bugs/1243164 | 12:19 |
nerochiaro | gusch: that's really weird, how come it only happens to me ? | 12:21 |
gusch | nerochiaro: no idea, maybe test again with the latest version | 12:21 |
nerochiaro | gusch: i did already last week, but i can try again. | 12:22 |
oSoMoN | nerochiaro, do it yourself | 12:23 |
nerochiaro | oSoMoN: cool. and please see my comment on https://bugs.launchpad.net/notes-app/+bug/1190630 when you have time | 12:25 |
ubot2 | Launchpad bug 1190630 in notes-app "Autopilot tests in notes_app.tests.test_quit fail in jenkins ci" [High,In progress] | 12:25 |
=== MacSlow|lunch is now known as MacSlow | ||
nerochiaro | oSoMoN: with your MR to set up the DB in notes, it seems that i get random failures that I wasn't getting before | 13:34 |
nerochiaro | oSoMoN: on AP tests | 13:34 |
=== gusch is now known as gusch|away | ||
oSoMoN | nerochiaro, do you get those random failures on desktop? | 13:44 |
nerochiaro | oSoMoN: on device | 13:45 |
oSoMoN | nerochiaro, do you get them reliably? which tests are failing? | 13:45 |
nerochiaro | oSoMoN: no, as I mentioned they are random. sometimes it can't find the db named "notes"when trying to delete things from it, other times tests are failing for stuff like notes not being there when the tests expects them to be. | 13:46 |
nerochiaro | oSoMoN: i can't definitely say but they all seem like failures due to the db not being in the right state | 13:47 |
oSoMoN | nerochiaro, weird, I’ll run them a bunch of time locally to see if I can reproduce | 13:49 |
nerochiaro | oSoMoN: how do you run the tests these days ? I'm running them by logging in into the device, maybe that's not the correct way ? (though i don't see why not) | 13:50 |
oSoMoN | nerochiaro, phablet-test-run from your dev box | 13:51 |
nerochiaro | oSoMoN: ok, trying that way now. meeting still in 3 minutes from now or in 1h ? | 13:57 |
oSoMoN | nerochiaro, my calendar says in an hour | 13:59 |
nerochiaro | oSoMoN: it has been at 15 so far | 14:00 |
nerochiaro | oSoMoN: for the past week | 14:00 |
nerochiaro | oSoMoN: and everyone seems to be there now (except you and bill) | 14:02 |
oSoMoN | nerochiaro, joining then | 14:02 |
nerochiaro | oSoMoN: some examples of the failures: http://pastebin.ubuntu.com/6358908/ | 14:06 |
oSoMoN | nerochiaro, looks like some sort of weird db corruption, can you run `adb shell "rm -r /home/phablet/.local/share/com.ubuntu.notes"` and then run the tests again? | 14:12 |
nerochiaro | oSoMoN: the next test doesn't fail | 14:12 |
nerochiaro | oSoMoN: so it looks like sometimes the db setup fails | 14:12 |
nerochiaro | oSoMoN: and sometimes not | 14:12 |
oSoMoN | nerochiaro, so can you run the tests with "phablet-test-run -o . notes_app" and then pastebin the resulting test_results.xml? | 14:13 |
nerochiaro | oSoMoN: i'm runnin it, going to grab some food in the meantime | 14:17 |
oSoMoN | nerochiaro, I tested https://code.launchpad.net/~amanzi-team/notes-app/notes-app-cursor-in-view/+merge/193743 and reported back there | 16:33 |
=== bfiller is now known as bfiller_afk | ||
timppa | any idea why "qtmultimedia camera" does only work once? | 17:38 |
timppa | Do I need to free the camera somehow? | 17:38 |
timppa | after running my app even the Ubuntu's own camera app wont get the camera preview | 17:40 |
timppa | rebooting helps | 17:40 |
timppa | I'm on the latest trusty (r11) | 17:40 |
timppa | Here is the SDK output when the app is ran the second time: http://pastebin.com/VD0jJ1p6 | 18:04 |
danielholm | oranger, ping. you here? wanted to ask about th docviewer-app. Anything I can do to help? I want to read my course PDF:s on my tablet :P | 18:22 |
=== bfiller_afk is now known as bfiller | ||
=== salem_ is now known as _salem | ||
killer | hey , while submitting app for ubuntu center , it says to "submit your application ", It means a binary? | 21:23 |
killer | http://tinypic.com/r/2qnvzub/5 | 21:23 |
Harsh | Thanks | 21:28 |
Harsh | can you help me | 21:28 |
Harsh | any new idea | 21:29 |
Harsh | exp: Account software | 21:29 |
Harsh | Quit | 21:30 |
killer | ? | 21:41 |
randomcpp | killer, need help? | 21:52 |
killer | yes | 21:56 |
randomcpp | what's the problem? | 21:56 |
killer | Firstly can i directly submit the source code if i don't know packaging , for my proprietary app ,I read somewhere ubuntu also do packaging | 21:57 |
randomcpp | killer you need to create a click pkg | 22:01 |
randomcpp | is your app written in qml? | 22:01 |
killer | It is written in c and python | 22:01 |
randomcpp | :/ | 22:01 |
randomcpp | popey, ^^^ | 22:02 |
killer | ? | 22:03 |
randomcpp | I call the expert, I though you were creating a ubuntu touch app | 22:03 |
killer | ? | 22:09 |
Elleo | popey: submitted eyrie to the store :) | 23:45 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!